User Details
- User Since
- Aug 21 2017, 11:38 PM (350 w, 3 d)
- Availability
- Available
- IRC Nick
- cooltey
- LDAP User
- Cooltey
- MediaWiki User
- CFeng (WMF) [ Global Accounts ]
Yesterday
Wed, May 8
As discussed in the Slack/Meeting, it would be great for both apps to align the logic with the desktop visual editor -> Insert image and media -> Advanced in Media settings, and that might meet the following requirements:
If size is set as the default (220x124px), we insert it. Instead we should omit it.
If basic is chosen, do not insert basic as a parameter.
Tue, May 7
Would you be able to refresh the page by swiping it down to see if the issue still exists?
Cannot reproduce it on the latest version. Please reopen the ticket if the issue is present.
Mon, May 6
The issue is the same as this ticket: T351989 and the one I merged: The RESTBase does not handle BCP47 language code correctly.
Fri, May 3
Please use this link to download the dev APK to test.
https://drive.google.com/file/d/1KIucLuiULofrwZZ_AYR-88Lw_MpGi4sW/view?usp=drive_link
Wed, May 1
The NotificationsActivity has been using the ViewModel, which was updated in this PR: https://github.com/wikimedia/apps-android-wikipedia/pull/2872
Tue, Apr 30
Thanks for the update. I left a new comment in your PR: we prefer to use ViewModel with data handling functions. Please follow the mechanism from the recently closed Wiktionary refactoring PR.
Mon, Apr 29
This has been done in this PR: https://github.com/wikimedia/apps-android-wikipedia/pull/3752
Sat, Apr 27
Fri, Apr 26
No design signoff is required. Moving to Code Review.
Thu, Apr 25
Wed, Apr 24
The Spike is completed, and here are my findings:
Tue, Apr 23
Notice an issue, not sure if it is related to the cache.
A related ticket is created: T363279
The app is sending BCP47 language code to the endpoints:
Fri, Apr 19
The new beta has been released, please help to recheck the issue, thanks!
New beta has been released, please download the latest version of beta/production APK:
If you have trouble reproducing and testing the issue, here I can provide some steps while fixing the issue.
Thu, Apr 18
New beta has been released, please download the latest version of beta/production APK:
Wed, Apr 17
Tue, Apr 16
The onboarding screen has been updated. Please go to the GitHub PR above and download the alpha APK to see the changes.