Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T271944 [EPIC] Code modernization | |||
Open | None | T303935 Refactor ReadingList fragment(s) to use ViewModel. |
Event Timeline
I'd love to contribute to this task on weekends. To begin with, I have refactored a small part in this PR (following the guide of creating small PRs) - I have created a separate repository for fetching preview reading pages instead of using the old helper. The current logic seemed a bit hard to read so I have also simplified it to some extent. Please review this PR: https://github.com/wikimedia/apps-android-wikipedia/pull/4501.
@Dbrant @Sharvaniharan gentle reminder on this. Please go through the initial PR. If it looks good, I'd love to continue on the refactoring work
Hi @cleandroidcoder, I left a comment in your PR let me know if you need help from me, thanks!
Hi @cleandroidcoder,
Thanks for the update. I left a new comment in your PR: we prefer to use ViewModel with data handling functions. Please follow the mechanism from the recently closed Wiktionary refactoring PR.