All (or almost all) pages in plwikisource are displayed as "pending review"
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Ankry
	Mar 27 2024, 10:09 PM

Description

Steps to replicate the issue (include links if applicable):

See any page in main or Page namespace in plwikisource

What happens?:
All pages are displayed as "pending reviev:

What should have happened instead?:
Pages that were not edited (nor the templetes used by them were edited) since last review shoud be shown as reviewed (checked).

Other information (browser name/version, screenshots, etc.):

#Any attempt to review those pages gives no effect.
#The pages are shown as reviewed (checked) in history:

Probably introduced with 1.42.0-wmf.24; not observed before

Details

	Subject	Repo	Branch	Lines +/-
	Avoid left join when getting templates needing review	mediawiki/extensions/FlaggedRevs	master	+1 -1
	Avoid left join when getting templates needing review	mediawiki/extensions/FlaggedRevs	wmf/1.42.0-wmf.24	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jeena	T360156 1.42.0-wmf.24 deployment blockers
		Resolved	BUG REPORT	Ladsgroup	T361166 All (or almost all) pages in plwikisource are displayed as "pending review"

Event Timeline

Ankry created this task.Mar 27 2024, 10:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2024, 10:09 PM

Ankry updated the task description. (Show Details)Mar 27 2024, 10:10 PM

Draco_flavus subscribed.Mar 27 2024, 10:23 PM

Draco_flavus triaged this task as Unbreak Now! priority.Mar 27 2024, 10:29 PM

Wargo added parent tasks: T359529: Future of flaggedtemplates feature, T277883: Drop all low-use and unused features of FlaggedRevs to make it more maintainable.Mar 27 2024, 10:38 PM

Ladsgroup claimed this task.Mar 27 2024, 11:58 PM

Ladsgroup added a project: MediaWiki-extensions-FlaggedRevs.

Ladsgroup edited parent tasks, added: T360156: 1.42.0-wmf.24 deployment blockers; removed: T277883: Drop all low-use and unused features of FlaggedRevs to make it more maintainable, T359529: Future of flaggedtemplates feature.

Change #1015158 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Avoid left join when getting templates needing review

https://gerrit.wikimedia.org/r/1015158

gerritbot added a project: Patch-For-Review.Mar 28 2024, 12:04 AM

This was the reason:

wikiadmin2023@10.64.16.46(plwikisource)> SELECT  lt_namespace,lt_title  FROM `templatelinks` JOIN `linktarget` ON ((tl_target_id=lt_id)) LEFT JOIN `page` ON ((page_namespace = lt_namespace AND page_title = lt_title)) LEFT JOIN `flaggedpages` ON ((fp_page_id = page_id))   WHERE tl_from = 930635 AND (fp_pending_since IS NOT NULL OR fp_stable IS NULL)  ;
+--------------+--------------------------------+
| lt_namespace | lt_title                       |
+--------------+--------------------------------+
|            8 | Proofreadpage_pagenum_template |
+--------------+--------------------------------+
1 row in set (0.002 sec)

The page doesn't need review but it just doesn't show up in flaggedpages and left join makes fp_stable NULL and triggering it to show up.

In T361166#9667608, @gerritbot wrote:

Change #1015158 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Avoid left join when getting templates needing review

https://gerrit.wikimedia.org/r/1015158

Pushed the patch to mwdebug1002 and that fixed the issue in plwikisource.

Change #1015065 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@wmf/1.42.0-wmf.24] Avoid left join when getting templates needing review

https://gerrit.wikimedia.org/r/1015065

Change #1015065 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.42.0-wmf.24] Avoid left join when getting templates needing review

https://gerrit.wikimedia.org/r/1015065

matmarex subscribed.Mar 28 2024, 12:22 AM

Mentioned in SAL (#wikimedia-operations) [2024-03-28T00:23:03Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:1015065|Avoid left join when getting templates needing review (T361166)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-28T00:25:27Z] <ladsgroup@deploy1002> ladsgroup: Backport for [[gerrit:1015065|Avoid left join when getting templates needing review (T361166)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Change #1015158 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Avoid left join when getting templates needing review

https://gerrit.wikimedia.org/r/1015158

Mentioned in SAL (#wikimedia-operations) [2024-03-28T00:37:59Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:1015065|Avoid left join when getting templates needing review (T361166)]] (duration: 14m 56s)