Maniphest T362004

[ES-M2]: Create new EntitySchema "expert"
Open, Needs TriagePublic
Actions

Description

Problem:
For our users to be able to make statements that use EntitySchema values we need an "expert" that accepts EntitySchema IDs.

Example:
The expert should:

Accept EntitySchema IDs (E10)
Display the label and description of that EntitySchema

Acceptance criteria:

An expert is implemented for statements using an EntitySchema Property that accepts EntitySchema IDs and displays the label and description of that EntitySchema

Notes
Ideally, searching for EntitySchemas by label and alias would also be supported, but will be investigated and developed in a separate task.

Details

Subject	Repo	Branch	Lines +/-
Process `useApiDataType` option from expert to override datatype	mediawiki/extensions/Wikibase	master	+8 -1
Use 'datatype' parameter for 'wbparsevalue' calls if configured	wikibase/javascript-api	master	+7 -1
Add 'expert' for Entity-Schema typed properties	mediawiki/extensions/EntitySchema	master	+120 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T91505 [Epic] Adding new datatypes to Wikidata (tracking)
Open	None	T214884 [ES-M2]: [EPIC] Linking EntitySchemas in statements
Resolved	• karapayneWMDE	T332139 [ES-M2]: Create a new EntitySchema data type
Open	None	T332157 [ES-M2]: Enable new EntitySchema data type on Wikidata
Open	None	T339920 [ES-M2]: Return EntitySchema as `wikibase-entityid` through the Action API
Open	None	T362000 [ES-M2]: [EPIC] Continue development of PoC EntitySchema patch
Open	ArthurTaylor	T362004 [ES-M2]: Create new EntitySchema "expert"
Open	None	T362005 [ES-M2]: Investigate how search could work by label and aliases on the EntitySchema expert
Open	Lucas_Werkmeister_WMDE	T362955 Add support for searching EntitySchema values by ID

Event Timeline

Arian_Bozorg created this task.Apr 6 2024, 3:46 PM

Arian_Bozorg mentioned this in T362005: [ES-M2]: Investigate how search could work by label and aliases on the EntitySchema expert.Apr 6 2024, 3:53 PM

Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Apr 9 2024, 2:15 PM

Arian_Bozorg updated the task description. (Show Details)Apr 10 2024, 11:19 AM

Arian_Bozorg moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Apr 10 2024, 12:05 PM

Lucas_Werkmeister_WMDE mentioned this in T362003: [ES-M2]: Display EntitySchema-value when adding statements.Wed, Apr 17, 2:30 PM

ArthurTaylor claimed this task.Thu, Apr 18, 7:28 AM

ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.

ArthurTaylor moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.

Change #1021378 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/EntitySchema@master] Add 'expert' for Entity-Schema typed properties

https://gerrit.wikimedia.org/r/1021378

gerritbot added a project: Patch-For-Review.Thu, Apr 18, 9:02 AM

Lucas_Werkmeister_WMDE mentioned this in T362955: Add support for searching EntitySchema values by ID.Fri, Apr 19, 8:32 AM

Arian_Bozorg added a comment.Fri, Apr 19, 3:05 PM

This comment was removed by Arian_Bozorg.

ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Thu, Apr 25, 7:30 AM

ArthurTaylor removed ArthurTaylor as the assignee of this task.Tue, Apr 30, 12:35 PM

ArthurTaylor subscribed.

ArthurTaylor claimed this task.Mon, May 6, 11:39 AM

ArthurTaylor moved this task from Ready for Peer Review to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.

Tested this with the latest patches from @Lucas_Werkmeister_WMDE . It mostly works - the expert is there and does the correct search and finds results by ID - but when you click a value from the dropdown, the call to wbparsevalue fails:

curl 'http://wikidatawikidev.mediawiki.mwdd.localhost:8080/w/api.php?action=wbparsevalue&format=json&parser=wikibase-entityid&values=%1FE31&errorformat=plaintext&uselang=en&options=%7B%22lang%22%3A%22en%22%7D'

(vs. the comparable call from the Lexeme expert, which succeeds:

curl 'http://wikidatawikidev.mediawiki.mwdd.localhost:8080/w/api.php?action=wbparsevalue&format=json&parser=wikibase-entityid&values=%1FL1&errorformat=plaintext&uselang=en&options=%7B%22lang%22%3A%22en%22%7D'

I had a chat with @Jakob_WMDE about this, and we agreed a plan:

Override the ValueParser for the EntitySchema expert so that it supplies different parameters to the wbparsevalue API call:
- drop the parser parameter (which is deprecated)
- supply the datatype or property parameter
Refactor the entity schema value parser (introduced in 994206) to expect strings instead of arrays and adjust all places that call it accordingly

I'll take a look at these and update my patch.

Change #1028768 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[wikibase/javascript-api@master] Use 'datatype' parameter for 'wbparsevalue' calls if configured

https://gerrit.wikimedia.org/r/1028768

Change #1028780 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Bump Wikibase API version for EntitySchema parsevalue support

https://gerrit.wikimedia.org/r/1028780

Change #1028768 abandoned by Arthur taylor:

[wikibase/javascript-api@master] Use 'datatype' parameter for 'wbparsevalue' calls if configured

Reason:

No longer required - moved this handling to the caller in 1028780