Page MenuHomePhabricator
Create Task
Maniphest T363084

Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API
Open, Needs TriagePublic8 Estimated Story Points
Actions

Description

As per T361995 JsonBodyValidator from Mediawiki REST API is discontinued in favor of a new mechanism (T358560)

Wikibase REST API should stop using the deprecated class.

Implementation notes:

  • for each POST/PUT/PATCH/DELETE route handler
    • remove getBodyValidator
    • move any field definitions that were previously in getBodyValidator to getParamSettings
    • move content type check into parseBodyData()
    • be careful about the very "flexible" body field validation (T364440). Some type casts may be needed.
    • adjusts e2e tests according to the new expected responses
    • see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1028919 for an example
  • remove TypeValidatingJsonBodyValidator

Details

SubjectRepoBranchLines +/-
REST: Remove usage of JsonBodyValidator in AddItemStatementRouteHandlermediawiki/extensions/Wikibasemaster+20 -32
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.Apr 22 2024, 9:19 AM
ashley renamed this task from Remove usege of Mediawiki's JsonBodyValidator from Wikibase REST API to Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API.Apr 22 2024, 8:08 PM
Ifrahkhanyaree_WMDE moved this task from Incoming tickets outside WPP to Backlog on the Wikibase Product Platform Team WPP board.Apr 23 2024, 8:09 AM
Ifrahkhanyaree_WMDE moved this task from Backlog to Polished on the Wikibase Product Platform Team WPP board.Apr 23 2024, 8:48 AM
gerritbot added a comment.Wed, May 8, 3:58 AM

Change #1028919 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in AddItemStatementRouteHandler

https://gerrit.wikimedia.org/r/1028919

gerritbot added a project: Patch-For-Review.Wed, May 8, 3:58 AM
Jakob_WMDE updated the task description. (Show Details)Wed, May 8, 7:25 AM
Ifrahkhanyaree_WMDE set the point value for this task to 8.Wed, May 15, 10:23 AM
Ifrahkhanyaree_WMDE moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL