Page MenuHomePhabricator

Do not show Response statistics tab in the case of no participant questions being enabled
Closed, ResolvedPublic

Description

Given an event has ended and the final aggregation has occurred

When there are no participant questions enabled, and there have never been participant questions enabled, the response statistics tab displays the following message: This event has no responses from participants to aggregate. Which is accurate, but also more correct is that there were never any participant questions enabled.

no reponses from participants, but actually no questions have been enabled.png (864×1 px, 116 KB)


Given an event has ended and the final aggregation has occurred

When there are no participant questions enabled, but the participant questions were previously enabled and participants recorded their answers but then the organizer removed all participant questions, the Response statistics tab displays the following message: Participants' responses will be aggregated and made available here shortly. This is inaccurate as the final aggregation has already occurred and there are no questions enabled to be aggregated ( though there were questions enabled and answered previously ).

participants answered questions but then questions were deleted before final aggregation.png (998×1 px, 141 KB)

Acceptance criteria
Do not show Response statistics tab in the case of no participant questions being enabled.
This should occur in all scenarios where there are no participant questions enabled, including 1. if there were never any questions enabled, 2. if questions were created and then answered and then removed, and 3. if questions were enabled answered aggregated after 90 days and then removed.

Event Timeline

@vaughnwalters For the first message/scenario we agreed to show that message rather than not showing the tab at all here T341341, though I can't find the reason for that. Perhaps @Daimona knows.
I don't think we should change it unless we know the reason for the previous decision.

For the 2nd scenario i think we can use the same message:
"This event has no responses from participants to aggregate"

@vaughnwalters For the first message/scenario we agreed to show that message rather than not showing the tab at all here T341341, though I can't find the reason for that. Perhaps @Daimona knows.

I think we did that for better discoverability of the stats tab, but I'm not 100% sure. However, we didn't consider the scenario of an event not having any questions enabled, because at the time every event would have all questions enabled; it was just for the case of there not being any answers.

Eng - Design Meeting
For the first scenario, where no questions are enabled by the organizer from the start we can decide not to show the Response statistics tab

Eng - Design Meeting
For the first scenario, where no questions are enabled by the organizer from the start we can decide not to show the Response statistics tab

Same for when the questions were added and then removed

vaughnwalters renamed this task from Display correct message in Response statistics tab in the case of no participant questions being enabled to Do not show Response statistics tab in the case of no participant questions being enabled.Wed, Apr 24, 3:33 PM
vaughnwalters updated the task description. (Show Details)
vaughnwalters updated the task description. (Show Details)

Given an event has ended and the final aggregation has occurred
When there are no participant questions enabled, but the participant questions were previously enabled and participants recorded their answers but then the organizer removed all participant questions, the Response statistics tab displays the following message: Participants' responses will be aggregated and made available here shortly. This is inaccurate as the final aggregation has already occurred and there are no questions enabled to be aggregated ( though there were questions enabled and answered previously ).

I cannot reproduce this. I do get this behaviour, but only before the "final aggregation" has run. Once that happens (and the redundant answers get deleted), I get the same message as the scenario #1.

Still, that doesn't change the AC -- the tab shouldn't be shown at all.

Change #1023887 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] SpecialEventDetails: do not show stats tab if no questions are enabled

https://gerrit.wikimedia.org/r/1023887

Change #1023887 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] SpecialEventDetails: do not show stats tab if no questions are enabled

https://gerrit.wikimedia.org/r/1023887

✅ Do not show Response statistics tab in the case of no participant questions being enabled.

This should occur in all scenarios where there are no participant questions enabled, including
✅ 1. if there were never any questions enabled,

Screenshot 2024-04-29 at 2.40.00 PM.png (1×1 px, 193 KB)

✅ 2. if questions were created and then answered and then removed
Screenshot 2024-04-29 at 2.47.12 PM.png (1×1 px, 219 KB)

✅ 3. if questions were enabled answered aggregated after 90 days and then removed.
Screenshot 2024-04-29 at 2.55.57 PM.png (1×1 px, 209 KB)

These cases are all functioning correctly now. Marking as done / resolved