Page MenuHomePhabricator

Remove unused import code from main codebase
Closed, ResolvedPublic

Description

We have some functionality in the old import classes than I'm 99% sure is unused

  1. adding tags to contacts (based on the 'Tags` column in the spreadsheet - no evidence of this having been used in living memory, no evidence of any bulk contact tag creates this year other than a bunch of 'Matching Gift Company' tags by @NNichols
  2. adding groups to contacts - based on `'Groups' column ditto - seems to have been maybe used or a good idea many years ago
  3. Adding relationships to contact based on the data in the spreadsheet column 'Target Contact ID' - part of 'Generic Individuals') (as opposed to the rules based additions where we add employer relationships of ?maybe? DAF relationships based on soft credits
  4. custom fields for organization (organization contact fields) - these are a bit more recent - ie there were discussed back here https://phabricator.wikimedia.org/T278892 but we no longer seem to import to organizations using the old methods and we removed the import organization check code a while back as unused - which is how I believe it was used

The only people to have used the old imports in 2024 are @NNichols @MDemosWMF & Ellen - so just looking for confirmation that there is nothing I'm missing here - mostly from @MDemosWMF since Benevity doesn't use these features

Event Timeline

I could see the tags and/or groups function to be useful. Would these things need to be data fields in the import spreadsheet or added automatically based on the import type? I do bulk additions of tags to matching gift companies and donors, but it would be better if this was more automated. I can also see this as being maybe beneficial for the MG team with DAFs

@NNichols ok - so I'm mostly looking towards whether the existing legacy functionality is used - but yeah - it's possible to do buik additions via the contact import & we could look at making that possible via the Contribution Import

so

  1. doesn't anyone use the existing functionality in the legacy imports (if not we will remove which will simplify our code) and
  2. has this triggered you to add a phab to add the ability to add tags & groups via the new contribution import in the same way the existing contact import permits it (try importing a contact on staging if you want to see)

To my knowledge NO, we have not used this

@Eileenmcnaughton The only one that I am familiar with is #4 - we want to keep those fields in the Engage Organization file. Right now they are: Organization Contact Name / Organization Contact Title / Organization Contact Email / Organization Contact Phone

These were added in while I've been here because they were requested by Major Gifts team. The others we no longer use as far as I know!

Change #1024809 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove handling for contact_groups & relationship

https://gerrit.wikimedia.org/r/1024809

Change #1024809 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove handling for contact_groups & relationship

https://gerrit.wikimedia.org/r/1024809

Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint: ick() board.
Eileenmcnaughton moved this task from Doing to Done on the Fundraising Sprint: ick() board.
Eileenmcnaughton set Final Story Points to 2.