Remove close icon on Wikipedia Preview popups for desktop
Open, MediumPublic
Actions

Assigned To

Authored By

	SGautam_WMF
	Tue, Apr 30, 8:40 AM

Description

Problem

Mouse interaction Wikipedia Preview.gif (1×1 px, 2 MB)

The close icon on Wikipedia's desktop preview popups for readers may be redundant since the previews can be dismissed by moving the cursor away.

Solution

Remove close icon for Desktop readers.
Don't remove it for Mobile readers.

Note: This change also removes close icon for editors too which should be fine.

Task Description:

QA Results - WordPress Dev

AC	Status	Details
1	✅	T363802#9782197

Related Objects

Mentioned Here: T352491: Image thumbnails in Wikipedia Preview should have cursor:pointer;

Event Timeline

SGautam_WMF created this task.Tue, Apr 30, 8:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Apr 30, 8:40 AM

SGautam_WMF updated the task description. (Show Details)Tue, Apr 30, 8:41 AM

SGautam_WMF renamed this task from Remove close icon on Wikipedia Preview popups for desktop readers to Remove close icon on Wikipedia Preview popups for desktop .Tue, Apr 30, 2:26 PM

SGautam_WMF updated the task description. (Show Details)

SGautam_WMF moved this task from Definition to Ready for Dev on the Inuka-Team (Kanban) board.

SBisson claimed this task.Tue, Apr 30, 2:45 PM

SBisson triaged this task as Medium priority.

SBisson moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

https://github.com/wikimedia/wikipedia-preview/pull/201

AFAICT no changes needed in the Wordpress plugin.

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Wed, May 1, 7:31 PM

@SBisson The close icon is now removed for Desktop readers while Mobile readers still have it as seen in the gifs below. The will be moved to design sign-off. Thanks for all your work!

Status: ✅PASS
Environment: WordPress Dev- 6.5.3; Wikipreview: 1.10.0; Commit: d4cbaf60aaef02c00441354c9a3704a6c921410f, Tue May 7 21:44:02 2024 +0800
OS: macOS Sonoma 14.4.1
Browser: Chrome 124, Firefox 125, Safari 17.4.1
Skins. N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://dev-test.local/philadelphia-eagles-test/

✅AC1: https://phabricator.wikimedia.org/T352491

Desktop	Mobile

GMikesell-WMF updated the task description. (Show Details)Wed, May 8, 9:56 PM

GMikesell-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Mon, May 20, 6:28 AM

	F49423263: Mouse interaction Wikipedia Preview.gif
	Tue, Apr 30, 8:40 AM

Remove close icon on Wikipedia Preview popups for desktop Open, MediumPublicActions