🏗️ Respond patched-property-label-description-same-value if patched property has the same label and description in any language after patching
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jakob_WMDE
	Tue, Apr 30, 12:19 PM

Description

align the validate method signature of PropertyLabelValidator and PropertyDescriptionValidator with those of the corresponding item label/description validators
after that, the (Item|Property)(Labels|Descriptions)ContentsValidators implementations should look more or less identical and the same test can be reused: extensions/Wikibase/repo/rest-api/tests/phpunit/Application/Validation/LabelsAndDescriptionsContentsValidatorTest.php
extensions/Wikibase/repo/rest-api/tests/mocha/api-testing/PatchPropertyTest.js already has a skipped test for this case

Details

	Subject	Repo	Branch	Lines +/-
	REST: Respond patched-property-label-description-same-value in PatchProperty use case	mediawiki/extensions/Wikibase	master	+435 -478

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T347394 🏗️ Modify data of a property
		Resolved		Muhammad_Yasser_Jazirahly_WMDE	T363824 🏗️ Respond patched-property-label-description-same-value if patched property has the same label and description in any language after patching

Event Timeline

Jakob_WMDE created this task.Tue, Apr 30, 12:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Apr 30, 12:19 PM

Change #1027227 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Align validate method signature

https://gerrit.wikimedia.org/r/1027227

gerritbot added a project: Patch-For-Review.Sat, May 4, 5:44 PM

Muhammad_Yasser_Jazirahly_WMDE claimed this task.Sat, May 4, 6:24 PM

Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 19) board.

Hello @Jakob_WMDE
I worked on this during the weekend but couldn't know why the 3 e2e tests failed.
I'm off tomorrow, so I just wanted to give a heads-up for you if you want to check it 👍