Page MenuHomePhabricator

Fix red link tokens for dark mode
Closed, ResolvedPublic

Description

Context

Currently, the component tokens utilize option tokens, when they should use application/decision tokens. Updating these to application tokens will then enable dark mode to reference the correct tokens for red links.

This addresses the bug reported in T363778: [Regression] Red links not compatible with night theme in both mobile and desktop

What needs to happen

  • Currently, a visited application exists, but we also need a red--visited application token.
  • Component tokens should be referencing application tokens, so they adopt whatever mode is being applied at the application level. Currently the component tokens for Link use option tokens. These must be updated to reference the appropriate application tokens.

Acceptance criteria

  • Add a destructive--visited application/decision token in Figma
  • Update component tokens for Link in Figma to use application tokens
  • Add a destructive--visited application token in application.json to reference appropriate light mode option token
  • Add a destructive--visited application token in dark.json to reference appropriate dark mode option token
  • Update component tokens for Link in components.json to use appropriate application tokens

Event Timeline

Change #1026152 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] tokens: Revise component tokens for Link to work with dark mode

https://gerrit.wikimedia.org/r/1026152

Change #1026152 merged by jenkins-bot:

[design/codex@main] tokens: Revise component tokens for Link to work with dark mode

https://gerrit.wikimedia.org/r/1026152

Change #1032095 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from 1.5.0 to 1.6.0

https://gerrit.wikimedia.org/r/1032095

Change #1032095 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from 1.5.0 to 1.6.0

https://gerrit.wikimedia.org/r/1032095