User Details
- User Since
- Oct 5 2023, 1:15 PM (32 w, 6 h)
- Availability
- Available
- LDAP User
- Unknown
- MediaWiki User
- DTorsani-WMF [ Global Accounts ]
Tue, May 14
This proposal seems fine to me. Thanks for working on this.
Mon, May 13
@Jdlrobson It looks like this patch which fixes the issue with red link color tokens is set to be included in the next Codex release, scheduled to happen tomorrow.
Thanks for bringing this to our attention. To appease the automated tests, I've updated this color ever so slightly to meet necessary contrast ratios in the patch listed directly above. The change is unnoticeable but fixes the issue.
Thu, May 9
I agree with the simpler, easy to read, latter approach in Volker's comment.
Tue, May 7
Mon, May 6
@Jdlrobson Glad you spoke with Eric about this. These cases are exactly why we created the @color-inverted-fixed token.
Thu, May 2
This patch which fixes this issue has been merged and will be a part of the next Codex release.
Wed, May 1
I am working on fixing this as a part of T363911: Fix red link tokens for dark mode.
Tue, Apr 30
Mon, Apr 29
Thanks @RHo! It can certainly help influence that task.
Fri, Apr 26
Okay thanks @bmartinezcalvo! We are still working through the exact definitions of Tooltip, so I will update these once we have a bit more clarity on that.
Wed, Apr 24
After discussion with Chris and Julieta, we will keep the Tooltip component separate from the Popover component, which has its own task.
Tue, Apr 23
Thu, Apr 18
I've created this task to add the decision tokens for diff colors into Codex, which I will work on. I've added that task as a subtask of this task, since once that is done then this task can be completed. Thus, I have assigned this task to @Jdlrobson
I think it is important, when referencing existing examples to help define what a Tooltip and Popover should be, to consider if the existing examples should be this type of interaction to begin with, or if maybe these are potentially inappropriate uses of hiding content in a container like this. I know this notion complicates this task and decision a little more, but I think it's worth questioning so we build the correct versions of these components. Not saying they are all misuses, but I think there are some that might be questionable.
Apr 15 2024
I wasn't sure if you were hard coding these dark mode values still or using what is being built into Codex. I think there may be a patch with some updates on our end that has not been published yet, but that update addresses this issue.
Colors have also been updated in Codex tokens. Assigning back to @Jdlrobson and removing from the design system board.
Apr 11 2024
Noting here that this task will address this request per our conversation in design sync 2024/04/10.
Apr 10 2024
Apr 9 2024
Apr 8 2024
@Volker_E Where is that example from you shared above?
@Volker_E yes I can work on a proposal to present at design sync.
Apr 5 2024
@Volker_E I would agree that it feels a bit small, but the next one up, size-5600, feels too big, and I think the smaller one works better for character length in one line. Maybe it is time for a new sizing token?
Apr 3 2024
Apr 2 2024
@Jdlrobson Thanks for that note. We are working on a broader color update that will be built into Codex. Also, the table above has been updated with colors that meet accessibility criteria.
Apologies for missing that. I will provide new color values in the table above that will work for all types of links on the varying Message status backgrounds for dark mode. Please standby.
@Volker_E Thanks for sharing this image. Since these checkbox groups both have one label each at the top of the checkbox group, they seem completely related to me, and should therefore be 12px apart from one another, just as shown on the docs site.