Page MenuHomePhabricator

Add decision tokens for diff colors into Codex
Closed, ResolvedPublic

Description

Context

As discussed in DST design sync, we decided we want to add in decision tokens for added and removed content in MediaWiki. This was originally discussed in Phab on T361717.

Naming

We have decided to name these tokens -content-added and -content-removed.

Designs

addedlight modedark mode
text@color-blue-600 #3366cc@color-blue-400 #6d8af2
background@color-blue-400 #6d8af2@color-blue-600 #3366cc
border@color-blue-400 #6d8af2@color-blue-600 #3366cc
removedlight modedark mode
text@color-yellow-700 #a66200@color-yellow-650 #ad822b
background@color-yellow-650 #ad822b@color-yellow-700 #a66200
border@color-yellow-650 #ad822b@color-yellow-700 #a66200

image.png (292×1 px, 49 KB)

image.png (1×2 px, 263 KB)

image.png (1×2 px, 265 KB)

Figma dev mode link

Acceptance criteria

  • Figma "content" tokens are renamed to "text"
  • Figma decision tokens have been added
  • Decision tokens have been added to code

Event Timeline

DTorsani-WMF renamed this task from Add in decision tokens for diff colors to Add decision tokens for diff colors into Codex.Apr 18 2024, 9:57 AM

Change #1023434 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] tokens: Add decision tokens for content added and removed

https://gerrit.wikimedia.org/r/1023434

Change #1023434 merged by jenkins-bot:

[design/codex@main] tokens: Add decision tokens for content added and removed

https://gerrit.wikimedia.org/r/1023434

@DTorsani-WMF cc @mwilliams - think this should link to the overarching need to unify diff and "highlight text" colours across products as captured in T333681: Establish consistent guidelines on how to visualize diffs across desktop, mobile web, and mobile apps on the DST backlog.

Thanks @RHo! It can certainly help influence that task.

Change #1025849 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.4.0 to v1.5.0

https://gerrit.wikimedia.org/r/1025849

Change #1025849 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.4.0 to v1.5.0

https://gerrit.wikimedia.org/r/1025849