Address issues with usage of [bgcolor]
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 23 2024, 8:56 PM

Description

When using backgrounds without colors this creates issues in the new night mode as noted in https://www.mediawiki.org/wiki/Recommendations_for_night_mode_compatibility_on_Wikimedia_wikis#Always_define_color_when_defining_background.

Various templates make use of bgcolor. To address this we will automatically detect these and automatically fix them.

QA

Visit https://fr.m.wikipedia.org/w/index.php?title=Cristiano_Ronaldo&oldid=212682659&minervanightmode=1#En_.C3.A9quipe_A

Actual: Unreadable text:

Screenshot 2024-02-23 at 12.53.45 PM.png (523×894 px, 78 KB)

Expected:
Readable text.

https://phabricator.wikimedia.org/T358385#9613994

QA Results - Prod

AC	Status	Details
1	✅	T358385#9613994

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved	ovasileva	T341632 [EPIC] Palette customizations and dark mode
Resolved	ovasileva	T354835 [epic] Release night mode as a beta feature on desktop and mobile
Resolved	Jdlrobson	T354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
Resolved	ovasileva	T354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
Resolved	Jdlrobson	T356344 [Night mode] Templates can be fixed by editors when necessary for night mode
Resolved	Jdlrobson	T358387 [EPIC] Ensure all template text is readable in night mode: Fix all templates using background without color
Resolved	Jdlrobson	T358164 Set color/background to inherit or #333 on common templates/use of HTML4 bgcolor
Resolved	Jdlrobson	T358385 Address issues with usage of [bgcolor]

Event Timeline

Jdlrobson created this task.Feb 23 2024, 8:56 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 23 2024, 8:56 PM

Jdlrobson added a parent task: T358164: Set color/background to inherit or #333 on common templates/use of HTML4 bgcolor.Feb 23 2024, 8:57 PM

Jdlrobson updated the task description. (Show Details)Feb 23 2024, 9:02 PM

Jdlrobson mentioned this in T358164: Set color/background to inherit or #333 on common templates/use of HTML4 bgcolor.Feb 29 2024, 5:36 PM

Jdlrobson triaged this task as High priority.Mar 4 2024, 5:08 PM

This is fixed in production now thanks to T358164. It can be verified in production.

Jdlrobson assigned this task to Edtadros.Mar 7 2024, 11:32 PM

Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.

Jdlrobson added a project: MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 8 2024, 12:59 AM

Test Result - Prod

Status: ✅ PASS
Environment: frwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://fr.m.wikipedia.org/w/index.php?title=Cristiano_Ronaldo&oldid=212682659&minervanightmode=1#En_.C3.A9quipe_A

✅ AC1: Text should be readable.
The text in the table is readable, however there are some issues pertaining to Color Contrast and one unrelated issue in Beta.

Edtadros updated the task description. (Show Details)Mar 8 2024, 1:53 AM

Jdlrobson closed this task as Resolved.Mar 8 2024, 9:17 PM

Jdlrobson claimed this task.

Edtadros added a project: Verified.Mar 8 2024, 9:40 PM

Edtadros mentioned this in T358382: Verify 1.42.0-wmf.21 deployment.Mar 14 2024, 9:27 PM

	F42070378: Screenshot 2024-02-23 at 12.53.45 PM.png
	Feb 23 2024, 8:56 PM

	F42452607: screenshot 642.png
	Mar 8 2024, 1:52 AM

	F42452590: screenshot 648.png
	Mar 8 2024, 1:52 AM

	F42452589: screenshot 647.png
	Mar 8 2024, 1:52 AM

	F42452588: screenshot 649.png
	Mar 8 2024, 1:52 AM

Address issues with usage of [bgcolor]Closed, ResolvedPublicActions