Page MenuHomePhabricator

[Night mode] Make all open-by-default global navigation appear in night mode on mobile
Open, HighPublic

Description

Background & User story

Why are we doing this ticket?

  • This ticket will allow all menus and other navigation that’s open by default to appear in night mode on the mobile site.

How does it connect to our overall plans? What goal does it link to?

  • See task tree

What previous/central documentation exists?

User Stories

  • As a night mode reader, I want all menus to appear in night mode, so that I am not distracted by portions of the page not appearing in my selected mode

Requirements

The following navigation must appear in night mode:

  • Article/talk tab
  • Article menu/AMC article menu (language, watch, history, etc)

Not included in this ticket
More menu, notifications, etc

Design

...

Acceptance criteria

  • All product and design requirements must be complete
  • ...

Developer notes on technical requirements and targets

Testing criteria

Signoff criteria

What is required to sign off this ticket?
How will this ticket be documented?
Have we updated the ticket description to reflect the final requirements?

Open questions:

Related Objects

StatusSubtypeAssignedTask
OpenJdrewniak
OpenJdrewniak
OpenNone
OpenNone
OpenNone
ResolvedJdlrobson
Resolvedovasileva
ResolvedBUG REPORTJdlrobson
ResolvedBUG REPORTJScherer-WMF
OpenNone
DuplicateFeatureNone
ResolvedSpikeJdlrobson
ResolvedJdlrobson
Resolvedovasileva
ResolvedFeatureJdlrobson
DuplicateNone
OpenBUG REPORTNone
ResolvedJdlrobson
Resolvedovasileva
DuplicateJdlrobson
Resolvedovasileva
In ProgressNone
DuplicateNone
ResolvedJdlrobson
ResolvedBUG REPORTovasileva
Resolvedovasileva
ResolvedVolker_E
InvalidNone
InvalidJdlrobson
DuplicateNone
DuplicateNone
StalledNone
DuplicateNone
Resolvedovasileva
OpenNone
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
DuplicateJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedNone
DeclinedJdlrobson
ResolvedSToyofuku-WMF
ResolvedJdlrobson
OpenKSarabia-WMF
ResolvedNone
OpenNone
OpenNone
ResolvedJdlrobson
ResolvedJdlrobson
OpenBUG REPORTNone
ResolvedBUG REPORTovasileva
Openovasileva
ResolvedBUG REPORTovasileva
ResolvedBUG REPORTabi_
ResolvedBUG REPORTNikerabbit
ResolvedBUG REPORTovasileva
Openovasileva
ResolvedBUG REPORTJdlrobson

Event Timeline

Tacsipacsi renamed this task from [Night mode] All global navigation open by default appear in night mode on mobile to [Night mode] Make all open-by-default global navigation appear in night mode on mobile.Feb 16 2024, 7:36 PM
Tacsipacsi updated the task description. (Show Details)
Tacsipacsi subscribed.

@ovasileva It took me a while to understand what you mean, so I’ve updated the title and description to make it easier to understand. Is it okay for you? Or did I maybe still not understand correctly what you mean and updated them with a misinterpretation?

Please note that the current patch on that task (and the description) doesn’t solve what this task (T354843) asks for: it fixes the language selector so that it appears in dark-on-light instead of light-on-light – readable, but still distracting and annoying at night. Due to the unique support policy of Translate, it cannot use Codex design tokens directly yet and thus it ignores the changed design token values in night mode.