Make <languages> compatible with night mode by using Codex design tokens
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 6 2024, 10:55 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Text should be readable

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1	✅	T356821#9552597

QA Results - Prod

AC	Status	Details
1	✅	T356821#9573227

Details

	Subject	Repo	Branch	Lines +/-
	Use Codex design tokens	mediawiki/extensions/Translate	master	+2 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		Jdrewniak	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Open		Jdrewniak	T341632 [EPIC] Palette customizations and dark mode
Open		None	T354835 [epic] Release night mode as a beta feature on desktop and mobile
Open		None	T354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
Open		None	T354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
Resolved	BUG REPORT	abi_	T356821 Make <languages> compatible with night mode by using Codex design tokens

Event Timeline

Jdlrobson created this task.Feb 6 2024, 10:55 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 6 2024, 10:55 PM

Change 997977 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Translate@master] Use Codex design tokens

https://gerrit.wikimedia.org/r/997977

gerritbot added a project: Patch-For-Review.Feb 6 2024, 10:55 PM

Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q3 Sprint 4).Feb 6 2024, 10:56 PM

Nikerabbit added projects: Language-Team (Language-2024-January-March), Unplanned-Sprint-Work.Feb 12 2024, 11:21 AM

Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2024-January-March) board.

Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.

Change 997977 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Use Codex design tokens

https://gerrit.wikimedia.org/r/997977

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2024, 10:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 13 2024, 11:00 AM

Jdlrobson assigned this task to Edtadros.Feb 13 2024, 4:37 PM

Jdlrobson triaged this task as Medium priority.

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 3); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 4).

Jdlrobson updated the task description. (Show Details)

Jdlrobson set the point value for this task to 0.

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.

Nikerabbit moved this task from In Review to Check after deployment on the Language-Team (Language-2024-January-March) board.Feb 15 2024, 2:59 PM

ovasileva added a parent task: T354843: [Night mode] Make all open-by-default global navigation appear in night mode on mobile.Feb 16 2024, 1:18 PM

Tacsipacsi mentioned this in T354843: [Night mode] Make all open-by-default global navigation appear in night mode on mobile.Feb 16 2024, 7:36 PM

Change 1004246 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Translate@master] Fixes outdated translations box

https://gerrit.wikimedia.org/r/1004246

gerritbot added a project: Patch-For-Review.Feb 16 2024, 8:55 PM

Jdlrobson updated the task description. (Show Details)Feb 16 2024, 8:56 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://m.mediawiki.org/wiki/Reading/Web/Desktop_Improvements?minervanightmode=1# (on beta cluster https://commons.m.wikimedia.beta.wmflabs.org/wiki/Lite%C5%88?minervanightmode=1)
Go to https://m.mediawiki.org/wiki/Help%3ALogging_in%2Fid?minervanightmode=1

✅ AC1: Text should be readable

Edtadros updated the task description. (Show Details)Feb 17 2024, 12:18 AM

Nikerabbit moved this task from Check after deployment to Done on the Language-Team (Language-2024-January-March) board.Feb 19 2024, 8:37 AM

ovasileva subscribed.Feb 19 2024, 12:17 PM

This comment was removed by ovasileva.

Seeing:

Screenshot 2024-02-19 at 1.17.55 PM.png (1×956 px, 142 KB)

. Looks good, resolving!

@ovasileva Another acceptance criterion was added in T356821#9552036, which hasn’t been confirmed yet – and couldn’t have been, as the patch is currently under review. (I’ve now added a beta cluster link as for that AC as well.)

Jdlrobson moved this task from Ready for Signoff to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.Feb 20 2024, 5:46 PM

Jdlrobson reassigned this task from ovasileva to abi_.Feb 21 2024, 1:31 AM

Jdlrobson moved this task from Done to In Review on the Language-Team (Language-2024-January-March) board.

Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 3).Feb 21 2024, 11:25 PM

Jdlrobson moved this task from Backlog to Night mode coordination on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Feb 22 2024, 12:51 AM

Test Result - Prod

Status: ✅ PASS
Environment: mediawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Text should be readable

Created new ticket for outdated translations: T358381 since it was a late discovery.

Jdlrobson moved this task from Blocked on Others to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.Feb 23 2024, 8:24 PM

Edtadros reopened this task as Open.Feb 23 2024, 8:26 PM

Edtadros updated the task description. (Show Details)

Jdlrobson closed this task as Resolved.Feb 23 2024, 9:58 PM

Edtadros mentioned this in T357332: Verify 1.42.0-wmf.19 deployment.Feb 24 2024, 12:33 AM

Nikerabbit moved this task from In Review to Done on the Language-Team (Language-2024-January-March) board.Feb 24 2024, 6:47 AM

Nikerabbit removed a project: Patch-For-Review.Feb 29 2024, 3:13 PM

	F41980826: Screenshot 2024-02-19 at 1.17.55 PM.png
	Feb 19 2024, 12:18 PM

	F41882718: Screenshot 2024-02-13 at 8.37.42 AM.png
	Feb 13 2024, 4:38 PM

	F41797251: Screenshot 2024-02-06 at 2.55.14 PM.png
	Feb 6 2024, 10:55 PM

	F41797202: Screenshot 2024-02-06 at 2.47.54 PM.png
	Feb 6 2024, 10:55 PM

	F42069712: screenshot 567.png
	Feb 23 2024, 8:21 PM

	F42069711: screenshot 566.png
	Feb 23 2024, 8:21 PM

	F41936714: screenshot 528.png
	Feb 17 2024, 12:17 AM

Make <languages> compatible with night mode by using Codex design tokensClosed, ResolvedPublic0 Estimated Story PointsBUG REPORTActions

Description

QA Results - Beta

QA Results - Prod

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Make <languages> compatible with night mode by using Codex design tokens
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Related Objects
Search...