Make Translate outdated translations text compatible with night mode
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 23 2024, 8:23 PM

Description

Steps to replicate the issue (include links if applicable):

Go to https://m.mediawiki.org/wiki/Reading/Web/Desktop_Improvements?minervanightmode=1# (on beta cluster https://commons.m.wikimedia.beta.wmflabs.org/wiki/Lite%C5%88?minervanightmode=1)
Go to (on beta cluster https://commons.m.wikimedia.beta.wmflabs.org/wiki/Lite%C5%88/cs?minervanightmode=1)

What happens?:
If it appears, check the "Outdated translations are marked " is white text on pink background

What should have happened instead?:
"Outdated translations are marked" should be readable

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1

Details

	Subject	Repo	Branch	Lines +/-
	Fix color contrast issues with outdated translations text	mediawiki/extensions/Translate	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		Jdrewniak	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Open		Jdrewniak	T341632 [EPIC] Palette customizations and dark mode
Open		None	T354835 [epic] Release night mode as a beta feature on desktop and mobile
Open		None	T354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
Open		None	T354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
Resolved	BUG REPORT	Nikerabbit	T358381 Make Translate outdated translations text compatible with night mode

Event Timeline

Jdlrobson created this task.Feb 23 2024, 8:23 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 23 2024, 8:23 PM

Jdlrobson mentioned this in T356821: Make <languages> compatible with night mode by using Codex design tokens.Feb 23 2024, 8:24 PM

Change 1004246 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Translate@master] Fix color contrast issues with outdated translations text

https://gerrit.wikimedia.org/r/1004246

gerritbot added a project: Patch-For-Review.Feb 23 2024, 8:25 PM

Jdlrobson renamed this task from Make <languages> compatible with night mode by using Codex design tokens to Make <languages> outdated translations text compatible with night mode.Feb 23 2024, 8:25 PM

Jdlrobson added a project: Language-Team (Language-2024-January-March).

Actually, this has nothing to do with <languages/>: it appears at the top of the page and highlights outdated translations if and only if there are outdated translations. It appears at the top even if <languages/> is not at the top or it isn’t used at all.

Tacsipacsi added a parent task: T354843: [Night mode] Make all open-by-default global navigation appear in night mode on mobile.Feb 23 2024, 9:23 PM

Nikerabbit triaged this task as Medium priority.Feb 26 2024, 9:58 AM

Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2024-January-March) board.

Nikerabbit set the point value for this task to 1.

Nikerabbit added projects: Unplanned-Sprint-Work, Localization Infrastructure FY2023-24.

Nikerabbit moved this task from Backlog to Translatable pages (LH1) on the Localization Infrastructure FY2023-24 board.

Nikerabbit moved this task from Translatable pages (LH1) to Support (LM) on the Localization Infrastructure FY2023-24 board.

Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Feb 26 2024, 11:18 AM

abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2024-January-March) board.Feb 27 2024, 4:14 AM

Change 1004246 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Fix color contrast issues with outdated translations text

https://gerrit.wikimedia.org/r/1004246