Page MenuHomePhabricator
Create Task
Maniphest T357998

Address color contrast issues in .wikitable
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
KSarabia-WMF
Feb 20 2024, 3:45 PM
Tags
Referenced Files
F44425482: screenshot 190.png
Apr 4 2024, 3:55 AM
F44365175: screenshot 161.png
Apr 3 2024, 7:22 PM
F42451872: Screenshot 2024-03-07 at 5.07.09 PM.png
Mar 8 2024, 1:07 AM
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson
KSarabia-WMF
Masumrezarock100

Description

Background

Our tables currently have color contrast issues due to use of non-standard tokens that will soon be formalized in Codex. While we have worked around this in the mean time for mobile, we need to resolve this ticket in such a way that this bug doesn't propagate to the desktop Vector 2022 skin.

User story

As a user viewing a table, I want it to be accessible and themed accordingly to the theme I have chosen.

Acceptance criteria

Communication criteria - does this need an announcement or discussion?

None needed.

QA steps

https://en.m.wikipedia.beta.wmflabs.org/wiki/Ethiopian_wolf?minervanightmode=1#Subspecies
This text is unreadable:

Screenshot 2024-03-07 at 5.07.09 PM.png (308×1 px, 57 KB)

QA Results - Beta

ACStatusDetails
1✅T357998#9685731

QA Results - Prod

ACStatusDetails
1✅T357998#9686838

Details

SubjectRepoBranchLines +/-
Define background-color-neutral in night mode palettemediawiki/skins/MinervaNeuemaster+1 -0
Minerva should use content-tables ResourceLoaderSkinModule featuremediawiki/skins/MinervaNeuemaster+5 -23
Skin: Use design tokens rather than hardcoded valuesmediawiki/coremaster+7 -6
Skin: Use LESS variable for design tokens rather than CSS variablesmediawiki/coremaster+6 -12
Set color on tablesmediawiki/skins/MinervaNeuemaster+2 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenJdrewniakT341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
 OpenJdrewniakT341632 [EPIC] Palette customizations and dark mode
 OpenovasilevaT354835 [epic] Release night mode as a beta feature on desktop and mobile
 ResolvedJdlrobsonT354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
 OpenovasilevaT354842 [Night mode] All global navigation open by default appear in night mode on desktop
 OpenovasilevaT354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
 ResolvedJdlrobsonT356074 Implement the dark mode color palette and switch LESS variables in Minerva to use it, degrade support for browsers that do not support CSS custom properties
 ResolvedovasilevaT356900 Regression: Issues with color-subtle (Codex .cdx-mixin-css-icon mixin doesn't work with CSS variables)
 ResolvedBUG REPORTJdlrobsonT356928 Regression: Visited links on mobile appearing as black
 ResolvedBUG REPORTJScherer-WMFT357381 Regression: Active link color is broken on mobile
 OpenNoneT356344 [Night mode] Templates can be fixed by editors when necessary for night mode
 ResolvedovasilevaT357998 Address color contrast issues in .wikitable
 ResolvedVolker_ET334790 tokens: Implement new static layout background-color tokens
 ResolvedBUG REPORTovasilevaT357179 Page issues as rendered in article is not compatible with night mode
 OpenovasilevaT358192 [Bug] Page issues icon disappearing on click
 ResolvedBUG REPORTovasilevaT356822 Minerva/MobileFrontend icons not using embedded data URI rules should be compatible with night mode
 ResolvedBUG REPORTabi_T356821 Make <languages> compatible with night mode by using Codex design tokens
 ResolvedBUG REPORTNikerabbitT358381 Make Translate outdated translations text compatible with night mode
 ResolvedBUG REPORTovasilevaT359081 [Bug] Page previews currently does not work in night mode.
 ResolvedJdlrobsonT360877 [Bug] Page previews gradient not working in night mode
ResolvedBUG REPORTJdlrobsonT358822 Translate extension needs to import mediawiki.skin.variables to get night mode

Event Timeline

KSarabia-WMF created this task.Feb 20 2024, 3:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2024, 3:45 PM
KSarabia-WMF added a parent task: T356344: [Night mode] Templates can be fixed by editors when necessary for night mode.Feb 20 2024, 3:45 PM
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog.Feb 22 2024, 12:30 AM
Jdlrobson changed the task status from Open to Stalled.Feb 22 2024, 1:06 AM
Jdlrobson triaged this task as Medium priority.
Jdlrobson subscribed.

Needs examples.

Jdlrobson moved this task from Backlog to Night mode coordination on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Feb 22 2024, 1:08 AM
Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Feb 24 2024, 12:37 AM
Jdlrobson renamed this task from Address undiagnosed color contrast issues in <table> or `.wikitable` to Address color contrast issues in .wikitable.Feb 27 2024, 4:40 PM
Jdlrobson changed the task status from Stalled to Open.
gerritbot added a comment.Feb 27 2024, 4:40 PM

Change 997978 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Skin: Use design tokens rather than hardcoded values

https://gerrit.wikimedia.org/r/997978

gerritbot added a project: Patch-For-Review.Feb 27 2024, 4:40 PM
Jdlrobson added a parent task: T334790: tokens: Implement new static layout background-color tokens.Feb 27 2024, 4:43 PM
CCiufo-WMF removed a parent task: T334790: tokens: Implement new static layout background-color tokens.Mar 5 2024, 3:46 PM
CCiufo-WMF added a subtask: T334790: tokens: Implement new static layout background-color tokens.
CCiufo-WMF changed the status of subtask T334790: tokens: Implement new static layout background-color tokens from Open to In Progress.Mar 5 2024, 3:48 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog (Needs Prioritization (Tech)).Mar 8 2024, 1:07 AM
Jdlrobson updated the task description. (Show Details)
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMar 8 2024, 1:07 AM
ovasileva raised the priority of this task from Medium to High.Mar 11 2024, 5:50 PM
Jdlrobson moved this task from Incoming to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.Mar 11 2024, 7:07 PM
Jdlrobson moved this task from Blocked on Others to Incoming on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
gerritbot added a comment.Mar 11 2024, 8:53 PM

Change 1010317 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Skin: Use design tokens rather than hardcoded values

https://gerrit.wikimedia.org/r/1010317

gerritbot added a comment.Mar 11 2024, 9:12 PM

Change 1010320 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Minerva should use content-tables ResourceLoaderSkinModule feature

https://gerrit.wikimedia.org/r/1010320

gerritbot added a comment.Mar 11 2024, 10:59 PM

Change 1010339 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Set color on tables

https://gerrit.wikimedia.org/r/1010339

gerritbot added a comment.Mar 11 2024, 11:33 PM

Change 1010339 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Set color on tables

https://gerrit.wikimedia.org/r/1010339

Jdlrobson updated the task description. (Show Details)Mar 12 2024, 12:12 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Night mode (mobile) to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.
Jdlrobson added a parent task: T354842: [Night mode] All global navigation open by default appear in night mode on desktop.
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 6); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 5).Mar 12 2024, 4:55 PM

This is waiting on the next Codex release so now we are unblocked we can reschedule this for sprint 6.

Jdlrobson lowered the priority of this task from High to Medium.Mar 12 2024, 5:27 PM
gerritbot added a comment.Mar 19 2024, 6:57 PM

Change 997978 abandoned by Jdlrobson:

[mediawiki/core@master] Skin: Use LESS variable for design tokens rather than CSS variables

Reason:

Merged into https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1010317/1?usp=related-change

https://gerrit.wikimedia.org/r/997978

egardner closed subtask T334790: tokens: Implement new static layout background-color tokens as Resolved.Mar 19 2024, 10:16 PM
gerritbot added a comment.Mar 20 2024, 12:49 AM

Change 1010317 merged by jenkins-bot:

[mediawiki/core@master] Skin: Use design tokens rather than hardcoded values

https://gerrit.wikimedia.org/r/1010317

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 20 2024, 1:00 AM
Jdlrobson raised the priority of this task from Medium to High.Mar 20 2024, 4:00 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 2.Mar 21 2024, 5:36 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
gerritbot added a comment.Mar 26 2024, 6:29 PM

Change #1010320 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Minerva should use content-tables ResourceLoaderSkinModule feature

https://gerrit.wikimedia.org/r/1010320

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2024, 6:30 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.25; 2024-04-02); removed MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 26 2024, 7:00 PM
Jdlrobson assigned this task to Edtadros.Apr 1 2024, 2:42 PM
Jdlrobson moved this task from Ready for Development to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
gerritbot added a comment.Apr 1 2024, 2:47 PM

Change #1015982 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Define background-color-neutral in night mode palette

https://gerrit.wikimedia.org/r/1015982

gerritbot added a project: Patch-For-Review.Apr 1 2024, 2:47 PM
Jdlrobson removed Edtadros as the assignee of this task.Apr 1 2024, 2:47 PM
Jdlrobson moved this task from QA to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Jdlrobson added a subscriber: Edtadros.
NBaca-WMF assigned this task to bwang.Apr 1 2024, 5:38 PM
NBaca-WMF moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.Apr 1 2024, 5:44 PM
Jdlrobson moved this task from QA to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.Apr 1 2024, 8:57 PM
bwang removed bwang as the assignee of this task.Apr 1 2024, 10:41 PM
bwang moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
bwang subscribed.
gerritbot added a comment.Apr 1 2024, 11:04 PM

Change #1015982 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Define background-color-neutral in night mode palette

https://gerrit.wikimedia.org/r/1015982

Jdlrobson assigned this task to Edtadros.Apr 1 2024, 11:12 PM
Jdlrobson updated the task description. (Show Details)
Edtadros removed Edtadros as the assignee of this task.Apr 3 2024, 7:22 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

https://en.m.wikipedia.beta.wmflabs.org/wiki/Ethiopian_wolf?minervanightmode=1#Subspecies
✅ AC1: The table headings should be readable.

screenshot 161.png (826×1 px, 275 KB)

Edtadros updated the task description. (Show Details)Apr 3 2024, 7:23 PM
Edtadros added a comment.Apr 4 2024, 3:55 AM

Test Result - Prod

Status: ✅ PASS
Environment: cawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

https://ca.m.wikipedia.org/wiki/Historial_de_versions_d%27Android?minervanightmode=1
✅ AC1: The table headings should be readable.

screenshot 190.png (1×1 px, 268 KB)

Edtadros updated the task description. (Show Details)Apr 4 2024, 3:56 AM
ovasileva claimed this task.Apr 4 2024, 4:37 PM
ovasileva closed this task as Resolved.Apr 8 2024, 9:14 AM
Edtadros added a project: Verified.Apr 9 2024, 9:54 PM
Edtadros mentioned this in T360465: Verify 1.42.0-wmf.25 deployment.Apr 9 2024, 11:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL