@Sneha Can you design review based off these test pages?
https://aab34200b0.catalyst.wmcloud.org/wiki/New_York_(state)?useparsoid=0
https://aab34200b0.catalyst.wmcloud.org/wiki/New_York_(state)?useparsoid=1

@Etonkovidova that looks like an unrelated error thank you for asking

In T344183#10208766, @Jdlrobson wrote:

@bwang - does this class as "essential work"? If so why? We do seem to have vector-icon and minerva-icon now so I'm not sure if this ties into our existing work for icon migration.

@bwang check if its still an issue and resolve task

@aude to update this task into spike ticket

Create spike subtask for this @Volker_E

From refinement: Create two subtasks for each roll out with acceptance criteria

Fix is to remove unneeded console.warn on line 228 resources/skins.vector.js/setupIntersectionObservers.js

Steps to QA in beta:

• create new account (i.e no edits)
• go to mobile
• open user menu, click on watchlist
• see you are on Special:EditWatchlist

Playing around with it quickly, this is what i get with Desktop styles on Minerva
Minerva

In T414882#11570765, @Jdlrobson-WMF wrote:

Currently we are using first-child
However, since first-child can be a thumbnail OR a style tag this doesn't work.

We don't want to apply the margin to headings where the lead is empty. I wrote some code to describe when we do not want this margin:

Array.from(document.querySelectorAll('.mf-collapsible-content')).filter((node) => {
    for (const child of node.childNodes) {
        if ( [ 'P', 'UL', 'OL' ].includes( child.nodeName ) ) {
            return false;
        }
    }
    return true;
} ).forEach((node) => {
    node.classList.add('mf-empty-lead');
} );
mw.util.addCSS(`
.mf-empty-lead section:first-of-type .mw-heading3 {
    margin-top: 0 !important;
}
`);

With some help from ChatGPT I was able to get an equivalent CSS selector. I don't like it (and has does not work for all our supported browsers but it does the job). When I ran visualdiffs for 100 articles on Wikipedia, it significantly improved the situation.

.content [data-mw-section-id] > div:not(:has(> p, > ul, > ol)) > section[data-mw-section-id]:first-of-type .mw-heading3{ margin-top: 0; }

Pending a bit more testing, I'd recommend we add the above CSS rule. @Aarohisharma3 if you still interested in helping a patch would be appreciated!

@matmarex thank you for the catch! i put up a small fix here: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1236781

@ATitkov i think thats fine, we already added 'skin-client-preference.change'. I put up a patch here. @Jdlrobson-WMF do you agree this is the shortest solution? https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1234458