Page MenuHomePhabricator

bwang (Bernard Wang)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 29 2021, 7:53 PM (16 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
BWang (WMF) [ Global Accounts ]

Recent Activity

Fri, Jul 23

bwang placed T283988: Raw edit summary is shown in Wikidata user contribution page in mobile view up for grabs.
Fri, Jul 23, 5:11 PM · MobileFrontend (MobileFrontend Special Pages), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Wikidata-Campsite, Mobile, MediaWiki-Comment-store, Wikidata
bwang moved T283988: Raw edit summary is shown in Wikidata user contribution page in mobile view from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Fri, Jul 23, 3:00 PM · MobileFrontend (MobileFrontend Special Pages), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Wikidata-Campsite, Mobile, MediaWiki-Comment-store, Wikidata
bwang claimed T283988: Raw edit summary is shown in Wikidata user contribution page in mobile view.
Fri, Jul 23, 3:00 PM · MobileFrontend (MobileFrontend Special Pages), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Wikidata-Campsite, Mobile, MediaWiki-Comment-store, Wikidata
bwang added a comment to T285259: User links: Echo icons should match mediawiki.ui.icons in the header.

@alexhollender Ok, if that's the case I'll just remove the opacity, which will look like this: https://jmp.sh/hpK2Jte
I made a mistake earlier, both echo icons and the user menu icons are actually just black #000, so I'll just leave them as be until that other color task

Fri, Jul 23, 2:51 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Thu, Jul 22

bwang added a comment to T285259: User links: Echo icons should match mediawiki.ui.icons in the header.

@Jdlrobson Yeah I could put up a follow up patch for Echo. I was thinking it might be easier to disable the opacity entirely for user links, and just set the color explicitly, what do you think?

Thu, Jul 22, 10:00 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang placed T286733: [User links] remove margin-left: auto on search box up for grabs.
Thu, Jul 22, 5:50 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements
bwang moved T286733: [User links] remove margin-left: auto on search box from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Thu, Jul 22, 5:25 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements
bwang moved T285259: User links: Echo icons should match mediawiki.ui.icons in the header from Needs More Work to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Thu, Jul 22, 5:06 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang assigned T285259: User links: Echo icons should match mediawiki.ui.icons in the header to Jdlrobson.
Thu, Jul 22, 4:08 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang moved T285259: User links: Echo icons should match mediawiki.ui.icons in the header from Needs More Work to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Thu, Jul 22, 4:08 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Wed, Jul 21

bwang updated the task description for T285259: User links: Echo icons should match mediawiki.ui.icons in the header.
Wed, Jul 21, 4:49 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang renamed T285259: User links: Echo icons should match mediawiki.ui.icons in the header from User links: Echo should use mediawiki.ui.icon in the header to User links: Echo icons should match mediawiki.ui.icons in the header.
Wed, Jul 21, 4:47 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang placed T287052: Regression: More menu dropdown font-size is too big in legacy Vector up for grabs.
Wed, Jul 21, 2:27 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Regression, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Tue, Jul 20

bwang placed T285259: User links: Echo icons should match mediawiki.ui.icons in the header up for grabs.
Tue, Jul 20, 10:13 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Fri, Jul 16

bwang placed T271763: Give Popups storybook instance some love up for grabs.
Fri, Jul 16, 4:14 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews

Thu, Jul 15

bwang reassigned T284584: Remove UserMenu template in favor of using the Menu template from Jdlrobson to Edtadros.
Thu, Jul 15, 8:56 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang added a comment to T285259: User links: Echo icons should match mediawiki.ui.icons in the header.

I suggest we use this ticket to focus on getting Echo's icons aligned with Vectors (in whatever form makes sense). I would suggest it makes sense for Echo to register menu items with icon class and for the classes to be added on the Vector side just as we have done with the user menu.

Thu, Jul 15, 5:31 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang assigned T284584: Remove UserMenu template in favor of using the Menu template to Jdlrobson.
Thu, Jul 15, 3:34 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang moved T284584: Remove UserMenu template in favor of using the Menu template from Needs More Work to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Thu, Jul 15, 3:33 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector

Wed, Jul 14

bwang claimed T285259: User links: Echo icons should match mediawiki.ui.icons in the header.
Wed, Jul 14, 9:09 PM · MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Tue, Jul 13

bwang placed T280614: Remove SkinTemplate::makeArticleUrlDetails up for grabs.
Tue, Jul 13, 9:05 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture
bwang moved T280614: Remove SkinTemplate::makeArticleUrlDetails from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Jul 13, 8:56 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture
bwang claimed T280614: Remove SkinTemplate::makeArticleUrlDetails.
Tue, Jul 13, 8:56 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture
bwang placed T271763: Give Popups storybook instance some love up for grabs.
Tue, Jul 13, 4:26 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews
bwang moved T286040: "InvalidArgumentException: $key must be a string or an array" on beta login and vote wikis from Upcoming to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Jul 13, 4:26 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Beta-Cluster-reproducible, Desktop Improvements
bwang placed T285442: [Bug] Orange talk alert does not disappear in new Vector after clicking "Mark all as read" up for grabs.
Tue, Jul 13, 4:26 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang placed T284584: Remove UserMenu template in favor of using the Menu template up for grabs.
Tue, Jul 13, 3:36 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector

Mon, Jul 12

bwang moved T285442: [Bug] Orange talk alert does not disappear in new Vector after clicking "Mark all as read" from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Mon, Jul 12, 8:52 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang claimed T285442: [Bug] Orange talk alert does not disappear in new Vector after clicking "Mark all as read".
Mon, Jul 12, 8:52 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Growth-Team, Notifications, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Wed, Jun 30

bwang placed T284584: Remove UserMenu template in favor of using the Menu template up for grabs.
Wed, Jun 30, 6:23 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang placed T284748: User links: Change button icon (logged-in only) up for grabs.
Wed, Jun 30, 6:23 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Jun 24 2021

bwang placed T273093: Design improvements for Search loading state up for grabs.
Jun 24 2021, 5:20 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang placed T282318: Regression: Whitespace to right of title in Firefox up for grabs.
Jun 24 2021, 5:19 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang updated subscribers of T285482: TypeError: Cannot read property 'key' of undefined.
Jun 24 2021, 4:44 PM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-production-error
bwang moved T282318: Regression: Whitespace to right of title in Firefox from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 24 2021, 4:27 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang claimed T282318: Regression: Whitespace to right of title in Firefox.
Jun 24 2021, 4:21 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang created T285482: TypeError: Cannot read property 'key' of undefined.
Jun 24 2021, 3:25 PM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-production-error

Jun 23 2021

bwang added a comment to T280608: Hard deprecate BaseTemplate:renderAfterPortlet method.

@Jdlrobson I think this task isnt done yet, as this patch hasnt been merged yet
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Metrolook/+/700934

Jun 23 2021, 5:20 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, MonoBook, Timeless, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, Metrolook, MediaWiki-Core-Skin-Architecture
bwang reassigned T284584: Remove UserMenu template in favor of using the Menu template from bwang to Edtadros.
Jun 23 2021, 2:30 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector

Jun 22 2021

bwang claimed T284584: Remove UserMenu template in favor of using the Menu template.
Jun 22 2021, 5:07 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang moved T284584: Remove UserMenu template in favor of using the Menu template from QA to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 22 2021, 5:07 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang added a comment to T273093: Design improvements for Search loading state.

@alexhollender I made this patchdemo that adds an additional 5 second delay. Let me know if this works for review!
https://patchdemo.wmflabs.org/wikis/3a8e8101b1/wiki/Main_Page?useskinversion=2

Jun 22 2021, 4:32 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang added a comment to T284584: Remove UserMenu template in favor of using the Menu template.

@Edtadros Ah that's my bad, I fixed the login/logout button but I forgot to remove the Login, Talk, and Contributions link for logged out. I'll put in another patch for that

Jun 22 2021, 3:34 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang moved T280608: Hard deprecate BaseTemplate:renderAfterPortlet method from Needs More Work to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 22 2021, 3:18 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, MonoBook, Timeless, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, Metrolook, MediaWiki-Core-Skin-Architecture

Jun 21 2021

bwang placed T284584: Remove UserMenu template in favor of using the Menu template up for grabs.
Jun 21 2021, 7:34 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang added a comment to T284584: Remove UserMenu template in favor of using the Menu template.

@Jdlrobson Yep can do!

Jun 21 2021, 7:09 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang placed T281545: Remove Html::infobox and associated styles up for grabs.
Jun 21 2021, 7:09 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt (Deprecation process), MediaWiki-Core-Skin-Architecture
bwang placed T280608: Hard deprecate BaseTemplate:renderAfterPortlet method up for grabs.
Jun 21 2021, 7:08 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, MonoBook, Timeless, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, Metrolook, MediaWiki-Core-Skin-Architecture
bwang moved T280608: Hard deprecate BaseTemplate:renderAfterPortlet method from Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 21 2021, 7:08 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, MonoBook, Timeless, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, Metrolook, MediaWiki-Core-Skin-Architecture

Jun 18 2021

bwang moved T284748: User links: Change button icon (logged-in only) from Ready for Development to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 18 2021, 7:58 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
bwang assigned T282759: Remove box-shadow usage in Popups and GuidedTour to Edtadros.
Jun 18 2021, 5:22 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Growth-Team, MediaWiki-extensions-GuidedTour, Page-Previews, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), good first task, CSS
bwang moved T283955: Align the numerals on the language switching button to local scripts from Ready for Development to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 18 2021, 5:22 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang placed T282759: Remove box-shadow usage in Popups and GuidedTour up for grabs.
Jun 18 2021, 4:30 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Growth-Team, MediaWiki-extensions-GuidedTour, Page-Previews, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), good first task, CSS
bwang moved T281545: Remove Html::infobox and associated styles from Ready for Development to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 18 2021, 4:29 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt (Deprecation process), MediaWiki-Core-Skin-Architecture
bwang claimed T282759: Remove box-shadow usage in Popups and GuidedTour.
Jun 18 2021, 3:55 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Growth-Team, MediaWiki-extensions-GuidedTour, Page-Previews, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), good first task, CSS
bwang moved T281545: Remove Html::infobox and associated styles from Doing to Ready for Development on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 18 2021, 3:54 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt (Deprecation process), MediaWiki-Core-Skin-Architecture
bwang moved T282759: Remove box-shadow usage in Popups and GuidedTour from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 18 2021, 3:54 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Growth-Team, MediaWiki-extensions-GuidedTour, Page-Previews, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), good first task, CSS
bwang moved T281545: Remove Html::infobox and associated styles from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 18 2021, 3:54 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Technical-Debt (Deprecation process), MediaWiki-Core-Skin-Architecture
bwang added a comment to T282759: Remove box-shadow usage in Popups and GuidedTour.

I also see an instance of the mixin in ULS, should that be added to this task?
https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/resources/css/ext.uls-vector.less#L8

Jun 18 2021, 3:45 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Growth-Team, MediaWiki-extensions-GuidedTour, Page-Previews, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), good first task, CSS

Jun 14 2021

bwang reassigned T280608: Hard deprecate BaseTemplate:renderAfterPortlet method from Jdlrobson to Edtadros.
Jun 14 2021, 8:10 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, MonoBook, Timeless, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, Metrolook, MediaWiki-Core-Skin-Architecture
bwang placed T280608: Hard deprecate BaseTemplate:renderAfterPortlet method up for grabs.
Jun 14 2021, 2:27 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, MonoBook, Timeless, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, Metrolook, MediaWiki-Core-Skin-Architecture

Jun 11 2021

bwang committed rSMNB6ce3ce1acb68: Use Skin::getAfterPortlet instead of deprecated BaseTemplate:getAfterPortlet (authored by bwang).
Use Skin::getAfterPortlet instead of deprecated BaseTemplate:getAfterPortlet
Jun 11 2021, 9:19 PM

Jun 10 2021

bwang added a comment to T280608: Hard deprecate BaseTemplate:renderAfterPortlet method.

@Jdlrobson Should we also hard deprecate getAfterPortlet? The release notes deprecate both getAfterPortlet and renderAfterPortlet together in 1.35:

Jun 10 2021, 5:29 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, MonoBook, Timeless, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, Metrolook, MediaWiki-Core-Skin-Architecture
bwang placed T280608: Hard deprecate BaseTemplate:renderAfterPortlet method up for grabs.
Jun 10 2021, 4:51 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, MonoBook, Timeless, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, Metrolook, MediaWiki-Core-Skin-Architecture
bwang moved T280608: Hard deprecate BaseTemplate:renderAfterPortlet method from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 10 2021, 4:06 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, MonoBook, Timeless, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, Metrolook, MediaWiki-Core-Skin-Architecture
bwang claimed T280608: Hard deprecate BaseTemplate:renderAfterPortlet method.
Jun 10 2021, 4:06 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, MonoBook, Timeless, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, Metrolook, MediaWiki-Core-Skin-Architecture

Jun 9 2021

bwang moved T284584: Remove UserMenu template in favor of using the Menu template from Needs More Work to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 9 2021, 10:22 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang placed T278894: [1.37] The class mw-ajax-loader will no longer be styled by Vector up for grabs.
Jun 9 2021, 3:13 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Technical-Debt, MediaWiki-extensions-LiquidThreads, MW-1.37-release

Jun 8 2021

bwang added a project to T284584: Remove UserMenu template in favor of using the Menu template: Readers-Web-Backlog (Kanbanana-FY-2020-21).
Jun 8 2021, 5:35 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang updated the task description for T284584: Remove UserMenu template in favor of using the Menu template.
Jun 8 2021, 5:33 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector
bwang created T284584: Remove UserMenu template in favor of using the Menu template.
Jun 8 2021, 5:32 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements, Vector

Jun 7 2021

bwang claimed T278894: [1.37] The class mw-ajax-loader will no longer be styled by Vector.
Jun 7 2021, 5:48 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Technical-Debt, MediaWiki-extensions-LiquidThreads, MW-1.37-release
bwang moved T273093: Design improvements for Search loading state from QA in Prod to Design Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 7 2021, 4:42 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Jun 3 2021

bwang added a comment to T276564: User links: Logged-out user links menu treatment.

An update on remaining work:

  1. MERGED Storybook https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/696651
  2. MERGED Follow up to comments https://gerrit.wikimedia.org/r/686781
  3. Remove UserMenu template https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/698587
Jun 3 2021, 9:46 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements
bwang reassigned T276564: User links: Logged-out user links menu treatment from bwang to Edtadros.
Jun 3 2021, 5:11 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements

Jun 1 2021

bwang moved T276564: User links: Logged-out user links menu treatment from Needs More Work to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jun 1 2021, 5:10 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements
bwang added a comment to T276668: Regression: Settings button misplaced in article preview.

Hi @Edtadros, I just took a second look at the AC3 on prod, and it seemed to work for me. Does this task still need work? https://jmp.sh/PdhIcyR

Jun 1 2021, 5:07 PM · Performance-Team (Radar), MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews
bwang assigned T276561: User links: Logged-in user links menu treatment without icons (for anonymous users no change) to Edtadros.
Jun 1 2021, 5:04 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements
bwang placed T276561: User links: Logged-in user links menu treatment without icons (for anonymous users no change) up for grabs.
Jun 1 2021, 5:04 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements

May 25 2021

bwang placed T276564: User links: Logged-out user links menu treatment up for grabs.
May 25 2021, 9:36 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements
alexhollender awarded T282480: [ Eng spike] Consider adding a loading state to the typeahead-search component for loading search results a Like token.
May 25 2021, 4:20 PM · Spike, WVUI

May 24 2021

Krinkle awarded T283260: Use commas in Wikimedia Portal article statistics a Orange Medal token.
May 24 2021, 5:55 PM · Accessibility, Wikimedia-Portals

May 20 2021

bwang created T283260: Use commas in Wikimedia Portal article statistics .
May 20 2021, 5:01 PM · Accessibility, Wikimedia-Portals
Volker_E awarded T283257: Wikimedia portals should should provide landmarks a Like token.
May 20 2021, 4:29 PM · Accessibility, Wikimedia-Portals
bwang created T283257: Wikimedia portals should should provide landmarks.
May 20 2021, 4:24 PM · Accessibility, Wikimedia-Portals

May 19 2021

bwang updated the task description for T283100: Add role="banner" landmark to the header.
May 19 2021, 8:18 PM · Readers-Web-Backlog, Browser-Support-Google-Chrome, Desktop Improvements, Vector, Accessibility
bwang updated the task description for T283100: Add role="banner" landmark to the header.
May 19 2021, 8:18 PM · Readers-Web-Backlog, Browser-Support-Google-Chrome, Desktop Improvements, Vector, Accessibility
bwang added a comment to T283100: Add role="banner" landmark to the header.

I was looking at this again and I realized I made a mistake earlier, the landmark is being announced correctly with Chrome/JAWS. This issue is limited to Chrome/VO afterall

May 19 2021, 8:17 PM · Readers-Web-Backlog, Browser-Support-Google-Chrome, Desktop Improvements, Vector, Accessibility
bwang updated the task description for T283100: Add role="banner" landmark to the header.
May 19 2021, 4:46 PM · Readers-Web-Backlog, Browser-Support-Google-Chrome, Desktop Improvements, Vector, Accessibility
bwang added a comment to T283100: Add role="banner" landmark to the header.

I did some additional testing, and it seems this is only happening with Chrome/VO and Chrome/Jaws. I tested Safari/VO, Firefox/Narrator, and Chrome/Narrator. In Chrome/Jaws it's not announced as a banner at all when navigating through landmarks and when listing all landmarks.

May 19 2021, 4:18 PM · Readers-Web-Backlog, Browser-Support-Google-Chrome, Desktop Improvements, Vector, Accessibility

May 18 2021

bwang moved T283100: Add role="banner" landmark to the header from Unsorted to Attributes on the Accessibility board.
May 18 2021, 6:25 PM · Readers-Web-Backlog, Browser-Support-Google-Chrome, Desktop Improvements, Vector, Accessibility
bwang created T283100: Add role="banner" landmark to the header.
May 18 2021, 6:24 PM · Readers-Web-Backlog, Browser-Support-Google-Chrome, Desktop Improvements, Vector, Accessibility
bwang claimed T265993: Heading structure & ordering in (new) DOM structure.
May 18 2021, 4:31 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Accessibility, Desktop Improvements, Vector
bwang moved T265993: Heading structure & ordering in (new) DOM structure from Unsorted to Semantic HTML on the Accessibility board.
May 18 2021, 3:52 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Accessibility, Desktop Improvements, Vector

May 17 2021

bwang added a watcher for Accessibility: bwang.
May 17 2021, 6:19 PM

May 13 2021

bwang added a comment to T276564: User links: Logged-out user links menu treatment.

@alexhollender The mocks seem to have a minimum width or width, do you have a particular value in mind? I've been using width: 12em or 192px, which looks like this: https://jmp.sh/Bz4MeqL

May 13 2021, 7:32 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements

May 12 2021

bwang added a comment to T281791: User links: Logged-in user links menu need sorting.

@Jdlrobson Yes, I think we could definitely unset the logout link in onSkinTemplateNavigation in Hooks.php, and handle it manually. I was also thinking an even simpler solution could be to just reorder $content_navigation['user-menu']['logout'] in that hook instead of unsetting it.

May 12 2021, 4:53 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements

May 10 2021

bwang added a project to T282480: [ Eng spike] Consider adding a loading state to the typeahead-search component for loading search results: Readers-Web-Backlog (Kanbanana-FY-2020-21).
May 10 2021, 6:57 PM · Spike, WVUI
bwang added a comment to T273093: Design improvements for Search loading state.

@alexhollender I went ahead and made a spike ticket to get started on the sign off criteria, please feel free to edit it! https://phabricator.wikimedia.org/T282480

May 10 2021, 6:57 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
bwang created T282480: [ Eng spike] Consider adding a loading state to the typeahead-search component for loading search results.
May 10 2021, 6:07 PM · Spike, WVUI