Page MenuHomePhabricator

"Theme" (Accessibility for Reading) button in Vector 2022 should have consistent padding in button form
Open, MediumPublicFeature

Description

image.png (73×338 px, 2 KB)

Feature summary (what you would like to be able to do and where):
In the above picture, as you can see, the eyeglasses button has less padding surrounding it than the other buttons.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
For everyone who enables the Accessibility for Reading beta

Benefits (why should this be implemented?):
Consistent interface

Event Timeline

Aklapper renamed this task from New "Theme" (Accessibilty for Reading) button in V22 should have consistent padding in button form to New "Theme" (Accessibilty for Reading) button in Vector22 should have consistent padding in button form.Dec 23 2023, 7:56 PM
Aklapper renamed this task from New "Theme" (Accessibilty for Reading) button in Vector22 should have consistent padding in button form to New "Theme" (Accessibilty for Reading) button in Vector2022 should have consistent padding in button form.
aliu renamed this task from New "Theme" (Accessibilty for Reading) button in Vector2022 should have consistent padding in button form to New "Theme" (Accessibilty for Reading) button in Vector 2022 should have consistent padding in button form.Dec 23 2023, 7:57 PM
ovasileva triaged this task as Medium priority.Jan 4 2024, 3:33 PM
Jdlrobson renamed this task from New "Theme" (Accessibilty for Reading) button in Vector 2022 should have consistent padding in button form to [Design] New "Theme" (Accessibilty for Reading) button in Vector 2022 should have consistent padding in button form.Mon, Jan 29, 4:15 PM
Jdlrobson assigned this task to JScherer-WMF.

This could be because the icon has a different shape than the square-ish icons beside it, in which case the padding would be fine.

@Jdrewniak or @Jdlrobson can you confirm that the padding is off? If not, I'll work with @DTorsani-WMF on solutions. He is already thinking through a more square version of the icon.

The bell icon is quite far from a square. I'm not sure what you mean.

image.png (393×665 px, 45 KB)

See the screenshot above. The Appearance button is structured very different from the others and doesn't have the vector-menu etc. css classes

The bell icon is quite far from a square. I'm not sure what you mean.

I double checked this, thanks! There is a 6 pixel discrepancy in the computed distance between icons.

Frame 1.png (40×169 px, 2 KB)

They should all be 16. I'll move this to ready for dev and unassign myself.

Copying my screenshot from T355420:

Buttons in vector-user-links are usually spaced by 8px, but the new appearance dropdown isn't:

image.png (46×238 px, 1 KB)

Jdlrobson renamed this task from [Design] New "Theme" (Accessibilty for Reading) button in Vector 2022 should have consistent padding in button form to "Theme" (Accessibility for Reading) button in Vector 2022 should have consistent padding in button form.Thu, Feb 8, 6:01 PM