Page MenuHomePhabricator

Mabualruz (mabualruz)
Senior Software Engineer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 17 2022, 8:57 AM (99 w, 3 d)
Availability
Available
IRC Nick
mo_abualruz
LDAP User
Mabualruz
MediaWiki User
MAbualruz-WMF [ Global Accounts ]

Recent Activity

Fri, Apr 5

Mabualruz lowered the priority of T361934: Support CSS variable fallbacks in template styles from High to Medium.

Based on the latest feedback and discussion here and on T360562, I think Medium is more fitting for now.

Fri, Apr 5, 1:08 PM · Patch-For-Review, css-sanitizer, TemplateStyles, FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog (FY2023-24 Q4 Sprint 1)
Mabualruz added a comment to T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles.

@stjn can we move the discussion to T361934, I wanted to summarise the movement of the discussion there for everyone's benefit. Thanks

Fri, Apr 5, 1:04 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz added a comment to T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles.

I just had a discussion on slack with @cscott, about the new sub task and follow up work in summary:

Fri, Apr 5, 12:55 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz moved T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles from Needs More Work to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Fri, Apr 5, 12:01 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)

Thu, Apr 4

Mabualruz reassigned T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles from cscott to Edtadros.
Thu, Apr 4, 5:57 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)

Wed, Apr 3

Mabualruz reassigned T356678: Migrate uses of codex-search in MinervaNeue to use CodexModule from Jdrewniak to Edtadros.
Wed, Apr 3, 7:26 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Web-Team-Backlog (FY2023-24 Q3 Sprint 6), Patch-For-Review, Web Team Essential Work 2024, MinervaNeue
Mabualruz moved T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles from Blocked on Others to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Wed, Apr 3, 7:25 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz reassigned T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer() from Jdrewniak to Edtadros.
Wed, Apr 3, 7:25 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Mabualruz added a comment to T360098: Allow reading accessibility settings menu to have different defaults for logged-in and logged-out users on desktop.

Martin +2ed the patch (thank you!), so this just needs a patch for Vector to make use of the new functionality :)

Wed, Apr 3, 1:20 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Mabualruz added a comment to T361158: Exception handling for appearance settings - Vector.
  1. There are two approaches to consider:
Wed, Apr 3, 1:15 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz moved T356678: Migrate uses of codex-search in MinervaNeue to use CodexModule from Needs More Work to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Wed, Apr 3, 12:53 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Web-Team-Backlog (FY2023-24 Q3 Sprint 6), Patch-For-Review, Web Team Essential Work 2024, MinervaNeue

Tue, Apr 2

Mabualruz added a comment to T360098: Allow reading accessibility settings menu to have different defaults for logged-in and logged-out users on desktop.

I have left some suggestions/questions on the patch

Tue, Apr 2, 9:57 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)

Mon, Apr 1

Mabualruz added a comment to T361157: Change "Night" to "Dark" in Appearance settings.

The following questions can help gather more context and understand the requirements for the task involving changes in the Appearance settings:

Mon, Apr 1, 7:11 AM · Web-Team-Backlog, FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz reassigned T360099: Accessibility settings menu should default to open for all logged-in and logged-out users from Mabualruz to Edtadros.
Mon, Apr 1, 7:05 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Mabualruz moved T360099: Accessibility settings menu should default to open for all logged-in and logged-out users from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Mon, Apr 1, 7:04 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Mabualruz moved T360099: Accessibility settings menu should default to open for all logged-in and logged-out users from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Mon, Apr 1, 3:51 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Mabualruz moved T360099: Accessibility settings menu should default to open for all logged-in and logged-out users from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Mon, Apr 1, 3:31 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Mabualruz claimed T360099: Accessibility settings menu should default to open for all logged-in and logged-out users.
Mon, Apr 1, 3:31 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Mabualruz added a comment to T359005: Page issues not clickable in mobile view (new parser).

The following questions structured around the 5W1H model can help gather more context and understand the requirements:

Mon, Apr 1, 3:20 AM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q4 Sprint 2), MobileFrontend, MinervaNeue
Mabualruz added a comment to T360926: Unable to View Error List on Night Mode Checker.

The following questions structured around the 5W1H model can help gather more context and understand the requirements:

Mon, Apr 1, 3:16 AM · Web-Team-Backlog
Mabualruz added a comment to T360955: Update mediawiki.web_ui_actions Stream Config.

The following questions structured around the 5W1H model can help gather more context and understand the requirements, and output of this task so we can share knowledge about this area:

Mon, Apr 1, 3:14 AM · Data Products (Data Products Sprint 11), Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Patch-For-Review, Data-Engineering, MediaWiki-extensions-WikimediaEvents
Mabualruz added a comment to T361038: Unexpected paragraph spacing added by the poem tag.

is this related to T360917?

Mon, Apr 1, 3:10 AM · Web-Team-Backlog, MediaWiki-extensions-Poem
Mabualruz added a comment to T360683: How should Template:Color work in night mode?.

The following questions structured around the 5W1H model can help gather more context and understand the requirements:

Mon, Apr 1, 3:09 AM · Web-Team-Backlog (Needs Prioritization (Tech)), Local-Wiki-Template-And-Gadget-Issues, FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz added a comment to T360388: Upstream thumbnail and table rules from Minerva to ResourceLoader/SkinModule.

The following questions structured around the 5W1H model can help gather more context and understand the requirements:

Mon, Apr 1, 3:04 AM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MinervaNeue, MediaWiki-Core-Skin-Architecture, FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz added a comment to T360917: [Spike 3hrs] Unintended vertical spacing behaviour .

Following the 5W1H model that can help gather more context and understand the requirements for starting the work:

Mon, Apr 1, 3:00 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz moved T357166: Categories appear in light theme from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Mon, Apr 1, 1:41 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations

Fri, Mar 29

Mabualruz added a comment to T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles.
  1. Last step for deployment we need to update the mediawiki/vendor repository with the new version of the CSS Sanitizer after successful local tests:
Fri, Mar 29, 9:52 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz added a comment to T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles.
  1. To locally test the TemplateStyles extension with changes from the CSS Sanitizer, follow this guide:
Fri, Mar 29, 9:30 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz added a comment to T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles.
  1. Remaining Steps:
Fri, Mar 29, 9:21 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz placed T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles up for grabs.
Fri, Mar 29, 9:13 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz moved T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles from Blocked on Others to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Fri, Mar 29, 9:13 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz closed T357486: Expand all sections should show on resize as Resolved.

Great work, it looks and works as intended

Fri, Mar 29, 7:41 AM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), Patch-For-Review, good first task, MobileFrontend, patch-welcome
Mabualruz reassigned T359606: It should be possible to disable night mode on select pages in Vector 2022 from SToyofuku-WMF to Edtadros.
Fri, Mar 29, 7:40 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz moved T359606: It should be possible to disable night mode on select pages in Vector 2022 from Doing to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Fri, Mar 29, 7:39 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations

Thu, Mar 28

Mabualruz claimed T356678: Migrate uses of codex-search in MinervaNeue to use CodexModule.
Thu, Mar 28, 1:47 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Web-Team-Backlog (FY2023-24 Q3 Sprint 6), Patch-For-Review, Web Team Essential Work 2024, MinervaNeue
Mabualruz moved T359606: It should be possible to disable night mode on select pages in Vector 2022 from Code Review to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Thu, Mar 28, 1:44 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz updated Other Assignee for T360386: Create a WikimediaMessages module for sharing styles between Vector 2022 and Minerva, removed: Jdrewniak.
Thu, Mar 28, 3:56 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, WikimediaMessages
Mabualruz placed T360387: Remove styles in hacks.less that no longer apply up for grabs.
Thu, Mar 28, 3:56 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, MinervaNeue
Mabualruz moved T360387: Remove styles in hacks.less that no longer apply from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Thu, Mar 28, 3:56 AM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, MinervaNeue

Wed, Mar 27

Mabualruz moved T360386: Create a WikimediaMessages module for sharing styles between Vector 2022 and Minerva from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Wed, Mar 27, 4:44 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, WikimediaMessages
Mabualruz added a comment to T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles.

Blocked until I get a pairing partner to share knowledge and discuss next steps

Wed, Mar 27, 1:14 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz moved T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles from Doing to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Wed, Mar 27, 1:14 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz claimed T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles.
Wed, Mar 27, 8:16 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Mabualruz moved T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Wed, Mar 27, 8:16 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)

Tue, Mar 26

Mabualruz claimed T360387: Remove styles in hacks.less that no longer apply.
Tue, Mar 26, 4:29 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, MinervaNeue
Mabualruz added a comment to T360387: Remove styles in hacks.less that no longer apply.

@bwang Should we apply same changes to https://phabricator.wikimedia.org/T360386 ?

Tue, Mar 26, 4:29 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, MinervaNeue
Mabualruz placed T360386: Create a WikimediaMessages module for sharing styles between Vector 2022 and Minerva up for grabs.
Tue, Mar 26, 4:28 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, WikimediaMessages
Mabualruz updated Other Assignee for T360386: Create a WikimediaMessages module for sharing styles between Vector 2022 and Minerva, added: Jdrewniak.
Tue, Mar 26, 4:28 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, WikimediaMessages
Mabualruz moved T360386: Create a WikimediaMessages module for sharing styles between Vector 2022 and Minerva from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Tue, Mar 26, 4:26 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, WikimediaMessages

Mon, Mar 25

Mabualruz added a comment to T360386: Create a WikimediaMessages module for sharing styles between Vector 2022 and Minerva.

I am reviewing it, seems ready to merge, just going to try some edge case testing try check styles loading and pixel results. Will probably merge it tomorrow

Mon, Mar 25, 10:36 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, WikimediaMessages
Mabualruz claimed T360386: Create a WikimediaMessages module for sharing styles between Vector 2022 and Minerva.
Mon, Mar 25, 10:34 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, WikimediaMessages
Mabualruz updated Other Assignee for T360386: Create a WikimediaMessages module for sharing styles between Vector 2022 and Minerva, added: Mabualruz.
Mon, Mar 25, 10:30 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, WikimediaMessages
Mabualruz moved T360386: Create a WikimediaMessages module for sharing styles between Vector 2022 and Minerva from Code Review to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Mon, Mar 25, 10:30 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, WikimediaMessages

Fri, Mar 22

Mabualruz added a comment to T360644: [Spike] Investigate alternatives to Storybooks.js.

https://www.docz.site/ , https://swanky-docs.github.io/swanky-docs.org/, maybe these tool with pixel can cover a lot of what we need.

Fri, Mar 22, 12:10 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2)
Mabualruz added a comment to T356690: Migrate uses of codex-search in Popups to use CodexModule.

I think this is the same work we did here https://phabricator.wikimedia.org/T356677, are we targeting all extensions and skins, ... ?
https://codesearch.wmcloud.org/search/?q=codex-search-styles&files=&excludeFiles=&repos=

Fri, Mar 22, 11:49 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Web Team Essential Work 2024, Page-Previews

Thu, Mar 21

Mabualruz edited projects for T353987: "Theme" (Accessibility for Reading) button in Vector 2022 should have consistent padding in button form, added: Web-Team-Backlog (FY2023-24 Q3 Sprint 6); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 5).
Thu, Mar 21, 4:49 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Mabualruz reassigned T359152: Deploy initial version of night mode to pilot wikis on the mobile website for testing from Jdrewniak to Edtadros.
Thu, Mar 21, 4:41 PM · Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz reassigned T359983: Rename the skin night mode classes to something more sensible before they become widely used from Edtadros to Jdlrobson.
Thu, Mar 21, 4:38 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz closed T320923: Normalise / Refactor SpecialPage::getShortDescription as Declined.

This is no longer needed, the current core implementation is sufficient

Thu, Mar 21, 2:03 PM · Web-Team-Backlog, MediaWiki-Core-Skin-Architecture, MobileFrontend, SectionTranslation
Mabualruz closed T345997: Revise the Dashboard if it requires splitting into more specialized and general ones as Resolved.

@Peter updated the dashboards and descriptions. in a different task, I will resolve this maybe we can open tasks in the future for each specific board with specific requirements

Thu, Mar 21, 2:00 PM · Web-Team-Backlog
Mabualruz closed T345997: Revise the Dashboard if it requires splitting into more specialized and general ones, a subtask of T337402: [SPIKE] Identify steps for Web Team performance Dashboards, as Resolved.
Thu, Mar 21, 2:00 PM · Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5)
Mabualruz updated the task description for T345997: Revise the Dashboard if it requires splitting into more specialized and general ones.
Thu, Mar 21, 1:58 PM · Web-Team-Backlog
Mabualruz placed T315014: Build core menu API MVP up for grabs.
Thu, Mar 21, 1:57 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture (Menus 2.0)
Mabualruz added a comment to T315014: Build core menu API MVP.

This is still has low priority, and not focused on in the current team goals

Thu, Mar 21, 1:57 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture (Menus 2.0)
Mabualruz placed T327717: Page tools: Support icon for Atom link up for grabs.
Thu, Mar 21, 1:54 PM · Patch-For-Review, Web-Team-Backlog, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Desktop Improvements (Vector 2022)
Mabualruz added a comment to T327915: Vector Components Management.

Mo do you remember what this ticket was about? If so could you update it to be actionable? if not should we decline it?

Thu, Mar 21, 1:52 PM · Web-Team-Backlog (Needs Prioritization (Tech))
Mabualruz updated the task description for T327915: Vector Components Management.
Thu, Mar 21, 1:52 PM · Web-Team-Backlog (Needs Prioritization (Tech))
Mabualruz placed T334367: On page load Javascript files load performance Tweaking up for grabs.
Thu, Mar 21, 1:43 PM · Web-Team-Backlog, Desktop Improvements (Vector 2022)
Mabualruz added a comment to T334367: On page load Javascript files load performance Tweaking.

Mo to expand the description to make it clearer what this task is about.

Thu, Mar 21, 1:42 PM · Web-Team-Backlog, Desktop Improvements (Vector 2022)
Mabualruz updated the task description for T334367: On page load Javascript files load performance Tweaking.
Thu, Mar 21, 1:42 PM · Web-Team-Backlog, Desktop Improvements (Vector 2022)
Mabualruz added a comment to T350582: Centralise the Less file imports for Minerva components.

@ovasileva I expanded a bit in the description here, still this is mainly a technical refactoring that does not affect the user experience directly.

Thu, Mar 21, 1:32 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MinervaNeue, FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz added a comment to T353029: QA desktopwebuiactionstracking schema port to the new metrics platform.

@phuedx Is there anything we can do from the web team side on this?

Thu, Mar 21, 1:31 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Product-Analytics (Kanban), MediaWiki-extensions-WikimediaEvents
Mabualruz placed T337404: [EPIC] Web Performance SLOs CI up for grabs.
Thu, Mar 21, 1:19 PM · Web-Team-Backlog, Epic, Desktop Improvements (Vector 2022)
Mabualruz placed T350582: Centralise the Less file imports for Minerva components up for grabs.
Thu, Mar 21, 1:17 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MinervaNeue, FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz updated the task description for T350582: Centralise the Less file imports for Minerva components.
Thu, Mar 21, 1:17 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MinervaNeue, FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz placed T359665: Refactor Vector skin to remove use of RequestContext::getMain in service wiring code up for grabs.
Thu, Mar 21, 1:11 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Technical-Debt, Desktop Improvements (Vector 2022)
Mabualruz moved T359665: Refactor Vector skin to remove use of RequestContext::getMain in service wiring code from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
Thu, Mar 21, 1:10 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Technical-Debt, Desktop Improvements (Vector 2022)
Mabualruz added a comment to T359665: Refactor Vector skin to remove use of RequestContext::getMain in service wiring code.

No QA needed, this change can be checked by pixel as it is stability and refactoring, expectation is no apparent change. Local Pixel passes for me.

Thu, Mar 21, 1:10 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Technical-Debt, Desktop Improvements (Vector 2022)
Mabualruz placed T353029: QA desktopwebuiactionstracking schema port to the new metrics platform up for grabs.
Thu, Mar 21, 12:59 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Product-Analytics (Kanban), MediaWiki-extensions-WikimediaEvents

Wed, Mar 20

Mabualruz moved T359983: Rename the skin night mode classes to something more sensible before they become widely used from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
Wed, Mar 20, 7:29 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz moved T359983: Rename the skin night mode classes to something more sensible before they become widely used from Needs More Work to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
Wed, Mar 20, 8:05 AM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz added a comment to T359983: Rename the skin night mode classes to something more sensible before they become widely used.

Done

  • Create a patch for Extension:DarkMode

Done

Is already merged. Do you want to review/merge the revert?

Wed, Mar 20, 8:04 AM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), FY2023-24-WE 2.1 Typography and palette customizations

Mon, Mar 18

Mabualruz added a comment to T327717: Page tools: Support icon for Atom link.

Will be abandoned but can be used as a future reference if we get back to this issue

Mon, Mar 18, 5:00 PM · Patch-For-Review, Web-Team-Backlog, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Desktop Improvements (Vector 2022)
Mabualruz added a comment to T354889: Vector 2022 should use the experimental Codex build.

Questions:

  • What steps will ensure the smooth integration of the experimental Codex build with Vector 2022?
  • How will the light and night mode colour palettes be implemented to maintain consistency across Vector themes?
  • Are there any potential impacts on performance or user experience to consider with this integration?
Mon, Mar 18, 8:49 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz added a comment to T358071: [GOAL] Move template override styles from Minerva to WikimediaMessages and allow site editors more control.

Questions:

  • How will the migration process from Minerva to WikimediaMessages be managed?
  • What guidelines can be provided to communities for effectively cherry-picking styles?
  • Is there specific consideration or limitation when applying this module to the Vector 2022 skin?
Mon, Mar 18, 8:47 AM · Web-Team-Backlog (Needs Prioritization (Tech)), FY2023-24-WE 2.1 Typography and palette customizations, Patch-For-Review, MinervaNeue, WikimediaMessages
Mabualruz added a comment to T359521: Potential interaction to paint problems and fixes.

This task checks on potential fixes to improve page rendering and interactivity, trying to address issues like large page-loads and layout shifts with changes on CSS strategies to enhance performance. I think it focuses on using content-visibility: auto to reduce rendering tasks and improve First Contentful Paint (FCP) on low-end devices for pages with large content.

Mon, Mar 18, 8:39 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Web Team Essential Work 2024
Mabualruz added a comment to T360098: Allow reading accessibility settings menu to have different defaults for logged-in and logged-out users on desktop.

Questions:

  • Is CUDCOND_ANON a defined condition or we need to request to be added, or is addressing it part of the ticket?
  • What are the specific technical details for implementing and storing the default settings (e.g., within code only or utilising a config file such as skin.json file)?
  • How and when will the deployment of the new default settings for users be carried out?
  • Are there any specific testing or validation criteria that should be considered during the development process?
Mon, Mar 18, 8:32 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Mabualruz added a comment to T358826: Editors should be able to request light or night theme always applies to a certain element.

Questions:

  • What specific elements or types of content require the implementation of a CSS class or variable for theme control?
Mon, Mar 18, 8:21 AM · Web-Team-Backlog (FY2023-24 Q3 Sprint 6), Wikistories
Mabualruz added a comment to T327717: Page tools: Support icon for Atom link.

I've created a new proof of concept for this Task. Moving forward, we will require:

Mon, Mar 18, 8:02 AM · Patch-For-Review, Web-Team-Backlog, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Desktop Improvements (Vector 2022)

Fri, Mar 15

Mabualruz added a comment to T359958: Exclude list is not working for special page names.

Test Result - Prod

Status: ❌ FAIL
Environment: frwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://fr.m.wikipedia.org/w/index.php?title=Sp%C3%A9cial:Modifications_r%C3%A9centes&days=30&enhanced=1&hideWikibase=1&hidebots=1&hidecategorization=1&limit=500&minervanightmode=1&safemode=1&urlversion=2

✅ AC1: Appears in light mode
❌ AC2: with an notification
There is no notification

screenshot.mov.gif (982×768 px, 916 KB)

Fri, Mar 15, 10:49 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, MinervaNeue, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), FY2023-24-WE 2.1 Typography and palette customizations

Thu, Mar 14

Mabualruz updated Other Assignee for T359983: Rename the skin night mode classes to something more sensible before they become widely used, added: SToyofuku-WMF.
Thu, Mar 14, 8:37 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz moved T359983: Rename the skin night mode classes to something more sensible before they become widely used from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
Thu, Mar 14, 8:37 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz claimed T359983: Rename the skin night mode classes to something more sensible before they become widely used.
Thu, Mar 14, 8:35 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), FY2023-24-WE 2.1 Typography and palette customizations
Mabualruz added a comment to T354974: [Tooling] Restore or remove MobileFrontend storybook.

To summarise the discussion from Slack that is mostly provided by @Jdlrobson, here are the key points:

Thu, Mar 14, 8:29 PM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MobileFrontend, Page-Previews
Mabualruz moved T354974: [Tooling] Restore or remove MobileFrontend storybook from Doing to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
Thu, Mar 14, 8:52 AM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MobileFrontend, Page-Previews
Mabualruz added a comment to T354974: [Tooling] Restore or remove MobileFrontend storybook.

During estimation we discussed that Pixel seems to cover most of the things we got out of storybook so we may want to remove it and update Pixel tests to capture it.

Jon to separate out the Popups upgrade into a separate ticket.

Thu, Mar 14, 8:52 AM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MobileFrontend, Page-Previews
Mabualruz updated Other Assignee for T354974: [Tooling] Restore or remove MobileFrontend storybook, removed: Mabualruz.
Thu, Mar 14, 7:09 AM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MobileFrontend, Page-Previews

Wed, Mar 13

Mabualruz claimed T354974: [Tooling] Restore or remove MobileFrontend storybook.
Wed, Mar 13, 9:29 PM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MobileFrontend, Page-Previews
Mabualruz updated Other Assignee for T354974: [Tooling] Restore or remove MobileFrontend storybook, added: Mabualruz.
Wed, Mar 13, 9:25 PM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MobileFrontend, Page-Previews
Mabualruz moved T354974: [Tooling] Restore or remove MobileFrontend storybook from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
Wed, Mar 13, 9:25 PM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MobileFrontend, Page-Previews