New regression in wmf.5. This will likely trigger error logging tomorrow.
If you are logged in and click the desktop link we showed a AMC drawer like so (note that the "No thanks" and enabled button are pressed together - likely a longstanding issue from our move to Codex). We didn't catch this in development as it's hard to test this workflow and we don't have any tests covering it.
This is no longer working on group 1 wikis (flagged by error reporting)
This looks related to the work we did to restrict our unstable APIs from gadgets/extensions.
We should either remove this feature, or fix it.
TODO
- Fix the immediate issue
- Add some tests for catching regressions to this component in future since it is hard to test. [done in https://github.com/wikimedia/pixel/pull/224]
- ICorrect the design. It should be possible to scroll the entire drawer. It shouldn't be clipped at the bottom. The button and "no thanks:" should be visually separated.
Developer notes
The following is needed for testing:
$wgMFAmcOutreachMinEditCount = 0; $wgMFAmcOutreach = true;
Production error
Error: TypeError: Cannot read properties of undefined (reading 'loadCampaign')
t HTMLAnchorElement.amcDesktopClickHandler https://m.mediawiki.org/w/load.php?lang=en&modules=skins.minerva.scripts&skin=minerva&version=sffel:42:689 at HTMLAnchorElement.dispatch https://m.mediawiki.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=minerva&version=1oirs:376:932 at elemData.handle https://m.mediawiki.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=minerva&version=1oirs:373:565
QA steps
NOTE: For production a minimum edit account of 100 is needed. Please attempt in an incognito window.
- Login and make sure AMC is disabled
- Click desktop link in footer at bottom of page
- Expected: the drawer should show.
Click the button
- Expected: you should get AMC mode and stay in mobile site
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ❌ | T351362#9343005 |
