Page MenuHomePhabricator
Create Task
Maniphest T350081

1.42.0-wmf.5 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jnuche
Release Version
1.42.0-wmf.5
Release Date
Nov 13 2023, 12:00 AM

2023 week 46 1.42-wmf.5 Changes wmf/1.42.0-wmf.5

This MediaWiki Train Deployment is scheduled for the week of Monday, November 13th:

Monday November 13thTuesday, November 14thWednesday, November 15thThursday, November 16thFriday
Backports only.Branch wmf.5 and deploy to Group 0 Wikis.Deploy wmf.5 to Group 1 Wikis.Deploy wmf.5 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.5 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.42.0-wmf.4
Next: 1.42.0-wmf.6
SubjectRepoBranchLines +/-
group2 wikis to 1.42.0-wmf.5operations/mediawiki-configmaster+333 -333
group1 wikis to 1.42.0-wmf.5operations/mediawiki-configmaster+549 -549
group0 wikis to 1.42.0-wmf.5operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.42.0-wmf.5operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.42.0-wmf.5mediawiki/corewmf/1.42.0-wmf.5+996 -3
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Oct 30 2023, 10:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2023, 10:26 PM
thcipriani assigned this task to jeena.Oct 30 2023, 10:27 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jnuche.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
Jdlrobson mentioned this in T350416: Verify 1.42.0-wmf.5 deployment.Nov 2 2023, 4:56 PM
thcipriani moved this task from Priority Backlog 📥 to Quid Pro Crow 🦃 on the Release-Engineering-Team board.Nov 8 2023, 4:20 PM
thcipriani edited projects, added Release-Engineering-Team (Quid Pro Crow 🦃); removed Release-Engineering-Team (Priority Backlog 📥).
DAlangi_WMF added subscribers: DAlangi_WMF, Tgr.Nov 13 2023, 9:55 AM
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/967880
  • Summary: Last week in T350080, we added a risky change note (T350080#9307536), due to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/960643 being rolled out. It was almost going entirely well until T350723 happened (hence risky) and it got fixed by @Tgr. This week, we're rolling out step 2/3 (risky) of the migration. At this point, we're confident that both CentralAuth token and session old and new key format are in the respective stores and with this week's rollout, we want to begin using the new key format. If everything goes well, the new key formats will be used, however, the old key format is still written to the store just in case something goes wrong, we don't loose our sessions and tokens.
  • Test plan: After group 0 and group 1 deploys, check that central login, edge login and central autologin still works, and check central tokens with the action and REST APIs.
  • Places to monitor:
  • Revert plan: Revert the patch if something breaks. Central tokens are short-lived so fallout is minimal. Central sessions live for 24 hours; a botched migration might prevent logins, in the worst case might log people out. Not a big deal on group 0; not great on group 1 (loginwiki is group 1 so the group 0 and group 1 train will test different code paths; group 2 train should be no different from group 0 train). The patch is written defensively, and problems would only affect people who logged in / refreshed their session between the deploy and the revert, so the risk is low, especially if this is done not too long after the train.
  • Affected wikis: group 0 train will affect group 0 wikis. Group 1 train will affect all wikis (but only for logins; group 1 wikis only for already existing sessions).
  • IRC contact: tgr (@Tgr) (UTC-08), xSavitar (@DAlangi_WMF) (UTC+01)
  • UBN Task Projects/tags: MediaWiki-Platform-Team
  • Would you like to backport this change rather than ride the train?: No
gerritbot added a comment.Nov 14 2023, 3:07 AM

Change 973414 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.42.0-wmf.5] Branch commit for wmf/1.42.0-wmf.5

https://gerrit.wikimedia.org/r/973414

gerritbot added a project: Patch-For-Review.Nov 14 2023, 3:07 AM
gerritbot added a comment.Nov 14 2023, 3:22 AM

Change 973414 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.5] Branch commit for wmf/1.42.0-wmf.5

https://gerrit.wikimedia.org/r/973414

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2023, 3:30 AM
gerritbot added a comment.Nov 14 2023, 4:01 AM

Change 973892 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.5

https://gerrit.wikimedia.org/r/973892

gerritbot added a project: Patch-For-Review.Nov 14 2023, 4:01 AM

Change 973892 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.5

https://gerrit.wikimedia.org/r/973892

Stashbot added a comment.Nov 14 2023, 4:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-11-14T04:02:57Z] <mwpresync@deploy2002> Started scap: testwikis wikis to 1.42.0-wmf.5 refs T350081

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2023, 4:10 AM
Stashbot added a comment.Nov 14 2023, 4:54 AM

Mentioned in SAL (#wikimedia-operations) [2023-11-14T04:54:13Z] <mwpresync@deploy2002> Finished scap: testwikis wikis to 1.42.0-wmf.5 refs T350081 (duration: 51m 15s)

Stashbot added a comment.Nov 14 2023, 10:03 AM

Mentioned in SAL (#wikimedia-operations) [2023-11-14T10:03:56Z] <jnuche@deploy2002> Started scap: testwikis wikis to 1.42.0-wmf.5 refs T350081

Stashbot added a comment.Nov 14 2023, 10:24 AM

Mentioned in SAL (#wikimedia-operations) [2023-11-14T10:24:16Z] <jnuche@deploy2002> Finished scap: testwikis wikis to 1.42.0-wmf.5 refs T350081 (duration: 20m 19s)

gerritbot added a comment.Nov 14 2023, 7:06 PM

Change 974255 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.5

https://gerrit.wikimedia.org/r/974255

gerritbot added a project: Patch-For-Review.Nov 14 2023, 7:06 PM

Change 974255 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.5

https://gerrit.wikimedia.org/r/974255

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2023, 7:10 PM
Stashbot added a comment.Nov 14 2023, 7:14 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-14T19:14:13Z] <jhuneidi@deploy2002> rebuilt and synchronized wikiversions files: group0 wikis to 1.42.0-wmf.5 refs T350081

gerritbot added a comment.Nov 15 2023, 7:09 PM

Change 974676 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.5

https://gerrit.wikimedia.org/r/974676

gerritbot added a project: Patch-For-Review.Nov 15 2023, 7:09 PM

Change 974676 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.5

https://gerrit.wikimedia.org/r/974676

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2023, 7:10 PM
Stashbot added a comment.Nov 15 2023, 7:17 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-15T19:17:45Z] <jhuneidi@deploy2002> rebuilt and synchronized wikiversions files: group1 wikis to 1.42.0-wmf.5 refs T350081

Stashbot added a comment.Nov 15 2023, 7:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-15T19:23:38Z] <jhuneidi@deploy2002> Synchronized php: group1 wikis to 1.42.0-wmf.5 refs T350081 (duration: 05m 52s)

Jdlrobson added subscribers: KSarabia-WMF, Jdlrobson.Nov 16 2023, 1:12 AM

Heads up that T351362 is likely to trigger our client error alerting systems with roll out of the train. User impact appears relatively low, but error rate is already 1187 errors in group 1 wikis so we might want to rush out a fix tomorrow either before or after the train runs depending on how much the error rate increases. Please ping me or @KSarabia-WMF for any questions.

gerritbot added a comment.Nov 16 2023, 7:02 PM

Change 975071 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.5

https://gerrit.wikimedia.org/r/975071

gerritbot added a project: Patch-For-Review.Nov 16 2023, 7:02 PM

Change 975071 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.5

https://gerrit.wikimedia.org/r/975071

Maintenance_bot removed a project: Patch-For-Review.Nov 16 2023, 7:10 PM
Stashbot added a comment.Nov 16 2023, 7:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-16T19:10:37Z] <jhuneidi@deploy2002> rebuilt and synchronized wikiversions files: group2 wikis to 1.42.0-wmf.5 refs T350081

thcipriani closed this task as Resolved.Nov 17 2023, 7:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits