Page MenuHomePhabricator

Migrate uses of codex-search in MinervaNeue to use CodexModule
Closed, ResolvedPublic2 Estimated Story Points


Replace the use of codex-search-styles with CodexModule.


  • No visual changes in Minerva

Event Timeline

Catrope renamed this task from Migrate uses of codex-search in MinervaNeue to Migrate uses of codex-search in MinervaNeue to use CodexModule.Feb 5 2024, 6:49 PM

Change #1014112 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Replace codex-search-styles with CodexModule

@Catrope is this basically the right replacement for codex-search-styles? Im not sure which components are needed in Minerva?

"": {
			"class": "MediaWiki\\ResourceLoader\\CodexModule",
			"codexStyleOnly": true,
			"codexComponents": [

@bwang I don't believe Minerva uses TypeaheadSearch, does it? Or does it use TahS styles for the CSS-only version of its search bar? Either way, to answer your question, you should list the components that are used in Minerva; you don't have to worry about technical dependencies (e.g. SearchInput needs the styles for TextInput) because those are added in automatically. The codex-search-styles module contains only TypeaheadSearch and its dependencies (which include SearchInput and Button), but you might not need all of those; conversely, it does not contain Radio and Message, but depending on what Minerva uses you might need those. Searching Minerva for the cdx- prefix I only see buttons, but I don't know if there's stuff coming from somewhere else that Minerva might need to style.

Change #1014112 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Replace codex-search-styles with CodexModule

@Jdlrobson / @Mabualruz , I need some guidance on how to test this.

This one can skip QA. Pixel is not reporting any related visual changes.
codex-search-styles is still being loaded by ext.popups.main and mobile.startup so I've bumped the priority of T356690 and T356688.