Replace the use of codex-search-styles with CodexModule.
AC
- No visual changes in Minerva
Replace the use of codex-search-styles with CodexModule.
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Replace codex-search-styles with CodexModule | mediawiki/skins/MinervaNeue | master | +43 -18 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | CCiufo-WMF | T335317 [EPIC] Determine how to support code-splitting when using Codex inside MediaWiki | |||
Resolved | BUG REPORT | ovasileva | T350069 message boxes visually change when full Codex styles module is loaded | ||
Invalid | Feature | None | T338911 Optimize codex-search-styles | ||
In Progress | Catrope | T349423 [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule | |||
Open | None | T356675 Deprecate the codex-search modules and migrate away from them | |||
Resolved | Jdrewniak | T356678 Migrate uses of codex-search in MinervaNeue to use CodexModule |
Change #1014112 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/MinervaNeue@master] Replace codex-search-styles with CodexModule
@Catrope is this basically the right replacement for codex-search-styles? Im not sure which components are needed in Minerva?
"skins.vector.search.codex.styles": { "class": "MediaWiki\\ResourceLoader\\CodexModule", "codexStyleOnly": true, "codexComponents": [ "CdxTypeaheadSearch", "CdxSearchInput", "CdxButton", "CdxRadio", "CdxMessage" ] },
@bwang I don't believe Minerva uses TypeaheadSearch, does it? Or does it use TahS styles for the CSS-only version of its search bar? Either way, to answer your question, you should list the components that are used in Minerva; you don't have to worry about technical dependencies (e.g. SearchInput needs the styles for TextInput) because those are added in automatically. The codex-search-styles module contains only TypeaheadSearch and its dependencies (which include SearchInput and Button), but you might not need all of those; conversely, it does not contain Radio and Message, but depending on what Minerva uses you might need those. Searching Minerva for the cdx- prefix I only see buttons, but I don't know if there's stuff coming from somewhere else that Minerva might need to style.
Change #1014112 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Replace codex-search-styles with CodexModule