Page MenuHomePhabricator

Catrope (Roan Kattouw)
Vue migration team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (333 w, 6 h)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF) [ Global Accounts ]

Recent Activity

Tue, Feb 23

Catrope added a comment to T251974: Pre-plan Vue 2 to Vue 3 migration.

Other notes:

Tue, Feb 23, 9:52 PM · Patch-For-Review, Vue.js Migration
Catrope added a comment to T251974: Pre-plan Vue 2 to Vue 3 migration.

Here's my first stab at a proposal for how we'd provide a smooth migration experience:

Tue, Feb 23, 9:41 PM · Patch-For-Review, Vue.js Migration

Fri, Feb 19

Catrope added a comment to T275180: Nested <a> tag results in corruption.

Huh, for some reason I thought I tested this and confirmed that browsers didn't move this <a> tag, but you're right, they do:

Fri, Feb 19, 5:50 PM · RemexHtml
Catrope created T275180: Nested <a> tag results in corruption.
Fri, Feb 19, 3:07 AM · RemexHtml

Thu, Feb 18

Catrope added a comment to T257579: Security Readiness Review For WVUI and Vector dependencies needed for Vue.js search.

(especially if we can drop the need to transpile code back to ES5)

To elaborate on this: I am currently working on T272104: Allow modules to opt-in to ES6 syntax support and T272882: Upgrade ResourceLoader JS minifier to support ES6, which will allow us to write ES6 code and ship it directly to the browser without using Babel. Modules using this feature would not be loaded in browsers that don't support ES6 (mostly, IE11), but we think that's fine since IE11's market share is low, and Vue 3 doesn't support IE11 anyway.

Thu, Feb 18, 6:33 PM · Security Readiness Reviews, WVUI, Readers-Web-Backlog (Kanbanana-FY-2020-21), user-sbassett, secscrum, Security, Vue.js (Vue.js-Search)

Wed, Feb 17

Catrope updated Catrope.
Wed, Feb 17, 6:13 PM
Catrope added a comment to T266203: Notifications: Research: Map Junior Contributors' current notification experience.

Some relevant tasks from previous times people brought up the idea of sending watchlist emails by default:

Wed, Feb 17, 6:06 PM · Editing-team (FY2020-21 Kanban Board), Editing Design, DiscussionTools, OWC2020
Catrope updated subscribers of T272882: Upgrade ResourceLoader JS minifier to support ES6.

Digging into this further, @Krinkle and I found that, because MinifyJS uses regexes, it can't successfully tell whether / is a division operator or the start of a regex, even with reasonable (non-contrived) inputs. For example,

let num = (foo + bar) / baz, rx = /.global(ly)? unique(ness?)/;
// incorrectly minifies to
let num=(foo+bar)/ baz, rx = /.global(ly)?unique(ness?)/
Wed, Feb 17, 2:31 AM · Wikimedia-Minify, Vue.js Migration, Patch-For-Review, Performance-Team (Radar), MediaWiki-ResourceLoader

Sun, Feb 7

He7d3r awarded T30563: WikiEditor - Streamlining and customizing the groups or modules loaded by default should require less manual scripting a Heartbreak token.
Sun, Feb 7, 10:07 PM · WikiEditor

Wed, Jan 27

Catrope added a comment to T272882: Upgrade ResourceLoader JS minifier to support ES6.

Pull request now up: https://github.com/matthiasmullie/minify/pull/358

Wed, Jan 27, 8:33 PM · Wikimedia-Minify, Vue.js Migration, Patch-For-Review, Performance-Team (Radar), MediaWiki-ResourceLoader
Catrope edited P13990 MinifyJS benchmark with patches.
Wed, Jan 27, 5:42 PM · Vue.js
Catrope added a comment to T272882: Upgrade ResourceLoader JS minifier to support ES6.

https://github.com/matthiasmullie/minify/commit/8538190f4ab21f77c938e51109547f0e943f7d44 would probably fix the slowness in that regex. Thanks for tracking that down!

Wed, Jan 27, 5:34 PM · Wikimedia-Minify, Vue.js Migration, Patch-For-Review, Performance-Team (Radar), MediaWiki-ResourceLoader
Catrope created P13990 MinifyJS benchmark with patches.
Wed, Jan 27, 5:29 PM · Vue.js

Tue, Jan 26

Catrope added a comment to T272882: Upgrade ResourceLoader JS minifier to support ES6.

For the OOUI input case, most of the slowness occurs on this line:

// multi-line comments
$this->registerPattern('/\n?\/\*(!|.*?@license|.*?@preserve).*?\*\/\n?/s', $callback);

Commenting it out speeds up minification of oojs-ui-core.js from 2372ms to 475ms.

Tue, Jan 26, 5:59 AM · Wikimedia-Minify, Vue.js Migration, Patch-For-Review, Performance-Team (Radar), MediaWiki-ResourceLoader
Jdforrester-WMF awarded P13951 MinifyJS benchmark a Pterodactyl token.
Tue, Jan 26, 5:16 AM · Vue.js
Catrope added a comment to T272882: Upgrade ResourceLoader JS minifier to support ES6.

Benchmark results:

1vagrant@vagrant:/vagrant/mediawiki$ php maintenance/benchmarks/compareJavaScriptMinifiers.php
2Comparing JavaScriptMinifier and MinifyJS over 10 iterations on 22 files.
3resources/lib/jquery/jquery.js (c0952713; 274 KiB)
4 JavaScriptMinifier — mean: 384.57 ms max: 488.82 ms rate: 2.60 /s output size: 138 KiB
5 MinifyJS — mean: 234.18 ms max: 264.27 ms rate: 4.27 /s output size: 138 KiB
6resources/lib/moment/moment.js (d38ff349; 170 KiB)
7 JavaScriptMinifier — mean: 211.07 ms max: 212.64 ms rate: 4.74 /s output size: 95 KiB
8 MinifyJS — mean: 61.64 ms max: 64.69 ms rate: 16.22 /s output size: 94 KiB
9resources/lib/ooui/oojs-ui-core.js (dad36a60; 415 KiB)
10 JavaScriptMinifier — mean: 361.65 ms max: 363.50 ms rate: 2.77 /s output size: 171 KiB
11 MinifyJS — mean: 2471.11 ms max: 2606.90 ms rate: 0.40 /s output size: 170 KiB
12resources/lib/ooui/oojs-ui-widgets.js (5b440e05; 175 KiB)
13 JavaScriptMinifier — mean: 176.22 ms max: 179.01 ms rate: 5.67 /s output size: 76 KiB
14 MinifyJS — mean: 571.74 ms max: 589.22 ms rate: 1.75 /s output size: 76 KiB
15resources/lib/ooui/oojs-ui-windows.js (d756645c; 115 KiB)
16 JavaScriptMinifier — mean: 103.59 ms max: 138.64 ms rate: 9.65 /s output size: 41 KiB
17 MinifyJS — mean: 195.90 ms max: 230.51 ms rate: 5.10 /s output size: 40 KiB
18resources/lib/pako/pako_deflate.js (1289ef06; 125 KiB)
19 JavaScriptMinifier — mean: 127.57 ms max: 130.69 ms rate: 7.84 /s output size: 43 KiB
20 MinifyJS — mean: 207.61 ms max: 226.70 ms rate: 4.82 /s output size: 43 KiB
21resources/lib/qunitjs/qunit.js (5c66acc7; 186 KiB)
22 JavaScriptMinifier — mean: 239.57 ms max: 244.34 ms rate: 4.17 /s output size: 100 KiB
23 MinifyJS — mean: 104.62 ms max: 106.47 ms rate: 9.56 /s output size: 100 KiB
24resources/lib/sinonjs/sinon.js (1636edf4; 210 KiB)
25 JavaScriptMinifier — mean: 272.84 ms max: 278.47 ms rate: 3.67 /s output size: 113 KiB
26 MinifyJS — mean: 42.81 ms max: 44.07 ms rate: 23.36 /s output size: 160 KiB
27resources/lib/vue/vue.common.dev.js (158c9e53; 313 KiB)
28 JavaScriptMinifier — mean: 440.87 ms max: 466.50 ms rate: 2.27 /s output size: 191 KiB
29 MinifyJS — mean: 1062.01 ms max: 1097.15 ms rate: 0.94 /s output size: 191 KiB
30resources/lib/vue/vue.common.prod.js (bc41beb5; 91 KiB)
31 JavaScriptMinifier — mean: 314.83 ms max: 330.20 ms rate: 3.18 /s output size: 91 KiB
32 MinifyJS — mean: 45.72 ms max: 63.95 ms rate: 21.87 /s output size: 91 KiB
33extensions/3D/modules/three/three.js (14c96de7; 1.01 MiB)
34 JavaScriptMinifier — mean: 1623.01 ms max: 1675.28 ms rate: 0.62 /s output size: 730 KiB
35 MinifyJS — mean: 474.18 ms max: 515.94 ms rate: 2.11 /s output size: 727 KiB
36extensions/CodeEditor/modules/ace/ace.js (95b0f780; 702 KiB)
37 JavaScriptMinifier — mean: 1154.19 ms max: 1205.26 ms rate: 0.87 /s output size: 482 KiB
38 MinifyJS — mean: 329.42 ms max: 344.20 ms rate: 3.04 /s output size: 480 KiB
39extensions/CodeEditor/modules/ace/mode-php.js (776d2e29; 581 KiB)
40 JavaScriptMinifier — mean: 292.32 ms max: 340.70 ms rate: 3.42 /s output size: 483 KiB
41 MinifyJS — mean: 549.18 ms max: 561.91 ms rate: 1.82 /s output size: 483 KiB
42extensions/CodeEditor/modules/ace/mode-php_laravel_blade.js (b24fc5f1; 588 KiB)
43 JavaScriptMinifier — mean: 311.58 ms max: 332.62 ms rate: 3.21 /s output size: 488 KiB
44 MinifyJS — mean: 563.84 ms max: 576.62 ms rate: 1.77 /s output size: 488 KiB
45extensions/CodeEditor/modules/ace/worker-xquery.js (6fff22ab; 3.34 MiB)
46 JavaScriptMinifier — mean: 5587.48 ms max: 5654.80 ms rate: 0.18 /s output size: 1.75 MiB
47 MinifyJS — mean: 65581.92 ms max: 66583.79 ms rate: 0.02 /s output size: 1.74 MiB
48extensions/Graph/lib/vega2/vega.js (92d0f434; 618 KiB)
49 JavaScriptMinifier — mean: 1150.84 ms max: 1189.06 ms rate: 0.87 /s output size: 421 KiB
50 MinifyJS — mean: 486.24 ms max: 495.74 ms rate: 2.06 /s output size: 419 KiB
51extensions/Kartographer/lib/external/mapbox/mapbox-lib.js (c2260fd8; 525 KiB)
52 JavaScriptMinifier — mean: 677.43 ms max: 707.80 ms rate: 1.48 /s output size: 262 KiB
53 MinifyJS — mean: 309.50 ms max: 311.94 ms rate: 3.23 /s output size: 260 KiB
54extensions/TimedMediaHandler/resources/mwembed/lib/binPlayers/ogv.js/ogv-decoder-video-av1.js (f22c4569; 912 KiB)
55 JavaScriptMinifier — mean: 4194.16 ms max: 4244.98 ms rate: 0.24 /s output size: 913 KiB
56 MinifyJS — mean: 249.50 ms max: 253.46 ms rate: 4.01 /s output size: 912 KiB
57extensions/TimedMediaHandler/resources/videojs/alt/video.core.min.js (9ab3ab78; 212 KiB)
58 JavaScriptMinifier — mean: 563.50 ms max: 576.02 ms rate: 1.77 /s output size: 212 KiB
59 MinifyJS — mean: 119.31 ms max: 121.11 ms rate: 8.38 /s output size: 212 KiB
60extensions/VisualEditor/lib/ve/dist/visualEditor-rebase.js (b1912746; 2.32 MiB)
61 JavaScriptMinifier — mean: 3013.94 ms max: 3046.76 ms rate: 0.33 /s output size: 1.19 MiB
62 MinifyJS — mean: 83.16 ms max: 89.02 ms rate: 12.02 /s output size: 2.32 MiB
63extensions/VisualEditor/lib/ve/dist/visualEditor.js (65ec015e; 2.19 MiB)
64 JavaScriptMinifier — mean: 2489.80 ms max: 2554.97 ms rate: 0.40 /s output size: 1.08 MiB
65 MinifyJS — mean: 112.99 ms max: 124.52 ms rate: 8.85 /s output size: 2.17 MiB
66extensions/Wikibase/client/data-bridge/dist/data-bridge.app.js (6615f253; 209 KiB)
67 JavaScriptMinifier — mean: 559.54 ms max: 562.91 ms rate: 1.79 /s output size: 207 KiB
68 MinifyJS — mean: 147.67 ms max: 162.85 ms rate: 6.77 /s output size: 209 KiB

Tue, Jan 26, 5:11 AM · Wikimedia-Minify, Vue.js Migration, Patch-For-Review, Performance-Team (Radar), MediaWiki-ResourceLoader
Catrope created P13951 MinifyJS benchmark.
Tue, Jan 26, 5:04 AM · Vue.js

Jan 25 2021

Catrope added a subtask for T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015): T272882: Upgrade ResourceLoader JS minifier to support ES6.
Jan 25 2021, 5:45 PM · Performance-Team, JavaScript, MediaWiki-ResourceLoader
Catrope added a parent task for T272882: Upgrade ResourceLoader JS minifier to support ES6: T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015).
Jan 25 2021, 5:45 PM · Wikimedia-Minify, Vue.js Migration, Patch-For-Review, Performance-Team (Radar), MediaWiki-ResourceLoader
Catrope moved T251974: Pre-plan Vue 2 to Vue 3 migration from Backlog to Vue.js Migration on the Vue.js board.
Jan 25 2021, 5:37 PM · Patch-For-Review, Vue.js Migration

Jan 23 2021

Catrope added a comment to T272104: Allow modules to opt-in to ES6 syntax support.

My patch above implements what I outlined in T272104#6750238. A module can add "es6": true to its definition to mark itself as ES6-only, and loading such a module will throw an error on non-ES6 browsers. This error is handled similarly to other module loading errors, so it fails the promise when using mw.loader.using()but is suppressed when using mw.loader.load().

Jan 23 2021, 7:47 AM · Vue.js Migration, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader

Jan 22 2021

Catrope added a comment to T272104: Allow modules to opt-in to ES6 syntax support.

Does that actually throw a catchable exception, rather than error as unparseable?

Yes, as long as it's wrapped in eval(). Attempting to eval() code that contains a syntax error throws a catchable exception.

Jan 22 2021, 2:13 AM · Vue.js Migration, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Catrope added a comment to T272104: Allow modules to opt-in to ES6 syntax support.

ES6 compatibility isn't easy to test for, because there are so many aspects of ES6. I looked through kangax's compatibility tables and explored using native Promise support as a proxy for "good enough" ES6 support. That seems to work relatively well. If we ignore tail call optimization (which is not supported even by recent versions of Chrome), the only browsers that support Promise but don't support some ES6 features are:

  • Android 4.4.3: supports Promise but almost nothing else
  • Safari 12 - 13.1, iOS <14: doesn't support using certain Unicode characters in identifiers
  • iOS <11: doesn't support scope shadowing resolution and shadowing parameters in for-in loop bindings
  • Safari 12 ,12.1: doesn't do template string caching correctly (which leads to equality checks sometimes breaking)
  • Edge 17, 18: Many RegExp-related features are missing, including Symbol.match, and some other ES6-y things (like proxies) don't work when RegExp objects are involved
Jan 22 2021, 1:10 AM · Vue.js Migration, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Catrope added a comment to T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015).

And some additional numbers from opening that page in older browsers via BrowserStack:

  • Safari 9: 53% spec compliant
  • Safari 10.1: 98% spec compliant
  • Mobile Safari iOS 9: 53% spec compliant
  • Mobile Safari iOS 10.0: 98% spec compliant
  • Android 4.4 (evergreen, Chrome 80): 98% spec compliant
  • Android 4.3 ("Browser" like Chrome 68): 98% spec compliant

If you check the "show obsolete platforms" checkbox on kangax's es6 tables, you'll see that it claims that Android 4.4 is 5% compliant, and Android 4.4.3 is 7% compliant.

Jan 22 2021, 12:14 AM · Performance-Team, JavaScript, MediaWiki-ResourceLoader

Jan 15 2021

Catrope added a comment to T272104: Allow modules to opt-in to ES6 syntax support.

Alongside this, I think we should also formalize the notion of grade B (in between grade A and grade C) in ResourceLoader. Modules that are flagged as using ES6 should not be executed in browsers that don't support ES6 (most prominently including IE11). ResourceLoader currently does not have a concept of per-module executability, only a global one: the startup code feature-detects ES5 support, and either decides that no JavaScript is going to be executed or that everything can be. In browsers that support ES5 but not ES6 (like IE11), we'd presumably want to execute the ES5-compatible modules, but not the ES6 ones.

Jan 15 2021, 4:26 AM · Vue.js Migration, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader

Jan 12 2021

Catrope added a comment to T270137: Document deployment process for Growth features.

@Catrope -- is the above your only/final feedback on the documentation?

Jan 12 2021, 9:27 PM · Growth-Team (Current Sprint)

Jan 11 2021

Catrope added a comment to T256887: Enable ORES filters for ukwiki (Ukrainian Wikipedia).

This confused me for a while, but I think I found an OK configuration. The stats are a bit strange though - for other wikis that I have seen precision and recall are more or less an "X" shape for the "bad" outcomes, while here especially for goodfaith precision is not even remotely monotonic, and it's just not possible to reach better precision than 0.6. Is that legit?

Jan 11 2021, 10:03 PM · Growth-Team (Current Sprint), Edit-Review-Improvements-Integrated-Filters, editquality-modeling, artificial-intelligence, Machine-Learning-Team

Jan 8 2021

Catrope added a comment to T271124: Add a link engineering: deal with word boundaries (\b) being broken in JS.

Stepping back a bit, as mentioned in the task description, I think we should probably not use word boundaries and instead rely on other metadata from T267329 (ie instance occurence) to make the correct link.

We could use instance occurrence, if both mwaddlink and the frontend agree that that counter includes sub-word strings. For example, in A scary [[car]] careens, there would be three occurrences of "car", and the linked one would be the second one. Using context_before/context_after could potentially be more resilient, as long as mwparserfromhell and the Parsoid HTML agree on what counts as text and where block-level boundaries (e.g. paragraph boundaries) are.

Jan 8 2021, 7:17 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks

Jan 6 2021

Catrope updated subscribers of T271294: New empty definitions and translations are ignored on import by processMessageGroupChanges.php.

I don't remember any examples offhand, but this has definitely happened before (cc @Jdforrester-WMF )

Jan 6 2021, 2:22 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), MediaWiki-extensions-Translate, Unplanned-Sprint-Work, Language-Team (Language-2021-January-March)

Jan 5 2021

Catrope added a comment to T270137: Document deployment process for Growth features.
  • Identifying / backporting missing l10n. There is some script for this but I couldn't remember the details.

The way I recommend doing this is:

  • Add the language code of the new target wiki to the requireCompleteTranslationLanguages array in Gruntfile.js
  • Run grunt banana:translations (in master or in the currently-deployed wmf branch, depending on how soon you plan to deploy)

The output of this script is not ideal, but it's workable. Languages are listed multiple times, once for each i18n subdirectory, and they're not grouped together (the grouping is by subdir then language). It also complains about missing translations for messages that are optional and don't have to be translated, but there aren't very many of them.

Jan 5 2021, 2:55 PM · Growth-Team (Current Sprint)
Catrope added a comment to T271124: Add a link engineering: deal with word boundaries (\b) being broken in JS.

Oh wow that's sad. They could be expressed with Unicode property escapes (something like ([\p{L}\p{N}\p{M}][^\p{L}\p{N}\p{M}]|[^\p{L}\p{N}\p{M}][\p{L}\p{N}\p{M}]) I think?) but apparently IE doesn't support those.

Another alternative is to use unicodeJS.characterclass.patterns.word, which is a fully Unicode-compliant regex for word characters. From that we could try to concoct a regex that uses lookahead/lookbehind to implement word boundaries somehow (which we would also have to do if we use \p{L} and friends).

Jan 5 2021, 10:50 AM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
Catrope created T271198: Visual diff does not display preformatted text correctly.
Jan 5 2021, 10:29 AM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Skipped QA, Editing-team (FY2020-21 Kanban Board), VisualEditor, VisualEditor-VisualDiffs

Jan 4 2021

Catrope created T271124: Add a link engineering: deal with word boundaries (\b) being broken in JS.
Jan 4 2021, 5:09 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks

Dec 18 2020

Catrope added a comment to T270146: New Vector breaks OO.ui.Element.static.scrollIntoView and sticky layouts.

For the product owners wanting to prioritize this, can we update the description with how this impacts products? I'm also like us to add a test for this given the times this has broken, so that would be helpful for working out where this should go.

The impact is that all features involving programmatically scrolling something into view don't work in new Vector. In VisualEditor alone, this includes scrolling down the editor to display the highlighted text when doing find and replace, and scrolling such that the entire inspector is visible when clicking a link or reference near the bottom of the screen. I discovered this issue when working on T261398, where navigating to the next link recommendation may require scrolling down the editor to make it visible.

Dec 18 2020, 1:55 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Vector, OOUI

Dec 15 2020

Catrope added a comment to T267707: Add a link in VE: disable the editor.

It looks like putting the surface in read-only mode works quite well for this. The only drawbacks I've found so far is that we have to toggle read-only mode when we want to change the acceptance status of a recommendation (but to avoid a flash in the UI, we can toggle only the DM surface), and that context items show a "View" button instead of an "Edit" button (but we can work around that for the link recommendation context item, and it's appropriate for the link context item).

Dec 15 2020, 9:25 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope created T270146: New Vector breaks OO.ui.Element.static.scrollIntoView and sticky layouts.
Dec 15 2020, 1:25 AM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Vector, OOUI

Dec 14 2020

Catrope added a comment to T267691: Add a link in VE: load addlink data from REST API earlier.

We could maybe also use BeforePageDisplay hook to export this data from the server-side. The data is not particularly heavy and should be fast to retrieve.

Dec 14 2020, 10:46 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks

Dec 10 2020

Catrope closed T267692: Allow plugin modules to be added in JS on mobile, a subtask of T261398: Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach, as Resolved.
Dec 10 2020, 10:53 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope closed T267692: Allow plugin modules to be added in JS on mobile as Resolved.

I think this is resolved, now that the patch is merged.

Dec 10 2020, 10:53 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Patch-For-Review, VisualEditor-Initialisation, VisualEditor, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope added a comment to T263220: Limit concurrency of DPL queries.

@Urbanecm noticed errors in the logs that looked like Pool key 'nowait:dpl-query:enwikinews' (DPL): Error reading from pool counter server 10.64.0.151., and asked me to revert

Dec 10 2020, 7:27 PM · SRE, serviceops, PoolCounter, Platform Team Workboards (Clinic Duty Team), MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Performance Issue, Patch-For-Review, DynamicPageList (Wikimedia)
Catrope closed T267705: Add a link in VE: issues with opening context when selection is at the edges of an annotation, a subtask of T261398: Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach, as Resolved.
Dec 10 2020, 5:11 AM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope closed T267705: Add a link in VE: issues with opening context when selection is at the edges of an annotation as Resolved.

Can this be fixed using ve.ce.Surface#selectAnnotation?

Dec 10 2020, 5:11 AM · Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope moved T269804: Banner module on the Growth homepage from Code Review to QA on the Growth-Team (Current Sprint) board.
Dec 10 2020, 2:37 AM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope added a comment to T269804: Banner module on the Growth homepage.

@Tgr -- thank you! I think we would like to backport this tomorrow if possible. The community members are writing the copy now. A couple questions:

  • Would this be immediately usable on any wiki?

Yes. Community members can also put the copy on the MediaWiki config page preemptively, before we deploy this feature tomorrow, and the banner text will appear immediately. In fact, that would be preferred, for ease of testing.

Dec 10 2020, 2:32 AM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope added a comment to T269477: [wmf.21-regression] RC/Watchlist -misaligned close icon in oo-ui-tagMultiselectWidget-group .

Even with above patches, we might need an additional OOUI release, given the number of interfaces that use TagItemWidget. Could need your help Growth team member devs tomorrow.

Dec 10 2020, 2:19 AM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Patch-For-Review, Growth-Team (Current Sprint), Regression, OOUI

Dec 9 2020

Catrope added a comment to T268707: Add a link: task type info in suggested edits module.

This patch adds the messages, but it doesn't add the robot icon. I'm also not sure if paragraph breaks are currently supported in those tooltips, I'll have to check.

Dec 9 2020, 5:08 AM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks

Nov 24 2020

Catrope added a comment to T258017: Variant D: difficulty overlay in onboarding.

If you have suggestions for how to fix the text alignment (item (g) in your comment above), I'm all ears. Both the text and the icon have vertical-align: middle, and neither has vertical padding or margin, so I don't know what else to do.

Nov 24 2020, 4:49 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T258016: Variant C: onboarding from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.
Nov 24 2020, 3:33 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Nov 19 2020

Catrope committed rWVUI8adb77224d23: 0.0.2-next.2020-11-19-21-55.0 (authored by Catrope).
0.0.2-next.2020-11-19-21-55.0
Nov 19 2020, 10:21 PM

Nov 11 2020

Catrope created T267707: Add a link in VE: disable the editor.
Nov 11 2020, 1:53 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope added a comment to T267705: Add a link in VE: issues with opening context when selection is at the edges of an annotation.

If we decide to purse T267706: Add a link in VE: consider using a permanent context instead of VE's built-in context, that might obviate these problems.

Nov 11 2020, 1:48 AM · Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope created T267706: Add a link in VE: consider using a permanent context instead of VE's built-in context.
Nov 11 2020, 1:47 AM · Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope created T267705: Add a link in VE: issues with opening context when selection is at the edges of an annotation.
Nov 11 2020, 1:29 AM · Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope created T267704: Add a link in VE: implement rejection dialog.
Nov 11 2020, 1:22 AM · Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope created T267703: Add a link in VE: enforce a maximum number of recommendations.
Nov 11 2020, 1:14 AM · Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks

Nov 10 2020

Catrope created T267696: Add a link in VE: make the edit button in the context item open the link inspector when clicked.
Nov 10 2020, 11:49 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, Growth-Team, Add-Link, Growth-Structured-Tasks
Catrope created T267695: Add a link in VE: handle span-wrapped entities and annotations when finding link recommendation phrases.
Nov 10 2020, 11:48 PM · Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope added a comment to T267694: Add a link in VE: define exclusion rules for finding text in the DOM.

One thing that is clearly deficient about the current rules is that it doesn't handle about groups: in HTML like <span typeof="mw:Transclusion" about="#mwt1">...</span><div about="#mwt1">...</div> both nodes should be skipped, but the current implementation skips only the first one.

Nov 10 2020, 11:41 PM · Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope created T267694: Add a link in VE: define exclusion rules for finding text in the DOM.
Nov 10 2020, 11:39 PM · Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope created T267693: Add a link in VE: figure out the most efficent way to find all annotations of a given type.
Nov 10 2020, 11:37 PM · VisualEditor, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope placed T267691: Add a link in VE: load addlink data from REST API earlier up for grabs.
Nov 10 2020, 11:30 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope created T267692: Allow plugin modules to be added in JS on mobile.
Nov 10 2020, 11:30 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Patch-For-Review, VisualEditor-Initialisation, VisualEditor, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope created T267691: Add a link in VE: load addlink data from REST API earlier.
Nov 10 2020, 11:25 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope created T267690: Add a link in VE: don't write to or read from restored edits.
Nov 10 2020, 11:20 PM · Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
Catrope moved T257936: Support the WebRequest / WebResponse SameSite behavior on the JS side from Code Review to QA on the Growth-Team (Current Sprint) board.
Nov 10 2020, 2:46 AM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Growth-Team-Leftovers, Growth-Team (Current Sprint), JavaScript, MediaWiki-General
Catrope added a comment to T259572: [Technical research] What discussion-specific notifications do people currently receive?.

Another relevant piece of information is that some notification types supersede others. There is no systematic guarantee that the same event/edit/comment won't result in multiple notifications being sent to the same user, but we do try to make it that way through these supersedence rules:

Nov 10 2020, 2:32 AM · Growth-Team (Current Sprint), Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020
Catrope added a comment to T259572: [Technical research] What discussion-specific notifications do people currently receive?.

Spreadsheet with the above notification types, when they're triggered, and what their text looks like in English: https://docs.google.com/spreadsheets/d/1MbLZKCc2Yy3q90Y78qSxUtBLLyGAzUm2oDHMeXVYq8g/edit

Nov 10 2020, 2:12 AM · Growth-Team (Current Sprint), Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020

Nov 9 2020

Catrope added a comment to T259572: [Technical research] What discussion-specific notifications do people currently receive?.

@Catrope does this spreadsheet accurately and exhaustively capture all of the notifications people could receive triggered by events on flow or wikitext talk pages?

Nov 9 2020, 9:35 PM · Growth-Team (Current Sprint), Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020

Nov 2 2020

Catrope added a comment to T265092: [M] Empty state message is mangled in Hebrew.

I've edited the Hebrew message on TWN to work around this bug: https://translatewiki.net/w/i.php?title=MediaWiki:Wikibasemediainfo-special-mediasearch-empty-state/he&diff=prev&oldid=9688010

Nov 2 2020, 11:27 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
Catrope added a comment to T265092: [M] Empty state message is mangled in Hebrew.

The cause of this issue is T249892: mw.message.parse() should not escape HTML returned from magic words (e.g. {{PLURAL}}). The Hebrew translation of the message looks something like Search more than {{PLURAL:$1|<span class="...">one</span> file that is|<span class="...">$1</span> files that are}} free to use. This syntax (putting HTML syntax inside of a PLURAL magic word) works in PHP, but breaks in JavaScript because of a bug.

Nov 2 2020, 11:05 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
Catrope placed T181466: Watchlist doesn't handle pages beginning with slash properly up for grabs.
Nov 2 2020, 10:45 PM · Growth-Team, User-thiemowmde, WMDE-Technical-Wishes-Maintenance, Technical-Debt, CatWatch, MediaWiki-Watchlist
Catrope closed T181466: Watchlist doesn't handle pages beginning with slash properly as Resolved.

Still not broken for me on testwiki, closing

Nov 2 2020, 10:44 PM · Growth-Team, User-thiemowmde, WMDE-Technical-Wishes-Maintenance, Technical-Debt, CatWatch, MediaWiki-Watchlist
Catrope updated subscribers of T257220: Deploy Growth features on Swedish Wikipedia.

Russian Wikipedia also encountered this issue, and we created a task about it at the time: T261714: Support posting new help desk questions at the top of the page.

Nov 2 2020, 6:56 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.9; 2020-09-15)

Oct 26 2020

Catrope moved T266501: [testwiki wmf.14] Cannot read property 'length' of null at PostEditPanel.logImpression from Code Review to QA on the Growth-Team (Current Sprint) board.
Oct 26 2020, 10:04 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T266501: [testwiki wmf.14] Cannot read property 'length' of null at PostEditPanel.logImpression from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Oct 26 2020, 9:31 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T259832: mediawiki-vendor submodule doesn't get automatically bumped on release branches.

It worked this time, the submodule update was created automatically without my intervention.

Oct 26 2020, 6:49 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), User-brennen, Release-Engineering-Team (Deployment services), Patch-For-Review, Parsoid

Oct 22 2020

Catrope moved T258017: Variant D: difficulty overlay in onboarding from QA to Code Review on the Growth-Team (Current Sprint) board.
Oct 22 2020, 11:52 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258017: Variant D: difficulty overlay in onboarding.

Change 634755 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Make image in difficulty banner top aligned, fix padding

https://gerrit.wikimedia.org/r/634755

This patch does the 24/16 thing for item (c).

Oct 22 2020, 11:52 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T258019: Variant D (desktop): embed onboarding dialog into suggested edits module from QA to Code Review on the Growth-Team (Current Sprint) board.

Change 635904 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Use smaller padding for mobile in various places

https://gerrit.wikimedia.org/r/635904

Oct 22 2020, 11:52 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T258016: Variant C: onboarding from QA to Code Review on the Growth-Team (Current Sprint) board.
Oct 22 2020, 11:50 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258016: Variant C: onboarding.

Change 635904 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Use smaller padding for mobile in various places

https://gerrit.wikimedia.org/r/635904

Oct 22 2020, 11:50 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Oct 21 2020

Catrope moved T266033: SE intro overlay - labels length and text positioning from Code Review to QA on the Growth-Team (Current Sprint) board.
Oct 21 2020, 10:40 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T266033: SE intro overlay - labels length and text positioning.

Change 635639 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Work around CSSJanus flipping bug

https://gerrit.wikimedia.org/r/635639

Oct 21 2020, 8:54 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments
Catrope claimed T266033: SE intro overlay - labels length and text positioning.
Oct 21 2020, 8:46 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258016: Variant C: onboarding.

I'm being a bit silly here: I just removed variant A, so it doesn't make sense for me to complain that something doesn't look good in it. I've also added the 16px bottom padding so it looks better:

Oct 21 2020, 7:53 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Oct 20 2020

Catrope moved T265754: Variant C/D: inconsistencies with welcome survey and discovery popups from In Progress to QA on the Growth-Team (Current Sprint) board.
Oct 20 2020, 12:44 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Growth-Team-Leftovers, GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint)

Oct 19 2020

Catrope claimed T265751: Variant C/D: autoscroll on Variant D.

I was able to reproduce this by making my window short enough that the bottom of the suggested edits onboarding was out of view. I tracked down the issue by running $(window).on( 'scroll', function () { debugger; } ); during load and inspecting the call stack. It turns out that OO.ui.Window.prototype.ready calls this.$content.trigger( 'focus' ), which causes Chrome (but not Firefox) to scroll down so that it's centered.

Oct 19 2020, 10:49 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team-Leftovers, Growth-Team (Current Sprint), NewcomerTasks Future Release
Catrope moved T243445: Deploy Growth features on Turkish Wikipedia from Needs More Work to QA on the Growth-Team (Current Sprint) board.

This is live now! I apologize for the delays and the postponement. Other deployments were postponed/canceled and we had to wait for those.

Oct 19 2020, 6:36 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites
Catrope moved T265556: Variant tests: roll out variant C/D from Code Review to Needs More Work on the Growth-Team (Current Sprint) board.

Stage 1 is done, the patch for stage 2 has passed code review, so now we just need to wait for Oct 26 and deploy stage 2 then.

Oct 19 2020, 6:35 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Oct 17 2020

Catrope added a comment to T258017: Variant D: difficulty overlay in onboarding.

Change 634755 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Make image in difficulty banner top aligned, fix padding

https://gerrit.wikimedia.org/r/634755

Oct 17 2020, 10:03 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258016: Variant C: onboarding.

While working on the big 24px->16px change mentioned in T258019#6557184, I noticed that the text in the difficulty banner in the variant C onboarding dialog was vertically centered on desktop, but should instead be top-aligned according to the mocks. The attached patch fixes that in both variant A and variant C.

Oct 17 2020, 10:02 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258019: Variant D (desktop): embed onboarding dialog into suggested edits module.

Desktop issues:

Left and right padding in the desktop module intro topic area should only be 16px (not 24px)

Kosta's patch fixed this

Oct 17 2020, 3:35 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Oct 16 2020

Catrope moved T258016: Variant C: onboarding from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.
Oct 16 2020, 8:10 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258016: Variant C: onboarding.

Looking at var C only per this task, some items still to be fixed (or were maybe reverted at some point?):

All these screenshots are from variant A though (as you can tell by the presence of the start module in the background, and the topic filters below the intro section.

Oct 16 2020, 8:08 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T258017: Variant D: difficulty overlay in onboarding from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.

a. Similar to comment on T258019#6510238 - please make the Desktop left and right padding 16px for the module

This is fixed now, with Kosta's patch for that issue.

Oct 16 2020, 1:06 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop.

(ii) This also means updating the total card width according, done by adjusting the class .suggested-edits-task-card-wrapper to have a width:332px.

Done, on desktop. But what should happen on mobile? Currently mobile uses 260x128 for the image dimensions, should that change to something else?

No, we are keeping mobile as is (since we haven't made the same layout changes to mobile where there is just the SE module).

Great, that makes it easy.

Oct 16 2020, 12:34 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments

Oct 15 2020

Catrope moved T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop from In Progress to Code Review on the Growth-Team (Current Sprint) board.

Change 634138 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Change image size, styling tweaks

https://gerrit.wikimedia.org/r/634138

Oct 15 2020, 2:29 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments

Oct 14 2020

Catrope moved T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.

Change 634127 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Fix header icon size and padding

https://gerrit.wikimedia.org/r/634127

Oct 14 2020, 11:55 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
Catrope claimed T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop.
Oct 14 2020, 11:54 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
Catrope set Due Date to Oct 19 2020, 6:00 PM on T265556: Variant tests: roll out variant C/D.
Oct 14 2020, 11:08 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments