Page MenuHomePhabricator

Catrope (Roan Kattouw)
Growth team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (265 w, 6 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF) [ Global Accounts ]

Recent Activity

Today

Catrope moved T236910: Texts in Czech are too long to display well from In Progress to Ready for Development on the Growth-Team (Current Sprint) board.
Tue, Nov 12, 6:25 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T236841: Newcomer Tasks: Make the V1.0 difficulty filter full-width button on the Suggested edits module from In Progress to Ready for Development on the Growth-Team (Current Sprint) board.

Moving back to ready for dev for the mobile changes Rita asked for.

Tue, Nov 12, 6:24 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Mobile, Desktop, Growth-Team (Current Sprint), NewcomerTasks 1.0
Catrope moved T235046: Newcomer tasks: task explanation widget from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Nov 12, 6:21 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
Catrope moved T232513: Newcomer tasks: homepage changes based on initiation (mobile) from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Nov 12, 6:21 PM · NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage

Fri, Nov 8

Catrope merged task T237703: GENewcomerTasksRemoteApiUrl should not need to be configured if using the local API into T235717: Newcomer tasks: non-HTTP-based ConfigurationLoader and TaskSuggester.
Fri, Nov 8, 8:39 PM · Technical-Debt, GrowthExperiments-NewcomerTasks
Catrope merged T237703: GENewcomerTasksRemoteApiUrl should not need to be configured if using the local API into T235717: Newcomer tasks: non-HTTP-based ConfigurationLoader and TaskSuggester.
Fri, Nov 8, 8:39 PM · NewcomerTasks 1.1, Growth-Team (Current Sprint), Patch-For-Review, Technical-Debt
Catrope added a project to T236624: Unable to restore page: IncompleteRevisionException for some revisions: Core Platform Team Workboards (Clinic Duty Team).

This definitely looks like a very deep MCR/core issue to me, not at all a Growth team issue. I don't know how we came to be tagged on the related task, but this is way out of our area of expertise.

Fri, Nov 8, 12:38 AM · Core Platform Team Workboards (Clinic Duty Team), Technical-Debt, Multi-Content-Revisions, Wikimedia-production-error, MediaWiki-Revision-backend
Catrope created T237703: GENewcomerTasksRemoteApiUrl should not need to be configured if using the local API.
Fri, Nov 8, 12:22 AM · Technical-Debt, GrowthExperiments-NewcomerTasks

Thu, Nov 7

Catrope added a comment to T237600: Homepage: unable to distinguish between clicks and impressions on mobile.

If Kosta is right about which change introduced this (I haven't double-checked but he probably is), then this bug hit production on September 5th.

Thu, Nov 7, 10:20 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
Catrope closed T234242: [betalabs-regression] Cannot add/update info on Structured discussion boards as Resolved.

This is now fixed

Thu, Nov 7, 9:42 PM · Beta-Cluster-Infrastructure, Growth-Team, StructuredDiscussions

Tue, Nov 5

Catrope created T237352: Difficulty overlay needs different image and layout on mobile.
Tue, Nov 5, 5:24 AM · Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks
Catrope added a comment to T235046: Newcomer tasks: task explanation widget.

I've added the links to the relevant JSON pages. Note that Arabic has not currently defined an "expand" task type (is this missing, or do we not have templates for it?), so I didn't add that one.

Tue, Nov 5, 1:05 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
Catrope moved T235046: Newcomer tasks: task explanation widget from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Tue, Nov 5, 1:02 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
Catrope created T237344: Newcomer tasks: filters dialog button label is misaligned on mobile.
Tue, Nov 5, 12:58 AM · Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks
Catrope created T237343: Newcomer tasks: filters dialog button should have down indicator, shorter label on mobile.
Tue, Nov 5, 12:57 AM · GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint)
Catrope updated the task description for T237342: Newcomer tasks: TaskExplanationWidget popup should be a pop-under on mobile.
Tue, Nov 5, 12:55 AM · Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks
Catrope created T237342: Newcomer tasks: TaskExplanationWidget popup should be a pop-under on mobile.
Tue, Nov 5, 12:54 AM · Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks
Catrope claimed T235046: Newcomer tasks: task explanation widget.

Yes, this is perfectly reasonable.

Tue, Nov 5, 12:27 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Mon, Nov 4

Catrope moved T235810: Newcomer tasks: mobile preview from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Nov 4, 9:04 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), NewcomerTasks 1.0 , Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T235042: Newcomer tasks: implement difficulty filters from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Nov 4, 7:55 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T236973: Newcomer tasks: 'Done' button still active when no filters are selected from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Nov 4, 7:41 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a subtask for T237301: Newcomer tasks: fix and migrate JSON config pages: T237140: Newcomer tasks module setup is not complete for kowiki betalabs .
Mon, Nov 4, 6:47 PM · Growth-Team (Current Sprint), NewcomerTasks 1.0
Catrope added a parent task for T237140: Newcomer tasks module setup is not complete for kowiki betalabs : T237301: Newcomer tasks: fix and migrate JSON config pages.
Mon, Nov 4, 6:47 PM · NewcomerTasks 1.0 , Growth-Team
Catrope moved T237084: Newcomer tasks: fix result interleaving from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Mon, Nov 4, 6:43 PM · Growth-Team (Current Sprint), NewcomerTasks 1.0
Catrope moved T236885: Newcomer tasks: Use edit tag for edits that originate from Suggested Edits module from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Mon, Nov 4, 6:43 PM · Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Sat, Nov 2

Catrope added a comment to T237149: Arabic text overlaying on icon.

With my patch:

Sat, Nov 2, 9:07 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks
Catrope claimed T237149: Arabic text overlaying on icon.
Sat, Nov 2, 9:03 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks
Catrope edited projects for T237149: Arabic text overlaying on icon, added: GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint); removed Growth-Team, GrowthExperiments.
Sat, Nov 2, 9:03 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks
Catrope added a comment to T236968: Newcomer tasks: hidden preference.

@Catrope - In order to test it - should $wgGEHomepageSuggestedEditsEnabled be set to false for, say, arwiki betalabs?

Sat, Nov 2, 7:33 AM · NewcomerTasks 1.0 , MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments-Homepage

Fri, Nov 1

Catrope moved T235723: Newcomer tasks: intro and difficulty overlays from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Nov 1, 11:40 PM · Growth Design, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T236968: Newcomer tasks: hidden preference.

The attached patch adds $wgGEHomepageSuggestedEditsRequiresOptIn. By default it's set to false, which means all users get the suggested edits feature (current behavior). If it's set to true, only users who enable the preference get the suggested edits feature. The preference is currently hidden, but it could easily be made visible if we decide we want that (we'd just have to write a label for it and get it translated).

Fri, Nov 1, 4:49 AM · NewcomerTasks 1.0 , MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T236968: Newcomer tasks: hidden preference from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Nov 1, 4:46 AM · NewcomerTasks 1.0 , MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope claimed T235723: Newcomer tasks: intro and difficulty overlays.
Fri, Nov 1, 3:45 AM · Growth Design, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope claimed T236968: Newcomer tasks: hidden preference.
Fri, Nov 1, 3:44 AM · NewcomerTasks 1.0 , MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T236641: Create Language method for human-readable numbers.

I'm sure there's some language out there which doesn't use 10^3-based grouping...

Yes. Indic languages use 10^3 for the first group, then increments of 10^2 for all subsequent groups:

Fri, Nov 1, 3:42 AM · Technical-Debt, Growth-Team, NewcomerTasks 1.0 , MediaWiki-Internationalization

Thu, Oct 31

Catrope moved T236910: Texts in Czech are too long to display well from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Thu, Oct 31, 10:09 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T236910: Texts in Czech are too long to display well.

@RHo I had to change your CSS a little bit. Because of the weird way that widths of table columns are negotiated, the width: max-content trick you found doesn't work well. It worked in your codepen, but once I changed the text in the right-hand column to the Czech text (and applied the 700px width constraint and 14px font size used in the dialog), the extra width of that text caused the right column to grow and the left column to shrink, so the "Středně obtížné" text still wraps. The solution I found was to keep width: 20% (which functions more like a min-width, and min-width itself doesn't work), then preventing wrapping using white-space: nowrap

Thu, Oct 31, 10:09 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T208369: Welcome survey: anonymize data after one year from QA to Code Review on the Growth-Team (Current Sprint) board.
Thu, Oct 31, 12:35 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Catrope moved T208369: Welcome survey: anonymize data after one year from Code Review to QA on the Growth-Team (Current Sprint) board.
Thu, Oct 31, 12:34 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Catrope edited projects for T236910: Texts in Czech are too long to display well, added: GrowthExperiments, Growth-Team (Current Sprint); removed GrowthExperiments-NewcomerTasks.

Rita's CSS tweaks: https://codepen.io/reets/pen/eYYEwXr

Thu, Oct 31, 12:04 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments

Wed, Oct 30

Catrope added a comment to T236841: Newcomer Tasks: Make the V1.0 difficulty filter full-width button on the Suggested edits module.

I couldn't find another task offhand for changing the label of the filter button to "Easy, Medium difficulty" instead of just "Easy, Medium", so I linked the patch for that to this task. Let me know if you'd like it to be linked to a different task instead.

Wed, Oct 30, 2:04 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Mobile, Desktop, Growth-Team (Current Sprint), NewcomerTasks 1.0
Catrope claimed T236841: Newcomer Tasks: Make the V1.0 difficulty filter full-width button on the Suggested edits module.
Wed, Oct 30, 2:03 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Mobile, Desktop, Growth-Team (Current Sprint), NewcomerTasks 1.0

Tue, Oct 29

Catrope moved T235043: Newcomer tasks: "No more suggestions" card widget from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Oct 29, 7:15 PM · Growth Design, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope updated subscribers of T236805: Get task types and their difficulties from the tasktypes API instead of hardcoding them in JS.

@Tgr says the ConfigurationLoader service returns this information

Tue, Oct 29, 3:22 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T236805: Get task types and their difficulties from the tasktypes API instead of hardcoding them in JS from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Tue, Oct 29, 3:19 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments
Catrope edited projects for T236805: Get task types and their difficulties from the tasktypes API instead of hardcoding them in JS, added: GrowthExperiments, Growth-Team (Current Sprint); removed NewcomerTasks 1.0 , GrowthExperiments-Homepage.
Tue, Oct 29, 3:19 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments
Catrope created T236805: Get task types and their difficulties from the tasktypes API instead of hardcoding them in JS.
Tue, Oct 29, 3:19 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Growth-Team (Current Sprint), GrowthExperiments

Wed, Oct 16

Catrope created T235720: Security concept review for newcomer tasks on Special:Homepage.
Wed, Oct 16, 11:48 PM · Privacy, Growth-Team (Current Sprint), GrowthExperiments-Homepage, Security-Team-Reviews
Catrope added a comment to T235672: ResourceLoader: Don't add a version hash param in debug mode.

In debug mode the cache control headers are set to no-cache

I'm not 100% sure that they are, but if they're not, they should be. And in any case, dropping the version param will lower the cache time to 5 minutes.

Wed, Oct 16, 4:21 PM · Performance-Team, MediaWiki-ResourceLoader
Catrope moved T235578: [wmf.2-regression] Help panel: the cog icon is misaligned from Incoming to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 16, 1:54 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Growth-Team (Current Sprint), GrowthExperiments-Help panel, Regression
Catrope edited projects for T235578: [wmf.2-regression] Help panel: the cog icon is misaligned, added: Growth-Team (Current Sprint); removed Growth-Team.
Wed, Oct 16, 1:54 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Growth-Team (Current Sprint), GrowthExperiments-Help panel, Regression
Catrope added a comment to T234907: RFC: Where to implement Desktop Improvements project.

I would strongly encourage you to make iterative improvements to Vector where possible. There is value in writing a new skin, yes, but a lot of what the Desktop Refresh project aims to achieve, especially more consistency between the desktop and mobile experiences, can be done with small iterative changes, so I suggest starting with that first.

Wed, Oct 16, 1:39 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC

Tue, Oct 15

Catrope added a comment to T235578: [wmf.2-regression] Help panel: the cog icon is misaligned.

Regression rGOJU6689fe50461b: WikimediaUI theme: Use `px` instead of `em`s, which changed left: Nem; to margin-left: -Nem; for no apparent reason.

Tue, Oct 15, 11:53 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Growth-Team (Current Sprint), GrowthExperiments-Help panel, Regression
Catrope moved T209120: Upgrade Parsoid HTML stored in the StructuredDiscussions tables from Inbox to Q2 2019-20 on the Growth-Team board.
Tue, Oct 15, 2:24 PM · Growth-Team, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Technical-Debt, StructuredDiscussions, Parsoid
Catrope edited projects for T209120: Upgrade Parsoid HTML stored in the StructuredDiscussions tables, added: Growth-Team; removed Growth-Team (Current Sprint).
Tue, Oct 15, 2:23 PM · Growth-Team, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Technical-Debt, StructuredDiscussions, Parsoid

Oct 4 2019

Catrope updated the task description for T222851: Improve Echo seentime code for multi-DC access.
Oct 4 2019, 10:58 PM · CPT Initiatives (Multi-DC Echo Notification Storage), MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-Eevans, Notifications, Growth-Team
Catrope added a comment to T222851: Improve Echo seentime code for multi-DC access.

I've put two patches in Gerrit that sketch out how I think this would be done. I'll come back to them tomorrow and test them properly etc.

Oct 4 2019, 10:57 PM · CPT Initiatives (Multi-DC Echo Notification Storage), MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-Eevans, Notifications, Growth-Team
Catrope moved T234380: [regression- mobile] Homepage - Start model displays broken layout from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Oct 4 2019, 9:19 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope claimed T234380: [regression- mobile] Homepage - Start model displays broken layout.
Oct 4 2019, 9:18 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope merged task T234689: Homepage: mobile start module formatting issue into T234380: [regression- mobile] Homepage - Start model displays broken layout.
Oct 4 2019, 9:17 PM · Patch-For-Review, GrowthExperiments-Homepage, Mobile, Growth-Team (Current Sprint)
Catrope merged T234689: Homepage: mobile start module formatting issue into T234380: [regression- mobile] Homepage - Start model displays broken layout.
Oct 4 2019, 9:17 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T234689: Homepage: mobile start module formatting issue from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Oct 4 2019, 8:17 PM · Patch-For-Review, GrowthExperiments-Homepage, Mobile, Growth-Team (Current Sprint)
Catrope added a comment to T222851: Improve Echo seentime code for multi-DC access.

I've put two patches in Gerrit that sketch out how I think this would be done. I'll come back to them tomorrow and test them properly etc.

Oct 4 2019, 12:04 AM · CPT Initiatives (Multi-DC Echo Notification Storage), MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-Eevans, Notifications, Growth-Team

Oct 3 2019

Catrope added a comment to T230653: Use a parser function to encapsulate signatures.

For those who are more nefarious, I believe someone could use this exploit to wrap nearly the entire page-contents inside an HTML-comment vanishing it from the page, and use a user-space template call to replace almost the entire page with fabricated comments by other users.

Oct 3 2019, 11:25 PM · Patch-For-Review, OWC2020, MediaWiki-Parser
Catrope added a comment to T234450: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException.

I also visited the URL https://en.wikipedia.org/w/index.php?limit=50000&title=Special%3AContributions&contribs=user&target=Heymid&namespace=&tagfilter=&start=2005-01-01&end=2017-06-30 and got a response in 16 seconds (according to mw.config.get( 'wgBackendResponseTime' ). So it looks like these timeouts might have been a fluke, somehow?

Oct 3 2019, 11:14 PM · User-notice, Core Platform Team Workboards (Clinic Duty Team), Vuln-DoS, Security, Performance Issue, MediaWiki-Special-pages, Wikimedia-production-error
Catrope added a comment to T234450: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException.

I also tried running this query on the production DB server that logstash says served this query db1105:3311, which is listed as the contributions replica. It took 9 seconds instead of 5, which is slower than on the analytics replica but still nowhere near 60.

Oct 3 2019, 11:13 PM · User-notice, Core Platform Team Workboards (Clinic Duty Team), Vuln-DoS, Security, Performance Issue, MediaWiki-Special-pages, Wikimedia-production-error
Catrope added a comment to T234450: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException.

I tried running this query on stat1006, and it only took 5 seconds. But logstash shows Expectation (readQueryTime <= 5) by MediaWiki::main not met (actual: 59.138929128647), and the query failing with an error code of 0 (so probably a 60-second timeout?). Maybe it's being sent to a DB server that doesn't have the right indexes for contribution queries?

Oct 3 2019, 10:42 PM · User-notice, Core Platform Team Workboards (Clinic Duty Team), Vuln-DoS, Security, Performance Issue, MediaWiki-Special-pages, Wikimedia-production-error
Catrope added a comment to T234450: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException.

Turns out, we are correctly capping the limit already!

Oct 3 2019, 10:34 PM · User-notice, Core Platform Team Workboards (Clinic Duty Team), Vuln-DoS, Security, Performance Issue, MediaWiki-Special-pages, Wikimedia-production-error
Catrope added a comment to T234450: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException.

There is already code to cap pager limits at 5000 in WebRequest::getLimitOffset() and in IndexPager::setLimit(), so let's figure out why those are being bypassed here.

Oct 3 2019, 10:24 PM · User-notice, Core Platform Team Workboards (Clinic Duty Team), Vuln-DoS, Security, Performance Issue, MediaWiki-Special-pages, Wikimedia-production-error

Oct 2 2019

Catrope added a comment to T230653: Use a parser function to encapsulate signatures.

As a proxy for the number of pages a user has their signature on, I looked at the number of pages that link to their user talk page. Here are the top 100 linked-to user talk pages on enwiki:

1[enwiki]> select user_name, count(*) as c from user join pagelinks on pl_title=REPLACE(user_name, ' ', '_') and pl_namespace=3 group by user_name order by c desc limit 100;
2+----------------------------+---------+
3| user_name | c |
4+----------------------------+---------+
5| ClueBot NG | 2017150 |
6| InternetArchiveBot | 914825 |
7| ClueBot | 468609 |
8| Materialscientist | 395292 |
9| XLinkBot | 257842 |
10| HasteurBot | 163684 |
11| MediaWiki message delivery | 160564 |
12| Oshwah | 149026 |
13| HostBot | 147690 |
14| Cyberbot II | 147285 |
15| Gilliam | 128008 |
16| I dream of horses | 127439 |
17| BracketBot | 111583 |
18| Gene93k | 106988 |
19| Widr | 103279 |
20| Jim1138 | 96419 |
21| J.delanoy | 88113 |
22| Shellwood | 82564 |
23| BetacommandBot | 79898 |
24| Alansohn | 77122 |
25| CAPTAIN RAJU | 75088 |
26| Donner60 | 71513 |
27| Alexf | 71409 |
28| DGG | 71055 |
29| DPL bot | 69410 |
30| Mattythewhite | 69115 |
31| Serols | 68303 |
32| Tide rolls | 68140 |
33| Northamerica1000 | 67575 |
34| SwisterTwister | 62855 |
35| NawlinWiki | 62251 |
36| Excirial | 62206 |
37| Drmies | 57379 |
38| JMHamo | 54574 |
39| CorenSearchBot | 53611 |
40| CLCStudent | 52795 |
41| Diannaa | 51376 |
42| JohnCD | 51195 |
43| Pseudomonas | 50257 |
44| SineBot | 49685 |
45| Cirt | 49677 |
46| Gogo Dodo | 47733 |
47| Favonian | 47520 |
48| PseudoBot | 45234 |
49| Ian (Wiki Ed) | 44684 |
50| Binksternet | 43878 |
51| Discospinster | 43540 |
52| ImageTaggingBot | 42464 |
53| C.Fred | 41704 |
54| JamesBWatson | 41634 |
55| KylieTastic | 40783 |
56| Ronhjones | 39652 |
57| Edgar181 | 39471 |
58| Epbr123 | 39349 |
59| Pinethicket | 38225 |
60| Ohnoitsjamie | 38013 |
61| Onel5969 | 37414 |
62| Wikipelli | 36867 |
63| COIBot | 36765 |
64| Acroterion | 36611 |
65| JJMC89 | 36528 |
66| Legacypac | 35705 |
67| ReferenceBot | 35631 |
68| MusikAnimal | 35222 |
69| Sfan00 IMG | 34501 |
70| Orangemike | 33844 |
71| STBotI | 33797 |
72| GiantSnowman | 33602 |
73| Red Director | 33345 |
74| DASHBot | 32944 |
75| Dcirovic | 32655 |
76| Coren | 32553 |
77| Robert McClenon | 32487 |
78| B-bot | 32273 |
79| DVdm | 32266 |
80| CommonsNotificationBot | 32211 |
81| Mark Arsten | 31293 |
82| Wtmitchell | 31144 |
83| BJBot | 31107 |
84| Bongwarrior | 31025 |
85| NeilN | 30903 |
86| MBisanz | 30840 |
87| Eeekster | 30807 |
88| K6ka | 30466 |
89| TenPoundHammer | 29801 |
90| Flyer22 Reborn | 29637 |
91| Biografer | 29416 |
92| Juliancolton | 29123 |
93| Lugia2453 | 28883 |
94| Stefan2 | 28804 |
95| Walter Görlitz | 28239 |
96| Jimfbleak | 28126 |
97| IronGargoyle | 28116 |
98| Chzz | 27974 |
99| Marek69 | 27692 |
100| Community Tech bot | 27521 |
101| Theroadislong | 27432 |
102| Rosiestep | 26618 |
103| Abelmoschus Esculentus | 26356 |
104| Piotrus | 26309 |
105+----------------------------+---------+
106100 rows in set (1 min 30.74 sec)

There are 15 users whose signature appears on >100k pages (and 9 of them are bots), a couple dozen over 50k, about a hundred over 25k, and just under 500 users over 10k. So it looks like having your signature used on 10k pages is decently common, but having more than 50k is uncommon and more than 100k is rare.

Oct 2 2019, 9:12 PM · Patch-For-Review, OWC2020, MediaWiki-Parser
Catrope created P9235 Top linked-to user talk pages on frwiki.
Oct 2 2019, 9:09 PM
Catrope created P9234 Top linked-to user talk pages on dewiki.
Oct 2 2019, 9:08 PM
Catrope created P9233 Top linked-to user talk pages on metawiki.
Oct 2 2019, 8:54 PM
Catrope created P9232 Top linked-to user talk pages on enwiki.
Oct 2 2019, 8:42 PM
Catrope added a comment to T230653: Use a parser function to encapsulate signatures.

That's a very good point, thanks for raising it. One particularly worrisome variant would be if a user who has signed a bunch of comments in a bunch of different places either turns malicious or has their account compromised, and changes their signature preference to something that's so bad that it's oversight-worthy (e.g. doxing, death treats). In that situation, oversighters wouldn't have good tools to get rid of it: you could remove the signatures from existing discussions even without necessarily needing to oversight those edits, but there would be too many places the signature is used to feasibly do this. The proper way to fix this situation is to change the user's signature to something non-terrible, but admins/oversighters don't have the power to change another user's preferences (nobody does).

Oct 2 2019, 7:19 PM · Patch-For-Review, OWC2020, MediaWiki-Parser

Oct 1 2019

Catrope moved T232548: Homepage: remove question-asking from help module from Code Review to QA on the Growth-Team (Current Sprint) board.
Oct 1 2019, 4:20 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), GrowthExperiments-Homepage, GrowthExperiments-HelpModule, Growth-Team (Current Sprint)
Catrope moved T232419: Newcomer tasks: suggested edits initiation and overlays from Code Review to QA on the Growth-Team (Current Sprint) board.
Oct 1 2019, 1:01 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T234084: EditorJourney records revision IDs for diffs from Code Review to QA on the Growth-Team (Current Sprint) board.
Oct 1 2019, 1:01 AM · MediaWiki-extensions-WikimediaEvents, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Growth-Team (Current Sprint)
Catrope added a comment to T222926: Use preferences for inputting email address.

The task description didn't specify, but I'm assuming the email-related functionality in ApiHelpPanelPostQuestion has to be removed as well as nothing else uses it (and the old behavior of automatically sending a confirmation email if the user posted a question while unconfirmed doesn't make sense now that we show an email resend button after posting).

Oct 1 2019, 1:00 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), GrowthExperiments-Help panel, GrowthExperiments-HelpModule, Mobile, Desktop, GrowthExperiments-MentorshipModule, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope added a comment to T222851: Improve Echo seentime code for multi-DC access.

Yes, that sounds correct to me. Based on your second bullet point, I propose that we do the configurable storage backend and the TTL change, but that we keep storing timestamps separately for now unless and until we find (or you tell us) that it's better to store them in pairs. In other words, we'd do the first and third item from the check list in the task description, but we'd hold off on the second item for now. Does that sound OK?

Oct 1 2019, 12:55 AM · CPT Initiatives (Multi-DC Echo Notification Storage), MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-Eevans, Notifications, Growth-Team

Sep 30 2019

Catrope added a comment to T225318: Homepage: homepage discovery for no-JS users (desktop).

A slightly hacky approach (hacky in a different way than cross-referencing an asset from an unrelated skin, that is) is to apply opacity: 0.4777 (0x77 / 0xff) which will result in a color very close to #72777d.

Sep 30 2019, 5:34 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Desktop, GrowthExperiments-HomepageDiscovery, GrowthExperiments-Homepage, Growth-Team (Current Sprint)

Sep 28 2019

Catrope moved T232419: Newcomer tasks: suggested edits initiation and overlays from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Sep 28 2019, 5:10 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage

Sep 27 2019

Aklapper awarded T211620: Change some default Notification settings on officewiki a Like token.
Sep 27 2019, 7:11 AM · Patch-For-Review, Wikimedia-Site-requests, Notifications, Growth-Team
Catrope changed the visibility for F30479255: task-types.svg.
Sep 27 2019, 1:06 AM

Sep 26 2019

Catrope renamed T232100: Parsoid drops closing tags when normalizing misnested tags, leaving wikitext that looks like unbalanced HTML from Flow talk page manager strips HTML when converting a page to Parsoid drops closing tags when normalizing misnested tags, leaving wikitext that looks like unbalanced HTML.
Sep 26 2019, 11:23 PM · Parsoid, Growth-Team, StructuredDiscussions
Catrope added a project to T232100: Parsoid drops closing tags when normalizing misnested tags, leaving wikitext that looks like unbalanced HTML: Parsoid.

This is a normalization bug in Parsoid. The output technically isn't incorrect, but it's unhelpful.

Sep 26 2019, 11:23 PM · Parsoid, Growth-Team, StructuredDiscussions

Sep 24 2019

SerDIDG awarded T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) a Burninate token.
Sep 24 2019, 2:41 PM · Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, MediaWiki-Watchlist, Growth-Team
Catrope claimed T233163: [mobile] Homepage modules overlays displayed cutoff .
Sep 24 2019, 12:41 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Growth-Team (Current Sprint), GrowthExperiments-Help panel
Catrope added a comment to T233163: [mobile] Homepage modules overlays displayed cutoff .

This happened because the change above moved the padding to make room for the header from the overlay div to the overlay-content div, and Special:Homepage already had a different padding rule on overlay-content, which overrode Minerva's new rule.

Sep 24 2019, 12:38 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Growth-Team (Current Sprint), GrowthExperiments-Help panel
Catrope added a comment to T233163: [mobile] Homepage modules overlays displayed cutoff .

git bisect blames rSMINd8deb264f2b5: Only apply padding-top to overlays with headers, which sounds quite plausible.

Sep 24 2019, 12:33 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Growth-Team (Current Sprint), GrowthExperiments-Help panel
Catrope added a comment to T233163: [mobile] Homepage modules overlays displayed cutoff .

This appears to be a regression in MinervaNeue between wmf.22 and wmf.23.

Sep 24 2019, 12:30 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Growth-Team (Current Sprint), GrowthExperiments-Help panel

Sep 19 2019

Catrope updated subscribers of T233363: New verification emails unexpectedly enabled on cswiki, kowiki, arwiki, viwiki.

This is on hold while @MMiller_WMF decides whether we should disable it, or keep it enabled. It's been enabled for about two and a half weeks now, since September 3rd at 12:19 UTC (which is when wmf.20 was finally fully rolled out; this was supposed to happen on August 29th, but was delayed).

Sep 19 2019, 8:49 PM · Product-Analytics, Growth-Team, GrowthExperiments
Catrope renamed T233363: New verification emails unexpectedly enabled on cswiki, kowiki, arwiki, viwiki from New verification emails unexpectedly enabled on cswiki. kowiki, arwiki, viwiki to New verification emails unexpectedly enabled on cswiki, kowiki, arwiki, viwiki.
Sep 19 2019, 8:46 PM · Product-Analytics, Growth-Team, GrowthExperiments
Catrope added a comment to T233363: New verification emails unexpectedly enabled on cswiki, kowiki, arwiki, viwiki.

It turns out this is a regression from rEGRE5ef7faffb42e: Invert configuration, defaulting features to "on", for T229389: Invert configuration for GrowthExperiments.

Sep 19 2019, 8:41 PM · Product-Analytics, Growth-Team, GrowthExperiments
Catrope created T233363: New verification emails unexpectedly enabled on cswiki, kowiki, arwiki, viwiki.
Sep 19 2019, 8:40 PM · Product-Analytics, Growth-Team, GrowthExperiments
SBisson awarded T232548: Homepage: remove question-asking from help module a Orange Medal token.
Sep 19 2019, 11:09 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), GrowthExperiments-Homepage, GrowthExperiments-HelpModule, Growth-Team (Current Sprint)

Sep 18 2019

Catrope moved T233263: Welcome survey responses not stored on the first submit from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Sep 18 2019, 11:13 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Growth-Team (Current Sprint), GrowthExperiments
Catrope lowered the priority of T233263: Welcome survey responses not stored on the first submit from Unbreak Now! to Normal.

Turns out this only happens for users who don't get assigned to a WelcomeSurvey group (i.e. don't automatically get shown a survey after account creation), and it only affects the case where you force the survey to appear by manually navigating to Special:WelcomeSurvey with the ?group=exp2_target_specialpage parameter.

Sep 18 2019, 10:59 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T233263: Welcome survey responses not stored on the first submit .

I can reproduce this both on testwiki and locally. Rolling back GrowthExperiments to wmf.22 or wmf.21 locally didn't help, so the culprit is probably somewhere else. Going to try rolling back core next.

Sep 18 2019, 10:06 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Growth-Team (Current Sprint), GrowthExperiments
Catrope triaged T233263: Welcome survey responses not stored on the first submit as Unbreak Now! priority.
Sep 18 2019, 9:39 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Growth-Team (Current Sprint), GrowthExperiments