Catrope (Roan Kattouw)
Growth team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (210 w, 1 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Catrope moved T206543: Make it possible to conditionally oversample Edit events from In Progress to Code Review on the Growth-Team (Current Sprint) board.

I have now tested these patches and confirmed that they correctly oversample new users and mark oversampled events as such. They're ready for code review.

Thu, Oct 18, 8:01 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Product-Analytics, VisualEditor, Patch-For-Review, Growth-Team (Current Sprint)
Catrope added a comment to T207115: Determine solution for logging clicks to external links.

Change 468047 merged by jenkins-bot:
[mediawiki/core@master] Introduce Special:RedirectExternal

https://gerrit.wikimedia.org/r/468047

Thu, Oct 18, 5:58 PM · Privacy, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Growth-Team (Current Sprint)
Catrope closed T206427: Thanks: Remove unexpected '<' character from selector as Invalid.

Closing per the latest comment

Thu, Oct 18, 5:56 PM · Patch-For-Review, Growth-Team, Thanks

Wed, Oct 17

Catrope closed T199744: Recent changes wrongly show as "b" for bot after update as Declined.

I'm afraid that it's very hard to figure out what happened and why at this point, but since your situation is such a confluence of odd edge-case-y things and it's never been reported by anyone else, I'm going to give up on figuring out what happened here.

Wed, Oct 17, 6:23 PM · Regression, MediaWiki-Maintenance-scripts, Growth-Team, MediaWiki-Recent-changes
Catrope added a comment to T206543: Make it possible to conditionally oversample Edit events.

In addition to the 9 (sorry!) patches tagged with this task, I've also amended https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/464432 (for T205759) to oversample Edit events in the relevant cases. I'm now done with the implementation and ready for initial review, but I haven't yet put together all these 10 patches to test that oversampling actually works in all 3 of the extensions that emit Edit events. I'll do that tomorrow, then move this task to the code review column.

Wed, Oct 17, 6:09 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Product-Analytics, VisualEditor, Patch-For-Review, Growth-Team (Current Sprint)

Tue, Oct 16

Catrope updated subscribers of T206543: Make it possible to conditionally oversample Edit events.

@Catrope's current plan:

  • Migrate VE and WikiEditor to the mw.eventLog.Schema class, which was created after the VE instrumentation code was written
  • Make the sampling rate configurable (like in this WIP change, but as an actual number rather than a weird hacky hex thing)
  • Add oversampling support to mw.eventLog.Schema, which adds isOversampled=true to the event data for oversampled events (i.e. events that bypassed sampling and would not have been logged otherwise)
  • Add code to WikimediaEvents that triggers oversampling in the cases where we need it
Tue, Oct 16, 7:25 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Product-Analytics, VisualEditor, Patch-For-Review, Growth-Team (Current Sprint)

Mon, Oct 15

Catrope claimed T206543: Make it possible to conditionally oversample Edit events.
Mon, Oct 15, 9:00 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Product-Analytics, VisualEditor, Patch-For-Review, Growth-Team (Current Sprint)

Wed, Oct 10

Catrope moved T206585: Nominated for deletion filter disregards the current article's state from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 10, 5:29 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Growth-Team (Current Sprint), Patch-For-Review
Catrope moved T206368: New Pages Feed: filter setting not sticking on refresh from AfC from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 10, 5:29 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-extensions-PageCuration

Tue, Oct 9

Catrope moved T204795: EchoNotificationController throws "Call to a member function isMinor() on a non-object" after Special:Undelete action from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Oct 9, 8:59 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team (Current Sprint), MediaWiki-Page-deletion, Notifications, Wikimedia-production-error
Catrope added a comment to T206475: Users are unable to edit (add new topics to) [[:fa:wikipedia:پرسش‌های متفرقه]].

This was caused by the log reason for the hide action on June 10th not being valid UTF-8, which meant that JSON-encoding it (and the rest of the config blob) failed. At @SBisson's suggestion, I un-hid and re-hid the post in question so that the hide reason at the top of its history would be different, and that fixed it.

Tue, Oct 9, 7:06 PM · Growth-Team (Current Sprint), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Performance-Team (Radar), MediaWiki-ResourceLoader, Patch-For-Review, StructuredDiscussions
Catrope moved T196227: User contribs, filtered by calendar period, contains edits on Flow pages outside of this period from To Triage to Triaged but Future on the Growth-Team board.
Tue, Oct 9, 3:56 AM · Growth-Team, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-History-or-Diffs, StructuredDiscussions
Catrope moved T190250: Provide a way to notify groups of users from To Triage to Triaged but Future on the Growth-Team board.
Tue, Oct 9, 3:53 AM · Need-volunteer, Growth-Team, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Catrope moved T192318: Flawed mentions in Flow and "wikitext" to "html" conversion exception from To Triage to External on the Growth-Team board.
Tue, Oct 9, 3:52 AM · WMSE-Samsyn-2018, Growth-Team, Collaboration-Team-Triage, StructuredDiscussions
Catrope moved T204395: Evidence that edits were suppressed is not visible in Flow history from To Triage to Triaged but Future on the Growth-Team board.

Moving this to Triaged but Future for now, unless it turns out to be very easy to fix (which I think may well be the case, but depends on the answer to my question above)

Tue, Oct 9, 3:52 AM · MediaWiki-Revision-deletion, StructuredDiscussions, Growth-Team
Catrope added a comment to T204395: Evidence that edits were suppressed is not visible in Flow history.

As a non-oversighter, I don't see the "this post was suppressed" entries on the topic page itself, which I think is fine. But I also don't see any entries in the history. Perhaps there are history entries but they're only visible to oversighters? In that case we should make a redacted version of them visible to non-oversighters.

Tue, Oct 9, 3:51 AM · MediaWiki-Revision-deletion, StructuredDiscussions, Growth-Team
Catrope closed T205160: AFC submission template gives inaccurate number of submissions waiting for review as Declined.

I'm not convinced the number in the template is wrong, I think it's just out of date. But even if it was wrong (e.g. if it adds up the wrong categories), it'd be a bug in the template code on-wiki, and something for the enwiki community to fix.

Tue, Oct 9, 3:45 AM · Growth-Team
Catrope moved T103747: After a user merge, there might be duplicate Echo notifications from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Tue, Oct 9, 3:43 AM · Growth-Team (Current Sprint), Patch-For-Review, Notifications, Collaboration-Team-Triage, MediaWiki-extensions-UserMerge
Catrope edited projects for T103747: After a user merge, there might be duplicate Echo notifications, added: Growth-Team (Current Sprint); removed Growth-Team.
Tue, Oct 9, 3:43 AM · Growth-Team (Current Sprint), Patch-For-Review, Notifications, Collaboration-Team-Triage, MediaWiki-extensions-UserMerge
Catrope moved T195048: Add a Telegram frontend for Echo notifications from To Triage to Triaged but Future on the Growth-Team board.
Tue, Oct 9, 3:43 AM · Growth-Team, goodfirstbug, Patch-For-Review, Notifications
Catrope moved T196678: Start a list of good examples of filter combinations from To Triage to External on the Growth-Team board.
Tue, Oct 9, 3:42 AM · Google-Code-in-2018, Growth-Team, Collaboration-Team-Triage, Edit-Review-Improvements
Catrope moved T137208: "Thank"ing opens new page from To Triage to Blocked on the Growth-Team board.
Tue, Oct 9, 3:42 AM · TestMe, Growth-Team, Collaboration-Team-Triage, Thanks
Catrope added a project to T158239: Improve GettingStarted data storage strategy: Technical-Debt.
Tue, Oct 9, 3:42 AM · Technical-Debt, Growth-Team, MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Patch-For-Review, User-Elukey, MediaWiki-extensions-GettingStarted, Collaboration-Team-Triage
Catrope moved T169441: Page curation adds text to first deletion discussion page if it already exists from To Triage to Upcoming Work on the Growth-Team board.
Tue, Oct 9, 3:41 AM · Growth-Team, MediaWiki-extensions-PageCuration, Collaboration-Team-Triage
Catrope moved T200353: Filters: Display the time and date of the last refresh from To Triage to Q2 2018-19 on the Growth-Team board.
Tue, Oct 9, 3:41 AM · Growth-Team, Edit-Review-Improvements-Integrated-Filters
Catrope moved T201520: Create a global Talk page filter from To Triage to Q2 2018-19 on the Growth-Team board.

@MMiller_WMF please review this design at some point (not urgent)

Tue, Oct 9, 3:41 AM · Growth-Team, Edit-Review-Improvements-Integrated-Filters
Catrope moved T176555: In new filters add option to auto-expand the grouped changes from To Triage to Triaged but Future on the Growth-Team board.

This is a good idea, but since it was a low priority for the Collaboration team, the Growth team won't be able to prioritize it.

Tue, Oct 9, 3:40 AM · Need-volunteer, Growth-Team, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements
Catrope assigned T189569: Avoid contradicting messages between Getting Started and Visual editor for new users to MMiller_WMF.
Tue, Oct 9, 3:39 AM · Growth-Team, New-Editor-Experiences, MediaWiki-extensions-GettingStarted
Catrope removed a project from T196900: Cursors are not consistent across the filters display and search areas: Collaboration-Team-Triage (Collab-Team-This-Quarter).

This is a substantial enough issue that we should prioritize fixing it.

Tue, Oct 9, 3:38 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Growth-Team, CSS, Edit-Review-Improvements-Integrated-Filters
Catrope added a project to T198337: Have mw.libs.ve.addPlugin working on StructuredDiscussions: Technical-Debt.
Tue, Oct 9, 3:36 AM · Technical-Debt, Growth-Team, Collaboration-Team-Triage, StructuredDiscussions
Catrope added a comment to T203526: [wmf.20-minor] Notification on bundled new topics has misaligned "Stop watching..." icon.

This is a bug with an easy fix, so we'll prioritize it.

Tue, Oct 9, 3:36 AM · Growth-Team, Notifications
Catrope moved T198337: Have mw.libs.ve.addPlugin working on StructuredDiscussions from To Triage to Triaged but Future on the Growth-Team board.

In discussing this, we think that applying VE gadgets to StructuredDiscussions is a pretty rare edge case. Since it's possible to work around it, we're not going to prioritize this.

Tue, Oct 9, 3:35 AM · Technical-Debt, Growth-Team, Collaboration-Team-Triage, StructuredDiscussions
Catrope moved T203526: [wmf.20-minor] Notification on bundled new topics has misaligned "Stop watching..." icon from To Triage to Q2 2018-19 on the Growth-Team board.
Tue, Oct 9, 3:35 AM · Growth-Team, Notifications
Catrope moved T195738: Add a filter for non-tagged edits from To Triage to Revisit on the Growth-Team board.

We discussed this task during our triage meeting last week, and we decided to defer this task for now and keep an eye on it to see if any other users have this request.

Tue, Oct 9, 3:33 AM · Growth-Team, Collaboration-Team-Triage, Edit-Review-Improvements-Integrated-Filters
Catrope moved T177412: Mocha tests for Echo notifications from To Triage to Q2 2018-19 on the Growth-Team board.
Tue, Oct 9, 3:32 AM · Growth-Team, Patch-For-Review, Notifications, Collaboration-Team-Triage, User-zeljkofilipin
Catrope moved T205224: Revisit inability to thank bots from To Triage to Revisit on the Growth-Team board.
Tue, Oct 9, 3:32 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team, Thanks

Thu, Oct 4

Catrope added a comment to T107610: Setup separate logical External Store for Flow in production.

This is probably repeating what everyone already knows, but just in case I believe the process here would be:

  • Create a table named something like "blobs_flow1" in each database on one of the existing read/write ES sets. The existing sets appear to be:
    • cluster24: es1011 es1013 es1015 es2016 es2014 es2015
    • cluster25: es1014 es1017 es1019 es2017 es2018 (and es2019 is currently commented out with a note pointing to T153440)
  • In operations/mediawiki-config, files wmf-config/db-eqiad.php and wmf-config/db-codfw.php,
    • Add to $wgLBFactoryConf['externalLoads'] an entry for flow_cluster1 mapping to whichever set of servers was used
    • Add to $wgLBFactoryConf['templateOverridesByCluster'] an entry for flow_cluster1 with [ 'blobs table' => 'blobs_flow1' ].
  • Adjust Flow's configuration to start writing flow_cluster1.
  • Run some maintenance script to migrate all the old Flow ES entries to the new cluster.
  • (Maybe) delete all the old Flow ES entries from cluster24 and cluster25. Or maybe running core's recompression would automatically leave those behind, I haven't checked.

This looks right to me, assuming this is the same as what was done on beta as part of T119568: Run External Store migration for real on Beta.

Thu, Oct 4, 6:40 PM · User-Banyek, Growth-Team, DBA, Operations, WorkType-Maintenance, Collaboration-Team-Triage, StructuredDiscussions
Catrope added a comment to T206130: Non logged in users are able to review and patrol pages on enwiki using the API.

Looks like its currently getting the state of the configuration in a way that assumes the default database name, rather than the actual one. This has bit us a few times before because our Jenkins jobs actually use the default dbname for its actual db.

Thu, Oct 4, 5:28 PM · Wikimedia-production-error (Shared Build Failure), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-extensions-PageCuration, Security, MediaWiki-Patrolling, English-Wikipedia-New-Pages-Patrol

Wed, Oct 3

Catrope changed the visibility for T206130: Non logged in users are able to review and patrol pages on enwiki using the API.
Wed, Oct 3, 6:51 PM · Wikimedia-production-error (Shared Build Failure), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-extensions-PageCuration, Security, MediaWiki-Patrolling, English-Wikipedia-New-Pages-Patrol
Catrope added a comment to T206130: Non logged in users are able to review and patrol pages on enwiki using the API.

Patch is deployed, making this public now.

Wed, Oct 3, 6:50 PM · Wikimedia-production-error (Shared Build Failure), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-extensions-PageCuration, Security, MediaWiki-Patrolling, English-Wikipedia-New-Pages-Patrol
Catrope added a comment to T206130: Non logged in users are able to review and patrol pages on enwiki using the API.

Also, I just realized why patrol checks aren't completely broken everywhere. There's some inconsistent and bizarre behavior going on, but I now understand why.

Wed, Oct 3, 6:38 PM · Wikimedia-production-error (Shared Build Failure), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-extensions-PageCuration, Security, MediaWiki-Patrolling, English-Wikipedia-New-Pages-Patrol
Catrope added a comment to T206130: Non logged in users are able to review and patrol pages on enwiki using the API.

That wasn't obvious to me, so thanks for pointing that out :)

Wed, Oct 3, 6:33 PM · Wikimedia-production-error (Shared Build Failure), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-extensions-PageCuration, Security, MediaWiki-Patrolling, English-Wikipedia-New-Pages-Patrol
Catrope added a comment to T206130: Non logged in users are able to review and patrol pages on enwiki using the API.

Looks good to me. I'd prefer it if the test changes included a test for the case when the user is, but we can fix that in a follow-up patch.

Wed, Oct 3, 6:08 PM · Wikimedia-production-error (Shared Build Failure), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-extensions-PageCuration, Security, MediaWiki-Patrolling, English-Wikipedia-New-Pages-Patrol
Catrope moved T184960: There is no license in topic pages of flow discussions from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 3, 5:50 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team (Current Sprint), MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), WMF-Legal, StructuredDiscussions
Catrope moved T196033: Clean up RCFilters preference tech debt once watchlist is out of beta from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 3, 5:46 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Growth-Team (Current Sprint), Technical-Debt, Edit-Review-Improvements-Integrated-Filters, MediaWiki-Watchlist
Catrope added a comment to T171898: Deleting large watchlist takes > 4 seconds causing rollback due to write time limit.

Manually removing large numbers of items (say, removing 2490 out of 2500 items in one's watchlist at Special:EditWatchlist/raw) results in individual queries (one per title) to remove from watchlist. If someone sees otherwise in the logs please add your observations here.

Wed, Oct 3, 12:32 AM · Patch-For-Review, Growth-Team (Current Sprint), DBA, MediaWiki-Watchlist, Wikimedia-production-error
Catrope moved T200364: [wmf.14-minor] Misalignment of labels - RC filters from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 3, 12:25 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team (Current Sprint), Edit-Review-Improvements-RC-Page

Tue, Oct 2

Catrope removed a project from T204761: Failed executing job: categoryMembershipChange: Growth-Team.
Tue, Oct 2, 5:40 PM · Wikimedia-production-error
Catrope renamed T190250: Provide a way to notify groups of users from Create group of users notifications to Provide a way to notify groups of users.
Tue, Oct 2, 1:08 AM · Need-volunteer, Growth-Team, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Catrope renamed T196900: Cursors are not consistent across the filters display and search areas from Cursors are not consistant across the filters display and search areas to Cursors are not consistent across the filters display and search areas.
Tue, Oct 2, 1:04 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Growth-Team, CSS, Edit-Review-Improvements-Integrated-Filters
Catrope updated the task description for T196900: Cursors are not consistent across the filters display and search areas.
Tue, Oct 2, 1:03 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Growth-Team, CSS, Edit-Review-Improvements-Integrated-Filters
Catrope moved T203893: Deduplicate mention and mention-summary notifications for the same edit from To Triage to External on the Growth-Team board.
Tue, Oct 2, 12:55 AM · Community-Tech, Notifications, Growth-Team
Catrope renamed T203893: Deduplicate mention and mention-summary notifications for the same edit from Only show one notification when multiple concurrent notifications occur to Deduplicate mention and mention-summary notifications for the same edit.
Tue, Oct 2, 12:55 AM · Community-Tech, Notifications, Growth-Team
Catrope added a comment to T192318: Flawed mentions in Flow and "wikitext" to "html" conversion exception.

Most likely, the rendering problems in edit mode and in view mode have the same root cause: Parsoid is not able to render the mention template.

Tue, Oct 2, 12:52 AM · WMSE-Samsyn-2018, Growth-Team, Collaboration-Team-Triage, StructuredDiscussions
Catrope added a comment to T205160: AFC submission template gives inaccurate number of submissions waiting for review.

Here's how the on-wiki number is computed: https://en.wikipedia.org/w/index.php?title=Template:AFC_status/backlog&action=edit . It's a sum of the sizes various age-based categories. NewPagesFeed instead looks at the overall "Pending AfC submissions" category. So either some pages are in one but not the other, or the on-wiki number is slightly out of date because it gets recomputed periodically (I think the latter is the most likely).

Tue, Oct 2, 12:33 AM · Growth-Team
Liuxinyu970226 awarded T20654: EditPage.php needs rewrite a Mountain of Wealth token.
Tue, Oct 2, 12:30 AM · Technical-Debt, MediaWiki-Page-editing
Catrope added a comment to T205224: Revisit inability to thank bots.

Uh, why has the bot group been hardcoded in extension code?

The bot group is a default group in MediaWiki (see $wgGroupPermissions in DefaultSettings.php), and User::isBot() uses this hardcoded group too. However, that still means that Thanks shouldn't be rolling its own; it should use $recipient->isBot() instead.

Tue, Oct 2, 12:13 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Growth-Team, Thanks
Catrope closed T171953: ORES and Enhanced Recent Changes: Background color gets stuck after patrolling as Resolved.

I can no longer reproduce this

Tue, Oct 2, 12:01 AM · Growth-Team, goodfirstbug, Scoring-platform-team, Collaboration-Team-Triage, Wikidata, MediaWiki-Recent-changes, MediaWiki-extensions-ORES

Mon, Oct 1

Catrope renamed T171953: ORES and Enhanced Recent Changes: Background color gets stuck after patrolling from ORES and Enhanced Recent Changes: Backgound color stucks after patrolling to ORES and Enhanced Recent Changes: Background color gets stuck after patrolling.
Mon, Oct 1, 11:50 PM · Growth-Team, goodfirstbug, Scoring-platform-team, Collaboration-Team-Triage, Wikidata, MediaWiki-Recent-changes, MediaWiki-extensions-ORES
RandomDSdevel awarded T121930: Cross-wiki mark as read doesn't work a Piece of Eight token.
Mon, Oct 1, 11:46 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Growth-Team (Current Sprint), Patch-For-Review, Collaboration-Team-Triage, User-notice, MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), Notifications, Collaboration-Team-Archive-2015-2016
Catrope moved T205323: ORES "is model really enabled?" PHP API from To Triage to External on the Growth-Team board.
Mon, Oct 1, 11:45 PM · Growth-Team, MediaWiki-extensions-PageCuration, Scoring-platform-team, MediaWiki-extensions-ORES
Catrope added a comment to T169441: Page curation adds text to first deletion discussion page if it already exists.

For some reason, MediaWiki has never had to render ordinal numbers (1st, 2nd, 3rd, etc), so there's no facility in MW core to generate these that I know of. Thankfully enwiki does have a template that does this, so here's a suggested approach that doesn't depend on building (internationalized!) ordinal support into MW core:

  • Create an i18n message that controls the name of the AfD subpage; pass it the page name (as $1) and the sequence number (as $2)
  • Start with the sequence number set to 1, and check if the resulting page title exists. If it does, try sequence number 2, 3, etc, until you find a page title that doesn't exist. Use that title for the AfD nomination.
  • In en.json, set the value of this message to something like $1 (nomination $2) or $1{{PLURAL:$2|1=| (nomination $2)}}. This is not compatible with enwiki's naming scheme, but it's a sensible default that doesn't require ordinals or anything else complicated.
  • On enwiki, create a local override of the message with $1{{PLURAL:$2|1=| ({{ordinal|$2}} nomination)}}. (Note that {{ordinal}} is a Lua-powered template that already exists on enwiki.)
Mon, Oct 1, 11:42 PM · Growth-Team, MediaWiki-extensions-PageCuration, Collaboration-Team-Triage
Catrope added a comment to T201520: Create a global Talk page filter.

Would that filter handle the Topic: namespace from StructuredDiscussions?

Mon, Oct 1, 11:06 PM · Growth-Team, Edit-Review-Improvements-Integrated-Filters
RandomDSdevel awarded T200119: No page link notifications since around end of June a Piece of Eight token.
Mon, Oct 1, 1:53 AM · MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Growth-Team (Current Sprint), Patch-For-Review, Regression, Notifications

Tue, Sep 25

Catrope added a comment to T203207: Copyvio: backfilling on existing pages.

To clarify: are you proposing using a system user? I think we should, to create a clear separation between imports from CopyPatrol that we did and things that EranBot does later.

Tue, Sep 25, 9:11 PM · Patch-For-Review, Growth-Team (Current Sprint), English-Wikipedia-New-Pages-Patrol
Catrope added a comment to T204785: Growth: how many users sign up with email addresses?.

I'm not sure how to answer Q3, do we want to get ops in on this to see if addresses registered in the last year were emailed but bounced? Not sure if there are other ways to figure that one out.

Tue, Sep 25, 8:53 PM · Growth-Team (Current Sprint), Product-Analytics
Catrope added a comment to T204785: Growth: how many users sign up with email addresses?.

One question that has come up during this work, and that I hope @Catrope can answer is: does verifying one's email address change anything in the business logic in Wikipedia/MediaWiki?

Tue, Sep 25, 8:36 PM · Growth-Team (Current Sprint), Product-Analytics

Mon, Sep 24

Catrope created T205320: Updated ORES models can no longer satisfy configured threshold requirements.
Mon, Sep 24, 6:34 PM · ORES, Scoring-platform-team

Wed, Sep 19

Catrope closed T204826: EchoForeignWikiRequest emits PHP error "Undefined index: query" as Resolved.

This happened pretty frequently, but then stopped. The last notice is from 16:43 UTC. The fix for T204758 was deployed at 16:49 UTC. I think that's enough circumstantial evidence to say that T204758 fixed this too.

Wed, Sep 19, 8:28 PM · Notifications, Growth-Team, Wikimedia-production-error
Catrope closed T204826: EchoForeignWikiRequest emits PHP error "Undefined index: query", a subtask of T191068: 1.32.0-wmf.22 deployment blockers, as Resolved.
Wed, Sep 19, 8:28 PM · User-zeljkofilipin, Release-Engineering-Team (Kanban), Release, Train Deployments

Sep 19 2018

Catrope updated the task description for T133462: Provide standard-compatible way to load multi-file packages (not plain concatenation).
Sep 19 2018, 2:39 AM · TechCom-RFC (TechCom-Approved), Performance-Team, Readers-Web-Backlog (Tracking), Front-end-Standards-Group, MediaWiki-ResourceLoader

Sep 18 2018

Catrope added a comment to T204767: Special:ActiveUsers fails with "Error: 1054 Unknown column 'rc_actor' in 'on clause' (10.192.32.110)".

...but making the joins explicit won't work, because you can't make COALESCE( actor_rc_user.actor_name, rc_user_text ) = qcc_title a join condition.

Sep 18 2018, 8:55 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Wikimedia-production-error, MediaWiki-Special-pages
Catrope added a comment to T204767: Special:ActiveUsers fails with "Error: 1054 Unknown column 'rc_actor' in 'on clause' (10.192.32.110)".

This either needs the order of the tables to be changed so that 'recentchanges' comes after 'user_groups' (not super easy to do with how the code is now), or this needs the implicit joins between user_groups, user, querycachetwo and recentchanges to be made explicit INNER JOINs.

Sep 18 2018, 8:52 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Wikimedia-production-error, MediaWiki-Special-pages
Catrope claimed T204764: DB error in PageTriage: Unknown column 'actor_rev_user.actor_user' in 'on clause'.

The code is generating this query in the wrong order for some reason. The actor-related joins need to go first, because backwards references are not allowed in join conditions.

Sep 18 2018, 8:23 PM · Growth-Team (Current Sprint), MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Wikimedia-production-error, Multi-Content-Revisions, MediaWiki-extensions-PageCuration
Catrope added a parent task for T204764: DB error in PageTriage: Unknown column 'actor_rev_user.actor_user' in 'on clause': T191068: 1.32.0-wmf.22 deployment blockers.
Sep 18 2018, 8:17 PM · Growth-Team (Current Sprint), MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Wikimedia-production-error, Multi-Content-Revisions, MediaWiki-extensions-PageCuration
Catrope added a subtask for T191068: 1.32.0-wmf.22 deployment blockers: T204764: DB error in PageTriage: Unknown column 'actor_rev_user.actor_user' in 'on clause'.
Sep 18 2018, 8:17 PM · User-zeljkofilipin, Release-Engineering-Team (Kanban), Release, Train Deployments
Catrope created T204764: DB error in PageTriage: Unknown column 'actor_rev_user.actor_user' in 'on clause'.
Sep 18 2018, 8:17 PM · Growth-Team (Current Sprint), MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Wikimedia-production-error, Multi-Content-Revisions, MediaWiki-extensions-PageCuration
Catrope added a comment to T201574: Put RCFilters i18n messages and other config in a ResourceLoader data module.

Change 460954 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Export config vars in the RL module where possible

https://gerrit.wikimedia.org/r/460954

Sep 18 2018, 6:17 PM · Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-Recent-changes

Sep 12 2018

Catrope moved T203008: Ensure retrieval and storage of article metadata from Code Review to QA on the Growth-Team (Current Sprint) board.
Sep 12 2018, 7:15 PM · Patch-For-Review, Growth-Team (Current Sprint), MediaWiki-extensions-PageCuration
jcrespo awarded T202058: Unknown modifier 'R': [/^page\-User\:BeneBot.+/RfD\-open/text$/] in /srv/mediawiki/php-1.32.0-wmf.16/extensions/Translate/stringmangler/StringMatcher.php a Doubloon token.
Sep 12 2018, 6:42 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Wikimedia-production-error, MediaWiki-extensions-Translate, Security

Sep 8 2018

Liuxinyu970226 awarded T121930: Cross-wiki mark as read doesn't work a 100 token.
Sep 8 2018, 11:10 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Growth-Team (Current Sprint), Patch-For-Review, Collaboration-Team-Triage, User-notice, MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), Notifications, Collaboration-Team-Archive-2015-2016
Catrope added a comment to T196671: Start reading from change_tag_def in beta cluster.

Reverted config change because Recentchanges and Watchlist were throwing exceptions. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/459016 should fix the underlying issue.

Sep 8 2018, 4:12 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata-Campsite, User-Ladsgroup, MediaWiki-Change-tagging
Catrope created T203860: Consider making NameTableStore easier to use.
Sep 8 2018, 12:52 AM · MediaWiki-General-or-Unknown

Sep 7 2018

Catrope moved T188849: Flow comments start and end with a lot of whitespace from Code Review to QA on the Growth-Team (Current Sprint) board.
Sep 7 2018, 6:09 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions
Catrope moved T132342: [[MediaWiki:Notification-header-flow-topic-resolved-user-talk/nb]] i18n issue from Code Review to QA on the Growth-Team (Current Sprint) board.
Sep 7 2018, 6:09 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Growth-Team (Current Sprint), Patch-For-Review, Gender-Support, StructuredDiscussions, I18n
Catrope moved T197541: Delete actions do not appear on watchlist (Hungarian Wikipedia issue) from Code Review to QA on the Growth-Team (Current Sprint) board.
Sep 7 2018, 5:24 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Growth-Team (Current Sprint), MediaWiki-Watchlist
Catrope added a comment to T197541: Delete actions do not appear on watchlist (Hungarian Wikipedia issue).

because NULL != 90 is false (that sounds strange, but any comparison involving null is false).

Hmm, is this MediaWiki specific?

Sep 7 2018, 5:22 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Growth-Team (Current Sprint), MediaWiki-Watchlist
Catrope claimed T197541: Delete actions do not appear on watchlist (Hungarian Wikipedia issue).
Sep 7 2018, 12:51 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Growth-Team (Current Sprint), MediaWiki-Watchlist
Catrope added a comment to T197541: Delete actions do not appear on watchlist (Hungarian Wikipedia issue).

This was caused by rELQT5c867745a737: Remove impossible query condition, which we should just revert.

Sep 7 2018, 12:44 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Growth-Team (Current Sprint), MediaWiki-Watchlist
Catrope added a comment to T197541: Delete actions do not appear on watchlist (Hungarian Wikipedia issue).

Mystery solved: this is caused by MediaWiki-extensions-LiquidThreads adding page_namespace != 90 (90 is the Thread namespace) to the WHERE clause, which then causes all rows that don't have a corresponding row in the page table (meaning, deleted pages) to be dropped, because NULL != 90 is false (that sounds strange, but any comparison involving null is false).

Sep 7 2018, 12:25 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Growth-Team (Current Sprint), MediaWiki-Watchlist

Sep 6 2018

Catrope moved T203125: New Pages Feed: filter logic inconsistent for "Were created by bots" from Code Review to QA on the Growth-Team (Current Sprint) board.
Sep 6 2018, 10:38 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, MediaWiki-extensions-PageCuration, Growth-Team (Current Sprint)
Catrope added a comment to T203526: [wmf.20-minor] Notification on bundled new topics has misaligned "Stop watching..." icon.

Psh, I filed first. ;-(

Sep 6 2018, 10:25 PM · Growth-Team, Notifications
Catrope added a comment to T203526: [wmf.20-minor] Notification on bundled new topics has misaligned "Stop watching..." icon.

Per the duplicate tasks, the "stop watching ..." link is both misaligned and has a non-transparent background on hover.

Sep 6 2018, 10:25 PM · Growth-Team, Notifications
Catrope merged T203502: Promoted "menu" items from the Notifications tray have a white rather than transparent background, which is a little ugly into T203526: [wmf.20-minor] Notification on bundled new topics has misaligned "Stop watching..." icon.
Sep 6 2018, 10:24 PM · Growth-Team, Notifications
Catrope merged task T203502: Promoted "menu" items from the Notifications tray have a white rather than transparent background, which is a little ugly into T203526: [wmf.20-minor] Notification on bundled new topics has misaligned "Stop watching..." icon.
Sep 6 2018, 10:24 PM · Notifications, Growth-Team
Catrope merged T203503: Promoted "menu" items from the Notifications tray seem to be wrongly vertically aligned, which is a little ugly into T203526: [wmf.20-minor] Notification on bundled new topics has misaligned "Stop watching..." icon.
Sep 6 2018, 10:23 PM · Growth-Team, Notifications
Catrope merged task T203503: Promoted "menu" items from the Notifications tray seem to be wrongly vertically aligned, which is a little ugly into T203526: [wmf.20-minor] Notification on bundled new topics has misaligned "Stop watching..." icon.
Sep 6 2018, 10:23 PM · Notifications, Growth-Team
Catrope added a comment to T173889: Rename article_ and _(prefixed)text variables to page_ and _(prefixed)title.

I have +2ed both 4A (which should be merged by Jenkins soon) and 8 (which won't be merged yet because it Depends-On an unmerged patch).

Sep 6 2018, 10:19 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Growth-Team, MediaWiki-extensions-HitCounters, StructuredDiscussions, User-notice, Patch-For-Review, AbuseFilter
Catrope added a comment to T203080: Change mentions of wp10 to articlequality in products.

I see, your ORES patch adds articlequality but does not remove wp10, so it should be safe to deploy with or without the PageTriage patch, right?

Sep 6 2018, 10:13 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, MediaWiki-extensions-ORES, ORES-Support-Checklist, User-Ladsgroup, Scoring-platform-team (Current)
Catrope edited projects for T203507: Remote image loaded in Echo's HTML user talk email notifications, added: Notifications; removed MediaWiki-Email.

If the email used ext.echo.emailicons, it wasn't an enotif email but an Echo email.

Sep 6 2018, 10:11 PM · Growth-Team, Notifications, Privacy