Page MenuHomePhabricator

Catrope (Roan Kattouw)
Growth team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (285 w, 3 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF) [ Global Accounts ]

Recent Activity

Fri, Mar 27

Catrope added a comment to T248405: [Spike] explore porting MachineVision front-end to Vue.js.

@Catrope This is not urgent, but it would be nice to have a resource module for Vuex in core that works similar to the one for Vue itself. Right now I'm including the Vuex code in a vendor subfolder but other projects will presumably need to use this soon as well.

Fri, Mar 27, 4:21 AM · Vue.js, MachineVision, Structured-Data-Backlog (Current Work)

Wed, Mar 25

Catrope updated subscribers of T248306: CI error on WMF branches: Cannot use the final modifier on an abstract class in vendor/microsoft/tolerant-php-parser/tests/cases/parser/abstractMethodDeclaration7.php on line 3.

This also happened on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/583339 . @Reedy investigated this briefly, but was confused because there's a specific exclusion for this directory in the phan config

Wed, Mar 25, 11:52 PM · Release-Engineering-Team, phan-taint-check-plugin, ci-test-error, MediaWiki-Vendor, Continuous-Integration-Config
Catrope added a comment to T248501: mw1251 down (no ssh) but still in dsh group?.

This is still broken, and was causing confusion during the 4pm SWAT deployment. Thankfully scap appears to route around broken proxies, so it didn't fail to sync 1/9th of the Apaches as I feared it would.

Wed, Mar 25, 11:48 PM · Release-Engineering-Team, serviceops

Tue, Mar 24

Catrope claimed T248422: [regression wmf.25] Mentorship module shows guidance root screen .

This happened because rEGREb5316d1d36cd: Help panel: Add root screen buttons (for T244546: Newcomer tasks: guidance root screen) made significant changes to HelpPanelProcessDialog, without realizing that QuestionPosterDialog is a subclass of it. In other words, the mentorship dialog (and the other "ask a question" dialogs) are implemented as some modifications on top of the help panel, so changing the structure of the help panel broke them.

Tue, Mar 24, 9:58 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Growth-Team (Current Sprint), NewcomerTasks 1.2, Regression, GrowthExperiments-Help panel
Catrope edited projects for T248422: [regression wmf.25] Mentorship module shows guidance root screen , added: Growth-Team (Current Sprint); removed Growth-Team.
Tue, Mar 24, 9:55 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Growth-Team (Current Sprint), NewcomerTasks 1.2, Regression, GrowthExperiments-Help panel

Fri, Mar 20

Catrope placed T248106: Newcomer tasks: randomize initial task type up for grabs.

Returning this task back to the pool because I don't understand the search backend well enough, I'll need @Tgr to help me or tell me what to do here.

Fri, Mar 20, 3:14 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Patch-For-Review, NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T248106: Newcomer tasks: randomize initial task type.

I tried to do this by randomizing the order in which the task types are sent to the API, because the API appears to return results ordered exactly the same as the task type list it receives. However, that only works if no topic filter is set. With a topic filter, this order isn't respected, and in fact there seems to be no rhyme or reason to the results ordering as far as I can tell (neither in terms of task type nor topic).

Fri, Mar 20, 3:14 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Patch-For-Review, NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T244546: Newcomer tasks: guidance root screen from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Mar 20, 2:58 AM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Thu, Mar 19

Catrope claimed T248106: Newcomer tasks: randomize initial task type.
Thu, Mar 19, 6:20 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Patch-For-Review, NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a subtask for T233872: 1.35.0-wmf.24 deployment blockers: T248049: wgNewUserMsgRevisionId (in JavaScript) is no longer set when the user has a new message.
Thu, Mar 19, 3:27 AM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release, Train Deployments
Catrope added a parent task for T248049: wgNewUserMsgRevisionId (in JavaScript) is no longer set when the user has a new message: T233872: 1.35.0-wmf.24 deployment blockers.
Thu, Mar 19, 3:27 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Wikimedia-production-error
Catrope created T248049: wgNewUserMsgRevisionId (in JavaScript) is no longer set when the user has a new message.
Thu, Mar 19, 3:27 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Wikimedia-production-error

Fri, Mar 13

Catrope moved T247375: [wmf.22] Suggested edits: Issues with canceling filter - 'Cannot read property 'tasktype' of undefined`' from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Fri, Mar 13, 12:11 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Growth-Team (Current Sprint), GrowthExperiments
Catrope claimed T247375: [wmf.22] Suggested edits: Issues with canceling filter - 'Cannot read property 'tasktype' of undefined`'.
Fri, Mar 13, 12:11 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Growth-Team (Current Sprint), GrowthExperiments

Sat, Feb 29

Catrope moved T246512: [betalabs] Newcomer tasks: se-card-end-of-queue displays Uncaught TypeError: this.currentCard.getTaskType is not a function from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Sat, Feb 29, 5:23 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope claimed T246512: [betalabs] Newcomer tasks: se-card-end-of-queue displays Uncaught TypeError: this.currentCard.getTaskType is not a function.
Sat, Feb 29, 5:23 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Growth-Team (Current Sprint), GrowthExperiments

Fri, Feb 28

Catrope added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.
  1. For the v3 migration, this is the currently planned procedures:
    1. v2.7 will be released with deprecation warnings for features that are set for removal. This release will also become an LTS version with 18 months of extended support time.
    2. v3 will come with a "compatibility build" that exposes v2 behavior (where applicable) via feature flags and provide deprecation warnings / migration guidance when v2 usage is detected. v2 compat feature flags that can be turned off individually so the migration can be performed piecemeal.
    3. Codemods will be provided for simple API syntax changes that can be automatically upgraded.
    4. A migration helper will scan the codebase and provide guidance for any changes that cannot be covered by the compatibility build or codemods (we try our best to avoid such changes, but sometimes they are inevitable).

Hope this addresses the stability concerns.

Fri, Feb 28, 8:42 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Feb 28 2020

Catrope moved T244421: Newcomer tasks: UX changes for ORES topics from In Progress to Code Review on the Growth-Team (Current Sprint) board.

The main part of this (the new UI for ORES topics) is now in code review. Next, I'm going to work on separating the topic preferences for morelike vs ORES, so that when we switch to ORES, everyone's topic selections will be blank and they'll see a blue dot (per a conversation with @MMiller_WMF). After that, I'll work on the design tweaks that the task description asked for.

Feb 28 2020, 1:09 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Growth Design, Growth-Team (Current Sprint), Scoring-platform-team, Discovery-Search
Catrope closed T244617: Please clear two stuck notifications for MABot as Resolved.

Closing this since the MABot issue is resolved; I've filed T246398: Echo does not recompute notification counts when notification subscriptions are changed through a global preference for the underlying issue.

Feb 28 2020, 12:15 AM · Notifications, Growth-Team
Catrope created T246398: Echo does not recompute notification counts when notification subscriptions are changed through a global preference.
Feb 28 2020, 12:15 AM · MediaWiki-extensions-GlobalPreferences, Community-Tech, Growth-Team, Notifications
Catrope added a comment to T244617: Please clear two stuck notifications for MABot.

In the database, I do see 1 unread notification each for MABot on eswiktionary and euwikibooks. They're both "thank you for your 100th edit" notifications. The one on eswiktionary is from July 2019, and the one on euwikibooks is from April 2019. However, MABot has disabled thank-you-edit notifications using global preferences. I think this is probably the source of the bug: saving one's global preferences only causes notification counts to be recomputed on the wiki where you did that, not globally (and generally, hooks listening for preference changes won't be fired when the preference change happens through global preferences).

Feb 28 2020, 12:01 AM · Notifications, Growth-Team

Feb 27 2020

Catrope created T246300: Ensure PHP is upgraded to at least 7.2.22.
Feb 27 2020, 1:11 AM · MediaWiki-Vagrant
Catrope added a comment to T228346: PHP 7.2 garbage collector segfault.

This broke MW-Vagrant, which uses PHP version PHP 7.2.16-1+0~20190307202415.17+stretch~1.gbpa7be82+wmf1

Feb 27 2020, 12:38 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Patch-For-Review, Release-Engineering-Team-TODO, MW-1.35-release, Upstream, MediaWiki-General, PHP 7.2 support

Feb 25 2020

Catrope added a comment to T245499: Improve performance of Compare query for Special:Investigate.

@Catrope wow thank you for all of that! :)

dropping the ORDER BY, which can significantly speed up the query in some cases.

Do you think the LIMIT on the main subquery is worth the cost of the ORDER BY on the subquery?

Yes. In my pathological example (which I realize is pathological, but still), adding a LIMIT reduced the query run time from 29 seconds to ~2 seconds. You are right though that the ORDER BY does make the query slower sometimes, it's just that in extreme cases the un-limited-ness makes it slower still.

Feb 25 2020, 5:20 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Anti-Harassment (The Letter Song), Performance Issue, CheckUser
Catrope added a comment to T245499: Improve performance of Compare query for Special:Investigate.

I played around some more, and decided to throw the worst at it that I could come up with. With a user with ~300k rows, an IP address with ~300k rows, and an IP range with ~800k rows (so 1.4M rows scanned in total), the query from the task description took 29 seconds. Adding LIMIT 100000 (that's 100k) to each of those subqueries took it down to 8 seconds. Adding a timestamp condition (>= 1 Feb, so 23 days' worth of data) made it 5 seconds, and then setting the limit to 33,333 (so that the limits add up to 100k) got it down to 2 seconds. That seems pretty acceptable. The worst-performing part seems to be IP range scans that return lots of results, because then MySQL is stuck between a rock (using the cuc_timestamp index for sorting, then a manual where for the IP range) and a hard place (using the cuc_ip_hex_time index for the IP range, then a filesort for ordering by timestamp).

Feb 25 2020, 12:06 AM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Anti-Harassment (The Letter Song), Performance Issue, CheckUser

Feb 24 2020

Catrope added a comment to T245499: Improve performance of Compare query for Special:Investigate.

Ooh, this subquery materialization stuff is really helpful, thanks! I knew that using the indexes to get rows by user/IP should be possible, but I didn't know how to tell MySQL to do it. Adding an index to help the GROUP BY will likely improve performance too.

Feb 24 2020, 9:11 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Anti-Harassment (The Letter Song), Performance Issue, CheckUser
Catrope added a comment to T227447: Librarize i18n-related PHP classes in MediaWiki.

I ranted about a few gaps in our current Message interface, specifically the (lack of) interaction between RawMessage and MessageLocalizer, here: T227233#5305488.

Feb 24 2020, 8:35 PM · Librarization, I18n, MediaWiki-Internationalization
Catrope claimed T244421: Newcomer tasks: UX changes for ORES topics.
Feb 24 2020, 6:09 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Growth Design, Growth-Team (Current Sprint), Scoring-platform-team, Discovery-Search

Feb 22 2020

Catrope added a comment to T228746: mw.config empty on some pages (and fatal errors emitted) due to Unicode-unaware handling of UTF8 data by Lua.

In T245573 @Catrope suggested another potential way to fix this: cleaning up the string inside LuaSandbox after it comes from Lua, in luasandbox_timer_profiler_hook() and luasandbox_push_structured_trace().

Feb 22 2020, 1:27 AM · Core Platform Team Workboards (Clinic Duty Team), LuaSandbox, MediaWiki-extensions-Scribunto, Wikimedia-production-error
Catrope added a comment to T164307: Add Reverted filter to RecentChanges Filters.

I have one doubt : Does the current edit model have a field to identify whether the edit is a revert ? Or does that need to be implemented ? From reading this, I understand that only a method needs to be implemented to know it, and that the model already has a field to know what is the edit type (revert or not) ?

Feb 22 2020, 1:05 AM · Google-Summer-of-Code (2020), Growth-Team, Edit-Review-Improvements-RC-Page, Edit-Review-Improvements-Integrated-Filters

Feb 21 2020

Catrope added a comment to T245782: Trying to resolve a particular StructuredDiscussion doesn't work: "Error: 1062 Duplicate entry for key 'flow_revision_unique_parent'".

The DBQueryError was: Error: 1062 Duplicate entry '\x05\xC1Ue\x09\xC1\xD8\xD2\xC2\x10U' for key 'flow_revision_unique_parent' (10.64.32.11)

Feb 21 2020, 7:48 PM · Growth-Team, StructuredDiscussions

Feb 18 2020

Catrope created T245573: LuaSandbox should clean up short_src for multibyte-safe truncation.
Feb 18 2020, 11:43 PM · LuaSandbox

Feb 15 2020

Catrope created T245328: Disable the {{ (template) sequence when inside a <code> annotation.
Feb 15 2020, 1:38 AM · VisualEditor

Feb 14 2020

Catrope added a comment to T245073: [wmf.19] Uncaught TypeError: Cannot read property 'toggle' of undefined.

Need to backport?

Feb 14 2020, 4:31 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Growth-Team

Feb 12 2020

Catrope added a comment to T245072: Search by exonym (e.g. "Dutch" for nl) not working in language search dialog.

I broke this a year ago in rMW1c7c9bdf1fc5: Use packageFiles feature to replace special-purpose RL modules, apparently nobody noticed.

Feb 12 2020, 10:48 PM · Verified, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MW-1.33-notes, Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, VisualEditor-LanguageTool
Catrope created T245072: Search by exonym (e.g. "Dutch" for nl) not working in language search dialog.
Feb 12 2020, 10:48 PM · Verified, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MW-1.33-notes, Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, VisualEditor-LanguageTool

Feb 11 2020

Catrope added a comment to T244937: [Regression 1.35.0-wmf.19] i/p/IndexPager.php:* PHP Warning: implode(): Invalid arguments passed.

This is a regression from rMW6786aa5d8e2e: Support pagination on multiple columns in the IndexPager, caused by the fact that ImageHistoryPseudoPager completely reimplements doQuery(), including code that lives in IndexPager::extractResultInfo(), which was modified in an incompatible way.

Feb 11 2020, 10:56 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Anti-Harassment, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3))

Feb 5 2020

Catrope added a comment to T244192: Newcomer tasks: ORES ontology mapping and score thresholds.

But the topics themselves should be displayed alphabetically in the local language. Engineers, please let us know if that doesn't look like a good approach.

This shouldn't be an issue.,

Feb 5 2020, 1:52 AM · Scoring-platform-team (Current), Discovery-Search (Current work), Growth-Team (Current Sprint)

Jan 24 2020

Catrope added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

There will be some limitations to this approach:

  1. we'll rely on Vue's built-in template compiler for the time being, which means shipping a little bit of additional code in production;

This is irresponsible. For the amount of traffic we have, the amount of extra computation we are going to force on millions of clients because of our inability to get our process together.

Jan 24 2020, 1:15 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 23 2020

Catrope added a comment to T236104: Cache of wmf-config/InitialiseSettings often 1 step behind.

I don't think that that would help. I was measuring mtime deltas not because I think there's a bug of the type you're alluding to, but as a proxy for finding out whether the bad servers generated their cache files very shortly after the scap happened. If the cache file is only a tenth of a second younger than the settings file, that might indicate some sort of race condition, but at 0.25 seconds that's less plausible, and at 3 seconds it's definitely not plausible.

Jan 23 2020, 1:07 AM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (Deployment services), Wikimedia-Incident, Deployments, Performance-Team (Radar), serviceops
Catrope awarded T243472: +2 for Urbanecm on mediawiki/extensions/GrowthExperiments a Like token.
Jan 23 2020, 12:51 AM · Gerrit-Privilege-Requests, GrowthExperiments, Growth-Team
Catrope added a comment to T236104: Cache of wmf-config/InitialiseSettings often 1 step behind.

It happened again today, with this patch. This time I left it broken for a while so I could investigate.

Jan 23 2020, 12:01 AM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (Deployment services), Wikimedia-Incident, Deployments, Performance-Team (Radar), serviceops

Jan 22 2020

Catrope updated the title for P10246 config mis-sync: servers sorted by mtime delta between InitialiseSettings.php and cache file from untitled to config mis-sync: servers sorted by mtime delta between InitialiseSettings.php and cache file.
Jan 22 2020, 11:53 PM
Catrope created P10246 config mis-sync: servers sorted by mtime delta between InitialiseSettings.php and cache file.
Jan 22 2020, 11:52 PM
Catrope edited P10245 2020-01-22 config mis-sync good and bad servers.
Jan 22 2020, 11:17 PM
Catrope created P10245 2020-01-22 config mis-sync good and bad servers.
Jan 22 2020, 11:11 PM
Catrope moved T243213: Allow extensions to register handlers with factories without the use of global variables from Inbox to In progress on the TechCom board.
Jan 22 2020, 9:35 PM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
Catrope moved T243036: Newcomer tasks: rules for duplicate results from Code Review to QA on the Growth-Team (Current Sprint) board.
Jan 22 2020, 8:34 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope added a comment to T236104: Cache of wmf-config/InitialiseSettings often 1 step behind.

Thanks to Giuseppe I got dsh+keyholder to work: SSH_AUTH_SOCK=/run/keyholder/proxy.sock dsh -r ssh -F 20 -M -g mediawiki-installation -o -i/etc/keyholder.d/mwdeploy -o -oUser=mwdeploy -o -oBatchMode=yes -- 'echo "echo \$wgGEHomepageSuggestedEditsTopicsRequiresOptIn ? \"BAD\" : \"good\";" | sudo -u www-data php /srv/mediawiki/multiversion/MWScript.php eval.php --wiki=cswiki | head -n 1'

Jan 22 2020, 7:00 AM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (Deployment services), Wikimedia-Incident, Deployments, Performance-Team (Radar), serviceops
Catrope added a comment to T236104: Cache of wmf-config/InitialiseSettings often 1 step behind.

I encountered this bug again today, when deploying this config change. My teammates reported that the feature we'd just enabled was working about half the time, which likely means that about half (or at least a significant fraction, much more than 10%) of the app servers had an outdated config, I tried to use dsh to count how many app servers were affected, but I couldn't get keyholder to work. It gave me a "Too many authentication failures" error message for each host.

Jan 22 2020, 1:58 AM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (Deployment services), Wikimedia-Incident, Deployments, Performance-Team (Radar), serviceops

Jan 21 2020

Catrope added a comment to T44085: Wikimedia needs a URL shortener (tracking).

It looks like @kaldari has updated the wiki page: https://www.mediawiki.org/w/index.php?title=Requests_for_comment%2FURL_shortener&type=revision&diff=3618236&oldid=2842533

Jan 21 2020, 10:40 PM · User-Ladsgroup, Proposal, TechCom-RFC (TechCom-RFC-Closed), Tracking-Neverending, WorkType-NewFunctionality, Wikimedia-General-or-Unknown
Catrope updated the task description for T243213: Allow extensions to register handlers with factories without the use of global variables.
Jan 21 2020, 9:18 PM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
Catrope added a comment to T239084: Homepage wording suggestions.

Supplementing this with the reasoning that Amir provided in his commit messages, and highlighting what the changes are:

Jan 21 2020, 7:05 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T243211: CAS update failed on user_touched. The version of the user to be saved is older than the current version. from Code Review to QA on the Growth-Team (Current Sprint) board.
Jan 21 2020, 3:24 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Growth-Team (Current Sprint), GrowthExperiments-Homepage

Jan 17 2020

Catrope added a comment to T242052: Newcomer tasks: topic matching instrumentation.

@Tgr -- okay, I just talked to @Catrope about wanting to SWAT this on Tuesday. Because we don't want there to be a few days of the topic era that don't have this element as part of their events.

Jan 17 2020, 9:54 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope added a project to T243078: Variant test: Say hi to mentor notification: Growth-Team.
Jan 17 2020, 9:47 PM · Growth-Team, GrowthExperiments-HomepageDiscovery, GrowthExperiments-Homepage
Catrope assigned T238320: Deploy Newcomer Homepage to Ukrainian, Hungarian, Armenian Wikipedias to Trizek-WMF.

The config patches are done. The next step is for @Trizek-WMF to set a deployment date for each wiki.

Jan 17 2020, 3:36 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope updated the task description for T238320: Deploy Newcomer Homepage to Ukrainian, Hungarian, Armenian Wikipedias.
Jan 17 2020, 3:36 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope assigned T238319: Deploy Help Panel to Ukrainian, Hungarian, Armenian Wikipedias to Trizek-WMF.

The config patches are done. The next step is for @Trizek-WMF to set a deployment date for each wiki.

Jan 17 2020, 3:28 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope updated the task description for T238319: Deploy Help Panel to Ukrainian, Hungarian, Armenian Wikipedias.
Jan 17 2020, 3:28 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope added a comment to T230676: Deploy Growth experiments at Armenian Wikipedia.

Which namespace(s) and/or categories the Help panel search should handle = https://hy.wikipedia.org/wiki/%D4%BF%D5%A1%D5%BF%D5%A5%D5%A3%D5%B8%D6%80%D5%AB%D5%A1:%D5%8E%D5%AB%D6%84%D5%AB%D5%BA%D5%A5%D5%A4%D5%AB%D5%A1:%D5%95%D5%A3%D5%B6%D5%B8%D6%82%D5%A9%D5%B5%D5%B8%D6%82%D5%B6

@Trizek-WMF: We don't support category search here yet, you can only search in entire namespaces. Right now, all wikis that have the help panel search in namespaces 4 (Wikipedia) and 12 (Help).

Jan 17 2020, 3:11 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team
Catrope added a comment to T230478: Get the Growth experiment for the Hungarian Wikipedia.

Which namespace(s) and/or categories the Help panel search should handle (0 is mandatory) = 0, 4; Kategória:Segítség

I don't believe 0 is mandatory here at all. The normal setting is 4, 12 (Wikipedia and Help). We also don't have support for searching in categories right now.

Jan 17 2020, 3:03 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Tgr, Growth-Team
Catrope added a comment to T230478: Get the Growth experiment for the Hungarian Wikipedia.

On which namespaces it have to be deployed = 0, 2, 4

Shouldn't this be 2, 4, 12? That's how all our existing wikis are configured. Including 0 worries me in particular. See also T231720#5811842

Jan 17 2020, 3:02 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Tgr, Growth-Team
Catrope added a comment to T238319: Deploy Help Panel to Ukrainian, Hungarian, Armenian Wikipedias.

The ukwiki and huwiki patch don't enable the help panel in the main namespace in read mode, even though that was requested, because it's unusual and we've never done it before. If we decide that is desired, we can do it, but for now I'm erring on the side of caution. I brought this up on the Ukranian-specific task at T231720#5811842.

Jan 17 2020, 3:00 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope added a comment to T231720: Deploy Growth experiments at Ukrainian Wikipedia.

On which namespaces it have to be deployed = 0, 2, 4

Just checking, this means the help panel would appear in read mode on pages in the main, User and Wikipedia namespaces, but not in the Help namespace. Is that intended? On every other wiki that has the help panel, we don't enable it in the main namespace, and do enable it in the Help namespace (in other words, we do 2, 4, 12). Note that this is just about where the help panel appears in read mode; in edit mode it will appear in every namespace.

Jan 17 2020, 2:57 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team
Catrope assigned T238295: Deploy Welcome Survey to Ukrainian, Hungarian, Armenian Wikipedias to MMiller_WMF.

The patch above is incomplete, we'll need to add the URLs of the translated privacy policies once they're available. Assigning to @MMiller_WMF since he's the liaison with Legal for that.

Jan 17 2020, 2:28 AM · Patch-For-Review, Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope moved T238294: Deploy EditorJourney to Ukrainian, Hungarian, Armenian Wikipedias from Ready for Development to Needs PM Review on the Growth-Team (Current Sprint) board.

This is ready to go, waiting on a decision from @MMiller_WMF as to when to deploy this. We probably want @nettrom_WMF to be around?

Jan 17 2020, 2:24 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope added a comment to T242808: Newcomer tasks: mobile - Topic filters check marks overlaps labels.

I can't reproduce this on desktop Chrome (with or without mobile emulator), desktop Firefox (with or without mobile emulator), or mobile Chrome (on Android). Does this only happen on iPhones? Does it happen in desktop Safari too?

Jan 17 2020, 1:59 AM · Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope moved T224883: Homepage: discovery of homepage after account creation (mobile) from Code Review to QA on the Growth-Team (Current Sprint) board.
Jan 17 2020, 1:42 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Growth-Team (Current Sprint), Growth Design, GrowthExperiments-HomepageDiscovery, Mobile, GrowthExperiments-Homepage

Jan 16 2020

Catrope added a comment to T243026: Newcomer tasks: ambassadors test topic matching in production.

For completeness: if you want to turn topic matching back off and test the UI that normal users see, you can run step 3 but with the 1 changed to a 0:

new mw.Api().saveOption('growthexperiments-homepage-suggestededits-topics-enabled', 0).done( function() { window.location.reload() });
Jan 16 2020, 10:04 PM · User-Dyolf77, NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope moved T242418: Newcomer tasks: add article counter to footer of start editing dialog from Code Review to QA on the Growth-Team (Current Sprint) board.
Jan 16 2020, 7:28 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope added a comment to T205361: Make an HTML dump of the output of the CodeReview extension on MediaWiki.org.

Looks good to me

Jan 16 2020, 12:29 AM · Core Platform Team Workboards (Clinic Duty Team), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-extensions-CodeReview
Catrope reassigned T242932: Remove censorship bar from Turkish Wikipedia logo from Catrope to Reedy.
Jan 16 2020, 12:24 AM · Turkish-Sites, Wikimedia-Site-requests
Catrope closed T242932: Remove censorship bar from Turkish Wikipedia logo as Resolved.
Jan 16 2020, 12:24 AM · Turkish-Sites, Wikimedia-Site-requests

Jan 15 2020

Catrope updated subscribers of T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

I'm very excited about this proposal and eager to adopt a modern framework like Vue!
I think there's still a lot of infrastructure that needs to be put in place to take advantage of single-file components, and I'm wondering what the developer experience is like without them.

Supporting single-file components wouldn't actually be that hard at all. With small modifications to our existing infrastructure, we could have ResourceLoader automatically remap SFCs to JS component definitions (with the template as a string), because this transformation is very simple. We wouldn't be able to support ES6 or scoped styles though (because those depend on preprocessing steps that use nodejs libraries).

Jan 15 2020, 11:18 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
Catrope added a comment to T242400: Newcomer tasks: ambassadors test morelike.

I created the page and made the changes as suggested.

Jan 15 2020, 8:21 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Dyolf77, NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope added a comment to T223988: Wrong grammatical case of month names in Slavic languages in StructuredDiscussions extension.

@Catrope Would that PR also solve the same problem with dates in Special:Notifications?

Jan 15 2020, 3:38 AM · Upstream, I18n, StructuredDiscussions, Growth-Team

Jan 14 2020

Catrope closed T222851: Improve Echo seentime code for multi-DC access, a subtask of T212129: Use a multi-dc aware store for ObjectCache's MainStash if needed., as Resolved.
Jan 14 2020, 5:13 PM · MediaWiki-General, serviceops-radar, User-mobrovac, User-jijiki, Performance-Team (Radar), Operations
Catrope closed T222851: Improve Echo seentime code for multi-DC access, a subtask of T234294: Configurable timestamp storage, as Resolved.
Jan 14 2020, 5:13 PM · Growth-Team, Notifications, Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Multi-DC Echo Notification Storage)
Catrope closed T222851: Improve Echo seentime code for multi-DC access as Resolved.
Jan 14 2020, 5:13 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), CPT Initiatives (Multi-DC Echo Notification Storage), User-Eevans, Growth-Team, Notifications
Catrope updated the task description for T222851: Improve Echo seentime code for multi-DC access.
Jan 14 2020, 5:13 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), CPT Initiatives (Multi-DC Echo Notification Storage), User-Eevans, Growth-Team, Notifications
Catrope added a comment to T242698: Newcomer tasks: hidden preference.

I've scheduled the config patch for the 19:00 UTC SWAT on Thursday Jan 16. The train should already have run by then (it's scheduled for 14:00-15:00 UTC).

Jan 14 2020, 2:16 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope added a comment to T242698: Newcomer tasks: hidden preference.

Once this is deployed, the following console snippet will enable topic matching in production:

new mw.Api().saveOption('growthexperiments-homepage-suggestededits-topics-enabled', 1).done( function() { window.location.reload() });

To turn it back off, change the 1 to 0.

Jan 14 2020, 2:11 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope moved T242698: Newcomer tasks: hidden preference from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Jan 14 2020, 2:05 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), NewcomerTasks 1.1, Growth-Team (Current Sprint)

Jan 13 2020

Catrope moved T238612: Newcomer tasks: topic filters from Code Review to QA on the Growth-Team (Current Sprint) board.
Jan 13 2020, 11:38 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1

Jan 10 2020

Catrope added a comment to T242446: Decide timing of the automatic mediawiki branch cut.

I think having the branch be cut at a fixed time would be good in general, because it would make the process more predictable. It would be helpful if the branch cut happened late enough in the day that there's an opportunity for people to merge patches on Tuesday morning in time for the train, but I also recognize that you can't both cut it late enough that developers on the US west coast have a chance to merge patches (say 18:00 UTC) and also cut it early enough that a releng team member in Europe can run the train (which currently happens at 14:00 UTC, when it happens).

Jan 10 2020, 10:31 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Core Platform Team, Release-Engineering-Team (Deployment services), Goal
Catrope added a comment to T242414: Consider adding suggestion widget to OOUI.

There are some issues with the existing code in MachineVision that I ran into when I copied it to GrowthExperiments:

  • It depends on mediawiki.template.mustache+dom, which is in the WikibaseMediaInfo extension (MachineVision already depends on WBMI, but it doesn't make sense for GrowthExperiments to depend on WBMI)
  • The mustache+dom templating engine avoids destructively rerendering embedded OOUI widgets, which is good, but it does destructively rerender nodes created by the template. This is a problem, because it breaks CSS transitions for state changes.
  • Because CSS transitions don't work, the widget uses CSS animations instead. But that causes a bug where the widgets animate (the text moves from left to right) when they're being unhidden or added to the DOM.
  • There is no clean group widget for these, so I had to make one by picking the relevant pieces from ImageWithSuggestionsWidget (which contains a lot of other things as well). Without that, the SuggestionWidgets don't behave correctly, because they rely on a CSS class set on the parent element to hide the outline.
  • These widgets don't extend SelectWidget and OptionWidget, which means you have to reinvent some wheels around selection management and getting the selected values from the group widget for example
Jan 10 2020, 9:06 PM · Structured-Data-Backlog, MachineVision, OOUI, Growth-Team, GrowthExperiments
Catrope added a comment to T242400: Newcomer tasks: ambassadors test morelike.

Links to the config pages:

Jan 10 2020, 7:29 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Dyolf77, NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope placed T238612: Newcomer tasks: topic filters up for grabs.

Like Kosta I also ran out of time, so I'll put this back in the pool so that either Kosta can pick it up in his morning, or I can pick it up in my morning tomorrow.

Jan 10 2020, 12:53 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope moved T238611: Newcomer tasks: topic filter button from Code Review to QA on the Growth-Team (Current Sprint) board.

The button doesn't do anything yet when clicked, but I'm going to implement that as part of T238612

Jan 10 2020, 12:30 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Growth-Team (Current Sprint), NewcomerTasks 1.1

Jan 9 2020

Catrope moved T238612: Newcomer tasks: topic filters from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Jan 9 2020, 11:45 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope claimed T238612: Newcomer tasks: topic filters.
Jan 9 2020, 11:45 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope added a comment to T238610: Newcomer tasks: include topics in intro overlay.

hi there - I think the mock-ups were based on the v1.0 'final mocks' which have since had minor text changes. I've just updated to match what's in the copy doc and happy to go with option B as well.

Jan 9 2020, 11:26 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1

Jan 8 2020

Catrope closed T233465: Newcomer tasks: article configurations for topics, a subtask of T231506: Newcomer tasks: prototype topic matching, as Resolved.
Jan 8 2020, 11:30 PM · NewcomerTasks 1.1, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope closed T233465: Newcomer tasks: article configurations for topics as Resolved.

These are now done:

Jan 8 2020, 11:30 PM · CommRel-Specialists-Support (Jul-Sep-2019), NewcomerTasks 1.1, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope closed T241021: Newcomer tasks: article configurations for topics (viwiki), a subtask of T233465: Newcomer tasks: article configurations for topics, as Resolved.
Jan 8 2020, 11:30 PM · CommRel-Specialists-Support (Jul-Sep-2019), NewcomerTasks 1.1, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope closed T241021: Newcomer tasks: article configurations for topics (viwiki) as Resolved.

I have transferred the config to this page on viwiki, which is protected so that only admins can edit it: https://vi.wikipedia.org/wiki/MediaWiki:NewcomerTopics.json

Jan 8 2020, 11:30 PM · NewcomerTasks 1.1, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T240512: Newcomer tasks: Morelike backend for topic matching.

@kostajh @Tgr @Catrope -- when I try this on Czech or Korean Beta, I am able to select a task type from the dropdown, but the topic field remains free text, with no choices. Does something need to be changed?
I'm here: https://cs.wikipedia.beta.wmflabs.org/wiki/Speci%C3%A1ln%C3%AD:API_p%C3%ADskovi%C5%A1t%C4%9B#action=query&format=json&list=growthtasks

Jan 8 2020, 6:29 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope moved T238610: Newcomer tasks: include topics in intro overlay from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Jan 8 2020, 2:24 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1

Jan 6 2020

Catrope placed T238888: Variant tests: "initiation" test (A vs. B) up for grabs.
Jan 6 2020, 10:19 PM · Product-Analytics (Kanban), MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Growth-Team (Current Sprint), NewcomerTasks Future Release