Page MenuHomePhabricator

Catrope (Roan Kattouw)
Software engineer, Design Systems Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (442 w, 2 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF) [ Global Accounts ]

Recent Activity

Today

Catrope reassigned T329383: Wikifunctions specific icons for the mode selector from Catrope to Volker_E.
Sat, Apr 1, 1:11 AM · Design-Systems-Team (Design-Systems-Sprint), Design, OOUI, Codex
Catrope closed T329383: Wikifunctions specific icons for the mode selector as Resolved.
Sat, Apr 1, 1:11 AM · Design-Systems-Team (Design-Systems-Sprint), Design, OOUI, Codex

Yesterday

Catrope created T333713: Document how to wrap the Dialog component.
Fri, Mar 31, 5:23 PM · Design-Systems-Team, Codex

Thu, Mar 30

Catrope added a comment to T328777: Develop plan for DST representation at Hackathon 2023.

I've submitted our session proposal as T333611: [Session] An introduction to Codex: the design system for Wikimedia

Thu, Mar 30, 11:23 PM · Design-Systems-Team (Design-Systems-Sprint)
Catrope created T333611: [Session] An introduction to Codex: the design system for Wikimedia.
Thu, Mar 30, 11:22 PM · Wikimedia-Hackathon-2023

Tue, Mar 28

Catrope closed T332167: Combobox: Button submits the form as Resolved.
Tue, Mar 28, 9:38 PM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope closed T295165: Allow all necessary input types in the TextInput component as Resolved.
Tue, Mar 28, 9:38 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope committed rEVTE5a21d7773739: Update Codex to v0.8.0 (authored by Catrope).
Update Codex to v0.8.0
Tue, Mar 28, 9:35 PM
Catrope added a comment to T312987: Add a way to set the native type attribute on Codex Buttons.

I've submitted a PR to the Citizen skin: https://github.com/StarCitizenTools/mediawiki-skins-Citizen/pull/606

Tue, Mar 28, 9:35 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope updated the task description for T312987: Add a way to set the native type attribute on Codex Buttons.
Tue, Mar 28, 9:33 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope updated the task description for T312987: Add a way to set the native type attribute on Codex Buttons.
Tue, Mar 28, 9:27 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope moved T324708: Dialog: support header and footer customization from Code Review to Design Sign-Off on the Design-Systems-Team (Design-Systems-Sprint) board.
Tue, Mar 28, 9:25 PM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Catrope moved T285592: Add generally applicable `z-index` stack to MediaWiki skin variables and Codex/WikimediaUI Base from Code Review to Design Sign-Off on the Design-Systems-Team (Design-Systems-Sprint) board.
Tue, Mar 28, 9:16 PM · Patch-For-Review, CSS, Design-Systems-Team (Design-Systems-Sprint), Codex, WikimediaUI-Base, MediaWiki-Core-Skin-Architecture
Catrope updated subscribers of T333354: Announce Grade A JavaScript requirement rising from ES5 to ES6.
Tue, Mar 28, 7:06 PM · Browser-Support-Internet-Explorer, Performance-Team, JavaScript, MediaWiki-ResourceLoader
Catrope renamed T331044: TextArea: Move from WIP components to public components from TextArea: Move from WIP components to pubic components to TextArea: Move from WIP components to public components.
Tue, Mar 28, 5:38 PM · Design-Systems-Team, Codex

Mon, Mar 27

Catrope added a parent task for T332923: `@supports` ruleset doesn't include the selector: T328602: Enable use of Codex Less mixins inside of MediaWiki.
Mon, Mar 27, 4:27 PM · Performance-Team (Radar), Design-Systems-Team (Design-Systems-Sprint), Less.php
Catrope added a subtask for T328602: Enable use of Codex Less mixins inside of MediaWiki: T332923: `@supports` ruleset doesn't include the selector.
Mon, Mar 27, 4:27 PM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), MediaWiki-Core-Skin-Architecture, Patch-For-Review, Codex, Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General
Catrope added a comment to T332754: Create a basic "Hello world" example of how to use Codex outside MediaWiki.

There's also https://gitlab.wikimedia.org/repos/abstract-wiki/wlh as a working example

Mon, Mar 27, 4:24 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope updated subscribers of T332753: Create a basic "Hello world" example of how to use Codex in a MediaWiki extension.

@egardner points out we can use https://github.com/egardner/codex-starter as a starting point and adapt it to be an extension

Mon, Mar 27, 4:16 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope updated subscribers of T332754: Create a basic "Hello world" example of how to use Codex outside MediaWiki.

@egardner points out we can use https://github.com/egardner/codex-starter as a starting point, it probably has most of what we need already

Mon, Mar 27, 4:16 PM · Design-Systems-Team (Design-Systems-Sprint), Codex

Thu, Mar 23

Catrope added a comment to T332923: `@supports` ruleset doesn't include the selector.

Thanks for finding this! I think the responsible commit might be this one, which appears to add tests in directives-bubbling.less. It looks like the commit that follows it may be related too. I found some of these pieces while trying to fix this, but this should give a better picture of the changes we need to port.

Thu, Mar 23, 8:56 PM · Performance-Team (Radar), Design-Systems-Team (Design-Systems-Sprint), Less.php

Wed, Mar 22

Catrope added a comment to T319064: <ORG> Creative Commons 4.0 Licensing.
Wed, Mar 22, 8:50 PM · Foundational Technology Requests
Catrope created T332754: Create a basic "Hello world" example of how to use Codex outside MediaWiki.
Wed, Mar 22, 1:24 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope added a subtask for T328777: Develop plan for DST representation at Hackathon 2023: T332753: Create a basic "Hello world" example of how to use Codex in a MediaWiki extension.
Wed, Mar 22, 1:22 AM · Design-Systems-Team (Design-Systems-Sprint)
Catrope added a parent task for T332753: Create a basic "Hello world" example of how to use Codex in a MediaWiki extension: T328777: Develop plan for DST representation at Hackathon 2023.
Wed, Mar 22, 1:22 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope created T332753: Create a basic "Hello world" example of how to use Codex in a MediaWiki extension.
Wed, Mar 22, 1:22 AM · Design-Systems-Team (Design-Systems-Sprint), Codex

Thu, Mar 16

Catrope committed rEVTE05152d76ad18: Update Codex to 0.7.0 and rename `type` prop to `weight` (authored by AnneT).
Update Codex to 0.7.0 and rename `type` prop to `weight`
Thu, Mar 16, 10:03 PM
Catrope committed rEVTE62f4360a11eb: i18n: Replace "Your Name" placeholder with actual author names (authored by Catrope).
i18n: Replace "Your Name" placeholder with actual author names
Thu, Mar 16, 4:51 PM
Volker_E awarded T325237: Enable and document use of Codex design tokens within MediaWiki a Mountain of Wealth token.
Thu, Mar 16, 4:05 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General, Documentation, Codex
Catrope added a comment to T296689: [EPIC] Address themeability needs for Codex components.

Reviving this old task with some thoughts about what it would take to have more than one theme in Codex:

In the tokens package, we would have to:

  • Add a theme-foo.json file in codex-design-tokens/src/, whose tokens have the same names as the ones in theme-wikimedia-ui.json but different values
  • Configure Style Dictionary to build dist/theme-foo.{css,less,scss} files using the tokens from theme-foo.json instead of the ones from theme-wikimedia-ui.json.

To preserve the historical record, I don't want to edit this comment from almost a year ago, but I should add here that I've since realized that it's not this simple. T325237#8700501 goes into a little more detail, but briefly: it's not the case that to make a different theme, you would only have to change the values in theme-wikimedia-ui.json but not those in codex-base.json. The filenames imply that, but it's not true. We would need to do more to figure out how this would work, and how we should organize our files and directories differently.

Thu, Mar 16, 2:21 AM · Design-Systems-Team, Epic, Patch-For-Review, Codex

Wed, Mar 15

Catrope added a comment to T325237: Enable and document use of Codex design tokens within MediaWiki.

In the future, we would like to add these "neutral" values as a theme in Codex, so that the defaults file can just import that theme, but that's out of scope for this task.

If this really is the better solution, should we consider just going ahead and doing this now?

Wed, Mar 15, 11:24 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General, Documentation, Codex
Catrope added a comment to T325237: Enable and document use of Codex design tokens within MediaWiki.

Is there a MediaWiki page that documents the existing skin variables system (prior to the changes we are proposing for better Codex integration)?

Wed, Mar 15, 11:09 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General, Documentation, Codex
Catrope updated the task description for T325237: Enable and document use of Codex design tokens within MediaWiki.
Wed, Mar 15, 11:07 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General, Documentation, Codex

Tue, Mar 14

Catrope added a comment to T330803: Field: explore implementation options.

A flaw of option 1 is that you must bind :disabled to both the outer Field and the inner Fields; the outer Field will not tell the inner Fields whether they should be disabled (although we can probably figure out a sensible way to do this).

We could use provide/inject so that a nested Field can find its parent Field and disable itself if the parent is disabled. We could also explore using this technique to communicate state between Field components and the input components inside them, although that would require a bit more complexity, as we'd have to duplicate that logic in TextInput, Checkbox, Radio, etc (we could wrap it in a composable, but still, all those components would have to know about it).

Tue, Mar 14, 3:04 AM · Accessibility, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope moved T331953: Export component tokens separately from base tokens from Inbox to Infrastructure on the Codex board.
Tue, Mar 14, 1:32 AM · Design-Systems-Team, Codex
Catrope moved T331953: Export component tokens separately from base tokens from Requests to Needs Refinement on the Design-Systems-Team board.
Tue, Mar 14, 1:31 AM · Design-Systems-Team, Codex
Catrope created T331953: Export component tokens separately from base tokens.
Tue, Mar 14, 1:31 AM · Design-Systems-Team, Codex
Catrope moved T331952: Add test page for CSS-only components from Requests to Refined/Up Next on the Design-Systems-Team board.
Tue, Mar 14, 1:17 AM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), VueTest
Catrope created T331952: Add test page for CSS-only components.
Tue, Mar 14, 1:17 AM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), VueTest

Fri, Mar 10

Catrope updated the task description for T328602: Enable use of Codex Less mixins inside of MediaWiki.
Fri, Mar 10, 12:05 AM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), MediaWiki-Core-Skin-Architecture, Patch-For-Review, Codex, Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General

Thu, Mar 9

Catrope moved T328042: Add px values representation in the Codex demos from Inbox to Contributor Experience on the Codex board.
Thu, Mar 9, 8:24 PM · Design-Systems-Team, Codex
Catrope updated the task description for T328602: Enable use of Codex Less mixins inside of MediaWiki.
Thu, Mar 9, 8:23 PM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), MediaWiki-Core-Skin-Architecture, Patch-For-Review, Codex, Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General
Catrope updated the task description for T325237: Enable and document use of Codex design tokens within MediaWiki.
Thu, Mar 9, 8:21 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General, Documentation, Codex
Catrope removed a subtask for T330694: tokens: Split out deprecated tokens into separate file: T331403: Replace legacy value tokens in WikimediaUI Base, OOUI and downstream.
Thu, Mar 9, 8:02 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope removed a parent task for T331403: Replace legacy value tokens in WikimediaUI Base, OOUI and downstream: T330694: tokens: Split out deprecated tokens into separate file.
Thu, Mar 9, 8:02 PM · WikimediaUI-Base, Design-Systems-Team, Codex
Catrope moved T330694: tokens: Split out deprecated tokens into separate file from Committed to Code Review on the Design-Systems-Team (Design-Systems-Sprint) board.
Thu, Mar 9, 8:01 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Restricted Application triaged T330694: tokens: Split out deprecated tokens into separate file as High priority.
Thu, Mar 9, 8:01 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope added a comment to T325237: Enable and document use of Codex design tokens within MediaWiki.

@Volker_E Are you happy with the neutral values in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/886929/ , or does more work need to be done there?

Thu, Mar 9, 8:00 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General, Documentation, Codex
Catrope added a comment to T330694: tokens: Split out deprecated tokens into separate file.
Thu, Mar 9, 7:59 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope closed T321470: Use the system's typographic scale tokens (font size and line-heights) as Resolved.
Thu, Mar 9, 7:49 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope closed T321470: Use the system's typographic scale tokens (font size and line-heights), a subtask of T305947: Define the system's typographic scale (font sizes and line-heights), as Resolved.
Thu, Mar 9, 7:48 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Catrope closed T331457: Replace `icon-accessory` with `icon-subtle` as Resolved.
Thu, Mar 9, 7:45 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope moved T329383: Wikifunctions specific icons for the mode selector from Code Review to Ready for Development on the Design-Systems-Team (Design-Systems-Sprint) board.

Looks like these icons still need to be added to OOUI?

Thu, Mar 9, 7:44 PM · Design-Systems-Team (Design-Systems-Sprint), Design, OOUI, Codex
kostajh awarded T314507: Allow MediaWiki developers to use their local version of Codex a Love token.
Thu, Mar 9, 10:21 AM · Design-Systems-Team, Codex

Wed, Mar 8

Catrope claimed T325237: Enable and document use of Codex design tokens within MediaWiki.
Wed, Mar 8, 8:37 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General, Documentation, Codex
Catrope moved T325237: Enable and document use of Codex design tokens within MediaWiki from Code Review to In Development on the Design-Systems-Team (Design-Systems-Sprint) board.
Wed, Mar 8, 8:37 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General, Documentation, Codex

Tue, Mar 7

Sgs awarded T305515: Consider migrating from Jest to Vitest a Like token.
Tue, Mar 7, 11:52 AM · Design-Systems-Team, Codex

Mon, Mar 6

Catrope committed rEVTE24227319fe9e: Docs: Add hint for uninitialized submodule and for older Node versions (authored by Konfused-Kitten).
Docs: Add hint for uninitialized submodule and for older Node versions
Mon, Mar 6, 10:57 PM

Sat, Mar 4

Catrope added a comment to T328163: Application Security Review Request : VueTest extension (proposed for beta cluster deployment only).

Ok, thanks for the update. I think this would likely make this security review a bit lower in priority for us since, for now, this extension will only ever live on beta and the risk for that has already been accepted by a WMF manager/director.

Sat, Mar 4, 1:27 AM · secscrum, Security, Application Security Reviews
Catrope closed T327499: Dropdown of Vector 2022 search incorrectly responds to enter as Resolved.
Sat, Mar 4, 1:25 AM · Design-Systems-Team (Design-Systems-Sprint), Codex, Readers-Web-Backlog, Desktop Improvements (Vector 2022)
Catrope moved T330665: MenuItem: refine highlight behavior from In Development to Design Sign-Off on the Design-Systems-Team (Design-Systems-Sprint) board.
Sat, Mar 4, 1:24 AM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex

Thu, Mar 2

Catrope closed T316046: docs: Add one-line description of each component as Resolved.
Thu, Mar 2, 6:58 PM · Design-Systems-Team (Design-Systems-Sprint), Codex

Mar 1 2023

Catrope added a comment to T330691: Table of mentees on the Mentor dashboard is not visible on Timeless.

I think this is happening because the import in NoEditsDisplay has one ../ to few. From mediawiki/extensions/GrowthExperiments/modules/ext.growthExperiments.Homepage.NewImpact/components/NoEditsDisplay.vue, the import path ../../../../resources/lib/codex-design-tokens/theme-wikimedia-ui.less resolves to mediawiki/extensions/resources/lib/codex-design-tokens/theme-wikimedia-ui.less , which doesn't exist. You need one more ../ to make it work.

Mar 1 2023, 6:14 PM · Community Feedback (Growth), MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), Growth-Team (Current Sprint), GrowthExperiments-Mentorship, Timeless, GrowthExperiments-MentorDashboard
Catrope added a comment to T330694: tokens: Split out deprecated tokens into separate file.

The attached patches implement my proposal. They don't exactly do what the task title asks for, but they solve the same problem: remove 84 of the 94 deprecated tokens from Codex, so they can later be moved into wikimedia-ui-base instead.

Mar 1 2023, 2:00 AM · Design-Systems-Team (Design-Systems-Sprint), Codex

Feb 28 2023

Catrope added a comment to T330694: tokens: Split out deprecated tokens into separate file.

For deprecated tokens that are just aliases of non-deprecated tokens, I think it would make the most sense to remove them from Codex completely, and just provide those aliases in wikimedia-ui-base. For deprecated tokens that have unique values (values different from any non-deprecated tokens), I think it should keep them in Codex as deprecated tokens.

Feb 28 2023, 6:12 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope committed rEVTE068cd2e12709: Add ToggleSwitch to the Codex demo navigation (authored by Catrope).
Add ToggleSwitch to the Codex demo navigation
Feb 28 2023, 1:14 AM

Feb 27 2023

Catrope added a comment to T330711: Patchdemo's Node LTS version is incompatible with latest Vitepress.

PatchDemo issue: https://github.com/MatmaRex/patchdemo/issues/531

Feb 27 2023, 10:46 PM · Patch-For-Review, MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope added a project to T330711: Patchdemo's Node LTS version is incompatible with latest Vitepress: Codex.
Feb 27 2023, 10:25 PM · Patch-For-Review, MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope added a comment to T330303: docs: Shiki transforms code on its own terms.


It looks like this only happens when code is wrapped in a ```less or ```css block. The formatter for ```vue is much less opinionated, and just breaks lines that are too long.

Feb 27 2023, 6:55 PM · Design-Systems-Team, Codex, Documentation
Catrope changed the status of T330466: Split Codex styles into separate ResourceLoader modules from Open to In Progress.
Feb 27 2023, 5:41 PM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope moved T330466: Split Codex styles into separate ResourceLoader modules from Research to Ready for Development on the Design-Systems-Team (Design-Systems-Sprint) board.
Feb 27 2023, 5:41 PM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope changed the status of T330466: Split Codex styles into separate ResourceLoader modules, a subtask of T330468: [EPIC] Enable use of CSS-only Codex components in MediaWiki, from Open to In Progress.
Feb 27 2023, 5:41 PM · Epic, Design-Systems-Team, Codex

Feb 24 2023

Catrope added a comment to T324375: docs: Provide code samples that work in MediaWiki.

We could use the code groups feature in VitePress to build something like this:

image.png (806×755 px, 61 KB)
image.png (806×755 px, 60 KB)
Feb 24 2023, 10:04 PM · Documentation, Codex, Design-Systems-Team
Catrope renamed T330303: docs: Shiki transforms code on its own terms from docs: Prism transforms code on its own terms to docs: Shiki transforms code on its own terms.
Feb 24 2023, 4:13 AM · Design-Systems-Team, Codex, Documentation
Catrope placed T301038: [Ready for Development] Improve List of All Icons tabular presentation up for grabs.
Feb 24 2023, 4:00 AM · Design-Systems-Team, I18n, RTL, Documentation, Codex
Catrope moved T330350: documentation: Document how to create a basic "Hello World" Gadget using Vue & Codex from Inbox to Codex Adoption on the Codex board.
Feb 24 2023, 3:56 AM · Front-end Modernization, Codex, Design-Systems-Team
Catrope triaged T330469: Improve the developer experience for using CSS-only Codex components in MediaWiki as Medium priority.
Feb 24 2023, 3:50 AM · Design-Systems-Team, Codex
Catrope moved T330469: Improve the developer experience for using CSS-only Codex components in MediaWiki from Inbox to Codex Adoption on the Codex board.
Feb 24 2023, 3:50 AM · Design-Systems-Team, Codex
Catrope removed a subtask for T325105: [Epic] Add CSS-only versions of most Codex Vue components: T326850: [Spike] Figure out how to generate markup for CSS components.
Feb 24 2023, 3:50 AM · Epic, Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, CSS, Codex
Catrope edited parent tasks for T326850: [Spike] Figure out how to generate markup for CSS components, added: T330469: Improve the developer experience for using CSS-only Codex components in MediaWiki; removed: T325105: [Epic] Add CSS-only versions of most Codex Vue components.
Feb 24 2023, 3:50 AM · Design-Systems-Team, CSS, Codex
Catrope added a subtask for T330469: Improve the developer experience for using CSS-only Codex components in MediaWiki: T326850: [Spike] Figure out how to generate markup for CSS components.
Feb 24 2023, 3:50 AM · Design-Systems-Team, Codex
Catrope created T330469: Improve the developer experience for using CSS-only Codex components in MediaWiki.
Feb 24 2023, 3:49 AM · Design-Systems-Team, Codex
Catrope triaged T330467: Document how to use CSS-only components in MediaWiki as High priority.
Feb 24 2023, 3:44 AM · Design-Systems-Team, Codex
Catrope moved T330467: Document how to use CSS-only components in MediaWiki from Inbox to Codex Adoption on the Codex board.
Feb 24 2023, 3:44 AM · Design-Systems-Team, Codex
Catrope moved T330466: Split Codex styles into separate ResourceLoader modules from Inbox to Infrastructure on the Codex board.
Feb 24 2023, 3:43 AM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope triaged T330468: [EPIC] Enable use of CSS-only Codex components in MediaWiki as High priority.
Feb 24 2023, 3:43 AM · Epic, Design-Systems-Team, Codex
Catrope moved T330468: [EPIC] Enable use of CSS-only Codex components in MediaWiki from Inbox to Codex Adoption on the Codex board.
Feb 24 2023, 3:42 AM · Epic, Design-Systems-Team, Codex
Catrope added a parent task for T328602: Enable use of Codex Less mixins inside of MediaWiki: T330468: [EPIC] Enable use of CSS-only Codex components in MediaWiki.
Feb 24 2023, 3:41 AM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), MediaWiki-Core-Skin-Architecture, Patch-For-Review, Codex, Design-Systems-Team (Design-Systems-Sprint), MediaWiki-General
Catrope added a parent task for T330466: Split Codex styles into separate ResourceLoader modules: T330468: [EPIC] Enable use of CSS-only Codex components in MediaWiki.
Feb 24 2023, 3:41 AM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope added a parent task for T330467: Document how to use CSS-only components in MediaWiki: T330468: [EPIC] Enable use of CSS-only Codex components in MediaWiki.
Feb 24 2023, 3:41 AM · Design-Systems-Team, Codex
Catrope added subtasks for T330468: [EPIC] Enable use of CSS-only Codex components in MediaWiki: T328602: Enable use of Codex Less mixins inside of MediaWiki, T330466: Split Codex styles into separate ResourceLoader modules, T330467: Document how to use CSS-only components in MediaWiki.
Feb 24 2023, 3:41 AM · Epic, Design-Systems-Team, Codex
Catrope created T330468: [EPIC] Enable use of CSS-only Codex components in MediaWiki.
Feb 24 2023, 3:41 AM · Epic, Design-Systems-Team, Codex
Catrope created T330467: Document how to use CSS-only components in MediaWiki.
Feb 24 2023, 3:38 AM · Design-Systems-Team, Codex
Catrope triaged T330466: Split Codex styles into separate ResourceLoader modules as High priority.

I favor #3, because we don't need an NPM-compatible module name in this context, and I think #1 and #2 would be confusing because they pretend to be NPM-compatible but aren't. But that's not a strongly held opinion, and I'd love to hear other opinions or other naming suggestions.

Feb 24 2023, 3:29 AM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope updated the task description for T330466: Split Codex styles into separate ResourceLoader modules.
Feb 24 2023, 3:29 AM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope created T330466: Split Codex styles into separate ResourceLoader modules.
Feb 24 2023, 3:26 AM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), Codex
Catrope added a comment to T330349: [Spike] Determine the extent to which the Gadgets extension supports .vue files.

if setting ['type' => 'script'] is appropriate for .vue files, enabling Vue is as easy as changing the regex in MediaWikiGadgetsDefinitionRepo.php (which doesn’t necessarily mean that Vue actually works, just that the file extension barrier is removed).

['type' => 'script'] is not the appropriate type for .vue files, it's ['type' => 'script-vue'] (this matters because .vue files need certain transformations, and can also contain styles in addition to script code). But that shouldn't be too hard to address, we'd probably just need to add another category of resources to the Gadget class, like we did for JSON files ('datas' at rEGAD includes/MediaWikiGadgetsDefinitionRepo.php:272-282 (at 7793a9475f18) and getJSONs() at rEGAD includes/Gadget.php:334 (at 7793a9475f18))

Feb 24 2023, 12:45 AM · Front-end Modernization, Codex, Design-Systems-Team, Epic
Catrope moved T325772: Add CSS-only (or non-client-side-JS) icon from Code Review to Design Sign-Off on the Design-Systems-Team (Design-Systems-Sprint) board.
Feb 24 2023, 12:13 AM · Patch-For-Review, Design-Systems-Team (Design-Systems-Sprint), CSS, Codex
Catrope added a comment to T328163: Application Security Review Request : VueTest extension (proposed for beta cluster deployment only).

I've added this exception to our risk register. Is this ever being planned for a production deployment? I think we should still perform a security review of the code, regardless, I'm just less clear after reading this language within the description: "Only used for testing, and only proposed for deployment to the beta cluster, not to production wikis."

Feb 24 2023, 12:10 AM · secscrum, Security, Application Security Reviews
Catrope added a comment to T327499: Dropdown of Vector 2022 search incorrectly responds to enter.

@matmarex thanks for the suggestions! I had forgotten about the mousemove event.

mousemove does indeed provide the ideal UX here, in that it avoids highlighting an item that happens to be under the cursor when the menu opens, but starts highlighting items as soon as the mouse moves. My only concern is that it gets triggered with each mouse move—I wonder if there's a performance concern with the mousemove handler being called over and over if the mouse is moved a lot? cc @Catrope

Feb 24 2023, 12:05 AM · Design-Systems-Team (Design-Systems-Sprint), Codex, Readers-Web-Backlog, Desktop Improvements (Vector 2022)