Catrope (Roan Kattouw)
Collaboration team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (154 w, 5 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF)

Recent Activity

Today

Catrope updated subscribers of T176704: mediawiki.api does not use consistent reject parameters.
Tue, Sep 26, 6:43 AM · JavaScript, MediaWiki-API
Catrope awarded T176704: mediawiki.api does not use consistent reject parameters a The World Burns token.
Tue, Sep 26, 5:11 AM · JavaScript, MediaWiki-API
Catrope created T176704: mediawiki.api does not use consistent reject parameters.
Tue, Sep 26, 5:11 AM · JavaScript, MediaWiki-API

Yesterday

Catrope added a comment to T176380: Stop community links from opening then closing on Recent changes.

@Mooeypoo re-opened - the issue is still present in FF 55.

Mon, Sep 25, 9:52 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Performance, Edit-Review-Improvements
Catrope moved T176348: Add 'View newest changes' and 'Live update' to Watchlist from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Mon, Sep 25, 8:56 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist
Catrope added a comment to T176652: Performance review of RCFilters feature.

See also T176445: Systematically test load speeds of Watchlist and Recent Changes

Mon, Sep 25, 5:34 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Performance-Team (Radar), Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage
Catrope moved T176264: New Watchlist UI with edit filters breaks unwatch links next to entries from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Mon, Sep 25, 5:20 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
He7d3r awarded T176300: Fix page reflow on Watchlist and Recent Changes a Like token.
Mon, Sep 25, 2:36 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters

Fri, Sep 22

Catrope moved T176328: 'Latest revision' + 'Logged actions' filters don't display Deleted pages on Watchlist and Recent Changes from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Fri, Sep 22, 5:40 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Thu, Sep 21

Catrope added a comment to T171027: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis.

Thanks for the detailed analysis @Bawolff and @jcrespo . My $0.02:

Thu, Sep 21, 11:05 PM · DBA, Wikidata, Commons, Contributors-Team, User-notice, Wikimedia-log-errors, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Russian-Sites, Wikimedia-General-or-Unknown, Performance, MediaWiki-Watchlist
Catrope added a comment to T176445: Systematically test load speeds of Watchlist and Recent Changes.

...and he's already done it: https://gerrit.wikimedia.org/r/#/c/379664/ . I will review shortly.

Thu, Sep 21, 10:19 PM · Operations, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Performance, Edit-Review-Improvements
Catrope added a comment to T176445: Systematically test load speeds of Watchlist and Recent Changes.

@Catrope, you signed yourself up to create a way to turn off Live Update. Whoever is taking on this task should be able to get going without that, but please coordinate with whomever you assign.

Thu, Sep 21, 10:18 PM · Operations, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Performance, Edit-Review-Improvements
Catrope added a comment to T176367: Watchlist css classes are messed up.

Does this happen only with the "New filters for edit review" beta feature enabled, or also with it disabled?

Thu, Sep 21, 4:17 PM · Regression, CSS, MediaWiki-Watchlist
Catrope added a comment to T176300: Fix page reflow on Watchlist and Recent Changes.

The above commit contains a bunch of fixes and tweaks that together eliminate reflow completely on my localhost (except for a very small horizontal reflow that is specific to the watchlist in enhanced mode), We'll have to see if it completely eliminates all reflows in production too, but I did test with large-ish community link sections, so hopefully it will, and if not it should come close.

Thu, Sep 21, 12:19 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters

Wed, Sep 20

Catrope added a comment to T176251: Asymmetrical MediaWiki:Watchlist-summary.
It’s quite easy to do by site CSS (the current 70% width is also done by site CSS), but I need some CSS classes to distinguish between the two versions.
Wed, Sep 20, 11:27 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements, MediaWiki-Watchlist
Catrope added a comment to T176300: Fix page reflow on Watchlist and Recent Changes.

(I'll still propose that though.)

Proposed here: https://en.wikipedia.org/wiki/MediaWiki_talk:Watchlist-details#Proposal:_Move_help_links_from_MediaWiki:Watchlist-details_to_MediaWiki:Watchlist-summary

Wed, Sep 20, 10:46 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T176300: Fix page reflow on Watchlist and Recent Changes.

I'll propose moving these links on the talk page.

Wed, Sep 20, 10:45 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T176300: Fix page reflow on Watchlist and Recent Changes.

watchlistdetails also isn't inside that min-height I think is it ?

Wed, Sep 20, 10:24 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T176300: Fix page reflow on Watchlist and Recent Changes.

@Catrope is this a dupe of some of the other tickets, or is this a task we'll want to prioritize for fixing before next week's release?

And should I change the title to "Fix page reflow on Watchlist and Recent Changes"?

Wed, Sep 20, 9:48 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T176300: Fix page reflow on Watchlist and Recent Changes.

watchlistdetails also isn't inside that min-height I think is it ?

Wed, Sep 20, 9:23 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope moved T176302: Mentions not displaying properly when replying in flow from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Wed, Sep 20, 7:06 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, StructuredDiscussions
Catrope edited projects for T176302: Mentions not displaying properly when replying in flow, added: Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017); removed Collaboration-Team-Triage.

This should be fixed in production now.

Wed, Sep 20, 7:06 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, StructuredDiscussions
Catrope moved T176264: New Watchlist UI with edit filters breaks unwatch links next to entries from QA Review to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.

The patch makes the 'x'es appear, but they don't actually work in the new UI (neither in enhanced mode nor in non-enhanced mode). When you click the 'x' in the new UI in non-enhanced mode, it goes to a new page rather than using AJAX, and in enhanced mode it does nothing at all.

Wed, Sep 20, 6:42 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T176300: Fix page reflow on Watchlist and Recent Changes.

We mostly try to prevent the reflow by setting a min-height on the container that will contain the UI, but:

  • That min-height value is just a little too low
Wed, Sep 20, 5:56 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope moved T176300: Fix page reflow on Watchlist and Recent Changes from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Wed, Sep 20, 5:33 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope edited projects for T176300: Fix page reflow on Watchlist and Recent Changes, added: Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017); removed Collaboration-Team-Triage.
Wed, Sep 20, 5:33 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T173533: No longer block user from clicking results when page is loading..

Please think of T176300: Fix page reflow on Watchlist and Recent Changes when this gets done... combined, i'm sure they will account for a significant amount of 'misclicks' by people.

Wed, Sep 20, 5:33 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page

Tue, Sep 19

Catrope added a comment to T176254: [betalabs] monobook RC page with filters and 'Grouped results by page' does not display markers.

It's pretty simple: green is unseen. Both the arrows and squares turn green if the entry is unseen.

Tue, Sep 19, 11:31 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage
Catrope added a comment to T176254: [betalabs] monobook RC page with filters and 'Grouped results by page' does not display markers.
Tue, Sep 19, 11:30 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage
Catrope placed T176251: Asymmetrical MediaWiki:Watchlist-summary up for grabs.
Tue, Sep 19, 11:17 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements, MediaWiki-Watchlist
Catrope added a comment to T176250: Defer building new filters menu to speed up performance.

There's another area for improvement that @Mooeypoo has been working on: T173533: No longer block user from clicking results when page is loading.. Currently, we show a loading animation and an overlay over the results while the UI is loading, but we should really just let the user interact with the results list right away. The reason we currently do this is because in some cases (if the user has a saved query that they've made default), we may need to reload the result list and replace it with the result of a different query, because default saved queries are handled entirely client-side. Moriel is working on moving this server-side (T166908: ChangesListSpecialPage backend: Respect saved query if no parameters) and after that's done we can remove the loading thing from the results list.

Tue, Sep 19, 10:31 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Performance, Edit-Review-Improvements
Catrope added a comment to T176250: Defer building new filters menu to speed up performance.

It looks like the RC sometimes very slow to load.

  1. The above patch address only some of the slowness (the hidden UI creation can take ~1sec)

Thanks! It looks good to me but I'll let @Mooeypoo make the final call, she wrote most of that code.

Tue, Sep 19, 10:25 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Performance, Edit-Review-Improvements
Catrope moved T176264: New Watchlist UI with edit filters breaks unwatch links next to entries from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Tue, Sep 19, 9:44 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope edited projects for T176264: New Watchlist UI with edit filters breaks unwatch links next to entries, added: Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017); removed Collaboration-Team-Triage.

Where is the 'Grouped by page' option?

Tue, Sep 19, 9:44 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T176264: New Watchlist UI with edit filters breaks unwatch links next to entries.

Looks like this only breaks in grouped ("enhanced") mode, in non-grouped mode it works fine.

Tue, Sep 19, 9:29 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T176250: Defer building new filters menu to speed up performance.

I think he likely did mean RC, because he's a hewiki user and we launched RCFilters as a default there today.

Tue, Sep 19, 9:20 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Performance, Edit-Review-Improvements
Catrope moved T176228: Special:RelatedChanges with edit filters has query error due to missing join on page table from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Tue, Sep 19, 5:27 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Catrope claimed T176228: Special:RelatedChanges with edit filters has query error due to missing join on page table.
Tue, Sep 19, 5:22 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Catrope moved T176228: Special:RelatedChanges with edit filters has query error due to missing join on page table from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Tue, Sep 19, 4:30 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Catrope triaged T176228: Special:RelatedChanges with edit filters has query error due to missing join on page table as Unbreak Now! priority.
Tue, Sep 19, 4:30 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T175062: Update gadgets for seen/unseen styling.

All the copies are now done.

Tue, Sep 19, 3:56 PM · Collaboration-Community-Engagement, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters, MediaWiki-Watchlist
Catrope moved T172387: Cannot set my default to see all results (no filters) from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Tue, Sep 19, 3:08 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Qgil awarded T175934: Give the right to sysops to create, move and delete Structured Discussions boards on wikis where they are available as a Beta feature a Love token.
Tue, Sep 19, 9:14 AM · User-notice, Chinese-Sites, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Community-Liaisons (Jul-Sep 2017), Collaboration-Community-Engagement, User-notice-collaboration, StructuredDiscussions
Catrope moved T176191: [betalabs] Watchlist - empty markers displayed for seen/unseen changes from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Tue, Sep 19, 5:08 AM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)

Mon, Sep 18

Catrope added a comment to T172757: Migrate and convert user preferences to the new UX.

Clarification: this is asking for preferences to modify the base defaults (as they currently already do), not magically create a new saved filter as we previously discussed.

Mon, Sep 18, 9:14 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters, MediaWiki-User-preferences
Catrope moved T175765: Move New Filters opt-out preference to its own section on the page from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Mon, Sep 18, 6:36 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review, User-Petar.petkovic, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Collaboration-Community-Engagement

Thu, Sep 14

Catrope added a comment to T175934: Give the right to sysops to create, move and delete Structured Discussions boards on wikis where they are available as a Beta feature.

https://www.wikidata.org/wiki/Special:ListGroupRights#sysop now lists flow-create-board

Thu, Sep 14, 11:39 PM · User-notice, Chinese-Sites, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Community-Liaisons (Jul-Sep 2017), Collaboration-Community-Engagement, User-notice-collaboration, StructuredDiscussions
Catrope moved T175934: Give the right to sysops to create, move and delete Structured Discussions boards on wikis where they are available as a Beta feature from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Thu, Sep 14, 11:38 PM · User-notice, Chinese-Sites, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Community-Liaisons (Jul-Sep 2017), Collaboration-Community-Engagement, User-notice-collaboration, StructuredDiscussions
Catrope moved T175934: Give the right to sysops to create, move and delete Structured Discussions boards on wikis where they are available as a Beta feature from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Thu, Sep 14, 10:18 PM · User-notice, Chinese-Sites, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Community-Liaisons (Jul-Sep 2017), Collaboration-Community-Engagement, User-notice-collaboration, StructuredDiscussions
Catrope added a comment to T175934: Give the right to sysops to create, move and delete Structured Discussions boards on wikis where they are available as a Beta feature.

My patch adds the following logic to the Flow config: if the Flow beta feature is enabled, or Flow occupies one or more entire namespaces, then give sysops the flow-create-board right.

Thu, Sep 14, 10:12 PM · User-notice, Chinese-Sites, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Community-Liaisons (Jul-Sep 2017), Collaboration-Community-Engagement, User-notice-collaboration, StructuredDiscussions
Catrope added a comment to T175318: Optimize SVGs in data URIs.

Unencoded " broke older versions of Android in my testing, mostly. Maybe they’re no longer common enough to worry about.

Thu, Sep 14, 9:48 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Front-end-Standards-Group, Performance-Team (Radar), MediaWiki-ResourceLoader
Catrope added a comment to T175062: Update gadgets for seen/unseen styling.

LGTM. Didn't test though, maybe @Etonkovidova can do that now that you've put this on beta cluster?

Thu, Sep 14, 12:03 AM · Collaboration-Community-Engagement, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters, MediaWiki-Watchlist

Wed, Sep 13

Catrope added a comment to T175318: Optimize SVGs in data URIs.

@matmarex As the article and furthermore RFC 3986 in Appendix D.2 states :

but only ' is allowed in a URL.

If you want to follow the RFC closely, then spaces must also be URL-encoded. But we want to unencode them so clearly we're disregarding the standards and doing what works ;) I don't see why spaces would be okay to unencode but quotes not.

Wed, Sep 13, 8:15 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Front-end-Standards-Group, Performance-Team (Radar), MediaWiki-ResourceLoader
Catrope renamed T175773: Make a TechCom RfC about proposed way to add a 'Reverted' feature from Make an RfC to ask the community about proposed way to add a 'Reverted' feature to Make a TechCom RfC about proposed way to add a 'Reverted' feature.
Wed, Sep 13, 1:06 AM · Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2017), Edit-Review-Improvements-Integrated-Filters
Catrope moved T174734: Changes to namespaces are not highlighted as requested if 'Group results by page' is enabled from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Wed, Sep 13, 12:46 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Catrope moved T175611: Preferences - Watchlist still has "Revision scoring" displayed after beta feature "New filters for edit review" is enabled from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Wed, Sep 13, 12:36 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page

Tue, Sep 12

Catrope reopened T175611: Preferences - Watchlist still has "Revision scoring" displayed after beta feature "New filters for edit review" is enabled as "Open".

@Etonkovidova points out that I was wrong, two of them are used by contribs but one of them isn't. Also, we do still need the part of my change that takes the RC opt-out into account.

Tue, Sep 12, 10:40 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Catrope closed T175611: Preferences - Watchlist still has "Revision scoring" displayed after beta feature "New filters for edit review" is enabled as Declined.

As @SBisson pointed out in code review, these preferences are all still used on the contributions page, so we can't get rid of any of them.

Tue, Sep 12, 6:31 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T173613: Make "live update" not download the entire RC page every 3 seconds.

I only see a HTTP 503 in the case that should return a HTTP 304 – otherwise, I correctly get an empty page with HTTP 200. Perhaps our caching layer doesn't like the 304. Try just using a HTTP 200 always and instead returning the information in the body (e.g. a '1' or '0')?

Tue, Sep 12, 6:18 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Performance, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Catrope reopened T110846: Enable Flow in Odia (Oriya) Wikipedia as "Open".
Tue, Sep 12, 5:33 PM · Community-Liaisons (Jul-Sep 2017), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Wikimedia-Site-requests, StructuredDiscussions
Catrope reopened T110846: Enable Flow in Odia (Oriya) Wikipedia, a subtask of T117990: Enable the Flow personal talk opt-in Beta Feature on some wikis, as Open.
Tue, Sep 12, 5:33 PM · Collaboration-Community-Engagement, Goal, Community-Liaisons, Collaboration-Team-Triage, Wikimedia-Site-requests, StructuredDiscussions
Catrope moved T169613: Introduce the New Filters to users upon beta graduation from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Tue, Sep 12, 12:40 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Catrope moved T175611: Preferences - Watchlist still has "Revision scoring" displayed after beta feature "New filters for edit review" is enabled from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.

I also noticed that the code for hiding the RC-related ORES preferences when RCFilters is enabled didn't take into account the new opt-out preference, so I fixed that too.

Tue, Sep 12, 12:34 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Catrope moved T175314: Confirm beta opt-in and (graduated) New Filters opt-out are compatible from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.

I just approved the patch for T168376 and confirmed it works with that patch. I can opt into the beta feature but out of the RC page, and when I do that I get the old interface on the RC page and the new interface on the watchlist.

Tue, Sep 12, 12:29 AM · Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Collaboration-Community-Engagement
Catrope moved T168376: Put an opt-out for the New Filters onto the current (unconsolidated) RC Preferences page from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Tue, Sep 12, 12:24 AM · Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Collaboration-Community-Engagement

Mon, Sep 11

Catrope updated subscribers of T175639: RCFilters intro tour displayed on Special:Watchlist even if filters are disabled on watchlist.

@jmatazzoni Not sure if this is a blocker for anything since we're rolling out the watchlist beta soon anyway, at which point this'll be moot.

Mon, Sep 11, 10:21 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Catrope created T175639: RCFilters intro tour displayed on Special:Watchlist even if filters are disabled on watchlist.
Mon, Sep 11, 10:20 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page

Sat, Sep 9

Catrope committed rADES3b8ffdd52656: Add codemirror-syntax-highlight beta feature (authored by Catrope).
Add codemirror-syntax-highlight beta feature
Sat, Sep 9, 3:36 AM

Wed, Sep 6

Catrope updated the task description for T175053: Make RCFilters compatible with both the old and new thresholds APIs.
Wed, Sep 6, 10:31 PM · Scoring-platform-team, Collaboration-Team-Triage, ORES
Catrope renamed T175053: Make RCFilters compatible with both the old and new thresholds APIs from Confirm that "thresholds" change will not affect RCFilters to Make RCFilters compatible with both the old and new thresholds APIs.
Wed, Sep 6, 10:05 PM · Scoring-platform-team, Collaboration-Team-Triage, ORES
Catrope moved T173613: Make "live update" not download the entire RC page every 3 seconds from Code Review Started to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Wed, Sep 6, 9:15 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Performance, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Catrope claimed T175085: Invalid namespace given (-1) when undeleting?.
Wed, Sep 6, 8:09 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Wikimedia-log-errors, StructuredDiscussions
Catrope added a comment to T175080: Flow fails to load content when running CirrusSearchLinksUpdate jobs.

Aha. But there are some fawiki occurrences too, although they look different.

Wed, Sep 6, 8:04 PM · CirrusSearch, Discovery, StructuredDiscussions, Wikimedia-log-errors, Collaboration-Team-Triage
Catrope added a comment to T175080: Flow fails to load content when running CirrusSearchLinksUpdate jobs.

Does anyone know which wikis this error happens on? For example, does it only happen on testwiki and test2wiki?

Wed, Sep 6, 8:01 PM · CirrusSearch, Discovery, StructuredDiscussions, Wikimedia-log-errors, Collaboration-Team-Triage
Catrope added a comment to T175085: Invalid namespace given (-1) when undeleting?.

/w/api.php?action=flow&format=json&submodule=view-header&uselang=en&page=Special%3AUndelete&vhformat=html is a very weird request. Who or what would ever want to treat Special:Undelete as a Flow page?

Wed, Sep 6, 8:01 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Wikimedia-log-errors, StructuredDiscussions
Catrope moved T174725: Turn off 'classic' ORES highlighting on the Watchlist (with beta) from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Wed, Sep 6, 12:38 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, MediaWiki-Watchlist, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)

Tue, Sep 5

Catrope updated the task description for T164234: Provide "RC Filters" functionality on the watchlist.
Tue, Sep 5, 9:42 PM · Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage, MediaWiki-Watchlist, Epic

Aug 18 2017

Catrope moved T173613: Make "live update" not download the entire RC page every 3 seconds from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 18 2017, 11:49 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Performance, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Catrope edited projects for T173613: Make "live update" not download the entire RC page every 3 seconds, added: Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017); removed Collaboration-Team-Triage.
Aug 18 2017, 11:49 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Performance, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Catrope created T173613: Make "live update" not download the entire RC page every 3 seconds.
Aug 18 2017, 11:48 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Performance, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T173411: Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload, Special:Notifications) (module ext.echo.styles.badge not loaded).

Also, why did you diff en against es? They have the same behavior on Special:Notifications (both work) for me, while fr is broken.

Aug 18 2017, 11:12 PM · User-notice-collaboration, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Special-pages, Regression, Notifications
Catrope added a comment to T173411: Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload, Special:Notifications) (module ext.echo.styles.badge not loaded).
ORES:/Hooks.php
	public static function onBeforePageDisplay( OutputPage &$out, Skin &$skin ) {
		if ( !self::oresUiEnabled( $out->getUser() ) ) {
			return;
		}

This might be our culprit. Although I was expecting to see a return false; here, given that, if I recall correctly, we changed it years ago that implicit return or null return defaults to true, not casted to false. And indeed, looking at Hooks::run() we only ever abort if either a string is returned, or explicit false (strict equality).

Aug 18 2017, 11:11 PM · User-notice-collaboration, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Special-pages, Regression, Notifications
Catrope added a comment to T172840: Some RC changes do not display highlight with ORES Quality and Intent filters .

I looked into a few of these cases and none of these edits have entries in the ores_classification table even though they should. So it looks like ORES occasionally craps out or times out and a few edits go unscored.

Aug 18 2017, 10:54 PM · Scoring-platform-team, Collaboration-Team-Triage, ORES
Catrope moved T172213: Simplify the 'Previously viewed changes' marker on Live Update and View Newest Changes from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 18 2017, 10:18 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page, Edit-Review-Improvements-Integrated-Filters
Catrope edited Description on Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017).
Aug 18 2017, 10:17 PM
Catrope moved T171218: Separate the user's 'Saved filters' on Watchlist from the user's 'Saved filters' on RC page from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 18 2017, 9:56 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist
Catrope moved T171132: Initial setup of watchlist to use new UI from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 18 2017, 9:56 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist
Catrope moved T171121: Rename 'Mark all pages as Visited" button to "Mark all changes as Seen" and put in the new UI style from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 18 2017, 9:56 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist
Catrope moved T171127: Adapt 'Watchlisted pages' filter group (or create similar one) for Watchlist from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 18 2017, 9:56 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist

Aug 17 2017

Catrope added a comment to T168376: Put an opt-out for the New Filters onto the current (unconsolidated) RC Preferences page .

I think we'll want to add a feature flag that puts RCFilters in either beta mode or default mode. That would make it easier to roll out the beta graduation to different wikis over the course of several weeks, as we plan to do.

Aug 17 2017, 4:35 AM · Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Collaboration-Community-Engagement

Aug 16 2017

Catrope lowered the priority of T173411: Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload, Special:Notifications) (module ext.echo.styles.badge not loaded) from Unbreak Now! to High.

(Downgrading from UBN to High on the assumption that only one special page is broken)

Aug 16 2017, 9:56 PM · User-notice-collaboration, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Special-pages, Regression, Notifications
Catrope added a comment to T173411: Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload, Special:Notifications) (module ext.echo.styles.badge not loaded).

About regression: I'm 95% sure it was OK 19 days ago on this page.

Aug 16 2017, 9:55 PM · User-notice-collaboration, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Special-pages, Regression, Notifications
Catrope added a comment to T138424: Special:Notifications broken on Safari 4.

Were you trying to view cross-wiki notifications in a no-JS environment? That is known not to work. The counter includes foreign notifications, but the no-JS version of Special:Notifications only shows local ones. There's a task for fixing that somewhere.

Aug 16 2017, 9:50 PM · Collaboration-Team-Triage, Browser-Support-Apple-Safari, Notifications
Catrope added a comment to T173411: Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload, Special:Notifications) (module ext.echo.styles.badge not loaded).

For some reason a LOT of modules are missing on Special:GadgetUsage. I think this might be a bug in the special page, not in Echo. Investigating.

Aug 16 2017, 9:34 PM · User-notice-collaboration, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Special-pages, Regression, Notifications
Catrope added a comment to T164898: PostgreSQL schema change for consistency with MySQL.

As per the TechCom (FKA ArchCom) meeting on August 16th, this RFC is entering the Last Call period. Should no pertinent objections remain unaddressed by August 30th, the RFC will be approved for implementation.

Aug 16 2017, 8:41 PM · TechCom-RfC (ArchCom-Approved), Technical-Debt, MediaWiki-Platform-Team, PostgreSQL
Catrope moved T164898: PostgreSQL schema change for consistency with MySQL from Under discussion to Last Call on the TechCom-RfC board.
Aug 16 2017, 8:40 PM · TechCom-RfC (ArchCom-Approved), Technical-Debt, MediaWiki-Platform-Team, PostgreSQL
Catrope added a comment to T147137: RFC: JSON validation.

@Harej What's the status of this? From looking at this task, it looks like it kind of lost steam toward the end of last year?

Aug 16 2017, 8:35 PM · TechCom-Has-shepherd, MediaWiki-extensions-CollaborationKit, Multimedia, TechCom-RfC
Catrope added a comment to T135963: Add support for Content-Security-Policy (CSP) headers in MediaWiki.

@Bawolff What's the status of this? At least from this task it looks like it's been stalled for quite a while?

Aug 16 2017, 8:33 PM · TechCom-Has-shepherd, RfC, JavaScript, Security-Team, TechCom-RfC
Catrope moved T172477: Attribute anonymous contributions to the first IP address used in a session from Inbox to Under discussion on the TechCom-RfC board.
Aug 16 2017, 8:26 PM · TechCom-RfC, MediaWiki-User-management
Catrope moved T172165: Bump PHP requirement to 5.6 (or 7.x?) in 1.31 from Inbox to Under discussion on the TechCom-RfC board.
Aug 16 2017, 8:25 PM · RfC, TechCom-RfC, MediaWiki-General-or-Unknown