Page MenuHomePhabricator

Catrope (Roan Kattouw)
Growth team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (244 w, 6 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Catrope added a comment to T219816: Fatal IncompleteRevisionException when restoring an article (undelete page).

Doing the others now:

  • arcwiki
  • arwiki
  • azwiki
  • bgwiki
  • cawiki
  • commonswiki
  • cswiki
  • dawiki
  • dewiki
  • dewikiversity
  • dewikivoyage
  • enwiki
  • enwikibooks
  • enwikiquote
  • eswiki
  • eswiktionary
  • etwiki
  • fawiki
  • fiwiki
  • frwiki
  • frwikisource
  • hrwiki
  • huwiki
  • idwiki
  • itwiki
  • itwikivoyage
  • jawiki
  • kowiki
  • kvwiki
  • metawiki
  • nlwiki
  • nlwiktionary
  • nowiki
  • oswiki
  • plwiki
  • ptwiki
  • ruwiki
  • ruwiktionary
  • slwiki
  • sourceswiki
  • srwiki
  • svwiki
  • tawiki
  • testwiki
  • trwiki
  • ukwiki
  • zhwiki
Tue, Jun 18, 10:11 PM · Chinese-Sites, Patch-For-Review, Growth-Team, Wikimedia-production-error, MediaWiki-Page-deletion
Catrope added a comment to T222848: Homepage: traffic from email confirmation success page.

In the two no-Js scenarios above I would only consider displaying the message if browsing to another page and then back to the homepage would remove the message.
Would that be the case?

Tue, Jun 18, 6:58 PM · Desktop, Mobile, GrowthExperiments- HomepageDiscovery, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope added a comment to T219816: Fatal IncompleteRevisionException when restoring an article (undelete page).

The script finished on dewiktionary, and fixed all the rows with missing ar_sha1 values. I've undeleted the remaining revision on Böotien, and this bug should no longer affect undeletions on dewiktionary. I'll run the script for the other wikis tomorrow.

Tue, Jun 18, 2:49 AM · Chinese-Sites, Patch-For-Review, Growth-Team, Wikimedia-production-error, MediaWiki-Page-deletion
Catrope added a comment to T219816: Fatal IncompleteRevisionException when restoring an article (undelete page).

The testwiki run failed to remedy any of the 11 missing ar_sha1 entries because those archive rows point to broken text rows, with the external store URL DB://cluster20/0. I suspect this is the story behind most of the wikis that only have a handful of missing SHA1s. It's now running for dewikivoyage and that does seem to be doing something.

Tue, Jun 18, 12:24 AM · Chinese-Sites, Patch-For-Review, Growth-Team, Wikimedia-production-error, MediaWiki-Page-deletion

Mon, Jun 17

Catrope added a comment to T219816: Fatal IncompleteRevisionException when restoring an article (undelete page).

The populateRevisionSha1.php maintenance script includes code that finds rows with a blank ar_sha1 and populates them, but there's currently no way to run only that step without also recomputing the SHA1 for every single revision and archive row in the entire database. I'll write a patch so that we can do this next week (this week is a no-deploys week).

Mon, Jun 17, 11:21 PM · Chinese-Sites, Patch-For-Review, Growth-Team, Wikimedia-production-error, MediaWiki-Page-deletion

Fri, Jun 14

Catrope added a comment to T225848: Serialization errors not propagated to web response.

Tangential to the actual bug report, given that mw:Param is only inserted for top-level {{{..}}} that can't be expanded and hence is emitted as is, not sure why Parsoid html2wt insists on data-mw for this case.

Fri, Jun 14, 8:55 PM · Parsoid
Catrope created T225849: Parsoid incorrectly renders lines beginning with " :" (space colon).
Fri, Jun 14, 8:51 PM · Parsoid-DOM, Parsoid
Catrope created T225848: Serialization errors not propagated to web response.
Fri, Jun 14, 7:28 PM · Parsoid
Catrope added a comment to T225318: Homepage: homepage discovery for no-JS users.
  • the banners we show to no-Js users won't be auto-dismissible with a timer, and won't be dismissed by user interaction. I guess it should still be possible to use either the query string approach or the user preference to only show the banners to no-Js users once (only after account creation), but wanted to double-check that.

Yes, that's right.

Fri, Jun 14, 6:30 PM · Mobile, Desktop, GrowthExperiments- HomepageDiscovery, Growth Design, GrowthExperiments-Homepage, Growth-Team (Current Sprint)

Thu, Jun 13

Catrope added a comment to T224076: wmerrors has no license information.

I'm good with Apache or MIT.

Thu, Jun 13, 7:29 PM · Patch-For-Review, wmerrors, Software-Licensing
Catrope added a comment to T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89.

@Catrope @SBisson @Etonkovidova -- are these browser versions we're supposed to support? If so, we will want to address it for the MVP release. If not, then this will not need to be addressed.

Thu, Jun 13, 12:47 AM · Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage
Catrope added a comment to T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89.

It works fine for me on Android too:

Thu, Jun 13, 12:44 AM · Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage
Catrope closed T225682: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs as Resolved.
Thu, Jun 13, 12:43 AM · MediaWiki-User-login-and-signup, MediaWiki-Database, MediaWiki-extensions-CentralAuth
Catrope added a comment to T225318: Homepage: homepage discovery for no-JS users.

@Catrope told me that the sitenotice option is actually feasible. @Catrope, could you fill us in on your recommendations for these users?

Not all types of site notices work in no-JS, because some of them are based on stuff like geo location. However, if all our links/redirects that lead from the account creation / welcome survey flow to wherever users end up next add a query string parameter (say, ?showhomepagetour=1), then we could see that query string parameter on the server side and output a site notice into the HTML. No-JS users will then see that site notice. For JS users, that site notice HTML will also be delivered, and we can either let it stand, or hide it with CSS and instead show a GuidedTour (or display both).

Thu, Jun 13, 12:37 AM · Mobile, Desktop, GrowthExperiments- HomepageDiscovery, Growth Design, GrowthExperiments-Homepage, Growth-Team (Current Sprint)

Wed, Jun 12

Catrope added a comment to T225682: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs.

Strangely, I can't reproduce this locally, even in a Vagrant setup with CentralAuth. Perhaps it's specific to having the master and replica be different servers.

Wed, Jun 12, 11:28 PM · MediaWiki-User-login-and-signup, MediaWiki-Database, MediaWiki-extensions-CentralAuth
Catrope claimed T225682: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs.
Wed, Jun 12, 11:24 PM · MediaWiki-User-login-and-signup, MediaWiki-Database, MediaWiki-extensions-CentralAuth
Catrope added a comment to T225682: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs.

I think this happened because the change made DatabaseMysqlBase::doSelectDomain() use executeQuery() whereas it previously used doQuery(). The former has the assertIsWritableMaster() check but the latter bypasses it. USE queries appear to be considered write queries (because they're not explicitly marked as read queries by the regex in Database::isWriteQuery()), so this failure started happening every time we try to switch databases in MySQL.

Wed, Jun 12, 11:23 PM · MediaWiki-User-login-and-signup, MediaWiki-Database, MediaWiki-extensions-CentralAuth
Catrope updated subscribers of T225682: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs.
Wed, Jun 12, 11:19 PM · MediaWiki-User-login-and-signup, MediaWiki-Database, MediaWiki-extensions-CentralAuth
Catrope added a comment to T225682: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs.

I believe https://gerrit.wikimedia.org/r/c/mediawiki/core/+/512043 is likely to be the culprit.

Wed, Jun 12, 11:13 PM · MediaWiki-User-login-and-signup, MediaWiki-Database, MediaWiki-extensions-CentralAuth
Catrope added a comment to T225682: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs.

The first error of this type appeared at 20:05:59 UTC today (June 12)

Wed, Jun 12, 11:11 PM · MediaWiki-User-login-and-signup, MediaWiki-Database, MediaWiki-extensions-CentralAuth
Catrope added a comment to T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89.

I was going to take a look but can't because of T225682: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs, so I'm going to investigate that first.

Wed, Jun 12, 11:09 PM · Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage
Catrope triaged T225682: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs as Unbreak Now! priority.
Wed, Jun 12, 11:08 PM · MediaWiki-User-login-and-signup, MediaWiki-Database, MediaWiki-extensions-CentralAuth
Catrope created T225682: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs.
Wed, Jun 12, 11:08 PM · MediaWiki-User-login-and-signup, MediaWiki-Database, MediaWiki-extensions-CentralAuth
Restricted Application added a project to T225671: Consider moving echo.unseen counter to JS: Growth-Team.
Wed, Jun 12, 7:41 PM · Technical-Debt, Notifications, Growth-Team
Catrope added a comment to T225199: Fatal error during RecentChange::notifyEdit (deferred update) from ORES/RecentChangeSaveHookHandler.

There are 1043 Logstash events in the last 30 days that match +exception.trace:"RecentChangeSaveHookHandler" and only 9 of them match +exception.trace:"RecentChangeSaveHookHandler". However, the other 1034 all have the same stack trace, which is the one from T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push. (I checked that all of the non-ORES events match +exception.trace:"requeueError".) So they probably have the same root cause (or similar root causes).

Wed, Jun 12, 12:59 AM · Scoring-platform-team, WMF-JobQueue, Growth-Team, ORES, Wikimedia-production-error
Catrope added a comment to T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences.

The preference is labeled "Show Wikidata edits *by default* in recent changes". If you don't have it enabled, the default state of the RC filters when you open RC will be such that Wikidata edits aren't shown, but if you then change the filters they may end up being shown. I'm not sure how we could make this clearer.

Wed, Jun 12, 12:35 AM · Growth-Team (Current Sprint), Wikidata-Campsite, Wikidata, MediaWiki-Recent-changes

Tue, Jun 11

Catrope added a comment to T219816: Fatal IncompleteRevisionException when restoring an article (undelete page).

Some of the deleted revisions for this page have ar_sha1 set to an empty string, which is what causes this error. For this page, this only affects the revisions dated November 2012 and earlier. The ones after November 2012 do have ar_sha1 set, and I was able to undelete those successfully.

Tue, Jun 11, 11:32 PM · Chinese-Sites, Patch-For-Review, Growth-Team, Wikimedia-production-error, MediaWiki-Page-deletion
Catrope added a comment to P8607 Number of archive rows with blank ar_sha1 on each wiki.

On stat1006:

(for wiki in $(cat ~/all.dblist); do echo -n "$wiki: "; echo "select count(*) from archive where ar_sha1='';" | analytics-mysql $wiki -N; done) | tee ~/empty-sha1
cat ~/empty-sha1 | grep -v ': 0'
Tue, Jun 11, 10:33 PM
Catrope created P8607 Number of archive rows with blank ar_sha1 on each wiki.
Tue, Jun 11, 10:23 PM
Catrope added a comment to T222848: Homepage: traffic from email confirmation success page.

Thanks @kostajh and @Catrope for your feedback on this!

I also agree that redirecting the users to the Homepage would be the best option for the user experience.
Just want to make sure I understand correctly how this would work: after clicking on the link in the email, the Special:ConfirmEmail page will load and after some time it will redirect to Special:Homepage?
Or actually the redirect to Special:Homepage would be so quick that the user won't be able to see the Special:ConfirmEmail page?
The reason I'm asking is that if we're in the first scenario, then I think it would be good to offer some kind of feedback of what's happening to the user, like a message with indication that the user is being redirected and a countdown, or something similar.

Tue, Jun 11, 9:41 PM · Desktop, Mobile, GrowthExperiments- HomepageDiscovery, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope created T225550: Categories (and possibly other start-of-line transparent wikitext) that follow indent-pre wikitext get absorbed into <pre> tags and don't round-trip.
Tue, Jun 11, 6:18 PM · Parsoid
Catrope moved T224526: Homepage: impact module text changes from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jun 11, 12:35 AM · Mobile, Desktop, GrowthExperiments- ImpactModule , MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), GrowthExperiments, GrowthExperiments-Homepage

Mon, Jun 10

Catrope closed T186553: Notification badges in personal bar need visual focus feedback as Resolved.
Mon, Jun 10, 10:48 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team, WCAG-Level-AA, UI-Standardization, UI-Standardization-Kanban, Design, Accessibility, Notifications
Catrope moved T223144: Homepage: remove intro text from mobile homepage from In Progress to QA on the Growth-Team (Current Sprint) board.
Mon, Jun 10, 8:40 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope added a comment to T212433: Help panel: adapt for StructuredDiscussions.

Note that one of the reasons we put the name and the date in the header was to help make the header (more likely to be) unique, because with duplicate headers it's a pain to link to the right one. But that's only true for wikitext talk pages, not in Flow where every topic has an internal ID that's used for links. That's not to say that having dozens of topics on the same page all named "Help panel question" wouldn't still be confusing/annoying, so that might still be a valid reason to keep the username, or the date, or both.

Mon, Jun 10, 6:51 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Thu, Jun 6

Catrope added a comment to T225261: CentralNotice setting a surprising content security policy in production when using &banner= URL parameter.

The code from CentralNotice that does this: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/includes/CentralNoticeHooks.php#L230-L240

Thu, Jun 6, 11:15 PM · Fundraising-Backlog, Release-Engineering-Team, Security, MediaWiki-extensions-CentralNotice

Wed, Jun 5

Catrope added a comment to T222851: Improve Echo seentime code for multi-DC.

OK, if we can get away with not TTLing the data at all, that would certainly be simpler!

Wed, Jun 5, 12:21 AM · Growth-Team, Notifications
Catrope added a comment to T222014: Edits using Help pane can bypass sysop-issued blocks.

Note that making internal calls like that is a "code smell", though. I started trying to abstract the business logic of it from the API "front-end" in gerrit:460436, but priorities and team assignments changed and I haven't had time to work on it for a while.

Wed, Jun 5, 12:20 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Growth-Team (Current Sprint), Security, GrowthExperiments-Help panel
Catrope added a comment to T215983: Homepage: mobile version.
  • If the user's total edit count is less than or equal to 1,000, then display the article edit count with this language: "4 edits to articles"
  • If the user's total edit count is greater than 1,000, then display the total edit count with this language: "1,123 total edits"

I've submitted a patch on top of Stephane's that does this: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/514412

Wed, Jun 5, 12:16 AM · Epic, GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
Catrope added a comment to T221007: Extract Echo handling from SkinMinerva class.

More than one day, probably close to a week. This also requires a combination of doing some thinking about how exactly to approach this, and getting a brain dump from Piotr.

Wed, Jun 5, 12:15 AM · good first bug, Growth-Team, Notifications, Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Tue, Jun 4

Catrope added a comment to T222848: Homepage: traffic from email confirmation success page.

I like Kosta's idea of showing a "your email is verified" message based on whether the user was redirected from Special:ConfirmEmail to the home page.

Tue, Jun 4, 11:37 PM · Desktop, Mobile, GrowthExperiments- HomepageDiscovery, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope added a comment to T224473: Homepage: investigate duplicate question post.

Moving the task back to Incoming as the case needs more discussion.

Looking into history - I did not see reverted or any indication of the content being removed in some point.

Tue, Jun 4, 10:56 PM · Growth-Team (Current Sprint), GrowthExperiments, GrowthExperiments-Homepage
Catrope added a comment to T215983: Homepage: mobile version.

MediaWiki Core maintains a per-user total edit count that we can display. It turns out counting the edits for a single namespace is too expensive. We can change it to show the total edit count for all namespaces or, as Roan suggested in the patch, count up to 50 and then display 50+.

Tue, Jun 4, 6:21 PM · Epic, GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
Catrope added a comment to T222926: Use preferences for inputting email address.

Yes, the user will lose their unsaved edit if they navigate to Special:ChangeEmail. Clicking the link would first show them a warning that they're about to lose unsaved content, and they have to click through that to leave the editor and go to Special:ChangeEmail. After they finish changing/setting their email address, they will see a link taking them back to the page they were on (because of returnto, as Marshall said), which will also open the editor again (because of returntoquery, which will be set to action=edit or something similar). I believe VisualEditor will recover the unsaved change in this case, but despite that I think that making the user navigate away during an edit session is bad and we should avoid it.

Tue, Jun 4, 5:38 PM · GrowthExperiments-Help panel, GrowthExperiments- HelpModule, Mobile, Desktop, GrowthExperiments- MentorshipModule, Growth Design, GrowthExperiments-Homepage, Growth-Team (Current Sprint), GrowthExperiments

Wed, May 29

Catrope added a comment to T185664: FlaggedRevs: code stewardship review.

@Catrope, we can certainly find another home for this extension if you think another team is a better fit. Out of curiosity, is this related at all to the change from Collaboration to Growth? I'm trying to get a sense of whether the wrong call was made when we first reviewed this extension for Code Stewardship or if things just changed since then.

Wed, May 29, 5:57 PM · MediaWiki-extensions-FlaggedRevs, Code-Stewardship-Reviews
Catrope added a comment to T222539: Scap deployments are not purging MessageBlobStore (was: Stale localized messages).

Thanks for cleaning this up, @Krinkle and @thcipriani. I heard about this problem during the hackathon, but forgot to work on it and then went on vacation. The way it was solved is exactly what I had in mind,

Wed, May 29, 5:36 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Performance-Team (Radar), Release-Engineering-Team (Kanban), Patch-For-Review, Scap, Regression, MediaWiki-ResourceLoader
Catrope closed T220780: Move config for disabling web login-success notifications to LoginNotify extension as Resolved.

Yes

Wed, May 29, 5:11 PM · Community-Tech (Kanban), Community-Tech-Sprint, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-LoginNotify

May 18 2019

Catrope created T223731: Hide system-noemail category from notification preferences.
May 18 2019, 3:35 PM · Growth-Team, Notifications
Catrope committed rEREC51266ecf4063: Escape CAPTCHA key, and use wfArrayToCgi() to build query string (authored by Catrope).
Escape CAPTCHA key, and use wfArrayToCgi() to build query string
May 18 2019, 7:27 AM

May 17 2019

Catrope committed rEGREe2356f121d43: SpecialHomepage: Don't fatal if tutorial title isn't set (authored by Catrope).
SpecialHomepage: Don't fatal if tutorial title isn't set
May 17 2019, 2:56 PM
Catrope committed rERECf000733b1134: Escape CAPTCHA key, and use wfArrayToCgi() to build query string (authored by Catrope).
Escape CAPTCHA key, and use wfArrayToCgi() to build query string
May 17 2019, 2:42 PM
Catrope added a comment to T223526: Move Wikidata link from "Toolbox" to "Other projects" section.

It works (partially). It moves the link only if the "In other projects" section exists.

May 17 2019, 10:57 AM · Wikidata, Wikimedia-Hackathon-2019 (Newcomer friendly), Wikimedia-User-Group-Basque
Catrope added a comment to T223526: Move Wikidata link from "Toolbox" to "Other projects" section.

Maybe we can do it only for Basque wikipedia using js?

May 17 2019, 10:32 AM · Wikidata, Wikimedia-Hackathon-2019 (Newcomer friendly), Wikimedia-User-Group-Basque

May 13 2019

Catrope updated the task description for T125902: Remove Special:UserProfile class with redirect from MobileFrontend.
May 13 2019, 11:57 PM · MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)), Patch-For-Review, Reading-Web-Sprint-67-If, Then, Else...?, MobileFrontend
Catrope moved T222183: Homepage: help module -- add footer link to help desk from Code Review to QA on the Growth-Team (Current Sprint) board.
May 13 2019, 8:32 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope added a comment to T222926: Use preferences for inputting email address.

This could be the same as / similar to the button in the email submodule of the account module on the home page. Technically that button is just a link, and it links to Special:ChangeEmail (not to preferences).

May 13 2019, 4:52 PM · GrowthExperiments-Help panel, GrowthExperiments- HelpModule, Mobile, Desktop, GrowthExperiments- MentorshipModule, Growth Design, GrowthExperiments-Homepage, Growth-Team (Current Sprint), GrowthExperiments

May 9 2019

Catrope added a comment to T219372: Homepage: help and mentorship modals should notify bad email format with error message.

This also applies to the help panel, which shares (much of) the relevant code with the help and mentorship dialogs.

May 9 2019, 9:16 PM · good first bug, Wikimedia-Hackathon-2019, GrowthExperiments, Growth-Team
Catrope renamed T222848: Homepage: traffic from email confirmation success page from Homepage: traffic from confirming emails to Homepage: traffic from email confirmation success page.
May 9 2019, 8:26 PM · Desktop, Mobile, GrowthExperiments- HomepageDiscovery, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope renamed T222852: Homepage: discovery of homepage after account creation (desktop) from Homepage: discovery of main page after account creation to Homepage: discovery of homepage after account creation.
May 9 2019, 8:26 PM · Desktop, Mobile, GrowthExperiments- HomepageDiscovery, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope added a comment to T222918: Put "shim" code for namespaces, logs, and log i18n into WikimediaMessages so we can undeploy extensions.

Sounds sane to me; except that I think the scope might need to be extended to random other bits (beyond namespaces, log types and i18n) that we're not thinking of now but will discover when we try to undeploy an extension.

May 9 2019, 8:22 PM · Release-Engineering-Team (Kanban), WikimediaMessages, Wikimedia-Site-requests
Catrope added a comment to T222847: Homepage: addition to main page.

The "sitenotice" area mentioned in option B is where the Wiki Loves Earth banner is in the screenshot below. If no banner is shown, the sitenotice area is empty (so not easy to point out in a screenshot), but it still exists and we can put stuff in it.

May 9 2019, 7:15 PM · Desktop, Mobile, GrowthExperiments- HomepageDiscovery, Growth Design, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope updated subscribers of T222847: Homepage: addition to main page.

We have three main options:

  • A: Put something in the "chrome" area of the page (the upside-down-L-shaped area along the top and left edge of the screen), which includes the sidebar, personal links and tabs along the top
  • B: Put something in the "sitenotice" area, which is where site notices, central notices and fundraising banners go
  • C: Put something in the content area of the main page
May 9 2019, 7:12 PM · Desktop, Mobile, GrowthExperiments- HomepageDiscovery, Growth Design, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Catrope added a comment to T222851: Improve Echo seentime code for multi-DC.

@Catrope also, I talked to @kaldari by email yesterday, and he thought that all the data was going into the main stash. Is that true? I might need to review the Echo code again.

May 9 2019, 7:00 PM · Growth-Team, Notifications
jeblad awarded T222539: Scap deployments are not purging MessageBlobStore (was: Stale localized messages) a Party Time token.
May 9 2019, 8:17 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Performance-Team (Radar), Release-Engineering-Team (Kanban), Patch-For-Review, Scap, Regression, MediaWiki-ResourceLoader

May 8 2019

Catrope updated subscribers of T222851: Improve Echo seentime code for multi-DC.

Migrating from one storage backend to another, and from individual keys to pairs, would be a bit complicated. @mobrovac suggested that it would be easier if we could do both of these migrations at the same time. One way to do that would be to create a config setting that takes an array of storage backends, and have the code try these in order when reading. That way we can configure it to read first from the new backend, then the old backend (and then the user preference, which we still have fallback code for today), but only write new values to the first one, and we could make the pair vs separate keys thing a property of each storage backend as well.

May 8 2019, 11:42 PM · Growth-Team, Notifications
Catrope added a subtask for T212129: Use a multi-dc aware store for ObjectCache's MainStash if needed.: T222851: Improve Echo seentime code for multi-DC.
May 8 2019, 11:25 PM · User-mobrovac, Services (doing), User-jijiki, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Performance-Team (Radar), Operations, MediaWiki-Cache, serviceops
Catrope added a parent task for T222851: Improve Echo seentime code for multi-DC: T212129: Use a multi-dc aware store for ObjectCache's MainStash if needed..
May 8 2019, 11:25 PM · Growth-Team, Notifications
Catrope created T222851: Improve Echo seentime code for multi-DC.
May 8 2019, 11:25 PM · Growth-Team, Notifications
Catrope moved T220762: [betalabs] Stuck cross-wiki notification from In Progress to QA on the Growth-Team (Current Sprint) board.

I ran the script above to recompute the notification counts for every user who could potentially have been affected by this (users who had at least one unread login-success notification). It took a while to run, but it finished some time yesterday. This should completely resolve the issue: new cases shouldn't happen (unless someone changes a notification type from being available on web to unavailable on web again), and existing cases should now be fixed. Nobody should be seeing wrong counts or phantom notifications anymore.

May 8 2019, 10:43 PM · Growth-Team (Current Sprint), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Community-Tech, Notifications, MediaWiki-extensions-LoginNotify
Catrope committed rEGRE3fb298c891c0: Help panel: Only offer the email input when email address is unset (authored by Catrope).
Help panel: Only offer the email input when email address is unset
May 8 2019, 10:19 PM
Catrope committed rEGREc4b50470536a: Help panel: Only offer the email input when email address is unset (authored by Catrope).
Help panel: Only offer the email input when email address is unset
May 8 2019, 10:04 PM
Catrope moved T222846: Don't offer email input in help panel when email address is already set from Incoming to Code Review on the Growth-Team (Current Sprint) board.
May 8 2019, 10:01 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Growth-Team (Current Sprint), GrowthExperiments-Help panel
Catrope added a project to T222846: Don't offer email input in help panel when email address is already set: Growth-Team (Current Sprint).
May 8 2019, 10:01 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Growth-Team (Current Sprint), GrowthExperiments-Help panel
Catrope created T222846: Don't offer email input in help panel when email address is already set.
May 8 2019, 10:00 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Growth-Team (Current Sprint), GrowthExperiments-Help panel

May 7 2019

Catrope committed rEGREfb618fc18af0: Append number to prevent duplicate question headers (authored by kostajh).
Append number to prevent duplicate question headers
May 7 2019, 10:22 PM
Catrope committed rEGRE181b4711272c: QuestionPoster refactoring (authored by kostajh).
QuestionPoster refactoring
May 7 2019, 10:22 PM
Catrope committed rMSCA02b384d24ebe: Clear MessageBlobStore after syncing i18n data (authored by Catrope).
Clear MessageBlobStore after syncing i18n data
May 7 2019, 3:43 AM
Catrope committed rMSCAe437dd68cec0: Clear MessageBlobStore after syncing i18n data (authored by Catrope).
Clear MessageBlobStore after syncing i18n data
May 7 2019, 3:43 AM
Catrope committed rMSCA7b59f5790092: Clear MessageBlobStore after syncing i18n data (authored by Catrope).
Clear MessageBlobStore after syncing i18n data
May 7 2019, 3:43 AM
Catrope added a comment to T217719: Post-mortem "MWException: No localisation cache found for English.".

Wrong bug, sorry. Neither of these patches addresses this bug, although 508488 is semi-related.

May 7 2019, 1:29 AM · Release-Engineering-Team (Kanban), Wikimedia-Incident, Deployments, MediaWiki-Internationalization, Wikimedia-production-error
Catrope claimed T222539: Scap deployments are not purging MessageBlobStore (was: Stale localized messages).
May 7 2019, 1:28 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Performance-Team (Radar), Release-Engineering-Team (Kanban), Patch-For-Review, Scap, Regression, MediaWiki-ResourceLoader
Catrope removed projects from T222539: Scap deployments are not purging MessageBlobStore (was: Stale localized messages): Growth-Team, MediaWiki-Recent-changes.
May 7 2019, 1:27 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Performance-Team (Radar), Release-Engineering-Team (Kanban), Patch-For-Review, Scap, Regression, MediaWiki-ResourceLoader

May 6 2019

Catrope added a comment to T222539: Scap deployments are not purging MessageBlobStore (was: Stale localized messages).

As I was talking this through with @Krinkle on IRC, he pointed out that in WMF production, we only run rebuildLocalisationCache.php once, on the deployment server, and then distribute the CDB files it generates to the application servers(*). rebuildLocalisationCache.php doesn't run on each app server. Together with $wgLocalisationCacheConf['manualRecache'] = true, this means that LocalisationCache::recache() only runs once, on the deployment server, many seconds (even minutes) before any of the app servers have the new CDB files. Reverting 7f1a3bc742 will cause MessageBlobStore::clear() to be called at this time, but that's not very useful. The MBS cache will be invalidated, but then it'll just be repopulated with stale data.

May 6 2019, 11:35 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Performance-Team (Radar), Release-Engineering-Team (Kanban), Patch-For-Review, Scap, Regression, MediaWiki-ResourceLoader
Catrope added a comment to T222539: Scap deployments are not purging MessageBlobStore (was: Stale localized messages).

Since the reason that clearing the MessageBlobStore from LocalisationCache was originally disabled is now moot (MBS isn't DB-based anymore), and since MessageBlobStore::clear() is just a touchCheckKey() call nowadays, I think we can safely revert rOMWC7f1a3bc742ed: Disable MessageBlobStore::clear() via hook. I will upload a patch to do that now.

May 6 2019, 10:57 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Performance-Team (Radar), Release-Engineering-Team (Kanban), Patch-For-Review, Scap, Regression, MediaWiki-ResourceLoader
Catrope added a comment to T222539: Scap deployments are not purging MessageBlobStore (was: Stale localized messages).

It turns out MessageBlobStore's normal update mechanism for when messages change was disabled in the WMF config by rOMWC7f1a3bc742ed: Disable MessageBlobStore::clear() via hook, because of T29320: MessageBlobStore::clear() causes scaling problems on multi-server setups with CDB l10ncache. However, that bug might be moot since MessageBlobStore no longer uses the database. I think this probably broke when we stopped running LocalisationUpdate, because the only thing that appears to run refreshMessageBlobs.php (referenced in the comment in that config patch) is l10nupdate-1, which I don't believe we run anymore.

May 6 2019, 10:25 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Performance-Team (Radar), Release-Engineering-Team (Kanban), Patch-For-Review, Scap, Regression, MediaWiki-ResourceLoader
Catrope committed rEGRE3ad43838af8b: Impact: No link to pageviews tool when data is not available (--) (authored by SBisson).
Impact: No link to pageviews tool when data is not available (--)
May 6 2019, 6:24 PM
Catrope committed rEGRE589af5126b0a: Fix phan job: ignore line using JsonSerializable (authored by SBisson).
Fix phan job: ignore line using JsonSerializable
May 6 2019, 6:24 PM
Catrope added a comment to T222539: Scap deployments are not purging MessageBlobStore (was: Stale localized messages).

For some reason, this particular message has failed to update on every wiki that it's been deployed to. I'll force-update it in about half an hour, and will investigate why this happened after.

May 6 2019, 6:04 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Performance-Team (Radar), Release-Engineering-Team (Kanban), Patch-For-Review, Scap, Regression, MediaWiki-ResourceLoader

May 3 2019

Catrope created P8474 Default date+time format by language.
May 3 2019, 9:04 PM
Catrope committed rEGRE956fbbd39d99: Help panel: Only offer the email input when email address is unset (authored by Catrope).
Help panel: Only offer the email input when email address is unset
May 3 2019, 7:58 PM
Catrope committed rEGRE670ca1b85179: Homepage: Move start module subheaders to bodies, bodies to footers (authored by Catrope).
Homepage: Move start module subheaders to bodies, bodies to footers
May 3 2019, 7:13 PM

May 2 2019

Catrope committed rEGRE8fca78d19f76: Homepage: Move start module subheaders to bodies, bodies to footers (authored by Catrope).
Homepage: Move start module subheaders to bodies, bodies to footers
May 2 2019, 9:04 PM
Catrope committed rEGREf122b67a3697: Homepage: Use flexbox to align buttons in start module (authored by Catrope).
Homepage: Use flexbox to align buttons in start module
May 2 2019, 8:22 PM
Catrope committed rEGRE2c469090c201: Homepage: Move start module subheaders to bodies, bodies to footers (authored by Catrope).
Homepage: Move start module subheaders to bodies, bodies to footers
May 2 2019, 8:22 PM
Catrope committed rEGREbec717b160b7: Homepage: Use flexbox to align buttons in start module (authored by Catrope).
Homepage: Use flexbox to align buttons in start module
May 2 2019, 8:22 PM
Catrope committed rEGRE4143d78ed466: Homepage: Use flexbox to align buttons in start module (authored by Catrope).
Homepage: Use flexbox to align buttons in start module
May 2 2019, 7:59 PM

May 1 2019

Catrope committed rEGRE301f5a692629: Help panel: Only offer the email input when email address is unset (authored by Catrope).
Help panel: Only offer the email input when email address is unset
May 1 2019, 11:54 PM
Catrope committed rEGRE70a973ddb32b: Help panel: Only offer the email input when email address is unset (authored by Catrope).
Help panel: Only offer the email input when email address is unset
May 1 2019, 11:04 PM
Catrope committed rEGREc680abcd783c: Homepage: Move start module subheaders to bodies, bodies to footers (authored by Catrope).
Homepage: Move start module subheaders to bodies, bodies to footers
May 1 2019, 10:25 PM
Catrope committed rEGREe5a23c648e43: Drop RENDER_NOW flag, use thumbnail script for impact images (authored by kostajh).
Drop RENDER_NOW flag, use thumbnail script for impact images
May 1 2019, 10:25 PM