Page MenuHomePhabricator

Catrope (Roan Kattouw)
Growth team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (236 w, 5 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF) [ Global Accounts ]

Recent Activity

Today

Catrope moved T221262: Actively delete echo_event rows when they become orphaned from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Tue, Apr 23, 5:20 PM · Growth-Team (Current Sprint), Patch-For-Review, Notifications
Catrope edited projects for T221262: Actively delete echo_event rows when they become orphaned, added: Growth-Team (Current Sprint); removed Growth-Team.
Tue, Apr 23, 5:20 PM · Growth-Team (Current Sprint), Patch-For-Review, Notifications

Yesterday

Catrope moved T221261: When deleting orphaned echo_event rows, also delete echo_target_page rows that refer to them from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Mon, Apr 22, 11:04 PM · Growth-Team (Current Sprint), Patch-For-Review, Notifications
Catrope edited projects for T221261: When deleting orphaned echo_event rows, also delete echo_target_page rows that refer to them, added: Growth-Team (Current Sprint); removed Growth-Team.
Mon, Apr 22, 11:04 PM · Growth-Team (Current Sprint), Patch-For-Review, Notifications
Catrope moved T221264: Remove per-event notify-type-availability, always make it per-category from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Mon, Apr 22, 10:38 PM · Patch-For-Review, Growth-Team (Current Sprint), Notifications
Catrope moved T93612: Auto-save post boxes locally from Incoming to QA on the Growth-Team (Current Sprint) board.
Mon, Apr 22, 7:18 PM · Growth-Team (Current Sprint), User-notice, Patch-For-Review, Collaboration-Team-Triage, StructuredDiscussions
Catrope assigned T93612: Auto-save post boxes locally to Esanders.
Mon, Apr 22, 7:18 PM · Growth-Team (Current Sprint), User-notice, Patch-For-Review, Collaboration-Team-Triage, StructuredDiscussions
Catrope added a project to T93612: Auto-save post boxes locally: User-notice.
Mon, Apr 22, 7:17 PM · Growth-Team (Current Sprint), User-notice, Patch-For-Review, Collaboration-Team-Triage, StructuredDiscussions

Sat, Apr 20

Catrope committed rEGRE848bf6e0444f: Homepage: Use bidi-embedding for user names (authored by Catrope).
Homepage: Use bidi-embedding for user names
Sat, Apr 20, 12:32 AM
Catrope moved T221264: Remove per-event notify-type-availability, always make it per-category from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Sat, Apr 20, 12:14 AM · Patch-For-Review, Growth-Team (Current Sprint), Notifications
Catrope claimed T221264: Remove per-event notify-type-availability, always make it per-category.
Sat, Apr 20, 12:14 AM · Patch-For-Review, Growth-Team (Current Sprint), Notifications

Fri, Apr 19

Catrope moved T67336: EchoTalkPageFunctionalTest::testAddCommentsToTalkPage is broken from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Apr 19, 11:11 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikimedia-production-error (Shared Build Failure), Growth-Team (Current Sprint), Patch-For-Review, Technical-Debt, Notifications
Catrope moved T221260: Remove all traces of EchoUseCrossWikiBetaFeature from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Apr 19, 11:09 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Growth-Team (Current Sprint), Patch-For-Review, Notifications
Catrope moved T140710: Remove Echo transition flags from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Apr 19, 11:08 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Growth-Team (Current Sprint), Patch-For-Review, Collaboration-Team-Triage, Notifications
Catrope moved T200353: Filters: Display the time and date of the last refresh from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Apr 19, 11:06 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), User-notice, Patch-For-Review, Growth-Team (Current Sprint), Edit-Review-Improvements-Integrated-Filters

Wed, Apr 17

Catrope created T221264: Remove per-event notify-type-availability, always make it per-category.
Wed, Apr 17, 4:45 PM · Patch-For-Review, Growth-Team (Current Sprint), Notifications
Catrope updated the task description for T221261: When deleting orphaned echo_event rows, also delete echo_target_page rows that refer to them.
Wed, Apr 17, 4:40 PM · Growth-Team (Current Sprint), Patch-For-Review, Notifications
Catrope created T221262: Actively delete echo_event rows when they become orphaned.
Wed, Apr 17, 4:40 PM · Growth-Team (Current Sprint), Patch-For-Review, Notifications
Catrope created T221261: When deleting orphaned echo_event rows, also delete echo_target_page rows that refer to them.
Wed, Apr 17, 4:39 PM · Growth-Team (Current Sprint), Patch-For-Review, Notifications
Catrope created T221258: Avoid inserting echo_event rows when not needed.
Wed, Apr 17, 4:33 PM · Growth-Team, Notifications

Sat, Apr 13

Catrope committed rEGRE123784ddebd0: Fix validation errors due to state='' (authored by Catrope).
Fix validation errors due to state=''
Sat, Apr 13, 1:17 AM
Catrope reopened T219444: Disable notification emails for article-linked ("A page you created has been linked to") as "Open".

The original patch didn't work, but the new patch should.

Sat, Apr 13, 12:00 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-notice, Performance, Notifications, Growth-Team

Fri, Apr 12

Catrope added a comment to T220762: [betalabs] Stuck cross-wiki notification .

Found it! The change in 1.32.0-wmf.24 that changed the behavior was rECHOb82b54f0a6ef: Don't override checkmatrix defaults set elsewhere, which was a fix for T174220: [Spike 8 hours] Successful login notification gets sent out even when disabled in preferences. Echo was overriding the default values for all echo-subscription-web-* preferences and forcing them to true even if they were configured to be false. So the default value for this preference did change, just not in a way that was apparent from looking at the git history.

Fri, Apr 12, 11:44 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Community-Tech, Notifications, MediaWiki-extensions-LoginNotify, Growth-Team
Catrope added a comment to T174220: [Spike 8 hours] Successful login notification gets sent out even when disabled in preferences.

I found this task and its fix in the context of T220762: [betalabs] Stuck cross-wiki notification , and I have a theory for why this was so hard to reproduce: the default value of the preference was forced to true by the Echo code Max removed, but on the preferences form the checkbox for the preference was rendered as unchecked (and disabled). So if a user then submits the preferences form, the preference becomes disabled. This suggests that the bug would only have happened for users who had never changed/saved their preferences (or on wikis where they had never changed/saved their preferences).

Fri, Apr 12, 11:32 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Growth-Team, Notifications, Community-Tech-Sprint, Spike, Community-Tech, Patch-For-Review, MediaWiki-extensions-LoginNotify
Catrope added a comment to T220762: [betalabs] Stuck cross-wiki notification .

It appears that something happened in 1.32.0-wmf.24 that caused us to stop inserting these notifications:

2018-10-03 21:16 dduvall@deploy1001: rebuilt and synchronized wikiversions files: group1 wikis to 1.32.0-wmf.24
2018-10-04 19:26 dduvall@deploy1001: rebuilt and synchronized wikiversions files: all wikis to 1.32.0-wmf.24

I looked at a few large wikis, and on all of them the timestamp of the last login-success notification is right before wmf.24 was enabled on that wiki: 20181004192550 on enwiki, 20181004192150 on dewiki, 20181003210113 on commonswiki and 20181003211300 on wikidatawiki.

Fri, Apr 12, 11:21 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Community-Tech, Notifications, MediaWiki-extensions-LoginNotify, Growth-Team
Catrope added a comment to T220762: [betalabs] Stuck cross-wiki notification .

I haven't been able to reproduce this problem, or otherwise figure out how it was possible for a web notification for login-success to be inserted into the database, counted in the notification count, and then become disabled without the notification count being recomputed. In particular I found the following things:

  • Web notifications for login-success are disallowed ($wgNotifyTypeAvailabilityByCategory['login-success']['web'] is false), and have always been as far as I can tell
  • If the user's echo-subscription-web-login-success preference is enabled, a web notification will be inserted despite this category+notifyType combination being disallowed (I wrote a patch that fixes this). This sounds promising, but...
  • Subscription preferences for disallowed category-notifyType pairs (like web-login-success) are forced to false, and have always been as far as I can tell, meaning the user can't enable them
  • If the user somehow did enable this preference, that wouldn't cause this bug, because then the login-success notification would just be visible. So the preference must have become disabled again after the notification was inserted.
  • But any change in a user's settings triggers a notification count recomputation, which would have made the bug go away.
  • Maybe the default value for this preference changed? That could change the effective value of the preference without running the saveSettings hook.
  • But as far as I can tell, the default value of this preference has always been false.
Fri, Apr 12, 11:12 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Community-Tech, Notifications, MediaWiki-extensions-LoginNotify, Growth-Team
Catrope committed rELGNfd827a88a078: Disable web notifications for login-success (authored by Catrope).
Disable web notifications for login-success
Fri, Apr 12, 7:57 PM

Thu, Apr 11

Catrope updated subscribers of T220762: [betalabs] Stuck cross-wiki notification .

BTW @Niharika is it intentional that login-success notifications are not deliverable through the web (only by email), and users cannot choose for them to be web-delivered even if they want to? If it is intentional, I'd recommend this config be moved from CommonSettings.php into the extension.

Thu, Apr 11, 9:49 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Community-Tech, Notifications, MediaWiki-extensions-LoginNotify, Growth-Team
Catrope added a comment to T220762: [betalabs] Stuck cross-wiki notification .

As you say, this is a login-success notification. Web delivery is disabled for these notifications (not in LoginNotify itself, but in WMF config: rOMWC4f3bfc93b785: Config changes for LoginNotify). So it makes sense that a login-success notification that's in the database will not be rendered, and will cause problems.

Thu, Apr 11, 9:46 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Community-Tech, Notifications, MediaWiki-extensions-LoginNotify, Growth-Team
Catrope added a comment to T220762: [betalabs] Stuck cross-wiki notification .

Well, this is interesting:

Thu, Apr 11, 9:30 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Community-Tech, Notifications, MediaWiki-extensions-LoginNotify, Growth-Team
mmodell awarded T220649: Testwiki pagetriage throwing "Class undefined: ORES\ORESServices" a Mountain of Wealth token.
Thu, Apr 11, 12:47 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Scoring-platform-team (Current), MediaWiki-extensions-ORES, User-Ladsgroup, Wikimedia-production-error

Wed, Apr 10

Catrope committed rESCCd156e6c515ab: Remove call to removed MWNamespace::clearCaches() (authored by Catrope).
Remove call to removed MWNamespace::clearCaches()
Wed, Apr 10, 10:22 PM
Catrope committed rESCC08c748fd74a8: Remove call to removed MWNamespace::clearCaches() (authored by Catrope).
Remove call to removed MWNamespace::clearCaches()
Wed, Apr 10, 10:22 PM
Catrope committed rEGRE32e697071c23: Homepage: Don't make help module button bigger than the others (authored by Catrope).
Homepage: Don't make help module button bigger than the others
Wed, Apr 10, 9:23 PM
Catrope committed rEGREe95139bae35a: Homepage: Don't make help module button bigger than the others (authored by Catrope).
Homepage: Don't make help module button bigger than the others
Wed, Apr 10, 9:23 PM
Catrope added a comment to T220649: Testwiki pagetriage throwing "Class undefined: ORES\ORESServices".

Caused by rEORS94634a01aede: Move classes around so namespaces don't couple tightly to each other

Wed, Apr 10, 8:55 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Scoring-platform-team (Current), MediaWiki-extensions-ORES, User-Ladsgroup, Wikimedia-production-error
Catrope moved T219620: Wrong gender in $3 in [[MediaWiki:Flow-notification-mention-email-subject/en]] from Incoming to QA on the Growth-Team (Current Sprint) board.
Wed, Apr 10, 4:36 PM · Growth-Team (Current Sprint), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, good first bug, I18n, StructuredDiscussions

Tue, Apr 9

Catrope added a comment to T219684: BlockRestriction should be a service instead of a singleton.

Oh... it looks like it hasn't been in a released version yet... so if that's the case, no deprecation needed. :)

Tue, Apr 9, 9:11 PM · Patch-For-Review, Anti-Harassment (Heth - ח), MediaWiki-User-management, Technical-Debt
Catrope added a project to T219620: Wrong gender in $3 in [[MediaWiki:Flow-notification-mention-email-subject/en]]: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).
Tue, Apr 9, 8:34 PM · Growth-Team (Current Sprint), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, good first bug, I18n, StructuredDiscussions
Catrope committed rEGREb4107d50a8e8: Homepage: Split impact module subheader messages (authored by Catrope).
Homepage: Split impact module subheader messages
Tue, Apr 9, 12:04 AM
Catrope committed rEGRE112ba5ce4e7f: Homepage: Parse message in impact module body, and fix styling (authored by Catrope).
Homepage: Parse message in impact module body, and fix styling
Tue, Apr 9, 12:04 AM
Catrope committed rEGREa638ef754166: Homepage: More styling tweaks (authored by Catrope).
Homepage: More styling tweaks
Tue, Apr 9, 12:04 AM

Mon, Apr 8

Catrope added a comment to T220447: Split out or remove Special:Contributions/newbies functionality.

It also uses a questionable definition of "newbie": user accounts that are in the most recently-created 1% (i.e. whose user ID is greater than 0.99*highestUserID)

Mon, Apr 8, 10:11 PM · Advanced Mobile Contributions, MediaWiki-Special-pages
Catrope committed rEGRE85a59b951956: Homepage: Split impact module subheader messages (authored by Catrope).
Homepage: Split impact module subheader messages
Mon, Apr 8, 10:09 PM
Catrope committed rEGRE494fd64b083f: Homepage: Parse message in impact module body, and fix styling (authored by Catrope).
Homepage: Parse message in impact module body, and fix styling
Mon, Apr 8, 10:09 PM
Catrope moved T220436: [betalabs] HomePage: Impact module shows html markup for 0 edits from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Mon, Apr 8, 10:04 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, MediaWiki-extensions-GrowthExperiments, Growth-Team (Current Sprint)
Catrope committed rEGRE1c700e62c216: Homepage: Parse message in impact module body (authored by Catrope).
Homepage: Parse message in impact module body
Mon, Apr 8, 10:04 PM
Catrope claimed T220436: [betalabs] HomePage: Impact module shows html markup for 0 edits.
Mon, Apr 8, 9:39 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, MediaWiki-extensions-GrowthExperiments, Growth-Team (Current Sprint)
Catrope committed rEGREb745e184c9b6: Homepage: More styling tweaks (authored by Catrope).
Homepage: More styling tweaks
Mon, Apr 8, 8:21 PM
Catrope committed rEGRE0fec726b0fc1: Homepage: More styling tweaks (authored by Catrope).
Homepage: More styling tweaks
Mon, Apr 8, 7:44 PM

Sat, Apr 6

Catrope added a comment to T218966: Homepage: layout and UI details.

The patch above addresses all of these things except for the subheader thing, because I'm confused about what you want there (see inline):

Sat, Apr 6, 12:15 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Growth-Team (Current Sprint)
Catrope committed rEGRE39a4db098940: Homepage: More styling tweaks (authored by Catrope).
Homepage: More styling tweaks
Sat, Apr 6, 12:15 AM

Fri, Apr 5

Catrope committed rEGREed8f897fdad0: Homepage: Fix escaping of things passed to buildSection() (authored by Catrope).
Homepage: Fix escaping of things passed to buildSection()
Fri, Apr 5, 11:19 PM

Thu, Apr 4

Catrope added a comment to T219620: Wrong gender in $3 in [[MediaWiki:Flow-notification-mention-email-subject/en]].

It turns out email subjects are a complete disaster gender-wise, and with the notable exception of Wikidata, no notification type or extension was getting this right. The patch above fixes the issue as reported, but there's a bunch more stuff to clean up, so it won't be the last patch on this task.

Thu, Apr 4, 9:45 PM · Growth-Team (Current Sprint), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, good first bug, I18n, StructuredDiscussions
Catrope committed rELGN45bd662c262f: Demonstrate use of {{GENDER}} in email subject message (authored by Catrope).
Demonstrate use of {{GENDER}} in email subject message
Thu, Apr 4, 9:45 PM
Catrope added a comment to T219620: Wrong gender in $3 in [[MediaWiki:Flow-notification-mention-email-subject/en]].

I just tried this myself on testwiki and it turns out that the email body uses the correct gender, but the subject line is wrong:

Thu, Apr 4, 7:40 PM · Growth-Team (Current Sprint), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, good first bug, I18n, StructuredDiscussions

Wed, Apr 3

Catrope closed T219395: Homepage: get target wiki’s links to put behind the “Tutorial” button in the start module as Resolved.
Wed, Apr 3, 11:56 PM · Patch-For-Review, User-revi, MediaWiki-extensions-GrowthExperiments, Growth-Team (Current Sprint)
Catrope closed T219395: Homepage: get target wiki’s links to put behind the “Tutorial” button in the start module, a subtask of T217105: Homepage: start module, as Resolved.
Wed, Apr 3, 11:56 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, MediaWiki-extensions-GrowthExperiments, Growth-Team (Current Sprint)
Catrope closed T219395: Homepage: get target wiki’s links to put behind the “Tutorial” button in the start module, a subtask of T219419: Community Relations support for the Newcomers homepage project, as Resolved.
Wed, Apr 3, 11:55 PM · CommRel-Specialists-Support (Apr-Jun-2019), Growth-Team
Catrope closed T219588: Enable "Structured Discussion" for zh.wikisource.org as Resolved.
Wed, Apr 3, 11:54 PM · Patch-For-Review, Growth-Team (Current Sprint), Chinese-Sites, Wikimedia-Site-requests
Catrope claimed T219588: Enable "Structured Discussion" for zh.wikisource.org.
Wed, Apr 3, 10:50 PM · Patch-For-Review, Growth-Team (Current Sprint), Chinese-Sites, Wikimedia-Site-requests
Catrope committed rEGRE3dbcecdb51cb: Homepage: Use new 'invert' flag in OOUI (authored by Catrope).
Homepage: Use new 'invert' flag in OOUI
Wed, Apr 3, 9:54 PM
Catrope committed rEGREedf86d65aa82: Homepage: Use new 'invert' flag in OOUI (authored by Catrope).
Homepage: Use new 'invert' flag in OOUI
Wed, Apr 3, 9:54 PM
Catrope committed rEGRE2509dbce689b: Homepage: UI tweaks (authored by SBisson).
Homepage: UI tweaks
Wed, Apr 3, 9:54 PM
Catrope committed rEGREb2dae5e41266: Homepage: UI tweaks (authored by SBisson).
Homepage: UI tweaks
Wed, Apr 3, 9:50 PM
Catrope committed rEGRE0075e5c226ed: Homepage: Use new 'invert' flag in OOUI (authored by Catrope).
Homepage: Use new 'invert' flag in OOUI
Wed, Apr 3, 9:50 PM
Catrope committed rEGREc83dafd12df6: Homepage: UI tweaks (authored by SBisson).
Homepage: UI tweaks
Wed, Apr 3, 9:50 PM
Catrope committed rEGREca84ad5e7e66: Homepage layout and styling (authored by Catrope).
Homepage layout and styling
Wed, Apr 3, 9:50 PM
Catrope committed rEGRE8cbe0738fbd2: Homepage: UI tweaks (authored by SBisson).
Homepage: UI tweaks
Wed, Apr 3, 9:21 PM
Catrope committed rEGREd0b2e88406da: Homepage layout and styling (authored by Catrope).
Homepage layout and styling
Wed, Apr 3, 9:21 PM
Catrope committed rEGREafbd221da156: Homepage: UI tweaks (authored by SBisson).
Homepage: UI tweaks
Wed, Apr 3, 7:35 PM
Catrope committed rEGREea235e7076e6: [WIP] Homepage layout and styling (authored by Catrope).
[WIP] Homepage layout and styling
Wed, Apr 3, 7:35 PM
Catrope changed the visibility for F28565527: Screenshot from 2019-04-02 16-46-14.png.
Wed, Apr 3, 7:28 PM
Trizek-WMF awarded T219395: Homepage: get target wiki’s links to put behind the “Tutorial” button in the start module a Like token.
Wed, Apr 3, 6:43 PM · Patch-For-Review, User-revi, MediaWiki-extensions-GrowthExperiments, Growth-Team (Current Sprint)
Catrope closed T217522: Notification icon stuck showing a number but dropdown does not show any notifications as Resolved.
Wed, Apr 3, 6:02 PM · Growth-Team (Current Sprint), Notifications
Catrope committed rEGRE59f156af8ce2: Homepage: Consolidate homepage style modules (authored by Catrope).
Homepage: Consolidate homepage style modules
Wed, Apr 3, 1:45 AM

Tue, Apr 2

Catrope committed rEGRE79d6e3c17769: Homepage: Use new 'invert' flag in OOUI (authored by Catrope).
Homepage: Use new 'invert' flag in OOUI
Tue, Apr 2, 11:46 PM
Catrope committed rEGRE960036f57724: Homepage: Hack for inverting the check icon (authored by Catrope).
Homepage: Hack for inverting the check icon
Tue, Apr 2, 11:46 PM
Catrope committed rEGRE3e8054dbc0db: Homepage: Refactor icon+span structure into BaseTaskModule (authored by Catrope).
Homepage: Refactor icon+span structure into BaseTaskModule
Tue, Apr 2, 11:46 PM
Catrope committed rEGRE8900fa554bd6: [WIP] Homepage layout and styling (authored by Catrope).
[WIP] Homepage layout and styling
Tue, Apr 2, 11:41 PM
Catrope committed rEGRE1221dc4ca700: [WIP] Homepage layout and styling (authored by Catrope).
[WIP] Homepage layout and styling
Tue, Apr 2, 11:13 PM
Catrope committed rEGRE8e7c95bdd85b: Homepage: set alternating backgrounds for impact module rows (authored by Catrope).
Homepage: set alternating backgrounds for impact module rows
Tue, Apr 2, 11:05 PM
Catrope committed rEGRE343aa5d70ef0: Homepage: Fix PHP notices when pageviews data is not available (authored by Catrope).
Homepage: Fix PHP notices when pageviews data is not available
Tue, Apr 2, 10:58 PM
Catrope committed rEGREd9aab945ec56: Homepage: Fix PHP notices when pageviews data is not available (authored by Catrope).
Homepage: Fix PHP notices when pageviews data is not available
Tue, Apr 2, 10:58 PM
Catrope added a comment to T219160: Enable ORES filters for Spanish Wikiquote.

These look good to me. I'm on the fence as to whether the goodfaith likelybad level should be at precision>=0.6 or precision>=0.75 (as it is, the maybebad and likelybad levels are kind of close together), but for maintainability it might be better to stick with the defaults and let this strangeness sort itself out if/when the model is rebuilt in the future.

Tue, Apr 2, 8:55 PM · Patch-For-Review, Growth-Team (Current Sprint), Spanish-Sites, artificial-intelligence, ORES, editquality-modeling, Scoring-platform-team
Restricted Application added a project to T112872: Edit description link should be grey by default, not blue: Growth-Team.

Note that this button is defined twice, once in PHP and once in JS. See "editButton" in includes/OOUI/BoardDescriptionWidget.php and modules/flow/ui/widgets/mw.flow.ui.BoardDescriptionWidget.js respectively. Both need to have the progressive flag removed.

Tue, Apr 2, 7:29 PM · Growth-Team, good first bug, Collaboration-Team-Triage, StructuredDiscussions
Catrope added a comment to T177281: Mark redirects in RecentChanges and Watchlist.
However, now that we have tags for edits that make a page into a redirect, or change a redirect's target, or change a redirect to a non-redirect, it would be possible to look for those tags and add a redirect symbol as this task proposes.
Tue, Apr 2, 7:21 PM · good first bug, MediaWiki-Recent-changes, Growth-Team
Catrope removed projects from T34478: AbuseFilter not setting utf-8 flag: Growth-Team, Collaboration-Team-Triage.
Tue, Apr 2, 6:23 PM · Core Platform Team Kanban (Doing), User-Daimona, AbuseFilter, MediaWiki-Database
Catrope added a comment to T194453: Spaces instead of css margin/padding in new Related changes.

What's the proposed alternative? A table where each cell contains either nothing or one character?

Tue, Apr 2, 6:02 PM · Readers-Web-Backlog (Tracking), Advanced Mobile Contributions, Growth-Team, MediaWiki-Recent-changes, MediaWiki-Watchlist, UI-Standardization, CSS
Catrope changed the status of T218104: Echo tells MABot that has two pending notifications from enwiki, but then nothing is displayed from Duplicate to Resolved.
Tue, Apr 2, 5:56 PM · Growth-Team, Notifications
Catrope committed rEGREb3cc079ada97: Homepage: Use new 'invert' flag in OOUI (authored by Catrope).
Homepage: Use new 'invert' flag in OOUI
Tue, Apr 2, 4:59 PM
Catrope committed rEGRE8a2804942710: Homepage: Refactor style file organization (authored by Catrope).
Homepage: Refactor style file organization
Tue, Apr 2, 4:59 PM
Catrope committed rEGREe7f7110b7aa1: Homepage: set alternating backgrounds for impact module rows (authored by Catrope).
Homepage: set alternating backgrounds for impact module rows
Tue, Apr 2, 4:59 PM
Catrope committed rEGRE95979c1bc7f9: Homepage: Fix PHP notices when pageviews data is not available (authored by Catrope).
Homepage: Fix PHP notices when pageviews data is not available
Tue, Apr 2, 4:59 PM
Catrope committed rEGRE38dd891b9188: Homepage: Hack for inverting the check icon (authored by Catrope).
Homepage: Hack for inverting the check icon
Tue, Apr 2, 4:59 PM
Catrope committed rEGRE8384ce433fdd: Homepage: Refactor icon+span structure into BaseTaskModule (authored by Catrope).
Homepage: Refactor icon+span structure into BaseTaskModule
Tue, Apr 2, 4:59 PM

Mon, Apr 1

Catrope committed rEGRE2825d3ae3c41: [WIP] Homepage layout and styling (authored by Catrope).
[WIP] Homepage layout and styling
Mon, Apr 1, 5:31 PM
Catrope moved T219588: Enable "Structured Discussion" for zh.wikisource.org from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Mon, Apr 1, 5:28 PM · Patch-For-Review, Growth-Team (Current Sprint), Chinese-Sites, Wikimedia-Site-requests
Catrope added a project to T219588: Enable "Structured Discussion" for zh.wikisource.org: Growth-Team (Current Sprint).
Mon, Apr 1, 5:27 PM · Patch-For-Review, Growth-Team (Current Sprint), Chinese-Sites, Wikimedia-Site-requests

Fri, Mar 29

Catrope added a comment to T218966: Homepage: layout and UI details.
Page subheader > colorGray7

It turns out we're using MediaWiki's built-in page subheader feature, which uses colorGray5 instead.

Fri, Mar 29, 7:08 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Growth-Team (Current Sprint)