Catrope (Roan Kattouw)
Collaboration team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (128 w, 1 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF)

Recent Activity

Today

Catrope committed rEWPLa88317b37567: Check for TheWikipediaLibrary extension feature flag value before the callable… (authored by KavithaMuthu).
Check for TheWikipediaLibrary extension feature flag value before the callable…
Fri, Mar 24, 1:05 AM
Catrope committed rEWPL506e7a6e639a: Set feature flag for TheWikiepdiaLibrary extension (authored by KavithaMuthu).
Set feature flag for TheWikiepdiaLibrary extension
Fri, Mar 24, 12:20 AM

Yesterday

Catrope moved T161250: Good faith test does not work properly from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Thu, Mar 23, 11:14 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T161225: Wikidata RCFilters integration causes error on Recentchanges from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Thu, Mar 23, 10:20 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T161250: Good faith test does not work properly from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Thu, Mar 23, 10:14 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T161250: Good faith test does not work properly.

This is because we're extracting the thresholds incorrectly from the ORES API: the thresholds for "false" qualities need to be inverted.

Thu, Mar 23, 9:51 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T161230: Echo subscription table doesn't exist .

After discussing this with @Reception123 on IRC and poking around in the code a bit, I suddenly remembered https://gerrit.wikimedia.org/r/#/c/340129/ , which should have fixed this bug. Duped to the task that patch was tagged with.

Thu, Mar 23, 8:02 PM · Notifications, Collaboration-Team-Triage
Catrope merged T161230: Echo subscription table doesn't exist into T157651: Weird behavior of sql.php on beta.
Thu, Mar 23, 8:01 PM · Patch-For-Review, MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)), MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MediaWiki-Maintenance-scripts, Beta-Cluster-reproducible
Catrope merged task T161230: Echo subscription table doesn't exist into T157651: Weird behavior of sql.php on beta.
Thu, Mar 23, 8:01 PM · Notifications, Collaboration-Team-Triage
Catrope added a comment to T161230: Echo subscription table doesn't exist .

Interesting. Could you paste the entire error message, with any backtraces and other information that appears alongside it?

Thu, Mar 23, 6:34 PM · Notifications, Collaboration-Team-Triage
Catrope added a comment to T161230: Echo subscription table doesn't exist .

Why are you running sql.php and what are you passing to it? Is this part of the extension setup process?

Thu, Mar 23, 6:28 PM · Notifications, Collaboration-Team-Triage
Catrope added a comment to T161230: Echo subscription table doesn't exist .

When do you get this error? When running update.php? When viewing a page? When doing something else?

Thu, Mar 23, 6:26 PM · Notifications, Collaboration-Team-Triage
Catrope moved T161172: RC filters - conflicting states for highlight-only filters do not have the tooltip for Conflict state from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Thu, Mar 23, 6:07 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope closed T159888: Notification popup clippable area problem - not showing full area as "Resolved".
Thu, Mar 23, 5:22 PM · MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Notifications
Catrope moved T160803: Implement corrected Conflict State tooltips and Results Area messages from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Thu, Mar 23, 5:21 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T161172: RC filters - conflicting states for highlight-only filters do not have the tooltip for Conflict state.

So it looks like filter capsules representing highlights are red if they don't do anything because the filter selection excludes those. For example, if you select "Unregistered" and highlight "Newcomers", the latter is marked red. This makes some sense because the unregistered filter ensures there will be no newcomers in the result. But the tooltips don't explain that. We'll have to figure out what we want the behavior to be here.

Thu, Mar 23, 5:12 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T161225: Wikidata RCFilters integration causes error on Recentchanges from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Thu, Mar 23, 4:48 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope triaged T161225: Wikidata RCFilters integration causes error on Recentchanges as "Unbreak Now!" priority.
Thu, Mar 23, 4:48 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope created T161225: Wikidata RCFilters integration causes error on Recentchanges.
Thu, Mar 23, 4:48 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope claimed T158458: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" baseline.
Thu, Mar 23, 2:00 AM · Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)

Wed, Mar 22

Catrope updated subscribers of T161172: RC filters - conflicting states for highlight-only filters do not have the tooltip for Conflict state.

Ahm, why are those even red? Isn't that wrong? @Mooeypoo

Wed, Mar 22, 10:59 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T160928: Add session ID to filter usage and highlight usage data from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Wed, Mar 22, 10:12 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)
Catrope added a comment to T160928: Add session ID to filter usage and highlight usage data.

These session IDs are not available on the server, but since both the (filter) logging and the beta feature itself are only for logged-in users right now, I'll just log the user ID instead. We can then derive sessions from user IDs and gaps in timestamps.

Wed, Mar 22, 10:07 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)
Catrope moved T121644: Fail to load more topics above current topic due to pseudo-column being queried from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Wed, Mar 22, 8:56 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Wikimedia-log-errors, Flow
Catrope edited projects for T121644: Fail to load more topics above current topic due to pseudo-column being queried, added: Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017); removed Collaboration-Team-Triage.
Wed, Mar 22, 8:56 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Wikimedia-log-errors, Flow
Catrope moved T160935: Make the generic "recentchanges-noresults" message bold from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Wed, Mar 22, 7:15 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T161033: [monobook] RC filters UI needs adjustments from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Wed, Mar 22, 7:15 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T160754: Posting a message on Flow is not possible when cookies are not activated from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Wed, Mar 22, 5:19 PM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Flow
RandomDSdevel awarded T63729: Remove Flow from Meta-Wiki a Barnstar token.
Wed, Mar 22, 12:59 AM · User-notice-collaboration, Patch-For-Review, Community-Liaisons, Collaboration-Team-Triage, Flow, Wikimedia-Site-requests
Catrope added a comment to T132084: Notify editors that they are now eligible for the Wikipedia Library program.

Wasn't expecting this to happen so soon after my suggested change!

Wed, Mar 22, 12:49 AM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, User-notice-collaboration, User-notice, Notifications, The-Wikipedia-Library
Catrope added a comment to T160754: Posting a message on Flow is not possible when cookies are not activated.

It seems that disabling cookies kicks a user out of the session, so the edits will be attributed to anon. I think it's expected?

Wed, Mar 22, 12:44 AM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Flow

Tue, Mar 21

Catrope added a comment to T121644: Fail to load more topics above current topic due to pseudo-column being queried.

This appears to have been caused by rEFLW699c5d86fcea: Fix history pagination and give user the number of entries they requested which made TopKIndex explicitly not match any reverse queries. This breaks a hack whereby order-by-timestamp queries are directed to a special instance of TopKIndex that uses a special storage backend (TopicListLastUpdatedStorage instead of TopicListStorage) which knows to do the join against the workflow table. This worked in forward mode, rEFLW699c5d86fcea: Fix history pagination and give user the number of entries they requested made it so that TopKIndex never matches reverse-ordered queries, so in reverse mode the query wouldn't match any of the indexes, which would throw a NoIndexException, which then gets caught and the query falls back to using the backend storage class directly, but because that is TopicListStorage rather than TopicListLastUpdatedStorage here, it doesn't know to do the join and explodes.

Tue, Mar 21, 11:44 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Wikimedia-log-errors, Flow
Catrope added a comment to T121644: Fail to load more topics above current topic due to pseudo-column being queried.

I can reproduce this locally, it looks like it happens whenever api.php?action=flow&submodule=view-topic is invoked with vtloffset-dir=rev.

Tue, Mar 21, 10:48 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Wikimedia-log-errors, Flow
Catrope merged T161040: Unknown column 'workflow_last_update_timestamp' in 'order clause' into T121644: Fail to load more topics above current topic due to pseudo-column being queried.
Tue, Mar 21, 9:15 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Wikimedia-log-errors, Flow
Catrope merged task T161040: Unknown column 'workflow_last_update_timestamp' in 'order clause' into T121644: Fail to load more topics above current topic due to pseudo-column being queried.
Tue, Mar 21, 9:15 PM · Collaboration-Team-Triage, Wikimedia-log-errors, Flow
Catrope added a comment to T160754: Posting a message on Flow is not possible when cookies are not activated.

This happens because Flow tries to access sessionStorage, which throws an exception. The weird Storer module that Flow uses doesn't handle this correctly.

Tue, Mar 21, 6:00 PM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Flow

Mon, Mar 20

Catrope updated subscribers of T158447: ERI Metrics: Establish baseline for RC page tool usage prior to beta release.

Re the percentage idea, remember that the percentages would add up to >100% because one selection can include multiple filters.

I don't understand. The goal here is to find out how often a give tool is used in a way that's meaningful. What I'd like to know is how often it's uses as a % of "searches," but I don't know what a "search" is with our dynamic system. So that's why I suggested as a % of all filter usage. Do you have a good suggestion?

Mon, Mar 20, 11:41 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)
Catrope reassigned T159787: Add Wikidata to new RC Filters UI from Catrope to Mattflaschen-WMF.
Mon, Mar 20, 9:38 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page, Wikidata
Catrope placed T158447: ERI Metrics: Establish baseline for RC page tool usage prior to beta release up for grabs.
Mon, Mar 20, 9:37 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)
Catrope placed T158458: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" baseline up for grabs.
Mon, Mar 20, 9:36 PM · Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)
Catrope placed T160935: Make the generic "recentchanges-noresults" message bold up for grabs.
Mon, Mar 20, 9:35 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T158344: Add technology so we'll be able to track usage of RC Page highlighting from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Mon, Mar 20, 9:34 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)
Catrope added a comment to T160575: Conform ORES sensitivity levels to the new ERI standards.

that we are proposing to eliminate the "High (flags more edits)" option,

Oh, yes, sorry, we were proposing eliminating "hard", not "softest", good catch. I got confused because these preferences are named in reverse order. In that case, "hard" is the default on Wikidata and used by more than 200 users, so it's not as unused as I thought it was.

Mon, Mar 20, 6:56 PM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page, Revision-Scoring-As-A-Service, ORES
Catrope added a comment to T158458: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" baseline.

@Catrope, are you proposing to use EventLogging click-tracking, or something else? Would the click-tracking only be on the RC page, or also on other pages?

I am thinking about some possible complexities, such as Navigation popups.

Mon, Mar 20, 6:39 PM · Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)
Catrope moved T160928: Add session ID to filter usage and highlight usage data from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Mon, Mar 20, 6:27 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)
Catrope created T160928: Add session ID to filter usage and highlight usage data.
Mon, Mar 20, 6:27 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)
Catrope added a comment to T158447: ERI Metrics: Establish baseline for RC page tool usage prior to beta release.

For "Tool usage profile", we already have data on filter usage going back months, and Stephane's got a patch that adds tracking for highlight usage. Re the percentage idea, remember that the percentages would add up to >100% because one selection can include multiple filters.

Mon, Mar 20, 6:23 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017)
Catrope updated subscribers of T160575: Conform ORES sensitivity levels to the new ERI standards.

We discussed the possibility of eliminating the "lowest" preference, as well as the possibility of just pegging it to something other than maybebad. @Ladsgroup / @Halfak can you shed some light on why "lowest" was introduced and what it was calibrated to? T150224 does say fpr=0.1 but I don't know what that means.

Mon, Mar 20, 6:08 PM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page, Revision-Scoring-As-A-Service, ORES
Catrope created P5087 Usage of ORES sensitivity preference.
Mon, Mar 20, 6:05 PM · MediaWiki-extensions-ORES
Catrope added a comment to T158225: Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (instead of behind a Beta Feature).

This will happen on w/c 26 March.

Wait... It was supposed to be done by rollouts (T146972), to migrate automatically users to the New Filters for Edit Review. What did I missed?

Mon, Mar 20, 5:07 PM · User-notice, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Revision-Scoring-As-A-Service, ORES

Sat, Mar 18

Catrope committed rADESf7acbe4fd450: Fix URL of betafeatures dashboard in comment (authored by Catrope).
Fix URL of betafeatures dashboard in comment
Sat, Mar 18, 7:17 AM
Catrope added a comment to T160734: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist.

The fix for this bug is scheduled for deployment on Monday March 20 at 13:00-14:00 UTC.

Sat, Mar 18, 6:58 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Regression, MediaWiki-Watchlist
Catrope committed rADES037f3934f516: Add rcenhancedfilters beta feature (authored by Catrope).
Add rcenhancedfilters beta feature
Sat, Mar 18, 4:36 AM
Catrope added a comment to T160797: visualeditor-switch uses 50% system CPU.

The instance isn't listening on port 22 either, so I decided to just delete it.

Sat, Mar 18, 2:29 AM · User-Ryasmeen, VisualEditor
Catrope added a comment to T160803: Implement corrected Conflict State tooltips and Results Area messages.

(Re Wikidata, it might be simpler to just do T158025?)

Sat, Mar 18, 1:49 AM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T160803: Implement corrected Conflict State tooltips and Results Area messages from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Sat, Mar 18, 1:47 AM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T160803: Implement corrected Conflict State tooltips and Results Area messages.

I changed "is conflicting with" to "conflicts with" in the result area messages, because from our IRL discussion earlier today I guessed that that's what you meant and that you'd forgotten to update those. Let me know if that's not right.

Sat, Mar 18, 1:47 AM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T160575: Conform ORES sensitivity levels to the new ERI standards.

I looked at doing this, but one issue is that while "lowest" sensitity (0.90) aligns well with "verylikelybad" (0.92), and "low" sensitivity (0.70) aligns well with "likelybad" (0.75), "high" sensitivity (0.50) does not align at all well with "maybebad" (0.16), It's also a bit strange IMO that the maybebad threshold (0.16) is below the likelygood threshold (0.55).

Sat, Mar 18, 12:24 AM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page, Revision-Scoring-As-A-Service, ORES
Catrope edited projects for T159786: Update filter logging for refactoring, added: Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017); removed Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017).
Sat, Mar 18, 12:06 AM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MediaWiki-extensions-WikimediaEvents, Edit-Review-Improvements-RC-Page
Catrope changed the status of T160574: [betalabs-regression] Filters' background for selected filters always looks grey from "Invalid" to "Declined".
Sat, Mar 18, 12:05 AM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope closed T160574: [betalabs-regression] Filters' background for selected filters always looks grey as "Invalid".

According to @Jdforrester-WMF , this was changed in OOUI by @Volker_E to align with design guidelines.

Sat, Mar 18, 12:05 AM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope renamed T160575: Conform ORES sensitivity levels to the new ERI standards from "Move 'ORES Sensitivity' controls and conform levels to the new ERI standards" to "Conform ORES sensitivity levels to the new ERI standards".
Sat, Mar 18, 12:01 AM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page, Revision-Scoring-As-A-Service, ORES

Fri, Mar 17

Catrope reassigned T156427: Implement the Conflict display states and messages from Mattflaschen-WMF to Mooeypoo.
Fri, Mar 17, 11:59 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T156427: Implement the Conflict display states and messages from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Fri, Mar 17, 11:59 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T160784: [minor] Active filter display area - rows of filters do not have space between rows from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Fri, Mar 17, 11:37 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), MW-1.29-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T160213: Close small gap between top of the Dropdown Filter Panel and the bottom of the Filter Search Bar from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Fri, Mar 17, 11:37 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), MW-1.29-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T149385: Approved interface text for RC page interface elements.

@Mooeypoo, I shortened the 'What's This' texts considerably (from 70 words down to about 50). Let's see how these look in situ.

Fri, Mar 17, 7:56 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T160779: Change the text of the 'What's This?' popups from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Fri, Mar 17, 7:53 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope reassigned T160734: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist from Catrope to Mattflaschen-WMF.

We found the cause, and Matt came up with a strategy for fixing it that I like.

Fri, Mar 17, 7:44 PM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Regression, MediaWiki-Watchlist
Catrope moved T159010: Show a message on the RC page introducing the new features from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Fri, Mar 17, 5:40 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope claimed T160734: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist.

I have to go run an errand now, but when I get back (in 45-60 mins) I'll look into this.

Fri, Mar 17, 5:39 PM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Regression, MediaWiki-Watchlist
Catrope added a comment to T159186: Implement 'What's This' Links on the dropdown filter panel.

We can probably make the i18n messages wikitext messages and deliver them to the client as parsed messages in a separate object, but it would be a bit more work.

Fri, Mar 17, 5:38 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T160574: [betalabs-regression] Filters' background for selected filters always looks grey from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Fri, Mar 17, 5:46 AM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T160482: Special:RecentChangesLinked page does not have "No changes during the given period matching these criteria." from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Fri, Mar 17, 5:46 AM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T160574: [betalabs-regression] Filters' background for selected filters always looks grey.

To clarify, you are talking about the filter capsules, not the list entries, correct?

Fri, Mar 17, 5:45 AM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T159010: Show a message on the RC page introducing the new features.

Moving this back to In Dev. @SBisson, please align the Got It button to the left of its column, as in the design at top (and below). If that is hard, for some reason, then we can let it go.

That's not where that button normally is in GuidedTour dialogs, and Matt was already complaining about the (in his view) excessive overrides of GT's default style.

Fri, Mar 17, 5:44 AM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T160475: Manage ORES preferences on Watchlist (and Contributions) from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.

I think the description also misunderstands the "Hide probably good edits" preference. There are two of them, an RC one and a watchlist one.

Fri, Mar 17, 5:39 AM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Revision-Scoring-As-A-Service, ORES
Catrope moved T159763: Enable parts of ORES extension by default and manage impacts on the RC Page and the RC page Preferences tab from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Fri, Mar 17, 5:38 AM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Revision-Scoring-As-A-Service, ORES
Catrope moved T159186: Implement 'What's This' Links on the dropdown filter panel from Needs Review to Code Review Started on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Fri, Mar 17, 5:35 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T160729: Visual diffing a change to a syntaxHighlight node causes JS error.

I've also found that this happens for hieroglyph nodes too, but not for math and score nodes, even though they're also subclasses of ve.dm.MWExtensionNode. For some reason, any changes to math and score nodes are rendered in the diff as deleting the old node and inserting the new node, whereas changed to syntaxHighlight and hiero nodes are correctly detected as attribute changes.

Fri, Mar 17, 4:52 AM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), VisualEditor
Catrope created T160730: References in visual diffs are highlighted without taking superscript into account.
Fri, Mar 17, 4:42 AM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), VisualEditor
Catrope created T160729: Visual diffing a change to a syntaxHighlight node causes JS error.
Fri, Mar 17, 4:40 AM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), VisualEditor
Catrope added a comment to T160197: [Regression wmf.16] Toolbar is not floating as I scroll down in VE, Error in the console "Uncaught TypeError: Cannot read property 'center' of undefined" .

The issue seems to be that when you leave-and-reenter VE, the popup instance persists, along with its copy of $container. But the $container it's using no longer exists, because it's the destroyed-surface from the previous VE session. As such, with a removed-from-DOM-and-thrown-away element, getting its CSS direction gives us an empty-string, which causes the error we see here.

Fri, Mar 17, 12:31 AM · Verified-in-Phase2, Verified-in-Phase0, User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Verified, VisualEditor

Thu, Mar 16

Catrope moved T160493: Good faith filter group not UNIONing properly from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.

This should be fixed now, but observe that "Likely good faith" + "Maybe bad faith" = everything. This is because "Likely good faith" is defined as score> 0.234 and "Maybe bad faith" is defined as score < 0.371. Because the lower bound for "good" is below the upper bound for "maybebad", all changes are either "good" or "maybebad", and some changes are both.

Thu, Mar 16, 11:03 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T160493: Good faith filter group not UNIONing properly.

From analyzing the queries, it looks like maybebadfaith is ignored completely (probably because I renamed it from maybebad). Doing just ?goodfaith=maybebadfaith results in no WHERE clause on the score at all, whereas ?goodfaith=good,maybebadfaith and ?goodfaith=good result in the same query. This suggests maybebadfaith is ignored.

Thu, Mar 16, 10:15 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T148066: New notifs sometimes doesn't appear correctly - progress bar appears but nothing happens.

Apologies for the long delay in responding.

Thu, Mar 16, 9:46 PM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), User-Urbanecm, Notifications
Catrope added a comment to T159763: Enable parts of ORES extension by default and manage impacts on the RC Page and the RC page Preferences tab.
Thu, Mar 16, 6:02 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Revision-Scoring-As-A-Service, ORES
Catrope added a comment to T159010: Show a message on the RC page introducing the new features.

This is what it looks like with minimal styling (only to deal with the image)

And with a bit more styling

Thu, Mar 16, 1:31 AM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page

Wed, Mar 15

Catrope removed a project from T159673: Book restaurant for dinner for those who wants at Wikipedia Day: Patch-For-Review.

Change 342964 had a related patch set uploaded (by Catrope):
[mediawiki/extensions/ORES] Follow-ups to 980fb74d7: move classic highlights to watchlist

https://gerrit.wikimedia.org/r/342964

Wed, Mar 15, 11:50 PM · User-Eric_Luth_WMSE
Catrope added a comment to T132084: Notify editors that they are now eligible for the Wikipedia Library program.

We can probably simplify this task substantially by pointing users always to the new Library Card Platform, rather than the database list page in the user's language group. The platform (https://wikipedialibrary.wmflabs.org/) is the new central database list, will be available in all languages, and therefore would be the best place to link to once migration of all users (T151177) has occurred.

Wed, Mar 15, 9:00 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, User-notice-collaboration, User-notice, Notifications, The-Wikipedia-Library
Catrope added a comment to T159763: Enable parts of ORES extension by default and manage impacts on the RC Page and the RC page Preferences tab.

@SBisson, good info. Thanks. Two questions;

  • Where does the "r" threshold fall now?

That depends on your sensitivity setting.

Wed, Mar 15, 5:13 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Revision-Scoring-As-A-Service, ORES

Tue, Mar 14

Catrope added a comment to T116417: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover.

Right, I forgot that it was already uploaded. I'll review it soon.

Tue, Mar 14, 9:53 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), User-Ryasmeen, User-notice-collaboration, User-notice, VisualEditor-MediaWiki-2017WikitextEditor, UI-Standardization, VisualEditor, Flow, Collaboration-Team-Triage, Design
Catrope added a comment to T159763: Enable parts of ORES extension by default and manage impacts on the RC Page and the RC page Preferences tab.
  1. So, if we want to offer classic ORES on RC page, we'd have to create a new preference on the RC page, And that new preference would be in conflict with the RC Page beta, on the beta page—since you can't have both.

If you're saying that we don't want to offer the highlighting part of classic ORES on the RC page, that seems fine to me, as it's redundant with RCFilters. However, I think we should still keep the newly-default parts of the classic ORES interface on the RC page. That also wouldn't require anything weird preference-wise, because that stuff isn't triggered by preferences.

Tue, Mar 14, 9:43 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Revision-Scoring-As-A-Service, ORES
Catrope edited the description of T159763: Enable parts of ORES extension by default and manage impacts on the RC Page and the RC page Preferences tab.
Tue, Mar 14, 6:24 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Revision-Scoring-As-A-Service, ORES
Catrope moved T150059: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Tue, Mar 14, 6:01 PM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T149385: Approved interface text for RC page interface elements from QA Review to In Development on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Tue, Mar 14, 6:01 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T149385: Approved interface text for RC page interface elements from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Tue, Mar 14, 6:01 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope moved T152754: Configure filters in a single extensible place from Code Review Started to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Tue, Mar 14, 5:59 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page
Catrope claimed T159787: Add Wikidata to new RC Filters UI.
Tue, Mar 14, 5:58 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page, Wikidata
Catrope moved T159787: Add Wikidata to new RC Filters UI from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Tue, Mar 14, 5:58 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Edit-Review-Improvements-RC-Page, Wikidata