Page MenuHomePhabricator

Catrope (Roan Kattouw)
Growth team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (315 w, 5 h)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Catrope moved T266033: SE intro overlay - labels length and text positioning from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 21, 10:40 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T266033: SE intro overlay - labels length and text positioning.

Change 635639 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Work around CSSJanus flipping bug

https://gerrit.wikimedia.org/r/635639

Wed, Oct 21, 8:54 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope claimed T266033: SE intro overlay - labels length and text positioning.
Wed, Oct 21, 8:46 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258016: Variant C: onboarding.

I'm being a bit silly here: I just removed variant A, so it doesn't make sense for me to complain that something doesn't look good in it. I've also added the 16px bottom padding so it looks better:

Wed, Oct 21, 7:53 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Tue, Oct 20

Catrope moved T265754: Variant C/D: inconsistencies with welcome survey and discovery popups from In Progress to QA on the Growth-Team (Current Sprint) board.
Tue, Oct 20, 12:44 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Growth-Team-Leftovers, GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint)

Mon, Oct 19

Catrope claimed T265751: Variant C/D: autoscroll on Variant D.

I was able to reproduce this by making my window short enough that the bottom of the suggested edits onboarding was out of view. I tracked down the issue by running $(window).on( 'scroll', function () { debugger; } ); during load and inspecting the call stack. It turns out that OO.ui.Window.prototype.ready calls this.$content.trigger( 'focus' k), which causes Chrome (but not Firefox) to scroll down so that it's centered.

Mon, Oct 19, 10:49 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team-Leftovers, Growth-Team (Current Sprint), NewcomerTasks Future Release
Catrope moved T243445: Deploy Growth features on Turkish Wikipedia from Needs More Work to QA on the Growth-Team (Current Sprint) board.

This is live now! I apologize for the delays and the postponement. Other deployments were postponed/canceled and we had to wait for those.

Mon, Oct 19, 6:36 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites
Catrope moved T265556: Variant tests: roll out variant C/D from Code Review to Needs More Work on the Growth-Team (Current Sprint) board.

Stage 1 is done, the patch for stage 2 has passed code review, so now we just need to wait for Oct 26 and deploy stage 2 then.

Mon, Oct 19, 6:35 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Sat, Oct 17

Catrope added a comment to T258017: Variant D: difficulty overlay in onboarding.

Change 634755 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Make image in difficulty banner top aligned, fix padding

https://gerrit.wikimedia.org/r/634755

Sat, Oct 17, 10:03 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258016: Variant C: onboarding.

While working on the big 24px->16px change mentioned in T258019#6557184, I noticed that the text in the difficulty banner in the variant C onboarding dialog was vertically centered on desktop, but should instead be top-aligned according to the mocks. The attached patch fixes that in both variant A and variant C.

Sat, Oct 17, 10:02 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258019: Variant D (desktop): embed onboarding dialog into suggested edits module.

Desktop issues:

Left and right padding in the desktop module intro topic area should only be 16px (not 24px)

Kosta's patch fixed this

Sat, Oct 17, 3:35 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Fri, Oct 16

Catrope moved T258016: Variant C: onboarding from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.
Fri, Oct 16, 8:10 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258016: Variant C: onboarding.

Looking at var C only per this task, some items still to be fixed (or were maybe reverted at some point?):

All these screenshots are from variant A though (as you can tell by the presence of the start module in the background, and the topic filters below the intro section.

Fri, Oct 16, 8:08 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T258017: Variant D: difficulty overlay in onboarding from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.

a. Similar to comment on T258019#6510238 - please make the Desktop left and right padding 16px for the module

This is fixed now, with Kosta's patch for that issue.

Fri, Oct 16, 1:06 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop.

(ii) This also means updating the total card width according, done by adjusting the class .suggested-edits-task-card-wrapper to have a width:332px.

Done, on desktop. But what should happen on mobile? Currently mobile uses 260x128 for the image dimensions, should that change to something else?

No, we are keeping mobile as is (since we haven't made the same layout changes to mobile where there is just the SE module).

Great, that makes it easy.

Fri, Oct 16, 12:34 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments

Thu, Oct 15

Catrope moved T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop from In Progress to Code Review on the Growth-Team (Current Sprint) board.

Change 634138 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Change image size, styling tweaks

https://gerrit.wikimedia.org/r/634138

Thu, Oct 15, 2:29 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments

Wed, Oct 14

Catrope moved T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.

Change 634127 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Fix header icon size and padding

https://gerrit.wikimedia.org/r/634127

Wed, Oct 14, 11:55 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
Catrope claimed T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop.
Wed, Oct 14, 11:54 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
Catrope set Due Date to Mon, Oct 19, 6:00 PM on T265556: Variant tests: roll out variant C/D.
Wed, Oct 14, 11:08 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope created T265556: Variant tests: roll out variant C/D.
Wed, Oct 14, 11:05 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T258021: Variant C/D: mobile preview for suggested edits module with first suggested edit from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 14, 10:18 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T264314: Task preview data incorrectly set when user uses non-default task/topic selections from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 14, 10:18 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks

Tue, Oct 13

Catrope added a comment to T265214: Change Growth features parameters on Portuguese Wikipedia.

I ended up reaching @Albertoleoncio on IRC, and we successfully moved the help desk together.

Tue, Oct 13, 11:24 PM · Wikimedia-Site-requests, Growth-Team
Catrope added a comment to T265214: Change Growth features parameters on Portuguese Wikipedia.

Setting it to 100% is possible, but having 20% of new users not get the homepage is deliberate, so as to create a control group for the experiment.

Oh, OK. Sorry for the confusion. I had seen that euwiki was set to 100 and I had assumed it was sort of customizable. So, I don't see a problem with staying at 80%, but is there a plan of how long the tests will stay? After that, the number could be raise to 100%.

I'll leave this to @Trizek-WMF to answer.

Tue, Oct 13, 10:53 PM · Wikimedia-Site-requests, Growth-Team
Catrope added a comment to T265422: Help panel does not show progress indicator when posting a question.

We should have something, like a pending indication on the "Post" button or on the header of the dialog (the latter would be the default, but we disabled it because it flashed pending states when navigating between panels).

My patch originally did the former, but after talking to @RHo , I changed it to do the latter.

Tue, Oct 13, 10:42 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments-Help panel
Catrope updated subscribers of T265422: Help panel does not show progress indicator when posting a question.
Tue, Oct 13, 10:32 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments-Help panel
Catrope created T265422: Help panel does not show progress indicator when posting a question.
Tue, Oct 13, 10:32 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments-Help panel
Catrope added a comment to T265214: Change Growth features parameters on Portuguese Wikipedia.

Related task: T265404: Redirects should be followed when posting to help desk

Tue, Oct 13, 8:02 PM · Wikimedia-Site-requests, Growth-Team
Catrope created T265404: Redirects should be followed when posting to help desk.
Tue, Oct 13, 8:01 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team-Leftovers, Growth-Team (Current Sprint)
Catrope updated subscribers of T265214: Change Growth features parameters on Portuguese Wikipedia.

would it be possible to increase the wgGEHelpPanelHelpDeskTitle for ptwiki to 100%?

Tue, Oct 13, 7:55 PM · Wikimedia-Site-requests, Growth-Team
Catrope changed Due Date from Tue, Oct 13, 6:00 PM to Mon, Oct 19, 6:00 PM on T243445: Deploy Growth features on Turkish Wikipedia.
Tue, Oct 13, 7:35 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites
Catrope added a comment to T243445: Deploy Growth features on Turkish Wikipedia.

Because the deployment train was delayed, we had to postpone this deployment to October 19th. I apologize for the inconvenience.

Tue, Oct 13, 7:35 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites

Sat, Oct 10

Catrope moved T258008: Variant C/D: smaller start module from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.
Sat, Oct 10, 2:31 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258008: Variant C/D: smaller start module.
  • Icon larger than expected (should be 20x20px)

It was 20x20 on desktop, and larger on mobile proportional to the base font size. I've fixed it to be 20x20 on both.

Sat, Oct 10, 2:31 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Fri, Oct 9

Catrope merged T265186: Bolding an inline template deletes it and inserts snowmen into T263607: Content nodes are lost when bolded in VE .
Fri, Oct 9, 11:58 PM · Verified, Regression, MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Editing-team (FY2020-21 Kanban Board), VisualEditor, OWC2020 (Reply Tool Opt Out), DiscussionTools
Catrope merged task T265186: Bolding an inline template deletes it and inserts snowmen into T263607: Content nodes are lost when bolded in VE .
Fri, Oct 9, 11:58 PM · VisualEditor
Catrope updated the task description for T265186: Bolding an inline template deletes it and inserts snowmen.
Fri, Oct 9, 11:54 PM · VisualEditor
Catrope created T265186: Bolding an inline template deletes it and inserts snowmen.
Fri, Oct 9, 11:51 PM · VisualEditor

Thu, Oct 8

Catrope moved T258019: Variant D (desktop): embed onboarding dialog into suggested edits module from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.

(1) I did not see any changes made to address this comment - https://phabricator.wikimedia.org/T258019#6510238. Moving to Needs More Work .

Fixed in the attached patch.

Thu, Oct 8, 2:57 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T258704: Variant C/D: homepage Suggested edits module changes - Desktop from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.
Thu, Oct 8, 2:20 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Wed, Oct 7

Catrope moved T258016: Variant C: onboarding from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.
Wed, Oct 7, 6:11 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258016: Variant C: onboarding.
  • The Suggested edits image should only be 64x64px:

This has already been fixed since your comment.

Wed, Oct 7, 6:10 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Tue, Oct 6

Catrope set Due Date to Tue, Oct 13, 6:00 PM on T243445: Deploy Growth features on Turkish Wikipedia.
Tue, Oct 6, 4:02 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites
Catrope added a comment to T243445: Deploy Growth features on Turkish Wikipedia.

Thanks @Evrifaessa! Sorry for the late response.

Tue, Oct 6, 4:01 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites

Mon, Oct 5

Catrope moved T262485: Variant C/D: instrumentation from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Oct 5, 5:46 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T258020: Variant C: Info icon in suggested edits module from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Oct 5, 5:45 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Fri, Oct 2

Catrope moved T258023: Variant C: pre-initiate suggested edits module on account creation from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.
Fri, Oct 2, 11:30 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258023: Variant C: pre-initiate suggested edits module on account creation.

The pulsating blue dot on the topic filter button is broken in all variants (not just C/D, but A as well). It looks like it was broken by this refactoring change, which was merged in early May.

Fri, Oct 2, 11:29 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258019: Variant D (desktop): embed onboarding dialog into suggested edits module.

@Catrope -- I noticed a requirement that was missed here, about two messages that need to be changed/added. This applies to mobile, too. They are the personalized messages based on welcome survey response. Basically, these new messages excise the part that tells the user to cancel out of the dialog before searching and clicking edit, because you can't cancel out of Variant D onboarding.

Well spotted, sorry for missing this.

Fri, Oct 2, 10:49 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258005: Variant C/D: homepage layout changes.

I believe this is item E on T258704 (footer should be flush to bottom and sides of SE module).

Fri, Oct 2, 10:06 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T254704: Remove Revision::newFromId.

Change 631564 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Fix footer display

https://gerrit.wikimedia.org/r/631564

Fri, Oct 2, 8:31 PM · MediaWiki-Revision-backend, Technical-Debt (Deprecation process), User-DannyS712
Catrope moved T258005: Variant C/D: homepage layout changes from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.

Moving to Code Review because I couldn't reproduce the autoscrolling issue; please move back to Needs More Work if someone other than Marshall can reproduce it.

Fri, Oct 2, 4:20 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258005: Variant C/D: homepage layout changes.

@Catrope @kostajh -- I just finished testing both Variants C and D on desktop in beta, and I have these issues:

  • When I first visit the homepage in Variant D, I am autoscrolled down the page to this view. This happened to me for all three accounts I created:

I could not reproduce this issue, neither in Firefox nor in Chrome.

Fri, Oct 2, 3:10 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T264087: Variant C/D: clicking content of task preview doesn't open suggested edits from QA to Ready for Development on the Growth-Team (Current Sprint) board.
Fri, Oct 2, 2:52 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint)
Catrope moved T264087: Variant C/D: clicking content of task preview doesn't open suggested edits from Ready for Development to QA on the Growth-Team (Current Sprint) board.
Fri, Oct 2, 2:52 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint)
Catrope claimed T264374: Variant C/D: convert legacy users to Variant D (and make it the default).
Fri, Oct 2, 2:41 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint)

Thu, Oct 1

Catrope updated subscribers of T264334: Could the registered module manifest be removed from the client?.

Hmm, that's an interesting idea. I'll mull it over and discuss it with @Krinkle. It's probably worth measuring how often such a global version string would change, compared to any individual module's version (for example, some modules are backed by wiki pages that admins can edit, so those can change more often than just the weekly deployment). We may be able to tackle that by excluding wiki page-based modules from the global version (and version them individually instead), or by having a "default version" that applies to most modules except those changed after the initial deployment.

Thu, Oct 1, 11:02 PM · Performance-Team, MediaWiki-ResourceLoader, Platform Engineering
Catrope added a comment to T264374: Variant C/D: convert legacy users to Variant D (and make it the default).

We shouldn't do this ahead of time though, only when we're ready.

Thu, Oct 1, 10:55 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint)
Catrope added a comment to T264374: Variant C/D: convert legacy users to Variant D (and make it the default).

I believe all these requirements will be satisfied because of our existing reuse of preferences for the welcome popups and suggested edits activation.

Thu, Oct 1, 10:54 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint)
Catrope added a comment to T264334: Could the registered module manifest be removed from the client?.

The reason the client has to have the module registry is because of our caching strategy. It needs the version hashes of each module in order to be able to compute the correct URL when requesting modules.

Thu, Oct 1, 10:38 PM · Performance-Team, MediaWiki-ResourceLoader, Platform Engineering
Teles awarded T255027: Deploy Growth features on Portuguese Wikipedia a Yellow Medal token.
Thu, Oct 1, 1:43 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Growth-Team (Current Sprint)
Catrope added a comment to T258017: Variant D: difficulty overlay in onboarding.

I believe that is correct, @RHo said that verbatim here:

Thu, Oct 1, 12:31 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments

Wed, Sep 30

Catrope moved T255027: Deploy Growth features on Portuguese Wikipedia from Ready for Development to QA on the Growth-Team (Current Sprint) board.
Wed, Sep 30, 8:26 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Growth-Team (Current Sprint)
Catrope moved T257220: Deploy Growth features on Swedish Wikipedia from Needs More Work to QA on the Growth-Team (Current Sprint) board.
Wed, Sep 30, 8:25 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.9; 2020-09-15)
Catrope moved T243445: Deploy Growth features on Turkish Wikipedia from Needs PM Review to Needs More Work on the Growth-Team (Current Sprint) board.
Wed, Sep 30, 8:25 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites
Catrope moved T243445: Deploy Growth features on Turkish Wikipedia from Ready for Development to Needs PM Review on the Growth-Team (Current Sprint) board.
Wed, Sep 30, 8:25 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites
Catrope added a comment to T243445: Deploy Growth features on Turkish Wikipedia.

Also, please check my work at https://tr.wikipedia.org/wiki/MediaWiki:NewcomerTasks.json . Did I put in the right templates and help pages for the right task types? If anything needs to be changed, tell me, or edit the page yourself (only administrators can edit it).

Wed, Sep 30, 8:19 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites
Catrope added a comment to T243445: Deploy Growth features on Turkish Wikipedia.

@Evrifaessa what should the labels for the help panel links be? For now, I've used the page names as labels, but that doesn't always work well. The links would be displayed in the help panel like this:

Please let me know what I should change these labels to (some of them may be right, but some others probably need to be changed)

Wed, Sep 30, 8:04 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites

Tue, Sep 29

Catrope moved T258008: Variant C/D: smaller start module from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.
Tue, Sep 29, 11:01 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T263071: Suggested edits arrows spill out of the suggested edits box at some viewport widths.

Unfortunately, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/630706 is about to bring this issue back

Tue, Sep 29, 10:21 PM · GrowthExperiments-Homepage
Catrope moved T258019: Variant D (desktop): embed onboarding dialog into suggested edits module from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.

The patch above sets the height of the onboarding panel to (approximately, within a few pixels) the height that the suggested edits module will be when it activates, and makes the contents scrollable. It also tightens up the padding on the footer, per the Zeplin mock (it was inheriting the much more spacious padding from the dialog).

Tue, Sep 29, 6:06 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope changed Due Date from Sep 21 2020, 6:00 PM to Wed, Sep 30, 6:00 PM on T255027: Deploy Growth features on Portuguese Wikipedia.
Tue, Sep 29, 3:39 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Growth-Team (Current Sprint)
Catrope added a comment to T255027: Deploy Growth features on Portuguese Wikipedia.

Roan, can you change the configuration so that newcomers get the tools? Thanks!

Tue, Sep 29, 3:39 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Growth-Team (Current Sprint)
Catrope moved T258017: Variant D: difficulty overlay in onboarding from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Sep 29, 2:09 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258017: Variant D: difficulty overlay in onboarding.

hi @Catrope - thanks for your attention to detail on some of these discrepancies. Per my comment on this patch, I messed up font stylings in a few places which was causing inconsistent font-size mappings from Desktop to Mobile. I've now updated the Zeplin mocks to correct this, along with the colour differences across Mobile/Desktop and the variants. Detailed revisions are as follows:

1. Header text for overlays ("Suggested edits to get started" and "Try some...") should use the OOUI fieldset header text style, which on Desktop is 16px (per current), and on Mobile is ~18.28px.
This font-size applies to the case for Variant D on the "Try some easy suggested edits only" header in font-size.

[...]

2. Intro text ("Wikipedia is built collab..." and "There are many ways...") should use the OOUI UI text style, which on Desktop is 14px, and on Mobile is 16px. Accordingly, I think there is no amazing reason for the different colours across variants, so let's make all of them Base10.

I have addressed these points by amending the patch you referred to.

Tue, Sep 29, 3:55 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments

Mon, Sep 28

Catrope moved T258010: Variant C/D: welcome peek drawer on mobile from Design Review to QA on the Growth-Team (Current Sprint) board.
Mon, Sep 28, 7:46 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T258022: Variant D: mobile preview for suggested edits module with call to action from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Sep 28, 6:13 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Growth-Team (Current Sprint), GrowthExperiments
Catrope changed Due Date from Tue, Sep 29, 6:00 PM to Wed, Sep 30, 6:00 PM on T257220: Deploy Growth features on Swedish Wikipedia.
Mon, Sep 28, 6:07 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.9; 2020-09-15)
Catrope added a comment to T257220: Deploy Growth features on Swedish Wikipedia.

Sorry, make that Wednesday instead.

Mon, Sep 28, 6:07 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.9; 2020-09-15)
Catrope set Due Date to Tue, Sep 29, 6:00 PM on T257220: Deploy Growth features on Swedish Wikipedia.
Mon, Sep 28, 6:05 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.9; 2020-09-15)
Catrope added a comment to T257220: Deploy Growth features on Swedish Wikipedia.

Thanks! With that information, I'm now ready to deploy this. I'll schedule this for tomorrow at 18:00-19:00 UTC, but if you need more time, let me know by commenting on this task and I'll postpone it.

Mon, Sep 28, 6:04 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.9; 2020-09-15)

Fri, Sep 25

Catrope added a comment to T258017: Variant D: difficulty overlay in onboarding.

First, in variant A, and in the variant C mocks, the text color of the "There are many ways you can contribute..." subheader is lighter (base20) and smaller (14.8px) than that of the "Try some easy suggested edits first" header above it (base10, 16px). In the variant D mock, they're the same color and font size (both base10, 14px). Is that intended? Should these color and font size changes only apply in variant D? Or should they apply in all variants, or in none of them? (Any of these answers is easy to implement, I just want to know.)

And to close this loop: my patches up for review assume that these color and font size changes should be specific to variant D.

Fri, Sep 25, 5:47 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258017: Variant D: difficulty overlay in onboarding.

Second, the styling of the "task type selector" (the Easy, Medium and Hard headers, the checkboxes, and their labels) in this mock is pretty different between desktop and mobile:

  • The headers are colored on mobile, but not on desktop
  • The subheaders are bolded on mobile, but not on desktop
  • The font sizes are generally larger on mobile (18px/16px vs 16px/14px)
  • The subheaders have a smaller font size (14.8px) than the checkbox labels (16px) on mobile, but the same font size on desktop (14px)
  • The vertical separation between the three sections is larger on mobile (24px) than on desktop (16px), even as a proportion of the font size of the header (1.333em vs 1em)

Are these differences intentional? Should these changes also be applied to the task type selector that appears when you click the "Easy tasks" button in the (activated) suggested edits module to change your task type selections later? If so, should those changes apply in variants A and C as well? (Applying these changes only to variant D or only to one of the occurrences of the task type selector would be doable, but a bit annoying, so I'd prefer to apply them universally.)

Fri, Sep 25, 5:37 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments

Thu, Sep 24

Catrope added a comment to T258019: Variant D (desktop): embed onboarding dialog into suggested edits module.

Code review from @kostajh led to a question for @RHo: should the embedded onboarding dialog keep the same height when moving between steps, like it does when it's a "real dialog"? The mockups suggest that it should, because the height is identical in the step 1 and step 2 mockups. But these are also misleading / not to scale: the step 1 mockup depicts 3 topic categories, but there are really 4, so step 1 is much taller than depicted. In practice, the height difference between step 1 (1067px) and step 2 (736px) is 331px, whereas the mockups show a consistent height of 748px and an implied height difference (if step 2 was shrunk to fit) of only 32px. Adding 300+ px of blank space to the bottom of step 2 seems like a lot, so I thought I should check first before I did that.

Thu, Sep 24, 7:38 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T258019: Variant D (desktop): embed onboarding dialog into suggested edits module from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Sep 24, 5:56 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Wed, Sep 23

Catrope added a comment to T263071: Suggested edits arrows spill out of the suggested edits box at some viewport widths.

This actually appears to have been fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/629375

Wed, Sep 23, 5:49 PM · GrowthExperiments-Homepage
Catrope created T263610: Don't build homepage / help panel windows on page load.
Wed, Sep 23, 2:29 AM · Growth-Team (Current Sprint), GrowthExperiments, Technical-Debt, Growth-Team-Leftovers
Catrope added a project to T263609: Reuse dialog and WindowManager for StartEditingDialog: Technical-Debt.
Wed, Sep 23, 2:28 AM · Growth-Team (Current Sprint), Technical-Debt, GrowthExperiments-Homepage, Growth-Team-Leftovers
Catrope created T263609: Reuse dialog and WindowManager for StartEditingDialog.
Wed, Sep 23, 2:21 AM · Growth-Team (Current Sprint), Technical-Debt, GrowthExperiments-Homepage, Growth-Team-Leftovers
Catrope added a comment to T258016: Variant C: onboarding.

Hi @Catrope - Can we continue to vary based on WelcomeSurvey responses for this onboarding, BUT when a user clicks on the "?" icon in the initiated module header, we always show the single general icon and text for everyone?

@MMiller_WMF to confirm but I am asking on the assumption we would want the same customized onboarding for var C & D, and at the same time not have the help "?" in the SE module header be customized (since a user may not look at that message until much later)

Wed, Sep 23, 2:16 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Catrope created T263608: Variant C: don't personalize onboarding dialog when accessed from info icon.
Wed, Sep 23, 2:16 AM · Growth-Team (Current Sprint), GrowthExperiments, Growth-Team-Leftovers

Tue, Sep 22

Catrope moved T258022: Variant D: mobile preview for suggested edits module with call to action from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Sep 22, 10:43 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T255027: Deploy Growth features on Portuguese Wikipedia.

Sorry for not providing better instructions for testing the welcome survey earlier. I knew this would be an issue, and made a mental note to post instructions for it, but I forgot.

Tue, Sep 22, 7:01 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Growth-Team (Current Sprint)
Catrope moved T258017: Variant D: difficulty overlay in onboarding from In Progress to Code Review on the Growth-Team (Current Sprint) board.

This is working and ready for review, except for the styling tweaks that I asked Rita about above.

Tue, Sep 22, 7:09 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Catrope added a comment to T258017: Variant D: difficulty overlay in onboarding.

Some additional styling questions for @RHo:

Tue, Sep 22, 7:08 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments

Sep 21 2020

Catrope moved T260758: Cache newcomer tasks per user from Code Review to QA on the Growth-Team (Current Sprint) board.
Sep 21 2020, 11:33 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks, GrowthExperiments-Homepage
Catrope moved T254239: Deploy Growth features on Polish Wikipedia from Needs More Work to QA on the Growth-Team (Current Sprint) board.
Sep 21 2020, 7:07 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Growth-Team (Current Sprint)
Catrope moved T255027: Deploy Growth features on Portuguese Wikipedia from In Progress to QA on the Growth-Team (Current Sprint) board.
Sep 21 2020, 7:07 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Growth-Team (Current Sprint)
Catrope added a comment to T261411: Add a link engineering: Determine format for accessing and storing link recommendations.

Yeah, I don't think external store would be the place to store this.
But again, as mentioned earlier, if this can be considered volatile, I am not sure MySQL is the right place to keep this as a "second cache". But even if it is, what would you have in mind? wikishared on x1?

I don't know enough about this. Where could I read about wikishared (I don't see any obvious looking documentation pages on wikitech)? The link recommendation data is local to each language wiki; whether there are advantages to using wikishared versus the local wiki's DB is unclear to me. Do you have advice here?

Sep 21 2020, 5:52 PM · Data-Persistence, DBA, Growth-Structured-Tasks, Growth-Team
Catrope updated subscribers of T263071: Suggested edits arrows spill out of the suggested edits box at some viewport widths.

@MMiller_WMF Could you decide the prioritization for this task please? It should probably go in either the current sprint or in Growth-Team-Leftovers

Sep 21 2020, 7:47 AM · GrowthExperiments-Homepage