Catrope (Roan Kattouw)
Collaboration team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (163 w, 22 h)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF)

Recent Activity

Today

RandomDSdevel awarded T174374: Use a mixed storage format, setting the system to slowly migrate over from HTML to wikitext storage (quarterly goal) a Mountain of Wealth token.
Thu, Nov 23, 12:30 AM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions

Yesterday

Catrope added a comment to T180689: Section link/anchor included in Notifications doesn't work due to ".C2.A0" instead of "_".

Turns out it's my fault: rECHO6eea6d93a137: Used parsed section titles for anchors

Wed, Nov 22, 7:20 PM · Patch-For-Review, Collaboration-Team-Triage, Notifications
Catrope added a comment to T180689: Section link/anchor included in Notifications doesn't work due to ".C2.A0" instead of "_".

This seems to be a regression kind of caused by rMW129067c907ea: Remove nbsp and similar characters from section IDs, in the sense that that commit changes the way the parser builds section IDs and we are mimicking but not using that in Echo (not sure why).

Wed, Nov 22, 6:49 PM · Patch-For-Review, Collaboration-Team-Triage, Notifications
Catrope moved T180607: Nuke does not list hidden Flow topics from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Wed, Nov 22, 5:29 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Patch-For-Review, StructuredDiscussions, MediaWiki-extensions-Nuke
Catrope edited projects for T180607: Nuke does not list hidden Flow topics, added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Wed, Nov 22, 5:29 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Patch-For-Review, StructuredDiscussions, MediaWiki-extensions-Nuke

Tue, Nov 21

Catrope added a project to T181100: [wmf.8 - regression] Related changes: Saved filters set as default won't include the page as part of a query: Edit-Review-Improvements-RC-Page.
Tue, Nov 21, 10:09 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Regression, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Catrope renamed T179765: Can't dismiss failed login attempt notification (or other notifications from login.wikimedia.org) from Failed login attempt notification won't disappear to Can't dismiss failed login attempt notification (or other notifications from login.wikimedia.org).
Tue, Nov 21, 7:30 PM · MediaWiki-extensions-LoginNotify, Notifications, Collaboration-Team-Triage
Catrope merged T180988: Can't dismiss the notice I got on login.wikimedia.org into T179765: Can't dismiss failed login attempt notification (or other notifications from login.wikimedia.org).
Tue, Nov 21, 7:30 PM · MediaWiki-extensions-LoginNotify, Notifications, Collaboration-Team-Triage
Catrope merged task T180988: Can't dismiss the notice I got on login.wikimedia.org into T179765: Can't dismiss failed login attempt notification (or other notifications from login.wikimedia.org).
Tue, Nov 21, 7:30 PM · Collaboration-Team-Triage, Notifications
Catrope added a comment to T180185: FlowMention template makes impossible to type in the same line.

On which wiki does this happen?

Tue, Nov 21, 7:17 PM · VisualEditor, StructuredDiscussions, Collaboration-Team-Triage
Catrope added a comment to T180689: Section link/anchor included in Notifications doesn't work due to ".C2.A0" instead of "_".

Looks like we are not correctly normalizing whitespace here? .C2.A0 is the encoding for a non-breaking space, but the other code seems to normalize that to a space. Ideally we'd use the same code for generating section anchors that's used everywhere else, but I'm not sure if that's exposed.

Tue, Nov 21, 6:59 PM · Patch-For-Review, Collaboration-Team-Triage, Notifications
Catrope updated subscribers of T175225: Add a 'Learners' (autoconfirmed) filter to New Pages Feed and rename the existing 'new editors' filter.

@kaldari Could you review this patch maybe?

Tue, Nov 21, 6:36 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-extensions-PageCuration
Catrope added a comment to T181015: ORES extension should not modify $wgHiddenPrefs at runtime.

In T181015#3778532, @Legoktm wrote:

It might? I'm not sure tbh. ...

@Petar.petkovic, will it?

Tue, Nov 21, 6:06 PM · Edit-Review-Improvements-Integrated-Filters, Technical-Debt, Scoring-platform-team, Collaboration-Team-Triage, MediaWiki-extensions-ORES
Catrope added a comment to T181015: ORES extension should not modify $wgHiddenPrefs at runtime.

It would be great if there was. We tried to find a better way of doing this when doing a similar thing in core(!), but couldn't really figure anything out there either: https://gerrit.wikimedia.org/r/#/c/388264/13..14/includes/Preferences.php

Tue, Nov 21, 1:15 AM · Edit-Review-Improvements-Integrated-Filters, Technical-Debt, Scoring-platform-team, Collaboration-Team-Triage, MediaWiki-extensions-ORES
Catrope added a comment to T179765: Can't dismiss failed login attempt notification (or other notifications from login.wikimedia.org).

Probably. Do either of you have Privacy Badger, AdBlock or a similar plugin enabled? If so, does (temporarily) disabling such plugins fix it?

Tue, Nov 21, 12:15 AM · MediaWiki-extensions-LoginNotify, Notifications, Collaboration-Team-Triage

Mon, Nov 20

Catrope added a comment to T181006: Watchlist and RecentChanges failure due to ORES on frwiki and ruwiki.

Looks like 22:27 awight@tin: Finished deploy [ores/deploy@5084251]: Updating ORES to revscoring 2.0.10, T179711 (duration: 49m 54s) probably started this?

Mon, Nov 20, 10:45 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Wikimedia-Incident, Patch-For-Review, ORES, Scoring-platform-team, MediaWiki-Recent-changes, MediaWiki-Watchlist, Russian-Sites
Catrope closed T180953: Impossible to access recent changes results on mk.wikipedia.org, shows "No changes during the given period match these criteria." due to stray </div> as Resolved.
Mon, Nov 20, 9:40 PM · Collaboration-Team-Triage, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T167656: Automatic edit summaries should be filtered as tags.
I don't know if this RC Filters system would allow patrollers to combine "new page" and "new redirect, or changed existing page to a redirect" to differentiate those two cases.

Yes it would. You can ask for "new page creations with tag X", and you can do a union on tags (i.e. "things with tag X or tag Y"). What you can't do is an intersection on tags ("things with tag X and tag Y").

Mon, Nov 20, 6:31 PM · MediaWiki-Change-tagging, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Edit-Review-Improvements-Integrated-Filters

Thu, Nov 16

Trizek-WMF awarded T177444: Graduate new filters out of beta on remaining Flagged Revisions wikis a Party Time token.
Thu, Nov 16, 10:29 AM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-RC-Graduated-Everywhere), Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-extensions-FlaggedRevs

Wed, Nov 15

Catrope created T180633: ORES RC filters missing in beta cluster, fetching thresholds fails.
Wed, Nov 15, 8:28 PM · Scoring-platform-team (Current), Beta-Cluster-reproducible, MediaWiki-extensions-ORES
Catrope merged T180549: [wmf.8-regression] New filters do not display records according to selected options for "Number of edits to show..." into T180577: [Regression] Recent Changes on MediaWiki.org doesn't display more than 50 past edits.
Wed, Nov 15, 7:20 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression, Edit-Review-Improvements-RC-Page
Catrope merged task T180549: [wmf.8-regression] New filters do not display records according to selected options for "Number of edits to show..." into T180577: [Regression] Recent Changes on MediaWiki.org doesn't display more than 50 past edits.
Wed, Nov 15, 7:20 PM · Regression, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Catrope moved T180577: [Regression] Recent Changes on MediaWiki.org doesn't display more than 50 past edits from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Wed, Nov 15, 7:20 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression, Edit-Review-Improvements-RC-Page
Catrope closed T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis as Resolved.
Wed, Nov 15, 7:16 PM · Collaboration-Feature-Rollouts (Collaboration-RC-Graduated-Everywhere), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage, Epic
Catrope closed T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis, a subtask of T171981: Annual Plan 2017-2018, Audiences 5, Goal 2: Give better ways to monitor contributions, as Resolved.
Wed, Nov 15, 7:16 PM · Global-Collaboration, Collaboration-Team-Triage, Contributors-Team
Catrope closed T177444: Graduate new filters out of beta on remaining Flagged Revisions wikis as Resolved.
Wed, Nov 15, 7:16 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-RC-Graduated-Everywhere), Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-extensions-FlaggedRevs
Catrope closed T177444: Graduate new filters out of beta on remaining Flagged Revisions wikis, a subtask of T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis, as Resolved.
Wed, Nov 15, 7:16 PM · Collaboration-Feature-Rollouts (Collaboration-RC-Graduated-Everywhere), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage, Epic
Catrope added a comment to T180577: [Regression] Recent Changes on MediaWiki.org doesn't display more than 50 past edits.

git bisect says b8a10e6dcf00da3519ccb9e43d1c2ce0db422557 is the first bad commit.

I don't know how it breaks things. It seems to revert clearly, so that could be done as a quick fix.

Wed, Nov 15, 6:33 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression, Edit-Review-Improvements-RC-Page

Tue, Nov 14

Catrope moved T175225: Add a 'Learners' (autoconfirmed) filter to New Pages Feed and rename the existing 'new editors' filter from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Tue, Nov 14, 2:48 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-extensions-PageCuration
Catrope added a comment to T175225: Add a 'Learners' (autoconfirmed) filter to New Pages Feed and rename the existing 'new editors' filter.

In my patch I took the artistic liberty to clarify "learners" as "newly autoconfirmed users". Here's a screenshot of my patch in action:

Tue, Nov 14, 2:47 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-extensions-PageCuration

Mon, Nov 13

Catrope added a comment to T179978: Bad render of notifications about edition of flow board description.

Why are we feeding Parsoid output into Sanitizer.php::stripAllTags() ?

We do have real HTML parsers, you could simply ask one of them to do the job properly...

Mon, Nov 13, 9:56 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), StructuredDiscussions
Catrope added a comment to T179978: Bad render of notifications about edition of flow board description.

Sanitizer.php seems to simply assume that all instances of < and > are always encoded. That's a somewhat reasonable assumption IMO, since the only software that I'm aware of that fails to encode these is Parsoid . It would probably be difficult to fix the Sanitizer, especially since Parsoid outputs < and > in an unbalanced way (< is encoded but > is not); the Sanitizer code would have to be aware of quotes and I fear it'd basically turn into half an HTML parser.

Mon, Nov 13, 9:47 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), StructuredDiscussions
Catrope added a comment to T177444: Graduate new filters out of beta on remaining Flagged Revisions wikis.

Scheduled for Wednesday November 15th at 19:00 UTC.

Mon, Nov 13, 8:35 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-RC-Graduated-Everywhere), Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-extensions-FlaggedRevs
Catrope added a comment to T159791: Create new RC Filters group for 'Flagged Revisions', based on the old 'Hide reviewed edits' function.

In T159791#3746125, @Petar.petkovic wrote:

... @jmatazzoni, do you think this should be worked on? Other projects using FlaggedRevs and their localization needs to be taken into account as well, if you find that localized name for "Flagged Revisions" isn't good.

These new filters correspond with a feature that exists already on all the relevant wikis. I just want to make sure that translators understand that the filter group should have the same name as the existing site feature. I don't know how to look at the translator notes. So I want you or Elena to confirm that the translator note (the QQQ) for the name of the filter group says something like "Use the word here your wiki uses for Flagged Revisions. (E.g., on English Wikipedia, it will be 'Pending changes'."

Mon, Nov 13, 8:34 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), User-notice-collaboration, Collaboration-Feature-Rollouts (Collaboration-RC-Graduated-Everywhere), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-extensions-FlaggedRevs
Catrope added a comment to T167656: Automatic edit summaries should be filtered as tags.
Mon, Nov 13, 7:59 PM · MediaWiki-Change-tagging, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T176925: StructuredDiscussions: Spam Blacklist eats text.

Checked the behavior of AbuseFilter (#461) in betalabs - the warning is displayed and the content is not posted, but the text is not removed form the editing area. So, it might be the specific behavior for that spam filter or type of filters - need more investigtion.

Mon, Nov 13, 7:20 PM · Collaboration-Team-Triage, StructuredDiscussions
Catrope added a comment to T179718: Revive ORES filters on Related Changes.

We should be able to just bring this back, provided we first review and EXPLAIN the query to verify that it's now OK.

Mon, Nov 13, 6:43 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, User-Ladsgroup, MediaWiki-Database

Thu, Nov 9

Catrope added a comment to T179978: Bad render of notifications about edition of flow board description.

...but the one I got for an edit to my talk page looks different:

Thu, Nov 9, 8:53 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), StructuredDiscussions
Catrope added a comment to T179978: Bad render of notifications about edition of flow board description.

...but the one I got for an edit to my talk page looks different:

Thu, Nov 9, 1:18 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), StructuredDiscussions
Catrope added a comment to T179978: Bad render of notifications about edition of flow board description.

Yup, that's it. I just made this edit and got this notification:

Thu, Nov 9, 1:17 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), StructuredDiscussions
Catrope added a comment to T179978: Bad render of notifications about edition of flow board description.

It's probably because of the template at the beginning of the board description in question: {{User:irønie/tamago|30|08|2007|80|Kwiki}}.

Thu, Nov 9, 12:42 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), StructuredDiscussions

Wed, Nov 8

Catrope added a comment to T178487: Timezone information on client side.

There's also a fourth way this is handled: use moment.js which uses the client's OS clock and timezone, ignoring the user's timezone preference. This is what Flow and Echo do, and people have complained about this (see the tasks that Andre linked above).

Wed, Nov 8, 5:57 PM · Front-end-Standards-Group, JavaScript

Thu, Nov 2

Catrope added a comment to T176990: Remove Media namespace from the list of filters.

It's the same with "Special:", right? Probably all namespaces with negative IDs should not be shown.

Thu, Nov 2, 3:13 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Next-Quarter), Edit-Review-Improvements-Integrated-Filters

Wed, Nov 1

Catrope added a comment to T174415: Make the Number of Edits and Number of Days settings sticky (and adjust the Preference pg. behavior appropriately).

The edited task description looks good to me. One nitpick:

Wed, Nov 1, 5:18 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters

Fri, Oct 27

Catrope added a comment to T178395: UX check RC Filters in beta (revscoring 2.0/thresholds release).

To clarify: @Etonkovidova's concern is that, because of the version change, ORES scores that predate the version change will not be found by the Extension:ORES/Recentchanges code. So if you filtered RC for "very likely bad", it would only find bad edits that happened after the version change, not before.

Fri, Oct 27, 7:09 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-extensions-ORES, Scoring-platform-team
Catrope added a comment to T174388: LoginNotify should inform users of the IP address of failed login attempts to their account.

I copied the the New Notification Data Form into the Description at top. There's no requirement to fill it out, but experience has shown that doing so will a) save you a lot of time and b) enable the team and others to more easily and accurately understand and evaluate the plan.

How does it save you time? By flushing out all the issues you'll face in advance, so you don't have to stop at every juncture and debate "oh yeah, what icon are we going to use?" or "what should I use as as a secondary link?" etc.

Fri, Oct 27, 5:24 AM · Notifications, Collaboration-Team-Triage, User-Huji, Community-Tech, Privacy, WMF-Legal, MediaWiki-extensions-LoginNotify
Catrope claimed T172755: [wmf.12] mobile view - Unread messages count shows NaN for farsi wiki.
Fri, Oct 27, 4:50 AM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), User-Jdlrobson, I18n, Collaboration-Team-Triage (Collab-Team-This-Quarter), Readers-Web-Backlog (Tracking), Notifications, MinervaNeue
Catrope moved T172755: [wmf.12] mobile view - Unread messages count shows NaN for farsi wiki from Snack Box to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Fri, Oct 27, 4:49 AM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), User-Jdlrobson, I18n, Collaboration-Team-Triage (Collab-Team-This-Quarter), Readers-Web-Backlog (Tracking), Notifications, MinervaNeue
Catrope closed T179114: wikipage.content hook gets fired twice on RC update as Invalid.

This is expected behavior. It fires twice, but each time with a different HTML element as its parameter.

Fri, Oct 27, 4:48 AM · Collaboration-Team-Triage, JavaScript, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page

Wed, Oct 25

Catrope added a comment to T178975: [wmf.5] testwiki - Tag names are not correctly displayed.

Nope, the tag name is actually defined that way (!) https://test.wikipedia.org/wiki/MediaWiki:Tag-foo-description

Wed, Oct 25, 8:58 AM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Collaboration-Team-Triage (Collab-Team-Next-Quarter), Edit-Review-Improvements-RC-Page
Catrope added a comment to T178975: [wmf.5] testwiki - Tag names are not correctly displayed.

It looks like that tag doesn't have a description message defined? That's not something that usually happens, but we should still handle that gracefully.

Wed, Oct 25, 8:55 AM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Collaboration-Team-Triage (Collab-Team-Next-Quarter), Edit-Review-Improvements-RC-Page

Oct 24 2017

Restricted Application added a project to T164446: Support prefix search filter: Collaboration-Team-Triage.

I believe this can be done performantly with the existing rc_namespace_title index.

Oct 24 2017, 11:53 AM · Collaboration-Team-Triage, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T167656: Automatic edit summaries should be filtered as tags.

Things we should tag:

  • Blanking
  • Removing nearly all content
  • Making a page a redirect (either redirect creation or editing an existing page)
  • Undo
  • Rollback
Oct 24 2017, 11:42 AM · MediaWiki-Change-tagging, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Edit-Review-Improvements-Integrated-Filters
Catrope updated subscribers of T168413: [wmf.19] The invite opt-in popup does not accommodate some languages .

@Mattflaschen-WMF says we manually set the width and height of the popup with width: NNNpx !important. He says the width should be passed in in JS, and we should avoid specifying the height.

Oct 24 2017, 11:26 AM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Next-Quarter), Edit-Review-Improvements-RC-Page
Catrope added a comment to T174415: Make the Number of Edits and Number of Days settings sticky (and adjust the Preference pg. behavior appropriately).

New proposal: let's make these sticky again. For rclimit, use a hidden preference like we did before, but when rclimit is changed, change the hidden preference too (or wipe it out). For rcdays, wllimit and wldays, update these directly and hide them from the preferences page if the new UI is enabled.

Oct 24 2017, 11:20 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T176851: Filter edit summaries hashtags.

To do this, MediaWiki would have to recognize these hashtags in the edit summary when the edit is saved, and convert them to edit tags. Then a filter can be used to target that edit tag.

Oct 24 2017, 11:13 AM · Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage
Catrope added a comment to T176808: [testwiki-1.31.0-wmf.1] rcfilters-head is more than 250px.

The Translate task is T159795: Port Translate to new RC Filters system and is now in progress. The FlaggedRevs task is already done.

Oct 24 2017, 11:13 AM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage
Catrope added a comment to T162299: Please let edit-user-talk notifications be expandable.

Matěj's patch looks like this:

Oct 24 2017, 8:44 AM · Collaboration-Team-Triage (Collab-Team-Next-Quarter), MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Notifications

Oct 23 2017

Catrope moved T178610: [regression-wmf.4] Names of Saved filters do not get truncated from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Next-Quarter) board.
Oct 23 2017, 11:47 AM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Next-Quarter), Regression
Catrope added a comment to T178326: Remove padding from the List of Abbreviations box, so it stops squeezing results.

Possible GCI Task @Pginer-WMF ?

Oct 23 2017, 11:45 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Google-Code-in-2017, Edit-Review-Improvements-Integrated-Filters, Easy
Catrope added a comment to T174388: LoginNotify should inform users of the IP address of failed login attempts to their account.

@Catrope @SBisson @Mattflaschen-WMF , Ryan mentioned this task to me to see whether we have any issues with this approach.They are going to check with Legal to see if they raise any objections. But I said I would run it past our team to see if we have any objection. So?

Oct 23 2017, 11:39 AM · Notifications, Collaboration-Team-Triage, User-Huji, Community-Tech, Privacy, WMF-Legal, MediaWiki-extensions-LoginNotify
Catrope updated subscribers of T178774: Clarify [[MediaWiki:Rcfilters-filter-user-experience-level-newcomer-description]].

It's time since registration, yes (AKA "account age"). @jmatazzoni do you have any ideas for how this might be clarified?

Oct 23 2017, 7:11 AM · Edit-Review-Improvements-RC-Page, I18n, Collaboration-Team-Triage

Oct 18 2017

Catrope added a comment to T177117: Page elements still jumping around and blinking on RC page and Watchlist.

The two causes of jumpiness on testwiki RC are the banner they have at the top (which is not us), and the unported filter for the Translate extension (which is T159795: Port Translate to new RC Filters system). On the Watchlist there's also the "New messages for you" thing which looks like a gadget.

Oct 18 2017, 10:19 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Catrope moved T178334: Correct error in "Newcomers" filter description language. from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Next-Quarter) board.
Oct 18 2017, 7:45 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Next-Quarter), Edit-Review-Improvements-Integrated-Filters, Easy
Catrope added a comment to T178512: Prevent Echo Notification Blacklist is storing Zeros in the database.

SELECT count(*) FROM user_properties WHERE up_property = 'echo-notifications-blacklist' AND up_value REGEXP '^(0|0\n)+$'; currently returns 1671 on English Wikipedia. Let's keep an eye on that number and see if it changes.

Oct 18 2017, 6:52 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Anti-Harassment (AHT Sprint 9), Collaboration-Team-Triage, Notifications
Catrope assigned T178395: UX check RC Filters in beta (revscoring 2.0/thresholds release) to Etonkovidova.
Oct 18 2017, 6:51 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-extensions-ORES, Scoring-platform-team
Catrope edited projects for T178395: UX check RC Filters in beta (revscoring 2.0/thresholds release), added: Collaboration-Team-Triage (Collab-Team-Next-Quarter); removed Collaboration-Team-Triage.
Oct 18 2017, 6:51 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-extensions-ORES, Scoring-platform-team
Catrope added a comment to T178512: Prevent Echo Notification Blacklist is storing Zeros in the database.

If this is not causing any errors or problems, then I do not believe it is worth addressing at this time. @kaldari , thoughts?

Oct 18 2017, 5:55 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Anti-Harassment (AHT Sprint 9), Collaboration-Team-Triage, Notifications
Catrope added a comment to T172755: [wmf.12] mobile view - Unread messages count shows NaN for farsi wiki.

@Jdlrobson If you need to parse a formatted number back to an integer in JS, use intValue = mw.language.convertNumber( formattedValue, true ). If you're looking at the data-* properties on the Echo badges, it may also be that you should be using a different one (IIRC there's one for the formatted number and one for the raw number).

Oct 18 2017, 1:24 AM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), User-Jdlrobson, I18n, Collaboration-Team-Triage (Collab-Team-This-Quarter), Readers-Web-Backlog (Tracking), Notifications, MinervaNeue

Oct 17 2017

Catrope updated subscribers of T177917: Have Special:RecentChanges as URL without any options when user visits the default filters configuration.
Oct 17 2017, 6:26 PM · Collaboration-Team-Triage (Collab-Team-Next-Quarter), Edit-Review-Improvements-Integrated-Filters
Liuxinyu970226 awarded T175934: Give the right to sysops to create, move and delete Structured Discussions boards on wikis where they are available as a Beta feature a Love token.
Oct 17 2017, 4:24 AM · User-notice, Chinese-Sites, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Community-Liaisons (Jul-Sep 2017), Collaboration-Community-Engagement, User-notice-collaboration, StructuredDiscussions

Oct 16 2017

Catrope added a comment to T167656: Automatic edit summaries should be filtered as tags.
I know there is a “page blanking” tag. How is this different? Could the others be tags?
Oct 16 2017, 11:29 PM · MediaWiki-Change-tagging, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Edit-Review-Improvements-Integrated-Filters
Catrope added a comment to T178313: Recover Echo Notification Blacklist from Backup.

What is your user name on terbium?, I will send all relevant logs to you so you can check it, by yourself as I will be disconnecting soon.

Oct 16 2017, 7:30 PM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), Patch-For-Review, Anti-Harassment (AHT Sprint 7), Collaboration-Team-Triage, Operations, Notifications
Catrope added a comment to T178313: Recover Echo Notification Blacklist from Backup.

@Catrope I need a regex or a grep command or something. Or, I give you the logs and you can extract exactly the queries you want. "looks like"? contains an '\x0' ? looks like 0\x0a0? is that an exact constant? contains it? I can help, but I need to avoid the ambiguity of English. The queries are multi-line and contain lots of garbage, so not as direct as just grep.

Oct 16 2017, 7:08 PM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), Patch-For-Review, Anti-Harassment (AHT Sprint 7), Collaboration-Team-Triage, Operations, Notifications
Catrope added a comment to T178313: Recover Echo Notification Blacklist from Backup.

Thanks for finding that @jcrespo. It's great to see that both the old and new values are in the dump. Could you specifically find queries where numbers were changed to zeroes? I.e. the @3 in the WHERE (old value) looks like 123\x0a45678 and the @3 in the SET (new value) looks like 0\x0a0

Oct 16 2017, 6:43 PM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), Patch-For-Review, Anti-Harassment (AHT Sprint 7), Collaboration-Team-Triage, Operations, Notifications
Catrope added a comment to T178313: Recover Echo Notification Blacklist from Backup.

While that is being setup, if the number of updates is relatively small, compared to the table size, I can try to find the individual updates on ROW format (which stores previous and final result) with the parameters mentioned at https://phabricator.wikimedia.org/T178313#3688296 .

Oct 16 2017, 6:09 PM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), Patch-For-Review, Anti-Harassment (AHT Sprint 7), Collaboration-Team-Triage, Operations, Notifications
Catrope added a comment to T178313: Recover Echo Notification Blacklist from Backup.

@jcrespo What I think (hope) you will find is two groups of UPDATE user_properties SET up_value=X WHERE up_user=N AND up_property='echo-notifications-blacklist'; queries, first a small one and then later a bigger one, on 2017-10-09 between 18:00 and 19:00 UTC. The first group should be small (~1300 for enwiki and at most a couple thousand across all wikis in total), the second group should be larger. In the second (bigger) group of queries, some values of X (values that up_value is set to) will look like '0' or '0\n0' or '0\n0\n0' etc. For those users, there should also be non-zero values set in the first round, and those are the values David will need. Cross-referencing this is probably a lot of effort, so you can also cross-reference it against users that have zeroes currently (with David's REGEXP query), or just dump all the first round data and let David cross-reference it himself.

Oct 16 2017, 5:57 PM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), Patch-For-Review, Anti-Harassment (AHT Sprint 7), Collaboration-Team-Triage, Operations, Notifications
Catrope updated the task description for T178313: Recover Echo Notification Blacklist from Backup.
Oct 16 2017, 5:43 PM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), Patch-For-Review, Anti-Harassment (AHT Sprint 7), Collaboration-Team-Triage, Operations, Notifications
Catrope added a comment to T178246: Daily email notifications are sent in UTC.

How to set up "daily email notifications"? Steps to reproduce are welcome; please see https://mediawiki.org/wiki/How_to_report_a_bug

Oct 16 2017, 7:12 AM · Notifications, Collaboration-Team-Triage

Oct 15 2017

Catrope updated subscribers of T177825: No on-site Notifications received for certain type of actions.

Change 384299 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Echo@master] ContainmentSet: Use strict comparison for array_search()

https://gerrit.wikimedia.org/r/384299

Oct 15 2017, 12:05 AM · Anti-Harassment (AHT Sprint 7), MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-notice-collaboration, User-notice, Regression, Notifications, Collaboration-Team-Triage

Oct 14 2017

Catrope added a comment to T177825: No on-site Notifications received for certain type of actions.

I'm going to prepare patches to have lookupCentralIds set values to null when an ID can't be resolved to a user name,

Oct 14 2017, 11:37 PM · Anti-Harassment (AHT Sprint 7), MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-notice-collaboration, User-notice, Regression, Notifications, Collaboration-Team-Triage
Catrope added a comment to T177825: No on-site Notifications received for certain type of actions.

Local testing confirms that a blacklist preference set to 0 suppresses all notifications coming from non-anonymous users (which is kind of surprising, you'd expect the opposite, since the user ID of an anonymous user is 0).

Oct 14 2017, 11:22 PM · Anti-Harassment (AHT Sprint 7), MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-notice-collaboration, User-notice, Regression, Notifications, Collaboration-Team-Triage
Catrope added a comment to T177825: No on-site Notifications received for certain type of actions.

Local testing confirms that a blacklist preference set to 0 suppresses all notifications coming from non-anonymous users (which is kind of surprising, you'd expect the opposite, since the user ID of an anonymous user is 0).

Oct 14 2017, 10:56 PM · Anti-Harassment (AHT Sprint 7), MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-notice-collaboration, User-notice, Regression, Notifications, Collaboration-Team-Triage
Catrope added a comment to T177437: Update Echo and Run Maintenance Script.

This script inserted zeroes (the user ID zero, suggesting a CU lookup failure) into the blacklists of a few thousand users, and possibly broke all notifications for them. See T177825#3685628.

Oct 14 2017, 10:50 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Notifications, Collaboration-Team-Triage, Patch-For-Review, Anti-Harassment (AHT Sprint 6)
Catrope added a comment to T177825: No on-site Notifications received for certain type of actions.

I found a problem that may or may not be related:

mysql:research@s3-analytics-slave [enwiki]> select * from user_properties where up_user=REDACTED and up_property='echo-notifications-blacklist';
+----------+------------------------------+----------+
| up_user  | up_property                  | up_value |
+----------+------------------------------+----------+
| REDACTED | echo-notifications-blacklist | 0        |
+----------+------------------------------+----------+
1 row in set (0.00 sec)
Oct 14 2017, 10:48 PM · Anti-Harassment (AHT Sprint 7), MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-notice-collaboration, User-notice, Regression, Notifications, Collaboration-Team-Triage
Catrope added a comment to T177825: No on-site Notifications received for certain type of actions.

I'm investigating this now, but it seems like my accounts are not affected. From an incognito window, I pinged my work account and my personal account and I got a web notification both times. I then enabled emails for mentions on my personal account, pinged it again, and that worked too.

Oct 14 2017, 10:12 PM · Anti-Harassment (AHT Sprint 7), MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-notice-collaboration, User-notice, Regression, Notifications, Collaboration-Team-Triage
Catrope created T178237: Access to x1 broken on stat1006.
Oct 14 2017, 10:02 PM · DBA, Analytics

Oct 13 2017

Catrope added a comment to T178194: Enable new RC on mobile.

We didn't enable the new filters on mobile because we didn't think they'd work well on mobile, with the big dropdown for example. If they do work well, that would be great and we could unblock them :)

Oct 13 2017, 10:12 PM · Mobile, MediaWiki-Recent-changes, Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page
Catrope added a comment to T165550: [minor] Bookmarking no-effect filters results in 'No active filters. All contributions are shown".

States with all filters selected in send_unselected_if_any groups are not representable in the URL. We're now storing saved filters as URL parameters, so they're basically bookmarks. If we really wanted to, we could store the list of groups with redundant selections (because there's only one way in which a group can be in such a state), but that would be an annoying thing that IMO wouldn't solve that urgent of an issue.

Oct 13 2017, 1:08 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page

Oct 12 2017

Catrope added a comment to T171027: "Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis.

Hi, @Johan. Recent changes or watchlists?

Oct 12 2017, 6:11 PM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), User-notice, MediaWiki-extensions-WikibaseRepository, Wikidata-Former-Sprint-Board, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), DBA, Wikidata, Commons, Contributors-Team, Wikimedia-log-errors, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Russian-Sites, Wikimedia-General-or-Unknown, Performance, MediaWiki-Watchlist
Catrope closed T29050: Special:RecentChanges - Add missing preferences for hide/show like for minor edits and patrolled edits as Declined.

In the new filters UI, you can save any combination of filters you like, and you can make a saved filter "default", which means it'll load when you open the page. So while there aren't actual separate preferences for each of these filters, that feature lets you do the same thing.

Oct 12 2017, 6:00 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage, MediaWiki-User-preferences, MediaWiki-Recent-changes
Catrope closed T29050: Special:RecentChanges - Add missing preferences for hide/show like for minor edits and patrolled edits, a subtask of T33882: Ensure consistency of how special pages [et al.] switches can be saved (tracking), as Declined.
Oct 12 2017, 6:00 PM · Epic, MediaWiki-User-preferences
Catrope closed T29050: Special:RecentChanges - Add missing preferences for hide/show like for minor edits and patrolled edits, a subtask of T53942: Watchlist and recent changes usability issues (tracking), as Declined.
Oct 12 2017, 6:00 PM · MediaWiki-Recent-changes, MediaWiki-Watchlist, Tracking
Catrope added a comment to T171027: "Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis.

Thanks, I'll experiment with removing the STRAIGHT_JOIN, as well as with @awight's suggestion at T164796#3560530 of breaking out the change tags rollup.

Oct 12 2017, 5:44 PM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), User-notice, MediaWiki-extensions-WikibaseRepository, Wikidata-Former-Sprint-Board, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), DBA, Wikidata, Commons, Contributors-Team, Wikimedia-log-errors, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Russian-Sites, Wikimedia-General-or-Unknown, Performance, MediaWiki-Watchlist
Catrope moved T176456: ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Oct 12 2017, 3:53 PM · User-notice-collaboration, Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-WL-Graduated-Everywhere), Collaboration-Team-Triage (Collab-Team-This-Quarter), Performance, Edit-Review-Improvements
Catrope added a comment to T176456: ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on.

Oh, well in that case, if a particular filter is very selective it may make sense to allow query plans wherethe base table is ores_classification, with some sort of index like (oresc_model, oresc_class, oresc_probability). If we can narrow down the range of revisions (for options of the form only show last three days), putting oresc_rev at the end of that index may make sense too for index condition pushdown. This of course only makes sense if the filter is very selective as the required filesort has a high overhead.

Oct 12 2017, 3:46 PM · User-notice-collaboration, Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-WL-Graduated-Everywhere), Collaboration-Team-Triage (Collab-Team-This-Quarter), Performance, Edit-Review-Improvements
Catrope added a comment to T176456: ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on.

I missed one case here. If the query was not using STRAIGHT_JOIN, and the total number of revisions in the appropriate probability range of that oresc_model and that oresc_class over all time was less than the number of pages on the user's watchlist (If this is a watchlist query) and was significantly less than the number of entries in the recentchanges table over the specified time range, then the order of the joins would be re-arranged and it would use the oresc_model_class index (If that index existed). In the short term there might be some cases where this is more efficient, since ores is a relatively new feature. However in the long term its unlikely this would be the case, as the set of all revisions of all time with the specified probability range is going to get bigger over time as more and more edits get scored with ores (compared to the number of rc entries or the number of watchlist entries, which stays relatively constant over time)

Oct 12 2017, 2:54 PM · User-notice-collaboration, Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-WL-Graduated-Everywhere), Collaboration-Team-Triage (Collab-Team-This-Quarter), Performance, Edit-Review-Improvements

Oct 11 2017

Catrope updated subscribers of T171027: "Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis.

Thanks, I'll experiment with removing the STRAIGHT_JOIN, as well as with @awight's suggestion at T164796#3560530 of breaking out the change tags rollup.

Oct 11 2017, 8:28 PM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), User-notice, MediaWiki-extensions-WikibaseRepository, Wikidata-Former-Sprint-Board, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), DBA, Wikidata, Commons, Contributors-Team, Wikimedia-log-errors, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Russian-Sites, Wikimedia-General-or-Unknown, Performance, MediaWiki-Watchlist
Catrope added a comment to T166634: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open.

I now see why the surface activates in response to blur, but I don't quite understand why applying a null selection isn't simpler in showModelSelection.

Oct 11 2017, 5:29 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), User-notice-collaboration, User-Ryasmeen, Patch-For-Review, Collaboration-Team-Triage, VisualEditor, StructuredDiscussions, Regression
Catrope moved T166634: [minor] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with inspector open from Untriaged to External on the Collaboration-Team-Triage board.
Oct 11 2017, 5:21 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), User-notice-collaboration, User-Ryasmeen, Patch-For-Review, Collaboration-Team-Triage, VisualEditor, StructuredDiscussions, Regression