In T266033#6569882, @gerritbot wrote:

Change 635639 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Work around CSSJanus flipping bug

https://gerrit.wikimedia.org/r/635639

I'm being a bit silly here: I just removed variant A, so it doesn't make sense for me to complain that something doesn't look good in it. I've also added the 16px bottom padding so it looks better:

I was able to reproduce this by making my window short enough that the bottom of the suggested edits onboarding was out of view. I tracked down the issue by running $(window).on( 'scroll', function () { debugger; } ); during load and inspecting the call stack. It turns out that OO.ui.Window.prototype.ready calls this.$content.trigger( 'focus' k), which causes Chrome (but not Firefox) to scroll down so that it's centered.

This is live now! I apologize for the delays and the postponement. Other deployments were postponed/canceled and we had to wait for those.

Stage 1 is done, the patch for stage 2 has passed code review, so now we just need to wait for Oct 26 and deploy stage 2 then.

In T258017#6557809, @gerritbot wrote:

Change 634755 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Make image in difficulty banner top aligned, fix padding

https://gerrit.wikimedia.org/r/634755

While working on the big 24px->16px change mentioned in T258019#6557184, I noticed that the text in the difficulty banner in the variant C onboarding dialog was vertically centered on desktop, but should instead be top-aligned according to the mocks. The attached patch fixes that in both variant A and variant C.

Desktop issues:

Left and right padding in the desktop module intro topic area should only be 16px (not 24px)

Kosta's patch fixed this

Looking at var C only per this task, some items still to be fixed (or were maybe reverted at some point?):

All these screenshots are from variant A though (as you can tell by the presence of the start module in the background, and the topic filters below the intro section.

In T258017#6510357, @RHo wrote:

a. Similar to comment on T258019#6510238 - please make the Desktop left and right padding 16px for the module

This is fixed now, with Kosta's patch for that issue.

In T264636#6545662, @RHo wrote:

(ii) This also means updating the total card width according, done by adjusting the class .suggested-edits-task-card-wrapper to have a width:332px.

Done, on desktop. But what should happen on mobile? Currently mobile uses 260x128 for the image dimensions, should that change to something else?

No, we are keeping mobile as is (since we haven't made the same layout changes to mobile where there is just the SE module).

Great, that makes it easy.

In T264636#6545061, @gerritbot wrote:

Change 634138 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Change image size, styling tweaks

https://gerrit.wikimedia.org/r/634138

In T264636#6544942, @gerritbot wrote:

Change 634127 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Fix header icon size and padding

https://gerrit.wikimedia.org/r/634127

I ended up reaching @Albertoleoncio on IRC, and we successfully moved the help desk together.

In T265214#6540686, @Albertoleoncio wrote:

Setting it to 100% is possible, but having 20% of new users not get the homepage is deliberate, so as to create a control group for the experiment.

Oh, OK. Sorry for the confusion. I had seen that euwiki was set to 100 and I had assumed it was sort of customizable. So, I don't see a problem with staying at 80%, but is there a plan of how long the tests will stay? After that, the number could be raise to 100%.

I'll leave this to @Trizek-WMF to answer.

We should have something, like a pending indication on the "Post" button or on the header of the dialog (the latter would be the default, but we disabled it because it flashed pending states when navigating between panels).

My patch originally did the former, but after talking to @RHo , I changed it to do the latter.

Related task: T265404: Redirects should be followed when posting to help desk

would it be possible to increase the wgGEHelpPanelHelpDeskTitle for ptwiki to 100%?

Because the deployment train was delayed, we had to postpone this deployment to October 19th. I apologize for the inconvenience.

In T258008#6509770, @RHo wrote:

• Icon larger than expected (should be 20x20px)

It was 20x20 on desktop, and larger on mobile proportional to the base font size. I've fixed it to be 20x20 on both.

In T258019#6519960, @Etonkovidova wrote:

(1) I did not see any changes made to address this comment - https://phabricator.wikimedia.org/T258019#6510238. Moving to Needs More Work .

Fixed in the attached patch.

In T258016#6495190, @RHo wrote:

• The Suggested edits image should only be 64x64px:
  

This has already been fixed since your comment.

Thanks @Evrifaessa! Sorry for the late response.

The pulsating blue dot on the topic filter button is broken in all variants (not just C/D, but A as well). It looks like it was broken by this refactoring change, which was merged in early May.

In T258019#6510951, @MMiller_WMF wrote:

@Catrope -- I noticed a requirement that was missed here, about two messages that need to be changed/added. This applies to mobile, too. They are the personalized messages based on welcome survey response. Basically, these new messages excise the part that tells the user to cancel out of the dialog before searching and clicking edit, because you can't cancel out of Variant D onboarding.

Well spotted, sorry for missing this.

In T258005#6512685, @RHo wrote:

I believe this is item E on T258704 (footer should be flush to bottom and sides of SE module).

In T254704#6513838, @gerritbot wrote:

Change 631564 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Fix footer display

https://gerrit.wikimedia.org/r/631564

Moving to Code Review because I couldn't reproduce the autoscrolling issue; please move back to Needs More Work if someone other than Marshall can reproduce it.

In T258005#6510923, @MMiller_WMF wrote:

@Catrope @kostajh -- I just finished testing both Variants C and D on desktop in beta, and I have these issues:

• When I first visit the homepage in Variant D, I am autoscrolled down the page to this view. This happened to me for all three accounts I created:

I could not reproduce this issue, neither in Firefox nor in Chrome.

Hmm, that's an interesting idea. I'll mull it over and discuss it with @Krinkle. It's probably worth measuring how often such a global version string would change, compared to any individual module's version (for example, some modules are backed by wiki pages that admins can edit, so those can change more often than just the weekly deployment). We may be able to tackle that by excluding wiki page-based modules from the global version (and version them individually instead), or by having a "default version" that applies to most modules except those changed after the initial deployment.

We shouldn't do this ahead of time though, only when we're ready.

I believe all these requirements will be satisfied because of our existing reuse of preferences for the welcome popups and suggested edits activation.

The reason the client has to have the module registry is because of our caching strategy. It needs the version hashes of each module in order to be able to compute the correct URL when requesting modules.

I believe that is correct, @RHo said that verbatim here:

Also, please check my work at https://tr.wikipedia.org/wiki/MediaWiki:NewcomerTasks.json . Did I put in the right templates and help pages for the right task types? If anything needs to be changed, tell me, or edit the page yourself (only administrators can edit it).

@Evrifaessa what should the labels for the help panel links be? For now, I've used the page names as labels, but that doesn't always work well. The links would be displayed in the help panel like this:

• Biçem el kitabı
• Sayfa değiştirme
• Sayfa nasıl yazılır?
• İçindekiler
• Sıkça Sorulan Sorular

Please let me know what I should change these labels to (some of them may be right, but some others probably need to be changed)

Unfortunately, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/630706 is about to bring this issue back

The patch above sets the height of the onboarding panel to (approximately, within a few pixels) the height that the suggested edits module will be when it activates, and makes the contents scrollable. It also tightens up the padding on the footer, per the Zeplin mock (it was inheriting the much more spacious padding from the dialog).

In T255027#6501868, @Trizek-WMF wrote:

Roan, can you change the configuration so that newcomers get the tools? Thanks!

In T258017#6498645, @RHo wrote:

hi @Catrope - thanks for your attention to detail on some of these discrepancies. Per my comment on this patch, I messed up font stylings in a few places which was causing inconsistent font-size mappings from Desktop to Mobile. I've now updated the Zeplin mocks to correct this, along with the colour differences across Mobile/Desktop and the variants. Detailed revisions are as follows:

1. Header text for overlays ("Suggested edits to get started" and "Try some...") should use the OOUI fieldset header text style, which on Desktop is 16px (per current), and on Mobile is ~18.28px.
This font-size applies to the case for Variant D on the "Try some easy suggested edits only" header in font-size.

[...]

2. Intro text ("Wikipedia is built collab..." and "There are many ways...") should use the OOUI UI text style, which on Desktop is 14px, and on Mobile is 16px. Accordingly, I think there is no amazing reason for the different colours across variants, so let's make all of them Base10.

I have addressed these points by amending the patch you referred to.

Sorry, make that Wednesday instead.

Thanks! With that information, I'm now ready to deploy this. I'll schedule this for tomorrow at 18:00-19:00 UTC, but if you need more time, let me know by commenting on this task and I'll postpone it.

In T258017#6482609, @Catrope wrote:

First, in variant A, and in the variant C mocks, the text color of the "There are many ways you can contribute..." subheader is lighter (base20) and smaller (14.8px) than that of the "Try some easy suggested edits first" header above it (base10, 16px). In the variant D mock, they're the same color and font size (both base10, 14px). Is that intended? Should these color and font size changes only apply in variant D? Or should they apply in all variants, or in none of them? (Any of these answers is easy to implement, I just want to know.)

And to close this loop: my patches up for review assume that these color and font size changes should be specific to variant D.

In T258017#6482609, @Catrope wrote:

Second, the styling of the "task type selector" (the Easy, Medium and Hard headers, the checkboxes, and their labels) in this mock is pretty different between desktop and mobile:

• The headers are colored on mobile, but not on desktop
• The subheaders are bolded on mobile, but not on desktop
• The font sizes are generally larger on mobile (18px/16px vs 16px/14px)
• The subheaders have a smaller font size (14.8px) than the checkbox labels (16px) on mobile, but the same font size on desktop (14px)
• The vertical separation between the three sections is larger on mobile (24px) than on desktop (16px), even as a proportion of the font size of the header (1.333em vs 1em)

Are these differences intentional? Should these changes also be applied to the task type selector that appears when you click the "Easy tasks" button in the (activated) suggested edits module to change your task type selections later? If so, should those changes apply in variants A and C as well? (Applying these changes only to variant D or only to one of the occurrences of the task type selector would be doable, but a bit annoying, so I'd prefer to apply them universally.)

Code review from @kostajh led to a question for @RHo: should the embedded onboarding dialog keep the same height when moving between steps, like it does when it's a "real dialog"? The mockups suggest that it should, because the height is identical in the step 1 and step 2 mockups. But these are also misleading / not to scale: the step 1 mockup depicts 3 topic categories, but there are really 4, so step 1 is much taller than depicted. In practice, the height difference between step 1 (1067px) and step 2 (736px) is 331px, whereas the mockups show a consistent height of 748px and an implied height difference (if step 2 was shrunk to fit) of only 32px. Adding 300+ px of blank space to the bottom of step 2 seems like a lot, so I thought I should check first before I did that.

This actually appears to have been fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/629375

In T258016#6432804, @RHo wrote:

Hi @Catrope - Can we continue to vary based on WelcomeSurvey responses for this onboarding, BUT when a user clicks on the "?" icon in the initiated module header, we always show the single general icon and text for everyone?

@MMiller_WMF to confirm but I am asking on the assumption we would want the same customized onboarding for var C & D, and at the same time not have the help "?" in the SE module header be customized (since a user may not look at that message until much later)

Sorry for not providing better instructions for testing the welcome survey earlier. I knew this would be an issue, and made a mental note to post instructions for it, but I forgot.

This is working and ready for review, except for the styling tweaks that I asked Rita about above.

Some additional styling questions for @RHo:

In T261411#6479345, @kostajh wrote:

Yeah, I don't think external store would be the place to store this.
But again, as mentioned earlier, if this can be considered volatile, I am not sure MySQL is the right place to keep this as a "second cache". But even if it is, what would you have in mind? wikishared on x1?

I don't know enough about this. Where could I read about wikishared (I don't see any obvious looking documentation pages on wikitech)? The link recommendation data is local to each language wiki; whether there are advantages to using wikishared versus the local wiki's DB is unclear to me. Do you have advice here?

@MMiller_WMF Could you decide the prioritization for this task please? It should probably go in either the current sprint or in Growth-Team-Leftovers