Catrope (Roan Kattouw)
Collaboration team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (132 w, 6 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF)

Recent Activity

Today

Catrope moved T163749: [wmf.21-regression] Posting a reply to Flow topics with multiple posts redirects users to no-js mode from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Wed, Apr 26, 12:34 AM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Flow, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review
Catrope edited projects for T163749: [wmf.21-regression] Posting a reply to Flow topics with multiple posts redirects users to no-js mode, added: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Flow, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017); removed MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Collaboration-Team-Triage.
Wed, Apr 26, 12:33 AM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Flow, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review

Yesterday

Catrope added a comment to T163749: [wmf.21-regression] Posting a reply to Flow topics with multiple posts redirects users to no-js mode.

Caused by a JS error: Cannot read property 'append' of undefined in mw.flow.ui.ReplyWidget.prototype.intializeEditor where it does this.$editorContainer.append(this.editor.$element); (this.$editorContainer is undefined)

Tue, Apr 25, 11:26 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Flow, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review
Catrope added a comment to T161041: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled.

...and it still failed.

Tue, Apr 25, 7:34 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MediaWiki-Recent-changes, MediaWiki-Unit-tests
Catrope added a comment to T163816: LoginNotify fatals on Special:Notifications in beta labs for certain users.

Looking at the implementation of LoginNotifyPresentationModel::getHeaderMessage(), it looks like it can return an empty string in some cases.

Tue, Apr 25, 7:20 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-LoginNotify
Catrope updated subscribers of T163816: LoginNotify fatals on Special:Notifications in beta labs for certain users.
Tue, Apr 25, 7:17 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-LoginNotify
Catrope triaged T163816: LoginNotify fatals on Special:Notifications in beta labs for certain users as "Unbreak Now!" priority.
Tue, Apr 25, 7:16 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-LoginNotify
Catrope created T163816: LoginNotify fatals on Special:Notifications in beta labs for certain users.
Tue, Apr 25, 7:16 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-LoginNotify
Catrope renamed T163494: Special:Nuke - "There are no new pages in recent changes." is displayed if no matches found from "[minor] Special:Nuke - "There are no new pages in recent changes." is displayed if no matches found " to "Special:Nuke - "There are no new pages in recent changes." is displayed if no matches found ".
Tue, Apr 25, 6:25 PM · Easy, MediaWiki-extensions-Nuke, Collaboration-Team-Triage
Catrope added a project to T163494: Special:Nuke - "There are no new pages in recent changes." is displayed if no matches found : Easy.
Tue, Apr 25, 6:25 PM · Easy, MediaWiki-extensions-Nuke, Collaboration-Team-Triage
Catrope added a comment to T163419: Add a "user contributions" link on Topics pages attached to a Talk page.

If you're on a topic page associated with a user talk page, the sidebar should contain the "user contributions" link (and other user-relevant links) just as it does when you view the user talk page directly.

Tue, Apr 25, 6:22 PM · Flow, Collaboration-Team-Triage
Catrope merged T163299: No reference for Thanks into T51087: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so.
Tue, Apr 25, 6:19 PM · Patch-For-Review, Collaboration-Team-Triage, Thanks
Catrope merged task T163299: No reference for Thanks into T51087: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so.
Tue, Apr 25, 6:19 PM · Collaboration-Team-Triage, Thanks
Catrope edited projects for T163264: [minor] Preferences page - zooming out makes tab dividing lines disappear, added: MediaWiki-Interface; removed Collaboration-Team-Triage.
Tue, Apr 25, 6:17 PM · MediaWiki-Interface
Catrope updated subscribers of T163164: [mobile-wmf.20] RC page - UI issues .

The grey blobs that merge together are because that's what disabled mw-ui-checkboxes look like. (@Volker_E ? @Jdlrobson ?) They become un-disabled when you make a selection in the dropdown.

Tue, Apr 25, 6:15 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage
Catrope added a comment to T163061: Flow: It's impossible hide/delete the title of topic.

Why oversighter? The RevDel normally is managed by administrator.

Sorry for the terminology confusion. The Flow UI uses "oversight", but it works a bit more like RevDel, and I think the rights needed for it are revdel-style rights. If not, that's something we should fix.

Tue, Apr 25, 6:10 PM · Collaboration-Team-Triage, Flow
Catrope added a comment to T163061: Flow: It's impossible hide/delete the title of topic.

Why oversighter? The RevDel normally is managed by administrator.

Tue, Apr 25, 5:59 PM · Collaboration-Team-Triage, Flow
Catrope moved T163025: Create a preference for 'classic' ORES shading on RC Page from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Tue, Apr 25, 5:41 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Revision-Scoring-As-A-Service
Catrope edited projects for T163025: Create a preference for 'classic' ORES shading on RC Page, added: Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017); removed Collaboration-Team-Triage.
Tue, Apr 25, 5:41 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Revision-Scoring-As-A-Service
Catrope added a comment to T161041: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled.

Change 349951 had a related patch set uploaded (by Sbisson):
[mediawiki/core@master] userExpLevel test: use a single time()

https://gerrit.wikimedia.org/r/349951

Tue, Apr 25, 2:00 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MediaWiki-Recent-changes, MediaWiki-Unit-tests
Catrope added a comment to T163757: ORES on en.wiki chokes on "V. likely good faith" + "Likely have problems".

The query for this is:

SELECT  /*! STRAIGHT_JOIN */ rc_id,rc_timestamp,rc_user,rc_user_text,rc_namespace,rc_title,rc_comment,rc_minor,rc_bot,rc_new,rc_cur_id,rc_this_oldid,rc_last_oldid,rc_type,rc_source,
    rc_patrolled,rc_ip,rc_old_len,rc_new_len,rc_deleted,rc_logid,rc_log_type,rc_log_action,rc_params,wl_user,wl_notificationtimestamp,
    (SELECT  GROUP_CONCAT(ct_tag SEPARATOR ',') FROM `change_tag`    WHERE ct_rc_id=rc_id  ) AS `ts_tags`,
    ores_damaging_cls.oresc_probability AS `ores_damaging_score`,ores_goodfaith_cls.oresc_probability AS `ores_goodfaith_score`,
    fp_stable,fp_pending_since
FROM `recentchanges`
LEFT JOIN `watchlist` ON (wl_user = '22559448' AND (wl_title=rc_title) AND (wl_namespace=rc_namespace))
LEFT JOIN `ores_model` `ores_damaging_mdl` ON (ores_damaging_mdl.oresm_is_current = '1' AND ores_damaging_mdl.oresm_name = 'damaging')
LEFT JOIN `ores_classification` `ores_damaging_cls` ON ((ores_damaging_cls.oresc_model = ores_damaging_mdl.oresm_id) AND (rc_this_oldid = ores_damaging_cls.oresc_rev) AND ores_damaging_cls.oresc_class = '1')
LEFT JOIN `ores_model` `ores_goodfaith_mdl` ON (ores_goodfaith_mdl.oresm_is_current = '1' AND ores_goodfaith_mdl.oresm_name = 'goodfaith')
LEFT JOIN `ores_classification` `ores_goodfaith_cls` ON ((ores_goodfaith_cls.oresc_model = ores_goodfaith_mdl.oresm_id) AND (rc_this_oldid = ores_goodfaith_cls.oresc_rev) AND ores_goodfaith_cls.oresc_class = '1')
LEFT JOIN `flaggedpages` ON ((fp_page_id = rc_cur_id)) 
WHERE ((ores_damaging_cls.oresc_probability BETWEEN 0.879 AND 1))
AND ((ores_goodfaith_cls.oresc_probability BETWEEN 0.86 AND 1))
AND (rc_timestamp >= '20170418000000')
AND rc_new IN ('0','1')
ORDER BY rc_timestamp DESC
LIMIT 50
Tue, Apr 25, 12:53 AM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MediaWiki-extensions-ORES, Revision-Scoring-As-A-Service-Backlog

Mon, Apr 24

Catrope added a comment to T159942: Support filtering for users, edit tags, and namespaces.

About the exclude button: I think we should have a single "exclude" button for the entire namespace dropdown, not per namespace.

Mon, Apr 24, 11:45 PM · Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Catrope added a comment to T159753: Concerns about ores_classification table size on enwiki.

For some reason the bot did not report this: https://gerrit.wikimedia.org/r/#/c/349946 by @Tgr adds a maintenance script to clean up the old rows (or, technically, adds this functionality to an existing maintenance script).

Mon, Apr 24, 6:41 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Revision-Scoring-As-A-Service, Patch-For-Review, Performance, MediaWiki-extensions-ORES
Catrope updated subscribers of T163712: " Highlight likely problem edits with colors and an "r" for "needs review"" shows up even with RC Filters beta feature enabled.

Furthermore, @jmatazzoni reports that he (correctly) does not see the preference, but that it (incorrectly) behaves as if it's set to true. Hidden preferences should behave as if they are set to their defaults, and the default is false.

Mon, Apr 24, 5:18 PM · MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MediaWiki-extensions-ORES, Revision-Scoring-As-A-Service-Backlog

Sat, Apr 22

MGChecker awarded T152169: URL parameter to temporarily disable user scripts/gadgets a Like token.
Sat, Apr 22, 8:53 PM · User-notice, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), MediaWiki-ResourceLoader
Catrope added a comment to T152169: URL parameter to temporarily disable user scripts/gadgets.

Noting here in case someone else was curious: The Tech News used the example https://en.wikipedia.org/wiki/Literature?safemode=1 but if you scroll to the bottom you'll see the navboxes are all broken. This apparently is because the styling is defined in common.css, which is also disabled in safe mode. It makes sense for safe mode to work in this way... but it might be useful to have a way to include the common JS/CSS, and perhaps even default-enabled gadgets (so similar to what a newly registered account would see).

Sat, Apr 22, 7:48 AM · User-notice, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), MediaWiki-ResourceLoader

Fri, Apr 21

Catrope moved T163522: [betalabs-regression] RC filters - UI changes in displaying conflict states and 'no-effect' filters from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Fri, Apr 21, 10:50 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Catrope moved T159372: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Fri, Apr 21, 10:45 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Wikimedia-log-errors, Flow
Catrope added a comment to T161041: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled.

https://gerrit.wikimedia.org/r/349456

This patch uses the $tables variable to fetch the users in the tests. In case of a pass-by-ref issue, the test would fail with a malformed SQL exception because no table would be specified.

Fri, Apr 21, 8:28 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MediaWiki-Recent-changes, MediaWiki-Unit-tests
Catrope added a comment to T163337: Watchlist entries duplicated several times.

Related: T158004: Release RC Page filtering to non-ORES wikis is scheduled for 14:00 UTC this Monday, which will deploy Ores (by default/not as a Beta Feature) at almost all of the wikis.

Fri, Apr 21, 6:35 PM · Patch-For-Review, Wikimedia-Incident, MediaWiki-JobQueue, Revision-Scoring-As-A-Service, User-Ladsgroup, MediaWiki-extensions-ORES, ORES, MediaWiki-Watchlist, codfw-rollout
Catrope merged T163528: FOUC: Content is narrow first and then reflows to wide into T102648: On page-load, a flash of expanded Flow Board Description is seen before it collapses.
Fri, Apr 21, 6:33 PM · Easy, JavaScript, Collaboration-Team-Triage, Flow
Catrope merged task T163528: FOUC: Content is narrow first and then reflows to wide into T102648: On page-load, a flash of expanded Flow Board Description is seen before it collapses.
Fri, Apr 21, 6:33 PM · Collaboration-Team-Triage, Flow
Halfak awarded T163025: Create a preference for 'classic' ORES shading on RC Page a Love token.
Fri, Apr 21, 2:23 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Revision-Scoring-As-A-Service
Catrope moved T162938: 'Beta' link redirects to the section on 'Preferences' where the most recent changes were made from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Fri, Apr 21, 12:45 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, BetaFeatures, MediaWiki-User-preferences, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Catrope moved T163387: [minor] RC filters - bullet points displayed blank if 'Highlight results' button is clicked from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Fri, Apr 21, 12:28 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
Catrope moved T149385: Approved interface text for RC page interface elements from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Fri, Apr 21, 12:26 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Edit-Review-Improvements-RC-Page
Catrope added a comment to T163518: Don't truncate bundled cross-wiki notifications.

And a simulation of what it would look like with the current (long) text for the LoginNotify notification:

Fri, Apr 21, 12:08 AM · Community-Tech, Crosswiki, Notifications, Collaboration-Team-Triage
Catrope added a comment to T159791: Port FlaggedRevs to new RCFilters UI.

Without the RCFilters beta feature enabled, you'd see two separate filters, both "Hide patrolled edits" and "Hide reviewed edits". There is some overlap between those two. The simple thing to do here would be to just port "Hide reviewed edits" to a simple "Reviewed" / "Unreviewed" filter group (same as "Patrolled" / "Unpatrolled", which has already been ported), but we may want to consider if we should handle it differently because of the overlap that exists (it sounds to me like all reviewed edits are also patrolled, but some things can be patrolled without being reviewed?).

Fri, Apr 21, 12:07 AM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page, MediaWiki-extensions-FlaggedRevs

Thu, Apr 20

Catrope added a comment to T162104: Fix multiple/repetitive notifications with LoginNotify.

I added the Notification Request Form into the Description at top. If you don't mind, having this filled out is very helpful for anyone reviewing the notification for proper style and completeness.

Thu, Apr 20, 11:57 PM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-LoginNotify
Catrope added a comment to T163518: Don't truncate bundled cross-wiki notifications.

Here's what truncated vs untruncated would look like:

Thu, Apr 20, 11:55 PM · Community-Tech, Crosswiki, Notifications, Collaboration-Team-Triage
Catrope added a comment to T162864: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing).

Do you know when this will be deployed?

Most likely with the next deployment train (April 25-27), but only if the patch is fixed (because it doesn't seem to work right now) and merged before then.

Thu, Apr 20, 6:54 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-notice, Patch-For-Review, VisualEditor-MediaWiki, Flow, VisualEditor-MediaWiki-2017WikitextEditor, Collaboration-Team-Triage, VisualEditor
Catrope placed T161756: Unchecking category leads to more results on plwiki up for grabs.
Thu, Apr 20, 6:07 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
Catrope moved T162931: The notification for "New topic created on" <page> should tell me whether anyone has replied yet from Untriaged to Product/Design Work on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Thu, Apr 20, 5:11 PM · Wikimedia-Hackathon-2017, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Collab-Notifications-Page
Catrope moved T162969: [minor] RC filters - additional alignment is needed for 'What's this?" link from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Thu, Apr 20, 5:11 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
Catrope moved T162938: 'Beta' link redirects to the section on 'Preferences' where the most recent changes were made from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Thu, Apr 20, 5:11 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, BetaFeatures, MediaWiki-User-preferences, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Catrope added a project to T162957: Rc filters - IE11 filters display issues: Browser-Support-Internet-Explorer.
Thu, Apr 20, 5:10 PM · Browser-Support-Internet-Explorer, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Catrope moved T162957: Rc filters - IE11 filters display issues from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Thu, Apr 20, 5:10 PM · Browser-Support-Internet-Explorer, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Catrope moved T163275: RC filters - 'Highlight results' button is still active even with 'No filters found' from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Thu, Apr 20, 5:10 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page

Wed, Apr 19

Catrope added a comment to T163337: Watchlist entries duplicated several times.

The 90M rows of old data are known: T159753: Concerns about ores_classification table size on enwiki. I was going to clean them up, but haven't gotten around to doing that yet, and it's probably a good idea to wait until after the switchover is completely over (i.e. we're back in eqiad) before I do that.

Wed, Apr 19, 8:29 PM · Patch-For-Review, Wikimedia-Incident, MediaWiki-JobQueue, Revision-Scoring-As-A-Service, User-Ladsgroup, MediaWiki-extensions-ORES, ORES, MediaWiki-Watchlist, codfw-rollout
Catrope added a comment to T163337: Watchlist entries duplicated several times.

The 90M rows of old data are known: T159753: Concerns about ores_classification table size on enwiki. I was going to clean them up, but haven't gotten around to doing that yet, and it's probably a good idea to wait until after the switchover is completely over (i.e. we're back in eqiad) before I do that.

Wed, Apr 19, 8:08 PM · Patch-For-Review, Wikimedia-Incident, MediaWiki-JobQueue, Revision-Scoring-As-A-Service, User-Ladsgroup, MediaWiki-extensions-ORES, ORES, MediaWiki-Watchlist, codfw-rollout
Catrope moved T162927: Set the default for Special:Notifications to "Unread" (at least if there are any unread messages) from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Wed, Apr 19, 7:22 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Collab-Notifications-Page
Catrope added a comment to T153011: Special:Notifications is too slow to open.

@Whatamidoing-WMF Can you reproduce this in safe mode? https://en.wikipedia.org/wiki/Special:Notifications?safemode=1 will load the notifications page without any gadgets or user/site scripts. If you can reproduce in safe mode, then there's a bug in our software and we'll try to track it down; if not, then the issue is with a user/site script or gadget.

Wed, Apr 19, 5:43 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), User-notice-collaboration, Notifications
Catrope added a comment to T148066: New notifs sometimes doesn't appear correctly - progress bar appears but nothing happens.

Update: I've introduced a new feature that lets you test with gadgets and user scripts disabled by going to https://cs.wikipedia.org/wiki/Special:Notifications?safemode=1 . Please test this in safe mode and see if you can reproduce the bug. If you cannot reproduce in safe mode, the cause must be a gadget or user script.

Wed, Apr 19, 5:41 PM · Collaboration-Team-Triage, User-Urbanecm, Notifications
Catrope moved T161888: Make ORES prediction disappear when the edit is reviewed with Flagged Revisions from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Wed, Apr 19, 5:36 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, User-notice-collaboration, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
Catrope triaged T163358: Loading oojs-ui-core without oojs-ui-toolbars causes JS error as "Unbreak Now!" priority.
Wed, Apr 19, 5:35 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), OOjs-UI (OOjs-UI-0.21.2), Regression
Catrope edited the description of T163358: Loading oojs-ui-core without oojs-ui-toolbars causes JS error.
Wed, Apr 19, 5:34 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), OOjs-UI (OOjs-UI-0.21.2), Regression
Catrope created T163358: Loading oojs-ui-core without oojs-ui-toolbars causes JS error.
Wed, Apr 19, 5:33 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), OOjs-UI (OOjs-UI-0.21.2), Regression

Tue, Apr 18

Catrope moved T159372: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) from Blocked to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Tue, Apr 18, 11:49 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Wikimedia-log-errors, Flow
RandomDSdevel awarded T152169: URL parameter to temporarily disable user scripts/gadgets a Doubloon token.
Tue, Apr 18, 11:34 PM · User-notice, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), MediaWiki-ResourceLoader
Catrope added a comment to T159372: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00).

As far as I can tell, all cases of un-unserializable events are due to very old Flow events. Prior to rEFLWe5f75381274a: Serialize UUID into something more compact / T64532: Flow: serialize UUID objects as strings, the UUID class in Flow included an MWTimestamp object in its serialization, which in turn contains a DateTime object. This DateTime sometimes has its timezone set to +00:00, which causes an exception in HHVM but not in Zend(!). It took me a while to figure this out because of T146285: Switch mwscript from Zend PHP5 to default php alternative (egHHVM), which meant that unserializing the bad data failed in production but worked in mwscript eval.php. I noticed that it did fail on real app servers, and went down a version discrepancy rabbit hole, but it turns out that that was a red herring caused by my workaround for mwscript being unavailable on those machines, which ended up using HHVM (php) instead of Zend (php5).

Tue, Apr 18, 11:32 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Wikimedia-log-errors, Flow
Catrope added a comment to T163278: Four different PHP/HHVM versions on the cluster.

This seems to be partially expected. T158176: Build / migrate to HHVM 3.18 says "3.18.2 is running on the mediawiki canaries, but the wider rollout is held back until after the DC switchover", which seems sensible.

Tue, Apr 18, 11:05 PM · Operations
Catrope updated subscribers of T163278: Four different PHP/HHVM versions on the cluster.
Tue, Apr 18, 10:57 PM · Operations
Catrope created T163278: Four different PHP/HHVM versions on the cluster.
Tue, Apr 18, 10:56 PM · Operations
Catrope added a comment to T161888: Make ORES prediction disappear when the edit is reviewed with Flagged Revisions.

My testing indicates that FlaggedRevs does update the rc_patrolled flag when a revision is reviewed. See RevisionReviewForm::updateRecentChanges

When the rc_patrolled flag is updated in the recentchanges table, both the red exclamation mark (!) and the ORES "r" should go away.

Tue, Apr 18, 10:53 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, User-notice-collaboration, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
Catrope added a comment to T162844: [minor] frwiki - RC page with filters displays extra dot on a new line .

So it looks like arz, bqi and luz do end in $3 (modulo RLE characters maybe)? And lrc and mzn don't have $3 at all, which seems like a bug. The only language where it would really make a difference is avk, and looking at that message I'm not sure if the translators understood what they were doing there. So your suggestion of removing $3 and adding the links separately sounds good to me.

Tue, Apr 18, 6:57 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review
Catrope closed T70580: Do not truncate a message in middle of a character as "Resolved".

This was almost certainly fixed by rMWe4d6238c0046: Language::truncate(): don't chop up multibyte characters when input contains… about 18 months ago. Please reopen if this still happens.

Tue, Apr 18, 6:45 PM · Collaboration-Team-Triage, I18n, Notifications
Catrope added a project to T136770: Use quotes instead of bolding in email subjects: Wikimedia-Hackathon-2017.
Tue, Apr 18, 6:43 PM · Wikimedia-Hackathon-2017, Collaboration-Team-Triage, Notifications
Catrope added a project to T71981: User rights change notification email does not specify in body which account was affected: Wikimedia-Hackathon-2017.
Tue, Apr 18, 6:38 PM · Wikimedia-Hackathon-2017, Collaboration-Team-Triage, Easy, Notifications
Catrope added a comment to T55479: Notification emails should embed icons as data URIs.

GMail now does display our notification icons. We did have to use PNGs instead of SVGs to make that happen, but we did that a while ago.

Tue, Apr 18, 6:37 PM · Collaboration-Team-Triage, Notifications
Catrope added a project to T158269: Escape round parentheses so they properly show in To: Wikimedia-Hackathon-2017.
Tue, Apr 18, 6:31 PM · Wikimedia-Hackathon-2017, Collaboration-Team-Triage, Notifications
Catrope added a project to T162930: Make it easy to filter notifications by type: Wikimedia-Hackathon-2017.
Tue, Apr 18, 6:28 PM · Wikimedia-Hackathon-2017, Collab-Notifications-Page, Collaboration-Team-Triage
Catrope added a project to T162931: The notification for "New topic created on" <page> should tell me whether anyone has replied yet: Wikimedia-Hackathon-2017.
Tue, Apr 18, 6:27 PM · Wikimedia-Hackathon-2017, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Collab-Notifications-Page
Catrope added a comment to T162864: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing).

@Jdforrester-WMF said in reaction to my question about this topic in task T116417 this answer:

@Jdforrester-WMF One little observation: Is it okay that there is a text "Switch to visual editing" if I am currently in the visual editing mode (or the same for source editing)? I think the textual representation of the current state should not be "Switch to ...", but something like "Using visual editing" or just "visual editing" instead. It seems to be a little bit confusing or misleading to me.

Certainly we could fiddle with that; I was going to wait for wider feedback before adding to translators' load, though. :-)

Tue, Apr 18, 6:19 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-notice, Patch-For-Review, VisualEditor-MediaWiki, Flow, VisualEditor-MediaWiki-2017WikitextEditor, Collaboration-Team-Triage, VisualEditor
Catrope closed T85030: Add Flow support to PageTriage using MessagePoster as "Resolved".
Tue, Apr 18, 6:08 PM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Flow, MediaWiki-extensions-PageCuration
Catrope merged T162314: Update Notifications/Developer guide into T136372: Document how to create a new notification type.
Tue, Apr 18, 6:05 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Documentation, Notifications
Catrope merged task T162314: Update Notifications/Developer guide into T136372: Document how to create a new notification type.
Tue, Apr 18, 6:05 PM · MediaWiki-Documentation, Documentation, Collaboration-Team-Triage, Notifications
Catrope closed T145902: Page link expandable bundle has a primary link as "Resolved".

This was resolved long ago: bundles open when clicked and do not have a primary link.

Tue, Apr 18, 6:04 PM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)), Patch-For-Review, Notifications
Catrope closed T110731: Echo's 'seen time' should be replaced with marking specific notifications as seen as "Declined".

We decided to stay with timestamp-based seen-ness, and made some improvements (including a global timestamp) to make it work better.

Tue, Apr 18, 5:46 PM · Collaboration-Team-Triage, Notifications
Catrope closed T135661: Schema change for per-notification seen-ness as "Declined".

We decided not to do this.

Tue, Apr 18, 5:46 PM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Notifications
Catrope closed T135661: Schema change for per-notification seen-ness, a subtask of T110731: Echo's 'seen time' should be replaced with marking specific notifications as seen, as "Declined".
Tue, Apr 18, 5:46 PM · Collaboration-Team-Triage, Notifications
Catrope closed T78671: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries as "Resolved".

This seems fixed to me. Please reopen if slow query log entries reappear.

Tue, Apr 18, 5:45 PM · Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Performance, MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)), Patch-For-Review, Flow, Beta-Cluster-Infrastructure
He7d3r awarded T152169: URL parameter to temporarily disable user scripts/gadgets a Love token.
Tue, Apr 18, 2:49 AM · User-notice, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), MediaWiki-ResourceLoader
Catrope moved T163170: [regression] RCFilters: When filtering and no results found, the menu disappears from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Tue, Apr 18, 12:14 AM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.29-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
Catrope moved T163138: [betalabs-regression] RC filters - in drop down filter panel there is no automatic scrolling to selected filter capsule from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Tue, Apr 18, 12:13 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Regression

Mon, Apr 17

Catrope added a project to T162968: ORES highlighting not working on grouped watchlist: Edit-Review-Improvements-RC-Page.
Mon, Apr 17, 11:17 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage, MediaWiki-extensions-ORES, Revision-Scoring-As-A-Service-Backlog
Catrope added a comment to T158458: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" baseline.

I was granted permission to deploy the fix, and tried to deploy it, but because of issues with the deployment server the deployment didn't fully work, and the fix is now half-deployed. I'm trying to get someone to fix that server so I can deploy it properly.

Mon, Apr 17, 11:16 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), Patch-For-Review, Edit-Review-Improvements-RC-Page
Catrope closed T163152: ERI Metrics fromrc=1 URL-extension breaks heavily used admin script as "Resolved".

The fix should be deployed now; it didn't quite work the first time because of T163158: acpi_pad consuming 100% CPU on tin, so I had to deploy it again after that was fixed.

Mon, Apr 17, 11:16 PM · Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page
Catrope added a comment to T158458: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" baseline.

I was granted permission to deploy the fix, and tried to deploy it, but because of issues with the deployment server the deployment didn't fully work, and the fix is now half-deployed. I'm trying to get someone to fix that server so I can deploy it properly.

Mon, Apr 17, 10:17 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), Patch-For-Review, Edit-Review-Improvements-RC-Page
Catrope added a comment to T163158: acpi_pad consuming 100% CPU on tin.

Apparently this previously happened on tin's sister host mira as well: T137647#2791091

Mon, Apr 17, 9:55 PM · Operations
Catrope added a comment to T162850: acpi_pad issues.

tin is also affected, its kernel version appears to be 4.4.0-3-amd64 .

Mon, Apr 17, 9:47 PM · Patch-For-Review, Operations
Catrope created T163158: acpi_pad consuming 100% CPU on tin.
Mon, Apr 17, 9:46 PM · Operations
Catrope added a comment to T163152: ERI Metrics fromrc=1 URL-extension breaks heavily used admin script .

We've already written and merged https://gerrit.wikimedia.org/r/348504 which disables the ?fromrc=1 addition, and we won't add it back unless and until we find a way to make it non-disruptive.

Mon, Apr 17, 9:07 PM · Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page
MusikAnimal awarded T152169: URL parameter to temporarily disable user scripts/gadgets a Love token.
Mon, Apr 17, 8:00 PM · User-notice, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), MediaWiki-ResourceLoader
Catrope changed the visibility for T162621: Flow Nuke integration is broken for non-existent users.
Mon, Apr 17, 6:43 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MediaWiki-extensions-Nuke, Flow, Security
Catrope added a comment to T158458: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" baseline.

I had not thought about link visitedness at all when implementing this. My apologies for the disruption! (And for missing the first comment about it.)

Mon, Apr 17, 6:29 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), Patch-For-Review, Edit-Review-Improvements-RC-Page
Catrope updated subscribers of T163025: Create a preference for 'classic' ORES shading on RC Page.

This is the behavior @jmatazzoni asked for, I'll leave it to him to defend it.

Mon, Apr 17, 6:17 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Revision-Scoring-As-A-Service
Catrope added a comment to T163061: Flow: It's impossible hide/delete the title of topic.

This is the same on wikitext talk pages, right? If you delete a "topic" (section), the name of that section will still be visible in the history, in the diffs of those edits and usually in their edit summaries too. If there is defamatory or otherwise terrible content in these section names, an oversighter can suppress the relevant edits. This is also possible in Flow, where an oversighter can suppress topics with defamatory content in their titles.

Mon, Apr 17, 6:15 PM · Collaboration-Team-Triage, Flow
Catrope added a comment to T133462: Provide standard-compatible way to load multi-file packages (not plain concatenation).

We want this. We have been having trouble with dependency management via ResourceLoader, to the point that now in the Popups repository we are using webpack to manage these dependencies and generate a single JS file for inclusion with ResourceLoader. Reflecting aside from one solveable problem of merge conflicts due to shipping compiled assets in the repository we prefer this approach and are probably going to use it elsewhere. So anything that plays into that / removes the need for webpack would be highly useful.

We are also planning to share more JS with the iOS and Android apps, so are thinking a lot about packaging up libraries on npm so we can share them amongst ourselves. Right now our webpack approach means we can do this quite easily.

Mon, Apr 17, 6:00 PM · Reading-Web-Backlog, ArchCom-Has-shepherd, RfC, Front-end-Standards-Group, ArchCom-RfC, MediaWiki-ResourceLoader
Catrope added a comment to T163063: SpecialRecentChangesLinked::doMainQuery bad query bringing down database server.

Thanks for clearing that up. I have +1'ed it. I guess this will be deployed after the switch DC right? As there are no deployments scheduled for this week.

Mon, Apr 17, 5:42 PM · Wikimedia-Incident, User-Ladsgroup, MediaWiki-General-or-Unknown, MediaWiki-Database

Fri, Apr 14

Catrope created T162974: Scap's canary check should stop us from deploying config changes that cause floods of "undefined variable" errors.
Fri, Apr 14, 12:15 AM · Patch-For-Review, Scap