Page MenuHomePhabricator

Catrope (Roan Kattouw)
Software engineer, Design Systems Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (490 w, 2 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Catrope closed T358903: Vector search field disappears after focussing when using ResourceLoader debug mode 1 as Resolved.
Fri, Mar 1, 10:11 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Desktop Improvements (Vector 2022)
Catrope claimed T358903: Vector search field disappears after focussing when using ResourceLoader debug mode 1.
Fri, Mar 1, 9:04 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Desktop Improvements (Vector 2022)
Catrope edited projects for T358903: Vector search field disappears after focussing when using ResourceLoader debug mode 1, added: Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)); removed Design-System-Team.
Fri, Mar 1, 9:02 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Desktop Improvements (Vector 2022)
Catrope added a comment to T358903: Vector search field disappears after focussing when using ResourceLoader debug mode 1.

This appears to happen because the @wikimedia/codex-search module is empty when ?debug=1 is passed (but not when ?debug=2 is passed).

Fri, Mar 1, 8:51 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Desktop Improvements (Vector 2022)
Catrope moved T358827: Adjacent Field components should have spacing between them from Inbox to Up Next on the Design-System-Team board.

See https://1007750--wikimedia-codex.netlify.app/sandbox/#cdx-field for a live demo of this issue.

Fri, Mar 1, 2:42 AM · Patch-For-Review, Design-System-Team, Codex
Catrope created T358827: Adjacent Field components should have spacing between them.
Fri, Mar 1, 2:26 AM · Patch-For-Review, Design-System-Team, Codex

Thu, Feb 29

Catrope added a comment to T356677: Migrate uses of codex-search in Vector to use CodexModule.

Note you also don't have to put this in a separate module -- if there's only one module that uses TypeaheadSearch, you can put all the CodexModule stuff in that module itself, and then do const { CdxTypeaheadSearch } = require( './codex.js' );

Thu, Feb 29, 8:51 PM · Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Desktop Improvements (Vector 2022)
Catrope closed T355841: Remove use of themeStyles in VueTest as Declined.

Yeah we can close this, this turned out not to be as necessary as I thought.

Thu, Feb 29, 8:42 PM · Design-System-Team, Patch-For-Review, Technical-Debt, VueTest
Catrope closed T355841: Remove use of themeStyles in VueTest, a subtask of T355842: Remove themeStyles support from CodexModule, as Declined.
Thu, Feb 29, 8:40 PM · Design-System-Team, Codex
Catrope added a comment to T357695: Table: Investigate open implementation questions.
  1. Pagination

[...]

Aside from that, it's just a matter of calculating which items to show, how many pages there are, etc.

I think this part may not be as simple. There seems to be a hidden assumption here that all the rows are already in the data prop, and you're showing a subset of those rows for visual space economy reasons. Maybe there are use cases for that, but the first thing that comes to my mind when someone says "pagination" is something like a table of all pages on a wiki (of which there can be millions). In that case, pagination involves fetching the next N results from an API and putting them in the data prop. We could have the parent component just keep adding stuff to the data prop, but I'm concerned that that also has limitations if the user paginates many times (accumulating thousands of rows in the data prop) or if it's possible for the table to start in the middle and paginate backwards.

Thu, Feb 29, 5:55 PM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
Catrope closed T357596: Remove codex-search build as Resolved.
Thu, Feb 29, 4:17 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Technical-Debt, Design-System-Team, Codex
Catrope closed T357596: Remove codex-search build, a subtask of T349423: [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule, as Resolved.
Thu, Feb 29, 4:16 AM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
Catrope added a comment to T357695: Table: Investigate open implementation questions.

Re sorting I agree that #3 is the best approach for MVP, and possibly also the best approach long term. I think we should not pursue #1 given how complex it would be. We could do #2, but and we could consider that as a post-MVP thing, and we need to keep the door open for custom sorting regardless, because that's what we'll want in MediaWiki. One possible advantage of #2 is that we could allow the environment to provide() a default sorting function, which would allow for automagic tablesorter support in MediaWiki (meaning, if you put use a <cdx-table> component in a MediaWiki context and make it sortable, it will sort using MediaWiki's advanced sorting logic, without the developer having to do anything to make that happen).

Thu, Feb 29, 1:01 AM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex

Wed, Feb 28

Catrope added a comment to T358703: Make CSS-only Select icon work in night mode.

Some ideas:

  • Use background-blend-mode somehow, see T358513#9578928 and https://gerrit.wikimedia.org/r/1006946 for an initial exploration
  • Change the markup of the CSS-only Select component to something like <div class="cdx-select"><select> ... </select></div>, so that we can then use :after for the icon (or add a separate <span> for the icon). Avoid a breaking change by writing the styles such that they still work for the old markup, but without night mode support.
Wed, Feb 28, 6:18 PM · Patch-For-Review, Codex, Design-System-Team
Catrope moved T358513: CSS-only Select is almost invisible from Code Review to Pending Release on the Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)) board.

We decided that the background-blend-mode idea has too many problems. It requires a white background, and still doesn't work in night mode without further modifications (changing "lighten" to "darken" for example, and changing the icon's fill color to white). We may be able to work around these using even cleverer background-blend-mode tricks, but we decided not to pursue that for now. Instead, we decided to fix the immediate problem and make Select work again, even if that means it only works in day mode for now.

Wed, Feb 28, 6:13 PM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Regression
Catrope created T358703: Make CSS-only Select icon work in night mode.
Wed, Feb 28, 6:13 PM · Patch-For-Review, Codex, Design-System-Team
Catrope added a comment to T356677: Migrate uses of codex-search in Vector to use CodexModule.

I should also add: CodexModule doesn't currently deduplicate styles, that's T350056 (which is stalled currently). Some duplication may occur between Vector and other extensions, but we think that is outweighed by the fact that each extension will load only what it needs and no more; the fact that the duplicated components are likely to be small; and that most of those only load on certain pages or in certain circumstances. We're hoping to eventually solve the duplication problem, either through T350056 or another approach. If there's a situation where components are duplicated on every page, let us know and we'll see what we can do about it (it may change our attitude towards T350056 for example).

Wed, Feb 28, 6:03 PM · Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Desktop Improvements (Vector 2022)
Catrope added a comment to T356677: Migrate uses of codex-search in Vector to use CodexModule.

There are open tasks for migrating all of those, see T356675. If there's an intermediate state while some things are migrated but others aren't, then as you say both modules will be loaded together. Hopefully gzip will handle that reasonably well, but even if not, I think the short-term hit is fine as long as this intermediate state doesn't last too long.

Wed, Feb 28, 5:58 PM · Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Desktop Improvements (Vector 2022)
Catrope added a comment to T358631: Regex replacements are broken, insert duplicate replacements.

git bisect blames 29cf2b99d3d0166177f8605d2872df9794b9e4e2

Wed, Feb 28, 12:15 AM · Design-System-Team, MediaWiki-Platform-Team, Less.php
Catrope moved T358631: Regex replacements are broken, insert duplicate replacements from Inbox to Following on the Design-System-Team board.
Wed, Feb 28, 12:07 AM · Design-System-Team, MediaWiki-Platform-Team, Less.php
Catrope added a comment to T288498: Update less.php port to support Less.js 3.13 behaviours.

I can confirm that the bug I mentioned in T288498#9286018 is fixed in version 4.2.1 of Less.php.

Wed, Feb 28, 12:06 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, MediaWiki-Platform-Team, Less.php, Design-System-Team, Technical-Debt, MediaWiki-ResourceLoader
Catrope added a project to T358631: Regex replacements are broken, insert duplicate replacements: Design-System-Team.

This breaks Codex's CSS-only icons mixin. The following code:

@import 'mediawiki.skin.variables.less'; /* Outside MediaWiki, import codex-icons/codex-icon-paths.less and codex/mixins/css-icon.less */
Wed, Feb 28, 12:05 AM · Design-System-Team, MediaWiki-Platform-Team, Less.php

Tue, Feb 27

Catrope created T358631: Regex replacements are broken, insert duplicate replacements.
Tue, Feb 27, 11:56 PM · Design-System-Team, MediaWiki-Platform-Team, Less.php
Catrope added a comment to T358513: CSS-only Select is almost invisible.

I can't believe I found this but I found another solution that I think could work:

.cdx-select:enabled {
    /* Set the background for the whole select. --background-color-interactive-subtle: #eaecf0; */ 
    background-color: var( --background-color-interactive-subtle );
    /* Set the (pure black version of the) icon image as a background, with a solid background of the color we want the icon to be on top */
    /* --background-color-base: #202122; */
    background-image: linear-gradient( var( --background-color-base ), var( --background-color-base ) ), url('data:image/svg+xml;utf8,<svg fill="%23000000">...</svg>');
    /* Contain the image + overlay color to just the area where we want the icon to be */
    background-position: center right 12px;
    background-repeat: no-repeat;
    background-size: max( 0.75em, 12px );
    /* Magic: make the darker grey background blend into the icon so that it lightens the icon; but don't apply that same transformation between the icon and the overall background */
    background-blend-mode: lighten, normal;
}
Tue, Feb 27, 1:28 AM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Regression
Catrope added a comment to T353618: TextInput: Include "date" input type in Figma spec.

Note that there's also the "datetime-local" input time, which lets you put in a date and time. Some products (including Special:Block) may need to use that instead of a a date input.

image.png (320×412 px, 26 KB)

Tue, Feb 27, 12:28 AM · Design, Codex, Design-System-Team

Mon, Feb 26

Catrope updated the task description for T358062: Reduce output size of css-icon mixin.
Mon, Feb 26, 8:15 PM · Design-System-Team, Codex
Catrope added a comment to T358513: CSS-only Select is almost invisible.

This appears to have been caused by the change from background-image to mask-image for CSS-only icons. In particular, the Select component's use of the CSS-only icon mixin passes in center right 12px for the mask-position property; that was a valid value for background-position but is not for mask-position (in fact it seems mask-position doesn't accept pixel values at all).

Mon, Feb 26, 6:13 PM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Regression
Catrope added a comment to T358246: Icon: explore supporting custom non-embedded SVG URLs for CSS-only icons.

I've rewritten this task to reflect what I think Jan meant, as opposed to what he said :)

Mon, Feb 26, 5:51 PM · Design-System-Team, Codex
Catrope renamed T358246: Icon: explore supporting custom non-embedded SVG URLs for CSS-only icons from Icon: explore removing utf-8 encoding for CSS icon URLs to Icon: explore supporting custom non-embedded SVG URLs for CSS-only icons.
Mon, Feb 26, 5:51 PM · Design-System-Team, Codex
Catrope renamed T358068: Minerva uses Codex css-icon mixin with custom icons in an unsupported way, causing bloated and invalid CSS from Minerva uses Codex css-icon mixin with custom icons in an unsupported way, causing bugs and bloat to Minerva uses Codex css-icon mixin with custom icons in an unsupported way, causing bloated and invalid CSS.
Mon, Feb 26, 5:43 PM · Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MinervaNeue
Catrope closed T356542: Integrate Codex's experimental CSS variables-based styles into MediaWiki as Resolved.
Mon, Feb 26, 5:33 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Codex
Catrope closed T356542: Integrate Codex's experimental CSS variables-based styles into MediaWiki, a subtask of T356537: Release experimental styles and CSS variable set of Codex design tokens for use in MediaWiki, as Resolved.
Mon, Feb 26, 5:33 PM · MediaWiki-General, Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), CSS, Codex
Catrope created T358513: CSS-only Select is almost invisible.
Mon, Feb 26, 5:29 PM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Regression

Fri, Feb 23

Catrope added a comment to T355842: Remove themeStyles support from CodexModule.

Looks like it's not that bad: there are no errors, the themeStyles VueTest specifies just aren't being applied. This breaks the styles for most components (see https://en.wikipedia.beta.wmflabs.org/wiki/Special:VueTest/codex and scroll to Card or Checkbox; the Button styles are still there because the Vector search pulls them in), and as a consequence there's a lot of red on https://pixel.wmcloud.org/reports/codex/index.html , but we weren't actively using those anyway.

Fri, Feb 23, 7:02 PM · Design-System-Team, Codex
Catrope closed T355842: Remove themeStyles support from CodexModule as Resolved.

This was accidentally done as part of the change for T355842. This will break VueTest because of T355841, which may have broken Pixel -- we'll have to address that.

Fri, Feb 23, 6:12 PM · Design-System-Team, Codex
Catrope closed T355842: Remove themeStyles support from CodexModule, a subtask of T349423: [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule, as Resolved.
Fri, Feb 23, 6:12 PM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
Catrope closed T355840: Code splitting: use CodexModule for the full library modules (@wikimedia/codex and codex-styles), a subtask of T355842: Remove themeStyles support from CodexModule, as Resolved.
Fri, Feb 23, 2:05 AM · Design-System-Team, Codex
Catrope closed T355840: Code splitting: use CodexModule for the full library modules (@wikimedia/codex and codex-styles) as Resolved.
Fri, Feb 23, 2:05 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex

Thu, Feb 22

Catrope added a comment to T358059: Use Codex experimental build in Minerva to allow codex components to appear in night mode.

If you need Codex to produce the list of variables without them being wrapped in a :root {} block, we may be able to do that. I think we may need to do something like that anyway in the near future, since we plan to put the night mode color palette in the codex-design-tokens package and have Minerva import those values from there, rather than putting those values in Minerva itself.

Thu, Feb 22, 5:20 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 4), MinervaNeue
Catrope updated the task description for T358038: Discuss how to handle font-size tokens in different skins with different base font sizes.
Thu, Feb 22, 12:35 AM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex
Catrope updated the task description for T358038: Discuss how to handle font-size tokens in different skins with different base font sizes.
Thu, Feb 22, 12:35 AM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex

Wed, Feb 21

Catrope renamed T358038: Discuss how to handle font-size tokens in different skins with different base font sizes from PLACEHOLDER: Discuss how to handle font-size tokens in different skins with different base font sizes to Discuss how to handle font-size tokens in different skins with different base font sizes.
Wed, Feb 21, 1:16 AM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex
Catrope updated the task description for T358068: Minerva uses Codex css-icon mixin with custom icons in an unsupported way, causing bloated and invalid CSS.
Wed, Feb 21, 12:11 AM · Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MinervaNeue
Catrope created T358069: Support custom icons in CSS icon mixin.
Wed, Feb 21, 12:10 AM · Design-System-Team, Codex
Catrope created T358068: Minerva uses Codex css-icon mixin with custom icons in an unsupported way, causing bloated and invalid CSS.
Wed, Feb 21, 12:08 AM · Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MinervaNeue

Tue, Feb 20

Catrope created T358062: Reduce output size of css-icon mixin.
Tue, Feb 20, 11:27 PM · Design-System-Team, Codex
Catrope edited projects for T358038: Discuss how to handle font-size tokens in different skins with different base font sizes, added: Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)); removed Design-System-Team.
Tue, Feb 20, 6:47 PM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex
Catrope created T358038: Discuss how to handle font-size tokens in different skins with different base font sizes.
Tue, Feb 20, 6:44 PM · Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex
Catrope moved T358032: [PLACEHOLDER] Put night mode color palette in Codex from Inbox to Up Next on the Design-System-Team board.
Tue, Feb 20, 6:26 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex
Catrope created T358032: [PLACEHOLDER] Put night mode color palette in Codex.
Tue, Feb 20, 6:26 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex
Catrope reopened T355841: Remove use of themeStyles in VueTest as "Open".

Reopening so that we can consider doing this as a faster way to unblock T355842 (rather than blocking that task on the full decommissioning of VueTest).

Tue, Feb 20, 5:59 PM · Design-System-Team, Patch-For-Review, Technical-Debt, VueTest
Catrope edited projects for T355841: Remove use of themeStyles in VueTest, added: Design-System-Team; removed Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)).
Tue, Feb 20, 5:57 PM · Design-System-Team, Patch-For-Review, Technical-Debt, VueTest
Catrope moved T355841: Remove use of themeStyles in VueTest from Inbox to Up Next on the Design-System-Team board.
Tue, Feb 20, 5:57 PM · Design-System-Team, Patch-For-Review, Technical-Debt, VueTest
Catrope reopened T355841: Remove use of themeStyles in VueTest, a subtask of T355842: Remove themeStyles support from CodexModule, as Open.
Tue, Feb 20, 5:57 PM · Design-System-Team, Codex

Sat, Feb 17

Catrope assigned T357324: InfoChip: Add CSS-only version to cscott.
Sat, Feb 17, 2:04 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex
Catrope added a comment to T350946: Lookup: Option to open menu when field is focused.

Also keep in mind that the Menu Header (to use in the "Suggested items") is not implemented a Codex menu variant yet T305036: Menu: Support headers for grouping options.

The current demo just fakes this, the "Suggested items" header is actually just a disabled menu item.

Sat, Feb 17, 2:00 AM · Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Design, Codex
Catrope changed the status of T356511: CodexModuleTest: add unit testing for getComponentFiles from Open to Stalled.

Marking this as stalled while T350056 is stalled; if and when we decide to move forward with T350056, this task will become relevant again.

Sat, Feb 17, 1:56 AM · Design-System-Team, Test-Coverage
Catrope changed the status of T356511: CodexModuleTest: add unit testing for getComponentFiles, a subtask of T349423: [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule, from Open to Stalled.
Sat, Feb 17, 1:56 AM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
Catrope changed the status of T350056: Code splitting: dependency deduplication of CodexModule from In Progress to Stalled.

@egardner and I discussed this some more, and I've filed T357836 for exploring another potential solution. For the time being, this task is stalled, while we figure out whether the dependency deduplication is an approach we want to go with or not.

Sat, Feb 17, 1:56 AM · Design-System-Team, Patch-For-Review, Codex
Catrope moved T357165: docs: Fix mobile nav font-size from Code Review to Pending Release on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.
Sat, Feb 17, 1:55 AM · Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Design, Documentation, Codex
Catrope moved T350056: Code splitting: dependency deduplication of CodexModule from Code Review to Blocked ⛔ on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.
Sat, Feb 17, 1:55 AM · Design-System-Team, Patch-For-Review, Codex
Catrope changed the status of T350056: Code splitting: dependency deduplication of CodexModule, a subtask of T349423: [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule, from In Progress to Stalled.
Sat, Feb 17, 1:54 AM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
Catrope added a comment to T357836: [Spike] Explore one-module-per-component approach to code splitting.

Another issue with this approach that we'd have to explore in a prototype is how dependencies between style modules would work. These dependencies would be handled correctly when these modules are loaded in the normal, non-render-blocking way (through addModules() or as the dependencies of other modules), but addModuleStyles() does not consider dependencies (intentionally, see T191652#4117599). So calling addModuleStyles() on a module that uses CodexModule to pull in styles for various Codex components would not work, and trying to make it work would require solving the caching-related issues presented in T191652#4117599.

Sat, Feb 17, 1:53 AM · Design-System-Team, Codex
Catrope moved T357836: [Spike] Explore one-module-per-component approach to code splitting from Inbox to Up Next on the Design-System-Team board.
Sat, Feb 17, 1:53 AM · Design-System-Team, Codex
Catrope updated the task description for T357836: [Spike] Explore one-module-per-component approach to code splitting.
Sat, Feb 17, 1:47 AM · Design-System-Team, Codex

Fri, Feb 16

Catrope created T357836: [Spike] Explore one-module-per-component approach to code splitting.
Fri, Feb 16, 11:09 PM · Design-System-Team, Codex
Catrope updated the task description for T352308: Port remaining files to jsdoc in MediaWiki core.
Fri, Feb 16, 4:11 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), JSDoc WMF theme, Patch-For-Review, MediaWiki CodeJam Dec 2023, Tech-Docs-Team, Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation
Catrope added a comment to T356542: Integrate Codex's experimental CSS variables-based styles into MediaWiki.

@Catrope if you update to use this Codex patch to produce the experimental output, you'll get an RTL experimental stylesheet.

Thanks! I will update MW core patch once the new Codex patch is updated to reinstate CSS vars for filter-invert-icon, filter-invert-primary-button-icon and opacity-icon-base

Fri, Feb 16, 12:20 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Codex

Thu, Feb 15

Catrope added a comment to T350056: Code splitting: dependency deduplication of CodexModule.

I'm less worried about missing Codex components and more worried about teams not coordinating well when one team's module depends on another's and then the first module gets moved, has its name changed, or even gets removed entirely. Then the second module won't load at all.

Guidelines that state (for now at least) that teams should not create dependency relationships on modules they do not maintain in order to use this feature would go a long way to mitigating this risk IMO.

I agree. Don't depend on random modules, depend on ones that either you maintain yourself, or that make a clear commitment that they'll stick around.

Thu, Feb 15, 7:57 PM · Design-System-Team, Patch-For-Review, Codex
Catrope added a comment to T356542: Integrate Codex's experimental CSS variables-based styles into MediaWiki.

Testing instructions:

  • Install MinervaNeue if you haven't already
  • In MW core, run git review -d 1003572
  • In MinervaNeue, run git review -d 1003573
  • Go to http://localhost:8080/wiki/Special:CodexExample?minervanightmode=1
  • Note that night mode applies to Codex components (e.g. tab labels are white, icon in Card is white)
  • Any changes made to color token values in CSSCustomProperties.less in Minerva apply to Codex components too
Thu, Feb 15, 12:47 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Codex
Catrope moved T356542: Integrate Codex's experimental CSS variables-based styles into MediaWiki from In Progress to Code Review on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.
Thu, Feb 15, 12:45 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Codex

Wed, Feb 14

Catrope moved T357596: Remove codex-search build from Inbox to Up Next on the Design-System-Team board.
Wed, Feb 14, 11:36 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Technical-Debt, Design-System-Team, Codex
Catrope created T357596: Remove codex-search build.
Wed, Feb 14, 11:35 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Technical-Debt, Design-System-Team, Codex
Catrope moved T356537: Release experimental styles and CSS variable set of Codex design tokens for use in MediaWiki from Blocked ⛔ to Committed on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.
Wed, Feb 14, 11:26 PM · MediaWiki-General, Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), CSS, Codex
Catrope moved T355716: Change jquery.ui ResourceLoader deprecation warning to point to Codex from In Progress to Code Review on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.
Wed, Feb 14, 11:25 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Patch-For-Review, MediaWiki-Platform-Team (Radar), MediaWiki-Documentation, Technical-Debt, MediaWiki-ResourceLoader
Catrope moved T357173: docs: Sidebar menu navigation clashes with header on mobile from In Progress to Code Review on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.
Wed, Feb 14, 11:25 PM · Design-System-Team, Design, Documentation, Codex
Catrope moved T357165: docs: Fix mobile nav font-size from In Progress to Code Review on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.
Wed, Feb 14, 11:24 PM · Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Design, Documentation, Codex
Catrope changed the status of T356542: Integrate Codex's experimental CSS variables-based styles into MediaWiki from Open to In Progress.
Wed, Feb 14, 11:22 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Codex
Catrope moved T356542: Integrate Codex's experimental CSS variables-based styles into MediaWiki from Committed to In Progress on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.
Wed, Feb 14, 11:22 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Codex
Catrope changed the status of T356542: Integrate Codex's experimental CSS variables-based styles into MediaWiki, a subtask of T356537: Release experimental styles and CSS variable set of Codex design tokens for use in MediaWiki, from Open to In Progress.
Wed, Feb 14, 11:22 PM · MediaWiki-General, Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), CSS, Codex
Catrope moved T350946: Lookup: Option to open menu when field is focused from In Progress to Pending Release on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.

This is brilliant, thank you for this excellent idea @AnneT! It's the best of both worlds, because:

  • It doesn't add an ugly boolean prop that toggles the behavior; instead it uses the presence/absence of initial menu items as a proxy for this
  • Old code keeps working the way it did, even if it doesn't clear the menuItems when the input is cleared (except if it sets menuItems to a non-empty array initially, but nobody does that currently)
  • New code intending to use this feature is written in an intuitive way, and looks exactly the same as it would if we had implemented my suggestions
  • New code that doesn't want to use this feature still has an intuitive path to doing so, because it set menuItems to empty initially and then populate it when something is typed, and/or clear menuItems when it wants to hide the menu
Wed, Feb 14, 10:57 PM · Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Design, Codex
Catrope added a comment to T350056: Code splitting: dependency deduplication of CodexModule.

I am concerned that introducing a bunch of new dependency relationships between ResourceLoader modules (which would not otherwise exist)

I think that if this feature is merged, it should come with guidelines for when it's appropriate to use it. Off the top of my head, that would be:

  • Dependencies between modules in the same extension/skin/feature
  • If we create a module in MW core with common/"core" Codex components that we expect almost every feature will use, then it would be appropriate for any Codex-using module to depend on that "core components" module
Wed, Feb 14, 12:39 AM · Design-System-Team, Patch-For-Review, Codex

Tue, Feb 13

Catrope added a comment to T357164: Standardize use of @description and @classdesc.

I think this is generally worthwhile, because the current state of things is confusing. It looks like the main body of the doc comment is interpreted as the documentation for the constructor, and only the @classdesc is interpreted as the documentation for the class. In most cases I think the text in the main body of the doc comment is intended to be about the class, not the constructor.

Tue, Feb 13, 11:53 PM · Patch-For-Review, JSDoc WMF theme
Catrope updated the task description for T357475: Decommission the VueTest Extension.
Tue, Feb 13, 10:21 PM · Projects-Cleanup, Design-System-Team
Catrope updated the task description for T357475: Decommission the VueTest Extension.
Tue, Feb 13, 10:20 PM · Projects-Cleanup, Design-System-Team

Mon, Feb 12

Catrope added a comment to T356465: [Spike] Determine how to Codex should support different themes/modes.

I think the reorganization you've proposed in your proof of concept makes sense. I'd recommend not calling the decision layer theme.json though..."theme" is a confusing word and you could argue that it's better applied to the options layer as it currently is. Instead, I'd let the decision file remain codex-base.json, and in the future we can add codex-night.json etc. (although I also like the single-file approach proposed by Danny Banks). I do like the rename of theme-wikimedia-ui.json to options.json.

Mon, Feb 12, 8:06 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Patch-For-Review, Epic
Catrope moved T356103: Natural space between icon and button text is lost in MinervaNeue from Code Review to Pending Release on the Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)) board.
Mon, Feb 12, 7:07 PM · Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)), Codex

Fri, Feb 9

Catrope closed T347107: Explore pointing Pixel to the standalone Codex sandbox as Resolved.

This task was filed as an exploration, and that exploration is now done. I've filed T357185: Set up Pixel testing for the Codex sandbox for productionizing the locally built sandbox approach.

Fri, Feb 9, 10:59 PM · Patch-For-Review, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Codex
Catrope moved T357185: Set up Pixel testing for the Codex sandbox from Inbox to Up Next on the Design-System-Team board.
Fri, Feb 9, 10:58 PM · Codex, Web Team Visual Regression Framework, Design-System-Team
Catrope moved T357185: Set up Pixel testing for the Codex sandbox from Inbox to Infrastructure on the Codex board.
Fri, Feb 9, 10:58 PM · Codex, Web Team Visual Regression Framework, Design-System-Team
Catrope created T357185: Set up Pixel testing for the Codex sandbox.
Fri, Feb 9, 10:58 PM · Codex, Web Team Visual Regression Framework, Design-System-Team
Catrope added a comment to T347107: Explore pointing Pixel to the standalone Codex sandbox.

Remaining issues with this proof of concept:

  • -b latest-release doesn't work, because it attempts to check out the wmf/1.42.0-wmf.17 branch in the Codex repo, which doesn't exist. We want latest-release to mean the latest Codex release instead.
  • As a consequence, runAll doesn't work, which is why this needs to be fixed before this PR can be merged.
Fri, Feb 9, 10:54 PM · Patch-For-Review, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Codex
Catrope closed T356913: Support dots in module names as Resolved.
Fri, Feb 9, 10:33 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Patch-For-Review, JSDoc WMF theme
Catrope added a comment to T357180: Exclude 404 results from search index.

What seems to be the issue for the members of mediawiki.special.apisandbox specifically is that the class is marked as @private, but its members are not individually marked as private. Somehow jsdoc either doesn't propagate that private-ness from the class to its members, or we're not looking for it the right way.

Fri, Feb 9, 9:52 PM · JSDoc WMF theme

Tue, Feb 6

bd808 awarded T356470: Migrate ApiSandbox from OOUI to Codex a Love token.
Tue, Feb 6, 12:40 AM · Wikimedia-Hackathon-2024, MediaWiki-User-Interface

Mon, Feb 5

Catrope added a comment to T347107: Explore pointing Pixel to the standalone Codex sandbox.

Instructions for how to use this proof of concept:

Mon, Feb 5, 7:54 PM · Patch-For-Review, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Codex
Catrope updated the task description for T356675: Deprecate the codex-search modules and migrate away from them.
Mon, Feb 5, 6:55 PM · Design-System-Team, Codex
Catrope created T356691: Migrate uses of codex-search in UniversalLanguageSelector to use CodexModule.
Mon, Feb 5, 6:53 PM · UniversalLanguageSelector
Catrope created T356690: Migrate uses of codex-search in Popups to use CodexModule.
Mon, Feb 5, 6:51 PM · Page-Previews
Catrope created T356689: Migrate uses of codex-search in MultimediaViewer to use CodexModule.
Mon, Feb 5, 6:50 PM · MediaViewer