Page MenuHomePhabricator

Catrope (Roan Kattouw)
Growth team lead

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 8:32 PM (257 w, 6 d)
Availability
Available
IRC Nick
RoanKattouw
LDAP User
Catrope
MediaWiki User
Roan Kattouw (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Catrope added a comment to T230653: Use a parser function to encapsulate signatures.

Is there any reason you proposed {{#~|user|date}} as opposed to {{#~:user|date}}? The latter would be implementable in an extension without parser modifications, by registering a parser function named ~. I understand the reasoning behind naming the parser function ~ instead of sig or something, so that it doesn't have to be localized, but was the colon-vs-pipe thing deliberate or an oversight?

Tue, Sep 17, 3:51 PM · OWC2020, MediaWiki-Parser

Sat, Sep 14

Catrope claimed T232419: Newcomer tasks: suggested edits initiation and overlays.
Sat, Sep 14, 12:37 AM · Patch-For-Review, GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T232548: Homepage: remove question-asking from help module from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Sat, Sep 14, 12:34 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), GrowthExperiments-Homepage, GrowthExperiments-HelpModule, Growth-Team (Current Sprint)

Fri, Sep 13

Catrope moved T232400: Newcomer tasks: welcome survey changes from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Sep 13, 11:26 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope claimed T232400: Newcomer tasks: welcome survey changes.
Fri, Sep 13, 10:11 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), GrowthExperiments-Homepage

Wed, Sep 11

Catrope claimed T232548: Homepage: remove question-asking from help module.
Wed, Sep 11, 10:20 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), GrowthExperiments-Homepage, GrowthExperiments-HelpModule, Growth-Team (Current Sprint)

Tue, Sep 10

Catrope moved T232549: Start module rendering broken in Safari 10 on desktop from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Tue, Sep 10, 11:27 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T232549: Start module rendering broken in Safari 10 on desktop from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Tue, Sep 10, 11:00 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope claimed T232549: Start module rendering broken in Safari 10 on desktop.
Tue, Sep 10, 11:00 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope created T232549: Start module rendering broken in Safari 10 on desktop.
Tue, Sep 10, 10:59 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T230629: Start module (overlay and server-side rendered view) layout broken in Firefox.

Unfortunately my first attempt at this patch did regress (un-fix) T225668, but I've now found a way to fix both. Thanks @Etonkovidova for verifying.

Tue, Sep 10, 10:56 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T230629: Start module (overlay and server-side rendered view) layout broken in Firefox from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Tue, Sep 10, 9:00 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T230629: Start module (overlay and server-side rendered view) layout broken in Firefox.

This patch doesn't regress the fix for T225668 on my iOS 11 test device, but since that bug was reported against iOS 10, we should test it on iOS 10 before merging. It doesn't make much sense to fix the mobile site on Firefox while breaking it in iOS Safari, because the latter has way higher market share on mobile.

Tue, Sep 10, 8:47 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T230629: Start module (overlay and server-side rendered view) layout broken in Firefox.

As @kostajh correctly pointed out, the display: block rule (overriding display: flex) on the module divs added by rEGRE6b461b1c3a10: Start: fix iOS 10 layout issue is what causes this. But removing that rule presumably regresses the iOS bug that it was fixing, so I'm not sure if there's a way to fix both. I'll try.

Tue, Sep 10, 6:41 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope claimed T230629: Start module (overlay and server-side rendered view) layout broken in Firefox.

Even when viewing the mobile start module without device emulation, it looks pretty messed up in Firefox:

Tue, Sep 10, 6:33 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage

Fri, Sep 6

Catrope moved T230798: GrowthExperiments should log exceptions on the exception channel from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Sep 6, 9:03 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Growth-Team (Current Sprint), GrowthExperiments

Wed, Sep 4

Catrope added a comment to T231956: makedeploynotes.py omits some changes for no apparent reason.

As a consequence, all of these changes are missing from https://www.mediawiki.org/wiki/MediaWiki_1.34/wmf.21#Core_changes

Wed, Sep 4, 12:57 AM · MediaWiki-Release-Tools
Catrope created T231956: makedeploynotes.py omits some changes for no apparent reason.
Wed, Sep 4, 12:57 AM · MediaWiki-Release-Tools

Tue, Sep 3

Catrope moved T231935: GrowthExperiments not loading extension.json properly from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Sep 3, 11:58 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Growth-Team (Current Sprint), GrowthExperiments
Catrope moved T225562: Deploy ORES filters for zhwiki from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Sep 3, 11:30 PM · Growth-Team (Current Sprint), Chinese-Sites, artificial-intelligence, Edit-Review-Improvements-Integrated-Filters, editquality-modeling, Scoring-platform-team
Catrope added a comment to T231701: Opening mentorship module on mobile throws JS error if it lists a question that's more than 30 days old.

Yes, sorry for causing confusion by reopening that bug without closing this one.

Tue, Sep 3, 9:58 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T230716: Show most recent question in overlay immediately after tapping "Done" from Ready for Development to QA on the Growth-Team (Current Sprint) board.

This was fixed by the fix for T229271, and should start working once the "ask a question" buttons start working again (i.e. when https://gerrit.wikimedia.org/r/534238 is merged).

Tue, Sep 3, 9:29 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T225562: Deploy ORES filters for zhwiki.

Scheduled for deployment in today's evening SWAT window (23:00-00:00 UTC)

Tue, Sep 3, 6:50 PM · Growth-Team (Current Sprint), Chinese-Sites, artificial-intelligence, Edit-Review-Improvements-Integrated-Filters, editquality-modeling, Scoring-platform-team
Catrope updated subscribers of T231866: Circular dependency when creating service! ContentLanguage.

All these dependencies make (some) sense, except ContentLanguage depending on ResourceLoader, which doesn't make sense.

Tue, Sep 3, 5:58 PM · Core Platform Team Workboards (Clinic Duty Team), Performance-Team, MediaWiki-ResourceLoader, Gadgets, MediaWiki-ServiceContainer
Catrope committed rEGRA349fcc5fbd88: Fix array vs object access (authored by Catrope).
Fix array vs object access
Tue, Sep 3, 4:25 PM
Catrope added a comment to T225941: Homepage: update "posted on" timestamp client-side when overlay is opened.

See also T231701 for why this was reverted.

Tue, Sep 3, 4:20 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
Catrope moved T225941: Homepage: update "posted on" timestamp client-side when overlay is opened from Needs PM Review to Ready for Development on the Growth-Team (Current Sprint) board.
Tue, Sep 3, 4:19 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
Catrope reopened T225941: Homepage: update "posted on" timestamp client-side when overlay is opened, a subtask of T215983: Homepage: mobile version, as Open.
Tue, Sep 3, 4:18 PM · Patch-For-Review, Epic, GrowthExperiments-Homepage, Mobile, Growth-Team (Current Sprint)
Catrope reopened T225941: Homepage: update "posted on" timestamp client-side when overlay is opened as "Open".

The patch was reverted by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/533620 because it crashed for comments more than 30 days old.

Tue, Sep 3, 4:18 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
Catrope committed rEGRAd0caddbd29b5: Fix array vs object access (authored by Catrope).
Fix array vs object access
Tue, Sep 3, 4:07 PM

Sat, Aug 31

Catrope created T231701: Opening mentorship module on mobile throws JS error if it lists a question that's more than 30 days old.
Sat, Aug 31, 12:28 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Growth-Team (Current Sprint), GrowthExperiments-Homepage

Fri, Aug 30

Catrope added a comment to T107610: Setup separate logical External Store for Flow in production.

Or do we want one table that's shared by all wikis? That would make Flow's existing cross-wiki architecture not be broken if something ever tries to actually use it.

Fri, Aug 30, 4:23 PM · Growth-Team (Current Sprint), DBA, Operations, WorkType-Maintenance, Collaboration-Team-Triage, StructuredDiscussions
Catrope claimed T231561: ApiQueryMapData.php: Call to a member function getData() on null.
Fri, Aug 30, 4:21 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Maps (Kartographer), Wikimedia-production-error
Catrope added a comment to T226130: Display notification text for incoming notification.
  • Clicking the notification doesn't do anything. Ideally (@Catrope or @Mooeypoo might have other preferences for this), clicking the notification would open up the notifications panel

Yes, I think opening the notification panel when the little notification bubble is clicked would be a good idea.

Fri, Aug 30, 4:13 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Google-Summer-of-Code (2019), Growth-Team, Notifications

Wed, Aug 28

Catrope updated subscribers of T106363: Migrate Flow content to new separate logical External Store in production.

I discussed this a little bit with @kostajh and @Tgr. Summarizing my comments here.

Wed, Aug 28, 10:24 AM · Growth-Team, TechCom, Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), WorkType-Maintenance, Patch-For-Review, StructuredDiscussions, Collaboration-Team-Sprint-E-Everywhere-2015-07-14

Tue, Aug 27

Catrope moved T220447: Split out or remove Special:Contributions/newbies functionality from Archive to Announce in next Tech/News on the User-notice board.
Tue, Aug 27, 7:42 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), User-notice, Advanced Mobile Contributions, MediaWiki-Special-pages
Catrope added a comment to T231245: Search and replace leaves bogus text highlight at the end.

It seems likely that that bug has the same root cause as this one.

Tue, Aug 27, 7:41 PM · VisualEditor
Catrope added a comment to T218555: Provide access to WebRequest and associated information via a service object.

getRequestedLanguage(): get the code of the requested output language. Based on the user's preferences, but may be overwritten per request. Avoid binding against the heavy Language class, though.
getRequestedSkin(): get the name of the requested skin. Based on the user's preferences, but may be overwritten per request. Avoid binding against the heavy Skin class, though.

What's the benefit of not binding against Language/Skin? There should probably be some sort of global-ish way to instantiate these and share/reuse those instances, because having to call Language::factory( $context->getRequestedLanguage() ) in 100 places would be very annoying and also inefficient.

Tue, Aug 27, 4:35 PM · TechCom, MediaWiki-ServiceContainer, CPT Initiatives (Decoupling (CDP2))

Mon, Aug 26

Krinkle awarded T215665: Emailability: Improve verification email a Orange Medal token.
Mon, Aug 26, 7:20 PM · Growth-Team, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), GrowthExperiments
Krinkle awarded T229271: [wmf.15-mobile] Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined' a Orange Medal token.
Mon, Aug 26, 7:11 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope created T231245: Search and replace leaves bogus text highlight at the end.
Mon, Aug 26, 7:01 PM · VisualEditor

Wed, Aug 21

Catrope added a comment to T227776: Generalize ParserCache into a generic service class for large "current" page-derived data.

This discussion inspired me to write patches for Graph and Kartographer that make their API modules retrieve the graph/map JSON blobs from the ParserOutput object in the parser cache, rather than from the page_props table. This avoids issues with gzipping the data stored in the page_props table and it getting truncated if it's too large despite that. See also T98940 and T119043.

Wed, Aug 21, 8:19 PM · User-mobrovac, CPT Initiatives (Parsoid PHP (CDP2)), TechCom, User-Daniel, Proposal
Catrope added a comment to T218839: [minor] HelpPanel logs incorrect events for protected pages.

And in case (2), I agree that we should show the help panel as normal, and fix whatever instrumentation bug is causing the events to be logged incorrectly. Many popular articles are semi-protected (require 10 edits and 4 days, or some variant thereof) and some are fully-protected (only admins can edit), so it would be pretty normal for a newcomer to try to edit a protected page.

Wed, Aug 21, 7:57 PM · GrowthExperiments-Help panel, Growth-Team (Current Sprint)
Catrope added a comment to T218839: [minor] HelpPanel logs incorrect events for protected pages.

Re case (1): if the user is blocked sitewide, they also won't be able to post on the help desk, because a sitewide block blocks them from editing any page (except their own user talk page). If the user is subject to a partial block, they may or may not be able to post on the help desk depending on the details of the block (and also, a partial block that blocks them from the help desk may not block them from editing the page they're currently on!).

Wed, Aug 21, 7:40 PM · GrowthExperiments-Help panel, Growth-Team (Current Sprint)
Catrope added a comment to T230953: Why is jawiki's goodfaith model so bad?.

(While you're at it, the damaging model isn't great either: it's not able to identify damaging edits with 60% precision or higher.)

Wed, Aug 21, 7:39 PM · artificial-intelligence, editquality-modeling, Scoring-platform-team
Catrope added a comment to T225563: Deploy ORES filters for jawiki.

Have you seen anything like that before?

I have, and in the past it's been tracked down to extremely skewed inputs from the labeling campaign. I think the first version of the arwiki goodfaith model was built from a data set that had <1% of the edits labeled as bad faith.

Wed, Aug 21, 7:20 PM · Growth-Team (Current Sprint), artificial-intelligence, Edit-Review-Improvements-Integrated-Filters, editquality-modeling, Scoring-platform-team
Catrope committed rEGRA193279179584: Stop storing gzipped JSON blobs in page_props (authored by Catrope).
Stop storing gzipped JSON blobs in page_props
Wed, Aug 21, 6:02 PM
Catrope added a project to T230927: AMC Outreach Drawer encouraging me to turn on advanced mode sends me from Special:Homepage to my user page: Advanced Mobile Contributions.
Wed, Aug 21, 1:36 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, MobileFrontend
Catrope created T230927: AMC Outreach Drawer encouraging me to turn on advanced mode sends me from Special:Homepage to my user page.
Wed, Aug 21, 1:35 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, MobileFrontend
Catrope assigned T230831: Convert GrowthExperiments-* project to subprojects of GrowthExperiments to JTannerWMF.

I think subprojects is the best way to go here. @JTannerWMF agreed to do this.

Wed, Aug 21, 12:06 PM · Growth-Team (Current Sprint), Phabricator, Project-Admins

Tue, Aug 20

Catrope closed T230740: wpSummary: A random browser extension sets it to autocomplete="off" as Invalid.

There's no real connection, as far as I can see, between XSS and personal information, or between XSS and autocomplete. I don't understand why a browser extension trying to prevent XSS would disable autocomplete. The default value for autocomplete is on, and it makes little sense to explicitly set autocomplete="on" on almost all form fields. In addition, MediaWiki already sets autocomplete="on" on almost every <form> it generates, so there's no reason to also set it on each field (except for browser extensions messing with things, but I don't think it makes sense to design around those).

Tue, Aug 20, 2:06 PM · MediaWiki-Page-editing
Catrope added a comment to T98940: graphoid fails if page_props is out of sync with parser cache, or on old revisions of a page.

@Catrope thanks for tackling it! I always thought parser cache is non-persisted, so if a page does not get any edits in 2 months, the relevant data might not be there?

Tue, Aug 20, 11:46 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Graphoid

Aug 18 2019

Catrope added a comment to T119043: Graph/Graphoid/Kartographer - data storage architecture.
Aug 18 2019, 11:15 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Patch-For-Review, Product-Infrastructure-Team-Backlog, Services (watching), Maps (Kartographer), TechCom-RFC, Graphoid, Graphs, Service-Architecture, RESTBase-architecture
Catrope added a comment to T98940: graphoid fails if page_props is out of sync with parser cache, or on old revisions of a page.

This patch doesn't fully address this issue, but it makes the API module pull the graph data from the parser cache (where it was already being stored) rather than from the page_props table. However, this still has the API module using the ParserCache entry for the canonical ParserOptions, and it's possible to construct pages (most of them pathological examples, but some real-world ones) that have graph JSON that vary on the ParserOptions. So we might still want a way to access hash->definition mappings for hashes that appear in a non-canonical rendering of the latest revision of a page. Perhaps we could encode the ParserOptions in the Graphoid URL, or have some other way of identifying which parser cache entry to use.

Aug 18 2019, 11:14 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Graphoid

Aug 17 2019

Catrope added a comment to T229726: Activate Kartographer in Georgian wikipedia.

Yes, combining Kartographer with FlaggedRevsOverride causes some problems. We'll still enable Kartographer on your wiki if you want it, but you should know about this bug so that you can make an informed decision.

Aug 17 2019, 10:06 AM · User-Urbanecm, Wikimedia-Site-requests

Aug 16 2019

Catrope assigned T230355: Homepage: icons alignment issue in mobile Start module dialog to JTannerWMF.

Setting this one aside for Jazmin to work on over the Wikimania hackathon

Aug 16 2019, 2:32 PM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage

Aug 15 2019

Catrope closed T215106: Enlarging the default thumb size on Dutch Wikipedia as Resolved.

I null edited https://nl.wikipedia.org/wiki/1870-1879 , and the photo of Aletta Jacobs changed from 220px to 260px. Unfortunately a null edit is required to trigger the update, a purge is not sufficient. That's OK though, removing the largethumb template from an article would also involve editing it.

Aug 15 2019, 3:55 PM · serviceops-radar, Wikimedia-Hackathon-2019, Performance-Team (Radar), Patch-For-Review, Wikimedia-Site-requests
Catrope added a comment to T215106: Enlarging the default thumb size on Dutch Wikipedia.

@Krinkle, @Ciell and I discussed this at Wikimania, and we decided that it would be best not to remove 200 and instead just change 250 to 260. That way the default size index changes (from 4 to 5), but that's less disruptive than what would happen if we removed 200 in the middle: someone whose preference was e.g. 300 would see it change to 400, and I don't even know what would happen to users whose default was 400 (their size index would become invalid).

Aug 15 2019, 12:04 PM · serviceops-radar, Wikimedia-Hackathon-2019, Performance-Team (Radar), Patch-For-Review, Wikimedia-Site-requests

Aug 14 2019

Catrope added a comment to T230370: Homepage: size issue with mentor's username in mobile mentor module preview and dialog.

Should this change be made only on mobile, or only on desktop?

Aug 14 2019, 12:42 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T230377: Homepage: text size issue of pageviews number in Impact module.

This task is only for mobile, but the CSS rule would apply to both mobile and desktop. Should this change be made for both mobile and desktop? It seems to me that the ratio between the font size of the number and the font size of the text to the left of it should be consistent between desktop and mobile (right now it's 1:1 on both).

Aug 14 2019, 12:41 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Desktop, Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T230373: Homepage: mentor text style issues in mobile Mentorship module dialog.

There's a letter-spacing: 0.02em rule on these because you asked for it here: T218966#5130398

Aug 14 2019, 12:25 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T230375: Homepage: text style issues in recent questions list of mobile mentor and help module dialogs.

You asked for both the font-size: 0.85em and letter-spacing: 0.02em rules here: T218966#5130398.

Aug 14 2019, 12:22 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T230364: Homepage: light text style tracking issue in mobile homepage module previews.

There's a letter-spacing: 0.02em rule on these because you asked for it here: T218966#5130398

Aug 14 2019, 12:18 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage

Aug 13 2019

Catrope added a comment to T230246: Newcomer tasks: investigate task types.

Specifically, I think it would be good to sketch out how we would implement some of these things (at least "maintenance template" and "newest articles", as you say), and especially what kinds of new storage we would need (database tables, caches, etc.).

Aug 13 2019, 10:53 AM · GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), GrowthExperiments-Homepage

Aug 6 2019

Catrope added a comment to T225199: Fatal error during RecentChange::notifyEdit (deferred update) from ORES/RecentChangeSaveHookHandler.

We should check if this still happens in production. The latest patch would have changed how the error is reported in Logstash, we should now search for "Job push failed".

Aug 6 2019, 6:25 PM · Growth-Team (Current Sprint), MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Scoring-platform-team, WMF-JobQueue, ORES, Wikimedia-production-error
Catrope added a comment to T227094: Update RC Filters for new ORES capacities (July, 2019).

It sounds to me like we just need to do the usual threshold configuration, like in the commit Aaron linked. So we just need to do each of the subtasks.

Aug 6 2019, 6:14 PM · Scoring-platform-team, editquality-modeling, Growth-Team, artificial-intelligence
Catrope added a comment to T229235: Homepage module 'GrowthExperiments\HomepageModules\Mentorship' cannot be rendered..

@kostajh -- how common is this? What percent of users are not getting a mentorship module?

Aug 6 2019, 2:15 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Growth-Team (Current Sprint), GrowthExperiments-Homepage, Wikimedia-production-error
Catrope claimed T223227: Homepage: add user email and email preferences link to "unconfirmed email state" of start module.
Aug 6 2019, 2:09 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Desktop, Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage, Growth-Team (Current Sprint)

Aug 3 2019

Catrope moved T229271: [wmf.15-mobile] Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined' from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Aug 3 2019, 4:14 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope claimed T229271: [wmf.15-mobile] Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined' .
Aug 3 2019, 4:14 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T225663: Homepage: add sub-header text about user longevity to mobile homepage.

I believe this FOUC is part of MobileFrontend's relative timestamp handling, because the "Last edited 24 days ago" label at the bottom of the user page behaves the same way.

Aug 3 2019, 3:48 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
Catrope added a comment to T229271: [wmf.15-mobile] Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined' .

This bug is very obviously visible if you open e.g. the "ask your mentor" dialog on the mobile site in a desktop browser at full size (without device emulation). The OOUI dialog doesn't cover the whole screen (because the screen isn't small enough to trigger that behavior), and you get this:

Aug 3 2019, 12:57 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Growth-Team (Current Sprint), GrowthExperiments-Homepage

Aug 2 2019

Catrope claimed T227104: Homepage: number in mobile impact preview doesn't look aligned in Czech version.

The attached patch fixes this by changing the way the impact module uses column layouts. Right now, the "Monitor views" and "You have not yet created" labels take up the entire width of the module, and then the "Views from recent edits" and the pageviews number are in a 2-column layout (where the left column is as wide as possible, and the right column as wide as necessary). With my patch, the entire module is a two-column layout, with all the text in the left column, and the number in the right column (bottom-aligned). This means that we don't get weird display issues when the number is taller than the "Views from recent edits" text, and hacks fighting those display issues is what made it hard to bottom-align the number in the first place.

Aug 2 2019, 11:14 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T227104: Homepage: number in mobile impact preview doesn't look aligned in Czech version.

This is also reproducible in English, you just have to make the screen narrower so that the "Views from recent edits" text wraps:

Aug 2 2019, 8:12 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
IKhitron awarded T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) a Burninate token.
Aug 2 2019, 7:24 PM · Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, Growth-Team, MediaWiki-Watchlist

Aug 1 2019

Catrope moved T223562: Topic (Structured Discussions) edits do not appear in mobile Recent Changes from Inbox to External on the Growth-Team board.
Aug 1 2019, 11:32 PM · Advanced Mobile Contributions, Readers-Web-Backlog (Tracking), Growth-Team, MobileFrontend, MediaWiki-Recent-changes, StructuredDiscussions
Catrope moved T223566: Topic: edits should appear in Talk tab in Mobile Watchlist from Inbox to External on the Growth-Team board.

It appears that a simple way to fix this would be to add 2600 (the ID of the Topic namespace) to the 1, 3, 5 list in the code snippet quoted in the task description.

Aug 1 2019, 11:31 PM · Readers-Web-Backlog, Growth-Team, MobileFrontend, MediaWiki-Watchlist, StructuredDiscussions
Catrope moved T217421: recentchanges timestamp may not be exactly the same as the revision timestamp from Inbox to External on the Growth-Team board.
Aug 1 2019, 11:28 PM · MediaWiki-Revision-backend, Growth-Team, MediaWiki-Recent-changes
Catrope moved T178038: Rebuildrecentchanges.php should regenerate CatWatch entries from Inbox to Triaged but Future on the Growth-Team board.
Aug 1 2019, 11:09 PM · Growth-Team, MediaWiki-Maintenance-scripts, MediaWiki-Recent-changes, CatWatch, TCB-Team
Catrope moved T225658: Homepage: enabled mobile homepage affects the position of the add-to-watchlist icon from Ready for Development to QA on the Growth-Team (Current Sprint) board.

I can't reproduce this on beta labs. It was probably fixed by something we did in the past 6 weeks.

Aug 1 2019, 11:08 PM · Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage

Jul 31 2019

Catrope claimed T229515: Start module icon missing when all four submodules are completed (desktop only).
Jul 31 2019, 11:23 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope created T229515: Start module icon missing when all four submodules are completed (desktop only).
Jul 31 2019, 11:22 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T132084: Notify editors that they are now eligible for the Wikipedia Library program.

While we could potentially get away with one notification being sent to relatively new editors, retroactively notifying editors might cause some stir we aren't prepared to handle at the moment.

Jul 31 2019, 10:48 PM · Wikimedia-extension-review-queue, Growth-Team, Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, User-notice-collaboration, User-notice, Notifications, The-Wikipedia-Library
Catrope moved T229115: When a user wants to create an article, offer to publish it as a draft from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Jul 31 2019, 2:11 AM · MediaWiki-Page-editing, Growth-Team, VisualEditor
Catrope moved T229080: Help panel: understand search behavior from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Jul 31 2019, 2:11 AM · Growth-Team, GrowthExperiments-Help panel
Catrope moved T229081: Help panel: suggest an edit from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Jul 31 2019, 2:11 AM · Growth-Team, GrowthExperiments-Help panel
Catrope moved T219592: Frequent Echo DB_MASTER write queries on HTTP GET from Inbox to Upcoming Work on the Growth-Team board.
Jul 31 2019, 2:10 AM · CPT Initiatives (Multi-DC (TEC1)), Growth-Team, Notifications, Services (watching), Performance-Team (Radar), Availability (MediaWiki-MultiDC)
Catrope added a comment to T219592: Frequent Echo DB_MASTER write queries on HTTP GET.

The first stack trace is from a deferred update scheduled from EchoHooks::processMarkAsRead() on read requests with a ?markasread=123 query parameter. If writing from deferred updates on GET requests is not allowed, how are we supposed to schedule a write when we notice that it's needed in a GET request? Do we submit a job to the job queue?

Jul 31 2019, 2:08 AM · CPT Initiatives (Multi-DC (TEC1)), Growth-Team, Notifications, Services (watching), Performance-Team (Radar), Availability (MediaWiki-MultiDC)
Catrope moved T229168: Add a help link to Thanks confirmation & remove the confusing word "publicly" from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Jul 31 2019, 2:02 AM · patch-welcome, Growth-Team, Thanks
Catrope moved T173219: Timeless uses words instead of a heart for wikilove from Inbox to External on the Growth-Team board.
Jul 31 2019, 1:59 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Growth-Team, WikiLove, Timeless
Catrope moved T218839: [minor] HelpPanel logs incorrect events for protected pages from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Jul 31 2019, 1:58 AM · GrowthExperiments-Help panel, Growth-Team (Current Sprint)
Catrope added a comment to T218839: [minor] HelpPanel logs incorrect events for protected pages.

(2) A protected page has 'View source' option for users who cannot edit protected pages. Clicks on 'View source' won't trigger impression event.

Jul 31 2019, 1:58 AM · GrowthExperiments-Help panel, Growth-Team (Current Sprint)
Catrope moved T229271: [wmf.15-mobile] Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined' from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Jul 31 2019, 1:55 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T229296: [Safari 10] Homepage layout broken from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Jul 31 2019, 1:55 AM · Growth-Team, GrowthExperiments-Homepage
Catrope moved T228973: Find a new ambassador for Vietnamese Wikipedia from Inbox to Upcoming Work on the Growth-Team board.
Jul 31 2019, 1:46 AM · Growth-Team (Current Sprint), CommRel-Specialists-Support (Jul-Sep-2019)
Catrope moved T229052: [DESIGN] Initial design explorations for a structured user profile page from Inbox to Upcoming Work on the Growth-Team board.
Jul 31 2019, 1:46 AM · Growth-Team (Current Sprint), Mobile, Desktop, Growth Design
Catrope closed T227009: selenium-daily-beta-Echo Jenkins job failing as Resolved.

Patch was merged, job is no longer failing

Jul 31 2019, 1:45 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Growth-Team, User-zeljkofilipin, Notifications
Catrope moved T229053: Newcomer tasks: Comparative review of task suggestion products from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Jul 31 2019, 1:43 AM · Growth-Team (Current Sprint)
Catrope edited projects for T229053: Newcomer tasks: Comparative review of task suggestion products, added: Growth-Team (Current Sprint); removed Growth-Team.
Jul 31 2019, 1:43 AM · Growth-Team (Current Sprint)
Catrope moved T229359: Remove WelcomeSurvey variation C related code from Inbox to Upcoming Work on the Growth-Team board.

Perhaps this could be a good onboarding task for @Tgr ?

Jul 31 2019, 1:42 AM · Technical-Debt, Growth-Team, GrowthExperiments