Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani (WMDE))
Shah of BugsAdministrator

Projects (29)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (267 w, 1 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Wikidata developer, open source enthusiast, mediawiki volunteer developer
Babel: fa-N, en-4, de-1, tr-1

Recent Activity

Today

Ladsgroup added a comment to T68025: [Story] Monitor size of some Wikidata database tables.

I just created a basic dashboard with these metrics.
https://grafana.wikimedia.org/d/pwq8ZIxWk/large-site-db-tables
Is there anything else we want to add (given our discussions last week?)

Wed, Nov 20, 3:04 PM · WMDE-Analytics-Engineering, DBA, Story, Wikidata, Wikidata.org
Ladsgroup added a comment to T237984: Some property labels are not displayed on Item pages.

I don't know if it's related, but here https://www.wikidata.org/wiki/Wikidata:Property_proposal/YVNG_ID the labels are not displayed for the {{Q}} template, even after a purge. (I'm logged in, interface is in French, I use the last version of Firefox on Ubuntu 18.10)

Wed, Nov 20, 2:58 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T237727: Symlinked js files broken on Windows.

I can't find where we documented other options but IIRC. One is the move only four fives to a another submodule and make it another npm module. The other option was to keep them copied and make sure they are the same using CI tests.

Wed, Nov 20, 12:46 PM · Wikidata-Campsite, Wikidata
Ladsgroup added a project to T238729: CI failing with “Return value of MediaWikiServices::getStatsdDataFactory() must implement IBufferingStatsdDataFactory, instance of Mock_StatsdDataFactory_5d2038b7 returned”: MediaWiki-extensions-WikimediaEvents.
Wed, Nov 20, 10:09 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikimediaEvents, Wikimedia-production-error (Shared Build Failure)
Ladsgroup added a comment to T167565: Wikidata allows invalid URIs to be entered as units.

Yes let's. And as Thiemo suggested let's do it for calendar model and globe as well.

Wed, Nov 20, 12:40 AM · Wikidata-Campsite, patch-welcome, MediaWiki-extensions-WikibaseRepository, Wikidata

Yesterday

Ladsgroup moved T218998: Track WDQS updater UA in wikidata-special-entitydata grafana dashboard from Doing to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 19, 4:22 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Analytics, WMDE-Analytics-Engineering, Wikidata
Ladsgroup moved T238473: Label for unit isn't displayed correctly, just Q-number from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 19, 4:21 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T237984: Some property labels are not displayed on Item pages.
Tue, Nov 19, 4:21 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T218998: Track WDQS updater UA in wikidata-special-entitydata grafana dashboard from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 19, 3:49 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Analytics, WMDE-Analytics-Engineering, Wikidata
Ladsgroup claimed T238473: Label for unit isn't displayed correctly, just Q-number.

I'm making progress here, so let me lick the cookie.

Tue, Nov 19, 3:49 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Mon, Nov 18

Ladsgroup reassigned T238590: Wikidata Beta returns a stack trace from Ladsgroup to Addshore.

People are really fast here :D

Mon, Nov 18, 8:31 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Wikidata
Ladsgroup claimed T238590: Wikidata Beta returns a stack trace.

The offending patch just got reverted. It takes some time to take into effect but it should be fixed now.

Mon, Nov 18, 8:30 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Wikidata
Ladsgroup added a comment to T237727: Symlinked js files broken on Windows.

I mean, that assumes you use git bash?

Mon, Nov 18, 5:47 PM · Wikidata-Campsite, Wikidata
Ladsgroup committed rEWCSa08a2b9d0b03: Move SpecialEntitiesWithoutPage from Wikibase to here (authored by Ladsgroup).
Move SpecialEntitiesWithoutPage from Wikibase to here
Mon, Nov 18, 4:22 PM
Ladsgroup added a comment to T238303: Define a release process for wdqs.

I would be in favor of separating the repos for two reasons:

Mon, Nov 18, 4:17 PM · Wikidata, Wikidata-Query-Service
Ladsgroup added a comment to T238512: Scheduled renaming of two Wikimedia user accounts.

As I said in the global renamers mailing list, the only thing I'm worried about is FlaggedRevs and AbuseFilter tables that might keep the user_text instead of normalized actor_id. Just keeping in these two in mind would be enough for me.

Mon, Nov 18, 1:06 PM · MediaWiki-extensions-CentralAuth, GlobalRename, Operations, DBA
Ladsgroup updated the task description for T232194: Terms migration to new store.
Mon, Nov 18, 12:53 PM · Wikidata

Fri, Nov 15

Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

After eight hours of looking at logs and hadoop queries and MySQL queries and graphs the only thing I can say is that putting stats or logs on FullEntityParserOutputGenerator is the best way to move forward here + there's nothing in edits in wikidata that can correlate to this problem (so the only possible idea it purges done either by jobs or POST purges by bots). There's nothing to look at in client side as the client side doesn't get called (actually I discovered that some parts of client are actually dead code that never gets called).

Fri, Nov 15, 10:03 PM · Wikidata-Campsite, Wikidata
Ladsgroup placed T237984: Some property labels are not displayed on Item pages up for grabs.

a bit of a never-ending story this. Now it's moved on to family name ;) Happened around 15:00 Berlin time

Fri, Nov 15, 2:34 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T237013: Refactor the Wikidata Data Quality Report analytics procedures.

no no, it should have only ~50mio lines, no more.
Looking at the file it has lots of old data. I should drop them, it's too much and only these lines should stay.

ladsgroup@stat1007:~/articlequality$ grep 20190901000000 run_20190901.out | wc -l
54049707
Fri, Nov 15, 1:15 PM · User-GoranSMilovanovic, WMDE-Analytics-Engineering
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

Given that SqlEntityInfoBuilder::collectTermsForEntities only user is FullEntityParserOutputGenerator::getEntityInfo, we might want to look into which pages get re-parsed around that time. Another possibility might be a bot running at that interval re-parsing (or more probably, editing) pages.

Fri, Nov 15, 12:15 PM · Wikidata-Campsite, Wikidata
Ladsgroup added a comment to T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config.

The cache is there:

Fri, Nov 15, 10:58 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata

Thu, Nov 14

Ladsgroup updated subscribers of T238285: Pages whose title ends with semicolon (;) are intermittently inaccessible.

I think this has to do something from differences between ATS and varnish normalizing request URLs (if they do any). @ema @BBlack Can you double check?

Thu, Nov 14, 8:05 PM · Wikimedia-General-or-Unknown, Operations, Traffic, User-DannyS712
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

The patch decreased the read on the database and work done but spikes are still happening:
https://grafana.wikimedia.org/d/000000548/wikibase-wb_terms?panelId=2&fullscreen&orgId=1&from=1573718423955&to=1573761623955

Thu, Nov 14, 5:00 PM · Wikidata-Campsite, Wikidata
Ladsgroup moved T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Nov 14, 12:43 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup added a comment to T231011: (euwiki) Mysterious, coordinated slowdowns every ~ 25 minutes on API servers.

@Ladsgroup might be on the correct track here. The spikes neatly coincide with the WD bot updates.

Thu, Nov 14, 12:42 PM · PHP 7.2 support, serviceops, Operations
Ladsgroup added a comment to T232446: Compress new Wikibase tables.

Let me clarify one thing here, by not possible I mean, it will be possible after one day of work and two days of test.

Thu, Nov 14, 9:15 AM · DBA

Wed, Nov 13

Ladsgroup added a comment to T237013: Refactor the Wikidata Data Quality Report analytics procedures.

@Ladsgroup
My attempt at a logico-historical approach:
Step 1. You have produce a first data set of ORES score predictions that included all items.
Step 2. I have produced the Wikidata Quality Report based on that data set.
Step 3. You have produced an update of ORES score predictions.
Claim A. The update produced in Step 3. does not encompass the ORES score predictions for all items, but only for those items that have received a revision between steps 1. and 3.
The central question is: is my statement in Claim A. correct?

Wed, Nov 13, 10:32 PM · User-GoranSMilovanovic, WMDE-Analytics-Engineering
Ladsgroup moved T236901: Use elastic for SpecialEntitiesWithoutPage (EntitiesWithoutTermFinder) from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Nov 13, 6:49 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup moved T218998: Track WDQS updater UA in wikidata-special-entitydata grafana dashboard from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

It needs to be deployed that will probably happen next Wednesday and then I need to add it to grafana.

Wed, Nov 13, 5:50 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Analytics, WMDE-Analytics-Engineering, Wikidata
Ladsgroup moved T236901: Use elastic for SpecialEntitiesWithoutPage (EntitiesWithoutTermFinder) from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Nov 13, 3:42 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup claimed T236901: Use elastic for SpecialEntitiesWithoutPage (EntitiesWithoutTermFinder).
Wed, Nov 13, 3:42 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup changed the status of T238119: Add Wikidata support for gcrwiki, a subtask of T238104: Create Guianan Creole Wikipedia, from Open to Stalled.
Wed, Nov 13, 2:20 PM · User-Ladsgroup, Patch-For-Review, Wiki-Setup (Create), User-Urbanecm
Ladsgroup changed the status of T238119: Add Wikidata support for gcrwiki from Open to Stalled.

The wiki hasn't been created yet.

Wed, Nov 13, 2:20 PM · Wikidata-Campsite, Wikidata
Ladsgroup changed the status of T238120: Add Wikidata support for shywiktionary, a subtask of T238105: Create Shawiya Wiktionary, from Open to Stalled.
Wed, Nov 13, 2:20 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Ladsgroup, Patch-For-Review, User-Urbanecm, Wiki-Setup (Create)
Ladsgroup changed the status of T238120: Add Wikidata support for shywiktionary from Open to Stalled.

The wiki hasn't been created yet.

Wed, Nov 13, 2:19 PM · Wikidata-Campsite, Wikidata
Ladsgroup added a comment to T237984: Some property labels are not displayed on Item pages.

I ran it again, it should be fixed now, let me know if it's happening again :(

Wed, Nov 13, 1:59 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T232446: Compress new Wikibase tables.

on our side (which stores and uses the most of stuff SDC use), we can safely move to another server, we don't do any joins with other tables in the code.

It was actually wikibase team that said to us said it was not yet possible, please talk to them to clarify.

Wed, Nov 13, 1:57 PM · DBA
Ladsgroup updated subscribers of T238199: SpecialFewestRevisions::reallyDoQuery takes more than 9h to run.

I think we should kill this thing for wikidata, it doesn't bring much value and it's really really resource intensive. cc @Lydia_Pintscher

Wed, Nov 13, 12:32 PM · MediaWiki-General, Wikidata

Tue, Nov 12

Ladsgroup added a comment to T237984: Some property labels are not displayed on Item pages.

Looks like this might be related?

Tue, Nov 12, 10:29 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup created T238154: Clean removed wikibase config variables from production.
Tue, Nov 12, 9:23 PM · Technical-Debt (Deprecation process), Wikidata-Campsite, Wikidata
Ladsgroup added a comment to T238150: patch-drop-ct_tag.sql causes duplicate entries for key change_tag_rc_tag_id.

The error is caused because the maintenance script mentioned in the update.php is not ran (PopulateChangeTagDef) otherwise your ct_tag_id column would have not been NULL, and indeed patch-drop-ct_tag.sql is after the maintenance script. So either somehow updater skipped running the maintenance script or failed to do anything there. I have no idea how I can check this for you. Can you do it?

Tue, Nov 12, 9:12 PM · MediaWiki-Installer
Ladsgroup added a comment to T237013: Refactor the Wikidata Data Quality Report analytics procedures.

I have trouble understanding you. Can you elaborate more?

Tue, Nov 12, 8:52 PM · User-GoranSMilovanovic, WMDE-Analytics-Engineering
Ladsgroup added a comment to T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master.

I'm in favor of turning the GUI into a nodejs app that serves static files for now and then slowly turning it into a full-fledged nodejs one. @Addshore do you think this is doable?

Tue, Nov 12, 8:44 PM · Wikidata-Campsite, Patch-For-Review, Release Pipeline (Blubber), User-Addshore, wikidata-tech-focus, Wikidata, Wikibase-Containers
Ladsgroup placed T235651: Update wikidata-query-gui-build job versions (from Jessie, Node v6, npm v3) up for grabs.
Tue, Nov 12, 8:26 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata, Continuous-Integration-Config, Wikidata Query UI
Ladsgroup updated subscribers of T235651: Update wikidata-query-gui-build job versions (from Jessie, Node v6, npm v3).

That was an interesting rabbit hole. The job is actually defined integration/config in jjb/wikidata.yaml and unlike most jobs, it's actually defined in context of a bare metal system or VM and not on a container making it really hard to change, It's pinned in puppet in file modules/contint/manifests/packages/javascript.pp but it has this message:

# DO NOT CHANGE VERSION WITHOUT INVOLVING Krinkle OR hashar
#
# https://wikitech.wikimedia.org/wiki/Nova_Resource:Integration/Setup
$versions = {
    'npm'       => '3.8.3',
}
Tue, Nov 12, 8:26 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata, Continuous-Integration-Config, Wikidata Query UI
Ladsgroup moved T235651: Update wikidata-query-gui-build job versions (from Jessie, Node v6, npm v3) from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 12, 7:49 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata, Continuous-Integration-Config, Wikidata Query UI
Ladsgroup moved T234329: Investigate, fix and reimport failing item terms into new store from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 12, 7:49 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup moved T234221: Change the datatype of P4839 from string to identifier from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 12, 7:47 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T235651: Update wikidata-query-gui-build job versions (from Jessie, Node v6, npm v3).
Tue, Nov 12, 7:35 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata, Continuous-Integration-Config, Wikidata Query UI
Ladsgroup claimed T234221: Change the datatype of P4839 from string to identifier.
Tue, Nov 12, 7:35 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T237013: Refactor the Wikidata Data Quality Report analytics procedures.

@Ladsgroup We might have a problem with your most recent version of ORES quality score predictions for Wikidata.
In our Wikidata Quality Report, based on the first data set that you have provided, we had the ORES score prediction for 57,014,687 items.
However, your most recent data set - run_201910.out - (and ask me in an email if you need to be reminded the path under which it is found on stat1000*), when filtered for the most recent item revision scored, has 56,315,883 items.

Tue, Nov 12, 7:28 PM · User-GoranSMilovanovic, WMDE-Analytics-Engineering
Ladsgroup moved T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 12, 7:27 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup added a comment to T232446: Compress new Wikibase tables.

Why this is created in s4? Does anyone knows why?

That was part of the Commons Structured Data project.
We advised against doing this, and rather, creating a new section (with new servers) just for those, to be able to accommodate growth and capacity planning as needed, as there were some concerns about the growth and usage, specially having those tables in such a busy and loaded section as Commonswiki, unfortunately, the creation of those tables were not communicated to us, and we actually found out about them by chance.
We later found out that also SDC cannot work with a separate Wikibase installation (meaning those specific set of tables) being stored on different servers.

Tue, Nov 12, 4:47 PM · DBA
Ladsgroup moved T225055: Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_BOTH from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 12, 4:25 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup closed T220284: Add monolingual language code tnq (Taíno) and car (Kalinago) as Resolved.
Tue, Nov 12, 2:47 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
Ladsgroup closed T220284: Add monolingual language code tnq (Taíno) and car (Kalinago), a subtask of T144272: new monolingual language code requests for Wikidata (tracking), as Resolved.
Tue, Nov 12, 2:47 PM · MediaWiki-extensions-WikibaseRepository, Tracking-Neverending, Wikidata
Ladsgroup closed T234330: Add monolingual language code bdr as Resolved.
Tue, Nov 12, 2:46 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup closed T234330: Add monolingual language code bdr, a subtask of T144272: new monolingual language code requests for Wikidata (tracking), as Resolved.
Tue, Nov 12, 2:46 PM · MediaWiki-extensions-WikibaseRepository, Tracking-Neverending, Wikidata
Ladsgroup closed T222581: Missing prerequisites in installation guide as Resolved.
Tue, Nov 12, 2:41 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Wikidata Query UI
Ladsgroup closed T230881: Add monolingual language code "sa-Sidd" and "pi-Sidd" as Resolved.
Tue, Nov 12, 2:40 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), good first bug, MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup closed T230881: Add monolingual language code "sa-Sidd" and "pi-Sidd", a subtask of T144272: new monolingual language code requests for Wikidata (tracking), as Resolved.
Tue, Nov 12, 2:40 PM · MediaWiki-extensions-WikibaseRepository, Tracking-Neverending, Wikidata
Ladsgroup closed T235970: beta testwiki site is broken: "Unknown database 'testwikidatawiki'" as Resolved.
Tue, Nov 12, 2:30 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient, Beta-Cluster-Infrastructure
Ladsgroup moved T237102: Increase the size of wbt_text_in_lang.wbxl_language from Test (Verification) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 12, 2:27 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ladsgroup, Wikidata, Schema-change, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Ladsgroup closed T236749: Don't store actual EntityUsage objects in ParserOutput, but just minimal identifier strings as Resolved.
Tue, Nov 12, 2:27 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Performance Issue, MediaWiki-extensions-WikibaseClient
Ladsgroup closed T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive as Resolved.
Tue, Nov 12, 2:26 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
Ladsgroup closed T236466: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Wikimedia\Rdbms\Database::makeList: empty input for field wbxl_text_id) [Called from Wikibase\Repo\Content\DataUpdateAdapter::doUpdate in /extensions/Wikibase/repo/includes/Content/DataUpdateAdapter.php at line 62] as Resolved.

https://logstash.wikimedia.org/goto/2486a0b26074a428cc79f8326adbbc4a:

Tue, Nov 12, 2:22 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikimedia-production-error
Ladsgroup moved T237984: Some property labels are not displayed on Item pages from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 12, 12:54 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T237984: Some property labels are not displayed on Item pages from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Nov 12, 12:39 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T237984: Some property labels are not displayed on Item pages.
Tue, Nov 12, 12:38 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T237984: Some property labels are not displayed on Item pages.

I just ran the rebuild term store for P195 and it fixed the issue (if you see it somewhere else, please purge the page). I ran it everywhere.

Tue, Nov 12, 12:36 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T232040: Add label and description collision detectors for new terms store.

As I mentioned in person, given that DefferedUpdates happen practically at the same time of the edit, I'm fine with 1. If it was done in a job, I would be against it.

Tue, Nov 12, 11:49 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
Ladsgroup added a comment to T236466: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Wikimedia\Rdbms\Database::makeList: empty input for field wbxl_text_id) [Called from Wikibase\Repo\Content\DataUpdateAdapter::doUpdate in /extensions/Wikibase/repo/includes/Content/DataUpdateAdapter.php at line 62].

Mentioned in SAL (#wikimedia-operations) [2019-11-12T11:47:17Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.4/extensions/Wikibase: Wikibase term store error reduction, [[gerrit:550441|Do not catch DBError in ReplicaMasterAwareRecordIdsAcquirer.]] (T236466) (duration: 00m 56s)

Tue, Nov 12, 11:48 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T232446: Compress new Wikibase tables.

Why this is created in s4? Does anyone knows why?

Tue, Nov 12, 11:17 AM · DBA

Mon, Nov 11

Ladsgroup assigned T237731: Do not catch DBError in new store db implementations to alaa_wmde.

Okay, I tested and in all of cases, we rethrow exception which I don't we should catch them in the first place, the stack trace will show up anyway, but that's not a big deal.

Mon, Nov 11, 5:13 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Ladsgroup moved T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Nov 11, 5:09 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup claimed T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config.

I need to rewrite half of the class to make it work with caching.

Mon, Nov 11, 4:23 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup closed T172776: Property labels missing on some items, a subtask of T171460: Populate term_full_entity_id on www.wikidata.org, as Resolved.
Mon, Nov 11, 11:55 AM · User-Ladsgroup, Wikidata-Former-Sprint-Board, Patch-For-Review, DBA, Wikidata
Ladsgroup closed T172776: Property labels missing on some items, a subtask of T173805: rebuild-all-terms option in RebuildTermSqlIndex causes term to randomly disappear, as Resolved.
Mon, Nov 11, 11:55 AM · MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup closed T172776: Property labels missing on some items as Resolved.

This issue is still happening these days on P195, eg https://www.wikidata.org/wiki/Q12418#P195

Mon, Nov 11, 11:55 AM · MediaWiki-extensions-WikibaseRepository, Wikidata-Former-Sprint-Board, User-Ladsgroup, Wikidata
Ladsgroup added a comment to T237120: Schema change on production for increase the size of wbt_text_in_lang.wbxl_language.

I can try to start with this next week to make sure the deletion of wb_terms doesn't get (more) blocked. I have a huge backlog to catch up with after my holidays so impossible to start with this during this week.
testwikidata should be easy to do and I will do that first (if that helps with anything)

Mon, Nov 11, 11:37 AM · DBA, Blocked-on-schema-change, Wikidata
Ladsgroup closed T236259: Start an ADR for package modules as Resolved.
Mon, Nov 11, 11:16 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata, RL Module Terminators Trailblazing
Ladsgroup moved T236259: Start an ADR for package modules from Peer Review to Done on the RL Module Terminators Trailblazing board.
Mon, Nov 11, 11:16 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata, RL Module Terminators Trailblazing
Ladsgroup added a comment to T237727: Symlinked js files broken on Windows.

We can put it in README

Mon, Nov 11, 11:10 AM · Wikidata-Campsite, Wikidata
Ladsgroup added a comment to T237369: Create Sakizaya Wikipedia.

Creation of the wiki is blocked until the MediaWiki namespaces are in place: T237370. Having them added afterwards is a pain.

Mon, Nov 11, 10:56 AM · User-Ladsgroup, Patch-For-Review, User-Urbanecm, Wiki-Setup (Create)
Ladsgroup moved T237731: Do not catch DBError in new store db implementations from Done to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

https://tools.wmflabs.org/versions/
We have wmf.5 in production now. This one is tagged for wmf.8. is that going to be the branch for this week's train?

Mon, Nov 11, 9:57 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)

Sat, Nov 9

Ladsgroup added a project to T230430: Migrate most recent schema changes to use the abstract system: CPT Initiatives (Abstract Schema).
Sat, Nov 9, 11:29 PM · CPT Initiatives (Abstract Schema), MediaWiki-Installer
Ladsgroup renamed T237838: Make addWiki.php follow the new system for schema from Make addWiki.php follow the new systtem for schema to Make addWiki.php follow the new system for schema.
Sat, Nov 9, 11:29 PM · CPT Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer
Ladsgroup added a project to T237837: Rework documentation of schema and schema changes design and manual: CPT Initiatives (Abstract Schema).
Sat, Nov 9, 11:29 PM · Documentation, CPT Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer
Ladsgroup added a project to T230428: Migrate tables.sql to abstract schema: CPT Initiatives (Abstract Schema).
Sat, Nov 9, 11:28 PM · CPT Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer
Ladsgroup added a project to T230421: Introduce a maintance script that takes abstract schema(changes|) and gives out raw SQL: CPT Initiatives (Abstract Schema).
Sat, Nov 9, 11:28 PM · CPT Initiatives (Abstract Schema), MediaWiki-Installer
Ladsgroup edited projects for T230420: Introduce JSON-based Doctrine-DBAL-based SchemaDiffBuilder, added: CPT Initiatives (Abstract Schema); removed Patch-For-Review.
Sat, Nov 9, 11:27 PM · CPT Initiatives (Abstract Schema), MediaWiki-Installer
Ladsgroup created T237839: Wire abstract schema and schema changes for extension.
Sat, Nov 9, 11:26 PM · CPT Initiatives (Abstract Schema), MediaWiki-Installer
Ladsgroup created T237838: Make addWiki.php follow the new system for schema.
Sat, Nov 9, 11:24 PM · CPT Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer
Ladsgroup created T237837: Rework documentation of schema and schema changes design and manual.
Sat, Nov 9, 11:22 PM · Documentation, CPT Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer
Ladsgroup claimed T230428: Migrate tables.sql to abstract schema.
Sat, Nov 9, 11:16 PM · CPT Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer
Ladsgroup closed T230419: Introduce JSON-based Doctrine-DBAL-based SchemaBuilder, a subtask of T191231: RFC: Abstract schemas and schema changes, as Resolved.
Sat, Nov 9, 11:16 PM · CPT Initiatives (Abstract Schema), TechCom-RFC (TechCom-Approved), MediaWiki-Installer, Patch-For-Review, User-Addshore, SQLite, Oracle Database, MSSQL, PostgreSQL, Epic
Ladsgroup closed T230419: Introduce JSON-based Doctrine-DBAL-based SchemaBuilder as Resolved.
Sat, Nov 9, 11:16 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MediaWiki-Installer
Ladsgroup moved T237731: Do not catch DBError in new store db implementations from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Sat, Nov 9, 5:05 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)

Fri, Nov 8

Ladsgroup added a comment to T220775: Consider creating a puppet-compiler equivalent for mediawiki-config.git.

I consider this to be part of that?

Fri, Nov 8, 4:09 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, serviceops-radar, Continuous-Integration-Config, Wikimedia-Site-requests