Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani)
Shah of Bugs, Emir of database architecture, World-renowned rubber duckAdministrator

Today

  • No visible events.

Tomorrow

  • No visible events.

Tuesday

  • No visible events.

User Details

User Since
Oct 6 2014, 9:53 PM (609 w, 5 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Staff Database Architect in SRE data persistence team in WMF. Used to be Wikidata software engineer at WMDE

I'm also open source enthusiast, mediawiki volunteer developer, and long-term Wikipedian and generally unhinged.

All edits on tickets about databases are in my work capacity and anything else is in my volunteer capacity unless mentioned otherwise.

Babel: fa-N, en-4, de-2, tr-1, hu-1

Recent Activity

Yesterday

Ladsgroup added a comment to T424399: shwiki uses unbalanced `-{` in Template:refbegin.

Ah I think I know what you mean, it should be on the articles themselves and not get injected via the templates.

Sat, Jun 13, 1:06 AM · Content-Transform-Team (Work In Progress), Parsoid-Read-Views (Language Converter Support)
Ladsgroup added a comment to T424399: shwiki uses unbalanced `-{` in Template:refbegin.

What would be a proposed solution that wouldn't trigger the language conversion? (I assume the -{ is added for this reason.) I can get it done, just need to know what should we replace it to.

Sat, Jun 13, 1:05 AM · Content-Transform-Team (Work In Progress), Parsoid-Read-Views (Language Converter Support)
Ladsgroup added a comment to T428927: cywiki bad wikitext.

https://cy.wikipedia.org/wiki/Sgwrs_Defnyddiwr:Llywelyn2000#c-Ladsgroup-20260613005800-Incompatibility_with_Parsoid

Sat, Jun 13, 12:58 AM · Parsoid-Read-Views (Small Size Wikipedias), Content-Transform-Team (Work In Progress)
Ladsgroup added a comment to T428927: cywiki bad wikitext.

FWIW. These pages all seem to be created by a bot. I ask the bot operator if it's okay to fix them.

Sat, Jun 13, 12:52 AM · Parsoid-Read-Views (Small Size Wikipedias), Content-Transform-Team (Work In Progress)

Wed, Jun 10

Ladsgroup added a comment to T428667: Create a new x1 tables for cross-wiki tracking of Wikifunctions usage, similar to GlobalUsage.

There is also a lot of discussion on json global usage tracking (T370378: Explore usage tracking for chart pages and tabular data pages) that could be useful and actually shape future the normalization of globalimageslinks too (so the above ticket is correct but slightly outdated). I suggest looking at the globaljsonlinks discussion in depth too.

Wed, Jun 10, 1:34 PM · Patch-For-Review, DBA, Abstract Wikipedia team (26Q4 (Apr–Jun)), WikiLambda, Essential-Work
Ladsgroup updated subscribers of T213040: Convert Special:Upload to OOUI.
Wed, Jun 10, 11:30 AM · Patch-For-Review, Multimedia, MediaWiki-Uploading
Ladsgroup added a comment to T213040: Convert Special:Upload to OOUI.

I think main point should be to migrate it to HTMLForm as much as possible, currently it's using HTMLForm for most but not all. Then we can switch that to codex or ooui:

grafik.png (997×865 px, 39 KB)

Wed, Jun 10, 11:28 AM · Patch-For-Review, Multimedia, MediaWiki-Uploading

Tue, Jun 9

Ladsgroup added a comment to T428517: The user's row is being loaded three times on every page view.

Thank you for looking into this. I have sent you down a rabbit hole. Sorry 😅 I take a look and see what I can do to reduce the queries.

Tue, Jun 9, 7:16 PM · MediaWiki-Platform-Team, GlobalCssJs, MediaWiki-ResourceLoader, DBA, Performance Issue
Ladsgroup closed T428525: Create mail list for Wikimedia Community User Group Cyprus as Resolved.

I created it as a public mailing list, if you wanted a private one, you can change the settings yourself: https://lists.wikimedia.org/postorius/lists/wikimedia-cy.lists.wikimedia.org

Tue, Jun 9, 6:57 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T427285: Mass delete talk pages of wikis where it's violating the welcome policy.

Ah OK, so these proposed deletions are not like usual deletions where the content is still in the database, but hidden to non-admin users?

Tue, Jun 9, 6:41 PM · WMF-General-or-Unknown, DBA
Ladsgroup added a comment to T427285: Mass delete talk pages of wikis where it's violating the welcome policy.

To be clear, I'm not advocating for it to be deleted on commons (and as I said, nothing will happen without the community agreeing to it first). If there is a need for users to keep them, there is a need and we (the infrastructure) need to accommodate but if there isn't, then it'd be nice for us.

Tue, Jun 9, 1:37 PM · WMF-General-or-Unknown, DBA
Ladsgroup added a comment to T427285: Mass delete talk pages of wikis where it's violating the welcome policy.

Hi, I don't understand why you want to delete these talk pages. Now that they exist, I don't see the point.

Tue, Jun 9, 1:34 PM · WMF-General-or-Unknown, DBA
Ladsgroup added a comment to T428521: wikistats broken due to MediaWiki API dropping format=php.

Hi, it was announced in tech news, and separately on wikitech-l too https://lists.wikimedia.org/hyperkitty/list/wikitech-l@lists.wikimedia.org/message/Z2BSRHB2KVFY3EQKYWCRS7CB65IRRVD7/ I did send it to mediawiki-api-announce but it got rejected automatically :/

grafik.png (1,077×692 px, 94 KB)

Tue, Jun 9, 12:48 PM · VPS-project-Wikistats
Ladsgroup added a comment to T428512: Consider caching revision id of properties in CachingFallbackBasedTermLookup.

Caching rev id of properties for an hour could save a lot of db lookups and make us more resilient towards scrapers.

And show stale labels for up to an hour, I assume?

Tue, Jun 9, 12:30 PM · Wikidata-Omega, DBA, Sustainability (Incident Followup), Wikidata
Ladsgroup added a comment to T353891: https://lists.wikimedia.org is often slow to load.

Thanks for the thorough investigation! I want to clean them up until it becomes automated but the UI is not showing anything pending on https://lists.wikimedia.org/postorius/lists/daily-article-l.lists.wikimedia.org/subscription_requests

Tue, Jun 9, 12:12 PM · collaboration-services, Upstream, SRE, Performance Issue, Wikimedia-Mailing-lists

Mon, Jun 8

Ladsgroup created T428518: 2FA status is being looked up on every page view.
Mon, Jun 8, 10:35 PM · MW-1.47-notes (1.47.0-wmf.7; 2026-06-16), Patch-For-Review, MW-1.46-release, Product Safety and Integrity, DBA, Performance Issue, MediaWiki-extensions-OATHAuth
Ladsgroup created T428517: The user's row is being loaded three times on every page view.
Mon, Jun 8, 10:23 PM · MediaWiki-Platform-Team, GlobalCssJs, MediaWiki-ResourceLoader, DBA, Performance Issue
Ladsgroup updated the task description for T428512: Consider caching revision id of properties in CachingFallbackBasedTermLookup.
Mon, Jun 8, 9:59 PM · Wikidata-Omega, DBA, Sustainability (Incident Followup), Wikidata
Ladsgroup created T428512: Consider caching revision id of properties in CachingFallbackBasedTermLookup.
Mon, Jun 8, 9:58 PM · Wikidata-Omega, DBA, Sustainability (Incident Followup), Wikidata
Ladsgroup closed T425487: RedisConnectionPool breaks persistent connections by unconditionally closing them as Resolved.

We can backport it to release branches for the next mediawiki releases.

Mon, Jun 8, 9:24 PM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), MW-1.46-notes, MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff
Ladsgroup added a comment to T425487: RedisConnectionPool breaks persistent connections by unconditionally closing them.

Looks correct. I'll let CI run and after that, I'll merge.

Mon, Jun 8, 8:43 PM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), MW-1.46-notes, MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff
Ladsgroup added a comment to T427465: Move thumbnail caching from upload cluster to text.

Contrary to what it looks like, I have no clue what I'm doing. We probably need a service in hieradata/common/service.yaml too but not 100% sure

Mon, Jun 8, 3:22 PM · Patch-For-Review, Data-Persistence, Traffic
Ladsgroup added a comment to T427285: Mass delete talk pages of wikis where it's violating the welcome policy.

Yeah, we won't do this on all wikis. Only the ones that have created so many page that is adding non-trivial amount of data to the database and it will be done after the community has green-lit it. Incubator is a bit complicated since there is no community in the traditional sense but others, definitely should happen after consultation. Even before this policy, we have deleted pages in Vietnamese Wikipedia and English Wikinews before this RfC so it's a problem independent of that RfC. It's that it reminded me that we can clean up more :D

Mon, Jun 8, 12:38 PM · WMF-General-or-Unknown, DBA
Ladsgroup added a comment to T119117: Get rid of $wg = $wmg hack.

All extensions have been migrated to extension.json making the part in the title now redundant :)

Mon, Jun 8, 10:53 AM · Technical-Debt, Wikimedia-Site-requests
Ladsgroup renamed T119117: Get rid of $wg = $wmg hack from Get rid of $wg = $wmg hack for extensions that have been converted to using extension.json to Get rid of $wg = $wmg hack.
Mon, Jun 8, 10:53 AM · Technical-Debt, Wikimedia-Site-requests
Ladsgroup closed T428202: Wikipedia full-screen image view does not display the image as Resolved.
Mon, Jun 8, 10:48 AM · MW-1.47-notes (1.47.0-wmf.5; 2026-06-02), Reader Growth Team, MediaViewer
Ladsgroup added a comment to T428377: Consider using lzma compression for storing wikidata entries in external storage.

There is a php extension for lzma compression but doesn't seem to be widely used: https://github.com/codemasher/php-ext-xz I can't find it in debian packages either: https://packages.debian.org/search?suite=stable&section=all&arch=any&searchon=names&keywords=php8-xz this could complicate things :(

Mon, Jun 8, 1:17 AM · DBA, Wikidata
Ladsgroup created T428377: Consider using lzma compression for storing wikidata entries in external storage.
Mon, Jun 8, 1:05 AM · DBA, Wikidata

Sun, Jun 7

Ladsgroup added a comment to T18691: RFC: Section header "share" link.

Potentially instead of guessing the impact of it, maybe you could just track how many times the feature was clicked on? Seems like a reasonable use of that if you want to measure how useful it is to people.
https://www.mediawiki.org/wiki/Gadget_kitchen:_recording_metrics

Sun, Jun 7, 3:18 PM · User-notice, MW-1.47-notes (1.47.0-wmf.1; 2026-05-05), Wikimedia-Hackathon-2026, Patch-For-Review, Hackathon-Northwestern-Europe-2026, Reader Growth Team, Tech Ambassadors & Translators, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-User-Interface

Sat, Jun 6

Ladsgroup added a comment to T18691: RFC: Section header "share" link.

TLDR: My explanation is that when someone gets to wikipedia through clicking on search engine results, they usually meant to look up a fact and then they leave. While if they are coming to us through other means (=with no referrer), they will stay and read more and click on links. Based on a simple regression, on average, every page view with referrer of none leads to 4.52 page views with internal referrer (clicking on links)

Sat, Jun 6, 1:44 AM · User-notice, MW-1.47-notes (1.47.0-wmf.1; 2026-05-05), Wikimedia-Hackathon-2026, Patch-For-Review, Hackathon-Northwestern-Europe-2026, Reader Growth Team, Tech Ambassadors & Translators, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-User-Interface
Ladsgroup added a comment to T18691: RFC: Section header "share" link.

Thanks for catching there. I started looking into this now more in terms of ratios. So for example, this is the ratio of none referrer class to search engine referrer:

none_vs_search_engine.png (1,920×961 px, 87 KB)

Sat, Jun 6, 1:10 AM · User-notice, MW-1.47-notes (1.47.0-wmf.1; 2026-05-05), Wikimedia-Hackathon-2026, Patch-For-Review, Hackathon-Northwestern-Europe-2026, Reader Growth Team, Tech Ambassadors & Translators, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-User-Interface

Fri, Jun 5

Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

I thought I gave an update here. The bot is now running and compressing tiffs: https://commons.wikimedia.org/w/index.php?title=Special:Contributions/Dexbot&target=Dexbot&dir=prev&offset=20260605152652 I'll bother Matthew about dropping the old files from swift.

Fri, Jun 5, 4:08 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup added a comment to T428266: Create Wikipedia Magahi.
subprocess.CalledProcessError: Command '['git', 'push', 'ssh://gerritbot@gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMessages', 'HEAD:refs/for/master%topic=lsc']' returned non-zero exit status 128.
Fri, Jun 5, 3:05 PM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), Wiki-Setup (Create)
Ladsgroup added a comment to T428223: MMV WebP thumbnail fails with "Use thumbnail sizes listed on ...".

I made a patch exactly doing that two hours before you made the ticket and specifying exactly what to do 😅

Fri, Jun 5, 4:02 AM · MediaViewer
Ladsgroup merged T428223: MMV WebP thumbnail fails with "Use thumbnail sizes listed on ..." into T428202: Wikipedia full-screen image view does not display the image.
Fri, Jun 5, 3:59 AM · MW-1.47-notes (1.47.0-wmf.5; 2026-06-02), Reader Growth Team, MediaViewer
Ladsgroup merged task T428223: MMV WebP thumbnail fails with "Use thumbnail sizes listed on ..." into T428202: Wikipedia full-screen image view does not display the image.
Fri, Jun 5, 3:59 AM · MediaViewer
Ladsgroup updated subscribers of T428202: Wikipedia full-screen image view does not display the image.

This should fix it. cc @MatthewVernon

Fri, Jun 5, 1:49 AM · MW-1.47-notes (1.47.0-wmf.5; 2026-06-02), Reader Growth Team, MediaViewer
Ladsgroup added a comment to T428202: Wikipedia full-screen image view does not display the image.

It tries to load the webp thumbnail on the size exactly of the original. I am sure I fixed this at php level (T418745) but somewhere in the javascript-land something needs updating

Fri, Jun 5, 1:23 AM · MW-1.47-notes (1.47.0-wmf.5; 2026-06-02), Reader Growth Team, MediaViewer

Thu, Jun 4

Ladsgroup moved T426804: filerevision view should not filter out deleted file revisions from Triage to Done on the DBA board.
Thu, Jun 4, 3:46 PM · DBA, SecTeam-Processed, Privacy Engineering, cloud-services-team, Data-Services
Ladsgroup closed T426804: filerevision view should not filter out deleted file revisions, a subtask of T425191: Drop old image tables from wikireplicas, as Resolved.
Thu, Jun 4, 3:46 PM · Patch-For-Review, cloud-services-team, Data-Services
Ladsgroup closed T426804: filerevision view should not filter out deleted file revisions as Resolved.
Thu, Jun 4, 3:46 PM · DBA, SecTeam-Processed, Privacy Engineering, cloud-services-team, Data-Services
Ladsgroup added a comment to T428102: Request creation of tiff compression VPS project.

Sounds good. Thanks!

Thu, Jun 4, 2:05 PM · Cloud-VPS (Project-requests)
Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

Wearing my WMF staff hat, I'd like to note that "we should not store uncompressed TIFFs in commons" is definitely our call to make, and "upload tooling should not upload uncompressed TIFFs to commons" likely also.

Thu, Jun 4, 1:21 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup closed T428054: Create new mailing lists: foundationbulletin@lists.wikimedia.org as Resolved.

https://lists.wikimedia.org/postorius/lists/foundation-bulletin.lists.wikimedia.org/ {{done}}

Thu, Jun 4, 12:44 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T245748: Phase out JS-based legacy page indicators.

That leave three wikis:

  • nlwiki: Needs some work
  • bnwikimedia: I don't have accounts there, it's a fishbowl wiki. I don't want to barge in via maint-script-created account either.
  • bewikimedia: Uses styling that stops applying once we switch to indicator. Not impossible to fix but needs a bit of work.
Thu, Jun 4, 1:01 AM · Local-Wiki-Template-And-Gadget-Issues, MediaWiki-core-Hackathon-2024, MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, Technical-Debt
Ladsgroup updated the task description for T245748: Phase out JS-based legacy page indicators.
Thu, Jun 4, 12:59 AM · Local-Wiki-Template-And-Gadget-Issues, MediaWiki-core-Hackathon-2024, MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, Technical-Debt
Ladsgroup updated the task description for T245748: Phase out JS-based legacy page indicators.
Thu, Jun 4, 12:54 AM · Local-Wiki-Template-And-Gadget-Issues, MediaWiki-core-Hackathon-2024, MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, Technical-Debt
Ladsgroup updated the task description for T245748: Phase out JS-based legacy page indicators.
Thu, Jun 4, 12:51 AM · Local-Wiki-Template-And-Gadget-Issues, MediaWiki-core-Hackathon-2024, MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, Technical-Debt
Ladsgroup updated the task description for T245748: Phase out JS-based legacy page indicators.
Thu, Jun 4, 12:47 AM · Local-Wiki-Template-And-Gadget-Issues, MediaWiki-core-Hackathon-2024, MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, Technical-Debt
Ladsgroup updated the task description for T245748: Phase out JS-based legacy page indicators.
Thu, Jun 4, 12:45 AM · Local-Wiki-Template-And-Gadget-Issues, MediaWiki-core-Hackathon-2024, MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, Technical-Debt
Ladsgroup added a comment to T428086: Disallow uploading of uncompressed tiff files.

yup

Thu, Jun 4, 12:42 AM · Commons, MediaWiki-Uploading, MediaWiki-File-management
Ladsgroup updated the task description for T245748: Phase out JS-based legacy page indicators.
Thu, Jun 4, 12:28 AM · Local-Wiki-Template-And-Gadget-Issues, MediaWiki-core-Hackathon-2024, MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, Technical-Debt
Ladsgroup updated the task description for T245748: Phase out JS-based legacy page indicators.
Thu, Jun 4, 12:25 AM · Local-Wiki-Template-And-Gadget-Issues, MediaWiki-core-Hackathon-2024, MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, Technical-Debt

Wed, Jun 3

Ladsgroup added a comment to T427465: Move thumbnail caching from upload cluster to text.

Moving images to under the subdomain of the wikis bring a lot of complexities. These are things to come to mind right now (and there might be more): How to do CSP. Making sure problematic files can't access sensitive cookies, how to do cache defragmentieren and so on. I personally prefer that files that anyone on the internet can upload to be served from a different domain just for the sake of security hardening but security hardening can happen somewhere else.

Wed, Jun 3, 11:52 PM · Patch-For-Review, Data-Persistence, Traffic
Ladsgroup added a comment to T428054: Create new mailing lists: foundationbulletin@lists.wikimedia.org.

Is it okay if I create it under foundation-bulletin@lists.wikimedia.org given the above page?

Wed, Jun 3, 10:32 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T428086: Disallow uploading of uncompressed tiff files.

If we have to compress it to see how much is compressed, we can simply just save the compressed version then :D

Wed, Jun 3, 10:27 PM · Commons, MediaWiki-Uploading, MediaWiki-File-management
Ladsgroup added a comment to T428102: Request creation of tiff compression VPS project.

In the long term and by that time, T428086: Disallow uploading of uncompressed tiff files will be done to prevent further issues.

Wed, Jun 3, 10:27 PM · Cloud-VPS (Project-requests)
Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

T428102: Request creation of tiff compression VPS project to run the bot

Wed, Jun 3, 10:25 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup created T428102: Request creation of tiff compression VPS project.
Wed, Jun 3, 10:22 PM · Cloud-VPS (Project-requests)
Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

Creating a ticket to request a temporary cloud VPS project for it is in my todo list for today. I hope I can get to it ASAP. Sorry! but we have been thinking exactly the same ideas interdependently.

Wed, Jun 3, 7:45 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

I think one of the questions that needs to be asked here is, are many of these files really needed? Some may have educational value, but there are others that provide no information at all. I often use WikiShootMe to review and categorize images with coordinates in my country, and sometimes I find images taken from the ISS that contain nothing but darkness.

Wed, Jun 3, 6:16 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

File: T428086: Disallow uploading of uncompressed tiff files

Wed, Jun 3, 5:03 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup created T428086: Disallow uploading of uncompressed tiff files.
Wed, Jun 3, 5:03 PM · Commons, MediaWiki-Uploading, MediaWiki-File-management
Ladsgroup added a comment to T428060: codfw: move public baremetal servers to per rack vlan.

mailman is now owned by collaboration-services !

Wed, Jun 3, 4:53 PM · SRE, DC-Ops, ops-codfw
Ladsgroup added a comment to T428054: Create new mailing lists: foundationbulletin@lists.wikimedia.org.

I get it done ASAP. In the meantime, do you think we can find a better name for it? see https://meta.wikimedia.org/wiki/Mailing_lists/Standardization

Wed, Jun 3, 1:22 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T706: Requests for addition to the #acl*Project-Admins group (in comments).

Hello! I'm the EM of the Tools Platform team, responsible for maintaining and evolving Toolforge. I'd like to be added to acl*Project-Admins so I can create milestones & sub-projects to organize my team's work. TIA!

Wed, Jun 3, 9:34 AM · Tracking-Neverending, Project-Admins
Ladsgroup added a member for acl*Project-Admins: aputhin.
Wed, Jun 3, 9:33 AM

Tue, Jun 2

Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

And it can't even upload the new files:

ERROR: An error occurred for uri https://commons.wikimedia.org/w/api.php
ERROR: Traceback (most recent call last):
  File "/home/amir/p3/lib/python3.13/site-packages/pywikibot/data/api/_requests.py", line 734, in _http_request
    response = http.request(self.site, uri=uri,
                            method='GET' if use_get else 'POST',
                            data=data, headers=headers)
  File "/home/amir/p3/lib/python3.13/site-packages/pywikibot/comms/http.py", line 329, in request
    r = fetch(baseuri, headers=headers, **kwargs)
  File "/home/amir/p3/lib/python3.13/site-packages/pywikibot/comms/http.py", line 506, in fetch
    callback(response)
    ~~~~~~~~^^^^^^^^^^
  File "/home/amir/p3/lib/python3.13/site-packages/pywikibot/comms/http.py", line 389, in error_handling_callback
    raise response from None
  File "/home/amir/p3/lib/python3.13/site-packages/pywikibot/comms/http.py", line 496, in fetch
    response = session.request(method, uri,
                               headers=headers, auth=auth, timeout=timeout,
                               **kwargs)
  File "/home/amir/p3/lib/python3.13/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/amir/p3/lib/python3.13/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
  File "/home/amir/p3/lib/python3.13/site-packages/requests/adapters.py", line 659, in send
    raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', TimeoutError('The write operation timed out'))
Tue, Jun 2, 11:47 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

Example: https://commons.wikimedia.org/wiki/File:LVGL-SL_-_DOP20IR_-_346000_5490000_(2025).tif

Tue, Jun 2, 11:45 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

I wrote a script to proactively compress tiff files, and it works pretty nice so far:

Processing: File:LVGL-SL - DOP20IR - 345000 5489000 (2025).tif
Success! Reduced by 62.62% (75030424 -> 28043302 bytes).
Tue, Jun 2, 11:40 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

Notified the uploader: https://commons.wikimedia.org/wiki/User_talk:PantheraLeo1359531#Compression_of_TIFF_files

Tue, Jun 2, 10:06 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

or in other words, total storage of our originals looks like this:
https://grafana.wikimedia.org/d/75a174f3-44b6-4416-a8b8-201ad5a0c09f/swift-krinkle-copy?orgId=1&from=now-1y&to=now&timezone=utc&var-site=$__all&viewPanel=panel-37

image.png (1,897×1,022 px, 85 KB)

Tue, Jun 2, 10:02 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup added a comment to T427949: Uncompressed TIFFs on commons.

As some data:

Tue, Jun 2, 9:19 PM · media-backups, MediaWiki-File-management, SRE, SRE-swift-storage, Commons
Ladsgroup added a comment to T427884: Create database grants for cumin2003.

I updated https://people.wikimedia.org/~ladsgroup/omg/ have fun!!!

Tue, Jun 2, 6:43 PM · DBA
Ladsgroup added a comment to T427884: Create database grants for cumin2003.

The documentation and link to automation: https://wikitech.wikimedia.org/wiki/MariaDB/Changing_user_passwords

Tue, Jun 2, 5:43 PM · DBA
Ladsgroup added a comment to T427884: Create database grants for cumin2003.

Sure thing!

Tue, Jun 2, 11:56 AM · DBA
Ladsgroup added a comment to T421705: Move mariadb hosts to nftables.

After migrating pc2022 to nftables we noticed a bump of connections tracked. The root cause is that on ferm connection tracking was disabled for 3306 being the source and dest port:

  • /etc/ferm/conf.d/10_mariadb_internal.conf configures NO_TRACK for the entire 3306 port (via /etc/ferm/functions.conf)
  • on nftables in /etc/nftables/notrack/10_mariadb_internal.nft we only set notrack for the destination port

This is no issue for pc2022, we have plenty of headroom on it. But we should resolve this before we move further mariadb nodes.

Tue, Jun 2, 12:54 AM · DBA

Mon, Jun 1

Ladsgroup added a comment to T424032: MediaSearch results does not use the standard thumbnail sizes.

The original file is on 120px which is a standard size, then it gets 180px which is not and gets blocked:

image.png (774×112 px, 19 KB)

Mon, Jun 1, 5:18 PM · MW-1.47-notes (1.47.0-wmf.5; 2026-06-02), MW-1.46-notes (1.46.0-wmf.24; 2026-04-14), MediaSearch, Commons
Ladsgroup added a comment to T424032: MediaSearch results does not use the standard thumbnail sizes.

I love how it first appears and then disappears... I guess javascript is overriding a perfectly good thumb with a non-standard one.

Mon, Jun 1, 5:09 PM · MW-1.47-notes (1.47.0-wmf.5; 2026-06-02), MW-1.46-notes (1.46.0-wmf.24; 2026-04-14), MediaSearch, Commons
Ladsgroup moved T423577: Undeploy FlaggedRevs from Wikinews and drop FlaggedRevs tables from Triage to Done on the DBA board.
Mon, Jun 1, 5:07 PM · DBA, Wikimedia-Site-requests
Ladsgroup closed T423577: Undeploy FlaggedRevs from Wikinews and drop FlaggedRevs tables as Resolved.
Mon, Jun 1, 5:06 PM · DBA, Wikimedia-Site-requests
Ladsgroup added a comment to T304538: Clean up GrowthExperiments-related user_properties rows.

Hi, is there anything I can do to help moving this forward? Thank you!

Mon, Jun 1, 2:32 PM · Growth Team Maintenance, Technical-Debt, GrowthExperiments
Ladsgroup closed T421797: Remove Wikinews from various multilingual portals as Resolved.

https://www.wikinews.org/?sdfwerwe

Mon, Jun 1, 2:29 PM · Wikimedia-Portals
Ladsgroup closed T118538: Reduce the usage of API format=php as Resolved.
Mon, Jun 1, 1:51 PM · MW-1.47-notes (1.47.0-wmf.1; 2026-05-05), Patch-For-Review, User-notice, MW-Interfaces-Team, Technical-Debt, MediaWiki-Action-API
Ladsgroup added a comment to T421797: Remove Wikinews from various multilingual portals.

Yeah, I can deploy it a bit later today. didn't want to deploy on Friday.

Mon, Jun 1, 10:43 AM · Wikimedia-Portals

Sun, May 31

Ladsgroup added a comment to T18691: RFC: Section header "share" link.

Some data for Persian Wikipedia where it had the section share functionality gadget since April 9th: https://w.wiki/QTg$

image.png (1,425×941 px, 98 KB)

Sun, May 31, 10:46 PM · User-notice, MW-1.47-notes (1.47.0-wmf.1; 2026-05-05), Wikimedia-Hackathon-2026, Patch-For-Review, Hackathon-Northwestern-Europe-2026, Reader Growth Team, Tech Ambassadors & Translators, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-User-Interface

Fri, May 29

Ladsgroup closed T355878: suppress TOC sidebar by default on zhwikinews main namespace as Declined.

Boldly declining since the wiki is now closed.

Fri, May 29, 7:24 PM · Content-Transform-Team, Chinese-Sites, Wikimedia-Site-requests
Ladsgroup added a comment to T427465: Move thumbnail caching from upload cluster to text.

A couple of thoughts. I am broadly in favour of handling thumbs and originals separately :)

First - our delightful rewrite middleware uses the /thumb/ in the URI path to know to rewrite the request to the relevant thumbnail container. That middleware currently is server-hostname-agnostic (because it assumes it's always the same, as does the associated test suite). So we could at least in theory teach it new URI schemes for accessing the thumbs, but it'd need doing with care.

Fri, May 29, 3:47 PM · Patch-For-Review, Data-Persistence, Traffic
Ladsgroup added a comment to T424357: Remove lag protection from WANObjectCache.

Yeah. It was brought up here and I asked the question there. Why do we need to build such protection? Has there been a case of uncommitted data ending up in WAN in vanilla setups? The patch that introduced it is not connected to any tickets. Also since WAN relies on callers actually passing the db object which in many cases it doesn't happen so I'd argue it hasn't done the job of that protection well but nothing ever got reported on it so I'd say it was never needed in the first place.

Fri, May 29, 1:57 PM · ServiceOps-Mediawiki, ServiceOps new, MediaWiki-Platform-Team (Radar), Patch-For-Review, MediaWiki-libs-BagOStuff

Thu, May 28

Ladsgroup added a comment to T427465: Move thumbnail caching from upload cluster to text.

We could eventually move MPEG-DASH files to text too, they are similar in nature.

On the QoS side we might be better keeping all video in low-priority I feel. I’m constantly paranoid of popular video ramping up bandwidth by many orders of magnitude. MPEG-DASH will help as it’s responsive, but to make sure it responds well it should be low priority. We can discuss again.

Thu, May 28, 3:04 PM · Patch-For-Review, Data-Persistence, Traffic
Ladsgroup added a comment to T366938: Reduce relying on database locks .

Regardless of how this work will continue, I would like to iterate once more that our Redis infrastructure currently is not HA, has no fault tolerance, and it needs manual intervention in case of host failures.

Thu, May 28, 2:49 PM · DBA, Patch-For-Review, MW-1.47-notes (1.47.0-wmf.1; 2026-05-05), MW-1.45-notes (1.45.0-wmf.24; 2025-10-21), MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, MediaWiki-Page-derived-data, MW-Interfaces-Team
Ladsgroup added a comment to T415237: etherpad table size is 233GB / plan to delete all etherpads.

That looks very unrelated and an actual problem. Can you clear the cache?

Thu, May 28, 1:26 PM · User-notice, collaboration-services, Wikimedia-Etherpad, Data-Persistence
Ladsgroup created T427465: Move thumbnail caching from upload cluster to text.
Thu, May 28, 2:14 AM · Patch-For-Review, Data-Persistence, Traffic
Ladsgroup closed T426984: Create Conductwiki wiki as Resolved.

So the wiki is live now: https://conduct.wikimedia.org/wiki/Fooo

Thu, May 28, 12:31 AM · Wiki-Setup (Create)
Ladsgroup added a comment to T426984: Create Conductwiki wiki.

Swift ACL looks correct:

wikipedia-conduct-local-deleted:
              Read ACL: mw:thumbor-private,mw:media
             Write ACL: mw:thumbor-private,mw:media
wikipedia-conduct-local-public:
              Read ACL: mw:thumbor-private,mw:media
             Write ACL: mw:thumbor-private,mw:media
wikipedia-conduct-local-temp:
              Read ACL: mw:thumbor-private,mw:media
             Write ACL: mw:thumbor-private,mw:media
wikipedia-conduct-local-thumb:
              Read ACL: mw:thumbor-private,mw:media
             Write ACL: mw:thumbor-private,mw:media
wikipedia-conduct-local-transcoded:
              Read ACL: mw:thumbor-private,mw:media
             Write ACL: mw:thumbor-private,mw:media
wikipedia-conduct-timeline-render:
              Read ACL: mw:thumbor-private,mw:media
             Write ACL: mw:thumbor-private,mw:media
Thu, May 28, 12:27 AM · Wiki-Setup (Create)
Ladsgroup added a comment to T426984: Create Conductwiki wiki.

Database and other stuff has been done. Swift seems to be setting the private flag correctly:

[set-zone-access] Configuring Swift zones... 
Running maintenance script class as if executing: setZoneAccess.php --wiki=conductwiki --backend=local-multiwrite --private=1
Making sure mwstore://local-multiwrite/local-public exists...making 'mwstore://local-multiwrite/local-public' private...done.
Making sure mwstore://local-multiwrite/local-thumb exists...making 'mwstore://local-multiwrite/local-thumb' private...done.
Making sure mwstore://local-multiwrite/local-transcoded exists...making 'mwstore://local-multiwrite/local-transcoded' private...done.
Making sure mwstore://local-multiwrite/local-temp exists...making 'mwstore://local-multiwrite/local-temp' private...done.
Making sure mwstore://local-multiwrite/local-deleted exists...making 'mwstore://local-multiwrite/local-deleted' private...done.
Making sure mwstore://local-multiwrite/timeline-render exists...making 'mwstore://local-multiwrite/timeline-render' private...done.
Thu, May 28, 12:15 AM · Wiki-Setup (Create)

Wed, May 27

Ladsgroup added a comment to T426984: Create Conductwiki wiki.

Who should be the initial user, can you send me username and email address privately @Keegan? (in Slack maybe)

Wed, May 27, 11:01 PM · Wiki-Setup (Create)
Ladsgroup added a comment to T426984: Create Conductwiki wiki.

I see conductwiki.%, is now part of Replicate_Wild_Ignore_Table so it won't show up in wikireplicas.

Wed, May 27, 10:55 PM · Wiki-Setup (Create)
Ladsgroup added a comment to T426984: Create Conductwiki wiki.
ladsgroup@deploy1003:~$ sudo run-puppet-agent
Info: Using environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for deploy1003.eqiad.wmnet
Info: Applying configuration version '(3c9bcca808) Ladsgroup - Add config for conductwiki'
Notice: /Stage[main]/Mediawiki::Web::Yaml_defs/File[/etc/helmfile-defaults/mediawiki/httpd.yaml]/content: 
--- /etc/helmfile-defaults/mediawiki/httpd.yaml 2026-03-26 16:24:29.323878037 +0000
+++ /tmp/puppet-file20260527-3453365-1dz52gi    2026-05-27 22:29:36.682541141 +0000
@@ -793,6 +793,10 @@
     - legacy_rewrites: false
       short_urls: true
       https_only: true
+      name: conduct.wikimedia.org
+    - legacy_rewrites: false
+      short_urls: true
+      https_only: true
       name: electcom.wikimedia.org
     - legacy_rewrites: false
       short_urls: true
Wed, May 27, 10:32 PM · Wiki-Setup (Create)
Ladsgroup added a comment to T424357: Remove lag protection from WANObjectCache.

There has been always the assumption that data in WAN is stale, at least for a bit. So I'm failing to see this fixing an actual problem that is hurting users or integrity of the data.

Stale data on read is fine indeed, because we treat reads from WANCache the same as reads from replica DBs, callers must tolerate a certain amount of lag, and otherwise require an uncached primary DB read (i.e. to inform writes during POST requests). There should generally not be a case where a read query can be satisfied by replica DB but not WANCache. The idea is that caching can be used without adding additional concens to callers.

The issue with stale DB reads is not the effect on the HTTP response (which will have a shorted CDN expiry), but the effect on future callers. Once stale data is placed into the cache, it does not self-correct.

I think as a first step, I'd like to simplify and automate this, rather than remove it. We can measure the impact with a Prometheus counter.

This would accomplish the same as your patch:

  • Remove the WANObjectCache lag and since options from the public API.
  • Remove Database::getCacheSetOptions method and need for developers to call it as part of boilerplate.

Exept, it would retain the protection in an automatic way, such that we automatically shorten the TTL for any WANObjectCache::getWithSet calls when a replica DB was used that is lagged outside acceptable bounds. This is similar to what we already do:

  • shorten HTTP response cache to $wgCdnMaxageLagged, if lagged replica is used.
  • shorten HTTP response cache to $wgCdnMaxageStale, if known-stale ParserOutput is used via lost PoolCounter lock.
  • [this task] shorten Memcached expiry to 30s, if there we involved a lagged replica DB.
  • shorten Memcached expiry to 1s, during the 10s hold-off period after a purge (via interim key).
  • shorten Memcached expiry to 1s, if using TSE-lock option, value is absent, and lost the lock (via interim value).
  • shorten Memcached expiry to 10s, if the hashed host is TKO (via mcrouter gutter pool).
Wed, May 27, 4:03 PM · ServiceOps-Mediawiki, ServiceOps new, MediaWiki-Platform-Team (Radar), Patch-For-Review, MediaWiki-libs-BagOStuff