Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani (WMDE))
Master of introducing new bugsAdministrator

Projects (26)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (232 w, 2 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Babel: fa-N, en-4, de-1, tr-1

Recent Activity

Today

Ladsgroup created T218918: lnterface messages are loading old messages.
Thu, Mar 21, 5:09 PM · MediaWiki-Internationalization, I18n, Language-Team
Ladsgroup added a comment to T217730: Connect wikimaniawiki to Wikidata.

Hello all,

Quick update: the links don't appear because the section "In other projects" doesn't seem to be enabled on wikimaniawiki. (see how it is on meta for example). Once this section is enabled, you should be able to have the other wikimedia projects links displayed.

I will fix it

(btw, the wikimediawiki link is displayed as "⧼wikibase-otherprojects-wikimania⧽", can someone fix it?

and this one.

Thu, Mar 21, 12:35 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Mill <mill@mail.com> committed rEWLE4fb25b0012f0: bjbaaaaaaaaaaa (authored by Ladsgroup).
bjbaaaaaaaaaaa
Thu, Mar 21, 12:41 AM
Ladsgroup committed rEWLE47c6a927f2df: Use baserevid in Senses editing (authored by Ladsgroup).
Use baserevid in Senses editing
Thu, Mar 21, 12:41 AM
Ladsgroup committed rEWLE55dbdacca890: Use baserevid in Senses editing (authored by Ladsgroup).
Use baserevid in Senses editing
Thu, Mar 21, 12:41 AM
Ladsgroup committed rEWLEdcf0580e9f7d: Use baserevid in Forms editing (authored by Ladsgroup).
Use baserevid in Forms editing
Thu, Mar 21, 12:41 AM
Ladsgroup committed rEWLE0eb3e27dfcff: Use baserevid in Forms editing (authored by Ladsgroup).
Use baserevid in Forms editing
Thu, Mar 21, 12:41 AM
Ladsgroup committed rEWLE40be3e17a9f5: Use baserevid in Forms editing (authored by Ladsgroup).
Use baserevid in Forms editing
Thu, Mar 21, 12:41 AM
Ladsgroup committed rEWLE64d1b4badfae: Use baserevid in Senses editing (authored by Ladsgroup).
Use baserevid in Senses editing
Thu, Mar 21, 12:41 AM
Ladsgroup committed rEWLE0e8053798d41: Use baserevid in Forms editing (authored by Ladsgroup).
Use baserevid in Forms editing
Thu, Mar 21, 12:41 AM
Mill <mill@mail.com> committed rWDQG699f8b9b7e03: %26taaaaaaaaaaaa (authored by Ladsgroup).
%26taaaaaaaaaaaa
Thu, Mar 21, 12:40 AM
Mill <mill@mail.com> committed rLCSHed515300ca93: i#aaaaaaaaaaaa (authored by Ladsgroup).
i#aaaaaaaaaaaa
Thu, Mar 21, 12:25 AM

Yesterday

Ladsgroup added a comment to T217730: Connect wikimaniawiki to Wikidata.

Both done: https://www.wikidata.org/w/index.php?title=Q7251&diff=prev&oldid=888814985

Wed, Mar 20, 11:46 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T217730: Connect wikimaniawiki to Wikidata from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Mar 20, 11:45 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Tue, Mar 19

Ladsgroup added a comment to T172748: Clean up lowercase q-IDs from page_props table.

I wrote a bot to touch the pages and reparse them, it fixed around half of them. The rest are either protected or has something that abusefilter or spamfilter blocks. I don't know what to do with those...

Tue, Mar 19, 6:50 PM · User-Addshore, Wikidata
Ladsgroup added a comment to T172748: Clean up lowercase q-IDs from page_props table.
  • bat_smgwiki
  • be_x_oldwiki
  • bewiki
  • eowiki
  • hsbwiki
  • kywiki
  • map_bmswiki
  • nds_nlwiki
  • nlwiki
  • scnwiki
  • skwiki
  • test2wiki
  • zh_classicalwiki
  • zh_min_nanwiki
  • zh_yuewiki
Tue, Mar 19, 6:32 PM · User-Addshore, Wikidata
Ladsgroup added a comment to T217730: Connect wikimaniawiki to Wikidata.

The problem is two-fold. One is that wikimaniawiki is not linkable in wikidata (the site link is not possible). This is rather easiliy fixable and I can do it. The second part is that wikimaniawiki become a client of wikidata. That needs creating tables and such. I can do that too.

Tue, Mar 19, 5:54 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T217730: Connect wikimaniawiki to Wikidata.
Tue, Mar 19, 5:31 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T217670: Use baserevid in Lemma editing from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

For lemma, given that it's using the wikibase entity changer, it sends the baserevid already (from my localhost):

action	wbeditentity
format	json
id	L5
baserevid	42
data	{"lemmas":{"en":{"value":"Helo","language":"en"}},"language":"Q2","lexicalCategory":"Q2"}
bot	1
assertuser	Ladsgroup
token	f6d817105eac55cb0e51934e1cc513e35c9124ee+\
Tue, Mar 19, 5:25 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T217671: Use baserevid in Senses editing.
Tue, Mar 19, 4:35 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T217672: Use baserevid in Forms editing.
Tue, Mar 19, 4:35 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T217671: Use baserevid in Senses editing from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Mar 19, 4:35 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T217672: Use baserevid in Forms editing from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Mar 19, 4:35 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T217245: Call WikibaseLexeme API with baserevid parameter from the UI from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Mar 19, 4:35 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T217670: Use baserevid in Lemma editing.
Tue, Mar 19, 1:25 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T218122: Cache property info with one key per property.
Tue, Mar 19, 12:19 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)

Mon, Mar 18

Ladsgroup created T218567: Fix statsd config handing in ores.
Mon, Mar 18, 12:53 PM · User-Ladsgroup, ORES, Scoring-platform-team (Current)
Ladsgroup added a comment to T112715: Enable different URL shorteners for WDQS.

If we enable CORS between wikidata query service and Wikimedia projects, it shouldn't need any OAuth dance.

Mon, Mar 18, 12:19 PM · Need-volunteer, User-Smalyshev, Discovery, Wikidata, Wikidata-Query-Service

Sat, Mar 16

Ladsgroup updated Ladsgroup.
Sat, Mar 16, 2:49 PM
Ladsgroup awarded T213156: SRE FY2019 Q3:TEC6: First steps towards Canary Deployments a Love token.
Sat, Mar 16, 1:17 PM · User-jijiki, Goal, Operations, serviceops, Scap

Fri, Mar 15

Ladsgroup moved T209604: Wikilabels needs manual reboot when DB connection is broken from Active to Review on the Scoring-platform-team (Current) board.

https://github.com/wikimedia/wikilabels/pull/255

Fri, Mar 15, 9:22 PM · User-Ladsgroup, Scoring-platform-team (Current), Wikilabels
Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

I would like to understand the problem better. If DBAL can do the schema changes, why can't we use it for the schema changes, even if it doesn't help us with the other parts of the issue?

Fri, Mar 15, 9:09 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Ladsgroup created T218397: Add usc_deleted to urlshortcodes.
Fri, Mar 15, 1:05 PM · Blocked-on-schema-change, MediaWiki-extensions-UrlShortener
Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

I'm sorry for the misunderstanding, as you wish. The POC is basically what I could get out of Doctring DBAL. If you think it's not good enough, we can go with the first proposal. I leave the decision to others in here.

Fri, Mar 15, 11:00 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Thu, Mar 14

Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

I note the review so far seems to have ignored that part of schema changes is checking the existing schema to determine whether the schema needs changing (MW currently does a somewhat crappy job of this).

Good point but I think we should focus scope of this ticket to unify and abstract away schema changes and not fix all of the issues with our current schema change system.

and also to have ignored data type requirements.

This can be rather easily fixable. Look at the POC.

But if @Ladsgroup wants to try writing an implementation, I won't say he can't.

I just made something concrete so we can discuss about it.

Thu, Mar 14, 12:14 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Thu, Mar 7

Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

I looked at the codes and doctrine projects. Doctrine as a whole is too much for us, it hides so many things (like database connections) from the outside that is basically unusable. Same goes for Doctrine Migrations. But there is something called Doctrine DBAL that seems a good fit for us.
For schema creation, We basically check out a yaml/json/xml config file (I call it "database scheme config file" from now on) that DBAL can create the schema object for it. Imagine a SchemaBuilder class that does this based on a config file.
(Example from the docs)

$schema = new \Doctrine\DBAL\Schema\Schema();
$myTable = $schema->createTable("my_table");
$myTable->addColumn("id", "integer", array("unsigned" => true));
$myTable->addColumn("username", "string", array("length" => 32));
$myTable->setPrimaryKey(array("id"));
$myTable->addUniqueIndex(array("username"));
$schema->createSequence("my_table_seq");

Turning this into SQL command is pretty easy:

$queries = $schema->toSql($myPlatform);

$myPlatform can be extracted from doctrine connection object (which we don't want to have) OR we can instantiate it directly, For example for MySQL57Platform class (List of all platforms). it'll be: $platform = new MySQL57Platform();
The nice thing here is that it has different platforms for different versions of a DBMS. Something that we didn't support before.

Thu, Mar 7, 8:16 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Ladsgroup awarded T188801: Migrate wl_notificationtimestamp updates to the job queue a Love token.
Thu, Mar 7, 3:39 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Growth-Team, MediaWiki-Watchlist, Patch-For-Review, Availability (MediaWiki-MultiDC)
Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

Reading the minutes of the meeting (sorry I couldn't join) I volunteer to do a basic research on Doctorine and how feasible it is to use. Is it okay with the TechCom and @Anomie ?

Thu, Mar 7, 3:20 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Wed, Mar 6

D3r1ck01 awarded T217716: Add Wikimedia CI to code search a Like token.
Wed, Mar 6, 3:03 PM · Patch-For-Review, User-Ladsgroup, VPS-project-codesearch
Ladsgroup committed rLCSH032e9ab761fb: Add Wikimedia CI to code search (authored by Ladsgroup).
Add Wikimedia CI to code search
Wed, Mar 6, 2:41 PM
Ladsgroup claimed T217716: Add Wikimedia CI to code search.
Wed, Mar 6, 1:48 PM · Patch-For-Review, User-Ladsgroup, VPS-project-codesearch
Ladsgroup committed rADESe9d1624f0458: Remove WikimediaDb::getPdo() (authored by Ladsgroup).
Remove WikimediaDb::getPdo()
Wed, Mar 6, 11:15 AM
Ladsgroup committed rADESe244211b72b9: Rewrite user_langauges.php to use babel table and Inclusion–exclusion principle (authored by Ladsgroup).
Rewrite user_langauges.php to use babel table and Inclusion–exclusion principle
Wed, Mar 6, 11:01 AM

Tue, Mar 5

Ladsgroup added a comment to T216842: Specify license of mediawiki/Wikibase/WikibaseLexeme ontology.

Any of the patches require a +1 from all of people who contributed to the files otherwise will be legally in trouble (we can't just change license of a file)

Tue, Mar 5, 8:31 AM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Mon, Mar 4

Ladsgroup awarded T166010: The Great Namespaceization and Reorg a Love token.
Mon, Mar 4, 5:38 PM · TechCom, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), Epic, TechCom-RFC
Ladsgroup added a comment to T212181: Rename JADE->Jade in continuous integration.

There's nothing to review here. It's blocked on T212181

Mon, Mar 4, 5:34 PM · Scoring-platform-team (Current), Patch-For-Review, Continuous-Integration-Config, Jade
Ladsgroup added a comment to T211473: JADE\Tests\Hooks\MoveHooksTest::testOnMovePageIsValidMove is broken.

The patch mentioned here is merged: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/JADE/+/476993
Should we call this done or is it still ongoing?

Mon, Mar 4, 5:33 PM · Scoring-platform-team (Current), Core Platform Team Backlog (Watching / External), Multi-Content-Revisions (Reactive), Jade
Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

Not supporting CI for any non-free software, but having support for that non-free software in core, seems contradictory. We should have both, or neither.

Mon, Mar 4, 4:16 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Ladsgroup committed rADESaf8a087f616d: Remove WikimediaDb::getPdo() (authored by Ladsgroup).
Remove WikimediaDb::getPdo()
Mon, Mar 4, 3:46 PM
Ladsgroup moved T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Mar 4, 3:42 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering
Ladsgroup committed rADES86669605f0f7: Rewrite user_langauges.php to use babel table and Inclusion–exclusion principle (authored by Ladsgroup).
Rewrite user_langauges.php to use babel table and Inclusion–exclusion principle
Mon, Mar 4, 3:39 PM
Ladsgroup updated the task description for T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup.
Mon, Mar 4, 2:13 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering
Ladsgroup committed rADES94f6529088b7: Change conditions on active_users (authored by Ladsgroup).
Change conditions on active_users
Mon, Mar 4, 1:34 PM
Ladsgroup committed rADES04d05f6c145e: Change conditions on active_users (authored by Ladsgroup).
Change conditions on active_users
Mon, Mar 4, 11:56 AM

Sun, Mar 3

Ladsgroup committed rADES5dd499c6812f: Rebuild the PDO when the insert fails (authored by Ladsgroup).
Rebuild the PDO when the insert fails
Sun, Mar 3, 6:35 PM
Ladsgroup added a comment to T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup.

The patch I put up fixes the issue there: https://grafana.wikimedia.org/d/000000259/betafeatures?refresh=5m&orgId=1

Sun, Mar 3, 6:23 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering

Sat, Mar 2

Ladsgroup added a comment to T213976: Workflow to be able to move data files computed in jobs from analytics cluster to production .

The idea is fine (I've been having the same for over 1 year now), but 1 important point. Not in the production kubernetes clusters please as those are dedicated to service traffic. But I can see a kubernetes cluster existing for easing batch processing jobs, although the specifics of such an installation should be discussed broadly.

Sat, Mar 2, 9:41 PM · Research, Operations, Discovery, Analytics
Ladsgroup claimed T209604: Wikilabels needs manual reboot when DB connection is broken.

I will do it gradually.

Sat, Mar 2, 5:27 PM · User-Ladsgroup, Scoring-platform-team (Current), Wikilabels
Ladsgroup committed rADES7904198c9174: Rebuild the PDO when the insert fails (authored by Ladsgroup).
Rebuild the PDO when the insert fails
Sat, Mar 2, 12:56 PM
Ladsgroup moved T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Sat, Mar 2, 12:52 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering
Ladsgroup added a comment to T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup.

Looking at the logs it's very likely due to lack of write rights (pun intended) for the wmde db user (in /etc/mysql/conf.d/research-wmde-client.cnf). Hopefully this will be fixed soon.

It's not, back to square one.
One note: The beta features scripts takes seven hours to finish. We should find a better way for this.

Sat, Mar 2, 12:51 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering

Fri, Mar 1

Ladsgroup updated subscribers of T217388: Use a 4th constant in rc_patrolled for unpatrollable log entries and categorization changes.

I would appreciate @Catrope's thoughts here but in general, after defining autopatrol state in RC, we had to add lots of bits to the API to handle it properly. See T184791: Make rc_patrolled 3-state instead of 2-state to distinguish autopatrolled edits. It's not as easy as adding just one more state.

Fri, Mar 1, 7:55 PM · MediaWiki-Patrolling, Growth-Team, MediaWiki-Recent-changes
Ladsgroup added a comment to T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup.

Looking at the logs it's very likely due to lack of write rights (pun intended) for the wmde db user (in /etc/mysql/conf.d/research-wmde-client.cnf). Hopefully this will be fixed soon.

Fri, Mar 1, 5:52 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering
Ladsgroup added a comment to T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup.

The ./wikidata/site_stats/user_languages.php is such a mess I doubt we will be able to do it at all if not with lots of work :(((

Fri, Mar 1, 4:56 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering
Ladsgroup moved T215556: Enable phan checks for WikibaseLexeme extension from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Filed T217425: Enable disabled phan checks in WikibaseLexeme for more work

Fri, Mar 1, 4:55 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), phan, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Continuous-Integration-Config, Lexicographical data
Ladsgroup created T217425: Enable disabled phan checks in WikibaseLexeme.
Fri, Mar 1, 4:53 PM · Lexicographical data, Wikidata, Wikidata-Campsite
Ladsgroup placed T214841: ores sends duplicate page text over the wire up for grabs.
Fri, Mar 1, 4:23 PM · User-Ladsgroup, Scoring-platform-team (Current), Performance, ORES
Ladsgroup moved T210580: Write puppet for redis-sentinel from Ready to go to Maintenance/cleanup on the Scoring-platform-team board.
Fri, Mar 1, 4:21 PM · Scoring-platform-team, Patch-For-Review, Puppet, ORES
Ladsgroup moved T210577: Build a test setup for redis sentinel in cloud VPS from Ready to go to Maintenance/cleanup on the Scoring-platform-team board.
Fri, Mar 1, 4:21 PM · Scoring-platform-team, ORES
Ladsgroup moved T210605: Run a test failover in labs before migrating prod to sentinel from Ready to go to Maintenance/cleanup on the Scoring-platform-team board.
Fri, Mar 1, 4:21 PM · Scoring-platform-team, User-Ladsgroup, ORES
Ladsgroup moved T210582: New node request: oresrdb[12]003 from Ready to go to Maintenance/cleanup on the Scoring-platform-team board.
Fri, Mar 1, 4:21 PM · Scoring-platform-team, Operations, vm-requests, ORES
Ladsgroup added a comment to T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup.

Looking at the logs it's very likely due to lack of write rights (pun intended) for the wmde db user (in /etc/mysql/conf.d/research-wmde-client.cnf). Hopefully this will be fixed soon.

Fri, Mar 1, 4:08 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering
Ladsgroup added a comment to T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup.

Hmm it seems that on https://grafana.wikimedia.org/d/000000259/betafeatures the Global users enabled Features are broken. :-/

Fri, Mar 1, 3:41 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering
Ladsgroup committed rADES8059e10ca11f: Fix active_users.php by doing most of the work in code (authored by Ladsgroup).
Fix active_users.php by doing most of the work in code
Fri, Mar 1, 3:22 PM
Ladsgroup committed rADES62538b24b7b0: Fix active_users.php by doing most of the work in code (authored by Ladsgroup).
Fix active_users.php by doing most of the work in code
Fri, Mar 1, 3:18 PM
Ladsgroup placed T215363: Create new editquality labeling campaign for hewiki up for grabs.
Fri, Mar 1, 3:18 PM · Scoring-platform-team (Current), User-Ladsgroup, ORES
Ladsgroup committed rADES6ec245623d27: Fix active_users.php by doing most of the work in code (authored by Ladsgroup).
Fix active_users.php by doing most of the work in code
Fri, Mar 1, 3:08 PM

Thu, Feb 28

Ladsgroup updated the task description for T216613: Update outdated scripts feeding QWERTY-related Grafana boards.
Thu, Feb 28, 7:13 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-20, Regression, TCB-Team
Ladsgroup committed rADESc518f15b2636: Move reads to multi-source db setup (authored by Ladsgroup).
Move reads to multi-source db setup
Thu, Feb 28, 4:31 PM
Ladsgroup added a comment to T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup.

Echo is back: https://grafana.wikimedia.org/d/000000270/echo-mention-status-notifications?refresh=1m&orgId=1&from=now-30d&to=now
Beta features is back partially: https://grafana.wikimedia.org/d/000000259/betafeatures?refresh=5m&orgId=1

Thu, Feb 28, 12:16 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering
Ladsgroup added a comment to T217285: commonswiki / wikibase: Postcondition failed: Namespace for entity type property must be defined!.

Federation is not and should not currently be turned on on commonswiki.
It looks like the thing that caused the logspam was indeed media info UI code calling the API, when it should not have been calling it.
However the underlying issue is in Wikibase (and only shows itself on commons now as this is the first time we have not had all entities enabled)
When calls are made to the API for entity types that are not enabled it should fail gracefully, not expose an exception to the user.

Thu, Feb 28, 12:07 PM · Wikidata-Campsite, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), WikibaseMediaInfo, Wikidata, Wikimedia-production-error

Wed, Feb 27

Ladsgroup moved T217285: commonswiki / wikibase: Postcondition failed: Namespace for entity type property must be defined! from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Feb 27, 11:45 PM · Wikidata-Campsite, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), WikibaseMediaInfo, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T217285: commonswiki / wikibase: Postcondition failed: Namespace for entity type property must be defined!.

This is result of the entity namespace lookup for commons in beta:

$namespaceLookup = \Wikibase\Repo\WikibaseRepo::getDefaultInstance()->getEntityNamespaceLookup();
Wed, Feb 27, 11:35 PM · Wikidata-Campsite, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), WikibaseMediaInfo, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T217285: commonswiki / wikibase: Postcondition failed: Namespace for entity type property must be defined!.

I suspect it's a config issue. Federation works in beta cluster:
https://commons.wikimedia.beta.wmflabs.org/w/api.php?action=wbgetentities&ids=P17
https://commons.wikimedia.beta.wmflabs.org/w/api.php?action=wbformatvalue&format=json&datavalue={%22type%22%3A%22wikibase-entityid%22%2C%22value%22%3A{%22id%22%3A%22P18%22}}&options={%22lang%22%3A%22en%22}&generate=text%2Fhtml

Wed, Feb 27, 11:08 PM · Wikidata-Campsite, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), WikibaseMediaInfo, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T217285: commonswiki / wikibase: Postcondition failed: Namespace for entity type property must be defined!.

It's not just wbformatevalue. it's basically every wikibase API module:
https://commons.wikimedia.org/w/api.php?action=wbgetentities&ids=P17
https://commons.wikimedia.org/w/api.php?action=wbgetclaims&entity=Q42&property=P31

Wed, Feb 27, 11:05 PM · Wikidata-Campsite, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), WikibaseMediaInfo, Wikidata, Wikimedia-production-error
Ladsgroup edited projects for T217285: commonswiki / wikibase: Postcondition failed: Namespace for entity type property must be defined!, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Patch-For-Review.
Wed, Feb 27, 9:22 PM · Wikidata-Campsite, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), WikibaseMediaInfo, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T217280: LDAP server running out of memory frequently and disrupting Cloud VPS clients.

At first I though I couldn't "become" dexbot but this was just a warning. Now I restarted the webservice and things seem working for now. I don't know why my webservice went down out of nowhere.

Wed, Feb 27, 8:19 PM · cloud-services-team (Kanban), Patch-For-Review, Operations, Cloud-VPS, LDAP, Toolforge
Ladsgroup renamed T217280: LDAP server running out of memory frequently and disrupting Cloud VPS clients from dexbot tools is completely gone to groups: cannot find name for group ID.
Wed, Feb 27, 8:18 PM · cloud-services-team (Kanban), Patch-For-Review, Operations, Cloud-VPS, LDAP, Toolforge
Ladsgroup created T217280: LDAP server running out of memory frequently and disrupting Cloud VPS clients.
Wed, Feb 27, 7:59 PM · cloud-services-team (Kanban), Patch-For-Review, Operations, Cloud-VPS, LDAP, Toolforge
GitHub <noreply@github.com> committed rORES8a4ee1b7399a: Merge 87f169e2e1b8085bb3839b685260d159e0012ece into… (authored by Ladsgroup).
Merge 87f169e2e1b8085bb3839b685260d159e0012ece into…
Wed, Feb 27, 2:57 PM
Ladsgroup awarded T176370: Migrate to PHP 7 in WMF production a Love token.
Wed, Feb 27, 12:29 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
Ladsgroup committed rADES6540a4686efe: Move reads to multi-source db setup (authored by Ladsgroup).
Move reads to multi-source db setup
Wed, Feb 27, 11:50 AM
Ladsgroup committed rADES4b5da9921b99: Fix typo (authored by Ladsgroup).
Fix typo
Wed, Feb 27, 11:41 AM
Ladsgroup committed rADES085df745c038: Move reads to multi-source db setup (authored by Ladsgroup).
Move reads to multi-source db setup
Wed, Feb 27, 11:41 AM
Ladsgroup added a comment to T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup.

With my patch, everything is fixed except src/wikidata/site_stats/active_users.php and src/wikidata/site_stats/user_languages.php because they are both read and write at the same time. I will fix those in a later patch.

Wed, Feb 27, 11:39 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering
Ladsgroup updated the task description for T213894: Modify analytics/wmde/scripts repo to work with the new analytics multisource db setup.
Wed, Feb 27, 11:38 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, German-Community-Wishlist, WMDE-FUN-Team, TCB-Team, Wikidata, WMDE-Analytics-Engineering
Ladsgroup committed rEWLEb16418581675: Add phan config file (authored by Ladsgroup).
Add phan config file
Wed, Feb 27, 10:09 AM

Tue, Feb 26

Ladsgroup moved T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array [] from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

This is one of the weirdest cases I've done. PHP doesn't distinguish between array and associative arrays when they are empty and there is no way to send this information around in php while in python they are completely different objects (lists and dictionaries). The reason that wbgetentity API module and the dumpers return {} instead of [] is because these containers are not passed around empty, they contain hidden elements that you can see when you change the formatting to xml (and for whatever reason, mediawiki needs to support xml output forever and beyond) but when they are turned to json, the hidden elements get stripped away but json knows it's a associative array.

Tue, Feb 26, 7:00 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-DataModel-Serialization, Wikidata, MediaWiki-extensions-WikibaseRepository
Ladsgroup claimed T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array [].
Tue, Feb 26, 4:25 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-DataModel-Serialization, Wikidata, MediaWiki-extensions-WikibaseRepository
Ladsgroup committed rEWLE950ec8656499: Add phan config file (authored by Ladsgroup).
Add phan config file
Tue, Feb 26, 1:52 PM