Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani)
Shah of Bugs, Emir of database architecture, World-renowned rubber duckAdministrator

Projects (35)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (442 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Staff Database Architect in SRE data persistence team in WMF. Used to be Wikidata software engineer in WMDE

I'm also open source enthusiast, mediawiki volunteer developer, and long-term Wikipedian.

All edits on tickets about databases are in my work capacity and anything else is in my volunteer capacity unless mentioned otherwise.

Babel: fa-N, en-4, de-2, tr-1, hu-1

Recent Activity

Today

Ladsgroup closed T333123: Switchover m1 master (db1101 -> db1164), a subtask of T331882: eqiad row C switches upgrade, as Resolved.
Fri, Mar 31, 1:43 PM · Patch-For-Review, serviceops-radar, Discovery-Search (Current work), SRE, DBA, cloud-services-team, Traffic, Infrastructure-Foundations, Machine-Learning-Team, Data-Engineering, serviceops-collab, Platform Engineering, SRE Observability
Ladsgroup closed T333123: Switchover m1 master (db1101 -> db1164) as Resolved.
Fri, Mar 31, 1:43 PM · DBA
Ladsgroup added a comment to T296847: Third-party resources policy.

There would be a special page that you go and explicitly enter the domain you want to exempt for your account and part of installing such gadgets would be to go there and set it.

For this to be viable in practice this needs to be "GUI-able" for Gadgets. I.e. that they can prompt you for the opt-in, and the user click a check box ("Whitelist toolforge.org?"). Which probably means this facility needs to be provided by MW. Think "the OAuth confirmation dialog". Anything that requires manual editing of a MediaWiki:Whitelist-esque whitelist is a no-go for anything except a personal user script (possibly shared with a few other techies, but not for the general user base).

Fri, Mar 31, 1:35 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
Ladsgroup added a comment to T326800: Make Wikimedia mwscript use run.php to run maintenance scripts.

hmm, yeah, I think it should try relative path from $IP before erroring out. That makes it fully backward compatible.

Fri, Mar 31, 1:20 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-Maintenance-system
Ladsgroup updated the task description for T326314: Run maint script backfilling new external links fields.
Fri, Mar 31, 1:02 PM · DBA
Ladsgroup updated the task description for T326314: Run maint script backfilling new external links fields.
Fri, Mar 31, 12:59 PM · DBA
Ladsgroup added a comment to T313253: Fix Flaggedrevs database schema drifts in production.

Only these two left:

{
    "_metadata": {
        "time_end": 1680182552.852061,
        "time_start": 1680181902.3546872
    },
    "flaggedrevs fr_user field-unsigned-mismatch": {
        "s2": [
            "db1162:eowiki",
            "db1162:plwiki"
        ]
    }
}
Fri, Mar 31, 12:58 PM · MediaWiki-extensions-FlaggedRevs, DBA
Ladsgroup added a comment to T333118: Slow recentchanges query on 10.6.

Doing index hints on rc queries is quite complicated because it depends on the arguments user provides and how they interact and such :/

Fri, Mar 31, 12:23 PM · mariadb-optimizer-bug, DBA
Ladsgroup added a comment to T296847: Third-party resources policy.

Eh.. the long-standing consensus has been that there are no exemptions. Is there an intention to change this?

There's some ambiguity about what circumstances users can opt-in to stuff, if they have given informed(-ish) consent. For example, the map layers on wikivoyage, or [not default enabled] gadgets that embed google translate. I assume that that sort of thing is what is being referred to.

Fri, Mar 31, 11:58 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
Ladsgroup added a comment to T326147: Stop fragmenting ParserCache entries for mobile frontend .

FWIW, after three weeks of mobile PC entries getting cleaned up. I optimized most of the table in a spare pc host we had:
https://grafana.wikimedia.org/d/000000377/host-overview?orgId=1&var-server=pc1014&var-datasource=thanos&var-cluster=wmcs&from=1679772407075&to=1680263465303&viewPanel=28

Fri, Mar 31, 11:53 AM · User-Ryasmeen, Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 3), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), DBA, Patch-For-Review, MediaWiki-Parser, MobileFrontend
Ladsgroup added a comment to T328311: Special:AbuseLog is missing the `mw-tempuserlink` class from temporary account user links.

Okay, I looked at it in depth and the sharding couldn't have caused these jumps (sorry, I was wrong). For two reasons: 1- The sharding is disabled by default and I'm not finding any config that enables it for the test wiki 2- The way that sharding works makes it that you will have temp user 4 before temp user 3 but no gaps.

Fri, Mar 31, 11:36 AM · Anti-Harassment, AbuseFilter, IP Masking
Ladsgroup added a comment to T333456: Requesting access to analytics-privatedata-users for sfaci.

Added now, in thirty minutes you should be able to access stat machines but someone from data engineering needs to do your krb creds.

Fri, Mar 31, 11:09 AM · API Platform, SRE, SRE-Access-Requests
Ladsgroup added a comment to T3876: Send a notification when someone else edits your userpage.

Thanks <3 <3 <3

Fri, Mar 31, 11:04 AM · User-notice, Growth-Team (Current Sprint), Community-Wishlist-Survey-2023, Patch-For-Review, Community-Tech, Community-Wishlist-Survey-2022, MediaWiki-Email, Notifications
Ladsgroup updated the task description for T333123: Switchover m1 master (db1101 -> db1164).
Fri, Mar 31, 10:54 AM · DBA
Ladsgroup updated the task description for T333123: Switchover m1 master (db1101 -> db1164).
Fri, Mar 31, 10:45 AM · DBA
Ladsgroup updated the task description for T333123: Switchover m1 master (db1101 -> db1164).
Fri, Mar 31, 10:42 AM · DBA
Ladsgroup removed a project from T149847: RFC: Use content hash based image / thumb URLs: SRE.
Fri, Mar 31, 1:22 AM · Parsoid (Tracking), Platform Team Legacy (Later), Services (later), TechCom-RFC, Reading-Admin, Commons, Epic, RESTBase-API, Multimedia, MediaWiki-File-management

Yesterday

jsn.sherman awarded T326800: Make Wikimedia mwscript use run.php to run maintenance scripts a Party Time token.
Thu, Mar 30, 9:24 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-Maintenance-system
Ladsgroup updated the task description for T333550: Requesting access to analytics-privatedata-users for atieno.
Thu, Mar 30, 7:45 PM · API Platform (Sprint 06), SRE-Access-Requests, SRE
bd808 awarded T326800: Make Wikimedia mwscript use run.php to run maintenance scripts a Stroopwafel token.
Thu, Mar 30, 4:29 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-Maintenance-system
Ladsgroup added a comment to T332379: Post-creation work for anpwiki.

It was the issue that broke the script halfway through creating tickets. I fixed that. so it should be fine for the next ones.

Thu, Mar 30, 1:26 PM · Countervandalism-Network, Platform Engineering, Wiki-Setup
Ladsgroup updated the task description for T333456: Requesting access to analytics-privatedata-users for sfaci.
Thu, Mar 30, 1:04 PM · API Platform, SRE, SRE-Access-Requests
Ladsgroup updated the task description for T333456: Requesting access to analytics-privatedata-users for sfaci.
Thu, Mar 30, 12:31 PM · API Platform, SRE, SRE-Access-Requests
Ladsgroup updated the task description for T326314: Run maint script backfilling new external links fields.
Thu, Mar 30, 12:23 PM · DBA
Ladsgroup closed T321662: Enable write both for externallinks in beta and production, a subtask of T312666: Remove duplication in externallinks table, as Resolved.
Thu, Mar 30, 12:22 PM · Patch-For-Review, MediaWiki-Page-derived-data, Performance-Team (Radar), DBA
Ladsgroup closed T321662: Enable write both for externallinks in beta and production as Resolved.
Thu, Mar 30, 12:22 PM · DBA
Ladsgroup updated the task description for T323907: Make fr_user unsigned.
Thu, Mar 30, 11:48 AM · Schema-change-in-production, DBA
Ladsgroup closed T318605: Deploy new externallinks fields to production, a subtask of T312666: Remove duplication in externallinks table, as Resolved.
Thu, Mar 30, 11:47 AM · Patch-For-Review, MediaWiki-Page-derived-data, Performance-Team (Radar), DBA
Ladsgroup closed T318605: Deploy new externallinks fields to production as Resolved.
Thu, Mar 30, 11:47 AM · Schema-change-in-production, DBA
Ladsgroup updated the task description for T318605: Deploy new externallinks fields to production.
Thu, Mar 30, 11:47 AM · Schema-change-in-production, DBA
Ladsgroup closed T326800: Make Wikimedia mwscript use run.php to run maintenance scripts, a subtask of T99268: RfC: Create a proper command-line runner for MediaWiki maintenance tasks, as Resolved.
Thu, Mar 30, 11:28 AM · MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), Wikimedia-Hackathon-2021, Patch-For-Review, Platform Engineering Roadmap Decision Making, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Maintenance-system
Ladsgroup closed T326800: Make Wikimedia mwscript use run.php to run maintenance scripts as Resolved.

Done now:

ladsgroup@mwmaint2002:~$ mwscript version.php --wiki=aawiki
MediaWiki version: 1.41.0-wmf.1 (built: 19:58, 20 March 2023)
ladsgroup@mwmaint2002:~$ mwscript Version --wiki=aawiki
MediaWiki version: 1.41.0-wmf.1 (built: 19:58, 20 March 2023)
Thu, Mar 30, 11:27 AM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-Maintenance-system
Ladsgroup updated the task description for T318605: Deploy new externallinks fields to production.
Thu, Mar 30, 10:53 AM · Schema-change-in-production, DBA
Ladsgroup removed a project from T333538: Switchover s7 master (db1136 -> db1181): Patch-For-Review.
Thu, Mar 30, 10:50 AM · DBA
Ladsgroup closed T333538: Switchover s7 master (db1136 -> db1181) as Resolved.
Thu, Mar 30, 10:50 AM · DBA
Ladsgroup claimed T333538: Switchover s7 master (db1136 -> db1181).
Thu, Mar 30, 10:23 AM · DBA

Wed, Mar 29

Ladsgroup updated subscribers of T333456: Requesting access to analytics-privatedata-users for sfaci.

Blocked on approval by owners of analytics-privatedata-users: @Ottomata or @odimitrijevic

Wed, Mar 29, 7:15 PM · API Platform, SRE, SRE-Access-Requests
Ladsgroup updated the task description for T318605: Deploy new externallinks fields to production.
Wed, Mar 29, 6:58 PM · Schema-change-in-production, DBA
Ladsgroup moved T333480: Switchover s4 master (db1138 -> db1160) from Triage to Done on the DBA board.
Wed, Mar 29, 6:57 PM · DBA
Ladsgroup closed T333480: Switchover s4 master (db1138 -> db1160) as Resolved.
Wed, Mar 29, 6:57 PM · DBA
Ladsgroup edited projects for T333479: Switchover s5 master (db1100 -> db1130), added: Trash; removed DBA.

Wrong section, sorry

Wed, Mar 29, 6:20 PM · Trash
Ladsgroup closed T333479: Switchover s5 master (db1100 -> db1130) as Invalid.
Wed, Mar 29, 6:20 PM · Trash
Ladsgroup added a comment to T706: Requests for addition to the #acl*Project-Admins group (in comments).

As an Engineering Manager I would need access as we won't have a Technical Program Manager as of next week.
Could I be added to Project-Admins so I can create tags, projects etc. I'm aware of the guidelines.

Wed, Mar 29, 4:09 PM · Project-Admins
Ladsgroup added a member for acl*Project-Admins: KSiebert.
Wed, Mar 29, 4:08 PM
Ladsgroup added a comment to T331831: Create Central Kurdish Wiktionary.

That'd be T331834: Prepare and check storage layer for ckbwiktionary. It'll take a bit to be properly sanitized for the cloud

Wed, Mar 29, 3:09 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Wiki-Setup (Create), User-Urbanecm
Ladsgroup added a comment to T188180: Read from and write to `actor` table in AbuseFilter.

Thank you for the note, it's actually not too unusual. For rev_comment migration we had the similar thing that a client wiki would read with its own config from wikidata's revision table (and *fireworks* ensues). I keep that in mind.

Wed, Mar 29, 2:28 PM · AbuseFilter (Overhaul-2020), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Schema-change
Ladsgroup claimed T333332: Add af_actor/afh_actor fields to wmf wikis.
Wed, Mar 29, 2:26 PM · Patch-For-Review, Schema-change-in-production, DBA
Ladsgroup added a comment to T86915: zh-min-nan.wikinews.org redirects to unprefixed incubator.

Is there anything left to do on SRE side? Otherwise we should remove the SRE tag.

Wed, Mar 29, 2:24 PM · Patch-For-Review, Wikimedia-Language-setup
Ladsgroup closed T333157: Request to be added to the ldap/wmde group as Resolved.

I prefer to have something there to satisfy the gods of bureaucracy but it's not mandatory for wmde/wmf groups for new hires.

Wed, Mar 29, 2:03 PM · LDAP-Access-Requests, SRE, WMF-NDA-Requests
Ladsgroup updated the task description for T333157: Request to be added to the ldap/wmde group.
Wed, Mar 29, 2:03 PM · LDAP-Access-Requests, SRE, WMF-NDA-Requests
Ladsgroup added a comment to T333157: Request to be added to the ldap/wmde group.

I need to wait for puppet to propagate and then I do the ldap changes in mwmaint.

Wed, Mar 29, 11:08 AM · LDAP-Access-Requests, SRE, WMF-NDA-Requests
Ladsgroup added a comment to T333157: Request to be added to the ldap/wmde group.

That checklist is part of the process for giving the rights: https://wikitech.wikimedia.org/wiki/SRE/Clinic_Duty/Access_requests#LDAP_access

Wed, Mar 29, 10:58 AM · LDAP-Access-Requests, SRE, WMF-NDA-Requests
Ladsgroup added a comment to T331834: Prepare and check storage layer for ckbwiktionary.

I did the filtering and now it's time to create the users before handing it over to data engineering

Wed, Mar 29, 10:50 AM · Data-Services, DBA
Ladsgroup closed T331831: Create Central Kurdish Wiktionary as Resolved.

The wiki is live, any extra work should have its own ticket.

Wed, Mar 29, 10:37 AM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Wiki-Setup (Create), User-Urbanecm
Ladsgroup claimed T331834: Prepare and check storage layer for ckbwiktionary.
Wed, Mar 29, 10:37 AM · Data-Services, DBA
Ladsgroup closed T331831: Create Central Kurdish Wiktionary, a subtask of T332093: Post-creation work for ckbwiktionary, as Resolved.
Wed, Mar 29, 10:36 AM · Wiki-Setup, User-Urbanecm, Countervandalism-Network, Platform Engineering

Tue, Mar 28

Ladsgroup added a comment to T170874: Provide additional Linter statistics about template-generated issues.

I was asked to comment on this. I'm not sure about the final design, product-wise but if you try to make it work as a QueryPage (an example: Special:WantedPages), it's going to be quite easy to build and maintain and you get all of the scalability protections (querying vslow, caching, etc.) for free and wouldn't need to worry about it at all. Something like this: https://github.com/wikimedia/mediawiki/blob/master/includes/specials/SpecialMostLinkedCategories.php. HTH

Tue, Mar 28, 11:13 PM · Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Ladsgroup added a comment to T333157: Request to be added to the ldap/wmde group.

Hi, I guessed your email address via the WMDE's email pattern, can you please confirm this? https://gerrit.wikimedia.org/r/c/operations/puppet/+/903691/1/modules/admin/data/data.yaml

Tue, Mar 28, 3:58 PM · LDAP-Access-Requests, SRE, WMF-NDA-Requests
Ladsgroup updated the task description for T333157: Request to be added to the ldap/wmde group.
Tue, Mar 28, 3:24 PM · LDAP-Access-Requests, SRE, WMF-NDA-Requests
Ladsgroup claimed T333157: Request to be added to the ldap/wmde group.

Thanks. I'm clinic duty this week.

Tue, Mar 28, 3:13 PM · LDAP-Access-Requests, SRE, WMF-NDA-Requests
Ladsgroup added a comment to T283277: Update process for development policies.

I agree with bd808. I prefer first finishing the retro before adding more responsibilities to it.

Tue, Mar 28, 3:02 PM · tech-decision-forum, Documentation
Ladsgroup updated subscribers of T332868: Grant Grafana access to babiola.

It seems there was another regular job was needed to sync users in ldap with grafana. @fgiunchedi thankfully did a manual kick:

Amir1: Mar 28 13:39:18 grafana1002 grafana-ldap-users-sync[25538]: INFO:__main__:Created user babiola name Barakat Ajadi email babiola-ctr@wikimedia.org
15:40 should work now on retry
Tue, Mar 28, 1:42 PM · SRE, LDAP-Access-Requests
Ladsgroup added a comment to T332868: Grant Grafana access to babiola.

They are now in the list in https://ldap.toolforge.org/group/wmf

User:Barakat Ajadi (more info)

Tue, Mar 28, 12:48 PM · SRE, LDAP-Access-Requests
Ladsgroup added a comment to T326181: Stop doing regex on SQL in Database.

There are a couple more warnings still https://logstash.wikimedia.org/goto/b3869e1ef82447c9fd65f7abee8f1279

Tue, Mar 28, 11:58 AM · Performance-Team, MediaWiki-libs-Rdbms
Ladsgroup closed T332942: Warning: SQLPlatform::isWriteQuery fallback to regex (from ApiQueryRevisions) as Resolved.
Tue, Mar 28, 11:57 AM · MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MediaWiki-Action-API, Performance-Team (Radar)
Ladsgroup closed T332942: Warning: SQLPlatform::isWriteQuery fallback to regex (from ApiQueryRevisions), a subtask of T326181: Stop doing regex on SQL in Database, as Resolved.
Tue, Mar 28, 11:57 AM · Performance-Team, MediaWiki-libs-Rdbms
Ladsgroup added a comment to T332868: Grant Grafana access to babiola.

They show up in ldap search:

ladsgroup@mwmaint2002:~$ ldapsearch -x cn=wmf
...
member: uid=babiola,ou=people,dc=wikimedia,dc=org
Tue, Mar 28, 11:45 AM · SRE, LDAP-Access-Requests
Ladsgroup added a comment to T332868: Grant Grafana access to babiola.

They aren't showing up in https://ldap.toolforge.org/group/wmf maybe I messed up something in ldap change. Let me double check

Tue, Mar 28, 11:40 AM · SRE, LDAP-Access-Requests
Ladsgroup added a comment to T332921: Requesting access to production for kamila.

Does this need anything from SRE now? I assume Hugh already took care of the most.

Tue, Mar 28, 11:13 AM · SRE, SRE-Access-Requests
Ladsgroup added a project to T333242: Rearrange "Users and rights" and "Login / create account" sections on Special:SpecialPages: User-notice.

Maybe adding user-notice, feel free to remove if you think it's not that important.

Tue, Mar 28, 11:07 AM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), User-notice, MediaWiki-General
Ladsgroup closed T333206: Move mbsantos and jgiannelos from parsoid-test-admins to parsoid-test-roots as Resolved.

Merged and deployed the patch, it should be doable in half an hour.

Tue, Mar 28, 11:05 AM · SRE, SRE-Access-Requests
Ladsgroup closed T333298: Update SSH key for abi as Resolved.

you'll have access with the new keys in thirty minutes

Tue, Mar 28, 10:55 AM · SRE, SRE-Access-Requests
Ladsgroup added a comment to T188180: Read from and write to `actor` table in AbuseFilter.

@matej_suchanek Let me know if you need help in any step of the way. You can also start testing first with beta cluster and then test wikis.

Tue, Mar 28, 10:41 AM · AbuseFilter (Overhaul-2020), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Schema-change
Ladsgroup claimed T333298: Update SSH key for abi.

Clinic duty this week, it doesn't need the full process. Let me double check something and get back to you.

Tue, Mar 28, 10:35 AM · SRE, SRE-Access-Requests
Ladsgroup added a member for WMF-NDA: BAbiola-WMF.
Tue, Mar 28, 10:29 AM
Ladsgroup closed T332868: Grant Grafana access to babiola as Resolved.

I added Barakat to wmf ldap group. They should be able to access grafana and such.

Tue, Mar 28, 10:28 AM · SRE, LDAP-Access-Requests
Ladsgroup added a comment to T333223: Adding user_is_temp to the user table.

oh thanks. That means it'll take a month or two at most (after schema change patch getting merged in core)

Tue, Mar 28, 10:01 AM · Data-Persistence, Data-Engineering, IP Masking
Ladsgroup added a project to T333174: Machine Learning team - k8s resources access: Machine-Learning-Team.
Tue, Mar 28, 2:49 AM · Machine-Learning-Team, SRE, Lift-Wing, SRE-Access-Requests
Ladsgroup renamed T333174: Machine Learning team - k8s resources access from Machine Learning team - k8s resources ccess to Machine Learning team - k8s resources access.
Tue, Mar 28, 2:48 AM · Machine-Learning-Team, SRE, Lift-Wing, SRE-Access-Requests

Mon, Mar 27

Ladsgroup added a comment to T280604: Post-deployment: (partly) ramp parser cache retention back up .

Will do it once some clean ups are in place.

Mon, Mar 27, 11:41 PM · Patch-For-Review, DBA, Performance-Team (Radar), Editing-team, DiscussionTools
Ladsgroup added a comment to T328034: ParsoidCachePrewarmJob should set the useParsoid ParserOption.

repeating what I said in the meeting with Daniel. If it's using the same general backend (MySQL PC), only splitting it via even fragmentation should just work out of the box. They are distributed via consistent hashing so it'll be in a random different (or the same in some cases) physical host. That makes it homogeneous and easy to maintain instead of maintaining two separate clusters.

Mon, Mar 27, 11:40 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Content-Transform-Team-WIP, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Performance-Team (Radar), MediaWiki-Parser, RESTbase Sunsetting, Parsoid
Ladsgroup added a comment to T333223: Adding user_is_temp to the user table.

Yup, adding a new column is not that hard. There are some documentation on this https://wikitech.wikimedia.org/wiki/Schema_changes and https://www.mediawiki.org/wiki/Manual:Schema_changes

Mon, Mar 27, 10:50 PM · Data-Persistence, Data-Engineering, IP Masking
Ladsgroup added a comment to T330173: page_assessments table uses an inadequate VARBINARY length for pa_class/pa_importance.

I'm planning to overhaul the documentation regarding this soon. Stay tuned.

Mon, Mar 27, 10:12 PM · Data-Persistence (work done), Schema-change-in-production, Community-Tech, MediaWiki-extensions-PageAssessments
Ladsgroup added a comment to T331899: Requesting access to deployment for ItamarWMDE.

https://wikitech.wikimedia.org/wiki/Deployments/Training

Mon, Mar 27, 9:40 PM · Patch-For-Review, SRE, SRE-Access-Requests
Ladsgroup claimed T331899: Requesting access to deployment for ItamarWMDE.

I'm on clinic duty this week. Waiting for signoff by Tyler. Maybe a deployment training can be arranged (or other devs in wmde can do an informal training)

Mon, Mar 27, 9:39 PM · Patch-For-Review, SRE, SRE-Access-Requests
Ladsgroup added a comment to T332063: Requesting access to analytics-privatedata-users for Yiannis Giannelos.

superset should be automatically done via wmf ldap group. If Jgiannelos is in the ldap group, it should be done already. Correct?

Mon, Mar 27, 9:37 PM · SRE, SRE-Access-Requests
Ladsgroup closed T328501: Request to clean my watchlist from articles in namespace 0 and 1 as Resolved.

Martin was busy so I did it.

Mon, Mar 27, 9:27 PM · User-Urbanecm, Wikimedia-maintenance-script-run, Wikimedia-Site-requests
Ladsgroup closed T251191: FlaggedRevs has lots of database drifts but only in s1 and s5, a subtask of T313253: Fix Flaggedrevs database schema drifts in production, as Resolved.
Mon, Mar 27, 9:16 PM · MediaWiki-extensions-FlaggedRevs, DBA
Ladsgroup closed T251191: FlaggedRevs has lots of database drifts but only in s1 and s5 as Resolved.

This is actually done already as part of T313253: Fix Flaggedrevs database schema drifts in production

Mon, Mar 27, 9:16 PM · DBA
Ladsgroup added a comment to T332329: UpdateQueryBuilder does not support IDatabase::ALL_ROWS updates.

You’re both talking about the wrong extension / class. EntitySchema’s SqlIdGenerator works on a database table that only has one row, and doesn’t have an id_type column. The id_value is the only column in the table – there’s nothing else we even could use to address any specific row.

Mon, Mar 27, 9:15 PM · Performance-Team (Radar), MediaWiki-libs-Rdbms
Ladsgroup added a comment to T332942: Warning: SQLPlatform::isWriteQuery fallback to regex (from ApiQueryRevisions).

It got merged today, I'm planning to deploy this tomorrow and until then it shouldn't be closed, otherwise people might see the warning and create it again.

Mon, Mar 27, 8:45 PM · MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MediaWiki-Action-API, Performance-Team (Radar)
Ladsgroup added a comment to T332329: UpdateQueryBuilder does not support IDatabase::ALL_ROWS updates.

Yeah to me it really feels like it should be avoided and I see it as a good opportunity to discourage it. You can set the id_type in the where condition?

Mon, Mar 27, 9:52 AM · Performance-Team (Radar), MediaWiki-libs-Rdbms
Ladsgroup closed T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable) as Resolved.

https://logstash.wikimedia.org/goto/b3869e1ef82447c9fd65f7abee8f1279

Mon, Mar 27, 8:42 AM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseClient, Performance-Team (Radar)
Ladsgroup closed T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable), a subtask of T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.), as Resolved.
Mon, Mar 27, 8:42 AM · Patch-For-Review, Platform Engineering (Icebox), Performance-Team (Radar), MediaWiki-libs-Rdbms
Ladsgroup closed T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable), a subtask of T326181: Stop doing regex on SQL in Database, as Resolved.
Mon, Mar 27, 8:42 AM · Performance-Team, MediaWiki-libs-Rdbms
Ladsgroup updated the task description for T332921: Requesting access to production for kamila.
Mon, Mar 27, 8:30 AM · SRE, SRE-Access-Requests
Ladsgroup moved T251191: FlaggedRevs has lots of database drifts but only in s1 and s5 from Backlog to In progress on the DBA board.

I'm already doing this as part of the main one. I just need to do switchovers in eqiad and we will be done with this too

Mon, Mar 27, 7:44 AM · DBA

Sun, Mar 26

Ladsgroup added a comment to T333073: Please add patchdemo to codesearch index.

Timo is working on devtools now: https://gerrit.wikimedia.org/r/c/labs/codesearch/+/902880

Sun, Mar 26, 12:54 PM · VPS-project-Codesearch
Ladsgroup added a comment to T332805: Decide the prefix character for temporary usernames.

FWIW these are characters that can be found in a standard Persian keyboard (as a way to check for universality of the choice): !٬٫﷼٪×،*)(ـ+÷؟|

Sun, Mar 26, 12:50 PM · IP Masking

Sat, Mar 25

Ladsgroup claimed T333073: Please add patchdemo to codesearch index.

I'll add it: https://github.com/wikimedia/labs-codesearch/blob/master/write_config.py

Sat, Mar 25, 10:41 PM · VPS-project-Codesearch