Ladsgroup (Amir Sarabadani)Administrator
Master of introducing new bugs

Projects (28)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (223 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Recent Activity

Today

Ladsgroup moved T208140: Detect/flag potentially malicious gadget/javascript edits from Untriaged to Ideas on the Scoring-platform-team board.
Fri, Jan 18, 2:55 PM · Scoring-platform-team, Gadgets, Code-Health, artificial-intelligence
Ladsgroup moved T210260: Stretch in docker registry forces ascii encoding from Untriaged to Monitor on the Scoring-platform-team board.

@Ladsgroup if you retry blubber for wikilabs, you should no more encounter the error. And I don't think you would need to set PYTHONUTF8=1 nor PYTHONIOENCODING: utf-8.

Fri, Jan 18, 2:55 PM · Release Pipeline, Patch-For-Review, Release-Engineering-Team (Backlog), Wikibase-Containers, Wikilabels, Scoring-platform-team, Wikidata
Ladsgroup moved T206333: Change default serializer of celery from pickle to json from Active to Review on the Scoring-platform-team (Current) board.

done now

Fri, Jan 18, 2:46 PM · Patch-For-Review, Scoring-platform-team (Current), User-Ladsgroup, ORES
Ladsgroup moved T213743: Document/script ORES config change deployment process from Active to Review on the Scoring-platform-team (Current) board.
Fri, Jan 18, 12:30 PM · User-Ladsgroup, Scoring-platform-team (Current), Documentation, ORES
Ladsgroup claimed T213743: Document/script ORES config change deployment process.

https://wikitech.wikimedia.org/wiki/ORES/Deployment#Unusual_maintenance_actions

Fri, Jan 18, 12:30 PM · User-Ladsgroup, Scoring-platform-team (Current), Documentation, ORES
Ladsgroup added a comment to T210569: Fix or add keyboard shortcut for saving changes on Persian keyboard layout (Alt+Shift+S doesn't work?).

I volunteer myself if you need any help from a native Persian speaker who loves VE. I'm Amir1 at IRC.

Fri, Jan 18, 12:09 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Ladsgroup added a comment to T124214: Allow filtering based on tag on Special:NewFiles.

Yeah, it might be possible. It needs some updates to reflect the normalization and updates that happened to the table and also, join decomposition might help a lot here but it should be doable. Anyone to take stab at it?

Fri, Jan 18, 12:07 PM · Growth-Team, MediaWiki-Change-tagging, DBA, MediaWiki-Recent-changes, Multimedia, Commons, User-Josve05a
Ladsgroup moved T201691: Implement JS ORES client in mw-ORES extension from Active to Pending deployment on the Scoring-platform-team (Current) board.

@Halfak This task is for a basic implementation of the API. I think we should followups for those.

Fri, Jan 18, 11:27 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, User-Ladsgroup, Scoring-platform-team (Current), MediaWiki-extensions-ORES

Yesterday

marcella awarded T213922: VE removes all new lines when editing a template a The World Burns token.
Thu, Jan 17, 6:58 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-notice, VisualEditor (Current work), Parsoid, VisualEditor-MediaWiki-Templates
Ladsgroup added a comment to T211530: Cannot add yue.wt sitelinks onto Wikidata items.

So I'm going to add yue to the langlist (Reading the discussion T209820#4777281 forward). This might have unforeseen consequences but there is no other way to handle it beside changing yuewiktionary database name to zh_yuewiktionary which is almost impossible (take for example renaming be-x-old, how fun was that).

Thu, Jan 17, 11:41 AM · Patch-For-Review, Wikidata-Campsite, Wikimedia-Language-setup, Wikidata, Wiktionary
Ladsgroup added a comment to T209820: Add Wikidata support to new wikis.

Yes. We need to add yue to langlist (https://github.com/wikimedia/mediawiki-extensions-SiteMatrix/blob/master/includes/SiteMatrix.php#L117):

foreach ( $this->sites as $site ) {
	$m = [];
	if ( preg_match( "/(.*)$site\$/", $db, $m ) ) {
		$lang = $m[1];
		$langhost = str_replace( '_', '-', $lang );
		if ( isset( $xLanglist[$langhost] ) ) {
			$this->matrix[$site][$langhost] = 1;
			$this->countPerSite[$site]++;
		} else {
			$this->specials[] = [ $lang, $site ];
		}
		$found = true;
		break;
	}
}
Thu, Jan 17, 11:37 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T210267: The continuous release pipeline should support more than one service per repo.

I think there are a couple of problems with the current Continuous Delivery pipeline implementation:

  1. Implicit assumption that every repo is one service

For the usecase of ores, the only difference between ServiceOne and ServiceTwo is the entrypoint. Everything else is the same.

  1. Implicit assumption that there is one test entrypoint per repo

Regarding tests, python libraries run flake8 (linting) and pytest (unit/integration tests). I can wrap it in tox.ini but I rather not but if it's decided and you only let one entrypoint, I can fix that.

Thu, Jan 17, 9:19 AM · Release-Engineering-Team (Backlog), Release Pipeline (Blubber), Operations, ORES, Scoring-platform-team
Ladsgroup closed T210719: ORES services should bind to ores config files as Declined.

In favor of T213743: Document/script ORES config change deployment process

Thu, Jan 17, 8:58 AM · Patch-For-Review, Wikimedia-Incident, Scoring-platform-team (Current), Puppet, User-Ladsgroup, ORES
Ladsgroup added a comment to T210719: ORES services should bind to ores config files.

My biggest problem is that it's not documented that config changes in puppet doesn't cause the service to restart. If I knew that. I would do it gradually. My (wrong) assumption was that changing /etc/ores/*.yaml would trigger a restart. If it's clear somewhere (like ores documentation). I'm fine with just abandoning my patch and calling this invalid as current method gives more power to the deployer to test changes in a more careful manner.

Thu, Jan 17, 8:56 AM · Patch-For-Review, Wikimedia-Incident, Scoring-platform-team (Current), Puppet, User-Ladsgroup, ORES
Ladsgroup moved T213281: Check for possible data corruptions caused by T212703 from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

With that only one case from Persian Wikipedia stood out. Tags made on log 13848755. I checked and it was vandalism anyway, I reverted the adding tags.

Thu, Jan 17, 8:33 AM · Chinese-Sites, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Regression, MediaWiki-Change-tagging
Ladsgroup added a comment to T213281: Check for possible data corruptions caused by T212703.

I wrote this bash script to quick things up:

a=$( sql $1 'select ct1.ct_rev_id from change_tag as ct1 join change_tag as ct2 on ct1.ct_rev_id = ct2.ct_log_id;');
b=$(sql $1 'select log_params from logging where log_type = "tag" and log_timestamp  > "20181217" order by log_id desc;');
for i in $a; do
  echo $b | grep $i
done
Thu, Jan 17, 6:57 AM · Chinese-Sites, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Regression, MediaWiki-Change-tagging
Ladsgroup added a comment to T213281: Check for possible data corruptions caused by T212703.

Ids that might have clashed (Query: select ct1.ct_rev_id from change_tag as ct1 join change_tag as ct2 on ct1.ct_rev_id = ct2.ct_log_id;)

  • bnwiki (3378 ids)
  • dewiktionary: Empty
  • eswiki:
MariaDB [eswiki_p]> select ct1.ct_rev_id from change_tag as ct1 join change_tag as ct2 on ct1.ct_rev_id = ct2.ct_log_id;
+-----------+
| ct_rev_id |
+-----------+
|  12671678 |
|  12671678 |
|  12671678 |
|  12671678 |
+-----------+
4 rows in set (6.21 sec)
  • fawiki (19998 ids, are you kidding me?)
  • fiwiki: 5 ids:
MariaDB [fiwiki_p]> select ct1.ct_rev_id from change_tag as ct1 join change_tag as ct2 on ct1.ct_rev_id = ct2.ct_log_id;
+-----------+
| ct_rev_id |
+-----------+
|   8315654 |
|  10754418 |
|  10784706 |
|  10792545 |
|  10792545 |
+-----------+
5 rows in set (0.51 sec)
  • hewiki (2519 ids)
  • itwiki (261 ids: P7999)
  • testwiki: 403 ids
  • viwiki (598 ids P8000)
  • zhwiki ( one id: 5355705)
  • wikidatawiki: Query is running
Thu, Jan 17, 6:35 AM · Chinese-Sites, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Regression, MediaWiki-Change-tagging
Ladsgroup created P8000 (An Untitled Masterwork).
Thu, Jan 17, 6:34 AM
Ladsgroup created P7999 (An Untitled Masterwork).
Thu, Jan 17, 6:32 AM
Ladsgroup awarded T213934: Set up a beta feature offering the use of PHP7 a Love token.
Thu, Jan 17, 4:39 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Performance-Team, Core Platform Team, User-Joe, serviceops, Operations

Wed, Jan 16

RandomDSdevel awarded T212703: Impossible to remove change tags from revisions a Cup of Joe token.
Wed, Jan 16, 6:08 PM · User-notice, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Patch-For-Review, Regression, MediaWiki-Change-tagging
Ladsgroup created T213922: VE removes all new lines when editing a template.
Wed, Jan 16, 2:15 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-notice, VisualEditor (Current work), Parsoid, VisualEditor-MediaWiki-Templates

Sat, Jan 12

GitHub <noreply@github.com> committed rORESc64b62d3b39a: Merge 1deb24cb0bd70ee31e031adcf86bb263a9b14407 into… (authored by Ladsgroup).
Merge 1deb24cb0bd70ee31e031adcf86bb263a9b14407 into…
Sat, Jan 12, 12:21 AM

Fri, Jan 11

Ladsgroup updated the task description for T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking).
Fri, Jan 11, 7:19 PM · Epic, DBA, Tracking
matej_suchanek awarded T212703: Impossible to remove change tags from revisions a Barnstar token.
Fri, Jan 11, 5:42 PM · User-notice, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Patch-For-Review, Regression, MediaWiki-Change-tagging
Ladsgroup added a comment to T210713: Drop change_tag.ct_tag column in production.

It's cut to half:

wikiadmin@10.64.32.114(ruwiki)> SELECT table_schema, table_name AS `Table`, round(((data_length + index_length) / 1024 / 1024), 2) `Size in MB` FROM information_schema.TABLES WHERE table_name = 'change_tag' order by (data_length + index_length) desc;
+--------------+------------+------------+
| table_schema | Table | Size in MB |
+--------------+------------+------------+
| frwiki | change_tag | 4978.98 |
| ruwiki | change_tag | 2599.02 |
| jawiki | change_tag | 2078.89 |
+--------------+------------+------------+
wikiadmin@db2046.codfw.wmnet(ruwiki)> SELECT table_schema, table_name AS `Table`, round(((data_length + index_length) / 1024 / 1024), 2) `Size in MB` FROM information_schema.TABLES WHERE table_name = 'change_tag' order by (data_length + index_length) desc;
+--------------+------------+------------+
| table_schema | Table | Size in MB |
+--------------+------------+------------+
| frwiki | change_tag | 2577.97 |
| ruwiki | change_tag | 1224.44 |
| jawiki | change_tag | 1012.16 |
+--------------+------------+------------+
3 rows in set (0.03 sec)
Fri, Jan 11, 12:44 PM · Patch-For-Review, Blocked-on-schema-change, User-Ladsgroup, MediaWiki-Change-tagging

Thu, Jan 10

Ladsgroup added a comment to T209016: Is it correct to show RTL content in RTL display mode alongside LTR content in LTR display mode?.

This is https://commons.wikimedia.beta.wmflabs.org/wiki/File:Foo.jpg (taken yesterday)


The language name is in English ("Persian" and not "فارسی") but it's RTL. This doesn't make any sense to me.

Oh! That's very odd, sorry. I'll file a task; all of your reports are asking for the reverse of this task. :-)

Thu, Jan 10, 8:21 PM · I18n, RTL, Multimedia, Multimedia-Team-Working-Board
Ladsgroup closed T139012: Use index on rc_this_oldid as Resolved.
Thu, Jan 10, 8:07 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, User-Ladsgroup, Scoring-platform-team (Current), TechCom-RFC (TechCom-Approved), MediaWiki-Database, Schema-change
Ladsgroup closed T139012: Use index on rc_this_oldid, a subtask of T138444: Use rc_timestamp index when joining to ores_classification, as Resolved.
Thu, Jan 10, 8:07 PM · Scoring-platform-team (Current), User-Ladsgroup, MediaWiki-extensions-ORES
Ladsgroup added a comment to T209016: Is it correct to show RTL content in RTL display mode alongside LTR content in LTR display mode?.

This is https://commons.wikimedia.beta.wmflabs.org/wiki/File:Foo.jpg (taken yesterday)


The language name is in English ("Persian" and not "فارسی") but it's RTL. This doesn't make any sense to me.

Thu, Jan 10, 8:04 PM · I18n, RTL, Multimedia, Multimedia-Team-Working-Board
Ladsgroup added a comment to T212255: Drop tag_summary table.

Let me elaborate more why I said we should drop it after wmf.9 is everywhere (T212255#4849367). It was because the patch that stops writing to the table was made it to the branch cut (wmf.9) but the patch to actually drop the table didn't.

Thu, Jan 10, 1:16 PM · Patch-For-Review, DBA
Ladsgroup added a comment to T213131: New ORES model relies on translatewiki.net API, which is not hosted on WMF production.

In general I agree that we should not have a wildcard proxy. Given that ores uses pickle a lot, I'm worried about its security.

Thu, Jan 10, 12:01 PM · Security, Scoring-platform-team, translatewiki.net, ORES
Ladsgroup added a comment to T213281: Check for possible data corruptions caused by T212703.

The wikis that have changed tags in the given time span are:

  • bnwiki
  • dewiktionary
  • eswiki
  • fawiki
  • fiwiki
  • hewiki
  • itwiki
  • jawiki
  • svwiki
  • testwiki
  • viwiki
  • wikidatawiki
  • zhwiki
Thu, Jan 10, 11:47 AM · Chinese-Sites, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Regression, MediaWiki-Change-tagging
Ladsgroup updated subscribers of T210285: Migrate selenium-Wikibase-chrome selenium-WikibaseLexeme-chrome to Docker containers.

@Addshore @Ladsgroup you were pretty active recently with Selenium tests. Can you approve this, or do you know who can?

Thu, Jan 10, 10:47 AM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikidata, Lexicographical data, User-zeljkofilipin, Browser-Tests, Continuous-Integration-Infrastructure (Slipway)
Ladsgroup added a comment to T210267: The continuous release pipeline should support more than one service per repo.

Q: would blubber's variants be enough to support the wsgi vs celery use case?

Thu, Jan 10, 10:27 AM · Release-Engineering-Team (Backlog), Release Pipeline (Blubber), Operations, ORES, Scoring-platform-team
Ladsgroup added a comment to T209016: Is it correct to show RTL content in RTL display mode alongside LTR content in LTR display mode?.

In wikidata the language name follows the direction of the the UI (https://www.wikidata.org/wiki/Q7251):

Thu, Jan 10, 10:18 AM · I18n, RTL, Multimedia, Multimedia-Team-Working-Board
Ladsgroup added a comment to T212255: Drop tag_summary table.

The reason being is that dropping tag_summary wasn't made it to wmf.9 (here). I think the reason valid_tag doesn't exist is that you dropped it several days ago.

Thu, Jan 10, 9:35 AM · Patch-For-Review, DBA

Wed, Jan 9

Ladsgroup updated the task description for T213281: Check for possible data corruptions caused by T212703.
Wed, Jan 9, 1:17 PM · Chinese-Sites, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Regression, MediaWiki-Change-tagging
Ladsgroup created T213281: Check for possible data corruptions caused by T212703.
Wed, Jan 9, 1:16 PM · Chinese-Sites, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Regression, MediaWiki-Change-tagging
Ladsgroup moved T212703: Impossible to remove change tags from revisions from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Jan 9, 1:16 PM · User-notice, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Patch-For-Review, Regression, MediaWiki-Change-tagging
Ladsgroup added a project to T212703: Impossible to remove change tags from revisions: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).

Now it works

Wed, Jan 9, 1:16 PM · User-notice, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Patch-For-Review, Regression, MediaWiki-Change-tagging
Ladsgroup merged task T213241: Direction of language name should conform to UI language and not the language itself into T209016: Is it correct to show RTL content in RTL display mode alongside LTR content in LTR display mode?.
Wed, Jan 9, 11:46 AM · SDC Engineering, I18n, RTL
Ladsgroup merged T213241: Direction of language name should conform to UI language and not the language itself into T209016: Is it correct to show RTL content in RTL display mode alongside LTR content in LTR display mode?.
Wed, Jan 9, 11:46 AM · I18n, RTL, Multimedia, Multimedia-Team-Working-Board
Ladsgroup added a comment to T209016: Is it correct to show RTL content in RTL display mode alongside LTR content in LTR display mode?.

The picture in the task description is really confusing. Label of language is the local name in some cases (like "español" instead of "Spanish") but for Hebrew is "Hebrew" and not "עברית"). As a person who speaks one RTL language (I mean I write it in RTL), it matters a lot. If the name being shown is local name, it should follow the directionality of the language (so "فارسی" for Persian should be RTL) but if it shows name of the language in language of the user UI (so "Persian" for Persian if the interface is set to English and "انگلیسی" for English when user interface is set to Persian), the it should follow the directionality of the user interface and not the language itself.

Wed, Jan 9, 11:36 AM · I18n, RTL, Multimedia, Multimedia-Team-Working-Board
Ladsgroup closed T213249: npm stylelint is broken due to dir-glob dependency upgrade as Resolved.

npm picked it up. It's fixed now: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/483059

Wed, Jan 9, 11:21 AM · Upstream, MediaWiki-Core-Tests
Ladsgroup added a comment to T212544: Gerrit repo scoring/ores/editquality LFS broken (smudge filter lfs failed).

I don't think this is a big issue: T212818#4865068

Wed, Jan 9, 10:09 AM · Scoring-platform-team
Ladsgroup added a comment to T212818: LFS objects are not mirroring from Github through Phab to Gerrit consistently.

This issue is easily fixable. Let me explain why it happens. (Probably duplicate of T212544). The problem happens only when there is new git lfs file added.

Wed, Jan 9, 10:08 AM · Release-Engineering-Team, Scoring-platform-team, GitHub-Mirrors, Diffusion
Ladsgroup created T213249: npm stylelint is broken due to dir-glob dependency upgrade.
Wed, Jan 9, 9:43 AM · Upstream, MediaWiki-Core-Tests
Ladsgroup claimed T212703: Impossible to remove change tags from revisions.

I found the issue. The patch is up.

Wed, Jan 9, 8:07 AM · User-notice, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Patch-For-Review, Regression, MediaWiki-Change-tagging
Ladsgroup closed T212674: Update Wikimedia logo on Mailman web pages from colored version to black and white version as Declined.

Thanks for the notes.

Wed, Jan 9, 4:49 AM · WMF-Communications, Design, Operations, Wikimedia-Mailing-lists
Ladsgroup updated the task description for T213241: Direction of language name should conform to UI language and not the language itself.
Wed, Jan 9, 4:37 AM · SDC Engineering, I18n, RTL
Ladsgroup created T213241: Direction of language name should conform to UI language and not the language itself.
Wed, Jan 9, 4:37 AM · SDC Engineering, I18n, RTL

Thu, Jan 3

GitHub <noreply@github.com> committed rORESabd3fb055166: Merge 1deb24cb0bd70ee31e031adcf86bb263a9b14407 into… (authored by Ladsgroup).
Merge 1deb24cb0bd70ee31e031adcf86bb263a9b14407 into…
Thu, Jan 3, 8:34 PM

Wed, Jan 2

Ladsgroup added a comment to T212674: Update Wikimedia logo on Mailman web pages from colored version to black and white version.

The black and white logo is just for the Foundation. The coloured logo is still used for community-related activity, which I would guess mailman includes. AffCom is one of the few exceptions there, but even that I would say is community rather than Foundation.

Wed, Jan 2, 4:50 PM · WMF-Communications, Design, Operations, Wikimedia-Mailing-lists
Ladsgroup added a comment to T212703: Impossible to remove change tags from revisions.

I will fix this ASAP. Unfortunately, I lost my laptop (and all of my access), making even a gerrit patch seems super difficult right now. Not to mention I'm on vacation.

Wed, Jan 2, 4:14 PM · User-notice, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Ladsgroup, Patch-For-Review, Regression, MediaWiki-Change-tagging
Ladsgroup changed the status of T212255: Drop tag_summary table from Stalled to Open.

wmf.9 is everywhere \o/

Wed, Jan 2, 4:10 PM · Patch-For-Review, DBA
Ladsgroup changed the status of T212255: Drop tag_summary table, a subtask of T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking), from Stalled to Open.
Wed, Jan 2, 4:10 PM · Epic, DBA, Tracking
Ladsgroup changed the status of T212255: Drop tag_summary table, a subtask of T209525: Migrate tag_summary usage to change_tag and drop the table, from Stalled to Open.
Wed, Jan 2, 4:10 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-Marostegui, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Patch-For-Review, MediaWiki-Change-tagging

Wed, Dec 26

Ladsgroup added a comment to T209820: Add Wikidata support to new wikis.

Whatever SiteMatrix does, it is not based on $wgLanguageCode.

You're wrong:
From wmf-config/CommonSettings.php:

// Config for sitematrix
$wgSiteMatrixFile = ( $wmfRealm === 'labs' ) ? "$IP/../langlist-labs" : "$IP/../langlist";

Then it's loaded in SiteMatrix.php

Wed, Dec 26, 9:37 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup updated subscribers of T202602: Consider renaming language identifier (i.e. on the left of sitelinks of items) of Cantonese from "zh_yue" to "yue".

One big reason everything is so complex and weird is that T113034: RFC: Overhaul Interwiki map, unify with Sites and WikiMap is not implemented and this has been biting us for a very long time now. Maybe we can use APCu cache for site/interwiki lookup. @daniel and @Addshore Any thoughts?

Wed, Dec 26, 9:09 PM · Wikidata

Mon, Dec 24

Ladsgroup created T212595: [Feature request] Install and use trove in openstack.
Mon, Dec 24, 3:44 PM · Cloud-VPS, User-Marostegui
Ladsgroup added a comment to T201636: The staff page does not show teams/sub-teams anymore which makes it considerably less useful.

I don't agree that our team structure is not useful to external audiences and would like to see this restored on the Foundation's website.

Mon, Dec 24, 3:36 PM · wikimediafoundation.org

Sun, Dec 23

Ladsgroup added a comment to T212283: issues in edit summary when changing the language of a Gloss.

I tested twice and it works fine: https://wikidata.beta.wmflabs.org/w/index.php?title=Lexeme:L1&diff=1088295&oldid=1088294 https://wikidata.beta.wmflabs.org/w/index.php?title=Lexeme:L1&diff=prev&oldid=1088294

Sun, Dec 23, 1:53 PM · Wikidata-Campsite, Wikidata, Lexicographical data
Ladsgroup added a comment to T210103: Support CIDR range whitelist for ORES throttling.

The code patch is merged, now we just need some configuration. @akosiaris @Ladsgroup do we have a private repository for semi-sensitive config like this whitelist?

Sun, Dec 23, 1:48 PM · Scoring-platform-team (Current), ORES
Ladsgroup moved T211297: Make Wikibase 1.32 base and bundle image from Peer Review to Stalled on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

1.32 is not released to docker hub yet: https://hub.docker.com/_/mediawiki

Sun, Dec 23, 1:43 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Containers
Ladsgroup claimed T211297: Make Wikibase 1.32 base and bundle image.

https://github.com/wmde/wikibase-docker/pull/54

Sun, Dec 23, 1:29 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Containers
Ladsgroup moved T209957: Configure WikibaseQualityConstraints on beta from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

We tried to test this and it doesn't seem to be working correctly yet. https://wikidata.beta.wmflabs.org/wiki/Q81561#P963 should have a constraint violation based on the constraint defined at https://wikidata.beta.wmflabs.org/wiki/Property:P963#P241048 and https://wikidata.beta.wmflabs.org/wiki/Special:ConstraintReport/Q81561 doesn't show anything either. Or are we missing something?

Sun, Dec 23, 12:51 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikimedia-Site-requests, Wikibase-Quality-Constraints

Sat, Dec 22

Ladsgroup added a comment to T212544: Gerrit repo scoring/ores/editquality LFS broken (smudge filter lfs failed).

I pushed all of the updates to gerrit. I found out that drafttopic and draftquality are not actually using git lfs. I need to fix that later.

Sat, Dec 22, 4:24 PM · Scoring-platform-team
Ladsgroup added a comment to T211530: Cannot add yue.wt sitelinks onto Wikidata items.

@Lydia_Pintscher Yup, it's on T209820#4831103 TLDR. It's fixable but needs deployment after the holidays.

Sat, Dec 22, 3:36 PM · Patch-For-Review, Wikidata-Campsite, Wikimedia-Language-setup, Wikidata, Wiktionary
Ladsgroup added a comment to T212544: Gerrit repo scoring/ores/editquality LFS broken (smudge filter lfs failed).

I actually saw this before and there is no easy way to properly fix it but there is a very easy way to go around it. Just add gerrit as another remote to your github editquality repo (git remote add gerrit ssh://path/to/gerrit) then simply do git lfs push. It uploads the lfs files on gerrit.

Sat, Dec 22, 3:05 PM · Scoring-platform-team

Fri, Dec 21

GitHub <noreply@github.com> committed rORES604b243a03cb: Merge pull request #298 from wikimedia/cidr_whitelist (authored by Ladsgroup).
Merge pull request #298 from wikimedia/cidr_whitelist
Fri, Dec 21, 5:33 PM
GitHub <noreply@github.com> committed rORESdc1f854d5946: Merge 1deb24cb0bd70ee31e031adcf86bb263a9b14407 into… (authored by Ladsgroup).
Merge 1deb24cb0bd70ee31e031adcf86bb263a9b14407 into…
Fri, Dec 21, 2:19 PM
Ladsgroup committed rORES1deb24cb0bd7: Add mock redis tests for times redis is not available (authored by Ladsgroup).
Add mock redis tests for times redis is not available
Fri, Dec 21, 2:19 PM
Ladsgroup moved T206333: Change default serializer of celery from pickle to json from Active to Review on the Scoring-platform-team (Current) board.

https://github.com/wikimedia/revscoring/pull/419

Fri, Dec 21, 2:01 PM · Patch-For-Review, Scoring-platform-team (Current), User-Ladsgroup, ORES

Thu, Dec 20

GitHub <noreply@github.com> committed rORES4518570e7450: Merge a80bdfa13bc79a8c68be326379a12f254fa9360e into… (authored by Ladsgroup).
Merge a80bdfa13bc79a8c68be326379a12f254fa9360e into…
Thu, Dec 20, 4:02 PM
Ladsgroup committed rORESa80bdfa13bc7: Add pytest.mark.redis to redis tests (authored by Ladsgroup).
Add pytest.mark.redis to redis tests
Thu, Dec 20, 4:02 PM
Ladsgroup committed rORES6585ab168d62: Add pytest.mark.redis to redis tests (authored by Ladsgroup).
Add pytest.mark.redis to redis tests
Thu, Dec 20, 2:29 PM
GitHub <noreply@github.com> committed rORESfa2dfdb610d8: Merge 6585ab168d628c8000f0cf332982775456dbaab6 into… (authored by Ladsgroup).
Merge 6585ab168d628c8000f0cf332982775456dbaab6 into…
Thu, Dec 20, 2:29 PM
Ladsgroup committed rORESDEPLOYa9828f5526a3: Bump editquality to HEAD (authored by Ladsgroup).
Bump editquality to HEAD
Thu, Dec 20, 1:25 PM

Dec 19 2018

Ladsgroup added a comment to T212090: Improve ORES test coverage.

https://github.com/wikimedia/ores/pull/306

Dec 19 2018, 1:17 PM · ORES, Scoring-platform-team (Current), User-Ladsgroup
GitHub <noreply@github.com> committed rORESac80b32a03bc: Merge 14713929daf19243128de30b1cdab9ef0e3360b9 into… (authored by Ladsgroup).
Merge 14713929daf19243128de30b1cdab9ef0e3360b9 into…
Dec 19 2018, 1:12 PM
Ladsgroup committed rORES14713929daf1: Add tests for redis task tracker and score cache (authored by Ladsgroup).
Add tests for redis task tracker and score cache
Dec 19 2018, 1:12 PM
GitHub <noreply@github.com> committed rOREScacbc61dba7d: Merge e4ef67d1e58ffdaffb3fd4b1fab44bf6f6687bff into… (authored by Ladsgroup).
Merge e4ef67d1e58ffdaffb3fd4b1fab44bf6f6687bff into…
Dec 19 2018, 12:42 PM
Ladsgroup committed rORESe4ef67d1e58f: Add tests for redis task tracker and score cache (authored by Ladsgroup).
Add tests for redis task tracker and score cache
Dec 19 2018, 12:38 PM
Ladsgroup moved T194178: Make WDQS UI page title configurable from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Dec 19 2018, 1:20 AM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
Ladsgroup moved T211123: copyright.html is missing style sheets from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Dec 19 2018, 1:20 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata Query UI
Ladsgroup moved T194177: Make copyright.html usable for non-Wikidata installations from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Dec 19 2018, 1:20 AM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
Ladsgroup added a comment to T194177: Make copyright.html usable for non-Wikidata installations.

I see https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/Copyright was created, which is nice. But myself and probably other people from WDQS team (at least @Gehel, maybe also @Lucas_Werkmeister_WMDE and others) should be able to edit it. Right now it's not the case.

Dec 19 2018, 1:12 AM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
Ladsgroup committed rWDQGe0923f891b09: Drop copyright.html and link to wikidata instead (authored by Ladsgroup).
Drop copyright.html and link to wikidata instead
Dec 19 2018, 12:51 AM
Ladsgroup moved T207749: Improve code examples of the Wikidata Query UI from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Dec 19 2018, 12:20 AM · User-Ladsgroup, Patch-For-Review, Google-Code-in-2018, Need-volunteer, Wikidata, Wikidata Query UI
Ladsgroup placed T207749: Improve code examples of the Wikidata Query UI up for grabs.
Dec 19 2018, 12:20 AM · User-Ladsgroup, Patch-For-Review, Google-Code-in-2018, Need-volunteer, Wikidata, Wikidata Query UI

Dec 18 2018

Ladsgroup committed rWDQG3a0dea785d97: Move copyright to config.js (authored by Ladsgroup).
Move copyright to config.js
Dec 18 2018, 11:24 PM
Ladsgroup committed rWDQG17b7ddc19482: Set title from config in copyright.html (authored by Ladsgroup).
Set title from config in copyright.html
Dec 18 2018, 11:24 PM
Ladsgroup committed rWDQGf7f416824305: Fix copyright.html style bundling (authored by Ladsgroup).
Fix copyright.html style bundling
Dec 18 2018, 11:24 PM
Ladsgroup claimed T194177: Make copyright.html usable for non-Wikidata installations.
Dec 18 2018, 11:21 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
Ladsgroup moved T211123: copyright.html is missing style sheets from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Dec 18 2018, 11:20 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
Ladsgroup committed rWDQG3659dc6b3945: Move copyright to config.js (authored by Ladsgroup).
Move copyright to config.js
Dec 18 2018, 11:19 PM
Ladsgroup claimed T211123: copyright.html is missing style sheets.
Dec 18 2018, 11:19 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
Ladsgroup moved T210830: Do not allow edits from the client for blocked users on the repository from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Dec 18 2018, 10:54 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T197212: Make wikibase 1.31 base and bundle image.

https://github.com/wmde/wikibase-docker/pull/52

Dec 18 2018, 10:49 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Wikidata, Wikibase-Containers