Ladsgroup (Amir Sarabadani)
Master of introducing new bugs

Projects (21)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (176 w, 6 d)
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup

Recent Activity

Sat, Feb 24

Ladsgroup added a comment to T187324: Medical editor stats 2017.

Unfortunately I can't find the code.

Sat, Feb 24, 2:27 PM · Contributors-Analysis

Fri, Feb 23

Ladsgroup moved T135155: Create an adapter that implements SiteLookup on top of InterwikiLookup from Backlog to Review on the Wikidata-Sprint-2018-02-14 board.
Fri, Feb 23, 11:50 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Sprint-2018-02-14, Wikidata, MediaWiki-Sites, MediaWiki-Interwiki
Ladsgroup claimed T135155: Create an adapter that implements SiteLookup on top of InterwikiLookup.

I'm working on this as it's blocking {}
One note before moving forward, In InterwikiLookup in production we don't save wikiId().

object(Interwiki)#2933 (6) {
  ["mPrefix":protected]=>
  string(2) "fa"
  ["mURL":protected]=>
  string(32) "https://fa.wikipedia.org/wiki/$1"
  ["mAPI":protected]=>
  string(0) ""
  ["mWikiID":protected]=>
  string(0) ""
  ["mLocal":protected]=>
  bool(true)
  ["mTrans":protected]=>
  bool(false)
}

This adapter is completely useless without it.

Fri, Feb 23, 10:33 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Sprint-2018-02-14, Wikidata, MediaWiki-Sites, MediaWiki-Interwiki
Ladsgroup committed rOEQ49b4ffa38fa9: Fix merge_label utility argument order (authored by Ladsgroup).
Fix merge_label utility argument order
Fri, Feb 23, 8:40 PM
Ladsgroup added a comment to T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5).

of course, populateSitesTable doesn't update site_identifiers table.

Fri, Feb 23, 6:34 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Wikidata-Sprint-2018-01-17, User-Ladsgroup, Wikidata-Sprint-2018-01-03, Patch-For-Review, User-thiemowmde, MediaWiki-Platform-Team, MediaWiki-extensions-WikibaseClient, Wikidata
Ladsgroup added a comment to T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5).

With the rebuilding of these tables, it's still can't find it. Problem lies somewhere else it seems

Fri, Feb 23, 6:31 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Wikidata-Sprint-2018-01-17, User-Ladsgroup, Wikidata-Sprint-2018-01-03, Patch-For-Review, User-thiemowmde, MediaWiki-Platform-Team, MediaWiki-extensions-WikibaseClient, Wikidata
Ladsgroup added a comment to T185712: Make Context serializable.

:(((((((((((((((((((

Fri, Feb 23, 5:51 PM · Wikidata-Sprint-2018-02-14, Patch-For-Review, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Ladsgroup added a comment to T185712: Make Context serializable.

Okay, so how about this:

  • Add Context::getCursor(), to return the associated ContextCursor.

I really like to avoid more public methods in Context, my recommendation is to have a public static function named ContextCursor::newFromContext( Context $context ) there instead. Beside that, it looks great to me.

Fri, Feb 23, 5:43 PM · Wikidata-Sprint-2018-02-14, Patch-For-Review, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Ladsgroup added a comment to T188105: Request to be added to the ldap/wmde and ldap/nda groups.

As his teammate, His talent and his knowledge always intrigued me, so I fully support this request and believe these accesses will be useful for the whole team and Wikidata.

Fri, Feb 23, 4:45 PM · LDAP-Access-Requests
Ladsgroup awarded T188105: Request to be added to the ldap/wmde and ldap/nda groups a Goat token.
Fri, Feb 23, 4:43 PM · LDAP-Access-Requests
Ladsgroup closed T121522: snaks-order option in wbsetreference is does not work correctly as Resolved.

It's not valid anymore: https://www.wikidata.org/w/index.php?title=Q4115189&diff=637507924&oldid=637447557

Fri, Feb 23, 4:42 PM · User-Ladsgroup, MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup committed rEWLE59076f80d9ae: Disable Senses, the softer way (authored by Ladsgroup).
Disable Senses, the softer way
Fri, Feb 23, 11:13 AM
Ladsgroup committed rEWLE52b0bcddfff7: Disable Senses in UI, the hard way (authored by Ladsgroup).
Disable Senses in UI, the hard way
Fri, Feb 23, 10:59 AM

Thu, Feb 22

Ladsgroup moved T168455: Implement code generation for model makefile maintenance from Review to Active on the Scoring-platform-team (Current) board.
Thu, Feb 22, 10:34 PM · User-Ladsgroup, Scoring-platform-team (Current), editquality-modeling, artificial-intelligence
Ladsgroup moved T186453: Fix or decide on edge cases of Makefile from Review to Active on the Scoring-platform-team (Current) board.
Thu, Feb 22, 10:34 PM · User-Ladsgroup, Scoring-platform-team (Current)
Ladsgroup moved T187742: I broke merge_labels utility so bad from Active to Review on the Scoring-platform-team (Current) board.
Thu, Feb 22, 10:34 PM · artificial-intelligence, User-Ladsgroup, editquality-modeling, Scoring-platform-team (Current)
Ladsgroup committed rEWLE67fe7ef5a53c: Disable Senses, the softer way (authored by Ladsgroup).
Disable Senses, the softer way
Thu, Feb 22, 10:30 PM
Ladsgroup moved T186714: enable x-kill feature on Commons from Backlog to Done on the Wikidata-Sprint-2018-02-14 board.
Thu, Feb 22, 10:30 PM · Wikidata-Sprint-2018-02-14, Commons, Wikidata, User-Ladsgroup
Ladsgroup moved T187196: Disable Senses in the UI of the initial Lexeme page [S] from Backlog to Review on the Wikidata-Sprint-2018-02-14 board.
Thu, Feb 22, 10:30 PM · User-Ladsgroup, Wikidata-Sprint-2018-02-14, Patch-For-Review, Lexicographical data, Wikidata
Ladsgroup claimed T187196: Disable Senses in the UI of the initial Lexeme page [S].
Thu, Feb 22, 10:29 PM · User-Ladsgroup, Wikidata-Sprint-2018-02-14, Patch-For-Review, Lexicographical data, Wikidata
Ladsgroup committed rEWLEd5490e520302: Disable Senses in UI, the hard way (authored by Ladsgroup).
Disable Senses in UI, the hard way
Thu, Feb 22, 10:19 PM
Ladsgroup added a comment to T188009: Private wikis & Disabling Tidy: How do we determine impacts?.

All high priority errors are zero

Thu, Feb 22, 10:11 PM · Tidy, Parsing-Team
Ladsgroup committed rEWLE46457936f277: Disable Senses in UI, the hard way (authored by Ladsgroup).
Disable Senses in UI, the hard way
Thu, Feb 22, 10:07 PM
Ladsgroup added a comment to T188009: Private wikis & Disabling Tidy: How do we determine impacts?.

Not me; I am an auxiliary member. @Ladsgroup has access though, I think.

Thu, Feb 22, 10:06 PM · Tidy, Parsing-Team
Ladsgroup moved T186714: enable x-kill feature on Commons from consider for next sprint to in progress on the Wikidata board.
Thu, Feb 22, 9:45 PM · Wikidata-Sprint-2018-02-14, Commons, Wikidata, User-Ladsgroup
Ladsgroup edited projects for T186714: enable x-kill feature on Commons, added: Commons, Wikidata-Sprint-2018-02-14; removed Patch-For-Review.
Thu, Feb 22, 9:45 PM · Wikidata-Sprint-2018-02-14, Commons, Wikidata, User-Ladsgroup
GitHub <noreply@github.com> committed rOEQ07c172ceb204: Merge 6ae40b19863e1e448cff3794106836c1bd517a98 into… (authored by Ladsgroup).
Merge 6ae40b19863e1e448cff3794106836c1bd517a98 into…
Thu, Feb 22, 9:36 PM
GitHub <noreply@github.com> committed rOEQ1a7aaa965e51: Merge 4bfd0544dac0d73179e28771954f513e5a9b8dc7 into… (authored by Ladsgroup).
Merge 4bfd0544dac0d73179e28771954f513e5a9b8dc7 into…
Thu, Feb 22, 9:36 PM
Ladsgroup committed rOEQ6ae40b19863e: Fix merge_label utility argument order (authored by Ladsgroup).
Fix merge_label utility argument order
Thu, Feb 22, 9:36 PM
Ladsgroup committed rOEQda22db863dca: Swap places of merge_label configs (authored by Ladsgroup).
Swap places of merge_label configs
Thu, Feb 22, 9:35 PM
Ladsgroup added a comment to T187742: I broke merge_labels utility so bad.

https://github.com/wiki-ai/editquality/pull/133

Thu, Feb 22, 9:33 PM · artificial-intelligence, User-Ladsgroup, editquality-modeling, Scoring-platform-team (Current)
Ladsgroup updated the task description for T186453: Fix or decide on edge cases of Makefile.
Thu, Feb 22, 4:41 PM · User-Ladsgroup, Scoring-platform-team (Current)

Wed, Feb 21

Ladsgroup added a comment to T186453: Fix or decide on edge cases of Makefile.

https://github.com/wiki-ai/editquality/pull/132

Wed, Feb 21, 11:00 PM · User-Ladsgroup, Scoring-platform-team (Current)
Ladsgroup added a comment to T168455: Implement code generation for model makefile maintenance.

https://github.com/wiki-ai/editquality/pull/132

Wed, Feb 21, 10:59 PM · User-Ladsgroup, Scoring-platform-team (Current), editquality-modeling, artificial-intelligence
GitHub <noreply@github.com> committed rOEQc4824569d5ce: Merge 05c189a657e122a06caeac5fecaffd225aee4125 into… (authored by Ladsgroup).
Merge 05c189a657e122a06caeac5fecaffd225aee4125 into…
Wed, Feb 21, 10:58 PM
Ladsgroup committed rOEQ05c189a657e1: Template nowiki and viwiki (authored by Ladsgroup).
Template nowiki and viwiki
Wed, Feb 21, 10:58 PM
Ladsgroup claimed T186453: Fix or decide on edge cases of Makefile.
Wed, Feb 21, 10:57 PM · User-Ladsgroup, Scoring-platform-team (Current)
Ladsgroup moved T186453: Fix or decide on edge cases of Makefile from Active to Review on the Scoring-platform-team (Current) board.
Wed, Feb 21, 10:57 PM · User-Ladsgroup, Scoring-platform-team (Current)
Ladsgroup moved T168455: Implement code generation for model makefile maintenance from Active to Review on the Scoring-platform-team (Current) board.
Wed, Feb 21, 10:56 PM · User-Ladsgroup, Scoring-platform-team (Current), editquality-modeling, artificial-intelligence
Ladsgroup moved T187742: I broke merge_labels utility so bad from Review to Active on the Scoring-platform-team (Current) board.
Wed, Feb 21, 10:55 PM · artificial-intelligence, User-Ladsgroup, editquality-modeling, Scoring-platform-team (Current)
GitHub <noreply@github.com> committed rOEQ1f93478b3e18: Merge 4bfd0544dac0d73179e28771954f513e5a9b8dc7 into… (authored by Ladsgroup).
Merge 4bfd0544dac0d73179e28771954f513e5a9b8dc7 into…
Wed, Feb 21, 9:48 PM
Ladsgroup moved T181335: Redesign onRecentChange_save hook handler for ORES from Active to Review on the Scoring-platform-team (Current) board.
Wed, Feb 21, 9:44 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Scoring-platform-team (Current), Patch-For-Review, User-Ladsgroup, MediaWiki-extensions-ORES
Ladsgroup added a comment to T185712: Make Context serializable.

I would suggest going with another class named "CompactContext" or "SerializerableContext" which has two (more) public functions. "newFromContext" which tuns the context to smallest size possible and returns a new self and other method that turns the compact version into a Context implementation instance with dummy EntityContent (or something similar). This is how we did it with EntityChange (see EntityDiffChangedAspects and its factory) to make it possible to transmit a wikibase repo edits to client wikis without causing too much hassle db/IO/etc. wise.

Wed, Feb 21, 8:56 PM · Wikidata-Sprint-2018-02-14, Patch-For-Review, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Ladsgroup added a comment to T187771: Edit quality campaign for Catalan Wikipedia.

It's uploaded, now you can label in http://labels.wmflabs.org/ui/cawiki/

Wed, Feb 21, 7:56 PM · User-Ladsgroup, Scoring-platform-team (Current)
Ladsgroup moved T187771: Edit quality campaign for Catalan Wikipedia from Active to Done on the Scoring-platform-team (Current) board.
Wed, Feb 21, 7:55 PM · User-Ladsgroup, Scoring-platform-team (Current)
GitHub <noreply@github.com> committed rOEQf00021c38ec9: Merge 65081d6de735fb8241973aa7918524c0926c6e3e into… (authored by Ladsgroup).
Merge 65081d6de735fb8241973aa7918524c0926c6e3e into…
Wed, Feb 21, 7:38 PM
Ladsgroup committed rOEQ65081d6de735: Add Makefile-related rules for the campaign (authored by Ladsgroup).
Add Makefile-related rules for the campaign
Wed, Feb 21, 7:37 PM
Ladsgroup committed rOEQ3f5b39ff071d: Add Makefile-related rules for the campaign (authored by Ladsgroup).
Add Makefile-related rules for the campaign
Wed, Feb 21, 7:24 PM
Ladsgroup added a comment to T185598: property-suggester-scripts master can't be installed on tool forge.

Oh, That's easily fixable. Let me get that worked out.

Wed, Feb 21, 6:10 PM · Patch-For-Review, Mediawiki-extensions-PropertySuggester, User-Ladsgroup, Wikidata
Ladsgroup added a comment to T143791: Enable RecentChanges patrolling on English Wikipedia.

Just wanted to add that old ORES filters even exclude patrolled edits but the new filters don't (which I thought they do until several days ago: T187337: ORES extension highlights edits that are patrolled)

Wed, Feb 21, 1:11 PM · Scoring-platform-team, Wikimedia-Site-requests, Community-consensus-needed

Tue, Feb 20

Ladsgroup added a comment to T178108: Edit quality campaign for Serbian Wikipedia.

Sure :)

Tue, Feb 20, 11:48 PM · Scoring-platform-team (Current), User-Ladsgroup, Wikilabels
Ladsgroup updated subscribers of T187793: Inject IContextSource into ViolationMessageRenderer.

So the reason I made MessageLocalizer is that we wanted to inject RequestContext somewhere just to use the msg method and @daniel pointed out that this class is a huge kitchen sink that are dragging around. That interface is an attempt to decouple RequestContext and message localization. In my ideal world, core would implement a proper RequestBasedMessageLocalizer and we would only inject that but for now I think injecting RequestContext instance using MessageLocalizer typehint (so we can easily mock it in tests, etc.) would be enough for me.

Tue, Feb 20, 9:09 PM · Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Ladsgroup added a comment to T187775: Investigation: Constraints for a database schema to store representations of a Lexeme.

Our idea would be to have it as memcached.

Tue, Feb 20, 8:57 PM · Wikidata-Sprint-2018-02-14, Lexicographical data, Wikidata
Ladsgroup added a comment to T178108: Edit quality campaign for Serbian Wikipedia.

Whatever way that I can get your message works, email, here, visiting WMDE office and having a coffee with me :). Whatever is more convenient for you

Tue, Feb 20, 8:51 PM · Scoring-platform-team (Current), User-Ladsgroup, Wikilabels
Ladsgroup added a subtask for T184322: Enable fine grained lua tracking gradually in client wikis: T186714: enable x-kill feature on Commons.
Tue, Feb 20, 8:43 PM · Patch-For-Review, Wikidata-Sprint-2018-01-03, User-Daniel, Wikidata, User-Ladsgroup, MediaWiki-extensions-WikibaseClient
Ladsgroup added a parent task for T186714: enable x-kill feature on Commons: T184322: Enable fine grained lua tracking gradually in client wikis.
Tue, Feb 20, 8:43 PM · Wikidata-Sprint-2018-02-14, Commons, Wikidata, User-Ladsgroup
Ladsgroup added a comment to T178108: Edit quality campaign for Serbian Wikipedia.

On http://labels.wmflabs.org/ui/srwiki/

Tue, Feb 20, 6:25 PM · Scoring-platform-team (Current), User-Ladsgroup, Wikilabels
Ladsgroup closed T184451: Selenium tests for ORES as Resolved.

Yup, We usually keep done tasks open until we report them but if it's in other teams radar too, we close them.

Tue, Feb 20, 12:18 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-Ladsgroup, Scoring-platform-team (Current), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-RC-Page, MediaWiki-extensions-ORES, User-zeljkofilipin
Ladsgroup added a comment to T187771: Edit quality campaign for Catalan Wikipedia.

@Townie: Hey, can you translate "Edit quality (20k sample)" to Catalan? Thank you :)

Tue, Feb 20, 12:13 PM · User-Ladsgroup, Scoring-platform-team (Current)
Ladsgroup created T187771: Edit quality campaign for Catalan Wikipedia.
Tue, Feb 20, 12:12 PM · User-Ladsgroup, Scoring-platform-team (Current)
Ladsgroup added a comment to T178108: Edit quality campaign for Serbian Wikipedia.

When the campaign is finished. See the stats: http://labels.wmflabs.org/stats/srwiki/62. When it's close to 100%, just let me know and I will do it. Thank you for working on it!

Tue, Feb 20, 12:08 PM · Scoring-platform-team (Current), User-Ladsgroup, Wikilabels

Mon, Feb 19

GitHub <noreply@github.com> committed rOEQ3d9dfe81b1f2: Merge 4bfd0544dac0d73179e28771954f513e5a9b8dc7 into… (authored by Ladsgroup).
Merge 4bfd0544dac0d73179e28771954f513e5a9b8dc7 into…
Mon, Feb 19, 7:30 PM
Ladsgroup committed rOEQ4bfd0544dac0: Fix broken merge_labels, part I (authored by Ladsgroup).
Fix broken merge_labels, part I
Mon, Feb 19, 7:30 PM
Ladsgroup moved T187742: I broke merge_labels utility so bad from Active to Review on the Scoring-platform-team (Current) board.
Mon, Feb 19, 7:28 PM · artificial-intelligence, User-Ladsgroup, editquality-modeling, Scoring-platform-team (Current)
Ladsgroup added a comment to T187742: I broke merge_labels utility so bad.

First fix:
https://github.com/wiki-ai/editquality/pull/130

Mon, Feb 19, 7:28 PM · artificial-intelligence, User-Ladsgroup, editquality-modeling, Scoring-platform-team (Current)
Ladsgroup added a comment to T182611: Train/test reverted model for Catalan Wikipedia.

This is an "edit type" campaign and not an "edit quality" one so making damaging/goodfaith support is not possible.

Mon, Feb 19, 7:07 PM · User-Ladsgroup, editquality-modeling, Scoring-platform-team (Current), artificial-intelligence
Ladsgroup created T187742: I broke merge_labels utility so bad.
Mon, Feb 19, 6:59 PM · artificial-intelligence, User-Ladsgroup, editquality-modeling, Scoring-platform-team (Current)
Ladsgroup added a project to T187337: ORES extension highlights edits that are patrolled: Regression.

For example: https://fa.wikipedia.org/w/index.php?damaging=maybebad%3Bverylikelybad&hidebots=1&hidepatrolled=1&hidecategorization=1&hideWikibase=1&limit=50&days=7&damaging__maybebad_color=c4&damaging__verylikelybad_color=c5&title=%D9%88%DB%8C%DA%98%D9%87:%D8%AA%D8%BA%DB%8C%DB%8C%D8%B1%D8%A7%D8%AA_%D8%A7%D8%AE%DB%8C%D8%B1&highlight=1&urlversion=2
This should be completely empty (or log actions only). I'm not sure if that's intentional. @Catrope is it?

Mon, Feb 19, 5:28 PM · Regression, MediaWiki-extensions-ORES, Scoring-platform-team (Current)
Ladsgroup moved T181335: Redesign onRecentChange_save hook handler for ORES from Review to Active on the Scoring-platform-team (Current) board.
Mon, Feb 19, 5:17 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Scoring-platform-team (Current), Patch-For-Review, User-Ladsgroup, MediaWiki-extensions-ORES
Ladsgroup closed T184938: Special:RecentChanges broken on Jenkins slaves as Resolved.

yup

Mon, Feb 19, 4:13 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Scoring-platform-team (Current), User-Ladsgroup, User-zeljkofilipin, Release-Engineering-Team (Kanban), MediaWiki-extensions-ORES, ORES
Ladsgroup added a comment to T182611: Train/test reverted model for Catalan Wikipedia.

That's so cool: http://labels.wmflabs.org/stats/cawiki/46

Mon, Feb 19, 3:47 PM · User-Ladsgroup, editquality-modeling, Scoring-platform-team (Current), artificial-intelligence
Ladsgroup created T187732: Train/test damaging/goodfaith model for Catalan Wikipedia.
Mon, Feb 19, 3:08 PM · User-Ladsgroup, Scoring-platform-team (Current)
Ladsgroup moved T181335: Redesign onRecentChange_save hook handler for ORES from Active to Review on the Scoring-platform-team (Current) board.
Mon, Feb 19, 2:32 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Scoring-platform-team (Current), Patch-For-Review, User-Ladsgroup, MediaWiki-extensions-ORES
Ladsgroup added a comment to T185903: Train/test damaging and goodfaith model for Hungarian Wikipedia.

Some comments

Updating the page is not enough. You need to make a PR against revscoring and then get it merged and release it in pypi and then bump the version number in editquality requirements.txt

  • updated editquality makefile along these lines. The patch is not super helpful in figuring out what to do:
    • it does not use $@/$</$^, which seems to be the standard today

It has changed. Please take a look at the new Makefile

  • it uses different parameters for revscoring calls (that seems to have changed with T173202)

Overall, I highly recommend trying to template huwiki (T168455: Implement code generation for model makefile maintenance) so you just make a yaml file, run a script and bam! The Makefile has changed.

  • there are a bunch of random-seeming numbers (pop-rate, again coming from T173202) which are different for every wiki

--pop-rate is percentage of true cases in the dataset of that model, grep and count the lines. I love to make it part of the templating script as it's already very confusing and prone to errors but hadn't have time to get around it.

  • it's from before the makefile was split into a manual and a templated part (although huwiki is not templated so that wasn't too confusing).

if you have some time, try to start with templating the huwiki without adding damaging and goodfaith (I think it's not very edge-casey wiki) and then adding damaging and goodfaith models will be rather easy.

Mon, Feb 19, 2:25 PM · User-Tgr, User-Ladsgroup, Scoring-platform-team (Current), editquality-modeling, artificial-intelligence
Ladsgroup added a comment to T182012: Deploy ORES filters to Simple Wikipedia.

It's completely unblocked on the scoring platform team side. I can take over and enable it or leave it to collab's team. It's a half-an-hour task. Check out old enables.

Mon, Feb 19, 11:38 AM · Collaboration-Team-Triage, Edit-Review-Improvements-Integrated-Filters, Patch-For-Review, User-notice-collaboration, Collaboration-Community-Engagement, MediaWiki-extensions-ORES, Scoring-platform-team
Ladsgroup closed T183778: Changes to properties are only injected to client recent changes for pages with X aspect as Invalid.

The task is invalid. For example we enabled xkill for hewiki which means now there is no x aspects usages there at all but still the wiki has 20% of its rows injected from Wikidata (daily):

MariaDB [hewiki_p]> select left(rc_timestamp,8), sum(if(rc_source='wb',1,0)) as WB, count(*),sum(if(rc_source='wb',1,0))/count(*) as RATIO from recentchanges where rc_bot = 0 group by left(rc_timestamp,8);
+----------------------+------+----------+--------+
| left(rc_timestamp,8) | WB   | count(*) | RATIO  |
+----------------------+------+----------+--------+
| 20180120             |  855 |     4337 | 0.1971 |
| 20180121             | 1939 |     6996 | 0.2772 |
| 20180122             | 4083 |     9665 | 0.4225 |
| 20180123             | 1961 |     7237 | 0.2710 |
| 20180124             | 1715 |     7555 | 0.2270 |
| 20180125             | 1803 |     7329 | 0.2460 |
| 20180126             | 1601 |     7099 | 0.2255 |
| 20180127             | 1868 |     7145 | 0.2614 |
| 20180128             | 2262 |     8869 | 0.2550 |
| 20180129             | 3680 |     9262 | 0.3973 |
| 20180130             | 1897 |     8780 | 0.2161 |
| 20180131             | 1655 |     9342 | 0.1772 |
| 20180201             | 1612 |     8753 | 0.1842 |
| 20180202             | 1713 |     7270 | 0.2356 |
| 20180203             | 1630 |     7648 | 0.2131 |
| 20180204             | 1623 |     9053 | 0.1793 |
| 20180205             | 1426 |     7397 | 0.1928 |
| 20180206             | 1641 |     8030 | 0.2044 |
| 20180207             |  953 |     7327 | 0.1301 |
| 20180208             | 1556 |     7645 | 0.2035 |
| 20180209             | 1597 |     8049 | 0.1984 |
| 20180210             | 1672 |     8119 | 0.2059 |
| 20180211             | 1598 |     7916 | 0.2019 |
| 20180212             | 1641 |     8596 | 0.1909 |
| 20180213             | 1667 |     8063 | 0.2067 |
| 20180214             | 1540 |     7503 | 0.2053 |
| 20180215             | 1900 |     8673 | 0.2191 |
| 20180216             | 1447 |     7301 | 0.1982 |
| 20180217             | 1731 |     8041 | 0.2153 |
| 20180218             | 1614 |     8586 | 0.1880 |
| 20180219             |  600 |     3483 | 0.1723 |
+----------------------+------+----------+--------+
31 rows in set (13.12 sec)
Mon, Feb 19, 11:16 AM · Regression, MediaWiki-extensions-WikibaseClient, Wikidata

Sun, Feb 18

Ladsgroup created T187662: Add autopatrol and related rights to fawikisource.
Sun, Feb 18, 9:22 PM · Wikimedia-Site-requests, User-Ladsgroup

Fri, Feb 16

Ladsgroup created T187521: Optimize recentchanges and wbc_entity_usage table across wikis.
Fri, Feb 16, 2:06 AM · Wikidata, DBA

Thu, Feb 15

Ladsgroup added a watcher for VPS-project-codesearch: Ladsgroup.
Thu, Feb 15, 11:39 PM
Ladsgroup committed rOEQ3f4f472b296e: Bumps sample size for bnwikisource and bawiki. (#129) (authored by Halfak).
Bumps sample size for bnwikisource and bawiki. (#129)
Thu, Feb 15, 11:27 PM
Ladsgroup updated subscribers of T180648: Expand the access to 2FA on fawiki.

In my humble opinion, the biggest bottleneck here is increase in number of requests of 2FA reset. I can help Su&Sa with both communication and technical matters. I know a little bit about social engineering and keep that in mind in resetting anyone's 2FA (I also know most prominent users in person, that makes things easier). I hope @Jalexander is fine with it.

Thu, Feb 15, 1:22 AM · Support-and-Safety, Security-Team, Patch-For-Review, Wikimedia-Site-requests
Ladsgroup added a comment to T187337: ORES extension highlights edits that are patrolled.

It's probably both, can't say for sure. I need to investigate in more depth

Thu, Feb 15, 12:20 AM · Regression, MediaWiki-extensions-ORES, Scoring-platform-team (Current)

Wed, Feb 14

Ladsgroup created T187337: ORES extension highlights edits that are patrolled.
Wed, Feb 14, 4:09 PM · Regression, MediaWiki-extensions-ORES, Scoring-platform-team (Current)
Ladsgroup closed T187187: Add uploader user group and give access to them only in mznwiki as Resolved.
Wed, Feb 14, 2:10 PM · Patch-For-Review, Wikimedia-Site-requests, User-Ladsgroup
Ladsgroup placed T186955: Links to items & properties in client recent changes are now redlinks up for grabs.
Wed, Feb 14, 12:12 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, User-Ladsgroup, Regression, MediaWiki-extensions-WikibaseClient, Wikidata
Ladsgroup moved T187265: Enable xkill on top wikis that use x aspect from Backlog to Done on the Wikidata-Sprint-2018-01-31 board.
Wed, Feb 14, 12:08 AM · Patch-For-Review, Wikidata-Sprint-2018-01-31, Wikidata, User-Ladsgroup

Tue, Feb 13

Ladsgroup added a subtask for T184322: Enable fine grained lua tracking gradually in client wikis: T187265: Enable xkill on top wikis that use x aspect.
Tue, Feb 13, 11:18 PM · Patch-For-Review, Wikidata-Sprint-2018-01-03, User-Daniel, Wikidata, User-Ladsgroup, MediaWiki-extensions-WikibaseClient
Ladsgroup added a parent task for T187265: Enable xkill on top wikis that use x aspect: T184322: Enable fine grained lua tracking gradually in client wikis.
Tue, Feb 13, 11:18 PM · Patch-For-Review, Wikidata-Sprint-2018-01-31, Wikidata, User-Ladsgroup
Ladsgroup created T187265: Enable xkill on top wikis that use x aspect.
Tue, Feb 13, 10:55 PM · Patch-For-Review, Wikidata-Sprint-2018-01-31, Wikidata, User-Ladsgroup
Ladsgroup added a comment to T151717: Usage tracking: record which statement group is used.

Well, enabling it on all wikis is one thing that we need to do and with T185693: Implement a (more liberal) usage aspect deduplicater (days: 3) I think it's fine to move forward in everywhere. Give me a detailed enabling plan and consider it done.

Tue, Feb 13, 9:38 PM · DBA, User-Daniel, Wikidata, MediaWiki-extensions-WikibaseClient
Ladsgroup added a comment to T186815: Badges not displaying on trwiki.

One tip, add &debug=true so it doesn't minify the result and seeing results will be easier:

curl 'https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=ext.cite.styles%7Cext.echo.badgeicons%7Cext.echo.styles.badge%7Cext.uls.interlanguage%7Cext.visualEditor.desktopArticleTarget.noscript%7Cext.wikimediaBadges%7Cmediawiki.legacy.commonPrint%2Cshared%7Cmediawiki.sectionAnchor%7Cmediawiki.skinning.interface%7Cskins.vector.styles%7Cwikibase.client.init&only=styles&skin=vector&debug=true' | grep -C 50 '/w/extensions/WikimediaBadges/resources/images/badge-golden-star.png'

The result is okay:

.badge-featuredarticle,
.badge-featuredportal,
.badge-featuredlist {
	list-style-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAkAAAANCAIAAAD0YtNRAAAABnRSTlMA/AD+APzoM1ogAAAAWklEQVR4AWP48+8PLkR7uUdzcMvtU8EhdykHKAciEXL3pvw5FQIURaBDJkARoDhY3zEXiCgCHbNBmAlUiyaBkENoxZSDWnOtBmoAQu7TnT+3WuDOA7KBIkAGAGwiNeqjusp/AAAAAElFTkSuQmCC);
	list-style-image: url(/w/extensions/WikimediaBadges/resources/images/badge-golden-star.png?ed948)!ie;
}

This is part of WikimediaBadges extension: https://phabricator.wikimedia.org/diffusion/EWMB/browse/master/resources/skins/vector/wikimedia-badges.css
The thing is that the url is not giving out 404: https://en.wikipedia.org/w/extensions/WikimediaBadges/resources/images/badge-golden-star.png?ed948
The url that was giving out 404 for trwiki had an extra Wikidata bundle: https://en.wikipedia.org/w/extensions/Wikidata/extensions/WikimediaBadges/resources/images/badge-golden-star.png
The reason that the url is struck through in your browser is that, it's not using that url and it's using the SVG version (the above list-style-image rule) instead which is faster.
HTH

Tue, Feb 13, 8:23 PM · Operations, Wikidata
Ladsgroup added a comment to T186815: Badges not displaying on trwiki.

I don't think we have anything else that is used wiki-wide in large scale. Unless my query is wrong.

ladsgroup@tin:~$ mwgrep "WikimediaBadges"
bhwiki              MediaWiki:Gadget-LiveRCSiteConfig.js
fiwiki              MediaWiki:Gadget-LiveRCSiteConfig.js
frwiki              MediaWiki:Gadget-LiveRCSiteConfig.js
frwiki              MediaWiki:Gadget-LiveRCSiteConfig.js/Dev.js
itwiki              MediaWiki:Gadget-LiveRCSiteConfig.js
kabwiki             MediaWiki:Gadget-LiveRCSiteConfig.js
Tue, Feb 13, 7:41 PM · Operations, Wikidata
Ladsgroup created T187187: Add uploader user group and give access to them only in mznwiki.
Tue, Feb 13, 1:38 PM · Patch-For-Review, Wikimedia-Site-requests, User-Ladsgroup
Ladsgroup added a comment to T183778: Changes to properties are only injected to client recent changes for pages with X aspect.

I will look into this in more depth when I'm back from vacation (next Monday)

Tue, Feb 13, 1:33 PM · Regression, MediaWiki-extensions-WikibaseClient, Wikidata
Ladsgroup closed T87645: Existing pages without ability to reach and obviously wrong namespace as Resolved.

This happened and was high priority around that time (if not UBN!) but since then, this hasn't happened anymore. I think we should resolve it and re-open it if it happened again.

Tue, Feb 13, 1:31 PM · User-Ladsgroup, Chinese-Sites, Patch-For-Review, Wikimedia-General-or-Unknown
Ladsgroup closed T87645: Existing pages without ability to reach and obviously wrong namespace, a subtask of T95277: Erroneous Category:Category:Pages_with_script_errors , as Resolved.
Tue, Feb 13, 1:31 PM · MediaWiki-Categories, Commons
Ladsgroup added a comment to T164753: ProofreadPage Quality selector needs to be transformed to OOUI.

Or perhaps a better answer is to make it possible to create a ButtonSelectWidget from PHP? How much work would that be? (I've never played with OOUI in that way.) I guess it'd be a <select> element underneath, but rendered as a set of buttons?

Tue, Feb 13, 1:28 PM · Patch-For-Review, UI-Standardization, ProofreadPage
Ladsgroup closed T173710: Job queue is increasing non-stop as Resolved.

The jobqueue size has been reduced to 1.6M and will go down more once we enable "lua fine grained usage tracking" and "statement fine grained usage tracking" in more wikis.

Tue, Feb 13, 1:14 PM · User-Ladsgroup, User-Elukey, Services (watching), Performance-Team (Radar), Wikidata, Operations, MediaWiki-JobQueue
Ladsgroup closed T173710: Job queue is increasing non-stop, a subtask of T175897: Audit and improve JobQueue stability and performance (2017), as Resolved.
Tue, Feb 13, 1:14 PM · Performance-Team

Mon, Feb 12

Ladsgroup updated subscribers of T186815: Badges not displaying on trwiki.

This happened because we removed the bundle of Wikidata from the production and thus the addresses got lost. Where these addresses have used? in Vector.css of trwiki. In order to bring the badges back, you just need to delete the rules at the bottom of the page. Maybe we should do a grep to check if more cases are still being used in Wikipedia-land CC. @Lydia_Pintscher.

Mon, Feb 12, 11:20 PM · Operations, Wikidata