Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani)
Shah of Bugs, Emir of database architecture, World-renowned rubber duckAdministrator

Today

  • No visible events.

Tomorrow

  • No visible events.

Sunday

  • No visible events.

User Details

User Since
Oct 6 2014, 9:53 PM (582 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Staff Database Architect in SRE data persistence team in WMF. Used to be Wikidata software engineer at WMDE

I'm also open source enthusiast, mediawiki volunteer developer, and long-term Wikipedian.

All edits on tickets about databases are in my work capacity and anything else is in my volunteer capacity unless mentioned otherwise.

Babel: fa-N, en-4, de-2, tr-1, hu-1

Recent Activity

Today

Ladsgroup triaged T411835: Investigate unusal dbs in x1 as Medium priority.
Fri, Dec 5, 1:24 AM · DBA
Ladsgroup created T411835: Investigate unusal dbs in x1.
Fri, Dec 5, 1:24 AM · DBA
Ladsgroup added a comment to T410747: Review production mariadb tables are still compressed (2026).

I did a "bash" one-liner so bad I'm proud of it:

root@db1169:~# find /srv/sqldata/ -size +10G -exec du -h {} \; | cut -f2 |  python3 -c "import sys, re;print(re.sub('/srv/sqldata/([^/]+?)/([^/]+?)\.ibd', r'\1.\2', ''.join(sys.stdin)))" | grep '\.' | xargs -I{} bash -c 'echo {}; mysql -e "show create table {};"' | grep -v COMPRE | grep -v "Create Table"
<string>:1: SyntaxWarning: invalid escape sequence '\.'
--------------
show create table /srv/sqldata/db1052.err
--------------
Fri, Dec 5, 1:10 AM · Data-Persistence, database-backups, DBA
Ladsgroup added a comment to T351953: Various old revisions are encoded as Windows-1252 rather than UTF-8, causing "RuntimeException: PCRE failure" when viewing them.

That would be all of issues in small.dblist wikis. Now running medium wikis.

Fri, Dec 5, 12:28 AM · MW-1.46-notes (1.46.0-wmf.5; 2025-12-02), MW-1.45-notes, MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), User-brennen, Essential-Work, Content-Transform-Team, Wikimedia-production-error, Wikimedia-database-issue (Bad data)
Ladsgroup added a comment to T351953: Various old revisions are encoded as Windows-1252 rather than UTF-8, causing "RuntimeException: PCRE failure" when viewing them.
ladsgroup@deploy2002:~$ mwscript-k8s --follow -- findBadBlobs.php --wiki guwiktionary --mark --revisions 20576
⏳ Starting findBadBlobs.php on Kubernetes as job mw-script.codfw.llaqsrum ...
🚀 Job is running.
📜 Streaming logs:
The --mark must be used together with --revisions
Fri, Dec 5, 12:24 AM · MW-1.46-notes (1.46.0-wmf.5; 2025-12-02), MW-1.45-notes, MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), User-brennen, Essential-Work, Content-Transform-Team, Wikimedia-production-error, Wikimedia-database-issue (Bad data)

Yesterday

Ladsgroup added a comment to T411821: Add sic_updated_timestamp column and associated indexes to the cusi_case table.

LGTM, I ask to drop the indexes once you're done with it. Even though it's small. Let's add them when they become needed.

Thu, Dec 4, 11:53 PM · Data-Engineering, Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12), Schema-change, DBA, CheckUser-SuggestedInvestigations
Ladsgroup added a comment to T411577: Make ChangesListQuery compatible with commons split.

If this is about RecentChangesLinked: I think the only solution we can do is to query templatelinks/imagelinks/etc from the requested page with limit of 1000 and then query rc table with condition of rc_page IN (...). Meaning for most cases it'll still continue to work as is but it'll break for more heavily used pages.

Thu, Dec 4, 11:50 PM · Data-Persistence
Ladsgroup added a comment to T409438: Enable revertrisk filters in thwiki.

@Kgraessle do you need the ores tables? like ores_models and ores_classification?

Thu, Dec 4, 11:46 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), OKR-Work, Machine-Learning-Team, MediaWiki-extensions-ORES, PersonalDashboard, MediaWiki-Recent-changes
Ladsgroup claimed T405005: Implement mechanism to exclude a domain from externallinks database (LinkSearch).
Thu, Dec 4, 6:36 PM · DBA, User-notice, MW-1.46-notes (1.46.0-wmf.7; 2025-12-16), Proposal, MediaWiki-Platform-Team (Radar), MediaWiki-Page-derived-data
Ladsgroup moved T405005: Implement mechanism to exclude a domain from externallinks database (LinkSearch) from Triage to In progress on the DBA board.
Thu, Dec 4, 6:36 PM · DBA, User-notice, MW-1.46-notes (1.46.0-wmf.7; 2025-12-16), Proposal, MediaWiki-Platform-Team (Radar), MediaWiki-Page-derived-data
Ladsgroup added projects to T405005: Implement mechanism to exclude a domain from externallinks database (LinkSearch): User-notice, DBA.

User notice suggestion:

URLs to other wikimedia projects won't be registered as external links meaning they won't be recorded on externallinks table, won't be searchable in Special:LinkSearch and won't be checked against spam blacklist or abuse filters added_links variable. This is to reduce the undies load on the databases abs improve editing save time. Also a limited number of trusted websites that are heavily used might be added to each wiki individually. For example Creative Commons website will be added to the ignore list in Wikimedia Commons due to large number of links to their license pages.

Thu, Dec 4, 6:34 PM · DBA, User-notice, MW-1.46-notes (1.46.0-wmf.7; 2025-12-16), Proposal, MediaWiki-Platform-Team (Radar), MediaWiki-Page-derived-data
Ladsgroup added a project to T411510: Incorporate appserver saturation into maxlag value in MediaWiki: MW-Interfaces-Team.
Thu, Dec 4, 2:27 PM · MW-Interfaces-Team, MediaWiki-General
Ladsgroup added a comment to T403397: Externallinks in Russian Wikinews is unusually large.

Compared to another host that isn't optimized yet:

root@db1175:/srv/sqldata/ruwikinews# ls -Ssh
total 256G
130G externallinks.ibd
 31G categorylinks.ibd
 22G page_props.ibd
 16G logging.ibd
Thu, Dec 4, 1:33 PM · Russian-Sites, DBA
Ladsgroup added a comment to T403397: Externallinks in Russian Wikinews is unusually large.

FTR:

root@db1157:/srv/sqldata/ruwikinews# ls -Ssh | head
total 81G
 17G externallinks.ibd
 14G logging.ibd
9.7G categorylinks.ibd
Thu, Dec 4, 1:32 PM · Russian-Sites, DBA

Wed, Dec 3

Ladsgroup added a comment to T411728: Codesearch down/unreachable (2025-12-03).

ah okay, I leave it now. FWIW it's inode:

ladsgroup@codesearch9:~$ df -i | grep -i srv
/dev/sdb       5242880 5242879       1  100% /srv
Wed, Dec 3, 11:13 PM · VPS-project-Codesearch
Ladsgroup added a comment to T411728: Codesearch down/unreachable (2025-12-03).

Well, I can't even ssh into the host to check what's going on 😢

Wed, Dec 3, 11:07 PM · VPS-project-Codesearch
Ladsgroup added a comment to T375981: Preferences settings for small image size are not being respected for Parsoid Read Views.

I think having two thumbnail preferences ("normal" and "large/accessible") might solve most issues, although we'd still have the complexity in core of serving HTML with two different sizes. I haven't seen a discussion of responsive images yet: in many cases even though the screen px is fixed, our HTML mentions thumbnails in 3 or so different resolutions based on the screen magnification factor.

Wed, Dec 3, 11:05 PM · Readers Essential Work 2025 (Parsoid roll out to Wikipedias), OKR-Work, Content-Transform-Team (Work In Progress), Parsoid-Read-Views (Small Size Wikipedias), Parsoid
Ladsgroup added a comment to T351953: Various old revisions are encoded as Windows-1252 rather than UTF-8, causing "RuntimeException: PCRE failure" when viewing them.

I'm seeing the check for archive failing sometimes with this:

Wikimedia\Assert\ParameterAssertionException from line 72 of /srv/mediawiki/php-1.46.0-wmf.4/vendor/wikimedia/assert/src/Assert.php: Bad value for parameter $page: must represent a proper page
#0 /srv/mediawiki/php-1.46.0-wmf.4/includes/Revision/RevisionArchiveRecord.php(80): Wikimedia\Assert\Assert::parameter(false, '$page', 'must represent ...')
#1 /srv/mediawiki/php-1.46.0-wmf.4/includes/Revision/RevisionStore.php(1639): MediaWiki\Revision\RevisionArchiveRecord->__construct(Object(MediaWiki\Title\Title), Object(MediaWiki\User\UserIdentityValue), Object(MediaWiki\CommentStore\CommentStoreComment), Object(stdClass), Object(MediaWiki\Revision\RevisionSlots), false)
#2 /srv/mediawiki/php-1.46.0-wmf.4/includes/Revision/RevisionStore.php(2038): MediaWiki\Revision\RevisionStore->newRevisionFromArchiveRowAndSlots(Object(stdClass), Object(MediaWiki\Revision\RevisionSlots), 0, Object(MediaWiki\Title\Title))
#3 [internal function]: MediaWiki\Revision\RevisionStore->MediaWiki\Revision\{closure}(Object(stdClass))
#4 /srv/mediawiki/php-1.46.0-wmf.4/includes/Revision/RevisionStore.php(2017): array_map(Object(Closure), Array)
#5 /srv/mediawiki/php-1.46.0-wmf.4/maintenance/findBadBlobs.php(287): MediaWiki\Revision\RevisionStore->newRevisionsFromBatch(Object(Wikimedia\Rdbms\MysqliResultWrapper), Array)
#6 /srv/mediawiki/php-1.46.0-wmf.4/maintenance/findBadBlobs.php(216): FindBadBlobs->loadArchiveByRevisionId(10451, 34930298, 1000)
#7 /srv/mediawiki/php-1.46.0-wmf.4/maintenance/findBadBlobs.php(128): FindBadBlobs->scanRevisionsByTimestamp()
#8 /srv/mediawiki/php-1.46.0-wmf.4/maintenance/includes/MaintenanceRunner.php(696): FindBadBlobs->execute()
#9 /srv/mediawiki/php-1.46.0-wmf.4/maintenance/run.php(53): MediaWiki\Maintenance\MaintenanceRunner->run()
#10 /srv/mediawiki/multiversion/MWScript.php(221): require_once('/srv/mediawiki/...')
Wed, Dec 3, 7:58 PM · MW-1.46-notes (1.46.0-wmf.5; 2025-12-02), MW-1.45-notes, MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), User-brennen, Essential-Work, Content-Transform-Team, Wikimedia-production-error, Wikimedia-database-issue (Bad data)
Ladsgroup closed T405087: Remove concept of groups in rdbms load balancer and replace it with shuffle sharding as Resolved.
Wed, Dec 3, 3:30 PM · MW-1.46-notes (1.46.0-wmf.3; 2025-11-19), Patch-For-Review, MW-1.45-notes (1.45.0-wmf.25; 2025-10-28), Wikidata, DBA, MediaWiki-libs-Rdbms
Ladsgroup closed T389893: Remove modtoken and multiPrimaryMode from SqlBagOStuff and mainstash as Resolved.
Wed, Dec 3, 3:15 PM · MW-1.46-notes (1.46.0-wmf.5; 2025-12-02), MW-1.45-notes (1.45.0-wmf.25; 2025-10-28), MediaWiki-Platform-Team (Radar), MediaWiki-libs-BagOStuff, DBA
Ladsgroup edited projects for T406843: Create watchlist labels database tables, added: Data-Persistence (work done); removed DBA.
Wed, Dec 3, 3:15 PM · Data-Persistence (work done), MW-1.46-notes (1.46.0-wmf.2; 2025-11-12), Community-Tech (Fox Squad), Watchlist-Labels
Ladsgroup closed T403397: Externallinks in Russian Wikinews is unusually large as Resolved.
Wed, Dec 3, 3:12 PM · Russian-Sites, DBA
Ladsgroup added a comment to T403397: Externallinks in Russian Wikinews is unusually large.

There is only 31 pages left in that category.

Wed, Dec 3, 3:12 PM · Russian-Sites, DBA
Ladsgroup closed T408801: Expectation (readQueryRows <= 10000) by MediaWiki\Actions\ActionEntryPoint::execute not met (caused by RestrictionStore), a subtask of T398709: FY2025-26 WE 6.4.1: Move links tables of commons to a dedicated cluster, as Resolved.
Wed, Dec 3, 2:59 PM · OKR-Work, Epic, Data-Persistence, Commons
Ladsgroup closed T408801: Expectation (readQueryRows <= 10000) by MediaWiki\Actions\ActionEntryPoint::execute not met (caused by RestrictionStore) as Resolved.

\o/

Wed, Dec 3, 2:59 PM · MW-1.46-notes (1.46.0-wmf.7; 2025-12-16), MediaWiki-Page-protection, DBA, Wikimedia-production-error
Ladsgroup created P86355 (An Untitled Masterwork).
Wed, Dec 3, 8:20 AM
Ladsgroup updated the task description for T410589: Optimize all core tables, late 2025.
Wed, Dec 3, 7:26 AM · DBA
Ladsgroup updated the task description for T411497: Drop modtoken and flags from cache tables.
Wed, Dec 3, 6:22 AM · Schema-change-in-production, DBA, Data-Engineering
Ladsgroup added a comment to T411573: sre.mysql.parsercache: make it work with msX sections.

I beat my usual drum 😅 : It all should be under one "depool" cookbook.

Wed, Dec 3, 6:21 AM · DBA
Ladsgroup added a comment to T411497: Drop modtoken and flags from cache tables.

Thank you both. After @Krinkle's message above, I am not sure whether I can proceed deleting them on parsercache or I should wait until the code is cleaned up?

Wed, Dec 3, 6:05 AM · Schema-change-in-production, DBA, Data-Engineering
Ladsgroup added a comment to T375981: Preferences settings for small image size are not being respected for Parsoid Read Views.

Remove all options greater than 250px.

Yes. I think it would be sensible to remove these.

Wed, Dec 3, 6:03 AM · Readers Essential Work 2025 (Parsoid roll out to Wikipedias), OKR-Work, Content-Transform-Team (Work In Progress), Parsoid-Read-Views (Small Size Wikipedias), Parsoid

Tue, Dec 2

Ladsgroup added a comment to T375981: Preferences settings for small image size are not being respected for Parsoid Read Views.

One thing that could be a middle ground is to have "large thumbnail" mode and split the PC into two modes, default and large. Then all other options would simply turn into a css. PC would split into two but better than six/seven. Loading everything with 500px is a non-starter. The increase would be quite big.

Tue, Dec 2, 3:54 PM · Readers Essential Work 2025 (Parsoid roll out to Wikipedias), OKR-Work, Content-Transform-Team (Work In Progress), Parsoid-Read-Views (Small Size Wikipedias), Parsoid
Ladsgroup created T411510: Incorporate appserver saturation into maxlag value in MediaWiki.
Tue, Dec 2, 3:44 PM · MW-Interfaces-Team, MediaWiki-General
Ladsgroup added a comment to T411497: Drop modtoken and flags from cache tables.

So the tables are built from the structure of objectcache table. They take the schema of objectcache and use it template to create other tables (see SqlBagOStuff:createTables) and SqlBagOStuff is flexible in terms of the name of the table it needs to query. i.e. the objectcache table schema in core is a template many parts of core use to create tables with other names (including Parser cache tables, main stash tables, etc.)

Tue, Dec 2, 2:36 PM · Schema-change-in-production, DBA, Data-Engineering
Ladsgroup added a comment to T375981: Preferences settings for small image size are not being respected for Parsoid Read Views.

So in terms of the load on the infra, this is not an issue anymore since mediawiki automatically turns them into one of the steps (T360589) so this is merely a css config at this point.

Tue, Dec 2, 2:03 PM · Readers Essential Work 2025 (Parsoid roll out to Wikipedias), OKR-Work, Content-Transform-Team (Work In Progress), Parsoid-Read-Views (Small Size Wikipedias), Parsoid
Ladsgroup added a comment to T375981: Preferences settings for small image size are not being respected for Parsoid Read Views.

So in terms of the load on the infra, this is not an issue anymore since mediawiki automatically turns them into one of the steps (T360589) so this is merely a css config at this point. I had plans and did clean up some of these values though T106640: Choose a sensible set of thumbnail sizes for Special:Preferences Specially my suggestion in T106640#10761152

Tue, Dec 2, 1:59 PM · Readers Essential Work 2025 (Parsoid roll out to Wikipedias), OKR-Work, Content-Transform-Team (Work In Progress), Parsoid-Read-Views (Small Size Wikipedias), Parsoid
Ladsgroup added a comment to T411497: Drop modtoken and flags from cache tables.
$ sudo db-mysql pc1011 parsercache -e "show tables like 'objec%'";
+--------------------------------+
| Tables_in_parsercache (objec%) |
+--------------------------------+
| objectcache                    |
+--------------------------------+
Tue, Dec 2, 1:51 PM · Schema-change-in-production, DBA, Data-Engineering
Ladsgroup created T411497: Drop modtoken and flags from cache tables.
Tue, Dec 2, 1:39 PM · Schema-change-in-production, DBA, Data-Engineering

Mon, Dec 1

Ladsgroup updated the task description for T410589: Optimize all core tables, late 2025.
Mon, Dec 1, 8:44 AM · DBA

Sun, Nov 30

Ladsgroup added a comment to T353458: Make core classes follow PSR-4.

With that ^ only 8% left (298 classes: P85110)

Sun, Nov 30, 4:01 PM · MW-1.46-notes (1.46.0-wmf.7; 2025-12-16), MW-1.45-notes, MW-1.44-notes, MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Wikimedia-Hackathon-2024, MediaWiki-core-Hackathon-2024, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Patch-For-Review, MediaWiki CodeJam Dec 2023, MediaWiki-General
Ladsgroup edited P85110 (An Untitled Masterwork).
Sun, Nov 30, 3:59 PM

Fri, Nov 28

Ladsgroup closed T410624: Stop pulling netbox-exported-dns repo from Phabricator Diffusion (which mirrors netbox-exports.wikimedia.org), a subtask of T405596: Disable IO for diffusion repositories, as Resolved.
Fri, Nov 28, 4:01 PM · Release-Engineering-Team (Priority Backlog 📥), Patch-For-Review, collaboration-services, Diffusion, Phabricator
Ladsgroup closed T410624: Stop pulling netbox-exported-dns repo from Phabricator Diffusion (which mirrors netbox-exports.wikimedia.org) as Resolved.

It has finally stopped

Fri, Nov 28, 4:01 PM · collaboration-services, VPS-project-Codesearch
Ladsgroup added a comment to T410624: Stop pulling netbox-exported-dns repo from Phabricator Diffusion (which mirrors netbox-exports.wikimedia.org).

Don't ask how I got this:

Nov 28 14:38:09 codesearch9 write_config.py[705745]: <class 'dict'> {'url': 'https://gerrit-replica.wikimedia.org/r/labs/countervandalism/stillalive.git', 'url-pattern': {'base-url': 'https://gerrit.wikimedia.org/g/labs/countervandalism/stillalive/+/{rev}/{path}{anchor}', 'anchor': '#{line}'}, 'ms-between-poll': 5400000}
Nov 28 14:38:09 codesearch9 write_config.py[705745]: <class 'str'> https://github.com/toolforge/paws
Nov 28 14:38:09 codesearch9 write_config.py[705745]: <class 'int'> 5400000
Fri, Nov 28, 2:39 PM · collaboration-services, VPS-project-Codesearch
Ladsgroup added a comment to T410624: Stop pulling netbox-exported-dns repo from Phabricator Diffusion (which mirrors netbox-exports.wikimedia.org).

Write config is broken:

Nov 28 14:24:49 codesearch9 write_config.py[705103]: Skip unsupported remote URL: https://git.push-f.com/mw-code/
Nov 28 14:24:49 codesearch9 write_config.py[705103]: Traceback (most recent call last):
Nov 28 14:24:49 codesearch9 write_config.py[705103]:   File "/srv/codesearch/write_config.py", line 632, in <module>
Nov 28 14:24:49 codesearch9 write_config.py[705103]:     main()
Nov 28 14:24:49 codesearch9 write_config.py[705103]:   File "/srv/codesearch/write_config.py", line 581, in main
Nov 28 14:24:49 codesearch9 write_config.py[705103]:     make_conf('search', args,
Nov 28 14:24:49 codesearch9 write_config.py[705103]:   File "/srv/codesearch/write_config.py", line 548, in make_conf
Nov 28 14:24:49 codesearch9 write_config.py[705103]:     new = extract_urls(conf)
Nov 28 14:24:49 codesearch9 write_config.py[705103]:           ^^^^^^^^^^^^^^^^^^
Nov 28 14:24:49 codesearch9 write_config.py[705103]:   File "/srv/codesearch/write_config.py", line 568, in extract_urls
Nov 28 14:24:49 codesearch9 write_config.py[705103]:     return {repo['url'] for repo in conf['repos'].values()}
Nov 28 14:24:49 codesearch9 write_config.py[705103]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 28 14:24:49 codesearch9 write_config.py[705103]:   File "/srv/codesearch/write_config.py", line 568, in <setcomp>
Nov 28 14:24:49 codesearch9 write_config.py[705103]:     return {repo['url'] for repo in conf['repos'].values()}
Nov 28 14:24:49 codesearch9 write_config.py[705103]:             ~~~~^^^^^^^
Nov 28 14:24:49 codesearch9 write_config.py[705103]: TypeError: string indices must be integers, not 'str'
Fri, Nov 28, 2:25 PM · collaboration-services, VPS-project-Codesearch
Ladsgroup added a comment to T410624: Stop pulling netbox-exported-dns repo from Phabricator Diffusion (which mirrors netbox-exports.wikimedia.org).

I'm forcing a restart of the services, let's see if that makes an impact.

Fri, Nov 28, 1:46 PM · collaboration-services, VPS-project-Codesearch
Ladsgroup added a comment to T410696: Deploy enwiki edition of 2025 GRS.

Apologies, we had to revert this. It was causing 701K errors in 15 minutes. In comparison, the rest of mediawiki in that period caused only 4K errors.

Fri, Nov 28, 1:28 PM · Research (FY2025-26-Research-October-December)
Ladsgroup added a comment to T410696: Deploy enwiki edition of 2025 GRS.

Hello! Since 1212204 was backported, it has been producing thousands of error messages https://logstash.wikimedia.org/goto/103ab3d23a65b901740f79fc62e71e9a

Fri, Nov 28, 1:07 PM · Research (FY2025-26-Research-October-December)

Thu, Nov 27

Ladsgroup added a comment to T297297: Investigate the unusual dbs in s3.

oh one thing: I should check x1 dbs, if these wikis get recreated, then it'll be quite a fun time with x1.

Thu, Nov 27, 9:15 PM · DBA
Ladsgroup added a comment to T411125: Tweak common ThumbnailSteps handling in PHP and JS.

Ah fair. Thanks for spotting it. Let me see if I can fix it easily.

Thu, Nov 27, 2:57 PM · MW-1.46-notes (1.46.0-wmf.7; 2025-12-16), Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26), Commons, MediaWiki-File-management, Page-Previews
Ladsgroup added a comment to T411125: Tweak common ThumbnailSteps handling in PHP and JS.

Wouldn't browsers been able to do it on the fly? I'd be surprised if FF can't upscale a svg. I can try in beta cluster but it's down.

Thu, Nov 27, 2:50 PM · MW-1.46-notes (1.46.0-wmf.7; 2025-12-16), Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26), Commons, MediaWiki-File-management, Page-Previews
Ladsgroup added a comment to T408460: Allow participants to opt out of post-publication dialogue.

nbd. Go for it.

Thu, Nov 27, 2:48 PM · Data-Persistence, Schema-change, Patch-For-Review, OKR-Work, CampaignEvents, Connection-Team (Connection-Current-Sprint)
Ladsgroup added a comment to T402792: Consider rate limiting non-standard thumbnail sizes.

I don't know the details of ForeignAPIFile but the API endpoints actually return the correct standardized thumb urls. See for example: https://commons.wikimedia.org/w/api.php?action=query&titles=File:Albert%20Einstein%20Head.jpg&prop=imageinfo&iiurlwidth=100&iiprop=url and since this is on our side, it should be technically automatically deployed everywhere. Obviously, if InstantCommons/ForeignAPIFile uses another API endpoint, then it's a different story. I'd argue we still could rate limit and encourage people to either use standard sizes or build a cache. We are not fully disallowing it, just pushing for a more responsible use of the infra by rate limiting excessive requests.

Thu, Nov 27, 2:11 PM · Traffic
Ladsgroup added a comment to T348255: Parser cache infrastructure for OutputTransform.

For "page" I don't mean two different parser cache types. That's correct. I should have given more context. When we had 3 pc shard and in old times, when a cluster (pc1 for example) turned empty for various reasons. 1/3rd of parser cache entries got invalidated because "idoptions" key was missing, and 1/3rd got invalidated because "idhash" entry was missing so we ended up with 2/3rd of entries getting invalidated (if you want to be more exact, it'd be 56% because 1/9th would be in the same). Adding sister keys avoided that so when we depool a cluster, only 1/nth of the page views require a reparse. That obviously means it's fine whether legacy parser or parsoid is living in separate clusters since they don't share a code path. I don't know about post-parse processing though. I assume it'd be better to make sure they still around the same page in parsoid to avoid partial loss of parsed data. Do I make sense? or I'm just confusing you more. If you want, we can hop on a call.

Thu, Nov 27, 1:58 PM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), Content-Transform-Team (Work In Progress), Patch-For-Review, Parsoid-Read-Views (Performance), OKR-Work
Ladsgroup added a comment to T410145: Build a way to duplicate a whole wiki from one section to another.

Another point to consider: https://meta.wikimedia.org/wiki/Wikimedia_Foundation_Community_Affairs_Committee/Sister_Projects_Task_Force/Results_of_the_consultation_about_Wikispore_and_Wikinews#Wikinews it's very likely most if not all wikinews projects will be closed and archived which means number of closed wikis will reach ~170. Having a small archive cluster that we could move all of these wikis to would help s3 a lot.

That's great - however, remember that for closed projects (with no writes) this whole process is way way easier.

Thu, Nov 27, 1:35 PM · DBA, MediaWiki-libs-Rdbms
Ladsgroup added a comment to T410145: Build a way to duplicate a whole wiki from one section to another.

Another point to consider: https://meta.wikimedia.org/wiki/Wikimedia_Foundation_Community_Affairs_Committee/Sister_Projects_Task_Force/Results_of_the_consultation_about_Wikispore_and_Wikinews#Wikinews it's very likely most if not all wikinews projects will be closed and archived which means number of closed wikis will reach ~170. Having a small archive cluster that we could move all of these wikis to would help s3 a lot.

Thu, Nov 27, 1:26 PM · DBA, MediaWiki-libs-Rdbms
Ladsgroup placed T344534: Explore bot-replacing all WikiHiero uses with Unicode glyphs, and switching off the extension up for grabs.

Stopping cookie licking but I will hope to take a look in Wikimedia Hackathon

Thu, Nov 27, 2:12 AM · Reader Experience Team, Wikimania-Hackathon-2026, WikiHiero
Ladsgroup added a comment to T408460: Allow participants to opt out of post-publication dialogue.

LGTM. No concerns from our side. nitpick: The name of the field is quite a mouthful. Maybe a shorter name? :P

Thu, Nov 27, 1:59 AM · Data-Persistence, Schema-change, Patch-For-Review, OKR-Work, CampaignEvents, Connection-Team (Connection-Current-Sprint)

Wed, Nov 26

Ladsgroup updated subscribers of T411092: InvalidArgumentException: Wikimedia\Rdbms\Platform\SQLPlatform::makeList: empty input for field tl_from.
Wed, Nov 26, 12:52 PM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), DBA, MediaWiki-Page-protection, Wikimedia-production-error
Ladsgroup created T411088: Clean up groups config.
Wed, Nov 26, 11:54 AM · DBA

Tue, Nov 25

Ladsgroup added a comment to T348255: Parser cache infrastructure for OutputTransform.

Data persistence opinion has been requested. I don't think it could cause any problems to the infra to add the extra keys to PC, but it would be extremely important that extra keys should end up in the same host using the concept of sister keys. The work I did in gerrit:1078013 and gerrit:1079677. This way, if we depool a host for maintenance, only 1/8th of the pages will be affected (status quo) and if they are not sister keys then it would be quite a problem. But if that's taken care of, I don't think we have any issues. Once it's rolled out, let us know so we can keep an eye on the infra.

Tue, Nov 25, 11:01 PM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), Content-Transform-Team (Work In Progress), Patch-For-Review, Parsoid-Read-Views (Performance), OKR-Work
Ladsgroup added a comment to T402792: Consider rate limiting non-standard thumbnail sizes.

I don't know the details of ForeignAPIFile but the API endpoints actually return the correct standardized thumb urls. See for example: https://commons.wikimedia.org/w/api.php?action=query&titles=File:Albert%20Einstein%20Head.jpg&prop=imageinfo&iiurlwidth=100&iiprop=url and since this is on our side, it should be technically automatically deployed everywhere. Obviously, if InstantCommons/ForeignAPIFile uses another API endpoint, then it's a different story. I'd argue we still could rate limit and encourage people to either use standard sizes or build a cache. We are not fully disallowing it, just pushing for a more responsible use of the infra by rate limiting excessive requests.

Tue, Nov 25, 10:53 PM · Traffic
Ladsgroup added a comment to T411013: Popups should use standard thumbnail sizes.

It would be great if we can get the simple patch deployed in the meantime so we can start working on rate limiting non-standard sizes

Tue, Nov 25, 8:21 PM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26), Page-Previews
Ladsgroup added a comment to T410304: Measure request frequency of thumbnail sizes.

T411013: Popups should use standard thumbnail sizes for longer term solution

Tue, Nov 25, 4:48 PM · Page-Previews, MediaViewer, Data-Persistence, Thumbor, SRE-swift-storage, Traffic
Ladsgroup added a comment to T408663: Unify weights on hosts that are not in vslow/dumps.

Deployed now, feel free to clean it up.

Tue, Nov 25, 1:28 PM · DBA
Ladsgroup added a comment to T411013: Popups should use standard thumbnail sizes.

I made https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/1211107 as a stop-gap to take care of the biggest chunk.

Tue, Nov 25, 1:26 PM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26), Page-Previews
Ladsgroup created T411013: Popups should use standard thumbnail sizes.
Tue, Nov 25, 1:26 PM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26), Page-Previews
Ladsgroup added a comment to T410304: Measure request frequency of thumbnail sizes.

I was kinda sure it was Popups and lo and behold, it's Popups: https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups/+/8754132e08cedfc0ac70b2bb1dded01e55472e93/src/gateway/rest.js#119

Tue, Nov 25, 12:40 PM · Page-Previews, MediaViewer, Data-Persistence, Thumbor, SRE-swift-storage, Traffic
Ladsgroup added a comment to T410304: Measure request frequency of thumbnail sizes.

Okay, I checked several more cases and they all seems to be coming from rest endpoint for page summary. For example, there is another one that hits https://en.wikipedia.org/api/rest_v1/page/summary/World_War_II and immediately https://uploads.wikimedia.org/wikipedia/commons/thumb/1/10/Bundesarchiv_Bild_101I-646-5188-17%2C_Flugzeuge_Junkers_Ju_87.jpg/480px-Bundesarchiv_Bild_101I-646-5188-17%2C_Flugzeuge_Junkers_Ju_87.jpg which is the same image provided in the thumbnail attribute of the page summary endpoint but when I open the link the thumbnail is a different size o.O

Tue, Nov 25, 12:13 PM · Page-Previews, MediaViewer, Data-Persistence, Thumbor, SRE-swift-storage, Traffic
Ladsgroup added a comment to T410304: Measure request frequency of thumbnail sizes.

I picked a random path that was hit and looked the IP and basically looked at the previous and after requests at the same time but the same IP. I picked a IPv6 to reduce the chance of overlap.

Tue, Nov 25, 11:51 AM · Page-Previews, MediaViewer, Data-Persistence, Thumbor, SRE-swift-storage, Traffic

Mon, Nov 24

Ladsgroup added a comment to T410304: Measure request frequency of thumbnail sizes.
spark-sql (default)> select uri_path, count(*) as hits from wmf.webrequest where webrequest_source='upload' and year=2025 and month=10 and day=24 and hour=10 and http_status='200' and uri_path like '/wikipedia/%/thumb/%' and regexp_extract(uri_path, '([0-9]+)px[^/]+$')='480' AND referer like '%.wikipedia.org%' group by uri_path order by hits desc LIMIT 10;
uri_path	hits
/wikipedia/commons/thumb/e/e4/Status_iucn3.1_LC_ru.svg/480px-Status_iucn3.1_LC_ru.svg.png	2106
/wikipedia/commons/thumb/9/96/Flag_of_the_United_States_%28DDD-F-416E_specifications%29.svg/480px-Flag_of_the_United_States_%28DDD-F-416E_specifications%29.svg.png	1939
/wikipedia/commons/thumb/a/a5/Flag_of_the_United_Kingdom_%281-2%29.svg/480px-Flag_of_the_United_Kingdom_%281-2%29.svg.png	1532
/wikipedia/commons/thumb/f/f3/Flag_of_Russia.svg/480px-Flag_of_Russia.svg.png	1482
/wikipedia/commons/thumb/c/c3/Flag_of_France.svg/480px-Flag_of_France.svg.png	1400
/wikipedia/commons/thumb/e/e2/Flag_of_the_United_States_%28Pantone%29.svg/480px-Flag_of_the_United_States_%28Pantone%29.svg.png	1297
/wikipedia/commons/thumb/f/fa/Flag_of_the_People%27s_Republic_of_China.svg/480px-Flag_of_the_People%27s_Republic_of_China.svg.png	1285
/wikipedia/commons/thumb/b/ba/Flag_of_Germany.svg/480px-Flag_of_Germany.svg.png	1272
/wikipedia/commons/thumb/e/e2/White_House_ballroom_plan%2C_October_2025.svg/480px-White_House_ballroom_plan%2C_October_2025.svg.png	1254
/wikipedia/commons/thumb/a/a9/Flag_of_the_Soviet_Union.svg/480px-Flag_of_the_Soviet_Union.svg.png	1218
Time taken: 36.124 seconds, Fetched 10 row(s)
Mon, Nov 24, 10:55 PM · Page-Previews, MediaViewer, Data-Persistence, Thumbor, SRE-swift-storage, Traffic
Ladsgroup added a comment to T410304: Measure request frequency of thumbnail sizes.

The query was wrong, the like should have an extra % at the end. Let me try again.

Mon, Nov 24, 10:53 PM · Page-Previews, MediaViewer, Data-Persistence, Thumbor, SRE-swift-storage, Traffic
Ladsgroup added a comment to T410304: Measure request frequency of thumbnail sizes.
spark-sql (default)> select uri_path, count(*) as hits from wmf.webrequest where webrequest_source='upload' and year=2025 and month=10 and day=24 and hour=10 and http_status='200' and uri_path like '/wikipedia/%/thumb/%' and regexp_extract(uri_path, '([0-9]+)px[^/]+$')='480' AND referer like '%.wikipedia.org' group by uri_path order by hits desc LIMIT 10;
uri_path	hits
/wikipedia/commons/thumb/7/7e/Map_of_Fukuoka_Prefecture_Ja.svg/480px-Map_of_Fukuoka_Prefecture_Ja.svg.png	1
/wikipedia/commons/thumb/a/a5/Infobox_info_icon2.svg/480px-Infobox_info_icon2.svg.png	1
/wikipedia/commons/thumb/d/d5/Lynx-wikipedia.png/480px-Lynx-wikipedia.png	1
/wikipedia/commons/thumb/8/81/Haiku_R1_Beta_3_desktop_screenshot.png/480px-Haiku_R1_Beta_3_desktop_screenshot.png	1
/wikipedia/commons/thumb/7/75/Small_Pencil_Icon.svg/480px-Small_Pencil_Icon.svg.png	1
/wikipedia/commons/thumb/5/5d/Dooble_Showing_Dutch_Wikipedia.png/480px-Dooble_Showing_Dutch_Wikipedia.png	1
/wikipedia/commons/thumb/e/eb/Emoji_u1f33f.svg/480px-Emoji_u1f33f.svg.png	1
/wikipedia/commons/thumb/f/fc/MEPIS_logo.svg/480px-MEPIS_logo.svg.png	1
/wikipedia/commons/thumb/6/62/W3m-wikipedia.png/480px-W3m-wikipedia.png	1
/wikipedia/commons/thumb/1/10/TDA1%2C_ptc_catalyst.svg/480px-TDA1%2C_ptc_catalyst.svg.png	1
Time taken: 56.367 seconds, Fetched 10 row(s)
spark-sql (default)>
Mon, Nov 24, 10:32 PM · Page-Previews, MediaViewer, Data-Persistence, Thumbor, SRE-swift-storage, Traffic
Ladsgroup closed T297297: Investigate the unusual dbs in s3 as Resolved.
Mon, Nov 24, 3:23 PM · DBA
Ladsgroup updated the task description for T297297: Investigate the unusual dbs in s3.
Mon, Nov 24, 3:23 PM · DBA
Ladsgroup updated the task description for T297297: Investigate the unusual dbs in s3.
Mon, Nov 24, 3:21 PM · DBA
Ladsgroup closed T410692: Drop the WikimediaEditorTasks extension's tables from Wikimedia production, a subtask of T376954: Stop using and then undeploy the WikimediaEditorTasks extension, as Resolved.
Mon, Nov 24, 3:11 PM · Patch-For-Review, Wikimedia-Site-requests, WikimediaEditorTasks, Wikipedia-Android-App-Backlog
Ladsgroup closed T410692: Drop the WikimediaEditorTasks extension's tables from Wikimedia production as Resolved.
Mon, Nov 24, 3:11 PM · DBA, WikimediaEditorTasks, Wikipedia-Android-App-Backlog
Ladsgroup added a comment to T410692: Drop the WikimediaEditorTasks extension's tables from Wikimedia production.

According to the table catalog these tables only exist in wikishared in x1: https://going-merry.toolforge.org/?table=wikimedia_editor_tasks_counts

Mon, Nov 24, 3:06 PM · DBA, WikimediaEditorTasks, Wikipedia-Android-App-Backlog
Ladsgroup added a comment to T410692: Drop the WikimediaEditorTasks extension's tables from Wikimedia production.

The extension is fully undeployed so this can go now.

Mon, Nov 24, 3:05 PM · DBA, WikimediaEditorTasks, Wikipedia-Android-App-Backlog
Ladsgroup updated the task description for T410589: Optimize all core tables, late 2025.
Mon, Nov 24, 3:04 PM · DBA
Ladsgroup closed T410624: Stop pulling netbox-exported-dns repo from Phabricator Diffusion (which mirrors netbox-exports.wikimedia.org) as Resolved.

It'll be live in 24 hours, please reopen if it doesn't.

Mon, Nov 24, 3:00 PM · collaboration-services, VPS-project-Codesearch
Ladsgroup closed T410624: Stop pulling netbox-exported-dns repo from Phabricator Diffusion (which mirrors netbox-exports.wikimedia.org), a subtask of T405596: Disable IO for diffusion repositories, as Resolved.
Mon, Nov 24, 3:00 PM · Release-Engineering-Team (Priority Backlog 📥), Patch-For-Review, collaboration-services, Diffusion, Phabricator
Ladsgroup added a comment to T408663: Unify weights on hosts that are not in vslow/dumps.

Yeah, let's leave it running for the weekend and if all is fine I can start unifying weights across the board. The host with lower weight will have 100.

Mon, Nov 24, 2:35 PM · DBA
Ladsgroup moved T410738: pretrain failing when calling mergeMessageFileList.php from Triage to Done on the DBA board.
Mon, Nov 24, 2:09 PM · DBA, MediaWiki-Maintenance-system
Ladsgroup closed T410738: pretrain failing when calling mergeMessageFileList.php as Resolved.
Mon, Nov 24, 2:09 PM · DBA, MediaWiki-Maintenance-system
Ladsgroup closed T410738: pretrain failing when calling mergeMessageFileList.php, a subtask of T408274: 1.46.0-wmf.4 deployment blockers, as Resolved.
Mon, Nov 24, 2:09 PM · User-brennen, Essential-Work, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
Ladsgroup created P85518 (An Untitled Masterwork).
Mon, Nov 24, 1:53 PM

Sat, Nov 22

Ladsgroup moved T410675: PHPUnit test LoadBalancerTest::testNonZeroMasterLoad is flaky from Triage to Done on the DBA board.
Sat, Nov 22, 12:57 AM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), DBA, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests, MediaWiki-libs-Rdbms
Ladsgroup closed T410675: PHPUnit test LoadBalancerTest::testNonZeroMasterLoad is flaky as Resolved.
Sat, Nov 22, 12:57 AM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), DBA, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests, MediaWiki-libs-Rdbms

Fri, Nov 21

Ladsgroup added a comment to T410675: PHPUnit test LoadBalancerTest::testNonZeroMasterLoad is flaky.

^ This would fix the flaky test if anyone is feeling like a +2

Fri, Nov 21, 11:45 PM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), DBA, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests, MediaWiki-libs-Rdbms
Ladsgroup added a comment to T410675: PHPUnit test LoadBalancerTest::testNonZeroMasterLoad is flaky.

Let me debug this a bit. Very likely caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1205190

Fri, Nov 21, 8:55 PM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), DBA, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests, MediaWiki-libs-Rdbms
Ladsgroup added a comment to T410624: Stop pulling netbox-exported-dns repo from Phabricator Diffusion (which mirrors netbox-exports.wikimedia.org).

(honestly it wouldn't be the end of the world if we just switch indexing it off)

Fri, Nov 21, 8:53 PM · collaboration-services, VPS-project-Codesearch
Ladsgroup added a comment to T410624: Stop pulling netbox-exported-dns repo from Phabricator Diffusion (which mirrors netbox-exports.wikimedia.org).

So I don't have a way to point to the file. Since except the .git file, nothing exists in netbox-exports endpoint:

root@netbox1003:/srv/netbox-exports# ls 
dns.git  netbox-dns  netbox-hiera
Fri, Nov 21, 8:49 PM · collaboration-services, VPS-project-Codesearch
Ladsgroup added a comment to T410738: pretrain failing when calling mergeMessageFileList.php.
["groupLoadsBySection"]=>
array(1) {
  ["DEFAULT"]=>
  array(1) {
    [""]=>
    array(1) {
      ["WMF_MAINTENANCE_OFFLINE_placeholder"]=>
      int(0)
    }
  }
}

o.O

Fri, Nov 21, 8:21 PM · DBA, MediaWiki-Maintenance-system
Ladsgroup added a comment to T410738: pretrain failing when calling mergeMessageFileList.php.

The root cause is very likely this https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1205190. The patch applied on mw-experimental work just fine, locally works fine, beta cluster works fine. It just explodes in production on maint scripts.

Fri, Nov 21, 7:53 PM · DBA, MediaWiki-Maintenance-system
Ladsgroup updated the task description for T410589: Optimize all core tables, late 2025.
Fri, Nov 21, 2:43 PM · DBA
Ladsgroup added a comment to T410304: Measure request frequency of thumbnail sizes.

I haven't found anything in gadgets, etc. https://commons.wikimedia.org/w/index.php?title=Special:Search&limit=500&offset=0&ns8=1&search=%22480px-%22 (same in enwiki, etc.) I found a lot of weird stuff in meta but still all unrelated: https://meta.wikimedia.org/w/index.php?search=%22%2F480px-%22&title=Special%3ASearch&profile=advanced&fulltext=1&ns8=1

Fri, Nov 21, 2:36 PM · Page-Previews, MediaViewer, Data-Persistence, Thumbor, SRE-swift-storage, Traffic
Ladsgroup added a comment to T410738: pretrain failing when calling mergeMessageFileList.php.

This is really really crazy. I've been debugging this in T405087#11388580 and onwards. The error doesn't make any sense.

Fri, Nov 21, 2:31 PM · DBA, MediaWiki-Maintenance-system
Ladsgroup added a comment to T405942: eqiad row C/D Data Persistence host migrations.

https://grafana.wikimedia.org/d/35WSHOjVk/application-servers-red-k8s?orgId=1&from=2025-11-21T13:37:29.200Z&to=2025-11-21T14:28:00.361Z&timezone=utc&var-site=$__all&var-deployment=mw-web&var-method=GET&var-code=200&var-handler=php&var-service=mediawiki&refresh=1m&viewPanel=panel-9

grafik.png (854×1 px, 96 KB)

Fri, Nov 21, 2:28 PM · media-backups, DBA, Data-Persistence, SRE, DC-Ops, ops-eqiad