Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani (WMDE))
Master of introducing new bugsAdministrator

Projects (29)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (249 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Wikidata developer, open source enthusiast, mediawiki volunteer developer
Babel: fa-N, en-4, de-1, tr-1

Recent Activity

Today

Ladsgroup added a comment to T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource.

My hypotheses: After hours of investigating I realized the big reason is that federation (i.e. $wmgUseEntitySourceBasedFederation) is enabled for all of beta cluster while it's only properly configured for commons and that's why the same thing works just fine in beta commons (https://commons.wikimedia.beta.wmflabs.org/wiki/Artturi). (I just realized that we disabled proprety term migration for commons in beta cluster because it practically blew up the whole website) I'm going to make configuration of beta cluster similar to production as other configurations are similar and then check enwiki in beta cluster to see if it's fixed for good or not.

Thu, Jul 18, 6:43 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Ladsgroup added a comment to T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource.

My hypotheses: After hours of investigating I realized the big reason is that federation (i.e. $wmgUseEntitySourceBasedFederation) is enabled for all of beta cluster while it's only properly configured for commons and that's why the same thing works just fine in beta commons (https://commons.wikimedia.beta.wmflabs.org/wiki/Artturi). (I just realized that we disabled proprety term migration for commons in beta cluster because it practically blew up the whole website) I'm going to make configuration of beta cluster similar to production as other configurations are similar and then check enwiki in beta cluster to see if it's fixed for good or not.

Thu, Jul 18, 6:33 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Ladsgroup moved T217243: Add baserevid to WikibaseLexeme API modules from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Jul 18, 2:48 PM · Lexicographical data, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T225070: Add baserevid to wbleditformelements API module from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Jul 18, 1:04 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Lexicographical data, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T228080: Adding a second gloss results in an error from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Jul 18, 1:04 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata
Ladsgroup updated the task description for T191231: RFC: Abstract schemas and schema changes.
Thu, Jul 18, 12:57 PM · MediaWiki-Installer, Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, Epic
Ladsgroup moved T228271: Lexeme: use vue2 ResourceLoader module from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Jul 18, 10:55 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Lexicographical data, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup created T228402: Reduce the number of ResourceLoader modules that WikibaseRepo registers.
Thu, Jul 18, 10:34 AM · Wikidata-Trailblazing-Exploration, Wikidata, Performance
Ladsgroup added a comment to T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource.

that's the callstack of that same error right?

Thu, Jul 18, 10:27 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Ladsgroup added a comment to T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource.

I found this error if that's any of help:

#0 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1573): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1162): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1801): Wikimedia\Rdbms\Database->query(string, string)
#3 /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/Store/Sql/Terms/PrefetchingPropertyTermLookup.php(90): Wikimedia\Rdbms\Database->select(string, array, array, string)
#4 /srv/mediawiki/php-master/extensions/Wikibase/data-access/src/ByTypeDispatchingPrefetchingTermLookup.php(53): Wikibase\Lib\Store\Sql\Terms\PrefetchingPropertyTermLookup->prefetchTerms(array, array, array)
#5 /srv/mediawiki/php-master/extensions/Wikibase/data-access/src/ByTypeDispatchingPrefetchingTermLookup.php(53): Wikibase\DataAccess\ByTypeDispatchingPrefetchingTermLookup->prefetchTerms(array, array, array)
#6 /srv/mediawiki/php-master/extensions/Wikibase/data-access/src/ByTypeDispatchingPrefetchingTermLookup.php(89): Wikibase\DataAccess\ByTypeDispatchingPrefetchingTermLookup->prefetchTerms(array, array, array)
#7 /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/Store/EntityTermLookupBase.php(52): Wikibase\DataAccess\ByTypeDispatchingPrefetchingTermLookup->getTermsOfType(Wikibase\DataModel\Entity\PropertyId, string, array)
#8 /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/Store/LanguageFallbackLabelDescriptionLookup.php(47): Wikibase\Lib\Store\EntityTermLookupBase->getLabels(Wikibase\DataModel\Entity\PropertyId, array)
#9 /srv/mediawiki/php-master/extensions/Wikibase/client/includes/Usage/UsageTrackingLanguageFallbackLabelDescriptionLookup.php(72): Wikibase\Lib\Store\LanguageFallbackLabelDescriptionLookup->getLabel(Wikibase\DataModel\Entity\PropertyId)
#10 /srv/mediawiki/php-master/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageDependentLuaBindings.php(60): Wikibase\Client\Usage\UsageTrackingLanguageFallbackLabelDescriptionLookup->getLabel(Wikibase\DataModel\Entity\PropertyId)
#11 /srv/mediawiki/php-master/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php(586): Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageDependentLuaBindings->getLabel(string)
#12 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaSandbox/Engine.php(391): Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseLibrary->getLabel(string)
#13 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#14 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaSandbox/Engine.php(314): LuaSandboxFunction->call(LuaSandboxFunction)
#15 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaCommon/LuaCommon.php(296): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#16 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaCommon/LuaCommon.php(983): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#17 /srv/mediawiki/php-master/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#18 /srv/mediawiki/php-master/includes/parser/Parser.php(3594): ScribuntoHooks::invokeHook(Parser, PPFrame_Hash, array)
#19 /srv/mediawiki/php-master/includes/parser/Parser.php(3301): Parser->callParserFunction(PPFrame_Hash, string, array)
#20 /srv/mediawiki/php-master/includes/parser/PPFrame_Hash.php(254): Parser->braceSubstitution(array, PPFrame_Hash)
#21 /srv/mediawiki/php-master/includes/parser/Parser.php(3115): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#22 /srv/mediawiki/php-master/includes/parser/Parser.php(1424): Parser->replaceVariables(string)
#23 /srv/mediawiki/php-master/includes/parser/Parser.php(555): Parser->internalParse(string)
#24 /srv/mediawiki/php-master/includes/content/WikitextContent.php(365): Parser->parse(string, Title, ParserOptions, boolean, boolean, NULL)
#25 /srv/mediawiki/php-master/includes/content/AbstractContent.php(555): WikitextContent->fillParserOutput(Title, NULL, ParserOptions, boolean, ParserOutput)
#26 /srv/mediawiki/php-master/includes/Revision/RenderedRevision.php(266): AbstractContent->getParserOutput(Title, NULL, ParserOptions, boolean)
#27 /srv/mediawiki/php-master/includes/Revision/RenderedRevision.php(234): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#28 /srv/mediawiki/php-master/includes/Revision/RevisionRenderer.php(199): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#29 /srv/mediawiki/php-master/includes/Revision/RevisionRenderer.php(148): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#30 [internal function]: Closure$MediaWiki\Revision\RevisionRenderer::getRenderedRevision#2(MediaWiki\Revision\RenderedRevision, array)
#31 /srv/mediawiki/php-master/includes/Revision/RenderedRevision.php(197): call_user_func(Closure$MediaWiki\Revision\RevisionRenderer::getRenderedRevision#2;8004, MediaWiki\Revision\RenderedRevision, array)
#32 /srv/mediawiki/php-master/includes/Storage/DerivedPageDataUpdater.php(1289): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#33 [internal function]: MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#34 /srv/mediawiki/php-master/includes/edit/PreparedEdit.php(104): call_user_func(array)
#35 /srv/mediawiki/php-master/includes/edit/PreparedEdit.php(119): MediaWiki\Edit\PreparedEdit->getOutput()
#36 /srv/mediawiki/php-master/includes/Storage/DerivedPageDataUpdater.php(1267): MediaWiki\Edit\PreparedEdit->__get(string)
#37 /srv/mediawiki/php-master/includes/page/WikiPage.php(2019): MediaWiki\Storage\DerivedPageDataUpdater->getPreparedEdit()
#38 /srv/mediawiki/php-master/extensions/SpamBlacklist/includes/SpamBlacklistHooks.php(31): WikiPage->prepareContentForEdit(WikitextContent)
#39 /srv/mediawiki/php-master/includes/Hooks.php(174): SpamBlacklistHooks::filterMergedContent(DerivativeContext, WikitextContent, Status, string, User, boolean)
#40 /srv/mediawiki/php-master/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#41 /srv/mediawiki/php-master/includes/EditPage.php(1766): Hooks::run(string, array)
#42 /srv/mediawiki/php-master/includes/EditPage.php(2221): EditPage->runPostMergeFilters(WikitextContent, Status, User)
#43 /srv/mediawiki/php-master/includes/EditPage.php(1596): EditPage->internalAttemptSave(NULL, boolean)
#44 /srv/mediawiki/php-master/includes/api/ApiEditPage.php(378): EditPage->attemptSave(NULL)
#45 /srv/mediawiki/php-master/includes/api/ApiMain.php(1583): ApiEditPage->execute()
#46 /srv/mediawiki/php-master/includes/api/ApiMain.php(500): ApiMain->executeAction()
#47 /srv/mediawiki/php-master/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(74): ApiMain->execute()
#48 /srv/mediawiki/php-master/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(400): ApiVisualEditorEdit->saveWikitext(Title, string, array)
#49 /srv/mediawiki/php-master/includes/api/ApiMain.php(1583): ApiVisualEditorEdit->execute()
#50 /srv/mediawiki/php-master/includes/api/ApiMain.php(531): ApiMain->executeAction()
#51 /srv/mediawiki/php-master/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#52 /srv/mediawiki/php-master/api.php(86): ApiMain->execute()
#53 /srv/mediawiki/w/api.php(3): include(string)
#54 {main}
Thu, Jul 18, 9:59 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Ladsgroup moved T217770: Never show anything from a language that is not currently Wikidata conform from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Jul 18, 9:27 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review

Yesterday

Ladsgroup created P8770 Mergeable RL modules.
Wed, Jul 17, 10:32 PM
Ladsgroup moved T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Tested, still explodes on beta cluster (To reproduce, edit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Italic_title&veaction=editsource&action=edit and add {{#invoke:Wikidata test|hello}} and then try to save)

Wed, Jul 17, 10:30 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Ladsgroup moved T214884: linking Schemas in statements from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Jul 17, 6:01 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Shape Expressions
Ladsgroup claimed T214884: linking Schemas in statements.
Wed, Jul 17, 6:00 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Shape Expressions
Ladsgroup added a comment to T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource.

I still get error in beta cluster:

A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
Query: SELECT  wbpt_property_id,wbpt_term_in_lang_id  FROM `wbt_property_terms`    WHERE wbpt_property_id = '694'  
Function: Wikibase\Lib\Store\Sql\Terms\PrefetchingPropertyTermLookup::prefetchTerms
Error: 1146 Table 'enwiki.wbt_property_terms' doesn't exist (172.16.4.147:3306)
Wed, Jul 17, 3:30 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Ladsgroup moved T191231: RFC: Abstract schemas and schema changes from Request IRC meeting to Inbox on the TechCom-RFC board.

I updated the description per the discussion in the TechCom IRC meeting and we agreed to move this to last call.

Wed, Jul 17, 2:28 PM · MediaWiki-Installer, Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, Epic
Ladsgroup updated the task description for T191231: RFC: Abstract schemas and schema changes.
Wed, Jul 17, 2:27 PM · MediaWiki-Installer, Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, Epic
Ladsgroup moved T224129: Track number of external identifiers on Wikidata over time from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Can you test again?

Wed, Jul 17, 10:50 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), WMDE-Analytics-Engineering, Wikidata
Ladsgroup added a comment to T224129: Track number of external identifiers on Wikidata over time.
Wed, Jul 17, 10:47 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), WMDE-Analytics-Engineering, Wikidata
Ladsgroup added a comment to T227577: MediaWiki and Wikidata/Wikibase/structured data APIs workshops at the Wikimania Hackathon.

Hello folks! This workshop topic sounds exciting. I had plans of developing a toolkit and running a workshop around MediaWiki Action API: T225772 similar to T225771#5339609. Originally this was about Action API only. But recently I am interested in focusing on all Wikimedia APIs that might be helpful for technical contributors (particularly of small wikis).
Would there be any interest in collaborating on this topic both developing and running a workshop around Wikimedia APIs?

Wed, Jul 17, 10:40 AM · StructuredDataOnCommons, Wikimania-Hackathon-2019
Ladsgroup added a comment to T217770: Never show anything from a language that is not currently Wikidata conform.

It isn't clear how ULS redirect language patch is related here. Can we add more elaborate commit message and/or a comment here. I also believe that that patch alone won't be enough, right? and it is just necessary for the later work for this task?

Wed, Jul 17, 9:49 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review
Ladsgroup awarded T228247: +2 nomination for Daimona in mediawiki/* a Like token.
Wed, Jul 17, 9:22 AM · MediaWiki-Gerrit-Group-Requests

Tue, Jul 16

Ladsgroup awarded Blog Post: Changes and improvements to PHPUnit testing in MediaWiki a Party Time token.
Tue, Jul 16, 8:52 PM · MediaWiki-Core-Testing, Test-Coverage, Code-Health
Ladsgroup updated subscribers of T228196: docker-registry: some layers has been corrupted due to deleting other swift containers.
Tue, Jul 16, 7:51 PM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Operations, Wikimedia-Incident, serviceops
Ladsgroup moved T220826: Wikibase Special:EntityData has 2 parameters that do the same thing from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Jul 16, 6:48 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Patch-For-Review, wikidata-tech-focus, Wikidata
Ladsgroup claimed T220826: Wikibase Special:EntityData has 2 parameters that do the same thing.
Tue, Jul 16, 6:48 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Patch-For-Review, wikidata-tech-focus, Wikidata
Ladsgroup claimed T85499: wbEntity shouldn't be served on every page load.
Tue, Jul 16, 6:17 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Performance, MediaWiki-extensions-WikibaseRepository
Ladsgroup moved T85499: wbEntity shouldn't be served on every page load from Ready to pick up to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Tue, Jul 16, 6:17 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Performance, MediaWiki-extensions-WikibaseRepository
Ladsgroup claimed T228080: Adding a second gloss results in an error .
Tue, Jul 16, 5:38 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata
Ladsgroup changed the subtype of T228194: Every Wikidata edit gets displayed in watchlist despite ‘Expand watchlist to show all settings’ not set from "Task" to "Bug Report".
Tue, Jul 16, 5:22 PM · Wikidata-Campsite, Regression, MediaWiki-extensions-WikibaseClient, Wikidata
Ladsgroup added projects to T228194: Every Wikidata edit gets displayed in watchlist despite ‘Expand watchlist to show all settings’ not set: Regression, Wikidata-Campsite.
Tue, Jul 16, 5:21 PM · Wikidata-Campsite, Regression, MediaWiki-extensions-WikibaseClient, Wikidata
Ladsgroup closed T228074: Drop deprecated wikibase.RepoApi{,Error} as Resolved.

All notified

Tue, Jul 16, 3:34 PM · User-Ladsgroup, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, Wikidata
Ladsgroup added a comment to T223552: external ID linking issue on Factgrid.

@Ladsgroup I'm in Edinburgh for the rest of the week (conference marathon https://www.bsecs.org.uk/isecs/en/programme/)
Can we talk about this - on the phone perhaps, later next week?

Tue, Jul 16, 3:26 PM · FactGrid, Wikidata, Wikidata-Campsite
Ladsgroup added a comment to Blog Post: Changes and improvements to PHPUnit testing in MediaWiki.

Could you give an example, in the current files, which is the unit test and which is the integration test? :)

Tue, Jul 16, 3:24 PM · MediaWiki-Core-Testing, Test-Coverage, Code-Health
Ladsgroup added a comment to T50047: client watchlist shows more than just the last change on the item.

Will anything be done to this? Watchlisting any big item (such as ones for any country) completely breaks my watchlist with multitudes of edits to the same articles, why is this completely neglected? This is a default configuration, not some option, why is no one working on the fix?

Tue, Jul 16, 2:27 PM · Wikidata-Campsite, Wikidata-Sprint-2015-11-17, Wikidata, MediaWiki-extensions-WikibaseClient
Ladsgroup moved T225070: Add baserevid to wbleditformelements API module from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Jul 16, 2:19 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Lexicographical data, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to Blog Post: Changes and improvements to PHPUnit testing in MediaWiki.

Emm, I am confused about the two types of tests, integration and unit. I don't really understand the difference between the two test types. This looks like the test directory structure (Unit and Feature) of the Laravel.

Tue, Jul 16, 1:26 PM · MediaWiki-Core-Testing, Test-Coverage, Code-Health
Ladsgroup added a comment to T228074: Drop deprecated wikibase.RepoApi{,Error}.

It probably need an announcement.

Strictly speaking it doesn’t, because Wikibase JavaScript code is explicitly not a stable interface according to the Stable Interface Policy. If you’ve already done the investigation, I guess it makes sense to notify those users, but on the other hand I’m not sure if it’s a good idea to treat the JavaScript code as if it’s more-or-less stable…

Tue, Jul 16, 1:07 PM · User-Ladsgroup, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, Wikidata
Ladsgroup claimed T217245: [Story] Call WikibaseLexeme API with baserevid parameter from the UI.
Tue, Jul 16, 11:30 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T219301: Run migration of property terms from To Do to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Waiting on T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource (Cleaning up To-Do column)

Tue, Jul 16, 11:29 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup moved T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW from To Do to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Waiting on T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource (Cleaning up To-Do column)

Tue, Jul 16, 11:28 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup added a comment to T228080: Adding a second gloss results in an error .

It's the same issue as T225070#5334629 We probably fix both in one go.

Tue, Jul 16, 10:59 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata
Ladsgroup moved T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers from Incoming to Ready to estimate on the Wikidata-Campsite board.
Tue, Jul 16, 10:54 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, Patch-For-Review, Performance-Team (Radar), Wikidata
Ladsgroup updated the task description for T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers.
Tue, Jul 16, 10:54 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, Patch-For-Review, Performance-Team (Radar), Wikidata
Ladsgroup moved T226818: Diff when updating wbc_entity_usage from Needs Work to Ready to estimate on the Wikidata-Campsite board.
Tue, Jul 16, 10:48 AM · Wikidata-Campsite, wikidata-tech-focus, User-Addshore, MediaWiki-extensions-WikibaseClient, Wikidata
Ladsgroup updated the task description for T226818: Diff when updating wbc_entity_usage.
Tue, Jul 16, 10:48 AM · Wikidata-Campsite, wikidata-tech-focus, User-Addshore, MediaWiki-extensions-WikibaseClient, Wikidata
Ladsgroup moved T85499: wbEntity shouldn't be served on every page load from Incoming to Ready to estimate on the Wikidata-Campsite board.
Tue, Jul 16, 10:41 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Performance, MediaWiki-extensions-WikibaseRepository
Ladsgroup updated the task description for T85499: wbEntity shouldn't be served on every page load.
Tue, Jul 16, 10:41 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Performance, MediaWiki-extensions-WikibaseRepository
Ladsgroup updated the task description for T85499: wbEntity shouldn't be served on every page load.
Tue, Jul 16, 10:41 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Performance, MediaWiki-extensions-WikibaseRepository
Ladsgroup added a subtask for T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers: T226976: Convert linkitem module to use OOUI, instead of jQuery UI.
Tue, Jul 16, 9:45 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, Patch-For-Review, Performance-Team (Radar), Wikidata
Ladsgroup added a parent task for T226976: Convert linkitem module to use OOUI, instead of jQuery UI: T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers.
Tue, Jul 16, 9:45 AM · Wikidata-Campsite, Wikidata, MediaWiki-extensions-WikibaseClient, UI-Standardization
Ladsgroup updated subscribers of T48643: [Story] Dispatching via delayed jobs (instead of cron script).

I sorta copy what I said in T193733#5276659 on reasons

  • It's a SPOF, if mwmaint1002 node goes down for HW issues, we can't dispatch at all. If there's a need to restart the node, dispatching has to stop until it's done.
  • "Noisy neighbor" effect, people run maintenance scripts in the mwmaint node, it can be choked to death by other scripts and it can make running maintenance scripts impossible by having bugs that eats all of the resources.
  • The distributed system we designed for this (pulling the wikis using three cronjobs, dispatching and picking up basically random + most stalled ones). This can use the great infrastructure for jobqueues we have.
  • Cronjobs are hard to debug, moving them to jobqueue makes it easier to debug in logstash.
Tue, Jul 16, 8:24 AM · Wikidata-Trailblazing-Exploration, Story, Wikidata, MediaWiki-extensions-WikibaseRepository
Ladsgroup added a comment to T223552: external ID linking issue on Factgrid.

@Olaf_Simons Hello, We have tried this on our side and in several places and we still couldn't reproduce the issue. Please make sure you run the maintenance script. Is there anyone who can run this? @Lucas_Werkmeister_WMDE maybe?

Tue, Jul 16, 8:15 AM · FactGrid, Wikidata, Wikidata-Campsite
Ladsgroup merged task T227786: broken reference dashboard into T214894: Grafana Datamodel References dashboard broken (daily data).
Tue, Jul 16, 7:59 AM · Wikidata, Wikidata-Campsite
Ladsgroup merged T227786: broken reference dashboard into T214894: Grafana Datamodel References dashboard broken (daily data).
Tue, Jul 16, 7:59 AM · Wikidata, Wikidata-Campsite, WMDE-Analytics-Engineering
Ladsgroup moved T226601: Wikidata JSON dump generation broken from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Jul 16, 7:56 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Dumps-Generation, Wikidata
Ladsgroup moved T226639: DBError on Wikibase term store from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Jul 16, 7:56 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Wikidata

Mon, Jul 15

Ladsgroup added a comment to T222224: Normalize MediaWiki link tables.

As for the need, more compact tables are certainly desirable, but how much of the problem is the current situation, really? Is there a pressing need to fox this now, do we expect this to become a problem within a year, two years? What drives this? Is the need the same for all the tables on all the projects? How do they related to each other? Perhaps @Marostegui or @jcrespo have answers top that.

Mon, Jul 15, 10:22 PM · MediaWiki-Page-derived-data, Schema-change, Patch-For-Review, TechCom-RFC
Ladsgroup updated subscribers of T225070: Add baserevid to wbleditformelements API module.

cc @Lydia_Pintscher ^

Mon, Jul 15, 8:22 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Lexicographical data, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T225070: Add baserevid to wbleditformelements API module.

So we have an issue here. Browser tests fail because they add a form and then immediately try to edit it. The baserevid sent doesn't contain any form so the system can't apply the form change op (or build it) and definitely can't do a proper patching or diffing or anything whatsoever.

Mon, Jul 15, 7:53 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Lexicographical data, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T224844: Show number of senses and forms on page information for WikibaseLexeme entities from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Jul 15, 6:02 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata
Ladsgroup claimed T224844: Show number of senses and forms on page information for WikibaseLexeme entities.
Mon, Jul 15, 6:02 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata
Ladsgroup updated the task description for T228074: Drop deprecated wikibase.RepoApi{,Error}.
Mon, Jul 15, 4:22 PM · User-Ladsgroup, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, Wikidata
Ladsgroup created T228074: Drop deprecated wikibase.RepoApi{,Error}.
Mon, Jul 15, 4:20 PM · User-Ladsgroup, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, Wikidata
Ladsgroup moved T226499: Check functionality and documenation of formatter URL property configuration from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Jul 15, 4:04 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), FactGrid, Wikidata
Ladsgroup added a comment to T226499: Check functionality and documenation of formatter URL property configuration.

I tested it and it works fine, the only weird part is that if you set your property to be data type of "external-identifier" the formatter won't work, you have to put it as "string":


The documentation says exactly this too but maybe we need to support that.

Mon, Jul 15, 4:01 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), FactGrid, Wikidata
Ladsgroup added a comment to T226499: Check functionality and documenation of formatter URL property configuration.

I tested it and it works fine, the only weird part is that if you set your property to be data type of "external-identifier" the formatter won't work, you have to put it as "string":

Mon, Jul 15, 3:49 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), FactGrid, Wikidata
Ladsgroup added a comment to T217770: Never show anything from a language that is not currently Wikidata conform.

I would rather fix ULS, this patch fixes ULS.

Mon, Jul 15, 2:16 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review
Ladsgroup closed T227579: Fix browser tests conflicting with each other, a subtask of T225070: Add baserevid to wbleditformelements API module, as Invalid.
Mon, Jul 15, 1:23 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Lexicographical data, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup closed T227579: Fix browser tests conflicting with each other as Invalid.
Mon, Jul 15, 1:23 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup committed rADES405b3b965c18: Use config for wdqs host name (authored by Ladsgroup).
Use config for wdqs host name
Mon, Jul 15, 10:47 AM
Ladsgroup created P8745 (An Untitled Masterwork).
Mon, Jul 15, 10:35 AM
Ladsgroup added a project to T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers: Wikidata-Campsite.
Mon, Jul 15, 8:33 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, Patch-For-Review, Performance-Team (Radar), Wikidata
Ladsgroup added a comment to T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers.

Except the wikibase-api, the rest actually are not needed and can be replaced by some other functionality or by T226976: Convert linkitem module to use OOUI, instead of jQuery UI

Mon, Jul 15, 12:08 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, Patch-For-Review, Performance-Team (Radar), Wikidata

Sun, Jul 14

Ladsgroup added a comment to T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers.

Actually the underlying problem here is that we load WikibaseView, the frontend designed to show entities on Wikidata on clients, this should not happen. Client and lib depend only on eight modules of view, I move them to lib and we will be done with this.

Sun, Jul 14, 11:08 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, Patch-For-Review, Performance-Team (Radar), Wikidata

Sat, Jul 13

Ladsgroup changed the status of T85499: wbEntity shouldn't be served on every page load, a subtask of T56098: [Epic][UI] Front-end performance: Improve loading time of items, from Stalled to Open.
Sat, Jul 13, 5:14 PM · Epic, Wikidata, Performance, MediaWiki-extensions-WikibaseRepository
Ladsgroup changed the status of T85499: wbEntity shouldn't be served on every page load from Stalled to Open.

wbEntity is not being used in large-scale anymore:

ladsgroup@mwmaint1002:~$ mwgrep "'wbEntity'"
urwiki              MediaWiki:Gadget-Preview.js
Sat, Jul 13, 5:14 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Performance, MediaWiki-extensions-WikibaseRepository
Ladsgroup awarded T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers a Like token.
Sat, Jul 13, 3:44 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, Patch-For-Review, Performance-Team (Radar), Wikidata
Ladsgroup awarded T202154: Audit modules 2018: Reduce registry overhead a Like token.
Sat, Jul 13, 3:35 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team

Fri, Jul 12

Ladsgroup added a comment to T194737: Improve features for wikibase vandalism detection model.

I don't know how much work this is.
@Lydia_Pintscher should this still be on the campsite?
Is this ready to be done?

Fri, Jul 12, 8:37 PM · Wikidata-Campsite, Wikidata, Scoring-platform-team, artificial-intelligence, editquality-modeling
Ladsgroup merged T227787: broken statements dashboard into T218710: Wikidata grafana dashboard for number of instances of various things is broken.
Fri, Jul 12, 8:32 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, WMDE-Analytics-Engineering
Ladsgroup merged task T227787: broken statements dashboard into T218710: Wikidata grafana dashboard for number of instances of various things is broken.
Fri, Jul 12, 8:32 PM · Wikidata-Campsite, Wikidata
Ladsgroup moved T224129: Track number of external identifiers on Wikidata over time from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Jul 12, 8:25 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), WMDE-Analytics-Engineering, Wikidata
Ladsgroup moved T224842: Show number of statements and external identifiers on page information for Wikibase entities from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Jul 12, 8:25 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup updated subscribers of T227847: Backfill terms index.

@matthiasmullie Let me stop you right there, populating wb_terms on commons was intentionally stopped (cc. @jcrespo) (and it should be a clean table) because it's pretty inefficient and it makes the storage in commons tables even more scarce. This table is being replaced by set of a new tables (which is also populateable(!) by rebuildTermIndex.php) that are normalized and ten times (really) smaller. we are at point of read_old/write_both on properties and will go to read_new/write_both soon. Then we will start the work on items which might take months. When designing new system, I pushed to add support of mediainfo in the new system too but I don't think that passed through. @alaa_wmde knows better.

Fri, Jul 12, 8:22 PM · SDC Engineering, Multimedia, SDC General
Ladsgroup moved T227788: broken site stats dashboard from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Jul 12, 8:07 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T227788: broken site stats dashboard.
Fri, Jul 12, 8:07 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T224129: Track number of external identifiers on Wikidata over time.
Fri, Jul 12, 7:00 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), WMDE-Analytics-Engineering, Wikidata
Ladsgroup claimed T224842: Show number of statements and external identifiers on page information for Wikibase entities.
Fri, Jul 12, 4:43 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup awarded T167246: Refactor "user" & "user_text" fields into "actor" reference table a Love token.
Fri, Jul 12, 4:19 PM · Schema-change, MediaWiki-General, Core Platform Team (Revision Storage Schema Improvements), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Epic
Ladsgroup moved T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

both fail in CI

Fri, Jul 12, 3:24 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Ladsgroup updated the task description for T226818: Diff when updating wbc_entity_usage.
Fri, Jul 12, 1:50 PM · Wikidata-Campsite, wikidata-tech-focus, User-Addshore, MediaWiki-extensions-WikibaseClient, Wikidata
Ladsgroup moved T227504: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Jul 12, 1:41 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Multimedia, Commons, Wikidata, Lexicographical data
Ladsgroup edited projects for T227504: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
Fri, Jul 12, 1:40 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Multimedia, Commons, Wikidata, Lexicographical data
Ladsgroup added a comment to T227504: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons.

The fix was actually very easy.

Fri, Jul 12, 1:40 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Multimedia, Commons, Wikidata, Lexicographical data
Ladsgroup closed T226639: DBError on Wikibase term store as Resolved.

After the deployment to production, this doesn't happen anymore (the highlighted time is the rough time of the deployment)

Fri, Jul 12, 11:08 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Wikidata

Thu, Jul 11

Ladsgroup added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

Thanks @hoo. What's the best way to test this?

Thu, Jul 11, 11:55 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Anti-Harassment, MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup added a comment to T224861: Special:UrlShortener should have a "help" link.

T227833: Everything fails with unable to load the docker file

Thu, Jul 11, 11:34 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), User-DannyS712, MediaWiki-extensions-UrlShortener
Ladsgroup triaged T227833: Everything fails with unable to load the docker file as Unbreak Now! priority.
Thu, Jul 11, 11:33 PM · Operations, Wikimedia-production-error (Shared Build Failure)