Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani (WMDE))
Shah of BugsAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (321 w, 1 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Wikidata software engineer, open source enthusiast, mediawiki volunteer developer, long-term Wikipedian
Babel: fa-N, en-4, de-2, tr-1, hu-1

Recent Activity

Today

Ladsgroup added a comment to T263437: Allow easier ICU transitions in MediaWiki (change how sortkey collation is managed in the categorylinks table).

It might sound like a promotion but I think before getting this done (in any way, duplicating the table, dynamic schema change on the fly, etc.), categorylinks should be normalized first (T222224: RFC: Normalize MediaWiki link tables). This table is 200GB in commons (and pretty big in other large wiki) and duplicating it (and updating both in real time) is going to be pretty costly if they are not normalized. This can be just normalizing the title+ns or also other columns of categorylinks too. The current update is done now (Am I wrong?) and I hope the next one is a little bit far in the future.

Tue, Dec 1, 4:08 PM · Platform Engineering Roadmap Decision Making, MediaWiki-General, Operations
Ladsgroup added a comment to T267327: Run latest Thumbor on Docker with Buster + Python 3.

oh it's not stateful but I think it's high I/O compared to other applications (maybe not as high as jitsi but higher than other apps in k8s). let's do benchmark and see.

Tue, Dec 1, 2:28 PM · Operations, User-jijiki, serviceops, Performance-Team
Ladsgroup added a comment to T267327: Run latest Thumbor on Docker with Buster + Python 3.

My 2c. From what I learned from docker books and such, containers and k8s are not recommended for two types of applications: 1- stateful applications (given the ephemeral nature of containers) or 2- High I/O applications (given that it introduce its own network). I use docker for jitsi (the video calling application) and I regret it, it's terrible. I think thumbor might see a performance degradation due to this.

Tue, Dec 1, 12:55 PM · Operations, User-jijiki, serviceops, Performance-Team
Ladsgroup moved T268988: Dropdown always reset to matching when click on Run Query from Done to Test (Verification) on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Tue, Dec 1, 10:52 AM · Wikidata Query Builder (Wikidata Query Builder - sprint 5)
Ladsgroup moved T268988: Dropdown always reset to matching when click on Run Query from Peer Review to Done on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Tue, Dec 1, 10:52 AM · Wikidata Query Builder (Wikidata Query Builder - sprint 5)
Ladsgroup added a comment to T254536: CacheAwarePropertyInfoStore performs 4000 Memc ops/s (APC not working?).

So when it was changed, it was one hour only: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/changes/66/602666/4/client/config/WikibaseClient.default.php#83

Tue, Dec 1, 8:41 AM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Sustainability (Incident Followup), Wikidata

Yesterday

Ladsgroup moved T265243: get initial metrics from Ready to pick up to Wikidata Query Builder - sprint 5 on the Wikidata Query Builder board.
Mon, Nov 30, 7:16 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup moved T268443: Create list of allowed datatypes from Peer Review to Done on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Mon, Nov 30, 7:15 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup added a comment to T266960: investigate sharing of query builder queries via URL [timebox: 4h].

Thanks for this. Quick question, is there an easy way to store/retrieve Vue state in URL? Like a library that serialize and unserialize it. That would simplify the work a lot.

Mon, Nov 30, 6:38 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup moved T268988: Dropdown always reset to matching when click on Run Query from To Do to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Mon, Nov 30, 6:32 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5)
Ladsgroup moved T268639: Investigate how to track the number of queries that return a result vs an error over time from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.

So you can get some data out of hadoop. Such query works:

SELECT
  *
FROM
  wmf.webrequest
WHERE
  year = 2020
  AND month = 11
  AND day = 27
  AND referer like 'https://query-builder-test.toolforge.org%'
  AND uri_host = "query.wikidata.org" LIMIT 50;
Mon, Nov 30, 5:23 PM · User-Ladsgroup, Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup moved T268639: Investigate how to track the number of queries that return a result vs an error over time from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Mon, Nov 30, 2:05 PM · User-Ladsgroup, Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup claimed T268639: Investigate how to track the number of queries that return a result vs an error over time.
Mon, Nov 30, 1:58 PM · User-Ladsgroup, Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup moved T268638: Create Grafana boards for metrics from To Do to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Mon, Nov 30, 1:57 PM · User-Ladsgroup, Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup claimed T268638: Create Grafana boards for metrics.

https://grafana-rw.wikimedia.org/d/RA1j2T0Mk/wikidata-query-builder?orgId=1

Mon, Nov 30, 1:57 PM · User-Ladsgroup, Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup added a comment to T268948: Add editprotected permission for interface-admin.

It sounds slightly weird to me, IMO being admin should be a prerequisite to being interface-admin and a wiki should not give that right so easily that non-admins can get it... I think it defies the whole point of having interface-admin in the first place (which we had to do because of attacks carried out on admins)

Mon, Nov 30, 3:00 AM · MediaWiki-General

Sun, Nov 29

Ladsgroup added a comment to T200319: Migrate Pybal to Python 3.

Is the bgp part of pybal actively used? It has an obvious import cycle. attributes.py imports bgp.py and bgp.py imports attributes.py, when it gets to run those tests, it fails really bad.

Sun, Nov 29, 11:21 AM · User-Ladsgroup, Patch-For-Review, Python3-Porting, Pybal
Ladsgroup added a comment to T200319: Migrate Pybal to Python 3.

So far I played with it a little:

Sun, Nov 29, 8:33 AM · User-Ladsgroup, Patch-For-Review, Python3-Porting, Pybal
Ladsgroup claimed T200319: Migrate Pybal to Python 3.
Sun, Nov 29, 1:51 AM · User-Ladsgroup, Patch-For-Review, Python3-Porting, Pybal

Sat, Nov 28

Ladsgroup removed projects from T267296: Javascript errors: Unable to add datalayers to map: Operations, Traffic.

This is not related to Traffic. If I'm missing something obvious, please re-add it.

Sat, Nov 28, 9:32 AM · Maps, Regression, Product-Infrastructure-Team-Backlog, JavaScript
Ladsgroup added a comment to T119173: RFC: Discourage use of MySQL's ENUM type.

Is the documentation merging / overhaul tracked anywhere (in a task, perhaps)? Seems like a good opportunity to ask :)

Sat, Nov 28, 5:00 AM · Data-Persistence-Consultation, Performance-Team (Radar), TechCom-RFC, MediaWiki-General

Fri, Nov 27

Ladsgroup moved T267671: Make the Query Builder configurable at build time from Peer Review to Done on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Fri, Nov 27, 12:42 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup moved T266698: Add jest-axe to query builder CI from Done to Test (Verification) on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Fri, Nov 27, 12:42 PM · User-Ladsgroup, Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata, Accessibility
Ladsgroup moved T268447: Implement the QB logic from Peer Review to Done on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Fri, Nov 27, 12:41 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), User-Ladsgroup, Wikidata
Ladsgroup moved T266698: Add jest-axe to query builder CI from Peer Review to Done on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Fri, Nov 27, 10:53 AM · User-Ladsgroup, Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata, Accessibility
Ladsgroup moved T267733: Investigate how do we handle RTL languages in the components -- 8h max from ❌ Blocked to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.

Looks okay to me so far: https://query-builder-test.toolforge.org/?uselang=fa

Fri, Nov 27, 9:13 AM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), User-Ladsgroup, Wikidata
Ladsgroup added a comment to T266698: Add jest-axe to query builder CI.

https://github.com/wmde/query-builder/pull/33

Fri, Nov 27, 9:11 AM · User-Ladsgroup, Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata, Accessibility
Ladsgroup claimed T266698: Add jest-axe to query builder CI.
Fri, Nov 27, 9:10 AM · User-Ladsgroup, Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata, Accessibility

Thu, Nov 26

Ladsgroup moved T268635: Track local metrics in QueryBuilder from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.

https://github.com/wmde/query-builder/pull/81

Thu, Nov 26, 9:27 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), User-Ladsgroup, Wikidata
Ladsgroup added a comment to T119173: RFC: Discourage use of MySQL's ENUM type.

Funnily enough those two are highly outdated and needs to change to reflect the abstract schema and schema changes RFC. We also have https://www.mediawiki.org/wiki/Manual:Schema_changes. Our database documentation needs an overhaul in general (with the json schema, we can also generate those automatically)

Thu, Nov 26, 2:36 PM · Data-Persistence-Consultation, Performance-Team (Radar), TechCom-RFC, MediaWiki-General
Ladsgroup closed T257537: Configure HTTPS for pywikibot.org as Resolved.

Cool :D

Thu, Nov 26, 10:37 AM · User-Ladsgroup, HTTPS, Operations, Pywikibot, Traffic
Ladsgroup closed T268198: Reduce user impact of codesearch's nightly restarts as Resolved.

I call it done, reopen if it's still annoying.

Thu, Nov 26, 9:22 AM · Patch-For-Review, VPS-project-Codesearch
Ladsgroup added a comment to T257537: Configure HTTPS for pywikibot.org.

Isn't this done now?

Thu, Nov 26, 9:09 AM · User-Ladsgroup, HTTPS, Operations, Pywikibot, Traffic
Ladsgroup closed T257536: http://pywikibot.org/ is displaying Wikimedia error page as Resolved.

After the timestamp given above, now http://pywikibot.org redirects without any issues \o/

Thu, Nov 26, 9:08 AM · User-Ladsgroup, Patch-For-Review, Traffic, cloud-services-team (Kanban), Operations, Pywikibot
Ladsgroup closed T257536: http://pywikibot.org/ is displaying Wikimedia error page, a subtask of T257537: Configure HTTPS for pywikibot.org, as Resolved.
Thu, Nov 26, 9:07 AM · User-Ladsgroup, HTTPS, Operations, Pywikibot, Traffic

Wed, Nov 25

Ladsgroup moved T268635: Track local metrics in QueryBuilder from To Do to Doing on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board.
Wed, Nov 25, 1:21 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), User-Ladsgroup, Wikidata
Ladsgroup claimed T268635: Track local metrics in QueryBuilder.
Wed, Nov 25, 1:02 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), User-Ladsgroup, Wikidata
Ladsgroup added a comment to T268635: Track local metrics in QueryBuilder.

Note: The mw implementation of statsv is different, See https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/blob/master/modules/ext.wikimediaEvents/statsd.js#L52 and https://gerrit.wikimedia.org/g/mediawiki/extensions/EventLogging/+/834271d7c2188c7aff6e74bd21e917c42b7f7173/modules/ext.eventLogging/core.js

Wed, Nov 25, 12:40 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), User-Ladsgroup, Wikidata
Ladsgroup moved T268447: Implement the QB logic from Doing to Peer Review on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board.

https://github.com/wmde/query-builder/pull/79

Wed, Nov 25, 8:57 AM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), User-Ladsgroup, Wikidata
Ladsgroup closed T264915: Widget not found (from unsafeInfuse, on Special:AboutTopic) as Resolved.

Fixed on beta, will go live next week: https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:AboutTopic/Q467998

Wed, Nov 25, 8:05 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), User-Ladsgroup, Wikidata-Campsite, JavaScript, Wikidata, Wikimedia-production-error, OOUI, ArticlePlaceholder
Ladsgroup claimed T264915: Widget not found (from unsafeInfuse, on Special:AboutTopic).
Wed, Nov 25, 4:34 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), User-Ladsgroup, Wikidata-Campsite, JavaScript, Wikidata, Wikimedia-production-error, OOUI, ArticlePlaceholder
Ladsgroup added a comment to T266713: Uncaught Error: Syntax error, unrecognized expression: unsupported pseudo: wikibase-statementview .

Could it relate to this code which uses an invalid selector?
https://gerrit.wikimedia.org/g/mediawiki/extensions/PropertySuggester/+/d9e15c19abbb2fda47444bd98f3336f3be75c4e9/modules/PropertySuggester.js#132

Wed, Nov 25, 4:15 AM · Wikidata-Campsite, Wikimedia-production-error, Wikidata
SQL awarded T268701: Ability to thank blocks a Stroopwafel token.
Wed, Nov 25, 1:18 AM · Patch-For-Review, Growth-Team, Thanks, MediaWiki-Blocks
Tks4Fish awarded T268701: Ability to thank blocks a Love token.
Wed, Nov 25, 1:17 AM · Patch-For-Review, Growth-Team, Thanks, MediaWiki-Blocks
Ladsgroup created T268701: Ability to thank blocks.
Wed, Nov 25, 12:55 AM · Patch-For-Review, Growth-Team, Thanks, MediaWiki-Blocks

Tue, Nov 24

Ladsgroup created T268643: Add "footer".
Tue, Nov 24, 3:50 PM · Wikidata, Wikidata Query Builder
Ladsgroup moved T268447: Implement the QB logic from To Do to Doing on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board.
Tue, Nov 24, 2:31 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), User-Ladsgroup, Wikidata
Ladsgroup claimed T268447: Implement the QB logic .
Tue, Nov 24, 2:31 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), User-Ladsgroup, Wikidata
Ladsgroup assigned T267559: Query for items with specific property without a specific value to guergana.tzatchkova.
Tue, Nov 24, 2:21 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup updated subscribers of T267559: Query for items with specific property without a specific value.

It's this PR to be exact: https://github.com/wmde/query-builder/pull/70/files

Tue, Nov 24, 2:21 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup added a comment to T267791: Allow entering Wikidata sitelinks to sites that have an ID containing hyphens (not matching the database name).

I don't know the context where those drifts would happen and be bad, but in principle having different presentation and persistence models is fine, I'd think?

That would be fine if we didn't expose the persistence, but we do expose it. And not just exposing it, tools and services use that as well.

I have to admit I am being slightly confused of the purpose of the change then?
We allow, and encourage, hyphenated site IDs for user input (via UI, and APIs) but we present underscored ones? And you say it would not lead to confusion if done this way?

Yes but there is a big difference between UI where non-tech savvy people use and API where people who already know the difference use.

My, apparently wrong, understanding of reasoning behind this change was using similar "style" for site IDs (hyphenated) as is used (for input and output) for language code e.g. in item labels.
Was it not? What is the problem this change intends to solve then?

The difference is the input and output. Currently for articles of https://be-tarask.wikipedia.org the user can't input "be-tarask" (or "be_tarask") and it gets even worse, in UI, "be-x-old" works but not in API which is pretty bad and we should bring some clarity in it but there will be some level of inconsistency somewhere anyway and we shouldn't make AC to fix every inconsistency in the system. Because clients of wikidata can handle representation inconsistencies in API. For example, pywikibot itself fixes the dash to hyphen when building the Site() object from the sitelinks of wikidata.

Tue, Nov 24, 1:03 PM · Wikidata, Wikidata-Campsite
Ladsgroup claimed T263553: Investigate i18n solutions for Vue + non-mediawiki applications using TranslateWiki.
Tue, Nov 24, 12:20 PM · User-Ladsgroup, Wikidata Query Builder ( Wikidata Query Builder - sprint 4), Wikidata
Ladsgroup moved T267731: Investigate how to update translations in the repo automatically from translatewiki -- 4h max from Peer Review to Done on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board.
Tue, Nov 24, 12:20 PM · Patch-For-Review, User-Ladsgroup, Wikidata Query Builder ( Wikidata Query Builder - sprint 4), Wikidata
Ladsgroup moved T268446: Create Messages for user facing text from Peer Review to Done on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board.
Tue, Nov 24, 12:20 PM · User-Ladsgroup, Wikidata Query Builder ( Wikidata Query Builder - sprint 4), Wikidata
Ladsgroup moved T266789: show the errors based on the state from Test (Verification) to Done on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board.
Tue, Nov 24, 12:20 PM · Wikidata Query Builder ( Wikidata Query Builder - sprint 4), User-Ladsgroup, Wikidata
Ladsgroup moved T266789: show the errors based on the state from Peer Review to Test (Verification) on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board.
Tue, Nov 24, 12:20 PM · Wikidata Query Builder ( Wikidata Query Builder - sprint 4), User-Ladsgroup, Wikidata
Ladsgroup moved T266789: show the errors based on the state from ❌ Blocked to Peer Review on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board.
Tue, Nov 24, 11:40 AM · Wikidata Query Builder ( Wikidata Query Builder - sprint 4), User-Ladsgroup, Wikidata
Ladsgroup moved T263553: Investigate i18n solutions for Vue + non-mediawiki applications using TranslateWiki from To Do to Test (Verification) on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board.
Tue, Nov 24, 11:02 AM · User-Ladsgroup, Wikidata Query Builder ( Wikidata Query Builder - sprint 4), Wikidata
Ladsgroup added a comment to T268232: Add wikidata query builder to translatewiki.net.

Could you review and update that page (like bugtracker)?

Tue, Nov 24, 10:46 AM · Language-Team (Language-2020-October-December), translatewiki.net
Ladsgroup added a comment to T267791: Allow entering Wikidata sitelinks to sites that have an ID containing hyphens (not matching the database name).

@Ladsgroup note that the question was not about the JSON blog that is stored. It is defined it should not changed.
Question is about the JSON representation in the APIs ("action" API, special entity page, etc). My interpretation of requirements has been that this JSON representation should contain the favored form (i.e. hyphenated one). It would be great to have this interpretation confirmed by someone who knows what is the right thing. thanks

Tue, Nov 24, 9:17 AM · Wikidata, Wikidata-Campsite
Ladsgroup moved T268446: Create Messages for user facing text from To Do to Peer Review on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board.
Tue, Nov 24, 3:16 AM · User-Ladsgroup, Wikidata Query Builder ( Wikidata Query Builder - sprint 4), Wikidata
Ladsgroup claimed T268446: Create Messages for user facing text .

https://github.com/wmde/query-builder/pull/75

Tue, Nov 24, 3:15 AM · User-Ladsgroup, Wikidata Query Builder ( Wikidata Query Builder - sprint 4), Wikidata
Ladsgroup added a comment to T265245: (MS1) query for Items with specific Property but any value.

Thanks. I put up a PR doing this: https://github.com/wmde/query-builder/pull/74

Tue, Nov 24, 3:03 AM · Wikidata Query Builder ( Wikidata Query Builder - sprint 4), Wikidata
Ladsgroup added a comment to T268587: Generate abstract schema for all supported DBMS with one script call.

In one hand, this helps in migration, OTOH, this wouldn't be a big deal afterwards because I assume number of schema changes happening would be small. I'm happy to something rather hacky and remove it later.

Tue, Nov 24, 2:41 AM · MediaWiki-Maintenance-system, Platform Team Initiatives (Abstract Schema)

Mon, Nov 23

Ladsgroup added a comment to T256190: Remove or remodel small site ownership icons which used in every MediaWiki skin.

aha, sorry.

Mon, Nov 23, 9:30 PM · Design, MediaWiki-General, Accessibility
Ladsgroup added a comment to T256190: Remove or remodel small site ownership icons which used in every MediaWiki skin.

The proposed one that got votes is this: https://commons.wikimedia.org/wiki/File:Powered_by_MediaWiki_proposal_(gradient_translucent,_capitalised).svg

Mon, Nov 23, 9:27 PM · Design, MediaWiki-General, Accessibility
Ladsgroup updated the task description for T268230: Rolling out the new logo of MediaWiki.
Mon, Nov 23, 9:07 PM · Design, MediaWiki-General
Ladsgroup added a member for WMF-NDA: Urbanecm.
Mon, Nov 23, 8:16 PM
Ladsgroup added a comment to T256190: Remove or remodel small site ownership icons which used in every MediaWiki skin.

IMHO, changing logo in the footer is needed, doing some refinements of the old buttons is also nice (like dropping the shadows) but anything drastic is going to cause a backlash if done without a proper community-based decision making. So I recommend keeping changes to a minimum (we also need to replace the logo in a million places, let's not bloat the work too much)

Mon, Nov 23, 7:39 PM · Design, MediaWiki-General, Accessibility
Ladsgroup updated subscribers of T268448: Create Wiktionary Saraiki.

@MF-Warburg is this approved by langcom?

Mon, Nov 23, 10:29 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, User-Urbanecm, Wiki-Setup (Create)
Ladsgroup added a comment to T185664: Code stewardship review: FlaggedRevs.

Is there a default result for an extension if no team agrees to be responsible for it? Undeployment?

No, the default "result" is to forward this to C levels of WMF for a decision. See https://www.mediawiki.org/wiki/Code_stewardship_reviews#FAQ. Per my understanding, this gives one more chance to the extension to be adopted (and funded accordingly).

So should we forward this to C levels? This task was opened in January 2018, with no end in sight and no one (so far) volunteering to be responsible for it

Mon, Nov 23, 1:42 AM · Release-Engineering-Team (Code Health), MediaWiki-extensions-FlaggedRevs, Code-Stewardship-Reviews

Sun, Nov 22

Ladsgroup added a comment to T268410: Create Wikipedia Saraiki.

@Nintendofan885 Hey, you really don't need to update the ticket, it gets updated automatically every couple of hours.

Sun, Nov 22, 9:02 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Wikimedia-Language-setup, User-Urbanecm, Wiki-Setup (Create)
Ladsgroup updated the task description for T230428: Migrate tables.sql to abstract schema.
Sun, Nov 22, 3:57 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer
Ladsgroup closed T258366: content.content_id is not "NOT NULL" while being primary key as Resolved.
Sun, Nov 22, 3:40 PM · User-Ladsgroup, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Platform Team Workboards (Clinic Duty Team), Wikimedia-Rdbms
Krenair awarded T268393: Cloud network not being able to handle large UDP traffic a Evil Spooky Haunted Tree token.
Sun, Nov 22, 12:57 AM · Cloud-Services
Ladsgroup created T268393: Cloud network not being able to handle large UDP traffic.
Sun, Nov 22, 12:46 AM · Cloud-Services
Ladsgroup created T268392: Schema change for watchlist.wl_notificationtimestamp going binary(14) from varbinary(14).
Sun, Nov 22, 12:35 AM · DBA, Blocked-on-schema-change
Ladsgroup created T268391: Schema change for timestamp fields of jobs table.
Sun, Nov 22, 12:32 AM · DBA, Blocked-on-schema-change

Sat, Nov 21

Ladsgroup updated the task description for T230428: Migrate tables.sql to abstract schema.
Sat, Nov 21, 10:42 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer
Ladsgroup renamed T263288: experiment with reenabling compression between applayer's TLS terminators and edge caches from experiment with reënabling compression between applayer's TLS terminators and edge caches to experiment with reenabling compression between applayer's TLS terminators and edge caches.
Sat, Nov 21, 9:11 PM · netops, Traffic, Operations
Ladsgroup added a comment to T246431: Minor fixes in pybal checks.

I have seen that UA in ores logs and have been thinking of blocking it since it seems like an external mystery scraper. Until today I learned it's pybal 🤦‍♂️ 🤦‍♂️ 🤦‍♂️ 🤦‍♂️ 🤦‍♂️

Sat, Nov 21, 9:05 PM · Traffic, Operations, Pybal
Ladsgroup added a comment to T236065: Remove unused plain HTTP services from LVS.

Can I ask how I can check if they are not used anymore? That file doesn't exist anymore and it's all in services.yaml

Sat, Nov 21, 8:48 PM · Operations, Traffic
Ladsgroup added a comment to T268230: Rolling out the new logo of MediaWiki.

Monobook and Timeless:


Sat, Nov 21, 7:08 PM · Design, MediaWiki-General
Ladsgroup updated the task description for T268230: Rolling out the new logo of MediaWiki.
Sat, Nov 21, 5:08 PM · Design, MediaWiki-General
Ladsgroup updated the task description for T268230: Rolling out the new logo of MediaWiki.
Sat, Nov 21, 4:58 PM · Design, MediaWiki-General

Fri, Nov 20

Ladsgroup added a comment to T265245: (MS1) query for Items with specific Property but any value.

There's an a11y issue with the current design, the a11y tests is now failing (https://github.com/wmde/query-builder/pull/33/checks?check_run_id=1432756100):

FAIL tests/unit/components/QueryBuilder.spec.ts
  ● QueryBuilder.vue › should not have obvious accessibility issues
Fri, Nov 20, 7:56 PM · Wikidata Query Builder ( Wikidata Query Builder - sprint 4), Wikidata
Ladsgroup added a comment to T265243: get initial metrics.

You can simply use statsv: https://wikitech.wikimedia.org/wiki/Graphite#statsv

Fri, Nov 20, 3:01 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), Wikidata
Ladsgroup added a comment to T268199: Graduate codesearch to production.

If it's that simple and a ganeti VM makes things much easier, I think doing it would be pretty easy. 1- We need to use webproxy for pulling from github 2- it needs a security review?

Fri, Nov 20, 2:56 PM · Operations, VPS-project-Codesearch
Ladsgroup added a comment to T268328: Automatically index extensions in Codesearch.

Codesearch searches for extensions and rebuild it on daily basis: https://gerrit.wikimedia.org/g/labs/codesearch/+/refs/changes/47/641847/1/write_config.py#35 Do you mean something larger?

Fri, Nov 20, 2:42 PM · VPS-project-Codesearch, TechCom
Ammarpad awarded T259771: RFC: Drop support for database upgrade older than two LTS releases a Like token.
Fri, Nov 20, 2:01 AM · MediaWiki-Stakeholders-Group, Platform Engineering, TechCom-RFC
Ladsgroup added a comment to T259771: RFC: Drop support for database upgrade older than two LTS releases.

We just discussed this in the Platform Engineering (PET) technical planning meeting. People in the meeting agreed with the general idea, though there was some discussion over whether it should be two LTS releases or three. PET can be the owner of the new policy, and champion this proposal.

Fri, Nov 20, 12:04 AM · MediaWiki-Stakeholders-Group, Platform Engineering, TechCom-RFC

Thu, Nov 19

Ladsgroup added a comment to T259771: RFC: Drop support for database upgrade older than two LTS releases.

We reviewed this in yesterday's TechCom meeting. The following questions have come up:

  • We need a way to detect and safely abort if someone tries to update from a version that is too old. So we have to somehow somewhere record in the database what version we are on. Maybe a simple revision number would be sufficient, but maybe we want something more fine grained. Maybe we can use update_log, maybe not. This needs a little more thought.

The problem is that it's impossible to implement, if we add something that leaves a marker in database, it's still can't be propagated to previous installations using EOL'ed releases in the wild. I have two ideas and have no preference which way to go :

  • Adding an optional argument to update.php and the maintainer providing that. So for example:
php maintenance/update.php --from-version=1.12

would abort on 1.36. Given the backward compatibility, I think if not applied, we should assume it's updating from within a release

Thu, Nov 19, 10:12 PM · MediaWiki-Stakeholders-Group, Platform Engineering, TechCom-RFC
Pcoombe awarded T268230: Rolling out the new logo of MediaWiki a Love token.
Thu, Nov 19, 10:07 PM · Design, MediaWiki-General
Ladsgroup added a comment to T119173: RFC: Discourage use of MySQL's ENUM type.

Is that a fair summary?

Thu, Nov 19, 9:56 PM · Data-Persistence-Consultation, Performance-Team (Radar), TechCom-RFC, MediaWiki-General
Ladsgroup added a comment to T268199: Graduate codesearch to production.

In general I like the idea but I'm slightly worried with the limited time and energy we have and given that we would eventually migrate to gitlab, we could use this time and energy on something more useful. I'm not saying we shouldn't do it, I'm saying given the limited resources we can do something more lasting. If anyone feels strongly otherwise, I'm definitely okay with helping them out getting it to production.

Thu, Nov 19, 9:46 PM · Operations, VPS-project-Codesearch
Ladsgroup added a comment to T268198: Reduce user impact of codesearch's nightly restarts.

Is there a way for the write config not to restart if configs are the same? for example, it can load the config and check if they are the same and not write it if they are the same and the restarter checks and if the modification date is recent, restarts it. It's slightly complicated but not too much. Do you think it make sense?

Thu, Nov 19, 9:01 PM · Patch-For-Review, VPS-project-Codesearch
Ladsgroup added a comment to T267733: Investigate how do we handle RTL languages in the components -- 8h max.

@Ladsgroup
Suggestions from Navigators Summit:

  • Did we check how Termbox's use of RTL?

It uses RtlDetectLib which is nice but so far I haven't had the need to use it in QB. Good to keep it in mind though.

  • Do not use CSS Janus. Let's use CSS logical properties.
Thu, Nov 19, 8:56 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 5), User-Ladsgroup, Wikidata
Ladsgroup committed rMSRD9ca186bddb44: Drop deployment-sca04 from betacluster deploys (authored by Ladsgroup).
Drop deployment-sca04 from betacluster deploys
Thu, Nov 19, 8:40 PM
Ladsgroup added a comment to T267793: Allow entering Wikidata sitelinks to sites using an alternative (alias) site ID (not matching the database name).

I think it should be only small case latin letters and hyphens (and underscores). Anything else makes this ticket bigger can be tackled later.

Thu, Nov 19, 8:36 PM · Wikidata, Wikidata-Campsite
Ladsgroup added a comment to T267732: Investigate how to switch the language in the UI (can we reuse what's done in the Query Service UI?) -- 8h.

https://github.com/wmde/query-builder/pull/68

Thu, Nov 19, 7:58 PM · User-Ladsgroup, Wikidata Query Builder ( Wikidata Query Builder - sprint 4), Wikidata