Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani (WMDE))
Master of introducing new bugsAdministrator

Projects (28)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (257 w, 5 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Wikidata developer, open source enthusiast, mediawiki volunteer developer
Babel: fa-N, en-4, de-1, tr-1

Recent Activity

Fri, Sep 13

Ladsgroup committed rADTBf51e4d3b4e84: Rebuild the jar (authored by Ladsgroup).
Rebuild the jar
Fri, Sep 13, 12:13 PM
Ladsgroup committed rADTBb92367f936d2: Rebuild the jar (authored by Ladsgroup).
Rebuild the jar
Fri, Sep 13, 12:13 PM
Ladsgroup committed rADTBb2549203e892: Track *.jar files as git lfs (authored by Ladsgroup).
Track *.jar files as git lfs
Fri, Sep 13, 12:13 PM
Ladsgroup moved T232826: Start using the new internal entry point for WDQS in WMDE statistics from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Sep 13, 11:47 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), WMDE-Analytics-Engineering, User-Ladsgroup, Wikidata
Ladsgroup created T232826: Start using the new internal entry point for WDQS in WMDE statistics.
Fri, Sep 13, 11:40 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), WMDE-Analytics-Engineering, User-Ladsgroup, Wikidata
Ladsgroup added a comment to T66315: Move "Data item" link outside of sidebar toolbox.

AFAIK, the decision was to have both for a month and then drop the toolbox.

This is a technical way/implementation of the change. We are not going to start with it until late 2019 to allow ourselves to communicate the change appropriately to all affected communities, and give all interested parties enough time to adapt.

Fri, Sep 13, 9:50 AM · Wikidata-Campsite, MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Patch-For-Review, User-notice, User-Ladsgroup, User-Noarave, Wikidata, MediaWiki-extensions-WikibaseClient

Thu, Sep 12

Ladsgroup added a comment to T66315: Move "Data item" link outside of sidebar toolbox.

To figure out a way around caching and/or other stuff before we move on with it later in November/December.

AFAIK, the decision was to have both for a month and then drop the toolbox.

Thu, Sep 12, 9:29 PM · Wikidata-Campsite, MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Patch-For-Review, User-notice, User-Ladsgroup, User-Noarave, Wikidata, MediaWiki-extensions-WikibaseClient
Ladsgroup added a comment to T231326: Explore ResourceLoader package files feature as way to reduce number of modules.

I wrote a code to analyze RL dependency graph and find things that can be merged, CX modules stood out a lot. Given that dropping each CX module saves 30 GB/day, I put them here and I hope you find them useful. The analysis of course can have false positives (like lazy loading, etc.) but looking at this might help you:






Thu, Sep 12, 7:51 PM · Performance-Team (Radar), ContentTranslation
Ladsgroup claimed T232728: Create a dependency graph of existing RL modules.

This was fun. Wikibase (repo + lib + view + client + lexeme) registers 260 RL module.
This is just the dependency graph of Wikibase modules (not core or other things):


If we just take a look at the modules to untangle them, it's completely useless:

Thu, Sep 12, 7:31 PM · User-Ladsgroup, RL Module Terminators Trailblazing
Ladsgroup committed rADTAf5ba8884ca56: Use the new wdqs address (authored by Ladsgroup).
Use the new wdqs address
Thu, Sep 12, 1:05 PM
Ladsgroup added a comment to T225056: Run Item Terms Rebuild script.

Merged and as requested at :

root@mwmaint1002:~# cat /var/log/wikidata/wikidata-rebuildItemTerms.log
Rebuilding Q501 till Q2000000
root@mwmaint1002:~# ls -lh /var/log/wikidata/wikidata-rebuildItemTerms.log
-rw-r--r-- 1 www-data www-data 30 Sep 10 08:57 /var/log/wikidata/wikidata-rebuildItemTerms.log

Those permissions are the same as the other logs on that directory have.

Thu, Sep 12, 12:07 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup added a comment to T176875: Allow access to wdqs.svc.eqiad.wmnet on port 8888.

The requests work but the TLS ones give me this error:

ladsgroup@stat1007:~$ curl https://wdqs.svc.eqiad.wmnet:8888
curl: (35) error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol

Our config uses https://wdqs1005.eqiad.wmnet:8888 which also fail with this error. That's weird. We can switch to http:// for now until this gets fixed.

Thu, Sep 12, 10:21 AM · Patch-For-Review, Traffic, Wikidata-Query-Service, Operations, WMDE-Analytics-Engineering, User-Addshore, Discovery, Wikidata
Ladsgroup added a comment to T231089: WikibaseClient.php: PHP Notice: Undefined index:.

no please do not. This bug has nothing to do with opcache corruption during deployments. The problem happens only episodically, not for all requests that happen to hit that code path, so I doubt that's the cause.

Thu, Sep 12, 10:13 AM · PHP 7.2 support, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikimedia-production-error

Wed, Sep 11

Ladsgroup placed T227266: Find out why 'old revisions do not have edit links' selenium test is flaky on CI up for grabs.
Wed, Sep 11, 7:02 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-Ladsgroup, ci-test-error, Wikimedia-production-error (Shared Build Failure), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, User-Noarave
Ladsgroup renamed T228739: Jenkins runs Scribunto tests in Wikibase patches from Jenkins has been running Scribunto tests in Wikibase patches since 2015 to Jenkins runs Scribunto tests in Wikibase patches.
Wed, Sep 11, 6:02 PM · Continuous-Integration-Config, Wikidata, ci-test-error
Ladsgroup added a comment to T232626: CI mediawiki/core run times have increased since July 26th.

Another reason: T231862: Selenium tests for Wikibase are being ran twice (Wikibase is part of gate, lots of selenium tests are being ran twice)

Wed, Sep 11, 6:01 PM · Release-Engineering-Team-TODO (201909), Continuous-Integration-Config
Ladsgroup added a comment to T232626: CI mediawiki/core run times have increased since July 26th.

I made a phabricator ticket at exact time: T228739: Jenkins runs Scribunto tests in Wikibase patches @Jdforrester-WMF

Wed, Sep 11, 6:00 PM · Release-Engineering-Team-TODO (201909), Continuous-Integration-Config
Ladsgroup added a comment to T232563: Drop IE6 and IE7 basic compatibility and security support.

Just a note, Currently China has blocked accessing Wikipedia. On a hypothetical scenario, if they unblock it, it might increase the IE traffic back to a significant number (given that China is China, Out of top six most visited websites in the world, four them are in China). OTOH, this is very unlikely to happen.

Wed, Sep 11, 12:30 PM · MediaWiki-General, TechCom-RFC

Tue, Sep 10

Ladsgroup placed T228293: [4h invstigation] RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job) up for grabs.
Tue, Sep 10, 4:29 PM · Wikidata-Campsite, User-Ladsgroup, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T232492: Track size of page responses in Wikibase.

2MB of minifed js. This is absolutely crazy .

Tue, Sep 10, 4:17 PM · RL Module Terminators Trailblazing
Ladsgroup updated the task description for T232492: Track size of page responses in Wikibase.
Tue, Sep 10, 3:43 PM · RL Module Terminators Trailblazing
Ladsgroup added a comment to T232492: Track size of page responses in Wikibase.

Q7251:

Tue, Sep 10, 3:42 PM · RL Module Terminators Trailblazing
Ladsgroup created T232492: Track size of page responses in Wikibase.
Tue, Sep 10, 3:41 PM · RL Module Terminators Trailblazing
Ladsgroup created T232465: List of WikibaseLexeme javascript entry points and other modules that can't be dropped.
Tue, Sep 10, 11:59 AM · User-Ladsgroup, Wikidata, Lexicographical data, RL Module Terminators Trailblazing
Ladsgroup moved T225055: Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_BOTH from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 10, 11:10 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup moved T230399: Entity Schema editor should be warning users about a blank edit summary from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 10, 9:29 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Noarave, Shape Expressions, Wikidata
Ladsgroup moved T225055: Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_BOTH from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 10, 9:06 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing

Mon, Sep 9

Ladsgroup claimed T228293: [4h invstigation] RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job).

Steps to reproduce:

  • Make an item (let's say Q231 with revision id 730)
  • Merge it to another item. Let's say you merge it and now it has revision id of 731 redirecting to Q228
  • Try setting English label or description using wbset(label|description) and not with wbeditentity and set baserevid=730 (before redirect)
  • Ta-duh
Mon, Sep 9, 8:52 PM · Wikidata-Campsite, User-Ladsgroup, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T232260: Hamburger and notifications menu icons arehidden in mobile view of RTL languages in Chrome.

Okay, @Jdrewniak has identified a short term fix if you need one asap to add to your MediaWiki:Mobile.css:

Mon, Sep 9, 8:40 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Browser-Support-Android-Google-Chrome, Browser-Support-Google-Chrome, Mobile, RTL, I18n, MobileFrontend
Ladsgroup added a comment to T228293: [4h invstigation] RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job).

Looking at the errors, it only happen on apps now (not on jobs anymore). I will debug this slightly further.

Mon, Sep 9, 4:15 PM · Wikidata-Campsite, User-Ladsgroup, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T225055: Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_BOTH.

Mentioned in SAL (#wikimedia-operations) [2019-09-04T11:37:47Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:534183|Set item terms migration stage for Wikidata on WRITE_BOTH up to Q2m (T225055)]] (duration: 00m 55s)

Mon, Sep 9, 11:43 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup added a comment to T230399: Entity Schema editor should be warning users about a blank edit summary.

The warning doesn't have much notice to it:


Adding warningbox makes it more visible:

Mon, Sep 9, 10:38 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Noarave, Shape Expressions, Wikidata

Fri, Sep 6

Ladsgroup moved T231685: Flaky test: Lexeme:Forms can cancel form addition from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Sep 6, 1:16 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Wikidata, Browser-Tests, Wikimedia-production-error (Shared Build Failure), Lexicographical data
Ladsgroup committed rEBQCed46d21b9459: Migrate some unit tests to the new structure (authored by Ladsgroup).
Migrate some unit tests to the new structure
Fri, Sep 6, 12:38 PM
Ladsgroup moved T225056: Run Item Terms Rebuild script from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Sep 6, 12:07 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup added a comment to T225056: Run Item Terms Rebuild script.

The complete list of things that the script can't build:

[ERROR] Failed to save terms of item: Q29
[ERROR] Failed to save terms of item: Q35
[ERROR] Failed to save terms of item: Q45
[ERROR] Failed to save terms of item: Q55
[ERROR] Failed to save terms of item: Q188
[ERROR] Failed to save terms of item: Q1321
[ERROR] Failed to save terms of item: Q1860
[ERROR] Failed to save terms of item: Q334351
[ERROR] Failed to save terms of item: Q649003
[ERROR] Failed to save terms of item: Q994512
[ERROR] Failed to save terms of item: Q994528
Fri, Sep 6, 10:49 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing

Thu, Sep 5

Ladsgroup created T232132: Add EntitiesWithoutTermFinder for the new store.
Thu, Sep 5, 5:48 PM · Wikidata, Wikidata-Campsite
Ladsgroup updated subscribers of T232085: RTL Wikis problem with tags in RC, history, contribs etc..

Yup, I was able to reproduce it in chrome. If the line breaks, it shows the closing bracket but before the content which looks interesting:


I feel this is a bug in chrome. @Volker_E is a better person to take a look at this.

Thu, Sep 5, 5:30 PM · Browser-Support-Google-Chrome, MediaWiki-Special-pages, MediaWiki-Internationalization, RTL, I18n
Ladsgroup moved T227643: dumpRDF.php generates a hash-based conceptUri from Ready to pick up to Ready to estimate on the Wikidata-Campsite board.
Thu, Sep 5, 2:23 PM · Wikidata-Campsite, User-Ladsgroup, Wikidata-Query-Service, Wikidata, Wikibase-Containers
Ladsgroup placed T227643: dumpRDF.php generates a hash-based conceptUri up for grabs.

Unfortunately this is bigger than it looks because the proposed solution really breaks WDQS updater rendering WDQS in docker completely useless. I put it back for re-estimation and possible solutions.

Thu, Sep 5, 2:19 PM · Wikidata-Campsite, User-Ladsgroup, Wikidata-Query-Service, Wikidata, Wikibase-Containers
Ladsgroup added a comment to T232085: RTL Wikis problem with tags in RC, history, contribs etc..

Can you put the CSS rules for the tags? I have a feeling they are being eaten by CSS

Thu, Sep 5, 2:13 PM · Browser-Support-Google-Chrome, MediaWiki-Special-pages, MediaWiki-Internationalization, RTL, I18n
Ladsgroup added a comment to T232085: RTL Wikis problem with tags in RC, history, contribs etc..

This is a rather high priority issue but I can't reproduce it. Maybe because I use the enhanced RC:

Thu, Sep 5, 1:57 PM · Browser-Support-Google-Chrome, MediaWiki-Special-pages, MediaWiki-Internationalization, RTL, I18n
Ladsgroup added a comment to T232081: Change Tag increased database contention (deadlocks) by the jobqueue (InjectRCRecordsJob).

Most of these errors seem to come from euwiki, and with a ct_tag_id corresponding to the php7 tag. (I think that much is safe to say publicly.)

Thu, Sep 5, 10:54 AM · serviceops, MediaWiki-Recent-changes, MediaWiki-Change-tagging, Wikimedia-production-error, Core Platform Team, Wikimedia-Rdbms, Growth-Team, Regression
Ladsgroup added a comment to T232081: Change Tag increased database contention (deadlocks) by the jobqueue (InjectRCRecordsJob).

The good news is that we don't inject the change tag from Wikidata (it would have been really really big). The bad news is it's php7 tags:

wikiadmin@10.64.32.136(euwiki)> select ct_tag_id from recentchanges join change_tag on rc_id = ct_rc_id where rc_source = 'wb' and ct_tag_id  != 46 limit 5;
Empty set (1.17 sec)
Thu, Sep 5, 10:53 AM · serviceops, MediaWiki-Recent-changes, MediaWiki-Change-tagging, Wikimedia-production-error, Core Platform Team, Wikimedia-Rdbms, Growth-Team, Regression
Ladsgroup added a comment to T232081: Change Tag increased database contention (deadlocks) by the jobqueue (InjectRCRecordsJob).

The inject RC jobs should inject tags into clients, that's wrong.

Thu, Sep 5, 10:50 AM · serviceops, MediaWiki-Recent-changes, MediaWiki-Change-tagging, Wikimedia-production-error, Core Platform Team, Wikimedia-Rdbms, Growth-Team, Regression
Ladsgroup added a comment to T232081: Change Tag increased database contention (deadlocks) by the jobqueue (InjectRCRecordsJob).

It seems all are inject RC record jobs (wikibase stuff). Might be (just thinking out loud), we are inserting duplicated jobs into the jobqueue?

Thu, Sep 5, 9:23 AM · serviceops, MediaWiki-Recent-changes, MediaWiki-Change-tagging, Wikimedia-production-error, Core Platform Team, Wikimedia-Rdbms, Growth-Team, Regression

Wed, Sep 4

Ladsgroup updated subscribers of T226210: Fix conditional presence of 'sitenotice' data and #siteNotice element.

@AndyRussG Hey, do you know why this is happening? I want to help but I'm slightly confused here.

Wed, Sep 4, 9:37 PM · User-Ladsgroup, MediaWiki-Interface, patch-welcome, Technical-Debt, MediaWiki-extensions-CentralNotice, Performance-Team (Radar)
Ladsgroup added a comment to T232035: 1.34.0-wmf.21 cause termbox to emit: Test get rendered termbox returned the unexpected status 500.

The link to logs: https://logstash.wikimedia.org/goto/3146ff65c2320362e12501bb1fe55789

Wed, Sep 4, 9:26 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), serviceops, Wikidata, Wikidata-Termbox, Release-Engineering-Team-TODO (201909), Release, Train Deployments
Ladsgroup edited projects for T232035: 1.34.0-wmf.21 cause termbox to emit: Test get rendered termbox returned the unexpected status 500, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Release-Engineering-Team (Deployment services).
Wed, Sep 4, 9:12 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), serviceops, Wikidata, Wikidata-Termbox, Release-Engineering-Team-TODO (201909), Release, Train Deployments
Ladsgroup added a comment to T227643: dumpRDF.php generates a hash-based conceptUri.

The solution indeed breaks WDQS updater:

wdqs-updater_1     | 17:08:57.869 [main] INFO  o.w.q.r.t.change.RecentChangesPoller - Got 1 changes, from Q2@8@20190904170851|7 to Q2@8@20190904170851|7
wdqs-updater_1     | 17:08:58.060 [update 1] WARN  org.wikidata.query.rdf.tool.Updater - Contained error syncing.  Giving up on Q2
wdqs-updater_1     | org.wikidata.query.rdf.tool.rdf.Munger$BadSubjectException: Unrecognized subjects:  [http://localhost:8181/entity/Q2, http://localhost:8181/wiki/Special:EntityData/Q2, http://localhost:8181/entity/statement/Q2-be933bd3-4253-89ed-e5d5-dc0a96b5732d].  Expected only sitelinks and subjects starting with http://wikibase.svc/wiki/Special:EntityData/ and http://wikibase.svc/entity/
wdqs-updater_1     | 	at org.wikidata.query.rdf.tool.rdf.Munger$MungeOperation.finishCommon(Munger.java:941)
wdqs-updater_1     | 	at org.wikidata.query.rdf.tool.rdf.Munger$MungeOperation.munge(Munger.java:493)
wdqs-updater_1     | 	at org.wikidata.query.rdf.tool.rdf.Munger.munge(Munger.java:148)
wdqs-updater_1     | 	at org.wikidata.query.rdf.tool.rdf.Munger.mungeWithValues(Munger.java:182)
wdqs-updater_1     | 	at org.wikidata.query.rdf.tool.Updater.handleChange(Updater.java:371)
wdqs-updater_1     | 	at org.wikidata.query.rdf.tool.Updater.lambda$handleChanges$0(Updater.java:236)
wdqs-updater_1     | 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
wdqs-updater_1     | 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
wdqs-updater_1     | 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
wdqs-updater_1     | 	at java.lang.Thread.run(Thread.java:748)
wdqs-updater_1     | 17:08:58.111 [main] INFO  org.wikidata.query.rdf.tool.Updater - Polled up to 2019-09-04T17:08:51Z at (0.0, 0.0, 0.0) updates per second and (0.0, 3.9, 34014.6) milliseconds per second
wdqs-updater_1     | 17:08:58.128 [main] INFO  o.w.q.r.t.change.RecentChangesPoller - Got no real changes
Wed, Sep 4, 5:46 PM · Wikidata-Campsite, User-Ladsgroup, Wikidata-Query-Service, Wikidata, Wikibase-Containers
Ladsgroup moved T192462: mw.wikibase.entityExists returns false for redirected entities from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Sep 4, 3:42 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient, Wikibase-Lua
Ladsgroup moved T227643: dumpRDF.php generates a hash-based conceptUri from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Sep 4, 3:07 PM · Wikidata-Campsite, User-Ladsgroup, Wikidata-Query-Service, Wikidata, Wikibase-Containers
Ladsgroup claimed T227643: dumpRDF.php generates a hash-based conceptUri.
Wed, Sep 4, 3:07 PM · Wikidata-Campsite, User-Ladsgroup, Wikidata-Query-Service, Wikidata, Wikibase-Containers
Ladsgroup moved T225055: Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_BOTH from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Sep 4, 2:30 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup moved T225056: Run Item Terms Rebuild script from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Sep 4, 11:44 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup moved T192462: mw.wikibase.entityExists returns false for redirected entities from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Sep 4, 10:29 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient, Wikibase-Lua
Ladsgroup added a comment to T231862: Selenium tests for Wikibase are being ran twice.

The change was for Wikibase and it get added again in EXT_DEPENDENCIES. For example Wikibase depends on WikibaseLexeme which itself is flagged to depend on .. Wikibase :]

Wed, Sep 4, 9:08 AM · Quibble, Continuous-Integration-Config, ci-test-error

Tue, Sep 3

Ladsgroup moved T224472: Investigate the timeout of Wikibase browser tests after the change/fix in MediaWiki's DeferredUpdated from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

This is result of my investigation: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/497537#message-2cc44c252b1750c49c9e2f84920cc74e3d8184bf

Tue, Sep 3, 8:31 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T224472: Investigate the timeout of Wikibase browser tests after the change/fix in MediaWiki's DeferredUpdated from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 3, 6:28 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T231685: Flaky test: Lexeme:Forms can cancel form addition from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

The patch should have fixed the issue hopefully. Feel free to bring it back if flaky tests keep happening

Tue, Sep 3, 6:28 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Wikidata, Browser-Tests, Wikimedia-production-error (Shared Build Failure), Lexicographical data
Ladsgroup added a comment to T224472: Investigate the timeout of Wikibase browser tests after the change/fix in MediaWiki's DeferredUpdated.

It seems my patch doesn't fix it (it seems, it fixed the flaky browser tests though). The interesting thing is that the ruby tests are failing only and we should rewrite them to use nodejs anyway.

Tue, Sep 3, 5:41 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T231685: Flaky test: Lexeme:Forms can cancel form addition from Incoming to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Tue, Sep 3, 5:27 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Wikidata, Browser-Tests, Wikimedia-production-error (Shared Build Failure), Lexicographical data
Ladsgroup added a comment to T228299: ModifyEntity.php database error.

I suggest closing this. DBQueryError on wikidata only happened twice in the last 7 days with unrelated cases: https://logstash.wikimedia.org/goto/377e383afb5da0a215980a1568bc7eb8

Tue, Sep 3, 5:20 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
Ladsgroup moved T224472: Investigate the timeout of Wikibase browser tests after the change/fix in MediaWiki's DeferredUpdated from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 3, 4:26 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T229099: Find out why Lexeme:Forms test is flaky in CI and fix.
Tue, Sep 3, 4:25 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
Ladsgroup moved T229099: Find out why Lexeme:Forms test is flaky in CI and fix from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

The patch should have fixed the issue hopefully. Feel free to bring it back if flaky tests keep happening

Tue, Sep 3, 4:25 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
Ladsgroup claimed T227266: Find out why 'old revisions do not have edit links' selenium test is flaky on CI.

The patch should have fixed the issue hopefully. Feel free to bring it back if flaky tests keep happening

Tue, Sep 3, 4:25 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-Ladsgroup, ci-test-error, Wikimedia-production-error (Shared Build Failure), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, User-Noarave
Ladsgroup claimed T229634: Flaky selenium tests block merging to Wikibase.

The patch should have fixed the issue hopefully. Feel free to bring it back if flaky tests keep happening

Tue, Sep 3, 4:25 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), ci-test-error, Lexicographical data, Wikidata
Ladsgroup moved T229634: Flaky selenium tests block merging to Wikibase from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 3, 4:24 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), ci-test-error, Lexicographical data, Wikidata
Ladsgroup added a comment to T192462: mw.wikibase.entityExists returns false for redirected entities.

So quick question from people who need this (ping @Uzume and @eranroz): Should mw.wikibase.entityExists('Q123') return true in case Q123 is redirect all the time or when it's redirecting to an existing entity?

Tue, Sep 3, 3:09 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient, Wikibase-Lua
Ladsgroup claimed T225056: Run Item Terms Rebuild script.
Tue, Sep 3, 1:25 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup added a comment to T231685: Flaky test: Lexeme:Forms can cancel form addition.

Skipping that test doesn't fix the issue. All Lexeme browser tests are flaky and there are several tickets open about it T225017: Flaky WikibaseLexeme test T229099: Find out why Lexeme:Forms test is flaky in CI and fix T229634: Flaky selenium tests block merging to Wikibase and several more that I couldn't find. There's an underyling problem that I hope I found the reason.

Tue, Sep 3, 1:22 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Wikidata, Browser-Tests, Wikimedia-production-error (Shared Build Failure), Lexicographical data
Ladsgroup moved T229634: Flaky selenium tests block merging to Wikibase from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 3, 1:04 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), ci-test-error, Lexicographical data, Wikidata
Ladsgroup moved T227266: Find out why 'old revisions do not have edit links' selenium test is flaky on CI from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 3, 1:04 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-Ladsgroup, ci-test-error, Wikimedia-production-error (Shared Build Failure), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, User-Noarave
Ladsgroup moved T229099: Find out why Lexeme:Forms test is flaky in CI and fix from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 3, 1:03 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
Ladsgroup closed T210752: Create Wikisource Neapolitan as Resolved.

The task in question is done, if there are config issues with the new wikis (which usually any new thing has some bugs) please open another ticket and people will fix it. The task of "Create Wikisource Neapolitan" is done here.

Tue, Sep 3, 1:02 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Google-Code-in-2018, Wiki-Setup (Create), User-Urbanecm
Ladsgroup added a comment to T225056: Run Item Terms Rebuild script.
ladsgroup@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildItemTerms.php --wiki=wikidatawiki --to-id 1000 --sleep 2
Rebuilding Q1 till Q250
[ERROR] Failed to save terms of item: Q29
[ERROR] Failed to save terms of item: Q35
[ERROR] Failed to save terms of item: Q45
[ERROR] Failed to save terms of item: Q55
[ERROR] Failed to save terms of item: Q188
Rebuilding Q251 till Q500
Rebuilding Q501 till Q750
Rebuilding Q751 till Q1000
Done.
Tue, Sep 3, 11:42 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup created T231862: Selenium tests for Wikibase are being ran twice.
Tue, Sep 3, 9:55 AM · Quibble, Continuous-Integration-Config, ci-test-error
Ladsgroup claimed T192462: mw.wikibase.entityExists returns false for redirected entities.
Tue, Sep 3, 9:31 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient, Wikibase-Lua
Ladsgroup moved T231799: LuaWikibaseEntityLibraryTest: CI failing en masse from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 3, 9:16 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-Scribunto, Wikidata
Ladsgroup moved T224472: Investigate the timeout of Wikibase browser tests after the change/fix in MediaWiki's DeferredUpdated from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Sep 3, 9:15 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Mon, Sep 2

Ladsgroup claimed T224472: Investigate the timeout of Wikibase browser tests after the change/fix in MediaWiki's DeferredUpdated.

I will take a look. I can't promise anything though :(

Mon, Sep 2, 4:13 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup assigned T178745: Highlight statement(s) when using "#P" in URL to abian.
Mon, Sep 2, 1:27 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Design, patch-welcome, good first bug, WMDE-Design, MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup moved T178745: Highlight statement(s) when using "#P" in URL from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Sep 2, 12:01 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Design, patch-welcome, good first bug, WMDE-Design, MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup committed rADTBd0e0fb06a0dc: Track *.jar files as git lfs (authored by Ladsgroup).
Track *.jar files as git lfs
Mon, Sep 2, 11:39 AM
Ladsgroup claimed T219123: Run Migration of item terms.
Mon, Sep 2, 11:34 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
Ladsgroup added a comment to T125050: [Task] Add Scribunto to extension-gate in CI.

I think we can revisit this now. I moved 675 tests of Scribunto from "integration" type to "unit" (T230701: Migrate Scribunto to stop using MediaWikiIntegrationTestCase on unit tests) That made Scribunto tests 40% faster (from ~2 minutes to 1). One big issue is if we add Scribunto to gate, since Wikibase is already there, Wikibase client scribunto tests also will be ran which are 329 more tests (1 more minute on my laptop).

Mon, Sep 2, 11:13 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Continuous-Integration-Config, MediaWiki-extensions-Scribunto, Wikidata
Ladsgroup closed T230701: Migrate Scribunto to stop using MediaWikiIntegrationTestCase on unit tests, a subtask of T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min, as Resolved.
Mon, Sep 2, 11:11 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Testing, Continuous-Integration-Config
Ladsgroup closed T230701: Migrate Scribunto to stop using MediaWikiIntegrationTestCase on unit tests, a subtask of T229180: Migrate extensions to stop using MediaWikiIntegrationTestCase on unit tests, as Resolved.
Mon, Sep 2, 11:11 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MediaWiki-extensions-General, Release-Engineering-Team (Code Health), Code-Health
Ladsgroup closed T230701: Migrate Scribunto to stop using MediaWikiIntegrationTestCase on unit tests as Resolved.
Mon, Sep 2, 11:11 AM · User-Ladsgroup, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-Scribunto, Code-Health
Ladsgroup moved T231799: LuaWikibaseEntityLibraryTest: CI failing en masse from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Sep 2, 11:04 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-Scribunto, Wikidata
Ladsgroup triaged T231799: LuaWikibaseEntityLibraryTest: CI failing en masse as Unbreak Now! priority.

Can't merge anything on Wikibase = UBN

Mon, Sep 2, 11:04 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-Scribunto, Wikidata
Ladsgroup moved T231666: EntitySourceDocumentUrlProviderTest fails on Travis CI from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Sep 2, 9:57 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T189427: Add monolingual language code peo (Old Persian) from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Sep 2, 9:50 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), patch-welcome, good first bug, MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup moved T198366: Add monolingual language code kld (Gamilaraay) from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Sep 2, 9:50 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Community-consensus-needed, patch-welcome, good first bug, MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup moved T230145: Add monolingual language code TLI (Tlingit) from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Sep 2, 9:50 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T222020: Add monolingual language code clc (Tsilhqotʹin) from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Sep 2, 9:50 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T190981: Add monolingual language code alc from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Sep 2, 9:50 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T225055: Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_BOTH from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Sep 2, 9:46 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing

Sat, Aug 31

Ladsgroup committed rELUA248dcae392ef: Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase (authored by Ladsgroup).
Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase
Sat, Aug 31, 1:53 PM