Page MenuHomePhabricator

Drop gb_by from globalblocks table
Closed, ResolvedPublic

Description

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalBlocking/+/1054403/9/sql/mysql/patch-globalblocks-drop-gb_by.sql
  2. Where to run those changes: centralauth database (s7)
  3. When to run those changes: When DBA has time
  4. If the schema change is backwards compatible: No.
  5. If the schema change has been tested already on some of the test/beta wikis: has been applied to beta cluster
  6. If the data should be made available on the labs replicas and/or dumps: No changes needed

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ABran-WMF triaged this task as Low priority.
ABran-WMF moved this task from Triage to Ready on the DBA board.

CC @Ottomata @Milimetric please have a look at this schema change.

Please let me know what the risks and impact are of the change.

@Zabe @ABran-WMF Who currently uses this table? Do we know how the breaking change will effect them? Please also share more information about why this work is needed and what the potential timeline could be. Thank you!

I'll let @Milimetric comment on if DPE sqoops globalblocks table. I would guess that we don't?

We do not currently use globalblocks anywhere I know of or searched.

Thank you @Milimetric for reviewing. I will untag Data Products since there seem to be no dependencies for us.

Just to be clear, can this be done or is it blocked on something?

This can be done from my perspective.

Nothing is writing to that column for quite some time, nothing seems to be using it from a codesearch perspective and nothing broke.

Mentioned in SAL (#wikimedia-operations) [2024-07-29T10:20:13Z] <marostegui> Deploy schema change on s7 eqiad master with replication dbmaint T370394

This is done

#    /home/marostegui/section s7 | grep -v clouddb1021  | while read host port; do echo "$host"; db-mysql $host:$port centralauth -e "show create table globalblocks\G" | grep -iw gb_by; done
dbstore1008.eqiad.wmnet
db2220.codfw.wmnet
db2218.codfw.wmnet
db2208.codfw.wmnet
db2200.codfw.wmnet
db2198.codfw.wmnet
db2187.codfw.wmnet
db2182.codfw.wmnet
db2168.codfw.wmnet
db2159.codfw.wmnet
db2150.codfw.wmnet
db2122.codfw.wmnet
db2121.codfw.wmnet
db1236.eqiad.wmnet
db1227.eqiad.wmnet
db1202.eqiad.wmnet
db1194.eqiad.wmnet
db1191.eqiad.wmnet
db1181.eqiad.wmnet
db1174.eqiad.wmnet
db1171.eqiad.wmnet
db1170.eqiad.wmnet
db1158.eqiad.wmnet
db1155.eqiad.wmnet
clouddb1018.eqiad.wmnet
clouddb1014.eqiad.wmnet
an-redacteddb1001.eqiad.wmnet
Marostegui claimed this task.
Marostegui added a subscriber: ABran-WMF.