Page MenuHomePhabricator
Create Task
Maniphest T371052

FlaggedRevs: RecentChanges filters no longer work
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
No changes are displayed.

What should have happened instead?:
There should be some changes listed - the ones that satisfy the selected criteria.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
When opening RC with a link with flaggedrevs filter already applied, an InvalidArgumentException is thrown ( https://pl.m.wikipedia.org/w/index.php?hidebots=1&hidecategorization=1&hideWikibase=1&flaggedrevs=needreview&limit=500&days=30&enhanced=1&title=Specjalna:Ostatnie_zmiany&urlversion=2&uselang=en )

Screenshot_20240725_214222_Edge.jpg (588×1 px, 90 KB)

If possible, please revert the faulty change, it severely breaks patrolling on wikis with FR enabled.

Details

MediaWiki Version
1.43.0-wmf.15
Request URL
https://pl.m.wikipedia.org/w/index.php?hidebots=1&hidecategorization=1&hideWikibase=1&flaggedrevs=needreview&limit=500&days=30&enhanced=1&title=Specjalna:Ostatnie_zmiany&urlversion=2&uselang=en
SubjectRepoBranchLines +/-
Use expression builder instead of raw sqlmediawiki/extensions/FlaggedRevsmaster+90 -18
Revert "Use expression builder to avoid IDatabase::makeList"mediawiki/extensions/FlaggedRevsmaster+6 -8
Revert "Use expression builder to avoid IDatabase::makeList"mediawiki/extensions/FlaggedRevswmf/1.43.0-wmf.15+6 -8
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasebrennenT366961 1.43.0-wmf.16 deployment blockers
 ResolvedPRODUCTION ERRORUmherirrenderT371052 FlaggedRevs: RecentChanges filters no longer work

Event Timeline

Msz2001 created this task.Jul 25 2024, 7:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2024, 7:45 PM
Tacsipacsi changed the subtype of this task from "Bug Report" to "Production Error".Jul 25 2024, 8:07 PM
Restricted Application added a project: Wikimedia-production-error. · View Herald TranscriptJul 25 2024, 8:07 PM
Tacsipacsi set Request URL to https://pl.m.wikipedia.org/w/index.php?hidebots=1&hidecategorization=1&hideWikibase=1&flaggedrevs=needreview&limit=500&days=30&enhanced=1&title=Specjalna:Ostatnie_zmiany&urlversion=2&uselang=en.Jul 25 2024, 8:09 PM
Tacsipacsi set Release Version to 1.43.0-wmf.15.
Tacsipacsi subscribed.
gerritbot added a comment.Jul 25 2024, 8:25 PM

Change #1057011 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Revert "Use expression builder to avoid IDatabase::makeList"

https://gerrit.wikimedia.org/r/1057011

gerritbot added a project: Patch-For-Review.Jul 25 2024, 8:25 PM

Change #1057012 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@wmf/1.43.0-wmf.15] Revert "Use expression builder to avoid IDatabase::makeList"

https://gerrit.wikimedia.org/r/1057012

Umherirrender merged a task: T371058: InvalidArgumentException on pages with Special:RelatedChanges transcluded.Jul 25 2024, 8:44 PM
Umherirrender added subscribers: stjn, Base.
stjn merged a task: T371058: InvalidArgumentException on pages with Special:RelatedChanges transcluded.Jul 25 2024, 8:46 PM
Ladsgroup subscribed.Jul 25 2024, 10:34 PM

I suggest merging the backport but not the patch on master. That'd make things easier and give you enough time to make proper fix.

gerritbot added a comment.Jul 25 2024, 10:44 PM

Change #1057012 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.43.0-wmf.15] Revert "Use expression builder to avoid IDatabase::makeList"

https://gerrit.wikimedia.org/r/1057012

Stashbot added a comment.Jul 25 2024, 10:46 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-25T22:46:07Z] <ladsgroup@deploy1002> Started scap sync-world: Backport for [[gerrit:1057012|Revert "Use expression builder to avoid IDatabase::makeList" (T371052)]]

Stashbot added a comment.Jul 25 2024, 10:48 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-25T22:48:30Z] <ladsgroup@deploy1002> ladsgroup, umherirrender: Backport for [[gerrit:1057012|Revert "Use expression builder to avoid IDatabase::makeList" (T371052)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jul 25 2024, 10:56 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-25T22:56:15Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:1057012|Revert "Use expression builder to avoid IDatabase::makeList" (T371052)]] (duration: 10m 08s)

Ladsgroup triaged this task as High priority.Jul 25 2024, 10:59 PM

Not merged on master

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 25 2024, 11:00 PM
Wargo subscribed.Jul 26 2024, 8:28 AM
gerritbot added a comment.Jul 26 2024, 10:24 AM

Change #1055612 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Use expression builder instead of raw sql

https://gerrit.wikimedia.org/r/1055612

gerritbot added a comment.Jul 26 2024, 10:25 AM

Change #1057011 abandoned by Umherirrender:

[mediawiki/extensions/FlaggedRevs@master] Revert "Use expression builder to avoid IDatabase::makeList"

Reason:

Added a test to Iffbe09e07f9a58aeddc360f10aa44c68c4410e14

https://gerrit.wikimedia.org/r/1057011

Umherirrender added a parent task: T366961: 1.43.0-wmf.16 deployment blockers.Jul 26 2024, 10:26 AM
gerritbot added a comment.Jul 26 2024, 11:57 AM

Change #1055612 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Use expression builder instead of raw sql

https://gerrit.wikimedia.org/r/1055612

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.16; 2024-07-30); removed MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 26 2024, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 26 2024, 12:30 PM
Umherirrender closed this task as Resolved.Jul 26 2024, 2:03 PM
Umherirrender claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits