docs: Version banner doesn't work on branch deploy previews
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	AnneT
	Aug 13 2024, 4:36 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The beta tag is present in the header and the version banner shows the beta site message:

What should have happened instead?:

You should not see the beta tag, and the message should reference that this is a branch deploy with a link to said patch:

Software version: Codex v1.10.0

	Subject	Repo	Branch	Lines +/-
	Update Codex from v1.11.1 to v1.12.0	mediawiki/core	master	+1 K -101
	Fix variable passing in branch-deploy.sh	design/codex	main	+1 -3

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@AnneT just to confirm, this is a regression right? It used to work properly and broke recently?

@CCiufo-WMF correct; I'm not sure when it last worked properly but it did at one point

CCiufo-WMF triaged this task as Medium priority.Aug 20 2024, 6:13 PM

CCiufo-WMF moved this task from Inbox to Up Next on the Design-System-Team board.

Change #1064128 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] Fix variable passing in branch-deploy.sh

AnneT closed this task as Resolved.Aug 21 2024, 12:55 PM

Change #1064128 merged by jenkins-bot:

[design/codex@main] Fix variable passing in branch-deploy.sh

Change #1070656 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v1.11.1 to v1.12.0

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/6bc5837bc4/w/

Change #1070656 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.11.1 to v1.12.0