Jdforrester-WMF (James D. Forrester)
Lead Product Manager, Contributors

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:08 PM (218 w, 6 d)
Availability
Available
IRC Nick
James_F
LDAP User
Jforrester
MediaWiki User
Jdforrester (WMF) [ Global Accounts ]

I've been a Wikipedia editor since 2002 on the English Wikipedia and a few other Wikimedia projects (see my personal account). In May 2012 I joined the Wikimedia Foundation as the "Product Manager" for the VisualEditor Team (now called the Editing-team). I'm now the Lead Product Manager for the Contributors-Team.

Recent Activity

Today

Jdforrester-WMF moved T211927: SnakDeserializer must apply ID prefix mapping from To Do to Monitoring on the SDC Engineering board.
Mon, Dec 17, 5:17 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Wikibase-DataModel-Serialization, SDC Engineering, Wikidata
Jdforrester-WMF assigned T204934: Use OOUI Layouts instead of table to display/edit multi-lingual captions on File page to Cparle.
Mon, Dec 17, 5:14 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Multimedia-Team-Working-Board, SDC Engineering, Multimedia, Wikidata, Technical-Debt
Jdforrester-WMF created T212138: Beta Cluster Commons searches on NS0 all fail (due to Wikibase federation?).
Mon, Dec 17, 5:13 PM · Wikidata, SDC Engineering
Jdforrester-WMF edited projects for T196208: Provide localized Bold and Italic icons for Urdu, added: OOUI (OOUI-0.30.0); removed Patch-For-Review, OOUI.

Thank you, @Tulsi_Bhagat and @Esanders. This will roll out in the next release of OOUI.

Mon, Dec 17, 4:48 PM · OOUI (OOUI-0.30.0), WikiEditor
Jdforrester-WMF committed rEWBIe8d6a3c877c0: File page captions: Shift edit button, don't show line after last caption (authored by Jdforrester-WMF).
File page captions: Shift edit button, don't show line after last caption
Mon, Dec 17, 4:46 PM
Jdforrester-WMF added a comment to T211994: Disable API modules that won't be used by Wikibase on Commons.

This is a dupe of T207683, right?

Mon, Dec 17, 11:55 AM · Multimedia, Multimedia-Team-Working-Board, MediaWiki-extensions-WikibaseMediaInfo

Fri, Dec 14

Jdforrester-WMF added a comment to T211800: Resolve ambiguity of entity ID prefixes used on Commons..

Option 3 sounds sanest in terms of fixing/avoiding the issue without a costly migration.

Fri, Dec 14, 1:26 AM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons

Thu, Dec 13

Jdforrester-WMF removed a project from T208246: Change password length requirement and ensure enforcement for privileged users (from 8 to 10): Patch-For-Review.

This is now live in production for privileged groups (in nag-mode for existing passwords, and enforcing for new passwords).

Thu, Dec 13, 11:59 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), MediaWiki-User-login-and-signup
Jdforrester-WMF removed a project from T211801: Find out how to deploy MediaInfo without breaking Commons: Patch-For-Review.
Thu, Dec 13, 9:17 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MediaWiki-extensions-WikibaseMediaInfo, SDC Engineering
Jdforrester-WMF removed a project from T202094: Deprecate Title::getUserCaseDBKey(): Patch-For-Review.

Soft deprecation done. Next is removal from use in Wikimedia production, then hard deprecation, then removal (in MW 1.35 if we get the rest done by MW 1.33).

Thu, Dec 13, 9:08 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), User-D3r1ck01, Core Platform Team ( Code Health (TEC13)), Core Platform Team Backlog (Next), MediaWiki-General-or-Unknown
Jdforrester-WMF removed a project from T204748: Create Federated Wikibase instance on Beta Commons: Patch-For-Review.

Local look-ups still work:

Thu, Dec 13, 7:02 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, SDC Engineering, Wikidata
Jdforrester-WMF added a comment to T204748: Create Federated Wikibase instance on Beta Commons.

Now done, with a prefix:

Thu, Dec 13, 6:57 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, SDC Engineering, Wikidata
Jdforrester-WMF merged T211911: Page down at https://doc.wikimedia.org/oojs-ui/master/demos/ into T206046: Host OOUI PHP demo (and all others?) on a PHP 7 capable server, because it needs PHP 7.
Thu, Dec 13, 6:50 PM · OOUI, Continuous-Integration-Infrastructure
Jdforrester-WMF merged task T211911: Page down at https://doc.wikimedia.org/oojs-ui/master/demos/ into T206046: Host OOUI PHP demo (and all others?) on a PHP 7 capable server, because it needs PHP 7.
Thu, Dec 13, 6:50 PM · OOUI
Jdforrester-WMF added a comment to T211911: Page down at https://doc.wikimedia.org/oojs-ui/master/demos/.

Yes, https://doc.wikimedia.org/oojs-ui/master/php/ hasn't worked for since September.

Thu, Dec 13, 6:50 PM · OOUI
Jdforrester-WMF moved T211834: "Insert row" adding as a header row for certain tables from Code review to QA on the VisualEditor (Current work) board.
Thu, Dec 13, 5:03 PM · Verified, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), VisualEditor (Current work), goodfirstbug, VisualEditor-Tables

Wed, Dec 12

Jdforrester-WMF renamed T187716: Sunset Wikipedia Zero from Sunset Wikipedia Zero (tracking) to Sunset Wikipedia Zero.
Wed, Dec 12, 11:46 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog, Wikimedia-Site-requests
Jdforrester-WMF added a project to T187716: Sunset Wikipedia Zero: Reading-Infrastructure-Team-Backlog.

Cookie-licking this for the Infrastructure team.

Wed, Dec 12, 11:45 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog, Wikimedia-Site-requests
Jdforrester-WMF added a comment to T143927: Per Family Unique Devices Counts .

This looks done:

Wed, Dec 12, 7:44 PM · Analytics-Kanban
Jdforrester-WMF assigned T204264: Add displaying/editing statements to File page to Cparle.

Cormac is working on this.

Wed, Dec 12, 6:49 PM · SDC Engineering, Multimedia-Team-Working-Board, Multimedia, Wikidata
Jdforrester-WMF added a comment to T211156: Review EditAttemptStep validation failures in production.

Sorry, have updated the link to be a proper one that should last: https://logstash.wikimedia.org/app/kibana#/dashboard/default?_g=(refreshInterval%3A(display%3AOff%2Cpause%3A!f%2Cvalue%3A0)%2Ctime%3A(from%3Anow-7d%2Cmode%3Aquick%2Cto%3Anow))

Wed, Dec 12, 5:44 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Product-Analytics, Contributors-Analysis
Jdforrester-WMF renamed T211156: Review EditAttemptStep validation failures in production from Review EditAttempStep validation failures in production to Review EditAttemptStep validation failures in production.
Wed, Dec 12, 5:43 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Product-Analytics, Contributors-Analysis
Jdforrester-WMF committed rEWBIa1f61c56de78: tests: Test moving the captions block on the File page (authored by Cparle).
tests: Test moving the captions block on the File page
Wed, Dec 12, 4:38 PM
Jdforrester-WMF closed T211134: Backfill unit tests for T205891 as Resolved.

Code-only change.

Wed, Dec 12, 4:37 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), SDC Engineering, Multimedia-Team-Working-Board, Multimedia
Jdforrester-WMF moved T211134: Backfill unit tests for T205891 from Doing to Sign off on the SDC Engineering board.
Wed, Dec 12, 4:37 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), SDC Engineering, Multimedia-Team-Working-Board, Multimedia
Jdforrester-WMF created T211785: Upgrade the mobileapps CI job from npm3 to npm6.
Wed, Dec 12, 4:32 PM · Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, JavaScript, Continuous-Integration-Config
Jdforrester-WMF created T211784: Upgrade all CI jobs from npm3 to npm6 across all projects.
Wed, Dec 12, 4:32 PM · JavaScript, Continuous-Integration-Config

Tue, Dec 11

Jdforrester-WMF added a comment to T211689: `scap prep 1.33-wmf.8` failed.

Can we delete all the 1.33-wmf.8 branches? They're cluttering up auto-completes etc..

Tue, Dec 11, 10:36 PM · Scap, Release-Engineering-Team (Kanban), User-zeljkofilipin
Jdforrester-WMF moved T207897: VisualEditor doesn't filter out deprecated template parameters from Code review to QA on the VisualEditor (Current work) board.
Tue, Dec 11, 8:45 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), VisualEditor (Current work), VisualEditor-MediaWiki-Templates
Jdforrester-WMF moved T211134: Backfill unit tests for T205891 from To Do to Doing on the SDC Engineering board.
Tue, Dec 11, 7:34 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), SDC Engineering, Multimedia-Team-Working-Board, Multimedia
Jdforrester-WMF edited projects for T189148: "donut-container" <div> added in every <ref>, added: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed Patch-For-Review.
Tue, Dec 11, 7:34 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-MediaWiki
Jdforrester-WMF moved T210686: [Regression pre-wmf.8] Typing in any fields for Cite>Web/Book etc. disables the "Insert" field from External to Doing on the Cite board.
Tue, Dec 11, 7:32 PM · User-Ryasmeen, VisualEditor-MediaWiki-References, Cite, VisualEditor (Current work), Verified, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11)
Jdforrester-WMF removed a project from T211052: SlotRoleHandler's introduction breaks WBMI; edits now fail with "content is not allowed on page" error: Patch-For-Review.

Now that T211237 is resolved, this is fixed in Beta too:

Tue, Dec 11, 7:31 PM · Core Platform Team Backlog (Watching / External), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Core Platform Team (MCR), SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo
Jdforrester-WMF assigned T211707: [wmf.8-regression] Flow pages - "Cannot read property 'trim' of undefined" crashes the page to Esanders.

Now hot-deployed to production. Seems fixed to me.

Tue, Dec 11, 7:30 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Regression, Growth-Team
Jdforrester-WMF archived MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).
Tue, Dec 11, 7:29 PM
Jdforrester-WMF edited projects for T209619: Broken "HON" browser plug-in causes content corruption when editing, added: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review.
Tue, Dec 11, 7:29 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), VisualEditor (Current work), VisualEditor-MediaWiki
Jdforrester-WMF reopened T204748: Create Federated Wikibase instance on Beta Commons as "Open".

@daniel can give more details about the inner parts of Wikibase, but we had to disable this to unbreak WBMI :-(

Tue, Dec 11, 7:26 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, SDC Engineering, Wikidata
Jdforrester-WMF moved T211237: wbgetentities has stopped returning content on Beta Cluster Commons from Doing to Sign off on the SDC Engineering board.
Tue, Dec 11, 7:26 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo, Wikidata
Jdforrester-WMF closed T211237: wbgetentities has stopped returning content on Beta Cluster Commons as Resolved.

Marking as Resolved. Will re-open T204748 instead, pending on Daniel's comments about needing to change things in Wikibase. :-(

Tue, Dec 11, 7:25 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo, Wikidata
Jdforrester-WMF moved T197242: Transition citoid to use Zotero's translation-server-v2 from In progress to Product owner review on the VisualEditor (Current work) board.
Tue, Dec 11, 6:03 PM · Patch-For-Review, Services (done), VisualEditor (Current work), Citoid, Operations
Jdforrester-WMF added a comment to T197242: Transition citoid to use Zotero's translation-server-v2.

🎉

Tue, Dec 11, 6:02 PM · Patch-For-Review, Services (done), VisualEditor (Current work), Citoid, Operations
Jdforrester-WMF added a comment to T211707: [wmf.8-regression] Flow pages - "Cannot read property 'trim' of undefined" crashes the page.

E.g. https://www.mediawiki.org/wiki/Project:Support_desk

Tue, Dec 11, 5:39 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Regression, Growth-Team
Jdforrester-WMF added a comment to T211237: wbgetentities has stopped returning content on Beta Cluster Commons.

I have a suspicion about this, but I want to dig some more to confirm. But if I am correct, this never worked on beta, at least not with MediaInfo in slots, with the config that is there now.

@Jdforrester-WMF is it possible that you remember this working on the dedicated labs test instance, but not on beta? That would be consistent with my idea of what is going on.

Tue, Dec 11, 5:01 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo, Wikidata
Jdforrester-WMF added a comment to T211323: The Chinese Wikivoyage mobile version only shows part of the map; some tiles remain white/blank (due to local incorrect CSS).

This also works in safemode – https://zh.m.wikivoyage.org/wiki/%E7%AB%B9%E5%8C%97?safemode=1 – so it's probably a site script/default gadget that's broken.

Tue, Dec 11, 4:48 PM · Reading-Web-Local-Wiki-Issues, MinervaNeue (Tracking), Maps (Kartographer), Chinese-Sites

Mon, Dec 10

Jdforrester-WMF removed a project from T211444: Scraped description text of images shows remnants of CSS transforms in MediaViewer: Patch-For-Review.
Mon, Dec 10, 10:58 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Multimedia, MediaWiki-extensions-MultimediaViewer
Jdforrester-WMF triaged T211237: wbgetentities has stopped returning content on Beta Cluster Commons as Unbreak Now! priority.

Sorry, good point.

Mon, Dec 10, 10:00 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo, Wikidata
Jdforrester-WMF added a comment to T211237: wbgetentities has stopped returning content on Beta Cluster Commons.

If this becomes urgent, I could probably dig in. I'd need good justification to spend time on this, though. In theory, this should be handled by the Wikidata team. On the other hand, there's a non-zero chance that this is something I screwed up :)

Mon, Dec 10, 8:38 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo, Wikidata
Jdforrester-WMF removed a project from T211527: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672: Patch-For-Review.
Mon, Dec 10, 8:37 PM · Core Platform Team Backlog (Watching / External), Parsing-Team
Jdforrester-WMF added a comment to T211527: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672.

Now de-deployed.

Mon, Dec 10, 8:37 PM · Core Platform Team Backlog (Watching / External), Parsing-Team
Jdforrester-WMF added a comment to T211527: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672.

We anticipated that ParserMigration will have to be disabled at some point and I had specifically asked on enwiki about this ( https://en.wikipedia.org/wiki/Wikipedia_talk:Linter#Question_about_ParserMigration_extension ). I think we can disable that extension for now.

Mon, Dec 10, 8:19 PM · Core Platform Team Backlog (Watching / External), Parsing-Team
Jdforrester-WMF added a comment to T207418: Replace jQuery functions with native equivalents.

Done in 434432324ff0ffd12718a90d9a7943eb5155f145 ish, right?

Mon, Dec 10, 7:06 PM · Patch-For-Review, Performance, OOUI
Jdforrester-WMF removed a project from T211576: Cite silently ignores all parameters in <ref> with more than two parameters: Patch-For-Review.
Mon, Dec 10, 6:24 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Need-volunteer, User-notice, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Cite
Jdforrester-WMF removed a project from T211516: Error pasting nested lists from macOS Notes app: Patch-For-Review.
Mon, Dec 10, 6:14 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), VisualEditor (Current work), VisualEditor-CopyPaste
Jdforrester-WMF added a comment to T203727: Restructure and improve 'Basic information' section.

What does "View global account info" do?

Mon, Dec 10, 6:08 PM · Patch-For-Review, UI-Standardization, MediaWiki-User-preferences
Jdforrester-WMF closed T211527: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672 as Resolved.

So this is now fixed by emergency-disabling the extension. I've written the patches to de-deploy it, but I'll wait for sign-off from the team that this was an intended consequence of their work. https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/478726/

Mon, Dec 10, 5:35 PM · Core Platform Team Backlog (Watching / External), Parsing-Team
Jdforrester-WMF added a comment to T211527: Notice: Undefined variable: wgTidyConf in /srv/mediawiki/wmf-config/CommonSettings.php on line 3672.

Oops, should have remembered this; my fault, sorry.

Mon, Dec 10, 5:24 PM · Core Platform Team Backlog (Watching / External), Parsing-Team
Jdforrester-WMF assigned T211516: Error pasting nested lists from macOS Notes app to cllu.
Mon, Dec 10, 4:41 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), VisualEditor (Current work), VisualEditor-CopyPaste
Jdforrester-WMF moved T211515: Flow widgets lose focus styling after using an inspector from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Mon, Dec 10, 4:36 PM · Editing QA, VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Growth-Team, StructuredDiscussions
Jdforrester-WMF assigned T211515: Flow widgets lose focus styling after using an inspector to Esanders.
Mon, Dec 10, 4:36 PM · Editing QA, VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Growth-Team, StructuredDiscussions
Jdforrester-WMF moved T211133: WikibaseMediaInfo needs a basic integration test suite asap from To Do to Doing on the SDC Engineering board.
Mon, Dec 10, 4:12 PM · Patch-For-Review, Technical-Debt, SDC Engineering, Multimedia-Team-Working-Board, Multimedia
Jdforrester-WMF moved T211237: wbgetentities has stopped returning content on Beta Cluster Commons from To Do to Doing on the SDC Engineering board.
Mon, Dec 10, 4:11 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo, Wikidata
Jdforrester-WMF moved T205444: Provide a way of having a meaningful slot header from To Do to Monitoring on the SDC Engineering board.
Mon, Dec 10, 3:48 PM · SDC Engineering, Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR)
Jdforrester-WMF added a project to T205444: Provide a way of having a meaningful slot header: SDC Engineering.
Mon, Dec 10, 3:48 PM · SDC Engineering, Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR)
Jdforrester-WMF closed T208769: Ensure that AbuseFilter applies to the content of all MCR slots as Resolved.
Mon, Dec 10, 3:36 PM · Core Platform Team Kanban (Done with CPT), AbuseFilter, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering
Jdforrester-WMF closed T208769: Ensure that AbuseFilter applies to the content of all MCR slots, a subtask of T189220: Ensure that relevant extensions are MCR-aware, as Resolved.
Mon, Dec 10, 3:35 PM · Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), Core Platform Team Backlog (Epic), Epic, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23))
Jdforrester-WMF closed T208769: Ensure that AbuseFilter applies to the content of all MCR slots, a subtask of T204582: Verify that abuse-/spam-related extensions work with Wikibase MediaInfo, as Resolved.
Mon, Dec 10, 3:35 PM · SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo, Wikidata, SDC General

Fri, Dec 7

Jdforrester-WMF added a comment to T211305: Preference for page-previews default incorrect when resetting preferences.

Perhaps, though a date comparison is a little slow. We could do what we did for enabling the visual editor – backfill opt-outs for the small number of accounts that have edited in the past year and then change the default. But it's fiddly.

Fri, Dec 7, 9:40 PM · User-TheDJ, Readers-Web-Backlog, MediaWiki-User-preferences, Page-Previews
Jdforrester-WMF committed rEWBI7d241fa2ca0c: Add an integration test set (authored by Cparle).
Add an integration test set
Fri, Dec 7, 7:40 PM
Jdforrester-WMF added a comment to T211243: Add a useful call-to-action in the context for citation needed templates.

"An editor has suggested that this needs a citation. Do you have one?" // "Replace with a citation" maybe?

Fri, Dec 7, 7:33 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki
Jdforrester-WMF committed rEWBIf3d9d1288353: Integration tests (authored by Cparle).
Integration tests
Fri, Dec 7, 7:29 PM
Jdforrester-WMF created T211444: Scraped description text of images shows remnants of CSS transforms in MediaViewer.
Fri, Dec 7, 7:09 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Multimedia, MediaWiki-extensions-MultimediaViewer
Jdforrester-WMF added a comment to T208188: Proposal for partial opt-out method for Content security policy.

Another option is to not do this work. I don't see a good justification for letting any users bypass CSP.

Making it effectively impossible to call to ToolForge from gadgets seriously diminishes the usefulness of ToolForge.

Fri, Dec 7, 6:33 PM · TechCom-RFC, TechCom, Security-Team, Security
Jdforrester-WMF added a comment to T125657: Gray used in .autocomment in RC and watchlist is not accessible against background and hinders link discovery.

Absolutely. The two standard design affordances on the Web for "this a thing you can click and it will change the page somehow" are blue coloured text with a hover underline effect, and a graphical representation (to some level of abstraction) of a button. This discussion is proposing doing neither of those things.

Fri, Dec 7, 6:24 PM · MediaWiki-Commenting, Growth-Team, UI-Standardization-Kanban, UI-Standardization, MediaWiki-History-or-Diffs, MediaWiki-Recent-changes, MediaWiki-Watchlist, Accessibility
Jdforrester-WMF added a comment to T160101: Upgrade php5-json .deb to at least 1.3.8.

We don't use PHP 5.x anywhere anymore. Is this still relevant or can we close?

Fri, Dec 7, 6:20 PM · Operations, Packaging
Jdforrester-WMF triaged T108796: Move namespace name localisation to JSON as Low priority.
Fri, Dec 7, 6:16 PM · MediaWiki-Internationalization
Jdforrester-WMF added a comment to T125657: Gray used in .autocomment in RC and watchlist is not accessible against background and hinders link discovery.

Yes, anything that relies on interaction before revealing itself to be a link is not discoverable for people on touch devices [...] That means that any system that only shows the link via some form of interactive element – be that :hover, :focus, or :active – is insufficient.

On the other hand, that depends on the extent to which immediate discoverability is necessary.

Fri, Dec 7, 6:07 PM · MediaWiki-Commenting, Growth-Team, UI-Standardization-Kanban, UI-Standardization, MediaWiki-History-or-Diffs, MediaWiki-Recent-changes, MediaWiki-Watchlist, Accessibility
Jdforrester-WMF added a comment to T211243: Add a useful call-to-action in the context for citation needed templates.

WFM. Maybe "citationNeededInline" vs. "citationNeededEncapsulate" for https://en.wikipedia.org/wiki/Template:Citation_needed_span ?

Fri, Dec 7, 5:33 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki
Jdforrester-WMF added a comment to T211420: Rollback extension-UploadLocal to 4bade11.

Thank you for checking @Jdforrester-WMF .- I'll have some work down the line soon today I hope.

Re. git push: it was my fault. I enabled it because git-review blocked the submission because it had more than 10 patches. I thought git push would bypass that, and indeed it did, but I didn't realised that meant going straight to the codebase instead to the review queue - won't happen again.

Do we have a way to commit more than 10 patches at once with git review?

Fri, Dec 7, 5:29 PM · User-MarcoAurelio, Patch-For-Review, Gerrit
Jdforrester-WMF merged T208475: chem equations cut off into T166380: Larger chemical formula are not displayed correctly in block mode.
Fri, Dec 7, 4:22 PM · VisualEditor, Math, Mathoid
Jdforrester-WMF merged task T208475: chem equations cut off into T166380: Larger chemical formula are not displayed correctly in block mode.
Fri, Dec 7, 4:22 PM · Math
Jdforrester-WMF reopened T166380: Larger chemical formula are not displayed correctly in block mode as "Open".
Fri, Dec 7, 4:22 PM · VisualEditor, Math, Mathoid
Jdforrester-WMF closed T211420: Rollback extension-UploadLocal to 4bade11 as Resolved.
Fri, Dec 7, 4:21 PM · User-MarcoAurelio, Patch-For-Review, Gerrit
Jdforrester-WMF added a comment to T211420: Rollback extension-UploadLocal to 4bade11.
~/D/c/a/UploadLocal   master  git log -n 1                                                  Fri  7 Dec 08:19:39 2018
commit 08c2f76ff87466bd3cc63d38abeb8efc0afd8907 (HEAD -> master, origin/master)
Author: MarcoAurelio <maurelio@tools.wmflabs.org>
Date:   2018-12-07 14:22:26 +0100
Fri, Dec 7, 4:21 PM · User-MarcoAurelio, Patch-For-Review, Gerrit
Jdforrester-WMF closed T33780: WikiEditor dialogs kill the undo buffer as Resolved.

Worked around for everyone except Firefox. Hopefully Mozilla will eventually fix that issue, but our work here is done.

Fri, Dec 7, 4:02 PM · User-TheDJ, Patch-For-Review, User-Ryasmeen, Browser-Support-Internet-Explorer, Browser-Support-Google-Chrome, Upstream, WikiEditor

Thu, Dec 6

Jdforrester-WMF added a comment to T125657: Gray used in .autocomment in RC and watchlist is not accessible against background and hinders link discovery.

Just to make sure it wasn't missed, in the other ticket @Jdforrester-WMF raised a concern with using :hover being problematic for people on touch devices in T165189#4790357 but I believe @stjn addressed his concern T165189#4790562 by noting that it's not just hover, it's any active states including :focus and :active.

@stjn I just tested .autocomment, .autocomment a:not(:hover):not(:focus):not(:active) and I kind of like that..

I played with it a bit and like it as well. I can't speak for whether it meets our accessibility needs/standards though.

Thu, Dec 6, 10:14 PM · MediaWiki-Commenting, Growth-Team, UI-Standardization-Kanban, UI-Standardization, MediaWiki-History-or-Diffs, MediaWiki-Recent-changes, MediaWiki-Watchlist, Accessibility
Jdforrester-WMF added a comment to T211379: Let me visit a red-linked page without opening the editor.

This isn't the behaviour on non-VE MediaWiki installations: https://wikitech.wikimedia.org/w/index.php?title=Dell_PowerEdge_1950&action=edit&redlink=1

Thu, Dec 6, 9:40 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Jdforrester-WMF added a comment to T211156: Review EditAttemptStep validation failures in production.

@Jdforrester-WMF It appears this is a task for @Neil_P._Quinn_WMF to keep an eye on, but not an analysis request. Is that correct? Moving to our Tracking column for now.

Thu, Dec 6, 9:36 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Product-Analytics, Contributors-Analysis
Jdforrester-WMF added a comment to T208188: Proposal for partial opt-out method for Content security policy.

Another option is to not do this work. I don't see a good justification for letting any users bypass CSP. The ones who will complain the most about this are also the ones who shouldn't be allowed (sysops, interface admins, stewards, …). Yes, toolforge has a number of neat tools, but this is proposing a lot of fiddly work which I don't think adds value.

Thu, Dec 6, 9:36 PM · TechCom-RFC, TechCom, Security-Team, Security
Jdforrester-WMF added a subtask for T211242: Move TitleBlacklist error handling code from VE to TitleBlacklist : T211157: Allow VE plugins to handle save errors generated by extensions.
Thu, Dec 6, 8:38 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), User-Ryasmeen, VisualEditor, TitleBlacklist, VisualEditor-MediaWiki
Jdforrester-WMF added a parent task for T211157: Allow VE plugins to handle save errors generated by extensions: T211242: Move TitleBlacklist error handling code from VE to TitleBlacklist .
Thu, Dec 6, 8:38 PM · Editing QA, Technical-Debt, VisualEditor-MediaWiki, VisualEditor (Current work)
Jdforrester-WMF added a comment to T211237: wbgetentities has stopped returning content on Beta Cluster Commons.

The only place this is configured (I thought) is https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings-labs.php where 'entityNamespaces' => [ 'mediainfo' => '6/mediainfo' ], is set for Commons; however it's also configured for baseUri to point to https://commons.wikimedia.beta.wmflabs.org/entity/ which doesn't currently dereference, so maybe that's it?

Thu, Dec 6, 4:14 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo, Wikidata
Jdforrester-WMF added a comment to T211305: Preference for page-previews default incorrect when resetting preferences.

Can't we somehow flip that logic around ? Seems more sane to me..
Get everyone currently not set to true, with a maintenance script, write them to false, configure default as true...

Thu, Dec 6, 4:06 PM · User-TheDJ, Readers-Web-Backlog, MediaWiki-User-preferences, Page-Previews
Jdforrester-WMF added a comment to T211052: SlotRoleHandler's introduction breaks WBMI; edits now fail with "content is not allowed on page" error.

The message is correct - wikibase-mediainfo is indeed not allowed in the Main slot. The question is, why is it trying to write mediainfo into the main slot?

Thu, Dec 6, 4:04 PM · Core Platform Team Backlog (Watching / External), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Core Platform Team (MCR), SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo
Jdforrester-WMF added a comment to T211305: Preference for page-previews default incorrect when resetting preferences.

This will be because (to avoid community members complaining), the preference for Page Previews is off by default (wgPopupsOptInDefaultState) on Wikipedias, and there's a special setting to over-ride that and set it on for new accounts (wgPopupsOptInStateForNewAccounts). Re-setting preferences doesn't trigger the "this is a brand-new account" hook (and rightly-so), so you lose the preference.

Thu, Dec 6, 4:03 PM · User-TheDJ, Readers-Web-Backlog, MediaWiki-User-preferences, Page-Previews
Jdforrester-WMF added a comment to T211052: SlotRoleHandler's introduction breaks WBMI; edits now fail with "content is not allowed on page" error.

So… my patch for this fixed it locally, but not on Beta Commons – content-not-allowed-here (e.g. "wikibase-mediainfo" content is not allowed on page File:Test-1445021196.521987.png in slot "Main") is still the error I get on trying to add a caption. Any ideas? Maybe related to T211237 brokeness?

Thu, Dec 6, 3:59 PM · Core Platform Team Backlog (Watching / External), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Core Platform Team (MCR), SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo
Jdforrester-WMF moved T210753: Better error msg display when AbuseFilter rejects captions from Doing to Sign off on the SDC Engineering board.
Thu, Dec 6, 3:57 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, SDC Engineering, Multimedia-Team-Working-Board, Multimedia
Jdforrester-WMF closed T211053: Error for file namespace should escape the title in the link as Resolved.
Thu, Dec 6, 3:57 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Core Platform Team (MCR), SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo
Jdforrester-WMF moved T211053: Error for file namespace should escape the title in the link from Doing to Sign off on the SDC Engineering board.
Thu, Dec 6, 3:57 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Core Platform Team (MCR), SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo
Jdforrester-WMF closed T123228: Include namespace information on action=info page as Resolved.

Thank you for your work!

Thu, Dec 6, 12:13 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Google-Code-in-2018, goodfirstbug, MediaWiki-General-or-Unknown

Wed, Dec 5

Jdforrester-WMF committed rEWBIce39b6a8975f: [Failing test] Assert that captions are trimmed on write (authored by Jdforrester-WMF).
[Failing test] Assert that captions are trimmed on write
Wed, Dec 5, 10:21 PM