Page MenuHomePhabricator

Jdforrester-WMF (James D. Forrester)
Software Engineer

Projects (62)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:08 PM (350 w, 23 h)
Availability
Available
IRC Nick
James_F
LDAP User
Jforrester
MediaWiki User
Jdforrester (WMF) [ Global Accounts ]

I've been a Wikipedia editor since 2002 on the English Wikipedia and a few other Wikimedia projects. In May 2012, I joined the Wikimedia Foundation as a "product manager", initially for VisualEditor, the the Editing Team, and later the lead product manager for all contribution. In 2018, I moved to be a software engineer, working on reliability, infrastructure, developer tooling, and continuous integration and deployment.

My job is to help ensure that the tools we provide to our readers and contributors are the best the can be, in speed, correctness, consistency, utility, and reliability.

Recent Activity

Tue, Jun 15

Jdforrester-WMF added a comment to T284563: Watchlist Expiry: enable by default in MediaWiki.

I think this is a mistake. Carrying the product debt of yet another feature flag is not something we should do based on supposition of the confusion caused by our own products.

Tue, Jun 15, 3:55 PM · Patch-For-Review, Community-Tech, Expiring-Watchlist-Items

Mon, Jun 14

Jdforrester-WMF added a comment to T284921: Remove "auto-number headings" preference .

Yes, instead it'd be:

Mon, Jun 14, 10:03 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Cache, MediaWiki-Parser, Platform Engineering
Jdforrester-WMF added a comment to T262091: Introduce aliases for objects.

In discussing this with Denny, we agreed that we would indeed keep things roughly as originally above, with there being a new key Z2K4, pointing to a ZMultiLingualStringSet (new type of object), which is a map of natural languages to an unordered list of strings (Z10: Z60 => Z10(Z6)).

Mon, Jun 14, 10:00 PM · Epic, Abstract Wikipedia team (Phase ζ), WikiLambda
Jdforrester-WMF changed the status of T220719: Standardize return type hint spacing from Stalled to Open.

OK, marking as un-Stalled.

Mon, Jun 14, 7:49 PM · Patch-For-Review, MediaWiki-Documentation, MediaWiki-Codesniffer
Jdforrester-WMF added a comment to T284495: Service pipeline publish job creates and then immediately deletes its tags.

I don't think this is unexpected. We delete builds locally from that machine after they're pushed to the registry; in the build above the 2021-06-02-161154-production tag still exists and is in the registry:

https://docker-registry.wikimedia.org/wikimedia/mediawiki-services-function-orchestrator/tags/

~
(/^ヮ^)/*:・゚✧ docker pull docker-registry.wikimedia.org/wikimedia/mediawiki-services-function-orchestrator:2021-06-02-161154-production
2021-06-02-161154-production: Pulling from wikimedia/mediawiki-services-function-orchestrator
5c86276767f3: Already exists 
1ef14f43e989: Pull complete 
388fccd06308: Pull complete 
426deee6f936: Pull complete 
24cda13c4b80: Pull complete 
2fd00452388f: Pull complete 
7b66ebaa23d1: Pull complete 
Digest: sha256:e5161610ea0ccb819e1d25a4a9552f4d76e441fe63fbcabe73835849d354679c
Status: Downloaded newer image for docker-registry.wikimedia.org/wikimedia/mediawiki-services-function-orchestrator:2021-06-02-161154-production
docker-registry.wikimedia.org/wikimedia/mediawiki-services-function-orchestrator:2021-06-02-161154-production
Mon, Jun 14, 7:45 PM · Abstract Wikipedia team, Release Pipeline, Release-Engineering-Team
Jdforrester-WMF closed T284919: regression - ModeSelector reference is assigning the wrong type to the search as Resolved.
Mon, Jun 14, 5:26 PM · Abstract Wikipedia team
Jdforrester-WMF closed T284922: Function call does not preload Arguments as Resolved.
Mon, Jun 14, 5:26 PM · Abstract Wikipedia team
Jdforrester-WMF created T284942: Make WikiLambda function call when embedding code (e.g. pre-flight testing of user-written function) use POST not GET so e.g. ? characters still work..
Mon, Jun 14, 5:17 PM · WikiLambda, Abstract Wikipedia team
Jdforrester-WMF closed T236915: Expose mediawiki/tools/api-testing doc on doc.wikimedia.org as Resolved.

https://doc.wikimedia.org/#testing:

Mon, Jun 14, 5:07 PM · Release-Engineering-Team (Doing), Platform Team Initiatives (API Integration Tests), Continuous-Integration-Config
Jdforrester-WMF added a comment to T251214: Make Fresnel API.md render correctly on Gitiles viewer.

How well does it render on GitLab? If the repo migrates there early, we can count this as done, perhaps?

Mon, Jun 14, 4:39 PM · patch-welcome, Documentation, Fresnel, Performance-Team
Jdforrester-WMF added a comment to T234359: [Idea] Deploy MediaWiki to Wikimedia production with a dedicated repo rather than re-using MediaWiki core.

Does that still fit with now that we have MW-on-K8s ? We also are phasing out Gerrit for Gitlab which afaik doesn't have the concept of a super project automatically tracking projects via submodules.

Mon, Jun 14, 4:12 PM · Release-Engineering-Team (Seen), Deployments
Jdforrester-WMF awarded T284921: Remove "auto-number headings" preference a Like token.
Mon, Jun 14, 3:58 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Cache, MediaWiki-Parser, Platform Engineering
Jdforrester-WMF closed T228552: "Content pages" link on Special:Statistics includes &hideredirects=1 though miser mode is enabled on wiki as Resolved.
Mon, Jun 14, 3:10 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MediaWiki-Special-pages

Fri, Jun 11

Jdforrester-WMF committed rMSFE4c05b9e17779: Update schemata to require one Z14 item, not all three (authored by Lindsay Wardell <three060@gmail.com>).
Update schemata to require one Z14 item, not all three
Fri, Jun 11, 7:28 PM
Jdforrester-WMF committed rMSFSfcad90e8098d: Z61: Allow language names to include digits (authored by Jdforrester-WMF).
Z61: Allow language names to include digits
Fri, Jun 11, 7:26 PM
Jdforrester-WMF added a comment to T284615: Improvements for the process of "WMF Releases" pages on MW.

Yup, currently ad hoc. The bot doing it would be great.

Fri, Jun 11, 6:48 PM · Release-Engineering-Team (Next)
Jdforrester-WMF added a comment to T282020: Add the type string from Z8 Vue code into the PHP side to show below the page title (currently "ZObject: ZObject").

Still needs the type-specific formatting for Z8s and other types.

Fri, Jun 11, 5:04 PM · WikiLambda, Abstract Wikipedia team
Jdforrester-WMF added a comment to T284345: Upgrade all CI jobs for WMF-deployed projects from Node 10 to Node 12.

Hi, I think this broke CI for packages that use node-rdkafka, e.g. node-rdkakfa-factory, eventgate, etc.

Fri, Jun 11, 3:08 PM · User-zeljkofilipin, Release-Engineering-Team (Doing), MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Continuous-Integration-Config

Thu, Jun 10

Jdforrester-WMF added a comment to T283194: Change User and User talk namespace name in tyv.wikipedia.org.

@Jdforrester-WMF May I ask, why isn't ReleaseTaggerBot tagging this merged core change? Thanks.

Thu, Jun 10, 11:38 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), I18n, MediaWiki-Internationalization
Jdforrester-WMF closed T284786: Automatic citation addition in VisualEditor has stopped working as Resolved.
Thu, Jun 10, 11:29 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), WMDE-TechWish-Sprint-2021-06-09, Citoid, Regression, VisualEditor
Jdforrester-WMF closed T284786: Automatic citation addition in VisualEditor has stopped working, a subtask of T281150: 1.37.0-wmf.9 deployment blockers, as Resolved.
Thu, Jun 10, 11:29 PM · Patch-For-Review, Release-Engineering-Team (Doing), Release, Train Deployments
Jdforrester-WMF added a project to T284780: ContentTranslation dependencies are not clearly defined in the extension making it unintuitive to setup for development: Documentation.
Thu, Jun 10, 11:28 PM · Documentation, ContentTranslation
Jdforrester-WMF assigned T284786: Automatic citation addition in VisualEditor has stopped working to AntiCompositeNumber.
Thu, Jun 10, 11:27 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), WMDE-TechWish-Sprint-2021-06-09, Citoid, Regression, VisualEditor
Jdforrester-WMF added a parent task for T284786: Automatic citation addition in VisualEditor has stopped working: T281150: 1.37.0-wmf.9 deployment blockers.
Thu, Jun 10, 11:10 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), WMDE-TechWish-Sprint-2021-06-09, Citoid, Regression, VisualEditor
Jdforrester-WMF added a subtask for T281150: 1.37.0-wmf.9 deployment blockers: T284786: Automatic citation addition in VisualEditor has stopped working.
Thu, Jun 10, 11:10 PM · Patch-For-Review, Release-Engineering-Team (Doing), Release, Train Deployments
Jdforrester-WMF added a comment to T207087: Replace all the npm* images with node10* ones.

Oh, oops. Go go 2019-me.

Thu, Jun 10, 10:16 PM · Patch-For-Review, Continuous-Integration-Config
Jdforrester-WMF added a comment to T151642: Change notification email from jenkins-bot@wikimedia.org to releng internal list.

I've recently been getting a few of these (mostly from @Jdforrester-WMF cleaning up portalsbuild?).

Thu, Jun 10, 10:06 PM · Release-Engineering-Team (Seen)
Jdforrester-WMF closed T268667: Archive mediawiki/extensions/MultiUpload? as Resolved.
Thu, Jun 10, 9:52 PM · User-Kizule, Wikimedia-GitHub, translatewiki.net, Diffusion-Repository-Administrators, Projects-Cleanup, MediaWiki-extensions-MultiUpload
Jdforrester-WMF added a subtask for T284730: selenium-daily-beta-CirrusSearch fails with `Request failed due to invalid argument: invalid argument: unrecognized capability: chromeOptions`: T284696: Update Fresh from Node.js 10 LTS to Node.js 12 LTS.
Thu, Jun 10, 7:03 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), CirrusSearch, User-zeljkofilipin, Browser-Tests, Discovery-Search, Quality-and-Test-Engineering-Team (QTE)
Jdforrester-WMF added a parent task for T284696: Update Fresh from Node.js 10 LTS to Node.js 12 LTS: T284730: selenium-daily-beta-CirrusSearch fails with `Request failed due to invalid argument: invalid argument: unrecognized capability: chromeOptions`.
Thu, Jun 10, 7:03 PM · User-zeljkofilipin, Patch-For-Review, Performance-Team, Fresh
Jdforrester-WMF removed a subtask for T284696: Update Fresh from Node.js 10 LTS to Node.js 12 LTS: T284507: Request increased quota for 'integration' Cloud VPS project.
Thu, Jun 10, 7:02 PM · User-zeljkofilipin, Patch-For-Review, Performance-Team, Fresh
Jdforrester-WMF added a subtask for T284774: Provide one or more Qemu agents in CI that use a newer version than 2.x: T284507: Request increased quota for 'integration' Cloud VPS project.
Thu, Jun 10, 7:02 PM · Continuous-Integration-Infrastructure, Performance-Team
Jdforrester-WMF edited parent tasks for T284507: Request increased quota for 'integration' Cloud VPS project, added: T284774: Provide one or more Qemu agents in CI that use a newer version than 2.x; removed: T284696: Update Fresh from Node.js 10 LTS to Node.js 12 LTS.
Thu, Jun 10, 7:02 PM · Continuous-Integration-Infrastructure, Release-Engineering-Team, Cloud-VPS (Quota-requests)
Jdforrester-WMF created T284774: Provide one or more Qemu agents in CI that use a newer version than 2.x.
Thu, Jun 10, 7:02 PM · Continuous-Integration-Infrastructure, Performance-Team
Jdforrester-WMF added a comment to T284730: selenium-daily-beta-CirrusSearch fails with `Request failed due to invalid argument: invalid argument: unrecognized capability: chromeOptions`.

Fresh can't update to node12 yet, unfortunately. See T284696: Update Fresh from Node.js 10 LTS to Node.js 12 LTS.

Thu, Jun 10, 6:59 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), CirrusSearch, User-zeljkofilipin, Browser-Tests, Discovery-Search, Quality-and-Test-Engineering-Team (QTE)
Jdforrester-WMF updated the task description for T278203: Migrate all CI jobs from stretch to buster or later and drop stretch testing support.
Thu, Jun 10, 5:55 PM · Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF closed T284702: Is the mediawiki-tarball image used, or can we delete it? as Resolved.
Thu, Jun 10, 5:53 PM · MediaWiki-Releasing, Continuous-Integration-Infrastructure
Jdforrester-WMF updated the task description for T278203: Migrate all CI jobs from stretch to buster or later and drop stretch testing support.
Thu, Jun 10, 5:49 PM · Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF added a comment to T284702: Is the mediawiki-tarball image used, or can we delete it?.

No, it was never used as the project wasn't finished. Feel free to delete it.

Thu, Jun 10, 5:45 PM · MediaWiki-Releasing, Continuous-Integration-Infrastructure

Wed, Jun 9

Jdforrester-WMF updated subscribers of T282795: More flexible treatment of requirements in `python`; control over `PYTHONPATH`.

@jeena suggests that the work-around mentioned in T267685: blubber: Execute python module as RUN command of dockerfile might work for us here?

Wed, Jun 9, 9:27 PM · Abstract Wikipedia team (Phase ζ), Release Pipeline (Blubber), Release-Engineering-Team
Jdforrester-WMF updated the task description for T278203: Migrate all CI jobs from stretch to buster or later and drop stretch testing support.
Wed, Jun 9, 9:19 PM · Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF created T284702: Is the mediawiki-tarball image used, or can we delete it?.
Wed, Jun 9, 9:14 PM · MediaWiki-Releasing, Continuous-Integration-Infrastructure
Jdforrester-WMF updated the task description for T278203: Migrate all CI jobs from stretch to buster or later and drop stretch testing support.
Wed, Jun 9, 9:02 PM · Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF closed T280874: Provide buster-based Ruby CI jobs as Resolved.
Wed, Jun 9, 9:00 PM · Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF closed T280874: Provide buster-based Ruby CI jobs, a subtask of T278203: Migrate all CI jobs from stretch to buster or later and drop stretch testing support, as Resolved.
Wed, Jun 9, 9:00 PM · Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF added a project to T284694: Enable "What Links Here" to include ZObject references: WikiLambda.
Wed, Jun 9, 8:14 PM · WikiLambda, Abstract Wikipedia team
Jdforrester-WMF added a comment to T284694: Enable "What Links Here" to include ZObject references.

To do this, I suppose that each time someone creates a Z9/Reference we'll store it into the link table?

Wed, Jun 9, 8:14 PM · WikiLambda, Abstract Wikipedia team
Jdforrester-WMF moved T284495: Service pipeline publish job creates and then immediately deletes its tags from To triage to Backlog on the Abstract Wikipedia team board.
Wed, Jun 9, 8:10 PM · Abstract Wikipedia team, Release Pipeline, Release-Engineering-Team
Jdforrester-WMF added a comment to T284495: Service pipeline publish job creates and then immediately deletes its tags.

This didn't happen on the next merged patch, so… 🤷‍♂️

Wed, Jun 9, 8:10 PM · Abstract Wikipedia team, Release Pipeline, Release-Engineering-Team
Jdforrester-WMF edited projects for T284495: Service pipeline publish job creates and then immediately deletes its tags, added: Abstract Wikipedia team; removed function-evaluator, Abstract Wikipedia team (Phase ε).
Wed, Jun 9, 8:10 PM · Abstract Wikipedia team, Release Pipeline, Release-Engineering-Team
Jdforrester-WMF removed a subtask for T283902: Evaluator service dies on receiving a request: T284495: Service pipeline publish job creates and then immediately deletes its tags.
Wed, Jun 9, 8:09 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
Jdforrester-WMF removed a parent task for T284495: Service pipeline publish job creates and then immediately deletes its tags: T283902: Evaluator service dies on receiving a request.
Wed, Jun 9, 8:09 PM · Abstract Wikipedia team, Release Pipeline, Release-Engineering-Team
Jdforrester-WMF closed T283902: Evaluator service dies on receiving a request as Resolved.

For some reason https://gerrit.wikimedia.org/r/c/mediawiki/services/function-evaluator/+/698570 did cause a new image to be tagged, as 2021-06-07-210845-production, so this is Resolved. Will follow-up with RelEng longer-term as we don't want this to recur.

Wed, Jun 9, 8:09 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
Jdforrester-WMF updated the task description for T282585: Provide for asynchronously-available MediaWiki parser content fragments / components.
Wed, Jun 9, 8:02 PM · MediaWiki-Parser, tech-decision-forum, Abstract Wikipedia team
Jdforrester-WMF updated the task description for T280874: Provide buster-based Ruby CI jobs.
Wed, Jun 9, 4:55 PM · Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF closed T199403: `composer test` in MediaWiki core doesn't work like it does in other repositories as Resolved.

Thanks!

Wed, Jun 9, 4:02 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MW-1.35-notes, MW-1.31-release-notes, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Composer, MediaWiki-Core-Tests
Volker_E awarded T284346: Provide a node 12 production image (based on bullseye?) a Like token.
Wed, Jun 9, 10:16 AM · Patch-For-Review, Services, serviceops, Release Pipeline

Tue, Jun 8

Jdforrester-WMF added a project to T284252: Change the orchestrator to respond with a Z5 if the input is in the 'wrong form', not reflecting the request: function-orchestrator.

@Jdforrester-WMF the Orchestrator tag was created for the DBAs (https://phabricator.wikimedia.org/project/profile/5061/) and the Orchestrator (https://github.com/openark/orchestrator) project. So I am going to remove the tag from here.

Tue, Jun 8, 10:34 PM · Patch-For-Review, Abstract Wikipedia team (Phase ζ), function-orchestrator
Jdforrester-WMF closed T284519: CirrusSearch cucumber runner system is not compatible with node 12 -> master is unmerge-able as Resolved.
Tue, Jun 8, 10:28 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Patch-For-Review, CirrusSearch, Discovery-Search, Continuous-Integration-Infrastructure
Jdforrester-WMF changed the status of T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline from Resolved to Declined.

Given the state of this was "no, we're not making them non-voting", let's call this Declined.

Tue, Jun 8, 10:22 PM · MediaWiki-Core-Tests, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
Jdforrester-WMF added a comment to T284526: Remove voting Selenium jobs from the wmf branches.

just like it was done for non-gate jobs (T225248).

Tue, Jun 8, 10:22 PM · Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
Jdforrester-WMF added a comment to T199403: `composer test` in MediaWiki core doesn't work like it does in other repositories.

So, if I understand correctly, current status is that CI is running composer test-some <paths> now, but we haven't patched core's composer.json so that composer test Just Works like we expect. But it should be safe to do that now because CI doesn't use composer test any more?

Tue, Jun 8, 10:17 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MW-1.35-notes, MW-1.31-release-notes, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Composer, MediaWiki-Core-Tests
Jdforrester-WMF added a comment to T284613: Add ssh key for jforrester.

Signing with MFA.

Tue, Jun 8, 10:00 PM · SRE, SRE-Access-Requests
Jdforrester-WMF created T284613: Add ssh key for jforrester.
Tue, Jun 8, 9:59 PM · SRE, SRE-Access-Requests
Jdforrester-WMF closed T283760: `function-schemata` Z14 should accept exactly one of Z14K[234], not require all three, a subtask of T277925: Provide a validator for Z14/Implementation in the editing experience, as Resolved.
Tue, Jun 8, 9:54 PM · Abstract Wikipedia team, WikiLambda
Jdforrester-WMF closed T283760: `function-schemata` Z14 should accept exactly one of Z14K[234], not require all three as Resolved.
Tue, Jun 8, 9:54 PM · function-schemata, Abstract Wikipedia team
Jdforrester-WMF closed T278293: MergeHistory message outputs unparsed HTML as Resolved.
Tue, Jun 8, 6:48 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MediaWiki-MergeHistory
Jdforrester-WMF closed T278295: MergeHistory: Avoid querying master DB for the purpose of trivial message variation as Resolved.
Tue, Jun 8, 6:48 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MediaWiki-MergeHistory
Jdforrester-WMF added a comment to T280491: Wikibase legacy ruby browser tests need to be updated to work on buster/ruby2.5.
  1. Verify somehow that this works. I believe the patch should pass on It's going to fail on the regular ruby jobs because of some version incompatibilities, so maybe we can add experimental jobs running the buster versions of rake-docker and mwselenium-quibble-docker?
Tue, Jun 8, 5:17 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, wdwb-tech, Wikidata
Jdforrester-WMF closed T283506: Move label fetching in the API methods into the ZObjectStore as Resolved.
Tue, Jun 8, 4:24 PM · WikiLambda, Abstract Wikipedia team
Jdforrester-WMF renamed T284519: CirrusSearch cucumber runner system is not compatible with node 12 -> master is unmerge-able from CirrusSearch cucumber runner system is not compatible with node 12 -> master is unmeregable to CirrusSearch cucumber runner system is not compatible with node 12 -> master is unmerge-able.
Tue, Jun 8, 12:29 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Patch-For-Review, CirrusSearch, Discovery-Search, Continuous-Integration-Infrastructure
Jdforrester-WMF created T284519: CirrusSearch cucumber runner system is not compatible with node 12 -> master is unmerge-able.
Tue, Jun 8, 12:25 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Patch-For-Review, CirrusSearch, Discovery-Search, Continuous-Integration-Infrastructure

Mon, Jun 7

Jdforrester-WMF closed T284492: CI failures in "git-status" task related to submodules as Resolved.

This should be back to working everywhere. If not, please shout.

Mon, Jun 7, 11:23 PM · Continuous-Integration-Infrastructure
Jdforrester-WMF added a comment to T277000: Validate a Z7/Function call in the wiki.

We don't validate Z7s when we try to save them, however (so API edits could be constructed that are invalid), so not sure if this counts as done yet. When we switch the PHP validation over to use schemata's code, which is T281386, this will be done there; I think we can wait for that?

Mon, Jun 7, 8:55 PM · Abstract Wikipedia team, WikiLambda
Jdforrester-WMF closed T279114: Switch ZMonoLingualString over to using Z60/Natural language objects, rather than 'en' etc. strings as Resolved.

Yes. Hopefully. :-)

Mon, Jun 7, 8:46 PM · Abstract Wikipedia team, Abstract Wikipedia UX, WikiLambda
Jdforrester-WMF created T284495: Service pipeline publish job creates and then immediately deletes its tags.
Mon, Jun 7, 8:21 PM · Abstract Wikipedia team, Release Pipeline, Release-Engineering-Team
Jdforrester-WMF added a comment to T284492: CI failures in "git-status" task related to submodules.

The node10 images have git 2.20.1; the node12 ones have git 2.30.2. Possibly something changed about how git submodule checkouts work?

Mon, Jun 7, 8:16 PM · Continuous-Integration-Infrastructure
Jdforrester-WMF added a comment to T284492: CI failures in "git-status" task related to submodules.

Given that 1f76dea7e63ca6b7bd5f1ef6a372c1878429f973 is the current value pointer for VE-MW HEAD, but 3891890c29a72941b0eae1bfd7b3b829bc58b343 is the current VE-standalone HEAD, possibly the git submodule checkout isn't respecting the pointer? I quickly made https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/698619 to see if that resets the state to work…

Mon, Jun 7, 8:15 PM · Continuous-Integration-Infrastructure
Jdforrester-WMF added a comment to T283902: Evaluator service dies on receiving a request.

Two questions on this:

@DVrandecic : you mentioned that the instructions in the README don't help. The README describes how to build the local versions of the docker containers. Can you suggest how the README could be more clear?
@Jdforrester-WMF : docker-registry still doesn't have a version of function-evaluator newer than June 1; is there a way I can manually upload a new image there or trigger a build?

Mon, Jun 7, 7:22 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
Jdforrester-WMF added a comment to T284345: Upgrade all CI jobs for WMF-deployed projects from Node 10 to Node 12.

Selenium jobs are not updated to node v12?

Example patch: 678287.
Example job: 55939.

...
INFO:quibble.commands:node --version: v10.24.0
INFO:quibble.commands:npm --version: 6.14.5
...
Mon, Jun 7, 6:55 PM · User-zeljkofilipin, Release-Engineering-Team (Doing), MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Continuous-Integration-Config
Jdforrester-WMF added a comment to T284484: Expose API Endpoint to Dereference ZObjects in WikiLambda Extension.

I was thinking that this would inside the orchestrator, walking the object and making wikilambda_fetch calls as needed. Is that your thought too?

Mon, Jun 7, 6:28 PM · Abstract Wikipedia team, function-orchestrator
Jdforrester-WMF added a comment to T284474: Add tests for normalize/canonicalize code in frontend..

More than https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLambda/+/refs/heads/master/tests/jest/mixins/ ?

Mon, Jun 7, 4:43 PM · Abstract Wikipedia team (Phase ζ)
Jdforrester-WMF created T284473: WikiLambda needs to implement a subclass of SlotDiffRenderer.
Mon, Jun 7, 4:33 PM · Abstract Wikipedia team (Phase θ), WikiLambda
Jdforrester-WMF added a comment to T251918: docker-reporter-releng-images failed on deneb.

We have another bunch of Release-Engineering-Team images failing, probably all due to being jessie based:

Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/ci-jessie:0.5.1-s1             [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/ci-src-setup:0.3.1-s3          [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/composer-php56:0.2.0-s2        [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/composer-test-php56:0.2.0-s2   [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/npm:0.4.0-s1                   [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/npm-test:0.7.1-s1              [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/npm-test-3d2png:0.3.0-s2       [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/npm-test-graphoid:0.3.0-s2     [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/npm-test-librdkafka:0.2.1-s1   [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/npm-test-maps-service:0.3.0-s2 [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/php56:0.1.2                    [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/quibble-jessie:0.0.31-1        [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/quibble-jessie-hhvm:0.0.31-1   [FAIL]
Jun  7 11:28:11 deneb docker-report-releng[9839]: docker-registry.wikimedia.org/releng/quibble-jessie-php56:0.0.31-1  [FAIL]
Mon, Jun 7, 3:33 PM · User-jbond, Patch-For-Review, serviceops, SRE
Jdforrester-WMF added a comment to T283883: Work out why initial skin/extension branches into REL1_35/REL1_36 were on the wrong branch.

So REL1_34 has been created via the REST API, presumably using some script. OATHAuth has a similar output.

I have no idea how the REL1_35 / REL1_36 branches got created.

Mon, Jun 7, 2:50 PM · Release-Engineering-Team (Seen), LibUp, MediaWiki-Release-Tools, MediaWiki-Releasing
Jdforrester-WMF added a comment to T200997: Add raw HTML messages in WMF-deployed extensions to $wgRawHtmlMessages.

Can this task be closed as the task title talks about "WMF-deployed extensions", and dedicated subtasks of T2212 be created for BlueSpice, ImageRating, MediaWiki-extensions-SmiteSpam, PollNY (which don't have a string RawHtmlMessages in their extension.json files) as per T200997#4667849 ?

Mon, Jun 7, 2:41 PM · Security, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), I18n, MediaWiki-Internationalization
Jdforrester-WMF closed T278242: Move static code out of WikiLambda content classes (e.g. ZKey) as Resolved.
Mon, Jun 7, 2:37 PM · Abstract Wikipedia team, WikiLambda
Jdforrester-WMF added a comment to T284434: Don't run quibble-vendor-mysql-php72-selenium-docker in gate-and-submit.

The first job is "with this patch, do this extension's selenium test (and its dependencies) still pass?" The second is "with this patch, do the core selenium tests still pass?". Potentially we could merge the jobs together for these circumstances, but it'd be messy.

Mon, Jun 7, 2:35 PM · Browser-Tests, Continuous-Integration-Config
zeljkofilipin awarded T284345: Upgrade all CI jobs for WMF-deployed projects from Node 10 to Node 12 a Yellow Medal token.
Mon, Jun 7, 10:30 AM · User-zeljkofilipin, Release-Engineering-Team (Doing), MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Continuous-Integration-Config

Sun, Jun 6

Jdforrester-WMF archived MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).
Sun, Jun 6, 6:38 PM

Sat, Jun 5

Mholloway awarded T284345: Upgrade all CI jobs for WMF-deployed projects from Node 10 to Node 12 a Barnstar token.
Sat, Jun 5, 6:47 PM · User-zeljkofilipin, Release-Engineering-Team (Doing), MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Continuous-Integration-Config
Jdforrester-WMF added a comment to T283902: Evaluator service dies on receiving a request.

But even without the tags, shouldn't the git hashes be referring to the right version?

Sat, Jun 5, 4:21 AM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
Jdforrester-WMF added a comment to T284360: Grant `mediawiki` gerrit group +2 rights for visualeditor.

This was intentional. If the Editing team wants to reverse its decision, sure, but this is exceptionally delicate code.

Sat, Jun 5, 4:19 AM · Patch-For-Review, Gerrit-Privilege-Requests, User-DannyS712, VisualEditor

Fri, Jun 4

Jdforrester-WMF added a comment to T283902: Evaluator service dies on receiving a request.

Hmm. It's done it again. 2021-06-04-220538-production pushed and then immediately untagged.

Fri, Jun 4, 10:10 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
Jdforrester-WMF added a comment to T283902: Evaluator service dies on receiving a request.

The patch that fixed this was merged on June 2: https://gerrit.wikimedia.org/r/c/mediawiki/services/function-orchestrator/+/697692

The most recent evaluator image on the Docker registry is from June 1st. @Jdforrester-WMF , is there a way we can manually force a new build?

Fri, Jun 4, 10:06 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
Jdforrester-WMF added a comment to T284345: Upgrade all CI jobs for WMF-deployed projects from Node 10 to Node 12.

Announced on wikitech-l in case it breaks anything: https://lists.wikimedia.org/hyperkitty/list/wikitech-l@lists.wikimedia.org/thread/ZOMZ376CCVD7HNTL2XYA5ASCABUS4DG5/

Fri, Jun 4, 10:00 PM · User-zeljkofilipin, Release-Engineering-Team (Doing), MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Continuous-Integration-Config
Jdforrester-WMF added a comment to T284345: Upgrade all CI jobs for WMF-deployed projects from Node 10 to Node 12.

OK, this is mostly done except for two sets of jobs:

Fri, Jun 4, 9:37 PM · User-zeljkofilipin, Release-Engineering-Team (Doing), MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Continuous-Integration-Config
Jdforrester-WMF closed T284343: Create WMF CI image for Node.js 12, a subtask of T284345: Upgrade all CI jobs for WMF-deployed projects from Node 10 to Node 12, as Resolved.
Fri, Jun 4, 7:35 PM · User-zeljkofilipin, Release-Engineering-Team (Doing), MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Continuous-Integration-Config
Jdforrester-WMF closed T284343: Create WMF CI image for Node.js 12 as Resolved.
Fri, Jun 4, 7:35 PM · Release-Engineering-Team, Continuous-Integration-Config, Continuous-Integration-Infrastructure
Jdforrester-WMF added a comment to T284197: `Failed to fetch http://mirrors.wikimedia.org/debian/pool/main/z/zvbi/libzvbi0_0.2.35-18_amd64.deb Error reading from server. Remote end closed connection [IP: 208.80.154.15 80]` on build of a bullseye CI image.

Well, it finally passed for me locally after running the build three times in a row…

Fri, Jun 4, 7:17 PM · serviceops