Page MenuHomePhabricator

Jdforrester-WMF (James D. Forrester)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:08 PM (246 w, 22 h)
Availability
Available
IRC Nick
James_F
LDAP User
Jforrester
MediaWiki User
Jdforrester (WMF) [ Global Accounts ]

I've been a Wikipedia editor since 2002 on the English Wikipedia and a few other Wikimedia projects. In May 2012, I joined the Wikimedia Foundation as a "product manager", initially for VisualEditor, the the Editing Team, and later the lead product manager for all contribution. In 2018, I moved to be a software engineer, working on reliability, infrastructure, developer tooling, and continuous integration and deployment.

My job is to help ensure that the tools we provide to our readers and contributors are the best the can be, in speed, correctness, consistency, utility, and reliability.

Recent Activity

Today

Jdforrester-WMF closed T220735: 1.34.0-wmf.10 deployment blockers as Resolved.
Tue, Jun 25, 7:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Release-Engineering-Team (Kanban), Release, Train Deployments
Jdforrester-WMF added a watcher for serviceops: Jdforrester-WMF.
Tue, Jun 25, 5:44 PM
Jdforrester-WMF moved T226112: Homepage: mobile homepage and user page auto scroll down (on iOS Safari 10 and iOS Chrome 60.0.3112.89) from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jun 25, 5:39 PM · Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Jdforrester-WMF added a comment to T226168: Chemistry beaker icon should have open top.

This is an actively terrible decision, and undermines our entire purpose for educating the world and being a congruent voice in that experience. I emplore the designers to consider their audience better.

Tue, Jun 25, 5:37 PM · Patch-For-Review, Design, OOUI
Jdforrester-WMF removed a parent task for T226503: Notification icons gone on meta wiki when using Monobook: "Error: Unknown module: ext.echo.badgeicons": T220735: 1.34.0-wmf.10 deployment blockers.
Tue, Jun 25, 5:25 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), User-MarcoAurelio, Growth-Team, Notifications, Regression, MonoBook
Jdforrester-WMF removed a subtask for T220735: 1.34.0-wmf.10 deployment blockers: T226503: Notification icons gone on meta wiki when using Monobook: "Error: Unknown module: ext.echo.badgeicons".
Tue, Jun 25, 5:25 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Release-Engineering-Team (Kanban), Release, Train Deployments
Jdforrester-WMF added a parent task for T226448: Fatal logged after renaming files: "LocalFile.php: Call to a member function purgeEverything() on boolean": T220736: 1.34.0-wmf.11 deployment blockers.
Tue, Jun 25, 4:43 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Multimedia, Commons, MediaWiki-API, MediaWiki-File-management, Wikimedia-production-error
Jdforrester-WMF added a subtask for T220736: 1.34.0-wmf.11 deployment blockers: T226448: Fatal logged after renaming files: "LocalFile.php: Call to a member function purgeEverything() on boolean".
Tue, Jun 25, 4:43 PM · Release-Engineering-Team (Kanban), Release, Train Deployments
Jdforrester-WMF closed T148340: Stop conditionally registering hooks in FlaggedRevs as Resolved.
Tue, Jun 25, 4:32 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Technical-Debt, MediaWiki-extensions-FlaggedRevs
Jdforrester-WMF reopened T226503: Notification icons gone on meta wiki when using Monobook: "Error: Unknown module: ext.echo.badgeicons" as "Open".

Looks like it needs further work. :-(

Tue, Jun 25, 3:52 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), User-MarcoAurelio, Growth-Team, Notifications, Regression, MonoBook
Jdforrester-WMF reopened T226503: Notification icons gone on meta wiki when using Monobook: "Error: Unknown module: ext.echo.badgeicons", a subtask of T220735: 1.34.0-wmf.10 deployment blockers, as Open.
Tue, Jun 25, 3:52 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Release-Engineering-Team (Kanban), Release, Train Deployments
Jdforrester-WMF closed T226503: Notification icons gone on meta wiki when using Monobook: "Error: Unknown module: ext.echo.badgeicons" as Resolved.

Deployed.

Tue, Jun 25, 3:28 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), User-MarcoAurelio, Growth-Team, Notifications, Regression, MonoBook
Jdforrester-WMF closed T226503: Notification icons gone on meta wiki when using Monobook: "Error: Unknown module: ext.echo.badgeicons", a subtask of T220735: 1.34.0-wmf.10 deployment blockers, as Resolved.
Tue, Jun 25, 3:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Release-Engineering-Team (Kanban), Release, Train Deployments
Restricted Application added a project to T226503: Notification icons gone on meta wiki when using Monobook: "Error: Unknown module: ext.echo.badgeicons": Growth-Team.
Tue, Jun 25, 3:02 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), User-MarcoAurelio, Growth-Team, Notifications, Regression, MonoBook

Yesterday

Jdforrester-WMF updated the task description for T220656: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.34 release.
Mon, Jun 24, 11:07 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, MediaWiki-General-or-Unknown, Technical-Debt (Deprecation), MW-1.34-release
Jdforrester-WMF closed T226442: CI jobs failing for MinervaNeue (because of old pinned fibers version?) as Resolved.
Mon, Jun 24, 10:25 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MinervaNeue
Jdforrester-WMF closed T226442: CI jobs failing for MinervaNeue (because of old pinned fibers version?), a subtask of T223142: Homepage: mobile tab scrolling, as Resolved.
Mon, Jun 24, 10:25 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Jdforrester-WMF closed T226442: CI jobs failing for MinervaNeue (because of old pinned fibers version?), a subtask of T226112: Homepage: mobile homepage and user page auto scroll down (on iOS Safari 10 and iOS Chrome 60.0.3112.89), as Resolved.
Mon, Jun 24, 10:24 PM · Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Jdforrester-WMF added a comment to T226329: QueryService UI test build fails on CI.

The Wikidata query UI isn't in a CI gate, right? I don't see how this is a shared build failure.

Mon, Jun 24, 10:20 PM · Wikimedia-production-error (Shared Build Failure), Wikidata, Wikidata Query UI
Jdforrester-WMF added a project to T226440: Local "wikEd" editor gadget on en.wp shows a thumbnail of an image instead of editable source that invokes it: MediaWiki-extensions-Other.

I don't think wikEd bugs are managed in Phabricator, but on its maintainer's talk page; I'm not sure if they're managed at all, frankly, but I worry that just creating this task here won't get seen by anyone, sorry. :-(

Mon, Jun 24, 9:22 PM
Jdforrester-WMF added a comment to T226440: Local "wikEd" editor gadget on en.wp shows a thumbnail of an image instead of editable source that invokes it.

That looks like wikEd, a community-written gadget.

Mon, Jun 24, 9:20 PM
Jdforrester-WMF added a comment to T226288: LibUp vulnerability dashboard should distinguish dev-only/devDependency issues from "real" ones..

Thank you! Highlights that we want to run LibUp to convert from jshint/jscs to eslint on a bunch of repos, if we can. ;-)

Mon, Jun 24, 9:14 PM · LibUp
Jdforrester-WMF renamed T149410: For consistency, Wikibase serialization should use "statements" as key, rather than "claims", like modern Wikibase code now does from For consistency MediaInfo serialization should use "claims" as key, rather than "statements" to For consistency, Wikibase serialization should use "statements" as key, rather than "claims", like modern Wikibase code now does.
Mon, Jun 24, 9:07 PM · StructuredDataOnCommons, Wikidata, WikibaseMediaInfo
Jdforrester-WMF created T226442: CI jobs failing for MinervaNeue (because of old pinned fibers version?).
Mon, Jun 24, 7:01 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MinervaNeue
Jdforrester-WMF added a comment to T225216: Bug in setting red links with MW 1.24.

Is this meant to be an issue with MW1.34?

Mon, Jun 24, 5:51 PM · MediaWiki-extensions-Page_Forms
Jdforrester-WMF assigned T226281: [Regression wmf.10] VE does not open/crashes if only a link is added/edited in a session, error in the console "jQuery.Deferred exception: Cannot read property 'height' of undefined TypeError: Cannot read property 'height' of undefined" to Esanders.
Mon, Jun 24, 5:45 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor (Current work), VisualEditor-MediaWiki
Jdforrester-WMF closed T226253: Composer\Downloader\TransportException in CI builds for multiple repositories as Resolved.

Yeah, this appears to have fixed itself upstream.

Mon, Jun 24, 5:42 PM · Release-Engineering-Team-TODO, Release-Engineering-Team, Wikimedia-production-error (Shared Build Failure)
Jdforrester-WMF closed T220737: 1.34.0-wmf.12 deployment blockers as Declined.

We're not running the train next week as there's the 4 July holiday.

Mon, Jun 24, 4:48 PM · Release, Train Deployments
Jdforrester-WMF closed T148103: Provide a desktop beta feature of replacing Kaltura player with Video.js as Resolved.

Yup, this task is done.

Mon, Jun 24, 4:05 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review, Beta-Feature, TimedMediaHandler-Player, Wikimedia-Video, TimedMediaHandler
Jdforrester-WMF closed T148103: Provide a desktop beta feature of replacing Kaltura player with Video.js, a subtask of T100106: Replace Kaltura player with Video.js, as Resolved.
Mon, Jun 24, 4:05 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Epic, Performance-Team, Multimedia, TimedMediaHandler-Player, Wikimedia-Video, Wikimedia-Hackathon-2015, TimedMediaHandler
Jdforrester-WMF closed T226102: BadMethodCallException on Commons: /includes/specials/pagers/ImageListPager.php: Call to a member function getUrl() on a non-object (boolean) as Resolved.

For simplicity let's mark this as Resolved and re-open if it didn't work.

Mon, Jun 24, 3:55 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MediaWiki-Special-pages, Multimedia, Commons, Wikimedia-production-error
Jdforrester-WMF closed T226102: BadMethodCallException on Commons: /includes/specials/pagers/ImageListPager.php: Call to a member function getUrl() on a non-object (boolean), a subtask of T220735: 1.34.0-wmf.10 deployment blockers, as Resolved.
Mon, Jun 24, 3:55 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Release-Engineering-Team (Kanban), Release, Train Deployments
Jdforrester-WMF closed T225456: Run phan on PHP 7.2, not PHP 7.0 as Resolved.
Mon, Jun 24, 3:51 PM · Patch-For-Review, Continuous-Integration-Config, Release-Engineering-Team (Kanban)
Jdforrester-WMF closed T225456: Run phan on PHP 7.2, not PHP 7.0, a subtask of T225457: Move all CI generic tasks from PHP70 to PHP72, as Resolved.
Mon, Jun 24, 3:51 PM · Continuous-Integration-Config
Jdforrester-WMF edited parent tasks for T207344: Phan-taint-check-plugin not available for PHP > 7.0, added: T226420: Run phan secheck on PHP 7.2, not PHP 7.0; removed: T225456: Run phan on PHP 7.2, not PHP 7.0.
Mon, Jun 24, 3:50 PM · Security-Team, Release-Engineering-Team (Kanban), phan-taint-check-plugin
Jdforrester-WMF removed a subtask for T225456: Run phan on PHP 7.2, not PHP 7.0: T207344: Phan-taint-check-plugin not available for PHP > 7.0.
Mon, Jun 24, 3:50 PM · Patch-For-Review, Continuous-Integration-Config, Release-Engineering-Team (Kanban)
Jdforrester-WMF added a subtask for T226420: Run phan secheck on PHP 7.2, not PHP 7.0: T207344: Phan-taint-check-plugin not available for PHP > 7.0.
Mon, Jun 24, 3:50 PM · Patch-For-Review, Continuous-Integration-Config
Jdforrester-WMF created T226420: Run phan secheck on PHP 7.2, not PHP 7.0.
Mon, Jun 24, 3:50 PM · Patch-For-Review, Continuous-Integration-Config
Jdforrester-WMF added a subtask for T225111: Update PHPUnit version of wikiba.se repository to PHPUnit 8: T224905: Move wikiba.se tests from php56 to php72.
Mon, Jun 24, 3:20 PM · Patch-For-Review, Wikidata-Campsite, wikiba.se website, Wikidata
Jdforrester-WMF added a parent task for T224905: Move wikiba.se tests from php56 to php72: T225111: Update PHPUnit version of wikiba.se repository to PHPUnit 8.
Mon, Jun 24, 3:20 PM · Release-Engineering-Team-TODO, Release-Engineering-Team, wikiba.se website, Wikidata, Continuous-Integration-Config
Jdforrester-WMF removed a parent task for T225111: Update PHPUnit version of wikiba.se repository to PHPUnit 8: T224905: Move wikiba.se tests from php56 to php72.
Mon, Jun 24, 3:20 PM · Patch-For-Review, Wikidata-Campsite, wikiba.se website, Wikidata
Jdforrester-WMF removed a subtask for T224905: Move wikiba.se tests from php56 to php72: T225111: Update PHPUnit version of wikiba.se repository to PHPUnit 8.
Mon, Jun 24, 3:20 PM · Release-Engineering-Team-TODO, Release-Engineering-Team, wikiba.se website, Wikidata, Continuous-Integration-Config
Jdforrester-WMF closed T224905: Move wikiba.se tests from php56 to php72, a subtask of T224906: Drop php56 testing support, as Resolved.
Mon, Jun 24, 3:19 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF closed T224905: Move wikiba.se tests from php56 to php72 as Resolved.

Thank you, @WMDE-leszek!

Mon, Jun 24, 3:19 PM · Release-Engineering-Team-TODO, Release-Engineering-Team, wikiba.se website, Wikidata, Continuous-Integration-Config

Fri, Jun 21

Jdforrester-WMF set Is Sprint to 0 on LibUp.
Fri, Jun 21, 10:35 PM
Jdforrester-WMF created T226288: LibUp vulnerability dashboard should distinguish dev-only/devDependency issues from "real" ones..
Fri, Jun 21, 10:35 PM · LibUp
Jdforrester-WMF edited parent tasks for T216620: Add error detection to HTTP fetch in foreign resources checker before gzipping, added: T203694: Run ForeignResourceManager verification on MediaWiki core commits; removed: T216619: Add the foreign resources integrity check to MediaWiki's unit tests.
Fri, Jun 21, 10:15 PM · Technical-Debt, Librarization, MediaWiki-Core-Testing
Jdforrester-WMF added a subtask for T203694: Run ForeignResourceManager verification on MediaWiki core commits: T216620: Add error detection to HTTP fetch in foreign resources checker before gzipping.
Fri, Jun 21, 10:15 PM · MediaWiki-Core-Testing, Performance-Team, MediaWiki-ResourceLoader, Continuous-Integration-Config
Jdforrester-WMF removed a subtask for T216619: Add the foreign resources integrity check to MediaWiki's unit tests: T216620: Add error detection to HTTP fetch in foreign resources checker before gzipping.
Fri, Jun 21, 10:15 PM · Librarization, MediaWiki-Core-Testing
Jdforrester-WMF added a project to T226281: [Regression wmf.10] VE does not open/crashes if only a link is added/edited in a session, error in the console "jQuery.Deferred exception: Cannot read property 'height' of undefined TypeError: Cannot read property 'height' of undefined": VisualEditor-MediaWiki.

I'd say that this is definitely needing an urgent fix but it's not quite so bad as to be a revert-production issue. It's relatively rare that people edit the same page twice without editing, and it's particularly rare for them to do so having only added a single link.

Fri, Jun 21, 8:27 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor (Current work), VisualEditor-MediaWiki
Jdforrester-WMF added a project to T226253: Composer\Downloader\TransportException in CI builds for multiple repositories: Release-Engineering-Team.
Fri, Jun 21, 6:35 PM · Release-Engineering-Team-TODO, Release-Engineering-Team, Wikimedia-production-error (Shared Build Failure)
Jdforrester-WMF added a subtask for T224906: Drop php56 testing support: T224591: Migrate contint* hosts to Stretch/Buster.
Fri, Jun 21, 6:28 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF added a parent task for T224591: Migrate contint* hosts to Stretch/Buster: T224906: Drop php56 testing support.
Fri, Jun 21, 6:28 PM · Continuous-Integration-Infrastructure (phase-out-jessie), Operations
Jdforrester-WMF removed a parent task for T226224: Provide php72 on contint1001 rather than php56: T224906: Drop php56 testing support.
Fri, Jun 21, 6:28 PM · serviceops, Continuous-Integration-Infrastructure
Jdforrester-WMF removed a subtask for T224906: Drop php56 testing support: T226224: Provide php72 on contint1001 rather than php56.
Fri, Jun 21, 6:28 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF added a comment to T226224: Provide php72 on contint1001 rather than php56.

OK, will switch out with T224591.

Fri, Jun 21, 6:28 PM · serviceops, Continuous-Integration-Infrastructure
Jdforrester-WMF closed T226244: Phan fails with php72 on WikibaseLexeme as Resolved.

Thank you for fixing this.

Fri, Jun 21, 6:13 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, phan, Continuous-Integration-Config, User-Michael, Wikidata-Campsite
Jdforrester-WMF added projects to T226276: Fix Parsoid PHP code so that phpunit coverage is happy: Parsoid, Test-Coverage.
Fri, Jun 21, 6:00 PM · Patch-For-Review, Parsoid-PHP, Test-Coverage
Jdforrester-WMF created T226276: Fix Parsoid PHP code so that phpunit coverage is happy.
Fri, Jun 21, 5:59 PM · Patch-For-Review, Parsoid-PHP, Test-Coverage
Jdforrester-WMF closed T219319: Parsoid/PHP post-merge doc publishing task needs updating to use PHP 7.2 as Resolved.

OK, the task as filed is indeed fixed. Will put in a follow-up.

Fri, Jun 21, 5:57 PM · Continuous-Integration-Config, Parsoid-PHP
Jdforrester-WMF closed T219319: Parsoid/PHP post-merge doc publishing task needs updating to use PHP 7.2, a subtask of T225457: Move all CI generic tasks from PHP70 to PHP72, as Resolved.
Fri, Jun 21, 5:57 PM · Continuous-Integration-Config
Jdforrester-WMF added a comment to T207344: Phan-taint-check-plugin not available for PHP > 7.0.

Thank you! I'm happy to help in whatever way I can.

Fri, Jun 21, 5:42 PM · Security-Team, Release-Engineering-Team (Kanban), phan-taint-check-plugin
Jdforrester-WMF updated the task description for T224908: Drop jessie testing support.
Fri, Jun 21, 5:36 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Continuous-Integration-Infrastructure (phase-out-jessie)
Jdforrester-WMF updated the task description for T224908: Drop jessie testing support.
Fri, Jun 21, 5:32 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Continuous-Integration-Infrastructure (phase-out-jessie)
Jdforrester-WMF awarded T226233: Rebuild integration-slave-docker-* instances to use less RAM, new name and Stretch a Like token.
Fri, Jun 21, 5:05 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure (phase-out-jessie)
Jdforrester-WMF added a subtask for T224906: Drop php56 testing support: T226224: Provide php72 on contint1001 rather than php56.
Fri, Jun 21, 12:19 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Infrastructure
Jdforrester-WMF added a parent task for T226224: Provide php72 on contint1001 rather than php56: T224906: Drop php56 testing support.
Fri, Jun 21, 12:19 AM · serviceops, Continuous-Integration-Infrastructure
Jdforrester-WMF created T226224: Provide php72 on contint1001 rather than php56.
Fri, Jun 21, 12:18 AM · serviceops, Continuous-Integration-Infrastructure

Thu, Jun 20

Jdforrester-WMF added a parent task for T226109: Jobs not being executed on 1.34.0-wmf.10: T220736: 1.34.0-wmf.11 deployment blockers.
Thu, Jun 20, 11:02 PM · Analytics, EventBus, Services (done), Core Platform Team Kanban (Done with CPT), Operations, WMF-JobQueue, MassMessage
Jdforrester-WMF added a subtask for T220736: 1.34.0-wmf.11 deployment blockers: T226109: Jobs not being executed on 1.34.0-wmf.10.
Thu, Jun 20, 11:02 PM · Release-Engineering-Team (Kanban), Release, Train Deployments
Jdforrester-WMF added a parent task for T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content: T220736: 1.34.0-wmf.11 deployment blockers.
Thu, Jun 20, 11:01 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Wikimedia-production-error
Jdforrester-WMF added a subtask for T220736: 1.34.0-wmf.11 deployment blockers: T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content.
Thu, Jun 20, 11:01 PM · Release-Engineering-Team (Kanban), Release, Train Deployments
Jdforrester-WMF added a comment to T224851: Please centralize enwiki's feedback for VisualEditor .

Sorry, this is impossible without reversing T148611.

Thu, Jun 20, 8:24 PM · VisualEditor (Current work)
Jdforrester-WMF changed the status of T200657: Remove old log-show-hide-[type] messages in extensions (after 1.31 LTS is over - June 2021) from Open to Stalled.
Thu, Jun 20, 6:30 PM · good first bug, MediaWiki-Logging
Jdforrester-WMF added a comment to T207344: Phan-taint-check-plugin not available for PHP > 7.0.

Oh, and all that code has been written into a feature branch so jenkins is blind to it. Fun. :-(

Thu, Jun 20, 5:51 PM · Security-Team, Release-Engineering-Team (Kanban), phan-taint-check-plugin
Jdforrester-WMF added a comment to T226064: mwext-php70-phan-seccheck-docker blocking merges.

It wasn't a local patch, it was just that environment variables like this are normally injected by *zuul* not *jjb*. And the phan and seccheck jobs do share some common config, which was prematurely removed.

Thu, Jun 20, 5:16 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config
Jdforrester-WMF lowered the priority of T226102: BadMethodCallException on Commons: /includes/specials/pagers/ImageListPager.php: Call to a member function getUrl() on a non-object (boolean) from Unbreak Now! to High.

So this is provisionally fixed but we can't tell until the train rolls forward to Commons, is that right?

Thu, Jun 20, 3:23 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MediaWiki-Special-pages, Multimedia, Commons, Wikimedia-production-error

Tue, Jun 18

Jdforrester-WMF lowered the priority of T226064: mwext-php70-phan-seccheck-docker blocking merges from Unbreak Now! to High.

No longer blocking merges, but pretty bad. Pinging @Bawolff and @Legoktm who might know of a local patch to jjb for these jobs.

Tue, Jun 18, 11:22 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config
Jdforrester-WMF added a project to T226064: mwext-php70-phan-seccheck-docker blocking merges: Release-Engineering-Team (Kanban).
Tue, Jun 18, 11:17 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config
Jdforrester-WMF added a comment to T226064: mwext-php70-phan-seccheck-docker blocking merges.

Working supposition is that someone made a local patch and pushed it via jjb without committing it ages ago, and it got accidentally wiped out when jjb seccheck jobs were updated earlier today.

Tue, Jun 18, 11:11 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config
Jdforrester-WMF added a project to T207344: Phan-taint-check-plugin not available for PHP > 7.0: Security-Team.
Tue, Jun 18, 11:08 PM · Security-Team, Release-Engineering-Team (Kanban), phan-taint-check-plugin
Jdforrester-WMF moved T220866: Switch Fresnel for MediaWiki jobs from php70 to php72 from Backlog to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.
Tue, Jun 18, 10:54 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Config, Performance-Team, Fresnel
Jdforrester-WMF moved T224907: Drop php55 testing support from Backlog to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.
Tue, Jun 18, 10:54 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure (phase-out-jessie)
Jdforrester-WMF moved T225832: Move coverage tasks from PHP70 to PHP72 from Backlog to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.
Tue, Jun 18, 10:54 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Config
Jdforrester-WMF added a comment to T226064: mwext-php70-phan-seccheck-docker blocking merges.

Locally, docker run --rm --env THING_SUBNAME=extensions/OATHAuth -v /Users/jdforrester/Documents/code/vagrant/mediawiki:/mediawiki docker-registry.wikimedia.org/releng/mediawiki-phan-seccheck:0.3.2 -m checkstyle passes. I've not touched the image for the docker image or the jjb definition (just the correlated php72 ones).

Tue, Jun 18, 10:49 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config
Jdforrester-WMF added a project to T220866: Switch Fresnel for MediaWiki jobs from php70 to php72: Release-Engineering-Team (Kanban).
Tue, Jun 18, 10:46 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Config, Performance-Team, Fresnel
Jdforrester-WMF edited projects for T224907: Drop php55 testing support, added: Release-Engineering-Team (Kanban); removed Release-Engineering-Team.
Tue, Jun 18, 10:01 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure (phase-out-jessie)
Jdforrester-WMF edited projects for T225832: Move coverage tasks from PHP70 to PHP72, added: Release-Engineering-Team (Kanban); removed Patch-For-Review.
Tue, Jun 18, 10:01 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Config
Jdforrester-WMF closed T218442: Hide successful PipelineBot messages from wikibugs's feed, the same way we do for jenkins-bot as Resolved.
Tue, Jun 18, 10:00 PM · Release-Engineering-Team, Release Pipeline, Wikibugs
Jdforrester-WMF edited projects for T226028: CI uses PHP7.2 packages from sury.org instead of SRE ones, added: Release-Engineering-Team (Kanban); removed Patch-For-Review.

https://gerrit.wikimedia.org/r/517754 fixes it. Fun. Merged, rebuilt the images, and php72 jobs should now actually work again. :-)

Tue, Jun 18, 9:55 PM · Release-Engineering-Team (Kanban), PHP 7.2 support, Continuous-Integration-Infrastructure
Jdforrester-WMF added a comment to T226028: CI uses PHP7.2 packages from sury.org instead of SRE ones.

quibble-stretch-php72:0.0.31-5 build fails for me locally.

Tue, Jun 18, 9:44 PM · Release-Engineering-Team (Kanban), PHP 7.2 support, Continuous-Integration-Infrastructure
Jdforrester-WMF added a comment to T226028: CI uses PHP7.2 packages from sury.org instead of SRE ones.

Doesn't look like this was built?

Tue, Jun 18, 9:41 PM · Release-Engineering-Team (Kanban), PHP 7.2 support, Continuous-Integration-Infrastructure
Jdforrester-WMF moved T207344: Phan-taint-check-plugin not available for PHP > 7.0 from Backlog to Blocked (externally) on the Release-Engineering-Team (Kanban) board.
Tue, Jun 18, 9:01 PM · Security-Team, Release-Engineering-Team (Kanban), phan-taint-check-plugin
Jdforrester-WMF added a project to T207344: Phan-taint-check-plugin not available for PHP > 7.0: Release-Engineering-Team (Kanban).

This is now the last remaining blocker to moving CI to newer versions of PHP (and dropping PHP support in MediaWiki). Prioritisation would be appreciated.

Tue, Jun 18, 9:01 PM · Security-Team, Release-Engineering-Team (Kanban), phan-taint-check-plugin
Jdforrester-WMF added a subtask for T225456: Run phan on PHP 7.2, not PHP 7.0: T207344: Phan-taint-check-plugin not available for PHP > 7.0.
Tue, Jun 18, 9:00 PM · Patch-For-Review, Continuous-Integration-Config, Release-Engineering-Team (Kanban)
Jdforrester-WMF added a parent task for T207344: Phan-taint-check-plugin not available for PHP > 7.0: T225456: Run phan on PHP 7.2, not PHP 7.0.
Tue, Jun 18, 9:00 PM · Security-Team, Release-Engineering-Team (Kanban), phan-taint-check-plugin
Jdforrester-WMF added a comment to T225456: Run phan on PHP 7.2, not PHP 7.0.

OK, phan is moved over, and phan-sec-check is left to move over.

Tue, Jun 18, 8:45 PM · Patch-For-Review, Continuous-Integration-Config, Release-Engineering-Team (Kanban)
Jdforrester-WMF closed T225832: Move coverage tasks from PHP70 to PHP72 as Resolved.

Upgraded and working:

Tue, Jun 18, 8:08 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Config
Jdforrester-WMF closed T225832: Move coverage tasks from PHP70 to PHP72, a subtask of T225457: Move all CI generic tasks from PHP70 to PHP72, as Resolved.
Tue, Jun 18, 8:08 PM · Continuous-Integration-Config
Jdforrester-WMF merged T225840: Quibble fails at the mysql_install_db step on PHP72? into T226040: quibble-coverage docker image fails at mysql_install_db step.
Tue, Jun 18, 7:32 PM · Patch-For-Review, Continuous-Integration-Infrastructure