Page MenuHomePhabricator

Jdforrester-WMF (James D. Forrester)
Software Engineer

Projects (77)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:08 PM (328 w, 4 d)
Availability
Available
IRC Nick
James_F
LDAP User
Jforrester
MediaWiki User
Jdforrester (WMF) [ Global Accounts ]

I've been a Wikipedia editor since 2002 on the English Wikipedia and a few other Wikimedia projects. In May 2012, I joined the Wikimedia Foundation as a "product manager", initially for VisualEditor, the the Editing Team, and later the lead product manager for all contribution. In 2018, I moved to be a software engineer, working on reliability, infrastructure, developer tooling, and continuous integration and deployment.

My job is to help ensure that the tools we provide to our readers and contributors are the best the can be, in speed, correctness, consistency, utility, and reliability.

Recent Activity

Yesterday

Jdforrester-WMF added a comment to T271575: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0.

A new release of HtmlFormatter is needed to include https://gerrit.wikimedia.org/r/c/HtmlFormatter/+/651996

Fri, Jan 22, 7:22 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Release, Patch-For-Review, Shellbox, RemexHtml, Equivset, PHP 8.0 support, MediaWiki-General
Jdforrester-WMF updated the task description for T271575: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0.
Fri, Jan 22, 7:17 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Release, Patch-For-Review, Shellbox, RemexHtml, Equivset, PHP 8.0 support, MediaWiki-General
Jdforrester-WMF added a comment to T272104: Allow modules to opt-in to ES6 syntax support.
  • Check that eval( 'var 𐋀;') (where 𐋀 is U+102C0 CARIAN LETTER G) does not throw an exception; this excludes Safari <= 13.1 and iOS < 14.

(we wouldn't have to check for the scope shadowing and template string caching bugs, because those only affect browsers that also fail the Unicode characters in variable names test)

Fri, Jan 22, 1:43 AM · Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader

Thu, Jan 21

Jdforrester-WMF updated the task description for T269712: Migrate afl_filter to afl_filter_id and afl_global.
Thu, Jan 21, 10:59 PM · Patch-For-Review, AbuseFilter
Jdforrester-WMF updated the task description for T269712: Migrate afl_filter to afl_filter_id and afl_global.
Thu, Jan 21, 10:52 PM · Patch-For-Review, AbuseFilter
Jdforrester-WMF updated the task description for T269713: Run the MigrateAflFilter script for AbuseFilter.
Thu, Jan 21, 9:07 PM · User-Urbanecm, Wikimedia-maintenance-script-run, AbuseFilter
Jdforrester-WMF removed a project from T272615: Some buttons seem too close together: OOUI.

Not a problem with the library.

Thu, Jan 21, 4:55 PM · Design, MediaWiki-extensions-GlobalWatchlist, User-DannyS712
Jdforrester-WMF committed rMTPSd74557320d3b: Avoid backpropagating EXEC taints to local function variables (authored by Daimona).
Avoid backpropagating EXEC taints to local function variables
Thu, Jan 21, 5:50 AM
Jdforrester-WMF committed rMTPSb2ddd1ae03da: Don't link parameters of functions with hardcoded taintedness (authored by Daimona).
Don't link parameters of functions with hardcoded taintedness
Thu, Jan 21, 5:50 AM
Jdforrester-WMF committed rMTPS8120d02b2e1a: Improve caused-by lines (authored by Daimona).
Improve caused-by lines
Thu, Jan 21, 5:50 AM
Tgr awarded T68108: [Epic] Store media information for files on Wikimedia Commons as structured data a Yellow Medal token.
Thu, Jan 21, 5:32 AM · GLAM-Tech, Multimedia, Commons, Epic, Wikidata, SDC General
Jdforrester-WMF closed T68108: [Epic] Store media information for files on Wikimedia Commons as structured data as Resolved.

I'm going to boldly claim this is Resolved, though of course there's loads more to do. All credit to the current and former members of the Structured Data on Commons team, from the Foundation, WMDE, and the community.

Thu, Jan 21, 5:18 AM · GLAM-Tech, Multimedia, Commons, Epic, Wikidata, SDC General
Jdforrester-WMF closed T68108: [Epic] Store media information for files on Wikimedia Commons as structured data, a subtask of T19503: Provide metadata support on Wikimedia Commons, as Resolved.
Thu, Jan 21, 5:17 AM · Commons, Wikimedia-Extension-setup
Jdforrester-WMF closed T68108: [Epic] Store media information for files on Wikimedia Commons as structured data, a subtask of T51662: VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog, as Resolved.
Thu, Jan 21, 5:17 AM · VisualEditor, VisualEditor-EditingTools
Jdforrester-WMF closed T68108: [Epic] Store media information for files on Wikimedia Commons as structured data, a subtask of T53032: When inserting an image, set its caption by default to be the Commons image description, as Resolved.
Thu, Jan 21, 5:17 AM · Patch-For-Review, VisualEditor, VisualEditor-EditingTools

Wed, Jan 20

Jdforrester-WMF changed the status of T272108: Change EnWiki logo's back to the standard one, on or after 2021-02-04 from Stalled to Open.

No longer "Stalled", which in Phabricator terms means "waiting for outside input".

Wed, Jan 20, 7:11 PM · Wikimedia-Site-requests
Jdforrester-WMF added a parent task for T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos: T272518: Watch for extensions broken by WikiPage now deprecating construction on bad titles.
Wed, Jan 20, 5:57 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, MediaWiki-extensions-FlaggedRevs, ci-test-error
Jdforrester-WMF added a subtask for T272518: Watch for extensions broken by WikiPage now deprecating construction on bad titles: T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.
Wed, Jan 20, 5:57 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
Jdforrester-WMF created T272518: Watch for extensions broken by WikiPage now deprecating construction on bad titles.
Wed, Jan 20, 5:55 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
Jdforrester-WMF added a project to T260861: Use Z4/Type to validate instances: Epic.
Wed, Jan 20, 5:38 PM · Epic, Abstract Wikipedia (Phase β)
Jdforrester-WMF added a parent task for T269702: Work out how async WL function evaluator returns plug in to synchronous ParserOutput page painting: T272516: Provide a mechanism by which editors can make Wikifunctions calls in wikitext.
Wed, Jan 20, 5:31 PM · Epic, Abstract Wikipedia
Jdforrester-WMF added a subtask for T272516: Provide a mechanism by which editors can make Wikifunctions calls in wikitext: T269702: Work out how async WL function evaluator returns plug in to synchronous ParserOutput page painting.
Wed, Jan 20, 5:31 PM · Epic, Abstract Wikipedia
Jdforrester-WMF added a subtask for T272515: Provide nice ways for editors to insert and update Wikifunctions calls in VisualEditor: T272514: Export data from Wikifunctions/WikiLambda into TemplateData so users can easily reuse them.
Wed, Jan 20, 5:31 PM · Abstract Wikipedia
Jdforrester-WMF added a parent task for T272514: Export data from Wikifunctions/WikiLambda into TemplateData so users can easily reuse them: T272515: Provide nice ways for editors to insert and update Wikifunctions calls in VisualEditor.
Wed, Jan 20, 5:31 PM · Abstract Wikipedia
Jdforrester-WMF added a project to T272516: Provide a mechanism by which editors can make Wikifunctions calls in wikitext: Epic.
Wed, Jan 20, 5:30 PM · Epic, Abstract Wikipedia
Jdforrester-WMF created T272516: Provide a mechanism by which editors can make Wikifunctions calls in wikitext.
Wed, Jan 20, 5:29 PM · Epic, Abstract Wikipedia
Jdforrester-WMF created T272515: Provide nice ways for editors to insert and update Wikifunctions calls in VisualEditor.
Wed, Jan 20, 5:29 PM · Abstract Wikipedia
Jdforrester-WMF created T272514: Export data from Wikifunctions/WikiLambda into TemplateData so users can easily reuse them.
Wed, Jan 20, 5:28 PM · Abstract Wikipedia

Tue, Jan 19

Jdforrester-WMF closed T271614: Code gets copied double-spaced on new syntax-highlighted pages on Firefox as Resolved.
Tue, Jan 19, 11:40 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), SyntaxHighlight
Jdforrester-WMF added a comment to T272428: Error 1146: Table 'mediawikiwiki.translate_cache' doesn't exist.

Aha, yeah, that's it.

Tue, Jan 19, 10:14 PM · Privacy Engineering, Patch-For-Review, Language-Team (Language-2021-January-March), MediaWiki-extensions-Translate, DBA, User-brennen, Wikimedia-production-error
Jdforrester-WMF added a comment to T272428: Error 1146: Table 'mediawikiwiki.translate_cache' doesn't exist.

Code defining and using this table was added for T182433: Implement a stronger synchronization in RepoNG and Translate in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/628631 which would have first rolled to production in wmf.25; not sure if there's a config flag preventing code attempting to read from the DB before it's created, but looks like not. Nothing in the SAL about creating the table; should be trivial, but oops.

Tue, Jan 19, 10:04 PM · Privacy Engineering, Patch-For-Review, Language-Team (Language-2021-January-March), MediaWiki-extensions-Translate, DBA, User-brennen, Wikimedia-production-error
Jdforrester-WMF added a comment to T253461: Liberate the @ for AtEase.

This should probably have a custom sniff to spot use of AtEase and require use of phpcs:ignore instead.

Tue, Jan 19, 9:22 PM · TechCom, MediaWiki-Codesniffer, Proposal, at-ease, MediaWiki-General
Jdforrester-WMF assigned T272399: PHP 8.0 support to Urbanecm.
Tue, Jan 19, 7:56 PM · User-Urbanecm, PHP 8.0 support, Release-Engineering-Team (CI & Testing services), stewardbots
Jdforrester-WMF added a comment to T266186: Conflicting information on Docker Hub regarding maintainership.

That links directly to https://docs.docker.com/docker-hub/official_images/ which makes clear they're 'official' for Docker, not for us, though?

Tue, Jan 19, 6:43 PM · Docker-Hub-MediaWiki
Jdforrester-WMF created T272399: PHP 8.0 support.
Tue, Jan 19, 5:01 PM · User-Urbanecm, PHP 8.0 support, Release-Engineering-Team (CI & Testing services), stewardbots
Jdforrester-WMF added a project to T272326: DeprecationHelperTest throws `ReflectionException: Property TestDeprecatedClass::$nonExistent does not exist` on PHP 8.0: MediaWiki-Core-Testing.
Tue, Jan 19, 12:10 AM · Patch-For-Review, MediaWiki-Core-Testing, MediaWiki-General, PHP 8.0 support
Jdforrester-WMF added a comment to T272328: MimeAnalyzer throws `ValueError: Path cannot be empty` on PHP 8.0.

Said code is wrapped in Wikimedia\suppressWarnings(), but I suppose that's magically now insufficient?

Tue, Jan 19, 12:06 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), MediaWiki-libs-Mime, Performance-Team, PHP 8.0 support
Jdforrester-WMF added a comment to T266583: MediaWiki 1.35 should be compatible with PHP 8 per PHP support policy.

We're getting pretty close to being able to enable PHP 8.0 on CI for REL1_35 of MediaWiki itself; some outstanding ones I spotted (not a complete list):

Tue, Jan 19, 12:05 AM · MW-1.35-release, PHP 8.0 support, MediaWiki-General

Mon, Jan 18

Jdforrester-WMF created T272328: MimeAnalyzer throws `ValueError: Path cannot be empty` on PHP 8.0.
Mon, Jan 18, 11:58 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), MediaWiki-libs-Mime, Performance-Team, PHP 8.0 support
Jdforrester-WMF renamed T272327: Exif throws `TypeError: abs(): Argument #1 ($num) must be of type int|float, string given` on PHP 8.0 from FormatMetadataTest throws `TypeError: abs(): Argument #1 ($num) must be of type int|float, string given` on PHP 8.0 to Exif throws `TypeError: abs(): Argument #1 ($num) must be of type int|float, string given` on PHP 8.0.
Mon, Jan 18, 11:57 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), MW-1.35-notes, MediaWiki-General, PHP 8.0 support
Jdforrester-WMF created T272327: Exif throws `TypeError: abs(): Argument #1 ($num) must be of type int|float, string given` on PHP 8.0.
Mon, Jan 18, 11:55 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), MW-1.35-notes, MediaWiki-General, PHP 8.0 support
Krinkle awarded T213295: Close and delete TestCommons from production a Orange Medal token.
Mon, Jan 18, 11:54 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO, Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, Structured Data Engineering, Wiki-Setup (Delete / Redirect)
Jdforrester-WMF created T272326: DeprecationHelperTest throws `ReflectionException: Property TestDeprecatedClass::$nonExistent does not exist` on PHP 8.0.
Mon, Jan 18, 11:54 PM · Patch-For-Review, MediaWiki-Core-Testing, MediaWiki-General, PHP 8.0 support
Jdforrester-WMF closed T269710: MW 1.35 Library Bumps for PHP 8.0 as Resolved.

I believe this is now done.

Mon, Jan 18, 11:52 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), MW-1.35-notes, PHP 8.0 support, MediaWiki-Vendor, MW-1.35-release
Jdforrester-WMF closed T269710: MW 1.35 Library Bumps for PHP 8.0, a subtask of T266583: MediaWiki 1.35 should be compatible with PHP 8 per PHP support policy, as Resolved.
Mon, Jan 18, 11:51 PM · MW-1.35-release, PHP 8.0 support, MediaWiki-General
Jdforrester-WMF closed T272320: bodh: Add backed to CI/CD, a subtask of T272317: bodh: Implement backend, as Resolved.
Mon, Jan 18, 11:46 PM · Tool-bodh
Jdforrester-WMF closed T272320: bodh: Add backed to CI/CD as Resolved.
Mon, Jan 18, 11:46 PM · Tool-bodh
Jdforrester-WMF updated the task description for T271575: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0.
Mon, Jan 18, 11:22 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Release, Patch-For-Review, Shellbox, RemexHtml, Equivset, PHP 8.0 support, MediaWiki-General
Jdforrester-WMF added a comment to T271968: Upload wizard should automatically update public domain year in mwe-upwiz-license-pd-old-70-1923 and mwe-upwiz-license-pd-us.

The fact that something is automatic does not mean that it gives bad advice. As for "it is not much work to manually update": I do not know if it is much or little, but apparently nobody wants to do such work.

Mon, Jan 18, 12:24 AM · Commons, UploadWizard
Jdforrester-WMF moved T272250: CookieTest::testValidateCookieDomain fails on PHP 8.0 from Backlog to MediaWiki core on the PHP 8.0 support board.
Mon, Jan 18, 12:18 AM · MW-1.35-notes, Patch-For-Review, MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), PHP 8.0 support, MediaWiki-General
Jdforrester-WMF created T272250: CookieTest::testValidateCookieDomain fails on PHP 8.0.
Mon, Jan 18, 12:18 AM · MW-1.35-notes, Patch-For-Review, MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), PHP 8.0 support, MediaWiki-General
Jdforrester-WMF added a comment to T272248: AbuseFilter-triggered API errors on Beta Commons: FilterRunner::checkFilter() must be an instance of ExistingFilter, instance of Filter given.

https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=User:Lucas_Werkmeister/sandbox&oldid=229222 created; Resolved?

Mon, Jan 18, 12:09 AM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), AbuseFilter, Beta-Cluster-reproducible

Sun, Jan 17

Jdforrester-WMF added a parent task for T272248: AbuseFilter-triggered API errors on Beta Commons: FilterRunner::checkFilter() must be an instance of ExistingFilter, instance of Filter given: T271341: 1.36.0-wmf.27 deployment blockers.
Sun, Jan 17, 11:39 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), AbuseFilter, Beta-Cluster-reproducible
Jdforrester-WMF added a subtask for T271341: 1.36.0-wmf.27 deployment blockers: T272248: AbuseFilter-triggered API errors on Beta Commons: FilterRunner::checkFilter() must be an instance of ExistingFilter, instance of Filter given.
Sun, Jan 17, 11:39 PM · User-brennen, Patch-For-Review, Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), Release, Train Deployments
Jdforrester-WMF moved T271789: Bump web-auth/* to 3.3 for PHP 8.0 support from Backlog to Wikimedia production on the PHP 8.0 support board.
Sun, Jan 17, 7:30 PM · Patch-For-Review, PHP 8.0 support, MediaWiki-extensions-OATHAuth
Jdforrester-WMF closed T235266: Composer Library Updates, late 2019/early 2020 edition as Resolved.

And only took us 15 months!

Sun, Jan 17, 3:53 AM · Composer, MediaWiki-General
Jdforrester-WMF closed T242751: Update monolog/monolog to 2.1.1 or later, a subtask of T196906: Sensible default parameters for Monolog logging, as Resolved.
Sun, Jan 17, 3:41 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Team Workboards (External Code Reviews), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, MediaWiki-Debug-Logger
Jdforrester-WMF closed T242751: Update monolog/monolog to 2.1.1 or later, a subtask of T247675: Stop overriding LogstashFormatter format, as Resolved.
Sun, Jan 17, 3:41 AM · Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Technical-Debt, Wikimedia-Logstash, MediaWiki-Debug-Logger
Jdforrester-WMF closed T242751: Update monolog/monolog to 2.1.1 or later, a subtask of T248925: Make MediaWiki compatible with PHP 8, as Resolved.
Sun, Jan 17, 3:41 AM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group
Jdforrester-WMF closed T242751: Update monolog/monolog to 2.1.1 or later, a subtask of T235266: Composer Library Updates, late 2019/early 2020 edition, as Resolved.
Sun, Jan 17, 3:41 AM · Composer, MediaWiki-General
Jdforrester-WMF closed T242751: Update monolog/monolog to 2.1.1 or later, a subtask of T268207: mediawiki/core composer error: "The requested package monolog/monolog ^1.22 exists as monolog/monolog[2.0.2] but these are rejected by your constraint.", as Resolved.
Sun, Jan 17, 3:41 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, MediaWiki-Vagrant, MediaWiki-General, Composer
Jdforrester-WMF closed T242751: Update monolog/monolog to 2.1.1 or later as Resolved.

Fingers crossed.

Sun, Jan 17, 3:41 AM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), PHP 8.0 support, Platform Team Workboards (Clinic Duty Team), Wikimedia-Logstash, MediaWiki-Debug-Logger, Patch-For-Review, MediaWiki-Vendor
Jdforrester-WMF moved T271575: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0 from Backlog to MediaWiki core on the PHP 8.0 support board.
Sun, Jan 17, 3:40 AM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Release, Patch-For-Review, Shellbox, RemexHtml, Equivset, PHP 8.0 support, MediaWiki-General
Jdforrester-WMF closed T271428: Bump php-ast to 1.0.10 for all phan jobs as Resolved.

Yes.

Sun, Jan 17, 1:18 AM · Patch-For-Review, Continuous-Integration-Config, Release-Engineering-Team, phan-taint-check-plugin, phan

Sat, Jan 16

Jdforrester-WMF created T272231: WikiLambda initial installation fails when TemplateData is installed.
Sat, Jan 16, 10:05 PM · Abstract Wikipedia (Phase γ), VisualEditor, TemplateData
Jdforrester-WMF created MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).
Sat, Jan 16, 9:25 PM
Jdforrester-WMF created MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).
Sat, Jan 16, 9:24 PM
Jdforrester-WMF created MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).
Sat, Jan 16, 9:24 PM
Jdforrester-WMF created MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).
Sat, Jan 16, 9:24 PM
Jdforrester-WMF created MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).
Sat, Jan 16, 9:23 PM
Jdforrester-WMF archived MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).
Sat, Jan 16, 9:20 PM
Jdforrester-WMF closed T245963: Deprecate User::getGrantName in favor of MWGrants::grantName as Resolved.
Sat, Jan 16, 8:21 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), User-Majavah, MediaWiki-General, User-DannyS712, Technical-Debt (Deprecation process)
Jdforrester-WMF added a comment to T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.

Can we add flagged revs to MW gate? This is maybe the 5th time over a year I remember FlaggedRevs being broken by core changes, so it seems like a good addition to MW gate

Sat, Jan 16, 6:32 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, MediaWiki-extensions-FlaggedRevs, ci-test-error
Jdforrester-WMF merged T272224: beta-scap-eqiad job failing with `sudo: ldap_start_tls_s(): Can't contact LDAP server`, 2021-01-16 into T272216: deployment-deploy01 is out of disk space, causing beta-scap-eqiad to fail.
Sat, Jan 16, 5:40 PM · Beta-Cluster-Infrastructure, Release-Engineering-Team
Jdforrester-WMF merged task T272224: beta-scap-eqiad job failing with `sudo: ldap_start_tls_s(): Can't contact LDAP server`, 2021-01-16 into T272216: deployment-deploy01 is out of disk space, causing beta-scap-eqiad to fail.
Sat, Jan 16, 5:39 PM · Beta-Cluster-Infrastructure
Jdforrester-WMF added a comment to T272224: beta-scap-eqiad job failing with `sudo: ldap_start_tls_s(): Can't contact LDAP server`, 2021-01-16.

Going to assume this is the same as T272216: deployment-deploy01 is out of disk space, causing beta-scap-eqiad to fail.

Sat, Jan 16, 5:39 PM · Beta-Cluster-Infrastructure
Jdforrester-WMF created T272224: beta-scap-eqiad job failing with `sudo: ldap_start_tls_s(): Can't contact LDAP server`, 2021-01-16.
Sat, Jan 16, 5:37 PM · Beta-Cluster-Infrastructure
Jdforrester-WMF added a comment to T271122: Restore IRC alerts for beta-scap-eqiad job.
08:35:29 <mw-jenkinsbot> Project beta-scap-eqiad build #334134: STILL FAILING in 1 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334134/
08:45:28 <mw-jenkinsbot> Project beta-scap-eqiad build #334135: STILL FAILING in 1 min 6 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334135/
08:55:28 <mw-jenkinsbot> Project beta-scap-eqiad build #334136: STILL FAILING in 1 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334136/
09:05:31 <mw-jenkinsbot> Project beta-scap-eqiad build #334137: STILL FAILING in 1 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334137/
09:15:33 <mw-jenkinsbot> Project beta-scap-eqiad build #334138: STILL FAILING in 1 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334138/
09:25:38 <mw-jenkinsbot> Project beta-scap-eqiad build #334139: STILL FAILING in 1 min 13 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334139/
Sat, Jan 16, 5:35 PM · Jenkins, Release-Engineering-Team-TODO, Continuous-Integration-Infrastructure
Jdforrester-WMF awarded T269950: Introduce a section title container to make talk page conversations more legible a Like token.
Sat, Jan 16, 5:31 PM · Patch-For-Review, Editing Design, DiscussionTools, Editing-team
Jdforrester-WMF created T272195: Transition all Wikimedia production code from $.Deferred to native Promises.
Sat, Jan 16, 12:18 AM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Front-end-Standards-Group, JavaScript, MediaWiki-Interface

Fri, Jan 15

Jdforrester-WMF added a comment to T269713: Run the MigrateAflFilter script for AbuseFilter.

The config patch should be merged first (I forgot to follow-up 2 days ago)

Actually, discard that. The stage is already WRITE_BOTH as that's the default in AbuseFilter. You can start running the script whenever you please.

Fri, Jan 15, 11:36 PM · User-Urbanecm, Wikimedia-maintenance-script-run, AbuseFilter
Jdforrester-WMF closed T271792: Put line numbers in left side also in RTL wikis as Resolved.
Fri, Jan 15, 9:41 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, RTL, I18n
Jdforrester-WMF closed T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos as Resolved.

OK, things look fixed.

Fri, Jan 15, 9:14 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, MediaWiki-extensions-FlaggedRevs, ci-test-error
Jdforrester-WMF assigned T269713: Run the MigrateAflFilter script for AbuseFilter to Urbanecm.
Fri, Jan 15, 9:04 PM · User-Urbanecm, Wikimedia-maintenance-script-run, AbuseFilter
Jdforrester-WMF added a comment to T269713: Run the MigrateAflFilter script for AbuseFilter.

Thanks!

Fri, Jan 15, 9:04 PM · User-Urbanecm, Wikimedia-maintenance-script-run, AbuseFilter
Jdforrester-WMF added a comment to T208776: RFC: Introduce PageIdentity to be used instead of WikiPage.

Yeah, rMW8f46ef5ff4cf: Make WikiPage a ProperPageIdentity and rMW36f1adf670fc: Define equality for PageIdentity and LinkTarget have had to be reverted; sorry.

Fri, Jan 15, 8:48 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), TechCom-RFC (TechCom-RFC-Closed), Patch-For-Review, Platform Team Initiatives (Decoupling (CDP2))
Jdforrester-WMF claimed T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.
Fri, Jan 15, 8:47 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, MediaWiki-extensions-FlaggedRevs, ci-test-error
Jdforrester-WMF renamed T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos from "FlaggablePageTest::testPageDataFromTitle" erroring on all MediaWiki patches to "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.
Fri, Jan 15, 6:04 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, MediaWiki-extensions-FlaggedRevs, ci-test-error
Jdforrester-WMF changed the status of T208776: RFC: Introduce PageIdentity to be used instead of WikiPage from Stalled to Open.

RfC approved, patches are landing -> clearly not Stalled.

Fri, Jan 15, 6:01 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), TechCom-RFC (TechCom-RFC-Closed), Patch-For-Review, Platform Team Initiatives (Decoupling (CDP2))
Jdforrester-WMF changed the status of T208776: RFC: Introduce PageIdentity to be used instead of WikiPage, a subtask of T195069: Factor PageStore and PageRecord out of WikiPage, from Stalled to Open.
Fri, Jan 15, 6:01 PM · MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition), Epic, Patch-For-Review, Platform Engineering Roadmap, Code-Health-Objective
Jdforrester-WMF added a comment to T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.

Looks like this error is new in rMW8f46ef5ff4cf: Make WikiPage a ProperPageIdentity.

Fri, Jan 15, 5:55 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, MediaWiki-extensions-FlaggedRevs, ci-test-error
Jdforrester-WMF added a comment to T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.
Fri, Jan 15, 5:51 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, MediaWiki-extensions-FlaggedRevs, ci-test-error
Jdforrester-WMF triaged T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos as Unbreak Now! priority.
Fri, Jan 15, 5:47 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, MediaWiki-extensions-FlaggedRevs, ci-test-error
Jdforrester-WMF awarded T270775: Arrange diffs with CSS grid layout a Like token.
Fri, Jan 15, 5:02 PM · Patch-For-Review, MediaWiki-Page-diffs
Jdforrester-WMF updated the task description for T269713: Run the MigrateAflFilter script for AbuseFilter.
Fri, Jan 15, 1:06 AM · User-Urbanecm, Wikimedia-maintenance-script-run, AbuseFilter
Jdforrester-WMF updated subscribers of T269713: Run the MigrateAflFilter script for AbuseFilter.

OK, and it's now fully run (automatically) for Beta Cluster. Are we confident that there were no issues? If we're happy to proceed, does @Urbanecm want to run this AF update in prod, like they did the last one?

Fri, Jan 15, 1:06 AM · User-Urbanecm, Wikimedia-maintenance-script-run, AbuseFilter
Jdforrester-WMF added a comment to T269712: Migrate afl_filter to afl_filter_id and afl_global.

Thanks!

Fri, Jan 15, 1:05 AM · Patch-For-Review, AbuseFilter
Jdforrester-WMF added a comment to T269712: Migrate afl_filter to afl_filter_id and afl_global.

Whoops, there's a missing quote.

The weird part is, I'm sure I had tested this script locally some time ago and it worked...

Fri, Jan 15, 12:55 AM · Patch-For-Review, AbuseFilter
Jdforrester-WMF updated the task description for T272108: Change EnWiki logo's back to the standard one, on or after 2021-02-04.
Fri, Jan 15, 12:48 AM · Wikimedia-Site-requests
Jdforrester-WMF closed T267033: CommonsMetadata bad wfTimestamp call as Resolved.

This is resolved, right?

Fri, Jan 15, 12:38 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Structured-Data-Backlog, Structured Data Engineering, Release-Engineering-Team (Logspam), User-DannyS712, CommonsMetadata