Page MenuHomePhabricator

Jdforrester-WMF (James D. Forrester)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:08 PM (262 w, 1 h)
Availability
Available
IRC Nick
James_F
LDAP User
Jforrester
MediaWiki User
Jdforrester (WMF) [ Global Accounts ]

I've been a Wikipedia editor since 2002 on the English Wikipedia and a few other Wikimedia projects. In May 2012, I joined the Wikimedia Foundation as a "product manager", initially for VisualEditor, the the Editing Team, and later the lead product manager for all contribution. In 2018, I moved to be a software engineer, working on reliability, infrastructure, developer tooling, and continuous integration and deployment.

My job is to help ensure that the tools we provide to our readers and contributors are the best the can be, in speed, correctness, consistency, utility, and reliability.

Recent Activity

Sat, Oct 12

Jdforrester-WMF committed rEQS1fac3ba89b08: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Sat, Oct 12, 7:15 PM

Fri, Oct 11

Jdforrester-WMF committed rERSLf99e981ee7cd: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 10:46 PM
Jdforrester-WMF committed rEULK256930503d89: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 10:40 PM
Jdforrester-WMF committed rERLS9d2d1bf11f52: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 10:14 PM
Jdforrester-WMF committed rELUA4a93593abfbf: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 10:14 PM
Jdforrester-WMF committed rEWET6e8a7d79db4f: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 10:14 PM
Jdforrester-WMF committed rESMXed8a8f0526ff: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 9:15 PM
Jdforrester-WMF committed rSCBL4139f04a1a82: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 9:10 PM
Jdforrester-WMF committed rESPB5a7886977243: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 8:53 PM
Jdforrester-WMF committed rEPHD7d9a8723fd26: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 8:39 PM
Jdforrester-WMF committed rETBL412cea8fef1f: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 8:26 PM
Jdforrester-WMF committed rSMNB7a12fac7a12b: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 8:25 PM
Jdforrester-WMF committed rESHGe84c4b6ec2c1: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 8:20 PM
Jdforrester-WMF committed rEHIEca88f4174655: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 8:17 PM
Jdforrester-WMF committed rETSA50723ef5056e: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Fri, Oct 11, 8:14 PM
Jdforrester-WMF added a comment to T235107: Change tags disclose non-public information about editors.

Perhaps for symmetry we should also tag desktop and wikitext edits, so that were not calling out the others as unusual.

Fri, Oct 11, 12:51 AM · Wikipedia-Android-App-Backlog, Advanced Mobile Contributions, Android-app-Bugs, iOS-app-Bugs, Mobile, Wikipedia-iOS-App-Backlog, MediaWiki-Change-tagging, Privacy
Jdforrester-WMF committed rECIRf18678c535af: Remove php requirement from composer.json (authored by Reedy).
Remove php requirement from composer.json
Fri, Oct 11, 12:38 AM

Thu, Oct 10

Jdforrester-WMF removed a project from T234418: Upgrade our php-xdebug package for php7.2: PHP 7.2 support.
Thu, Oct 10, 10:53 PM · serviceops, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
Jdforrester-WMF added a comment to T228346: PHP 7.2 garbage collector segfault.

Given we've now upgraded to 7.2.22 in prod, is this now Resolved?

Thu, Oct 10, 10:53 PM · Patch-For-Review, Parsoid-PHP, PHP 7.2 support
Jdforrester-WMF closed T211470: selenium tests are flaky under php7 on TemplateWizard as Resolved.
Thu, Oct 10, 10:52 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), ci-test-error, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), User-zeljkofilipin, PHP 7.2 support, MediaWiki-extensions-TemplateWizard, Community-Tech
Jdforrester-WMF added a comment to T235107: Change tags disclose non-public information about editors.

The reason user agents are PII are because they act like a fingerprint for cross-tabulation with other sources of the same data. For ultra-small populations (like Solid users – hi, TimBL – or BeOS users, or whatever) knowing the user agent / platform might move slightly towards individual privacy concerns, but this is pretty trivial.

Thu, Oct 10, 10:44 PM · Wikipedia-Android-App-Backlog, Advanced Mobile Contributions, Android-app-Bugs, iOS-app-Bugs, Mobile, Wikipedia-iOS-App-Backlog, MediaWiki-Change-tagging, Privacy
Jdforrester-WMF added a comment to T211539: Beta Cluster cross-wiki login request would be blocked by CSP.

I'm going to have to wade through MW's CSP code to work out what's not working.

Thu, Oct 10, 10:28 PM · Performance-Team (Radar), Beta-Cluster-Infrastructure, Beta-Cluster-reproducible, MediaWiki-extensions-CentralAuth, Security-Team
Jdforrester-WMF awarded T234632: Wikimedia Technical Conference 2019 Session: Local development environment - MediaWiki core a Pterodactyl token.
Thu, Oct 10, 10:08 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
Jdforrester-WMF closed T196206: Bump symfony libraries when we no longer need hhvm support as Resolved.
Thu, Oct 10, 9:53 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, MediaWiki-General
Jdforrester-WMF moved T234881: TreeModifier: remover does not skip over a deleted node immediately following a text node from Code review to QA on the VisualEditor (Current work) board.

Deployed.

Thu, Oct 10, 9:42 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-ContentEditable
Jdforrester-WMF added a comment to T231636: Butcher the list of phan suppressions in MW core.

Resolved?

Thu, Oct 10, 9:15 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Clinic Duty Team), phan, MediaWiki-Core-Testing
Jdforrester-WMF added a comment to T235021: mwext-php72-phan-seccheck-docker fails for Collection extension.

Thank you!

Thu, Oct 10, 8:57 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), phan-taint-check-plugin, Jenkins, Collection
Jdforrester-WMF closed T230340: Set up CI for mediawiki/tools/api-testing as Resolved.
Thu, Oct 10, 8:36 PM · Release-Engineering-Team-TODO (201910), Release-Engineering-Team (CI & Testing services), Core Platform Team Workboards (Purple), Continuous-Integration-Config, CPT Initiatives (API Integration Tests)
Jdforrester-WMF closed T230340: Set up CI for mediawiki/tools/api-testing, a subtask of T231893: Run tests automatically when tests changed, as Resolved.
Thu, Oct 10, 8:36 PM · Story, Core Platform Team Workboards (User Stories), CPT Initiatives (API Integration Tests), Code-Health
Jdforrester-WMF edited projects for T230340: Set up CI for mediawiki/tools/api-testing, added: Release-Engineering-Team-TODO (201910); removed Release-Engineering-Team-TODO.
Thu, Oct 10, 8:35 PM · Release-Engineering-Team-TODO (201910), Release-Engineering-Team (CI & Testing services), Core Platform Team Workboards (Purple), Continuous-Integration-Config, CPT Initiatives (API Integration Tests)
Jdforrester-WMF moved T234580: Add pipeline config and publish step for restbase dev docker image from INBOX to Doing on the Release-Engineering-Team-TODO (201910) board.
Thu, Oct 10, 7:47 PM · Patch-For-Review, Release-Engineering-Team-TODO (201910), Release-Engineering-Team (Local Dev), local-charts, Developer Productivity, Epic
Jdforrester-WMF moved T229510: Define code review metrics from INBOX to Doing on the Release-Engineering-Team-TODO (201910) board.
Thu, Oct 10, 7:39 PM · Release-Engineering-Team-TODO (201910), Code-Review-Workgroup
Jdforrester-WMF closed T233143: Quibble should fatal out on clone/fetch failure"ERROR:zuul.Repo:Unable to initialize repo for npm-test.git" as Resolved.
Thu, Oct 10, 7:38 PM · Release-Engineering-Team-TODO (201910), Release-Engineering-Team (CI & Testing services), Quibble, Continuous-Integration-Config
Jdforrester-WMF moved T232165: Bump CI php72 images given we've moved production to 7.2.22 from INBOX to Ready on the Release-Engineering-Team-TODO (201910) board.
Thu, Oct 10, 7:37 PM · Patch-For-Review, Release-Engineering-Team-TODO (201910), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure
Jdforrester-WMF moved T228910: Move restbase chart from local-charts to deployment-charts repository from INBOX to Doing on the Release-Engineering-Team-TODO (201910) board.
Thu, Oct 10, 7:37 PM · Release-Engineering-Team-TODO (201910), RESTBase, Core Platform Team Workboards (Clinic Duty Team), Release-Engineering-Team (Local Dev), Developer Productivity, local-charts
Jdforrester-WMF moved T228915: Update local-charts repository to use restbase chart from deployment-charts repo from INBOX to Doing on the Release-Engineering-Team-TODO (201910) board.
Thu, Oct 10, 7:37 PM · Release-Engineering-Team-TODO (201910), Patch-For-Review, Release-Engineering-Team (Local Dev), Developer Productivity, local-charts
Jdforrester-WMF assigned T234580: Add pipeline config and publish step for restbase dev docker image to jeena.
Thu, Oct 10, 7:37 PM · Patch-For-Review, Release-Engineering-Team-TODO (201910), Release-Engineering-Team (Local Dev), local-charts, Developer Productivity, Epic
Jdforrester-WMF moved T235118: Create an integration test running Quibble with mediawiki/core from INBOX to Doing on the Release-Engineering-Team-TODO (201910) board.
Thu, Oct 10, 7:36 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201910), Quibble
Jdforrester-WMF assigned T235118: Create an integration test running Quibble with mediawiki/core to hashar.
Thu, Oct 10, 7:36 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201910), Quibble
Jdforrester-WMF moved T230446: Create composer-test-php70 docker image for fundraising tech's crm tests from INBOX to Doing on the Release-Engineering-Team-TODO (201910) board.
Thu, Oct 10, 7:36 PM · Patch-For-Review, Release-Engineering-Team-TODO (201910), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Fundraising-Backlog
Jdforrester-WMF closed T234767: Bump PHP support version in composer.json, a subtask of T196206: Bump symfony libraries when we no longer need hhvm support, as Resolved.
Thu, Oct 10, 7:23 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, MediaWiki-General
Jdforrester-WMF closed T234767: Bump PHP support version in composer.json as Resolved.
Thu, Oct 10, 7:23 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Release-Engineering-Team-TODO (201910), MediaWiki-General
Jdforrester-WMF closed T234062: ci-src-setup job (used by mediawiki-core-php72-phan-docker) is still running on PHP 7.0.33, a subtask of T192166: Drop HHVM support from MediaWiki, as Resolved.
Thu, Oct 10, 6:54 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes, TechCom, Core Platform Team Legacy (Watching / External), Patch-For-Review, HHVM
Jdforrester-WMF closed T234062: ci-src-setup job (used by mediawiki-core-php72-phan-docker) is still running on PHP 7.0.33, a subtask of T234767: Bump PHP support version in composer.json, as Resolved.
Thu, Oct 10, 6:54 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Release-Engineering-Team-TODO (201910), MediaWiki-General
Jdforrester-WMF closed T234062: ci-src-setup job (used by mediawiki-core-php72-phan-docker) is still running on PHP 7.0.33 as Resolved.
Thu, Oct 10, 6:54 PM · Release-Engineering-Team-TODO (201910), phan, Continuous-Integration-Config
Jdforrester-WMF added a comment to T234766: Consider what PHP 7.2 point release to use.

I asked if there was a specific reason why we're using .22 over .0 or whatever and ServiceOps said they aimed for latest&greatest from upstream.

Thu, Oct 10, 6:52 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes, Patch-For-Review, PHP 7.2 support, MW-1.34-release, MediaWiki-General
Jdforrester-WMF added a comment to T234766: Consider what PHP 7.2 point release to use.

7.2.9 seems fine by me.

Thu, Oct 10, 6:47 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes, Patch-For-Review, PHP 7.2 support, MW-1.34-release, MediaWiki-General
Jdforrester-WMF added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

This affected at least one export, possibly others.

Thu, Oct 10, 5:32 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
Jdforrester-WMF committed rEELA8bd860cd2390: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Thu, Oct 10, 4:47 AM
Jdforrester-WMF committed rEFILEEXPORTdc8dfcc3466a: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Thu, Oct 10, 2:59 AM
Jdforrester-WMF committed rEDIS33698344efb9: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Thu, Oct 10, 2:48 AM
Jdforrester-WMF committed rEEPS1e792417b1ce: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Thu, Oct 10, 2:24 AM
Jdforrester-WMF committed rEFFD21498ee77078: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Thu, Oct 10, 2:23 AM
Jdforrester-WMF committed rECPAe6b2d1f0ffaf: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Thu, Oct 10, 2:20 AM
Jdforrester-WMF committed rEGRAab760839819f: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Thu, Oct 10, 2:19 AM
Jdforrester-WMF committed rEGTO6aa6bac14b10: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Thu, Oct 10, 2:09 AM

Wed, Oct 9

Jdforrester-WMF committed rWMUI9fcb9d39282f: build: Update 'grunt-stylelint' (authored by Volker E <volker.e@wikimedia.org>).
build: Update 'grunt-stylelint'
Wed, Oct 9, 10:41 PM
Jdforrester-WMF committed rECITb960d9d4905f: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Wed, Oct 9, 10:15 PM
Jdforrester-WMF committed rECEX29ce12648ceb: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Wed, Oct 9, 10:15 PM
Jdforrester-WMF committed rEASR55922e36ddaa: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Wed, Oct 9, 10:11 PM
Jdforrester-WMF committed rEAFU1aa08efcc0f3: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v28.0.0
Wed, Oct 9, 10:11 PM
Jdforrester-WMF added a comment to T234907: RFC: Where to implement Desktop Improvements project.

The ability to differentiate a Wikimedia site (e.g. Wikipedia) from a third-party site running MediaWiki.

Just to confirm, by this you mean the new skin will not be the new default for mw and maybe not distributed with mediawiki, but still remain open source, right?

That's correct. The skin will be open source. By this requirement, we mean that we would like to establish a look and feel for the skin that is specific and most useful within Wikimedia projects. That said, if any third party finds it useful for their purposes, we wouldn't prevent them from using it in any way.

Wed, Oct 9, 4:23 PM · Desktop Improvements, Readers-Web-Backlog (Tracking), TechCom-RFC
Jdforrester-WMF added a comment to T233316: Deployment Pipeline fails with CPS error for Kartotherian.

Now you're back to the lerna: not found error we had before. How did this ever work?

Wed, Oct 9, 3:59 PM · Release-Engineering-Team-TODO (201910), Maps (Kartotherian), Release Pipeline, Release-Engineering-Team (Pipeline)

Tue, Oct 8

Jdforrester-WMF added a comment to T211539: Beta Cluster cross-wiki login request would be blocked by CSP.

Helps but doesn't fix. Let's try putting the wikis properly into CSPReportOnly mode?

Tue, Oct 8, 10:19 PM · Performance-Team (Radar), Beta-Cluster-Infrastructure, Beta-Cluster-reproducible, MediaWiki-extensions-CentralAuth, Security-Team
Jdforrester-WMF updated the task description for T72470: Remove legacy javascript globals.
Tue, Oct 8, 9:57 PM · MW-1.35-release, User-notice, Technical-Debt (Deprecation process), Performance-Team-publish, Performance-Team, MediaWiki-ResourceLoader, JavaScript
Jdforrester-WMF claimed T234767: Bump PHP support version in composer.json.
Tue, Oct 8, 9:53 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Release-Engineering-Team-TODO (201910), MediaWiki-General
Jdforrester-WMF changed the status of T196206: Bump symfony libraries when we no longer need hhvm support from Stalled to Open.

Not stalled. :-)

Tue, Oct 8, 9:52 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, MediaWiki-General
Jdforrester-WMF closed T232128: Make MultiHttpClient use CURLMOPT_MAX_HOST_CONNECTIONS and reuse connections as Resolved.
Tue, Oct 8, 9:52 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MediaWiki-libs-HTTP, Performance-Team (Radar), Core Platform Team Workboards (Clinic Duty Team)
Jdforrester-WMF changed the subtype of T220479: Improve rollback confirmation selenium tests from "Production Error" to "Task".
Tue, Oct 8, 8:46 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), WMDE-FUN-Sprint-2019-04-29, WMDE-FUN-Sprint-2019-04-15, WMDE-FUN-Sprint-2019-04-01, Confirmation prompt for rollback action, WMDE-FUN-Team
Jdforrester-WMF added a comment to T211539: Beta Cluster cross-wiki login request would be blocked by CSP.

https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/541603 and https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/541604 should help.

Tue, Oct 8, 7:20 PM · Performance-Team (Radar), Beta-Cluster-Infrastructure, Beta-Cluster-reproducible, MediaWiki-extensions-CentralAuth, Security-Team
Jdforrester-WMF added a comment to T211539: Beta Cluster cross-wiki login request would be blocked by CSP.

Yeah, the extension function in -labs seems to be getting run before the main one.

Tue, Oct 8, 7:02 PM · Performance-Team (Radar), Beta-Cluster-Infrastructure, Beta-Cluster-reproducible, MediaWiki-extensions-CentralAuth, Security-Team
Jdforrester-WMF added a comment to T231855: Allow using relative paths in array config vars.

While I'm happy for allowing an array of paths (that makes perfect sense), the relative-ness does give cause for concern
What's to stop a malicious extension reading arbitrary files from disk, and then doing whatever with them?

Tue, Oct 8, 6:51 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Security, Structured Data Engineering, Structured-Data-Backlog, MediaWiki-extensions-WikibaseRepository, MediaWiki-Configuration, Wikidata
Jdforrester-WMF added a comment to T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; try restarting transaction.

In IRC, @Ladsgroup suggested that this is likely interplay between edit load being a bit too high and the running migration script (to let us drop wb_terms, T221764).

Tue, Oct 8, 4:02 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Wikimedia-database-error, Wikidata
Jdforrester-WMF added a comment to T214984: PHP7's stricter JSON parsing breaks some wiki content.

Do I get this right, to make the following showcase map work without Lua, now there isn't a more readable way than removing all newlines from SPARQL?
https://www.mediawiki.org/wiki/Help:Extension:Kartographer#GeoShapes_via_Wikidata_Query

Tue, Oct 8, 3:34 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support
Jdforrester-WMF added a comment to T234743: User rights validation is malfunctioning.

As noted in T233561#5532950 the start of these issues roughly coincides with variant settings being introduced. Since that involves an extra config cache layer, maybe what's happening is that the behavior is different on cache hit and cache miss for some reason.

Tue, Oct 8, 3:32 PM · Release-Engineering-Team, User-DannyS712, MediaWiki-User-management
Jdforrester-WMF added a watcher for Code-Review-Workgroup: Jdforrester-WMF.
Tue, Oct 8, 2:24 PM

Mon, Oct 7

Jdforrester-WMF moved T234623: releng/composer still using PHP 7.0.33 from INBOX to Completed on the Release-Engineering-Team-TODO (201910) board.
Mon, Oct 7, 11:06 PM · Release-Engineering-Team-TODO (201910), Continuous-Integration-Config
Jdforrester-WMF closed T234623: releng/composer still using PHP 7.0.33 as Resolved.
Mon, Oct 7, 11:06 PM · Release-Engineering-Team-TODO (201910), Continuous-Integration-Config
Jdforrester-WMF added a comment to T223393: switch wikitech to PHP 7.2.

Well, we can pin this wiki for special treatment for a week or two if needed.

Mon, Oct 7, 9:29 PM · cloud-services-team (Kanban), Release-Engineering-Team-TODO, wikitech.wikimedia.org, PHP 7.2 support, serviceops, Operations
Jdforrester-WMF added a project to T223393: switch wikitech to PHP 7.2: Release-Engineering-Team-TODO.
Mon, Oct 7, 9:21 PM · cloud-services-team (Kanban), Release-Engineering-Team-TODO, wikitech.wikimedia.org, PHP 7.2 support, serviceops, Operations
Jdforrester-WMF raised the priority of T223393: switch wikitech to PHP 7.2 from Low to High.

If this isn't done before tomorrow, the train rollout will break wikitechwiki. :-(

Mon, Oct 7, 9:21 PM · cloud-services-team (Kanban), Release-Engineering-Team-TODO, wikitech.wikimedia.org, PHP 7.2 support, serviceops, Operations
Jdforrester-WMF closed T232028: Prune /vendor for REL1_34, a subtask of T232023: Release MW 1.34, as Resolved.
Mon, Oct 7, 7:36 PM · Core Platform Team, MediaWiki-Releasing, MW-1.34-notes, MW-1.34-release
Jdforrester-WMF closed T232028: Prune /vendor for REL1_34 as Resolved.
Mon, Oct 7, 7:36 PM · Core Platform Team, MediaWiki-Releasing, MW-1.34-notes, MW-1.34-release
Jdforrester-WMF added a comment to T234768: Create Balinese Wikipedia.

I have added the logo to the task description, so that's all clear.
However, the main namespace translations are in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/541109/ waiting to be merged – I don't know if we have to wait for that to be deployed on Wikimedia wikis, or if the change can be backported?

Mon, Oct 7, 6:45 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, User-Ladsgroup, User-Urbanecm, Wiki-Setup (Create)
Jdforrester-WMF added a comment to T232759: Move CI selenium/qunit tests of mediawiki repository to a standalone job.

I do wonder if the gate vs non-gate variants are useful for extensions that are in the gate. Especially given the number of dependencies Wikibase has, it might be just as good (or better) to not have the non-gate variant run there at all?

Mon, Oct 7, 6:43 PM · Release-Engineering-Team-TODO, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config
Jdforrester-WMF added a comment to T234610: ERROR webdriver: Request failed due to Error: session not created: Chrome version must be between 70 and 73.

Yeah, running selenium via the CI images is probably the best choice for long-term developer sanity.

Mon, Oct 7, 6:40 PM · Patch-For-Review, User-zeljkofilipin, MediaWiki-Core-Testing, Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO (201910)
Jdforrester-WMF added a comment to T220589: Support phan in MediaWiki's default composer.json.

OK, this is done from the CI end, right? We now "just" need to do a release of mediawiki-phan-config with the dependency and then remove the 'extra' field when bumping all the repos to the new release?

Mon, Oct 7, 5:36 PM · phan, MediaWiki-Core-Testing, MediaWiki-General
Jdforrester-WMF closed T192166: Drop HHVM support from MediaWiki, a subtask of T192167: Upgrade PHPUnit from 4/6 to 8, as Resolved.
Mon, Oct 7, 5:29 PM · Patch-For-Review, PHP 7.4 support, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-Core-Testing
Jdforrester-WMF closed T192166: Drop HHVM support from MediaWiki, a subtask of T220589: Support phan in MediaWiki's default composer.json, as Resolved.
Mon, Oct 7, 5:29 PM · phan, MediaWiki-Core-Testing, MediaWiki-General
Jdforrester-WMF closed T192166: Drop HHVM support from MediaWiki, a subtask of T196206: Bump symfony libraries when we no longer need hhvm support, as Resolved.
Mon, Oct 7, 5:29 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, MediaWiki-General
Jdforrester-WMF closed T192166: Drop HHVM support from MediaWiki, a subtask of T231636: Butcher the list of phan suppressions in MW core, as Resolved.
Mon, Oct 7, 5:29 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Clinic Duty Team), phan, MediaWiki-Core-Testing
Jdforrester-WMF closed T192166: Drop HHVM support from MediaWiki, a subtask of T232128: Make MultiHttpClient use CURLMOPT_MAX_HOST_CONNECTIONS and reuse connections, as Resolved.
Mon, Oct 7, 5:29 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MediaWiki-libs-HTTP, Performance-Team (Radar), Core Platform Team Workboards (Clinic Duty Team)
Jdforrester-WMF closed T192166: Drop HHVM support from MediaWiki, a subtask of T231710: Recommend PHP7-only features after dropping HHVM support, as Resolved.
Mon, Oct 7, 5:29 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), PHP 7.0 support, Code-Health
Jdforrester-WMF closed T192166: Drop HHVM support from MediaWiki as Resolved.

I'm declaring this Resolved.

Mon, Oct 7, 5:28 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes, TechCom, Core Platform Team Legacy (Watching / External), Patch-For-Review, HHVM
Jdforrester-WMF closed T192166: Drop HHVM support from MediaWiki, a subtask of T234236: Drop HHVM support from MediaWiki-Vagrant, as Resolved.
Mon, Oct 7, 5:28 PM · MediaWiki-Vagrant, HHVM
Jdforrester-WMF moved T234384: Drop HHVM from CI from Doing to Completed on the Release-Engineering-Team-TODO (201910) board.
Mon, Oct 7, 5:28 PM · HHVM, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201910)
Jdforrester-WMF closed T234384: Drop HHVM from CI, a subtask of T192166: Drop HHVM support from MediaWiki, as Resolved.
Mon, Oct 7, 5:28 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes, TechCom, Core Platform Team Legacy (Watching / External), Patch-For-Review, HHVM
Jdforrester-WMF closed T234384: Drop HHVM from CI as Resolved.
Mon, Oct 7, 5:28 PM · HHVM, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201910)
Jdforrester-WMF closed T234733: User field in OOUI Special:Contributions is very short, a subtask of T117736: Convert Special:Contributions to OOUI, as Invalid.
Mon, Oct 7, 5:12 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-notice, MediaWiki-Special-pages, User-Jdlrobson, UI-Standardization-Kanban, UI-Standardization
Jdforrester-WMF closed T234733: User field in OOUI Special:Contributions is very short as Invalid.

Sounds like this is a user script issue.

Mon, Oct 7, 5:12 PM · MediaWiki-Special-pages, UI-Standardization