Page MenuHomePhabricator

Jdforrester-WMF (James D. Forrester)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:08 PM (269 w, 5 d)
Availability
Available
IRC Nick
James_F
LDAP User
Jforrester
MediaWiki User
Jdforrester (WMF) [ Global Accounts ]

I've been a Wikipedia editor since 2002 on the English Wikipedia and a few other Wikimedia projects. In May 2012, I joined the Wikimedia Foundation as a "product manager", initially for VisualEditor, the the Editing Team, and later the lead product manager for all contribution. In 2018, I moved to be a software engineer, working on reliability, infrastructure, developer tooling, and continuous integration and deployment.

My job is to help ensure that the tools we provide to our readers and contributors are the best the can be, in speed, correctness, consistency, utility, and reliability.

Recent Activity

Yesterday

Jdforrester-WMF added a comment to T240068: Page Content Service summary endpoint "extract" value does not vary per Accept-Language, and returns different output from expected LanguageConverter results.

From quick local testing, curl -s -H 'Accept-Language: zh-Hans' -XGET https://zh.wikipedia.org/api/rest_v1/page/summary/%E7%A7%8D%E4%B8%96%E8%A1%A1, curl -s -H 'Accept-Language: zh-Hans-CN' -XGET https://zh.wikipedia.org/api/rest_v1/page/summary/%E7%A7%8D%E4%B8%96%E8%A1%A1, curl -s -H 'Accept-Language: zh-Hant' -XGET https://zh.wikipedia.org/api/rest_v1/page/summary/%E7%A7%8D%E4%B8%96%E8%A1%A1 and curl -s -H 'Accept-Language: zh-Hant-HK' -XGET https://zh.wikipedia.org/api/rest_v1/page/summary/%E7%A7%8D%E4%B8%96%E8%A1%A1 return different results, but only vary on the displaytitle value, the titles.display value (which… is the same?) and tid (as expected). In particular, lang is wrongly set to unvarianted zh, and the extract and extract_html values appear to be unvarianted zh-Hant or zh-Hans; not sure how which is picked.

Sat, Dec 7, 10:29 PM · Chinese-Sites, MediaWiki-Language-converter, Product-Infrastructure-Team-Backlog, Page Content Service
Jdforrester-WMF renamed T240068: Page Content Service summary endpoint "extract" value does not vary per Accept-Language, and returns different output from expected LanguageConverter results from Page Content Service does not work well with LanguageConverter to Page Content Service summary endpoint "extract" value does not vary per Accept-Language, and returns different output from expected LanguageConverter results.
Sat, Dec 7, 10:24 PM · Chinese-Sites, MediaWiki-Language-converter, Product-Infrastructure-Team-Backlog, Page Content Service
Jdforrester-WMF updated the task description for T195542: Convert all Wikimedia-deployed extensions and skins to lint JavaScript via eslint, not jshint/jscs.
Sat, Dec 7, 10:05 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Majavah, Google-Code-in-2019, Technical-Debt, JavaScript
Jdforrester-WMF closed T239757: CirrusSearch is not compatible with PHP7.4 as Resolved.

Thank you!

Sat, Dec 7, 9:59 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), CirrusSearch, Discovery-Search, PHP 7.4 support
Jdforrester-WMF added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

I was thinking about how to progress the migration. Given the high number of "broken" tests, I'd suggest to:

  • Add forward-compat methods to PHPUnit6And8Compat. For instance:
function assertIsArray( ... ) {
   if( is_callable( [ $this, 'assertIsArray' ] ) {
     $this->assertIsArray( ... )
   } else {
     $this->assertInternalType( ... )
   }
}

Right now, I see that we're going with "suppress the rest", but I believe that the option above could save us some time.

I also see another way forward: upgrade to PHPUnit 7 as a temporary step. It already has assertIs* methods, and assertInternalType is not yet deprecated there. This means that we can start migrating to the new methods in extensions without using the trait. Again, LibUp will do most of the work here.

@MaxSem I've seen your patches around for suppressing stuff, so I wanted to ask you how would you feel about the proposals above.

Sat, Dec 7, 9:50 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Fri, Dec 6

Jdforrester-WMF closed T233418: Fatal exception of type "Wikimedia\Assert\PostconditionException" (page with an invalid title on Pashto Wikipedia) as Resolved.

I think that's just the script being screwy. All looks good.

Fri, Dec 6, 10:16 PM · Navigation-Popups, Wikimedia-production-error, MediaWiki-General, Readers-Web-Backlog (Tracking)
Jdforrester-WMF added a comment to T240055: Craft a deployment strategy to transition Parsoid/PHP from a faux extension to a composer library without breaking incoming requests.

"Just" have the version of MW-core where the library is introduced hard-code the pointer?

Fri, Dec 6, 10:14 PM · serviceops, Parsoid-PHP
Jdforrester-WMF added a comment to T233418: Fatal exception of type "Wikimedia\Assert\PostconditionException" (page with an invalid title on Pashto Wikipedia).
jforrester@mwmaint1002:/srv/mediawiki-staging$ mwscript namespaceDupes.php --wiki=pswiki
0 pages to fix, 0 were resolvable.
Fri, Dec 6, 10:02 PM · Navigation-Popups, Wikimedia-production-error, MediaWiki-General, Readers-Web-Backlog (Tracking)
Jdforrester-WMF closed T236309: define requirements for new devtools cloud vps project to replace "git", "gerrit" and "phabricator", a subtask of T240047: Request creation of devtools VPS project, as Resolved.
Fri, Dec 6, 8:34 PM · Cloud-VPS (Project-requests)
Jdforrester-WMF closed T236309: define requirements for new devtools cloud vps project to replace "git", "gerrit" and "phabricator" as Resolved.
Fri, Dec 6, 8:34 PM · Phabricator, Gerrit
Jdforrester-WMF moved T235356: Fatal from ApiGraph->getGraphSpec: "Call to a member function getExtensionData() on boolean" from Oct 2019 / 1.35.wmf.1+ to Resolved on the Wikimedia-production-error board.
Fri, Dec 6, 6:35 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Editing-team, MediaWiki-extensions-Graph, Wikimedia-production-error
Jdforrester-WMF closed T235356: Fatal from ApiGraph->getGraphSpec: "Call to a member function getExtensionData() on boolean" as Resolved.

Current error rate is way down (probably a function of editing patterns): https://logstash.wikimedia.org/app/kibana#/dashboard/Fatal-Monitor?_g=(refreshInterval%3A(display%3AOff%2Cpause%3A!f%2Cvalue%3A0)%2Ctime%3A(from%3Anow-60d%2Cmode%3Aquick%2Cto%3Anow))

Fri, Dec 6, 6:35 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Editing-team, MediaWiki-extensions-Graph, Wikimedia-production-error
Jdforrester-WMF added a comment to T239660: Integrate Parsoid/PHP with core as a composer library.

I am going to unlink this with the subtask because in its current form, I am likely going to decline. I'll post my reasoning shortly and we can discuss and retarget it appropriately.

Fri, Dec 6, 6:19 PM · Parsoid-PHP
Jdforrester-WMF added a comment to T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".

Deployed (to group0); all seems quiet, but we're not going to roll the train on a Friday (especially as it caused a site outage last time).

Fri, Dec 6, 6:11 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-production-error
Jdforrester-WMF added a comment to T239968: `cli/dump.php` does not accept the --votes modifier.

(Now merged.)

Fri, Dec 6, 6:05 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-extensions-SecurePoll, Core Platform Team
mmodell awarded T239815: mobileapps-periodic-test failing since 2019-12-04 01:00 UTC due to failing git fetches a Cookie token.
Fri, Dec 6, 5:24 PM · Release-Engineering-Team-TODO (201912), Page Content Service, Continuous-Integration-Infrastructure, Product-Infrastructure-Team-Backlog
Jdforrester-WMF added a comment to T239979: Migrate fail-archived-repositories job to a new host.

Or we could just drop this job? It's very low-value, and a lot of repos don't have it…

Fri, Dec 6, 5:15 PM · Release-Engineering-Team-TODO (201912), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure (phase-out-jessie)
Jdforrester-WMF added a comment to T239973: Review and remove unneeded wmg* variables.

Moving code from InitialiseSettings to CommonSettings slows the site down a tad. Please wait for the migration to YAML, which won't have this limitation.

Fri, Dec 6, 5:14 PM · Cleanup, User-DannyS712, Wikimedia-Site-requests
Jdforrester-WMF added a comment to T216826: Move Kartotherian and Tilerator to Kubernetes.

@Mathew.onipe and @Jdforrester-WMF just FYI: I have tested kartotherian with debian buster and upstream mapnik library and it works just fine, which is a good thing since our backported mapnik library is outdated in comparison with debian stable (buster).

Fri, Dec 6, 12:14 AM · Patch-For-Review, Epic, Operations, Maps (Kartotherian)

Thu, Dec 5

Jdforrester-WMF added a comment to T235263: Make it possible to bypass automatic redirection to exact matches in commons.

OK, this is now deployed.

Thu, Dec 5, 11:50 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work), Discovery-Search (Current work), MediaWiki-Search, Discovery, Commons
Jdforrester-WMF added a parent task for T88258: Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration: T239137: Replace individual wfLoadExtension calls with a loop operating over an array.
Thu, Dec 5, 11:22 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Wikidata-Trailblazing-Exploration, Story, Technical-Debt, wikidata-tech-focus, Wikidata-Turtles-Tech-Debt, Wikidata-Ministry-Of-Magic-Tech-Debt, Wikidata-Sprint-2017-12-20, Wikidata-Sprint-2015-08-11, Wikidata-Sprint-2015-06-30, Wikidata-Sprint-2015-06-16, Wikidata-Sprint-2015-06-02, MediaWiki-extensions-WikibaseRepository, Wikidata, MediaWiki-extensions-WikibaseClient
Jdforrester-WMF added a subtask for T239137: Replace individual wfLoadExtension calls with a loop operating over an array: T88258: Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration.
Thu, Dec 5, 11:22 PM · Release Pipeline, Release-Engineering-Team-TODO
Jdforrester-WMF added a comment to T239137: Replace individual wfLoadExtension calls with a loop operating over an array.

Not sure why that would be incompatible with the wikibase directory structure?

Thu, Dec 5, 11:22 PM · Release Pipeline, Release-Engineering-Team-TODO
Jdforrester-WMF updated the task description for T235142: Clean up mediawiki-config from HHVM-related configuration.
Thu, Dec 5, 11:07 PM · Wikimedia-Site-requests, HHVM
Jdforrester-WMF added a project to T239910: labs/toollabs testsuite fails when building the Debian package: Release-Engineering-Team-TODO (201912).
Thu, Dec 5, 11:05 PM · Release-Engineering-Team-TODO (201912), Release-Engineering-Team, cloud-services-team (Kanban)
Jdforrester-WMF added a comment to T239482: Update Doxygen in CI to 1.8.15 or greater.

I have a working backport for Doxygen 1.8.16 but that is using Buster. Our releng/doxygen container is based on Stretch..

Thu, Dec 5, 9:36 PM · Release-Engineering-Team-TODO (201912), Patch-For-Review, Release-Engineering-Team (CI & Testing services), doxygen, Continuous-Integration-Config, Documentation, Wikidata
Jdforrester-WMF committed rEARA27a60cdb24ea: Add license information for Extension:ArticleRatings (authored by jeropbrenda).
Add license information for Extension:ArticleRatings
Thu, Dec 5, 7:39 PM
Jdforrester-WMF reopened T21605: Hook 'EditFilterMerged' should be called after 'force edit summary' preference is enforced as "Open".
Thu, Dec 5, 6:07 PM · AbuseFilter, MediaWiki-Page-editing
Jdforrester-WMF merged task T132869: Endless loop between forceeditsummary and Abusefilter warnings into T21605: Hook 'EditFilterMerged' should be called after 'force edit summary' preference is enforced.
Thu, Dec 5, 6:07 PM · MediaWiki-Page-editing, AbuseFilter
Jdforrester-WMF merged T132869: Endless loop between forceeditsummary and Abusefilter warnings into T21605: Hook 'EditFilterMerged' should be called after 'force edit summary' preference is enforced.
Thu, Dec 5, 6:07 PM · AbuseFilter, MediaWiki-Page-editing
Jdforrester-WMF added a comment to T132869: Endless loop between forceeditsummary and Abusefilter warnings.

Please do not merge tasks in the wrong direction unless there is a massive amount more detail on the newer task.

Thu, Dec 5, 6:07 PM · MediaWiki-Page-editing, AbuseFilter
Jdforrester-WMF added a comment to T239911: [Spike] Decide how to guarantee Cite footnote body numbering.

"Good luck"? Replicating browser behaviour on DOM-order numbering will be challenging. We were previously planning to go the other way once we switch to Parsoid HTML for renders, and have items numbered entirely by the browser with nothing in the DOM at all, but your changes make that plan probably impossible now.

Thu, Dec 5, 6:04 PM · Parsing-Team, WMDE-Design, Book-Referencing, Design, Cite
Jdforrester-WMF added a comment to T239759: TimedMediaHandler is not compatible with PHP7.4.

Now last ones remaining in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-docker/25/console are from getID3, yup.

Thu, Dec 5, 6:00 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Upstream, TimedMediaHandler, PHP 7.4 support
Jdforrester-WMF renamed T239121: VE edit data stopped due to statsv falling over (?) on webperf1001 from VE edit data stopped at 2019-11-24Z00:57 and again at 2019-12-01Z22:45 to VE edit data stopped due to statsv falling over (?) on webperf1001.
Thu, Dec 5, 5:58 PM · Performance-Team (Radar), observability, Analytics, Editing-team
Jdforrester-WMF added a comment to T239121: VE edit data stopped due to statsv falling over (?) on webperf1001.

And again. @Ottomata, can you kick webperf1001 again?

Thu, Dec 5, 5:57 PM · Performance-Team (Radar), observability, Analytics, Editing-team
Jdforrester-WMF added a comment to T239935: Add a coordinate picker to OOUI.
  • Do you really mean "to OOUI", the library, or just as a MediaWiki widget? Are there use cases where adding this heavy functionality is necessary for non-MediaWiki environment tools e.g. things on ToolForge, or is this for use in extensions and gadgets?
  • The UploadWizard extension already has a rudimentary location-picker based on OOUI. Presumably this is insufficient? What features is it missing?
  • The Kartographer extension already has a rather advanced geo-plot picker, basedon OOUI and Leaflet. Presumably this is too complicated/heavyweight?
  • Who can answer these questions so that the right thing is built for the needs of the people voting in favour of it?
Thu, Dec 5, 5:39 PM · Maps, OOUI
Jdforrester-WMF added a comment to T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".

Apache worker count feel to 0 on the affected machines during the outage.

Thu, Dec 5, 12:09 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-production-error
Jdforrester-WMF updated the task description for T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".
Thu, Dec 5, 12:08 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-production-error

Wed, Dec 4

Jdforrester-WMF added a comment to T239771: Review and consolidate when user group rights are assigned.

Sounds good.

Wed, Dec 4, 11:25 PM · User-DannyS712, Proposal, Wikimedia-Site-requests
Jdforrester-WMF closed T239867: Address Parsoid/PHP noise from cluttering mediawiki train deployments, a subtask of T233856: 1.35.0-wmf.8 deployment blockers, as Resolved.
Wed, Dec 4, 11:22 PM · Release, Train Deployments
Jdforrester-WMF closed T239867: Address Parsoid/PHP noise from cluttering mediawiki train deployments as Resolved.
Wed, Dec 4, 11:22 PM · Patch-For-Review, Parsoid-PHP
Jdforrester-WMF added a comment to T239868: Logstash in Beta Cluster stopped ingesting messages from MediaWiki.

See also T211984: Logstash in beta fails periodically and T233134: logstash-beta.wmflabs.org does not receive any mediawiki events.

Wed, Dec 4, 10:14 PM · Operations, Beta-Cluster-Infrastructure, Wikimedia-Logstash
Jdforrester-WMF added a comment to T142081: Merge Wikimedia's "Deployment checklist for new extensions" doc pages.

Hey, I think this was a bad change (especially in how it implicitly excludes non-extensions), but oh-well, too late now.

Wed, Dec 4, 8:19 PM · Developer-Advocacy (Oct-Dec-2016), Release-Engineering-Team, Documentation
Jdforrester-WMF added a comment to T239771: Review and consolidate when user group rights are assigned.

Please do not create a new file for this stuff; there's enough crap I'm having to treat specially (like abusefilter.php), please don't add any more.

Wed, Dec 4, 8:16 PM · User-DannyS712, Proposal, Wikimedia-Site-requests
Jdforrester-WMF claimed T239815: mobileapps-periodic-test failing since 2019-12-04 01:00 UTC due to failing git fetches.

I believe this is now fixed; please confirm.

Wed, Dec 4, 7:42 PM · Release-Engineering-Team-TODO (201912), Page Content Service, Continuous-Integration-Infrastructure, Product-Infrastructure-Team-Backlog
Jdforrester-WMF added a project to T239815: mobileapps-periodic-test failing since 2019-12-04 01:00 UTC due to failing git fetches: Release-Engineering-Team-TODO (201912).
Wed, Dec 4, 7:23 PM · Release-Engineering-Team-TODO (201912), Page Content Service, Continuous-Integration-Infrastructure, Product-Infrastructure-Team-Backlog
Jdforrester-WMF added a comment to T239815: mobileapps-periodic-test failing since 2019-12-04 01:00 UTC due to failing git fetches.

It should be as simple as switching the url to gerrit. Generally I think it's a bad idea to have CI rely on phabricator which is sometimes out of date due to replication lag and phabricator's git hosting is essentially maintained as a best-effort service rather than a critical service that must have ~100% uptime.
I obviously can't comment on the value of this CI job.

tldr;

There is a real issue with phabricator that I am still working on, however, the fastest route to getting this job running again is to switch the url to gerrit.

Wed, Dec 4, 6:50 PM · Release-Engineering-Team-TODO (201912), Page Content Service, Continuous-Integration-Infrastructure, Product-Infrastructure-Team-Backlog
Jdforrester-WMF edited projects for T99740: Use static php array files for l10n cache instead of CDB, added: Scap; removed Deployments.
Wed, Dec 4, 4:56 PM · Scap, Performance-Team (Radar), MediaWiki-Internationalization
Jdforrester-WMF added a project to T111789: Disallow renaming own accounts with Special:GlobalRenameQueue: Core Platform Team.

Requesting code review from the Core Platform Team for this patch.

Wed, Dec 4, 4:15 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-Majavah, MediaWiki-extensions-CentralAuth, GlobalRename

Tue, Dec 3

Jdforrester-WMF edited projects for T239482: Update Doxygen in CI to 1.8.15 or greater, added: Release-Engineering-Team-TODO (201912); removed Release-Engineering-Team-TODO.
Tue, Dec 3, 10:50 PM · Release-Engineering-Team-TODO (201912), Patch-For-Review, Release-Engineering-Team (CI & Testing services), doxygen, Continuous-Integration-Config, Documentation, Wikidata
Jdforrester-WMF added a project to T236680: Enable API integration tests in CI for MediaWiki core: Release-Engineering-Team-TODO (201912).
Tue, Dec 3, 10:45 PM · Patch-For-Review, Release-Engineering-Team-TODO (201912), Core Platform Team Workboards (Green), CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
Jdforrester-WMF closed T239731: Deploy Wikisource extension to frwikisource as Resolved.
Tue, Dec 3, 10:37 PM · Wikimedia-Site-requests, Wikimedia-Extension-setup, Wikisource
Jdforrester-WMF closed T239731: Deploy Wikisource extension to frwikisource, a subtask of T210174: Deploy Wikisource extension to Wikimedia cluster, as Resolved.
Tue, Dec 3, 10:37 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Wikisource
Jdforrester-WMF added a comment to T210224: Revert FlaggedRevs changes on the Hungarian Wikipedia.

What's the status here? It seems like we've been over-running the "test" for seven months waiting for the analysis. Is that right?

Tue, Dec 3, 10:35 PM · Africa-Wikimedia-Developers, Patch-For-Review, Wikimedia-Site-requests
Jdforrester-WMF added a comment to T235263: Make it possible to bypass automatic redirection to exact matches in commons.

@Ramsey-WMF, your call as to when to deploy this to Commons; it's enabled on Test Commons as of a few seconds ago.

Tue, Dec 3, 10:22 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work), Discovery-Search (Current work), MediaWiki-Search, Discovery, Commons
Jdforrester-WMF reopened T29570: Sticky notes as "Open".

I don't think that talk pages are an appropriate solution for this product request.

Tue, Dec 3, 10:12 PM · MediaWiki-Page-editing
Jdforrester-WMF added a comment to T239759: TimedMediaHandler is not compatible with PHP7.4.

Cool.

Tue, Dec 3, 10:11 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Upstream, TimedMediaHandler, PHP 7.4 support
Jdforrester-WMF added a comment to T233012: Make MediaWiki core compatible with PHP 7.4.

Core itself works, but I'm not sure about all tarball extensions yet, so won't enable this there.

Tue, Dec 3, 9:42 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
Jdforrester-WMF created T239761: Wikibase is not compatible with PHP7.4.
Tue, Dec 3, 9:38 PM · Patch-For-Review, Wikidata-Campsite, Wikidata, PHP 7.4 support
Jdforrester-WMF created T239760: WikibaseLib is not compatible with PHP7.4.
Tue, Dec 3, 9:37 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Campsite, Wikidata, Wikibase-Quality-Constraints, PHP 7.4 support
Jdforrester-WMF created T239759: TimedMediaHandler is not compatible with PHP7.4.
Tue, Dec 3, 9:36 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Upstream, TimedMediaHandler, PHP 7.4 support
Jdforrester-WMF added a project to T239757: CirrusSearch is not compatible with PHP7.4: CirrusSearch.
Tue, Dec 3, 9:32 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), CirrusSearch, Discovery-Search, PHP 7.4 support
Jdforrester-WMF created T239757: CirrusSearch is not compatible with PHP7.4.
Tue, Dec 3, 9:31 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), CirrusSearch, Discovery-Search, PHP 7.4 support
Jdforrester-WMF closed T239727: MinervaNeue is not compatible with PHP7.4 as Resolved.
Tue, Dec 3, 9:17 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MinervaNeue, PHP 7.4 support
Jdforrester-WMF committed R2668:02a92f77ebc0: Create symlink for components/index.html pointing to links.html (#312) (authored by Volker E <Volker-E@users.noreply.github.com>).
Create symlink for components/index.html pointing to links.html (#312)
Tue, Dec 3, 9:17 PM
Jdforrester-WMF closed T239726: ConfirmEdit is not compatible with PHP7.4 as Resolved.
Tue, Dec 3, 8:54 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), ConfirmEdit (CAPTCHA extension), PHP 7.4 support
Jdforrester-WMF added projects to T239742: Should npm packages maintained by Wikimedia be scoped or unscoped?: Front-end-Standards-Group, Release-Engineering-Team-TODO.
Tue, Dec 3, 7:11 PM · TechCom, Release-Engineering-Team-TODO, Front-end-Standards-Group, Readers-Web-Backlog, Core Platform Team, Product-Infrastructure-Team-Backlog
Jdforrester-WMF added a comment to T210286: Migrate wikidata-query-gui-build to Docker containers.

@Addshore Should this be in CampSite, then?

Tue, Dec 3, 4:58 PM · Wikidata-Campsite, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Continuous-Integration-Infrastructure (Slipway), Wikidata Query UI, Wikidata
Jdforrester-WMF updated subscribers of T239726: ConfirmEdit is not compatible with PHP7.4.
Tue, Dec 3, 4:56 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), ConfirmEdit (CAPTCHA extension), PHP 7.4 support
Jdforrester-WMF added a comment to T239209: XSS in Visual Editor via Copy&Paste.

Update: I tried picking master to REL1_34 in gerrit and got a merge conflict. Not sure why - I'm not seeing any outstanding patches. And I'm not seeing any release branches for 1.31, 1.32 and 1.33. I see the various wmf/ branches for those releases in the repo, but not the REL1_xx branches to which we typically backport.

Tue, Dec 3, 4:55 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work), Security-Team, VisualEditor-CopyPaste, Vuln-XSS, Security
Jdforrester-WMF added a comment to T143037: Stop using jquery.tipsy in Wikimedia-maintained code.

jquery.tipsy does not have jquery.effects.* modules as dependencies. Is this task meant to be about "jquery.tipsy" instead of "jquery.effects" or is it meant to be about jquery (ui) effects and is Tipsy and unrelated subtask?

Tue, Dec 3, 4:49 PM · Technical-Debt, JavaScript, MediaWiki-General
Jdforrester-WMF created T239727: MinervaNeue is not compatible with PHP7.4.
Tue, Dec 3, 4:31 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MinervaNeue, PHP 7.4 support
Jdforrester-WMF created T239726: ConfirmEdit is not compatible with PHP7.4.
Tue, Dec 3, 4:30 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), ConfirmEdit (CAPTCHA extension), PHP 7.4 support
Jdforrester-WMF updated the task description for T233012: Make MediaWiki core compatible with PHP 7.4.
Tue, Dec 3, 4:19 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
Jdforrester-WMF closed T236628: ArticleRevisionViewCustom hook is unusable as Resolved.
Tue, Dec 3, 4:01 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.32-notes, MW-1.33-notes, Multi-Content-Revisions
Jdforrester-WMF added a comment to T239666: RESTBase requests to Parsoid/PHP that contain a "." in the title (without a /<revid> component) fail with a http 403.

Thank you, all!

Tue, Dec 3, 3:59 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ryasmeen, RESTBase, VisualEditor, Parsoid
Jdforrester-WMF updated the task description for T239666: RESTBase requests to Parsoid/PHP that contain a "." in the title (without a /<revid> component) fail with a http 403.
Tue, Dec 3, 2:55 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ryasmeen, RESTBase, VisualEditor, Parsoid
Jdforrester-WMF added a comment to T239666: RESTBase requests to Parsoid/PHP that contain a "." in the title (without a /<revid> component) fail with a http 403.

I managed to create
https://en.wikipedia.org/w/index.php?title=42_Test_for_T239666&action=history
with the new wikitext editor, and
https://en.wikipedia.org/w/index.php?title=42_Test_for_T239666_2&action=history
with visual editor and didn't see any problems.
So I think it's stronger than "starts with digits", I think the title must be a valid number with no extraneous characters.

Tue, Dec 3, 2:54 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ryasmeen, RESTBase, VisualEditor, Parsoid
Jdforrester-WMF closed T78711: querypage-no-updates still shown on special pages on wmf wikis that update from cron as Resolved.

This is now deployed, e.g. https://en.wikipedia.org/w/index.php?title=Special:LonelyPages&uselang=fr

Tue, Dec 3, 2:42 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MediaWiki-Special-pages, WikimediaMessages, good first task
Jdforrester-WMF closed T239091: Enable Extension:Translate on se.wikimedia.org as Resolved.

Now deployed successfully.

Tue, Dec 3, 2:07 AM · Wikimedia-Site-requests, User-Jopparn, User-LokalProfil, Wikimedia-Extension-setup
Jdforrester-WMF moved T239209: XSS in Visual Editor via Copy&Paste from In progress to Product owner review on the VisualEditor (Current work) board.
Tue, Dec 3, 2:00 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work), Security-Team, VisualEditor-CopyPaste, Vuln-XSS, Security
Jdforrester-WMF edited projects for T239209: XSS in Visual Editor via Copy&Paste, added: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05); removed Patch-For-Review.

Now manually deployed to wmf.5 and wmf.8, and landed in master. Do we want to announce this, or just Resolve it publicly?

Tue, Dec 3, 1:59 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work), Security-Team, VisualEditor-CopyPaste, Vuln-XSS, Security
Jdforrester-WMF added a comment to T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed".

Now deployed.

Tue, Dec 3, 1:24 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Structured-Data-Backlog (Current Work), Structured Data Engineering, MediaWiki-Revision-backend, Wikimedia-production-error, Commons
Jdforrester-WMF closed T239318: Enable Extension:Wikibase Client on se.wikimedia.org as Resolved.

Deployed.

Tue, Dec 3, 1:16 AM · User-Jopparn, User-LokalProfil, Wikimedia-Site-requests, Wikimedia-Extension-setup
Jdforrester-WMF added a comment to T239091: Enable Extension:Translate on se.wikimedia.org.

Deployed but it broke things, so reverted for now.

Tue, Dec 3, 1:06 AM · Wikimedia-Site-requests, User-Jopparn, User-LokalProfil, Wikimedia-Extension-setup

Mon, Dec 2

Jdforrester-WMF added a parent task for T238927: Build and supply buster nodejs (nodejs-slim and nodejs-devel) container images: Unknown Object (Task).
Mon, Dec 2, 10:22 PM · serviceops
Jdforrester-WMF triaged T239666: RESTBase requests to Parsoid/PHP that contain a "." in the title (without a /<revid> component) fail with a http 403 as Unbreak Now! priority.
Mon, Dec 2, 10:16 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ryasmeen, RESTBase, VisualEditor, Parsoid
Jdforrester-WMF created T239666: RESTBase requests to Parsoid/PHP that contain a "." in the title (without a /<revid> component) fail with a http 403.
Mon, Dec 2, 10:15 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ryasmeen, RESTBase, VisualEditor, Parsoid
Krinkle awarded T210552: JS Linting: Drop `dot-notation` keyword over-ride from all repos; no longer needed a Orange Medal token.
Mon, Dec 2, 9:45 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Continuous-Integration-Config, JavaScript
Jdforrester-WMF updated the task description for T210552: JS Linting: Drop `dot-notation` keyword over-ride from all repos; no longer needed.
Mon, Dec 2, 9:04 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Continuous-Integration-Config, JavaScript
Jdforrester-WMF added a comment to T143037: Stop using jquery.tipsy in Wikimedia-maintained code.
Mon, Dec 2, 9:02 PM · Technical-Debt, JavaScript, MediaWiki-General
Jdforrester-WMF added a parent task for T229015: Tracking: Direct live production traffic at Parsoid/PHP: T239660: Integrate Parsoid/PHP with core as a composer library.
Mon, Dec 2, 8:48 PM · User-notice, Core Platform Team, User-WDoran, Parsoid-PHP
Jdforrester-WMF added a subtask for T239660: Integrate Parsoid/PHP with core as a composer library: T229015: Tracking: Direct live production traffic at Parsoid/PHP.
Mon, Dec 2, 8:48 PM · Parsoid-PHP
Jdforrester-WMF created T239660: Integrate Parsoid/PHP with core as a composer library.
Mon, Dec 2, 8:47 PM · Parsoid-PHP
Jdforrester-WMF added a comment to T239642: We need to run tests on the PHP code in the deploy repo.

I've quickly added the parsoidsvc-composer-package-php72-docker job as experimental, but that's insufficient because (a) using the sub-repo doesn't quite work, and (b) that's a remote-fetch composer job which won't test the particular issue in question here.

Mon, Dec 2, 8:30 PM · Parsoid-PHP
Jdforrester-WMF added a comment to T239647: WikibaseLexeme mwgate-node10-docker CI builds time out waiting for `npm ci`.

Also on https://integration.wikimedia.org/ci/job/mwgate-node10-docker/56262/console on an already-merged master patch.

Mon, Dec 2, 7:57 PM · ci-test-error, Lexicographical data, Wikidata
Jdforrester-WMF added a subtask for T238770: Deploy MediaWiki to Wikimedia production in containers : T238492: Figure out which production extensions have conflicting tests and fix them.
Mon, Dec 2, 7:41 PM · serviceops-radar, Epic, Release Pipeline, Release-Engineering-Team-TODO
Jdforrester-WMF added a parent task for T238492: Figure out which production extensions have conflicting tests and fix them: T238770: Deploy MediaWiki to Wikimedia production in containers .
Mon, Dec 2, 7:41 PM · Release-Engineering-Team-TODO (201912), Epic, Release-Engineering-Team (CI & Testing services)
Jdforrester-WMF added a comment to T239121: VE edit data stopped due to statsv falling over (?) on webperf1001.

It's re-broken itself.

Mon, Dec 2, 7:35 PM · Performance-Team (Radar), observability, Analytics, Editing-team
Jdforrester-WMF renamed T239121: VE edit data stopped due to statsv falling over (?) on webperf1001 from VE edit data stopped at ~2019-11-24Z01:25 to VE edit data stopped at 2019-11-24Z00:57 and again at 2019-12-01Z22:45.
Mon, Dec 2, 7:35 PM · Performance-Team (Radar), observability, Analytics, Editing-team