Page MenuHomePhabricator
Create Task
Maniphest T368604

Wikifunction parser tag: Use parsers on inputs, rather than check for Z6 inputs
Closed, ResolvedPublic
Actions

Description

Code base context.

Acceptance criteria:

  • When evaluating a call from wikitext, don't error if the inputs aren't Z6s (remove existing code)
  • Attempt to run the parser of the target type with the given input, and if successful pass on.
    • Question: What language do we use as the context language for the parser? The content language of the wiki?
  • If parsing fails (or there is no parser), show a MediaWiki-style error and don't try to evaluate.
  • Add some parser tests demonstrating happy path (and maybe failure?).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Re-write function call system to split responsibilitiesmediawiki/extensions/WikiLambdamaster+1 K -252
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT272515 Provide nice ways for editors to insert and update Wikifunctions calls in VisualEditor
 ResolvedJdforrester-WMFT383106 [25Q3] Provide Wikifunctions integration in articles on Dagbani Wikipedia
 ResolvedJdforrester-WMFT376521 Enable one WF use case in a smaller language Wikipedia
 ResolvedJdforrester-WMFT272516 Provide a mechanism by which editors can make Wikifunctions calls in wikitext
 ResolvedJdforrester-WMFT269702 Work out how async WL function evaluator returns plug in to synchronous ParserOutput page painting
 ResolvedJdforrester-WMFT282585 TDMP DR: Provide for asynchronously-available MediaWiki parser content fragments / components
 ResolvedJdforrester-WMFT261472 [25Q1] Let users embed function calls in wikitext which are rendered in the output (for WF itself, not remote wikis)
 ResolvedJdforrester-WMFT362252 Wikifunction parser tag: Use renderers rather than check for Z6 output
 ResolvedJdforrester-WMFT368604 Wikifunction parser tag: Use parsers on inputs, rather than check for Z6 inputs
 DeclinedNoneT371027 Properly separate the WikifunctionsClient repo from WikiLambda
 Resolved• SharvaniharanT363391 [25Q1] Build a design prototype for Wikifunctions use case in Wikipedias
 ResolvedAAlhazwani-WMFT363392 [24Q4] Create a visual prototype for how Wikifunctions calls could be embedded into Wikipedia articles etc.
 ResolvedAAlhazwani-WMFT358362 Design Research: Wikifunctions Integration to Wikipedia
 ResolvedgenghT382140 Provide an API to filter functions by input/output types which can return functions usable by the prototype
 ResolvedgenghT383561 Improve performance of function filter API
 Resolved• MarosteguiT385183 Run the T383561 ALTERs on wikifunctionswiki

Event Timeline

Jdforrester-WMF created this task.Jun 27 2024, 10:00 AM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from Incoming to Ready, Features on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jdforrester-WMF mentioned this in T261472: [25Q1] Let users embed function calls in wikitext which are rendered in the output (for WF itself, not remote wikis).Jun 27 2024, 10:03 AM
Jdforrester-WMF updated the task description. (Show Details)Jul 18 2024, 4:14 PM
Jdforrester-WMF moved this task from 25Q1 (Jul–Sep) to 25Q2 (Oct–Dec) on the Abstract Wikipedia team board.Oct 8 2024, 2:04 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q2 (Oct–Dec)); removed Abstract Wikipedia team (25Q1 (Jul–Sep)).
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Oct 8 2024, 2:08 PM
Jdforrester-WMF claimed this task.Oct 8 2024, 2:10 PM
gerritbot added a comment.Nov 11 2024, 8:03 PM

Change #1071260 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Re-write function call system to split responsibilities

https://gerrit.wikimedia.org/r/1071260

gerritbot added a project: Patch-For-Review.Nov 11 2024, 8:03 PM
Jdforrester-WMF moved this task from 25Q2 (Oct–Dec) to 25Q3 (Jan–Mar) on the Abstract Wikipedia team board.Jan 15 2025, 5:33 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q3 (Jan–Mar)); removed Abstract Wikipedia team (25Q2 (Oct–Dec)).
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Jan 15 2025, 5:55 PM
Jdforrester-WMF added a parent task: T376521: Enable one WF use case in a smaller language Wikipedia.Jan 15 2025, 9:33 PM
DSantamaria changed the task status from Open to In Progress.Jan 31 2025, 11:54 AM
DSantamaria added a project: Wikifunctions integration.
Jdforrester-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Feb 10 2025, 2:44 PM
gerritbot added a comment.Feb 13 2025, 4:23 PM

Change #1071260 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Re-write function call system to split responsibilities

https://gerrit.wikimedia.org/r/1071260

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2025, 4:31 PM
Jdforrester-WMF moved this task from In Code review to Needs Sign-off on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Feb 13 2025, 5:49 PM

We're not deploying this code (it's behind a feature flag), so moving straight to sign-off.

Jdforrester-WMF closed this task as Resolved.Feb 20 2025, 3:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits