Maniphest T369956

Add logging data when db fetch in orchestrator
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ecarg
	Jul 12 2024, 9:48 PM

Tags

Referenced Files

None

Subscribers

Description

What/Why:
As a follow-up to the major refactor in schemata and corresponding updates in the orchestrator (and evaluator), we want to also add another log at the bookends of fetching in the orchestrator.

How:

Add before and after the await fetch()... method in src/db.
Figure out how to bring in logger

Details

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade orchestrator from 2024-07-17-145014 to 2024-07-19-164024	operations/deployment-charts	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		cmassaro	T367933 [25Q1] Performance improvements
		Resolved		ecarg	T368000 [25Q1] Production monitoring – logging
		Resolved		ecarg	T364413 Improve the logging we're doing in the orchestrator and evaluator to have a better idea of where the slowness is coming from
		Resolved		cmassaro	T369956 Add logging data when db fetch in orchestrator

Event Timeline

ecarg created this task.Jul 12 2024, 9:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2024, 9:48 PM

ecarg added a parent task: T364413: Improve the logging we're doing in the orchestrator and evaluator to have a better idea of where the slowness is coming from.Jul 12 2024, 9:49 PM

ecarg updated the task description. (Show Details)

Jdforrester-WMF moved this task from 24Q4 (Apr–Jun) to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.Jul 17 2024, 4:45 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team (24Q4 (Apr–Jun)).

Jdforrester-WMF triaged this task as High priority.Jul 17 2024, 4:54 PM

Jdforrester-WMF moved this task from Incoming to Ready, Features on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.

cmassaro claimed this task.Jul 18 2024, 4:24 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/204

Add logs before and after calling wikilambda_fetch.

cmassaro moved this task from Ready, Features to In Progress on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jul 18 2024, 7:45 PM

Jdforrester-WMF changed the task status from Open to In Progress.Jul 18 2024, 8:22 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/204

Add logs before and after calling wikilambda_fetch.

Jdforrester-WMF moved this task from In Progress to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jul 19 2024, 10:22 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2024, 10:30 AM

Change #1056266 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-07-17-145014 to 2024-07-19-164024

https://gerrit.wikimedia.org/r/1056266

gerritbot added a project: Patch-For-Review.Jul 23 2024, 11:19 PM

Change #1056266 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-07-17-145014 to 2024-07-19-164024

https://gerrit.wikimedia.org/r/1056266

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2024, 2:31 PM

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jul 24 2024, 2:47 PM

Jdforrester-WMF closed this task as Resolved.Aug 13 2024, 5:30 PM