Page MenuHomePhabricator

cmassaro (Cory Massaro)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 5 2021, 4:31 PM (171 w, 3 d)
Availability
Available
LDAP User
Cory Massaro
MediaWiki User
CMassaro (WMF) [ Global Accounts ]

Recent Activity

Yesterday

cmassaro added a comment to T361132: Orchestrator Should Validate Input Function Call as Z1 (instead of not validating it at all).

We were already doing this by validating inputs as Z7, and this change catches the potential uncanonicalizable inputs when that happens. So I don't think we need to add any new validation.

Thu, Apr 18, 7:13 PM · function-orchestrator, Abstract Wikipedia team
cmassaro moved T361132: Orchestrator Should Validate Input Function Call as Z1 (instead of not validating it at all) from Backlog to Verify in production on the Abstract Wikipedia team board.
Thu, Apr 18, 7:11 PM · function-orchestrator, Abstract Wikipedia team
cmassaro added a comment to T353155: Upgrade QuickJS to 2023-12-09 release or later.

Oof, now I see why I couldn't actually write a proper timeout test for QuickJS ...

Thu, Apr 18, 6:25 PM · Abstract Wikipedia team, function-evaluator

Wed, Apr 17

cmassaro created T362738: Figure Out the Required Number of Corks.
Wed, Apr 17, 1:20 AM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team

Tue, Apr 16

cmassaro added a comment to T362278: Consider why compositions are significantly faster in the condition of the built-in if function.

type of should be possible with Z803/Value by key. I am not claiming this would be good or efficient, but, in theory, you should be able to get to

Tue, Apr 16, 8:49 PM · Documentation, Abstract Wikipedia team
cmassaro updated the task description for T321866: Create Re-Entrant Evaluator for JavaScript and Fix Re-Entrancy for Python.
Tue, Apr 16, 5:27 PM · Abstract Wikipedia team, function-evaluator, function-orchestrator
cmassaro created T362703: Test Invalid ParseStates in Evaluator.
Tue, Apr 16, 5:24 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro renamed T321866: Create Re-Entrant Evaluator for JavaScript and Fix Re-Entrancy for Python from Create Re-Entrant Evaluator for JavaScript to Create Re-Entrant Evaluator for JavaScript and Fix Re-Entrancy for Python.
Tue, Apr 16, 5:20 PM · Abstract Wikipedia team, function-evaluator, function-orchestrator

Mon, Apr 15

cmassaro renamed T361361: Protect Stream Access with a Mutex and Unique ID in Executors from Protect Stdout Access with a Mutex in Executors to Protect Stream Access with a Mutex and Unique ID in Executors.
Mon, Apr 15, 11:40 PM · function-evaluator, Abstract Wikipedia team

Thu, Apr 11

cmassaro added a comment to T362200: [QA task] wikifunction betacluster failures .

For Z13087, I get a Z517 (return type mismatch). The implementation is apparently returning a Z20 (Tester???) when it should return a Z6.

Thu, Apr 11, 12:47 AM · Abstract Wikipedia team (24Q4 (Apr–Jun))

Wed, Apr 10

cmassaro created T362266: Discuss wikilambda_fetch Slowness with SRE.
Wed, Apr 10, 4:44 PM · function-orchestrator, Abstract Wikipedia team
cmassaro created T362265: Where possible, batch calls to wikilambda_fetch in the orchestrator, rather than running multiple in parallel.
Wed, Apr 10, 4:43 PM · function-orchestrator, Abstract Wikipedia team
cmassaro created T362264: Design a More Refined Version of the Orchestrator's run-time cache.
Wed, Apr 10, 4:42 PM · function-orchestrator, Abstract Wikipedia team
cmassaro added a parent task for T362262: Devise an eviction and disregard strategy for the orchestrator to cache fetched ZObjects from Wikifunctions: T362263: Implement in the orchestrator a semi-persistent cache of fetched ZObjects from Wikifunctions.
Wed, Apr 10, 4:40 PM · function-orchestrator, WikiLambda, Abstract Wikipedia team
cmassaro added a subtask for T362263: Implement in the orchestrator a semi-persistent cache of fetched ZObjects from Wikifunctions: T362262: Devise an eviction and disregard strategy for the orchestrator to cache fetched ZObjects from Wikifunctions.
Wed, Apr 10, 4:40 PM · function-orchestrator, Abstract Wikipedia team
cmassaro created T362263: Implement in the orchestrator a semi-persistent cache of fetched ZObjects from Wikifunctions.
Wed, Apr 10, 4:39 PM · function-orchestrator, Abstract Wikipedia team
cmassaro created T362262: Devise an eviction and disregard strategy for the orchestrator to cache fetched ZObjects from Wikifunctions.
Wed, Apr 10, 4:38 PM · function-orchestrator, WikiLambda, Abstract Wikipedia team
cmassaro added a comment to T358589: Raise a type error if resulting value is incompatible with argument type.

Hello! For the moment, it looks like we will leave this task alone. The issue here is the backend validation workflow, which we've intentionally deactivated in certain circumstances. Re-enabling it isn't a high priority right now.

Wed, Apr 10, 4:35 PM · Patch-For-Review, Abstract Wikipedia team, function-orchestrator, Wikifunctions
cmassaro placed T358589: Raise a type error if resulting value is incompatible with argument type up for grabs.
Wed, Apr 10, 4:33 PM · Patch-For-Review, Abstract Wikipedia team, function-orchestrator, Wikifunctions
cmassaro added a subtask for T358589: Raise a type error if resulting value is incompatible with argument type: T327412: Re-enable skipped tests in mswOrchestrateTest once type comparison's guarantees are stricter.
Wed, Apr 10, 4:32 PM · Patch-For-Review, Abstract Wikipedia team, function-orchestrator, Wikifunctions
cmassaro added a parent task for T327412: Re-enable skipped tests in mswOrchestrateTest once type comparison's guarantees are stricter: T358589: Raise a type error if resulting value is incompatible with argument type.
Wed, Apr 10, 4:32 PM · Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-schemata, function-orchestrator
cmassaro added a comment to T359500: A test is timing out in the orchestrator, for multiple reasons.

No, this isn't related to type conversion. I'm able to run it successfully in my local environment, where the only real difference is the co-location of services (so no latency between the API and the orchestrator or between the orchestrator and evaluator).

Wed, Apr 10, 1:44 PM · Abstract Wikipedia team (24Q4 (Apr–Jun)), function-orchestrator, Wikifunctions
cmassaro added a comment to T359233: Support typed list of types with type converters.

This doesn't necessarily depend on re-entrancy.

Wed, Apr 10, 1:42 PM · Abstract Wikipedia team
cmassaro added a comment to T337589: Scopes Are Not Always Attached to ZObjects Correctly.

@ecarg I just saw your note. Not intruding at all. Some related issues have started to cause bugs in prod, so (in my opinion) this would absolutely be a worthwhile thing to look at for fix-it week!

Wed, Apr 10, 11:53 AM · Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator

Tue, Apr 9

cmassaro added a comment to T355632: Investigate Better Ways to Kill/Timeout Subprocesses.

The better way will be to use wasmedge's time limit. Should we close this as a duplicate of T360543?

Tue, Apr 9, 10:36 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro claimed T361361: Protect Stream Access with a Mutex and Unique ID in Executors.
Tue, Apr 9, 7:47 PM · function-evaluator, Abstract Wikipedia team
cmassaro claimed T361369: Protect All Writes to Stdout with Start and End Signals; Maintain Awareness of stdout State.
Tue, Apr 9, 7:46 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro claimed T361130: Make Canonicalize and Normalize Equally Strict.
Tue, Apr 9, 7:46 PM · function-schemata, Abstract Wikipedia team
cmassaro added a subtask for T347086: Make It Possible to import function-schemata utils, not just require(): T361130: Make Canonicalize and Normalize Equally Strict.
Tue, Apr 9, 7:45 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro added a parent task for T361130: Make Canonicalize and Normalize Equally Strict: T347086: Make It Possible to import function-schemata utils, not just require().
Tue, Apr 9, 7:45 PM · function-schemata, Abstract Wikipedia team
cmassaro added a subtask for T347086: Make It Possible to import function-schemata utils, not just require(): T361132: Orchestrator Should Validate Input Function Call as Z1 (instead of not validating it at all).
Tue, Apr 9, 7:45 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro added a parent task for T361132: Orchestrator Should Validate Input Function Call as Z1 (instead of not validating it at all): T347086: Make It Possible to import function-schemata utils, not just require().
Tue, Apr 9, 7:45 PM · function-orchestrator, Abstract Wikipedia team
cmassaro claimed T361132: Orchestrator Should Validate Input Function Call as Z1 (instead of not validating it at all).
Tue, Apr 9, 7:44 PM · function-orchestrator, Abstract Wikipedia team
cmassaro created T362194: Consider Recording Request Start/Request Receipt/Response Start/Response Receipt Times.
Tue, Apr 9, 7:42 PM · function-orchestrator, Abstract Wikipedia team
cmassaro moved T360385: When Tester validation fails, put the expected but not the identical "actual" value in from 24Q4 (Apr–Jun) to Verify in production on the Abstract Wikipedia team board.
Tue, Apr 9, 3:08 PM · Abstract Wikipedia team, WikiLambda, Wikifunctions
cmassaro added a comment to T360385: When Tester validation fails, put the expected but not the identical "actual" value in.

This is passing now.

Tue, Apr 9, 3:07 PM · Abstract Wikipedia team, WikiLambda, Wikifunctions
cmassaro added a comment to T359500: A test is timing out in the orchestrator, for multiple reasons.

I am running this locally (but using the wikifunctions.org API for ZID resolution). When I run the calls that time out, it takes 5066 ms.

Tue, Apr 9, 3:03 PM · Abstract Wikipedia team (24Q4 (Apr–Jun)), function-orchestrator, Wikifunctions
cmassaro moved T361654: Fourth and subsequent Argument references not resolved from In Progress to To deploy on the Abstract Wikipedia team board.
Tue, Apr 9, 2:13 PM · Patch-For-Review, Abstract Wikipedia team

Mon, Apr 8

cmassaro created T362104: Consider Adding an `isFunctionInternal` Attribute to ZWrapper.
Mon, Apr 8, 7:05 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro added a comment to T361654: Fourth and subsequent Argument references not resolved.

Hmm, okay. So what are the ZIDs of a function and implementation that should currently work but don't? How can I reproduce the bug right now?

Mon, Apr 8, 12:11 AM · Patch-For-Review, Abstract Wikipedia team

Fri, Apr 5

cmassaro added a comment to T361654: Fourth and subsequent Argument references not resolved.

I am trying to figure out whether this is a scoping issue in the orchestrator or a problem with the composition-based implementation itself. I'm running this locally and logging all the nested function calls. At one point, I see this:

Fri, Apr 5, 11:08 PM · Patch-For-Review, Abstract Wikipedia team
cmassaro moved T361674: Argument mismatch error returns wrong value for Z22K1 from In Progress to To deploy on the Abstract Wikipedia team board.
Fri, Apr 5, 4:15 PM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team

Thu, Apr 4

cmassaro added a comment to T358589: Raise a type error if resulting value is incompatible with argument type.

Yeah, the unfortunate truth is that it's very easy to construct ZObjects whose type can't be known until runtime. We can't, in general, know that an inner function evaluates to an incompatible type until we run it. For user-defined types and generic types, this will be true unless and until we decide to banish arbitrary function calls from the type calculus.

Thu, Apr 4, 9:08 PM · Patch-For-Review, Abstract Wikipedia team, function-orchestrator, Wikifunctions
cmassaro updated subscribers of T361654: Fourth and subsequent Argument references not resolved.

Ah! I see. I was running it with all of the Boolean argument values set.

Thu, Apr 4, 9:01 PM · Patch-For-Review, Abstract Wikipedia team
cmassaro moved T353741: Current JavaScript executor does not support Object.hasOwn from To deploy to Verify in production on the Abstract Wikipedia team board.
Thu, Apr 4, 5:55 PM · Abstract Wikipedia team
cmassaro moved T360904: Z10006 fails with "ZID not found" on Z112 from In Progress to Verify in production on the Abstract Wikipedia team board.
Thu, Apr 4, 5:54 PM · Abstract Wikipedia team, Patch-For-Review, function-orchestrator
cmassaro added a comment to T360904: Z10006 fails with "ZID not found" on Z112.

Looks like the tests are passing now. In the last two hours, I don't see the corresponding log anywhere. It's possible this was a symptom of some other bug that's since been fixed.

Thu, Apr 4, 5:53 PM · Abstract Wikipedia team, Patch-For-Review, function-orchestrator
cmassaro added a comment to T361854: Current Evaluator images fail to serve, with `loading failed: invalid path … /srv/service/programming-languages/rustpython.wasm.

Oh! I think you pulled the old images. I'm trying with 04-03-210033

Thu, Apr 4, 4:36 PM · Patch-For-Review, Regression, Abstract Wikipedia team, function-evaluator
cmassaro added a comment to T361854: Current Evaluator images fail to serve, with `loading failed: invalid path … /srv/service/programming-languages/rustpython.wasm.

At what point did you see the loading failed error? When trying to run a function call?

Thu, Apr 4, 4:32 PM · Patch-For-Review, Regression, Abstract Wikipedia team, function-evaluator
cmassaro claimed T361854: Current Evaluator images fail to serve, with `loading failed: invalid path … /srv/service/programming-languages/rustpython.wasm.
Thu, Apr 4, 4:31 PM · Patch-For-Review, Regression, Abstract Wikipedia team, function-evaluator
cmassaro added a comment to T361674: Argument mismatch error returns wrong value for Z22K1.

Weird. I was able to repro locally. My guess is that we're calling resolve on Z24 and retrieving the object { Z1K1: 'Z21' }. This is technically "correct," but also very weird that it's happening here, since we don't normally resolve those. I'll take a look.

Thu, Apr 4, 3:53 PM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team
cmassaro placed T353742: Error message too terse for missing Object.hasOwn up for grabs.
Thu, Apr 4, 3:51 PM · Abstract Wikipedia team (24Q4 (Apr–Jun))
cmassaro added a comment to T353742: Error message too terse for missing Object.hasOwn.

I think the QuickJS 2024 update has already propagated through?

Thu, Apr 4, 3:47 PM · Abstract Wikipedia team (24Q4 (Apr–Jun))
cmassaro claimed T353742: Error message too terse for missing Object.hasOwn.
Thu, Apr 4, 3:46 PM · Abstract Wikipedia team (24Q4 (Apr–Jun))
cmassaro claimed T361674: Argument mismatch error returns wrong value for Z22K1.
Thu, Apr 4, 3:17 PM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team
cmassaro changed the status of T358589: Raise a type error if resulting value is incompatible with argument type from Open to In Progress.
Thu, Apr 4, 3:07 PM · Patch-For-Review, Abstract Wikipedia team, function-orchestrator, Wikifunctions
cmassaro changed the status of T360904: Z10006 fails with "ZID not found" on Z112 from Open to In Progress.
Thu, Apr 4, 3:06 PM · Abstract Wikipedia team, Patch-For-Review, function-orchestrator
cmassaro moved T353741: Current JavaScript executor does not support Object.hasOwn from 24Q4 (Apr–Jun) to To deploy on the Abstract Wikipedia team board.
Thu, Apr 4, 3:01 PM · Abstract Wikipedia team
cmassaro added a comment to T353741: Current JavaScript executor does not support Object.hasOwn.

Looks like this got merged into wasmedge-quickjs in February: https://github.com/second-state/wasmedge-quickjs/commit/d76ccf4aed0745e4ff7aad2f6aac4caf4acdfca2

Thu, Apr 4, 3:00 PM · Abstract Wikipedia team
cmassaro claimed T353741: Current JavaScript executor does not support Object.hasOwn.
Thu, Apr 4, 2:59 PM · Abstract Wikipedia team
cmassaro added a comment to T361654: Fourth and subsequent Argument references not resolved.

@GrounderUK , are you still seeing this behavior? When I run this function with input 1 set to True and all others set to False, I get an error.

Thu, Apr 4, 2:36 PM · Patch-For-Review, Abstract Wikipedia team
cmassaro claimed T358589: Raise a type error if resulting value is incompatible with argument type.
Thu, Apr 4, 1:22 PM · Patch-For-Review, Abstract Wikipedia team, function-orchestrator, Wikifunctions
Jdforrester-WMF awarded T361826: Resolve All Function Call Internals Ephemerally a Like token.
Thu, Apr 4, 1:05 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro claimed T361654: Fourth and subsequent Argument references not resolved.
Thu, Apr 4, 11:59 AM · Patch-For-Review, Abstract Wikipedia team
cmassaro added a comment to T358589: Raise a type error if resulting value is incompatible with argument type.

Okay, I have now replicated the bug. A partial fix is out for review. The rest of the fix involves a big-ish change; the team will discuss that change soon.

Thu, Apr 4, 11:56 AM · Patch-For-Review, Abstract Wikipedia team, function-orchestrator, Wikifunctions
cmassaro created T361826: Resolve All Function Call Internals Ephemerally.
Thu, Apr 4, 11:51 AM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro created T361823: ORCHESTRATOR PERFORMANCE: Mark ZWrappers as Fully Resolved; Skip Fully Resolved Objects when Eagerly Evaluating.
Thu, Apr 4, 11:37 AM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team

Wed, Apr 3

cmassaro added a comment to T358589: Raise a type error if resulting value is incompatible with argument type.

I haven't replicated this yet, but I think I see the problem.

Wed, Apr 3, 12:36 PM · Patch-For-Review, Abstract Wikipedia team, function-orchestrator, Wikifunctions

Tue, Apr 2

cmassaro added a comment to T358589: Raise a type error if resulting value is incompatible with argument type.

(To be clear: the changed scope for this task is absolutely something we can and should fix in the backend; my comment above concerns the wider question of frontend type-checking)

Tue, Apr 2, 11:30 AM · Patch-For-Review, Abstract Wikipedia team, function-orchestrator, Wikifunctions
cmassaro added a comment to T358589: Raise a type error if resulting value is incompatible with argument type.

My two cents:

Tue, Apr 2, 12:57 AM · Patch-For-Review, Abstract Wikipedia team, function-orchestrator, Wikifunctions

Mon, Apr 1

cmassaro claimed T360904: Z10006 fails with "ZID not found" on Z112.
Mon, Apr 1, 10:14 PM · Abstract Wikipedia team, Patch-For-Review, function-orchestrator
cmassaro added a project to T361369: Protect All Writes to Stdout with Start and End Signals; Maintain Awareness of stdout State: Abstract Wikipedia Fix-It tasks.
Mon, Apr 1, 10:10 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro placed T361369: Protect All Writes to Stdout with Start and End Signals; Maintain Awareness of stdout State up for grabs.
Mon, Apr 1, 10:10 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team

Fri, Mar 29

cmassaro claimed T361369: Protect All Writes to Stdout with Start and End Signals; Maintain Awareness of stdout State.
Fri, Mar 29, 2:15 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro added a subtask for T360543: Set Resource Limits on wasmedge CLI: T361369: Protect All Writes to Stdout with Start and End Signals; Maintain Awareness of stdout State.
Fri, Mar 29, 2:14 PM · Patch-For-Review, WikiLambda, function-evaluator, Abstract Wikipedia team
cmassaro added a subtask for T361361: Protect Stream Access with a Mutex and Unique ID in Executors: T361369: Protect All Writes to Stdout with Start and End Signals; Maintain Awareness of stdout State.
Fri, Mar 29, 2:14 PM · function-evaluator, Abstract Wikipedia team
cmassaro added parent tasks for T361369: Protect All Writes to Stdout with Start and End Signals; Maintain Awareness of stdout State: T361361: Protect Stream Access with a Mutex and Unique ID in Executors, T360543: Set Resource Limits on wasmedge CLI.
Fri, Mar 29, 2:14 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro created T361369: Protect All Writes to Stdout with Start and End Signals; Maintain Awareness of stdout State.
Fri, Mar 29, 2:14 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro added a subtask for T321866: Create Re-Entrant Evaluator for JavaScript and Fix Re-Entrancy for Python: T361361: Protect Stream Access with a Mutex and Unique ID in Executors.
Fri, Mar 29, 1:04 PM · Abstract Wikipedia team, function-evaluator, function-orchestrator
cmassaro added a parent task for T361361: Protect Stream Access with a Mutex and Unique ID in Executors: T321866: Create Re-Entrant Evaluator for JavaScript and Fix Re-Entrancy for Python.
Fri, Mar 29, 1:04 PM · function-evaluator, Abstract Wikipedia team
cmassaro created T361361: Protect Stream Access with a Mutex and Unique ID in Executors.
Fri, Mar 29, 1:04 PM · function-evaluator, Abstract Wikipedia team

Wed, Mar 27

cmassaro created T361132: Orchestrator Should Validate Input Function Call as Z1 (instead of not validating it at all).
Wed, Mar 27, 4:37 PM · function-orchestrator, Abstract Wikipedia team
cmassaro created T361131: Provide an understandable warning on Uncanonicalizable Output.
Wed, Mar 27, 4:36 PM · function-orchestrator, Abstract Wikipedia team
cmassaro created T361130: Make Canonicalize and Normalize Equally Strict.
Wed, Mar 27, 4:35 PM · function-schemata, Abstract Wikipedia team

Mon, Mar 25

cmassaro moved T356888: Consider Making `eslint` a Part of a Separate Stage, Rather than Incorporating It into the Test Stages from Backlog to Verify in production on the Abstract Wikipedia team board.
Mon, Mar 25, 11:42 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro claimed T356888: Consider Making `eslint` a Part of a Separate Stage, Rather than Incorporating It into the Test Stages.
Mon, Mar 25, 11:42 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro updated the task description for T360543: Set Resource Limits on wasmedge CLI.
Mon, Mar 25, 8:13 PM · Patch-For-Review, WikiLambda, function-evaluator, Abstract Wikipedia team
cmassaro added a comment to T360172: orchestration of compositions is too slow.

The immediate (possible) fix is now merged. I have moved this task to "To Deploy."

Mon, Mar 25, 1:45 PM · Patch-For-Review, Abstract Wikipedia team, Wikifunctions
cmassaro moved T360172: orchestration of compositions is too slow from In Progress to To deploy on the Abstract Wikipedia team board.
Mon, Mar 25, 1:42 PM · Patch-For-Review, Abstract Wikipedia team, Wikifunctions

Fri, Mar 22

cmassaro added a comment to T360791: Value fields for natural numbers display "Display function returned an unknown error.".

A couple of observations:

Fri, Mar 22, 10:33 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), WikiLambda Front-end, Patch-For-Review, Abstract Wikipedia team
cmassaro added a comment to T360791: Value fields for natural numbers display "Display function returned an unknown error.".

Thank you!!

Fri, Mar 22, 9:41 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), WikiLambda Front-end, Patch-For-Review, Abstract Wikipedia team
cmassaro added a comment to T360791: Value fields for natural numbers display "Display function returned an unknown error.".

So if it's only happening when the input is an empty string, I am imagining that it's something like this:

Fri, Mar 22, 7:30 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), WikiLambda Front-end, Patch-For-Review, Abstract Wikipedia team
cmassaro added a comment to T360791: Value fields for natural numbers display "Display function returned an unknown error.".

@ecarg Yep, it's the same error you were working on! Unfortunately, there will always be cases where this error crops up (usually a syntax error).

Fri, Mar 22, 7:25 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), WikiLambda Front-end, Patch-For-Review, Abstract Wikipedia team
cmassaro added a comment to T360791: Value fields for natural numbers display "Display function returned an unknown error.".

@gengh How can I view this error? In particular, how can I see the JS one?

Fri, Mar 22, 4:25 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), WikiLambda Front-end, Patch-For-Review, Abstract Wikipedia team
cmassaro added a comment to T360172: orchestration of compositions is too slow.

I think one reason these are slow is that we're resolving all the labels (Z11, Z12, etc.) inside of the argument internals. We never use this information, so we can just stop doing that. I tested with your not(not(input)) example; with this change, we save 7 calls to the wikilambda_fetch API. There's a lot of other stuff causing slowdown, but this was a really obvious source of latency. Let's see if the performance is better once that MR is merged and deployed.

Fri, Mar 22, 4:18 PM · Patch-For-Review, Abstract Wikipedia team, Wikifunctions
cmassaro moved T320507: convertZObjectToBinary Must Check an Object Is in Valid Normal Form from In Progress to To deploy on the Abstract Wikipedia team board.
Fri, Mar 22, 4:14 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team, good first task, function-schemata

Thu, Mar 21

cmassaro changed the status of T360543: Set Resource Limits on wasmedge CLI from Open to In Progress.
Thu, Mar 21, 11:27 PM · Patch-For-Review, WikiLambda, function-evaluator, Abstract Wikipedia team
cmassaro claimed T360543: Set Resource Limits on wasmedge CLI.
Thu, Mar 21, 11:27 PM · Patch-For-Review, WikiLambda, function-evaluator, Abstract Wikipedia team
cmassaro added a parent task for T358057: Consider Making Dot Notation into a Smart Accessor for ZWrapper: T360692: ORCHESTRATOR PERFORMANCE: Start Resolving Early; JIT Await.
Thu, Mar 21, 7:01 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro added a subtask for T360692: ORCHESTRATOR PERFORMANCE: Start Resolving Early; JIT Await: T358057: Consider Making Dot Notation into a Smart Accessor for ZWrapper.
Thu, Mar 21, 7:01 PM · function-orchestrator, Abstract Wikipedia team