Page MenuHomePhabricator

cmassaro (Cory Massaro)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 5 2021, 4:31 PM (24 w, 1 d)
Availability
Available
LDAP User
Cory Massaro
MediaWiki User
CMassaro (WMF) [ Global Accounts ]

Recent Activity

Yesterday

cmassaro created T285435: Allow Evaluator to Request Further Dereferencing.
Wed, Jun 23, 8:53 PM · Abstract Wikipedia team
cmassaro created T285433: Replace Z23s with Z21s in Orchestrator and Validator.
Wed, Jun 23, 8:15 PM · function-evaluator, function-orchestrator, Abstract Wikipedia team
cmassaro closed T282827: Write Tests for JS Executor, a subtask of T284163: Improve evaluator testing for Phase Zeta, as Resolved.
Wed, Jun 23, 5:14 PM · function-evaluator, Abstract Wikipedia team (Phase ζ)
cmassaro closed T282827: Write Tests for JS Executor as Resolved.
Wed, Jun 23, 5:14 PM · Abstract Wikipedia team (Phase ζ), function-evaluator
cmassaro closed T284703: Fix JS Code Example in WikiLambda Extension as Resolved.
Wed, Jun 23, 5:14 PM · Abstract Wikipedia team (Phase ζ), Patch-For-Review, WikiLambda
cmassaro closed T282821: Python execution engine should expect full `def`, not just statement setting return value as Resolved.
Wed, Jun 23, 5:13 PM · function-evaluator, Abstract Wikipedia team (Phase ζ)
cmassaro closed T285276: Update example Python function call in extension to include full `def`, a subtask of T282821: Python execution engine should expect full `def`, not just statement setting return value, as Resolved.
Wed, Jun 23, 5:13 PM · function-evaluator, Abstract Wikipedia team (Phase ζ)
cmassaro closed T285276: Update example Python function call in extension to include full `def` as Resolved.
Wed, Jun 23, 5:12 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ζ)
cmassaro committed rMSFE6ee3829bc7c8: Add JS unit tests. (authored by cmassaro).
Add JS unit tests.
Wed, Jun 23, 5:06 PM
cmassaro added projects to T281759: Allow Normalization/Canonicalization Code to Accept Mixed Forms: function-schemata, function-orchestrator.
Wed, Jun 23, 4:38 PM · function-orchestrator, function-schemata, Abstract Wikipedia team (Phase ζ)
cmassaro placed T281759: Allow Normalization/Canonicalization Code to Accept Mixed Forms up for grabs.
Wed, Jun 23, 4:38 PM · function-orchestrator, function-schemata, Abstract Wikipedia team (Phase ζ)
cmassaro committed rMSFE0484d6ea45d1: Ensures Python executor expects a full def (or equivalent). (authored by cmassaro).
Ensures Python executor expects a full def (or equivalent).
Wed, Jun 23, 4:37 PM
cmassaro claimed T282827: Write Tests for JS Executor.
Wed, Jun 23, 4:35 PM · Abstract Wikipedia team (Phase ζ), function-evaluator
cmassaro claimed T285365: Evaluate a composition.
Wed, Jun 23, 4:34 PM · function-orchestrator, Abstract Wikipedia team (Phase ζ)
cmassaro claimed T285276: Update example Python function call in extension to include full `def`.
Wed, Jun 23, 4:33 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ζ)
cmassaro claimed T285196: Enable Reference Cache in Orchestrator.
Wed, Jun 23, 4:24 PM · Abstract Wikipedia team (Phase ζ)
cmassaro assigned T285342: Z30 Validator Errors to arthurlorenzi.
Wed, Jun 23, 4:14 PM · Abstract Wikipedia team (Phase ζ)
cmassaro closed T285195: Ensure Reference Resolution Alters Original ZObject in Orchestrator as Invalid.
Wed, Jun 23, 4:14 PM · Abstract Wikipedia team

Tue, Jun 22

cmassaro updated the task description for T285342: Z30 Validator Errors.
Tue, Jun 22, 6:55 PM · Abstract Wikipedia team (Phase ζ)
cmassaro created T285342: Z30 Validator Errors.
Tue, Jun 22, 6:41 PM · Abstract Wikipedia team (Phase ζ)
cmassaro created T285312: Enable Logging in Backend Services.
Tue, Jun 22, 1:54 PM · Abstract Wikipedia team (Phase η), function-evaluator, function-orchestrator
cmassaro closed T284743: Function Evaluation Is Not Working as Invalid.
Tue, Jun 22, 1:52 PM · Abstract Wikipedia team

Mon, Jun 21

cmassaro created T285276: Update example Python function call in extension to include full `def`.
Mon, Jun 21, 8:51 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ζ)
cmassaro added a project to T285275: Disseminate Tutorial about How to Run Frontend Lint: Developer Productivity.
Mon, Jun 21, 8:48 PM · Developer Productivity, WikiLambda, Abstract Wikipedia team
cmassaro renamed T285275: Disseminate Tutorial about How to Run Frontend Lint from Disseminate Information about How to Run Frontend Lint to Disseminate Tutorial about How to Run Frontend Lint.
Mon, Jun 21, 8:47 PM · Developer Productivity, WikiLambda, Abstract Wikipedia team
cmassaro created T285275: Disseminate Tutorial about How to Run Frontend Lint.
Mon, Jun 21, 8:47 PM · Developer Productivity, WikiLambda, Abstract Wikipedia team
cmassaro added a subtask for T283740: Have the orchestrator dereference functions, implementations, testers, etc. as needed: T284515: Orchestrator Should Respect Z14K4, Not Z8K5.
Mon, Jun 21, 6:04 PM · Patch-For-Review, Abstract Wikipedia team (Phase ζ), function-orchestrator
cmassaro added a parent task for T284515: Orchestrator Should Respect Z14K4, Not Z8K5: T283740: Have the orchestrator dereference functions, implementations, testers, etc. as needed.
Mon, Jun 21, 6:04 PM · Abstract Wikipedia team (Phase ζ), function-orchestrator
cmassaro added a project to T285260: Orchestrator Top-Level Validation Should Check Z1K1: function-orchestrator.
Mon, Jun 21, 6:01 PM · function-orchestrator, Abstract Wikipedia team
cmassaro created T285260: Orchestrator Top-Level Validation Should Check Z1K1.
Mon, Jun 21, 5:54 PM · function-orchestrator, Abstract Wikipedia team
cmassaro created T285196: Enable Reference Cache in Orchestrator.
Mon, Jun 21, 3:22 AM · Abstract Wikipedia team (Phase ζ)
cmassaro created T285195: Ensure Reference Resolution Alters Original ZObject in Orchestrator.
Mon, Jun 21, 3:19 AM · Abstract Wikipedia team
cmassaro raised the priority of T281759: Allow Normalization/Canonicalization Code to Accept Mixed Forms from High to Needs Triage.
Mon, Jun 21, 3:18 AM · function-orchestrator, function-schemata, Abstract Wikipedia team (Phase ζ)
cmassaro added a project to T281759: Allow Normalization/Canonicalization Code to Accept Mixed Forms: Abstract Wikipedia team.
Mon, Jun 21, 3:18 AM · function-orchestrator, function-schemata, Abstract Wikipedia team (Phase ζ)
cmassaro reopened T281759: Allow Normalization/Canonicalization Code to Accept Mixed Forms as "Open".
Mon, Jun 21, 3:17 AM · function-orchestrator, function-schemata, Abstract Wikipedia team (Phase ζ)

Thu, Jun 10

cmassaro created T284764: Fix Canonicalization Code in Frontend to Handle Z6s That Masquerade as Z9s.
Thu, Jun 10, 4:16 PM · Abstract Wikipedia team (Phase ζ)
cmassaro created T284744: Implement Local End-to-End Test or Function Evaluation in WikiLambda.
Thu, Jun 10, 1:17 PM · Abstract Wikipedia team (Phase ζ)
cmassaro created T284743: Function Evaluation Is Not Working.
Thu, Jun 10, 1:16 PM · Abstract Wikipedia team
cmassaro added a comment to T261341: Performance review of Wikifunctions.

Hmm, I also notice that nothing is working at the moment. We've made a bunch of changes to the orchestrator recently, so I assume that's the reason. I will investigate today.

Thu, Jun 10, 1:15 PM · Abstract Wikipedia team (Phase ζ), WikiLambda, Performance-Team

Wed, Jun 9

cmassaro added a project to T284703: Fix JS Code Example in WikiLambda Extension: WikiLambda.
Wed, Jun 9, 9:27 PM · Abstract Wikipedia team (Phase ζ), Patch-For-Review, WikiLambda
cmassaro created T284704: Implement Intelligent Strategy for When to Dereference Z9s in Orchestrator.
Wed, Jun 9, 9:26 PM · function-orchestrator, Abstract Wikipedia team
cmassaro created T284703: Fix JS Code Example in WikiLambda Extension.
Wed, Jun 9, 9:26 PM · Abstract Wikipedia team (Phase ζ), Patch-For-Review, WikiLambda
cmassaro added a comment to T261341: Performance review of Wikifunctions.

Hi, Gilles, a few questions/comments.

Wed, Jun 9, 8:40 PM · Abstract Wikipedia team (Phase ζ), WikiLambda, Performance-Team
cmassaro added a comment to T282164: Function calls should return a status tuple with metadata (success, error list, …).

A proposal is underway.

Wed, Jun 9, 4:51 PM · function-schemata, function-evaluator, function-orchestrator, Abstract Wikipedia team
cmassaro added projects to T282164: Function calls should return a status tuple with metadata (success, error list, …): function-evaluator, function-schemata.
Wed, Jun 9, 4:50 PM · function-schemata, function-evaluator, function-orchestrator, Abstract Wikipedia team
cmassaro placed T284676: Z14/Implementation component should allow to select one of Z14K2, Z14K3, or Z14K4 up for grabs.
Wed, Jun 9, 4:35 PM · WikiLambda, Abstract Wikipedia team (Phase ζ)
cmassaro assigned T284676: Z14/Implementation component should allow to select one of Z14K2, Z14K3, or Z14K4 to arthurlorenzi.
Wed, Jun 9, 4:33 PM · WikiLambda, Abstract Wikipedia team (Phase ζ)
cmassaro claimed T283740: Have the orchestrator dereference functions, implementations, testers, etc. as needed.
Wed, Jun 9, 4:15 PM · Patch-For-Review, Abstract Wikipedia team (Phase ζ), function-orchestrator
cmassaro renamed T282742: Fix Python Executor Unit Test in `function-evaluator` repo from Fix Python Executor Unit Test to `function-evaluator` repo to Fix Python Executor Unit Test in `function-evaluator` repo.
Wed, Jun 9, 4:14 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ζ)

Tue, Jun 8

cmassaro closed T284484: Expose API Endpoint to Dereference ZObjects in WikiLambda Extension, a subtask of T283740: Have the orchestrator dereference functions, implementations, testers, etc. as needed, as Invalid.
Tue, Jun 8, 10:01 PM · Patch-For-Review, Abstract Wikipedia team (Phase ζ), function-orchestrator
cmassaro closed T284484: Expose API Endpoint to Dereference ZObjects in WikiLambda Extension as Invalid.
Tue, Jun 8, 10:01 PM · Abstract Wikipedia team, function-orchestrator
cmassaro added a comment to T284484: Expose API Endpoint to Dereference ZObjects in WikiLambda Extension.

Yes, I was mistaken yesterday. I am using wikilambda_fetch and it does what I need. Closing.

Tue, Jun 8, 10:01 PM · Abstract Wikipedia team, function-orchestrator
cmassaro created T284596: Re-Enable Evaluated Function Call Test in Orchestrator.
Tue, Jun 8, 7:16 PM · Abstract Wikipedia team

Mon, Jun 7

cmassaro added a project to T284515: Orchestrator Should Respect Z14K4, Not Z8K5: function-orchestrator.
Mon, Jun 7, 11:08 PM · Abstract Wikipedia team (Phase ζ), function-orchestrator
cmassaro created T284515: Orchestrator Should Respect Z14K4, Not Z8K5.
Mon, Jun 7, 11:08 PM · Abstract Wikipedia team (Phase ζ), function-orchestrator
cmassaro committed rMSFE7ca67f1f13f9: Fix Python executor unit tests. (authored by cmassaro).
Fix Python executor unit tests.
Mon, Jun 7, 9:08 PM
cmassaro added a comment to T283902: Evaluator service dies on receiving a request.

Yes, agreed. I am just wondering if the fallback instructions in the README can be made more clear.

Mon, Jun 7, 7:42 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
cmassaro added a comment to T283902: Evaluator service dies on receiving a request.

Two questions on this:

Mon, Jun 7, 5:59 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
cmassaro moved T284484: Expose API Endpoint to Dereference ZObjects in WikiLambda Extension from Phase ζ to To triage on the Abstract Wikipedia team board.
Mon, Jun 7, 5:32 PM · Abstract Wikipedia team, function-orchestrator
cmassaro created T284484: Expose API Endpoint to Dereference ZObjects in WikiLambda Extension.
Mon, Jun 7, 5:30 PM · Abstract Wikipedia team, function-orchestrator
cmassaro renamed T282742: Fix Python Executor Unit Test in `function-evaluator` repo from Add Executor Unit Tests to CI for `function-evaluator` Repo to Fix Python Executor Unit Test to `function-evaluator` repo.
Mon, Jun 7, 5:02 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ζ)
cmassaro claimed T282828: Enable Executor Tests in CI.
Mon, Jun 7, 5:01 PM · function-evaluator, Abstract Wikipedia team (Phase ζ), Patch-For-Review
cmassaro added a parent task for T284474: Add tests for normalize/canonicalize code in frontend.: T282745: Add function-schemata to frontend in order to remedy hybrid forms.
Mon, Jun 7, 5:00 PM · Abstract Wikipedia team (Phase ζ)
cmassaro added a subtask for T282745: Add function-schemata to frontend in order to remedy hybrid forms: T284474: Add tests for normalize/canonicalize code in frontend..
Mon, Jun 7, 5:00 PM · Abstract Wikipedia team (Phase ζ), WikiLambda
cmassaro reassigned T282745: Add function-schemata to frontend in order to remedy hybrid forms from cmassaro to Lindsaykwardell.
Mon, Jun 7, 5:00 PM · Abstract Wikipedia team (Phase ζ), WikiLambda
cmassaro created T284474: Add tests for normalize/canonicalize code in frontend..
Mon, Jun 7, 4:42 PM · Abstract Wikipedia team (Phase ζ)

Fri, Jun 4

cmassaro added a comment to T283902: Evaluator service dies on receiving a request.

The patch that fixed this was merged on June 2: https://gerrit.wikimedia.org/r/c/mediawiki/services/function-orchestrator/+/697692

Fri, Jun 4, 7:05 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)

Wed, Jun 2

cmassaro claimed T261468: Composition of functions.
Wed, Jun 2, 3:58 PM · function-evaluator, function-orchestrator, Abstract Wikipedia team (Phase ζ), Epic
cmassaro claimed T282742: Fix Python Executor Unit Test in `function-evaluator` repo.
Wed, Jun 2, 3:57 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ζ)
cmassaro updated the task description for T282745: Add function-schemata to frontend in order to remedy hybrid forms.
Wed, Jun 2, 3:56 PM · Abstract Wikipedia team (Phase ζ), WikiLambda
cmassaro claimed T282745: Add function-schemata to frontend in order to remedy hybrid forms.
Wed, Jun 2, 3:55 PM · Abstract Wikipedia team (Phase ζ), WikiLambda
cmassaro moved T282745: Add function-schemata to frontend in order to remedy hybrid forms from Un-phased work to Phase ζ on the Abstract Wikipedia team board.
Wed, Jun 2, 3:55 PM · Abstract Wikipedia team (Phase ζ), WikiLambda

Tue, Jun 1

cmassaro committed rMSFEcb79ae4dcd0e: Update NPM dependencies and base Docker images in order to resolve Node… (authored by cmassaro).
Update NPM dependencies and base Docker images in order to resolve Node…
Tue, Jun 1, 10:27 PM
cmassaro added a comment to T283902: Evaluator service dies on receiving a request.

Huh. Looks like the buster-node10js images are the culprit: the function-evaluator image isn't building at HEAD, but everything works if I use a different image. I guess that the version of Node packaged in those images doesn't work with some of our dependencies.

Ah, are some of our dependencies not locked down enough?

Tue, Jun 1, 9:02 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
cmassaro updated subscribers of T283902: Evaluator service dies on receiving a request.

Huh. Looks like the buster-node10js images are the culprit: the function-evaluator image isn't building at HEAD, but everything works if I use a different image. I guess that the version of Node packaged in those images doesn't work with some of our dependencies. This should have caused a ruckus and a din in function-evaluator CI. @Jdforrester-WMF, is there a way to get alerts when CI is failing in a repo?

Tue, Jun 1, 8:42 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
cmassaro added a comment to T283902: Evaluator service dies on receiving a request.

Ignore previous comment :). I have replicated this with the latest builds. Investigating now.

Tue, Jun 1, 7:43 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
cmassaro added a comment to T283902: Evaluator service dies on receiving a request.
Tue, Jun 1, 7:38 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)
cmassaro claimed T283902: Evaluator service dies on receiving a request.
Tue, Jun 1, 7:33 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ε)

Thu, May 27

cmassaro added projects to T283832: More Informative Error Propagation between Evaluator and Orchestrator: function-evaluator, function-orchestrator.
Thu, May 27, 3:39 PM · Abstract Wikipedia team (Phase ζ), function-orchestrator, function-evaluator
cmassaro moved T283832: More Informative Error Propagation between Evaluator and Orchestrator from Un-phased work to To triage on the Abstract Wikipedia team board.
Thu, May 27, 3:39 PM · Abstract Wikipedia team (Phase ζ), function-orchestrator, function-evaluator
cmassaro created T283832: More Informative Error Propagation between Evaluator and Orchestrator.
Thu, May 27, 3:38 PM · Abstract Wikipedia team (Phase ζ), function-orchestrator, function-evaluator
cmassaro added a project to T262997: Better validation for recursive types: function-schemata.
Thu, May 27, 3:37 PM · function-schemata, Abstract Wikipedia team (Phase ζ)
cmassaro added projects to T261468: Composition of functions: function-orchestrator, function-evaluator.
Thu, May 27, 3:37 PM · function-evaluator, function-orchestrator, Abstract Wikipedia team (Phase ζ), Epic
cmassaro added a project to T282821: Python execution engine should expect full `def`, not just statement setting return value: function-evaluator.
Thu, May 27, 3:36 PM · function-evaluator, Abstract Wikipedia team (Phase ζ)
cmassaro added a project to T282742: Fix Python Executor Unit Test in `function-evaluator` repo: function-evaluator.
Thu, May 27, 3:36 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team (Phase ζ)

Wed, May 26

cmassaro created T283761: `Workboard`: Make a `function-schemata` tag.
Wed, May 26, 8:30 PM · function-schemata, Abstract Wikipedia team
cmassaro created T283760: `function-schemata` Z14 should accept exactly one of Z14K[234], not require all three.
Wed, May 26, 8:29 PM · function-schemata, Abstract Wikipedia team
cmassaro committed rMSFO581936df2267: Allow orchestrator to make calls to executor. (authored by cmassaro).
Allow orchestrator to make calls to executor.
Wed, May 26, 7:19 PM
cmassaro created T283745: Tighten Test Guarantees in evaluator unit tests.
Wed, May 26, 5:16 PM · Abstract Wikipedia team (Phase ζ), function-evaluator

Tue, May 25

cmassaro committed rMSFO667d0ca72fee: Lock those packages for function-orchestrator's Blubber config (authored by cmassaro).
Lock those packages for function-orchestrator's Blubber config
Tue, May 25, 7:28 PM
cmassaro committed rMSFE9346a1fe811d: Add python3 executor tests to CI pipeline. (authored by cmassaro).
Add python3 executor tests to CI pipeline.
Tue, May 25, 6:11 PM
cmassaro added a comment to T280070: Provide a CI mechanism by which we can test end-to-end integration between MW and back-end services, e.g. via docker-compose.

Specifically, it would be very nice if we could influence the MW docker-compose configuration when testing the Wikilambda extension. This way, we could introduce other services (viz. function-orchestrator and function-evaluator) for purposes of integration testing.

Tue, May 25, 4:58 PM · Release Pipeline, Release-Engineering-Team (Seen)

May 14 2021

cmassaro updated the task description for T277914: Provide a more expansive test suite for the built-in functions in the orchestrator.
May 14 2021, 7:22 PM · Abstract Wikipedia team, function-orchestrator
cmassaro updated the task description for T282891: Migrate Duplicated Code in orchestrator/evaluator to `function-schemata`.
May 14 2021, 6:34 PM · function-schemata, Abstract Wikipedia team
cmassaro updated the task description for T282891: Migrate Duplicated Code in orchestrator/evaluator to `function-schemata`.
May 14 2021, 6:13 PM · function-schemata, Abstract Wikipedia team
cmassaro created T282891: Migrate Duplicated Code in orchestrator/evaluator to `function-schemata`.
May 14 2021, 6:10 PM · function-schemata, Abstract Wikipedia team
cmassaro claimed T282843: Hook up orchestrator to the evaluator and pass through appropriately-dereferenced Z7 calls.
May 14 2021, 5:38 PM · Patch-For-Review, Abstract Wikipedia team (Phase ε), function-evaluator, function-orchestrator
cmassaro added a comment to T282821: Python execution engine should expect full `def`, not just statement setting return value.

Yes, I think any of the below is fine:

May 14 2021, 1:13 AM · function-evaluator, Abstract Wikipedia team (Phase ζ)
cmassaro committed rMSFEf82cdb446ac0: JavaScript executor (authored by cmassaro).
JavaScript executor
May 14 2021, 12:14 AM

May 13 2021

cmassaro created T282829: Symlink test_data files in `function-evaluator` to executor test subdirectories.
May 13 2021, 8:33 PM · function-evaluator, Abstract Wikipedia team