Page MenuHomePhabricator
Create Task
Maniphest T351473

Create a More General Solution for Metadata Merging
Closed, ResolvedPublic
Actions

Description

Description

If a function in the orchestrator receives a Z22 and then returns another Z22, it should not discard the metadata associated with the received Z22. Instead, it should intelligently merge that metadata with any metadata that will be produced in the current function.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • ensure that metadata is always merged instead of being discarded

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (307671a)mediawiki/extensions/WikiLambdamaster+1 -1
wikifunctions: Upgrade evaluators from 2024-05-13-145650 to 2024-05-28-185827operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2024-05-13-145903 to 2024-05-23-164021operations/deployment-chartsmaster+1 -1
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Update function-schemata sub-module to HEAD (86cfa0b)repos/abstract-wiki/wikifunctions/function-evaluator!215jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (86cfa0b)repos/abstract-wiki/wikifunctions/function-orchestrator!171apinesync-function-schematamain
Add ZEnvelopeWrapper with specialized metadata property.repos/abstract-wiki/wikifunctions/function-orchestrator!170apineapine-metadata-2main
Add ZWrapperBase so that setMetadata* functions can handle ZWrappers in addition to bare Z22s.repos/abstract-wiki/wikifunctions/function-schemata!118apineapine-metadata-utilsmain
Customize query in GitLab

Related Objects
Search...

Event Timeline

cmassaro created this task.Nov 16 2023, 9:59 PM
cmassaro added a parent task: T342656: Consider Creating a Way to Debug Native Code Functions.
Jdforrester-WMF triaged this task as Medium priority.Nov 30 2023, 5:43 PM
Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.
ecarg subscribed.Mar 20 2024, 5:29 AM

To add to this; a specific example of why this will be helpful can be seen when we are testing out an implementation of a function. E.g. https://www.wikifunctions.org/view/en/Z13453, we click on 'details', we do not see which implementations were run to gather test results; when for this function there is both a JS and Py implementation. As a user, I would want to know which implementation(s) was used

Screenshot 2024-03-19 at 10.25.25 PM.png (470×1 px, 46 KB)
.

cmassaro moved this task from Backlog to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.Apr 24 2024, 7:22 PM
cmassaro edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.
Jdforrester-WMF removed a parent task: T342656: Consider Creating a Way to Debug Native Code Functions.Apr 24 2024, 7:22 PM
cmassaro added a parent task: T363384: [24Q4] Make it easier for users to debug their code by having each function sub-call return a complete metadata map.Apr 24 2024, 7:26 PM
Jdforrester-WMF added a parent task: T363385: [EPIC] Q4 - Make it easier for users to debug their code by having each function sub-call return a complete metadata map.Apr 24 2024, 7:27 PM
Jdforrester-WMF removed a parent task: T363385: [EPIC] Q4 - Make it easier for users to debug their code by having each function sub-call return a complete metadata map.
Jdforrester-WMF moved this task from Incoming to Ready, Features on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Apr 24 2024, 7:39 PM
Jdforrester-WMF added a parent task: T363396: Frontend: Display Nested Metadata Maps.Apr 24 2024, 7:50 PM
CodeReviewBot added a project: Patch-For-Review.May 15 2024, 11:19 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/118

Add ZWrapperBase so that setMetadata* functions can handle ZWrappers in addition to bare Z22s.

CodeReviewBot added a comment.May 16 2024, 12:53 AM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/170

Draft: Add ZEnvelopeWrapper with specialized metadata property.

CodeReviewBot added a comment.May 16 2024, 6:11 PM

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/118

Add ZWrapperBase so that setMetadata* functions can handle ZWrappers in addition to bare Z22s.

CodeReviewBot added a comment.May 16 2024, 6:40 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/171

Update function-schemata sub-module to HEAD (86cfa0b)

CodeReviewBot added a comment.May 16 2024, 6:43 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/215

Update function-schemata sub-module to HEAD (86cfa0b)

CodeReviewBot added a comment.May 16 2024, 6:45 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/171

Update function-schemata sub-module to HEAD (86cfa0b)

cmassaro claimed this task.May 16 2024, 7:53 PM
CodeReviewBot added a comment.May 17 2024, 2:02 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/215

Update function-schemata sub-module to HEAD (86cfa0b)

cmassaro changed the task status from Open to In Progress.May 22 2024, 3:10 PM
cmassaro moved this task from Ready, Features to In Progress on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.
CodeReviewBot added a comment.May 22 2024, 6:50 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/170

Add ZEnvelopeWrapper with specialized metadata property.

gerritbot added a comment.May 29 2024, 2:10 PM

Change #1037084 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-05-13-145903 to 2024-05-23-164021

https://gerrit.wikimedia.org/r/1037084

gerritbot added a comment.May 29 2024, 2:10 PM

Change #1037085 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-05-13-145650 to 2024-05-28-185827

https://gerrit.wikimedia.org/r/1037085

gerritbot added a comment.May 29 2024, 2:12 PM

Change #1037084 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-05-13-145903 to 2024-05-23-164021

https://gerrit.wikimedia.org/r/1037084

gerritbot added a comment.May 29 2024, 2:21 PM

Change #1037085 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-05-13-145650 to 2024-05-28-185827

https://gerrit.wikimedia.org/r/1037085

Jdforrester-WMF subscribed.May 29 2024, 2:51 PM

AIUI what's left here is to actually use this for multi-call functions? As a trivial test case, I think the following should work?

{
    "Z1K1": "Z7",
    "Z7K1": {
        "Z1K1": "Z8",
        "Z8K1": [
            "Z17",
            {
                "Z1K1": "Z17",
                "Z17K1": "Z6",
                "Z17K2": { "Z1K1": "Z6", "Z6K1": "Z400K1" },
                "Z17K3": { "Z1K1": "Z12", "Z12K1": [ "Z11" ] }
            },
            {
                "Z1K1": "Z17",
                "Z17K1": "Z6",
                "Z17K2": { "Z1K1": "Z6", "Z6K1": "Z400K2" },
                "Z17K3": { "Z1K1": "Z12", "Z12K1": ["Z11"] }
            }
        ],
        "Z8K2": "Z1",
        "Z8K3": [ "Z20" ],
        "Z8K4": [
            "Z14",
            {
                "Z1K1": "Z14",
                "Z14K1": "Z400",
                "Z14K3": {
                    "Z1K1": "Z16",
                    "Z16K1": "Z600",
                    "Z16K2": "function Z400(Z400K1,Z400K2){return(parseInt(Z400K1)+parseInt(Z400K2)).toString();}"
                }
            }
        ],
        "Z8K5": "Z400"
    },
    "Z400K1": { "Z1K1": "Z7", "Z7K1": "Z801", "Z801K1": "2" },
    "Z400K2": { "Z1K1": "Z7", "Z7K1": "Z801", "Z801K1": "3" }
}
gerritbot added a comment.May 31 2024, 1:57 PM

Change #1037796 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (307671a)

https://gerrit.wikimedia.org/r/1037796

gerritbot added a comment.Jun 1 2024, 1:04 AM

Change #1037796 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (307671a)

https://gerrit.wikimedia.org/r/1037796

Jdforrester-WMF added a parent task: T366498: Add and populate new nested meta-data key/value in the orchestrator.Jun 3 2024, 4:21 PM
Jdforrester-WMF removed a parent task: T363396: Frontend: Display Nested Metadata Maps.
Jdforrester-WMF moved this task from In Progress to Ready to deploy on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Jun 11 2024, 3:33 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Jun 26 2024, 2:17 PM
Jdforrester-WMF closed this task as Resolved.Jul 10 2024, 4:43 PM
cmassaro mentioned this in rMSFEe6b2641286ad: Update function-schemata sub-module to HEAD (86cfa0b).Oct 3 2025, 9:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits