Change #1036184 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Add nested metadata to FunctionMetadataDialog component

https://gerrit.wikimedia.org/r/1036184

Tested with the latest orchestrator fixes.

• We are able to see the menu selector displaying the zObjectKey keys indented properly
• The zObjectKey keys are labelized properly
• We are able to select the function call and see its metadata
• The metadata dialog selection is reset when its closed and re-opened (cc. suggested by @AAlhazwani-WMF)

Observed issues

Here are some observations of use cases that I'm unable to test. I'm not sure if this is expected or not, so will note everything down and wait for @cmassaro @Jdforrester-WMF to confirm:

1. There is no nested metadata when the implementation is a composition
   • E.g. say I create an And implementation that is a composition of If ( "first argument", "second argument", Echo( Boolean("false") ) ) and I call And( Boolean("false"), Boolean("true") )
   • Even though we have run And(), If() and Echo(), there are no nested details of these different executions
   • Is this expected behavior??
2. Child function calls don't return any metadata, apart from their zObjectKey:
   
3. Some child function calls that are part of the parent function call are not being returned in the nested metadata key
   • In the example below, the function call tree is:

* And (
  * Echo (Boolean{"identity":"false"}),
  * If (
     * Boolean{"identity":"true"},
     * Boolean{"identity":"false"},
     * And (Boolean{"identity":"true"}, Boolean{"identity":"true"})))

• The only function calls reported are the parent-most And and the first direct child, Echo:
  
• When inverting the order of the direct children:

* And (
  * If (
     * Boolean{"identity":"true"},
     * Boolean{"identity":"false"},
     * Boolean{"identity": "true"}
  * Echo (Boolean{"identity":"false"}))

• We also see that only the first child (If) is added into the nestedMetadata list:
  
• We also observe that the nested metadata tree stops at the first level, only the first direct child of the parent call seems to appear. See an example of the first child, If, having a child function call Echo:
  

Change #1036184 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add nested metadata to FunctionMetadataDialog component

https://gerrit.wikimedia.org/r/1036184

Will move T366498 back to In-Progress, per above.

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/190

Recursively pass addNestedMetadata flag.

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/191

Draft: Apine grandbabies

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/190

Recursively pass addNestedMetadata flag.

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/191

Make ReferenceResolver.dereference return a bare object (not a ZWrapper) and clean up treatment of nested metadata.

Change #1046787 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-06-11-223956 to 2024-06-17-221517

https://gerrit.wikimedia.org/r/1046787

Change #1046787 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-06-11-223956 to 2024-06-17-221517

https://gerrit.wikimedia.org/r/1046787

Patches deployed.