Page MenuHomePhabricator

ecarg (Grace)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 7 2023, 9:56 PM (24 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
GChoi-WMF [ Global Accounts ]

Recent Activity

Thu, Apr 25

ecarg added a subtask for T350036: Add Wikifunctions services' application-level Prometheus metrics to main dashboard: T363494: [spike] figure out if and how to hook services into our Grafana board.
Thu, Apr 25, 4:37 PM · function-evaluator, function-orchestrator, Abstract Wikipedia team
ecarg added a parent task for T363494: [spike] figure out if and how to hook services into our Grafana board: T350036: Add Wikifunctions services' application-level Prometheus metrics to main dashboard.
Thu, Apr 25, 4:37 PM · Abstract Wikipedia team (24Q4 (Apr–Jun))
ecarg created T363494: [spike] figure out if and how to hook services into our Grafana board.
Thu, Apr 25, 4:37 PM · Abstract Wikipedia team (24Q4 (Apr–Jun))

Fri, Apr 19

ecarg added a comment to T345010: Show a better error state in the function evaluator widget.

Hi @Jdforrester-WMF ! Does this issue still exist? If so, could you add the steps on how to reproduce this behavior and what the desired outcome should look like? TY

Fri, Apr 19, 5:36 PM · Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, Abstract Wikipedia team
ecarg updated subscribers of T300512: WikiLambda: Have a unified source of ZErrorType IDs.

Hello @gengh || @Jdforrester-WMF

  • How do these files differ from the purpose of data/errors/error_types.yaml?
  • When we consolidate, could we store said errors we need from error.js into a yaml file? So that using them in both JS and PHP is easy?
Fri, Apr 19, 5:28 PM · Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-schemata, WikiLambda

Thu, Apr 18

ecarg added a comment to T343125: Global language selector review.

Hello! Is this still an issue? Also, what do we mean by 'ULS'?

Thu, Apr 18, 1:48 AM · Abstract Wikipedia team
ecarg added a comment to T335922: Revisit the language selector control UX, and see if we can improve it to something similar to the ULS control.

Hello! Does this task still exist as an issue or are there any updates to this?

Thu, Apr 18, 1:46 AM · Epic, WikiLambda Front-end, Design, Abstract Wikipedia team
ecarg added a comment to T346031: Language count is updated before publish in about widget.

To confirm, this is still occurring and we still want to make this change when in 'Read' mode bc it is fine in 'Edit' mode?

Thu, Apr 18, 1:44 AM · Design, Abstract Wikipedia team
ecarg added a comment to T360610: Improve About widget experience for translators and multi-lingual contributors.

I really like the idea of this functionality

Thu, Apr 18, 1:40 AM · WikiLambda Front-end, Design, Abstract Wikipedia team
ecarg added a comment to T340845: Unknown key and zids show inconsistently "Untitled" or their ID.

Hello! Any updates on the discussion/thread? Have we decided on what to go with?

Thu, Apr 18, 1:22 AM · Abstract Wikipedia team (24Q4 (Apr–Jun)), Design, WikiLambda Front-end, WikiLambda
ecarg added a comment to T309039: Use the Vue chip component on the object title.

I notice the last thread here was a couple years back haha, is this still blocked? And does the checklist need updating (aka. is this still an issue or some part(s) of it)?

Thu, Apr 18, 1:07 AM · WikiLambda, Abstract Wikipedia team
ecarg added a comment to T359772: Wikifunctions objects show descriptions and aliases in languages that aren't related to the user.

I would be confused having random lang aliases shown to me. How does the 'system' know what languages 'are related to me'? Does this mean, if in the case I have logged in in English, Hebrew, and Arabic at some point?

Thu, Apr 18, 1:06 AM · Abstract Wikipedia team (24Q4 (Apr–Jun)), Wikifunctions, WikiLambda
ecarg added a comment to T359782: Make ZMonolingualString's hard-coded English placeholder label for "Enter text" proper i18n.

To clarify, the acceptance criteria is to see "Enter Text" in the respective user language and not in English for every language?

  • Do we expect to have translation for every language or can we have a fallback language with a chip?
Thu, Apr 18, 12:00 AM · Abstract Wikipedia team (24Q4 (Apr–Jun)), I18n, Wikifunctions, WikiLambda

Tue, Apr 16

ecarg created T362711: Clean up [Vue warn:] logs .
Tue, Apr 16, 7:16 PM · WikiLambda Front-end, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team
ecarg created T362708: Clean up [Vue warn.
Tue, Apr 16, 7:12 PM · Abstract Wikipedia team
ecarg placed T342912: Special:ListObjectsByType have no paging up for grabs.
Tue, Apr 16, 3:33 PM · Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (24Q4 (Apr–Jun)), WikiLambda Front-end, good first task, WikiLambda

Mon, Apr 15

ecarg claimed T342912: Special:ListObjectsByType have no paging.
Mon, Apr 15, 10:32 PM · Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (24Q4 (Apr–Jun)), WikiLambda Front-end, good first task, WikiLambda
ecarg claimed T362056: ExpandedToggle: Internationalize ExpandedToggle aria-label="Toggle" string.
Mon, Apr 15, 7:34 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), Abstract Wikipedia team (24Q4 (Apr–Jun)), Accessibility, Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, WikiLambda
ecarg created T362562: Refactor: replace variable declaration.
Mon, Apr 15, 4:56 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), WikiLambda Front-end, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team

Fri, Apr 12

ecarg updated the task description for T358207: Unit tests: Add tests to all the ignored base components that are planned to stay.
Fri, Apr 12, 8:03 PM · Abstract Wikipedia team (24Q4 (Apr–Jun)), MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, WikiLambda
ecarg moved T358596: Frontend cleanup: Remove duplicate isNewZObject and isCreateNewPage from Backlog to In Progress on the Abstract Wikipedia team board.
Fri, Apr 12, 7:33 PM · Abstract Wikipedia team (24Q4 (Apr–Jun)), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, WikiLambda

Wed, Apr 10

ecarg added a comment to T287154: Switch function-orchestrator from hard-coded strings to using Z61/Programming language objects.

Update:

  • regardless of 'successful' result from Beta or Prod, we don't actually know for sure if Orch is truly routing the Z61 refs appropriately bc we are mocking this behavior kind of.
  • in order to know for sure, we need testing in the orchestrator
Wed, Apr 10, 9:25 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Abstract Wikipedia team, function-orchestrator
ecarg added a comment to T358204: Unit tests: Add awaits to all waitFor statements in jest tests.

Hello! What is the best way to know/verify this:

if tests had undetected failures, they should be fixed

Wed, Apr 10, 8:29 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, WikiLambda, Abstract Wikipedia team

Tue, Apr 9

ecarg claimed T360510: Overflow Issue: Short Description Exceeds Container Limits.
Tue, Apr 9, 10:58 PM · Abstract Wikipedia team (24Q4 (Apr–Jun)), WikiLambda Front-end
ecarg claimed T358204: Unit tests: Add awaits to all waitFor statements in jest tests.
Tue, Apr 9, 10:56 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, WikiLambda, Abstract Wikipedia team
ecarg claimed T358596: Frontend cleanup: Remove duplicate isNewZObject and isCreateNewPage.
Tue, Apr 9, 10:55 PM · Abstract Wikipedia team (24Q4 (Apr–Jun)), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, WikiLambda
ecarg added a comment to T357696: Refactor: DRY up repeated logic in some ZCode implementation files.

(Un-assigning myself for now as I'll prioritize other 'fix-it' tasks; am happy to pick up later or not, TY)

Tue, Apr 9, 10:52 PM · WikiLambda Front-end, WikiLambda, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team
ecarg placed T357696: Refactor: DRY up repeated logic in some ZCode implementation files up for grabs.
Tue, Apr 9, 10:51 PM · WikiLambda Front-end, WikiLambda, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team

Thu, Apr 4

ecarg added a comment to T287154: Switch function-orchestrator from hard-coded strings to using Z61/Programming language objects.

Current status: we think we've seen this configuration/routing fail either or both in Beta and Prod so we need to verify which/where and why, then how.

Thu, Apr 4, 5:50 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Abstract Wikipedia team, function-orchestrator

Mar 27 2024

ecarg moved T358207: Unit tests: Add tests to all the ignored base components that are planned to stay from Backlog to In Progress on the Abstract Wikipedia team board.

The checklist/task will be tackled in separate patches

Mar 27 2024, 4:59 AM · Abstract Wikipedia team (24Q4 (Apr–Jun)), MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, WikiLambda

Mar 26 2024

ecarg moved T359158: About Widget: Replace description cdx-text-input and use cdx-text-area instead from Backlog to In Progress on the Abstract Wikipedia team board.
Mar 26 2024, 4:56 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, WikiLambda, Abstract Wikipedia team
ecarg moved T322345: Raise Error If Code Executor Spits out Pure Whitespace to the Evaluator from Backlog to In Progress on the Abstract Wikipedia team board.
Mar 26 2024, 5:25 AM · Patch-For-Review, Abstract Wikipedia team, function-evaluator

Mar 22 2024

ecarg added a comment to T347901: Fix the Benchmark for the WASMedge-based Evaluators and Enable in CI .

Observations so far:

  • _mocha test/benchmarks/javascriptEvaluatorBenchmarks.js takes forever (10 minutes in, it's still going⏳)
  • _mocha test/benchmarks/pythonEvaluatorBenchmarks.js immediately returns:
(node:48369) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Mar 22 2024, 10:07 PM · function-evaluator, Abstract Wikipedia team
ecarg added a comment to T337589: Scopes Are Not Always Attached to ZObjects Correctly.

If the status on this is still the same, would it make sense to mark this as 'Low'? Sry to intrude, just scouring for a good BE task to pick up!

Mar 22 2024, 8:28 PM · Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
ecarg added a comment to T360791: Value fields for natural numbers display "Display function returned an unknown error.".

Ah I see~ @cmassaro
Also, until Geno comes back:/resources/ext.wikilambda.edit/components/default-view-types/ZObjectStringRenderer.vue

Mar 22 2024, 8:12 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), WikiLambda Front-end, Patch-For-Review, Abstract Wikipedia team
ecarg added a comment to T360791: Value fields for natural numbers display "Display function returned an unknown error.".

That error looks familiar @cmassaro 💀

Mar 22 2024, 7:01 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), WikiLambda Front-end, Patch-For-Review, Abstract Wikipedia team
ecarg added a comment to T322345: Raise Error If Code Executor Spits out Pure Whitespace to the Evaluator.

Noting I'm having trouble reproducing this issue; below is brief of what I tried:

Mar 22 2024, 6:41 PM · Patch-For-Review, Abstract Wikipedia team, function-evaluator

Mar 20 2024

ecarg moved T358209: Modify page header in object edit page when the main label is changed during an edit, before the change is published from Backlog to In Progress on the Abstract Wikipedia team board.
Mar 20 2024, 6:25 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), WikiLambda Front-end, WikiLambda, Abstract Wikipedia team
ecarg added a comment to T351473: Create a More General Solution for Metadata Merging.

To add to this; a specific example of why this will be helpful can be seen when we are testing out an implementation of a function. E.g. https://www.wikifunctions.org/view/en/Z13453, we click on 'details', we do not see which implementations were run to gather test results; when for this function there is both a JS and Py implementation. As a user, I would want to know which implementation(s) was used

Screenshot 2024-03-19 at 10.25.25 PM.png (470×1 px, 46 KB)
.

Mar 20 2024, 5:29 AM · Abstract Wikipedia team (24Q4 (Apr–Jun)), function-schemata, function-orchestrator
ecarg moved T358543: List equality throwing a Z564/Invalid executor response for test using Z872/Filter from To deploy to Verify in production on the Abstract Wikipedia team board.
Mar 20 2024, 5:21 AM · Abstract Wikipedia team (24Q4 (Apr–Jun)), function-orchestrator, function-evaluator, Wikifunctions
ecarg moved T358543: List equality throwing a Z564/Invalid executor response for test using Z872/Filter from Backlog to To deploy on the Abstract Wikipedia team board.
Mar 20 2024, 5:21 AM · Abstract Wikipedia team (24Q4 (Apr–Jun)), function-orchestrator, function-evaluator, Wikifunctions
ecarg added a comment to T358543: List equality throwing a Z564/Invalid executor response for test using Z872/Filter.

Hello! I have tried out this using the provided link, using a string reference as well as string as input and it seems this is no longer an issue. Will move this to 'Verify In Prod' for now~

Mar 20 2024, 5:21 AM · Abstract Wikipedia team (24Q4 (Apr–Jun)), function-orchestrator, function-evaluator, Wikifunctions

Mar 8 2024

ecarg added a comment to T359651: Zobjs fail to build using docker compose exec mediawiki php maintenance/run.php update and npm run local:setup.

From my end, since docker compose exec mediawiki php maintenance/run.php update was giving me the following (stopping at random Z objs) several times:

Mar 8 2024, 5:44 PM · Abstract Wikipedia Fix-It tasks, WikiLambda, Abstract Wikipedia team

Mar 7 2024

ecarg added a comment to T346006: "Select function" when function is already selected.

To clarify following the discussion thread, we want to:

  • show an empty string, "" if none has already been selected (instead of "Select function")
  • but if said function has already been selected, we want to show that (instead of "Select function")
Mar 7 2024, 5:39 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WikiLambda Front-end, Abstract Wikipedia team, Wikifunctions
ecarg added a comment to T346006: "Select function" when function is already selected.

Hello, the link mentioned a couple times here, shttps://www.wikifunctions.org/view/en/Z10601 just send/redirects me to https://www.wikifunctions.org/wiki/Wikifunctions:Main_Page 🤔?

Mar 7 2024, 5:16 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WikiLambda Front-end, Abstract Wikipedia team, Wikifunctions
ecarg updated subscribers of T343653: Edit button of old revision links to wrong location.

Hi @Jdforrester-WMF! I am not able to reproduce this in my local environment atm.

  1. I made some revisions to a created function w/ implementations
  2. Clicked on the revision history to view a single page of an old revision (w/ 'oldid')
  3. Clicked on 'edit' and the function and persistent obj fields have not changed
Mar 7 2024, 5:03 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WikiLambda, Abstract Wikipedia team

Mar 5 2024

Etonkovidova awarded T346852: Special:RunFunction - improvements needed for messages to users a Yellow Medal token.
Mar 5 2024, 4:33 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Abstract Wikipedia team, WikiLambda Front-end

Mar 4 2024

ecarg updated subscribers of T353236: Function Editor: Change function descriptions to use cdx-text-area not cdx-input.

I think the nit should be a new task because it seems a bit more complicated than just adding an isolated way to read LTR or RTL just from the text box. If I go to https://www.wikifunctions.org/view/he/Z10000 (already set to a different language, for ex. Hebrew), the page knows to set RTL; however, if we are wanting just the text box to detect a Hebrew selection when we're on an English page (i.e. https://www.wikifunctions.org/view/en/Z10000), manipulating that does not seem straightforward to me. What do you guys think @AAlhazwani-WMF @Jdforrester-WMF @gengh

Mar 4 2024, 7:43 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), WikiLambda Front-end, Abstract Wikipedia team

Mar 1 2024

ecarg added a comment to T353236: Function Editor: Change function descriptions to use cdx-text-area not cdx-input.

nit: if we could display the char counter on the right (for LTR languages, and left for RLT) it would be great! similarly to this demo https://doc.wikimedia.org/codex/latest/components/demos/field.html#fieldset-with-custom-help-text-content

Mar 1 2024, 7:21 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), WikiLambda Front-end, Abstract Wikipedia team
ecarg added a comment to T353236: Function Editor: Change function descriptions to use cdx-text-area not cdx-input.

Ok so it was RTL, thank you 😸!

Mar 1 2024, 6:25 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), WikiLambda Front-end, Abstract Wikipedia team
ecarg added a comment to T353236: Function Editor: Change function descriptions to use cdx-text-area not cdx-input.

Hi @AAlhazwani-WMF what do we mean by 'LTR' and 'RLT'? Google says, 'long term relationship' and 'revocable living trust' 😆 .

Mar 1 2024, 6:20 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), WikiLambda Front-end, Abstract Wikipedia team
ecarg updated subscribers of T347536: Passed tests on Function details just shows - instead of 3/3.
Mar 1 2024, 5:58 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WikiLambda Front-end, Abstract Wikipedia team
ecarg added a comment to T347536: Passed tests on Function details just shows - instead of 3/3.

In the code (WikiLambda/resources/ext.wikilambda.edit/components/function/viewer/FunctionViewerDetails.vue) where this test data would get initialized, I see mention of this task commented, 'TODO (T310003): fetch these from a cached table in mediawiki'. Perhaps this is not a bug, rather a non-trivial task and we are intentionally using '-' for the time being 🤔 ? @Jdforrester-WMF do you recall/have thoughts?

Mar 1 2024, 5:57 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WikiLambda Front-end, Abstract Wikipedia team
ecarg added a comment to T347536: Passed tests on Function details just shows - instead of 3/3.

Do we know when we began to see this bug? Around the date this was reported, late September 2023?

Mar 1 2024, 5:40 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WikiLambda Front-end, Abstract Wikipedia team

Feb 21 2024

ecarg added a comment to T358058: Custom Type Converters Are Not Working.

lol the description on behaviors love it XD

Feb 21 2024, 4:58 AM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team

Feb 15 2024

sbassett awarded T335695: Install the Application Security Pipeline templates for function-orchestrator's GitLab repo a Like token.
Feb 15 2024, 7:10 PM · Security-Team, SecTeam-Processed, Security Architecture Tooling, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
ecarg created T357696: Refactor: DRY up repeated logic in some ZCode implementation files.
Feb 15 2024, 4:58 PM · WikiLambda Front-end, WikiLambda, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team
ecarg added a project to T357681: Refactor Constants in Wikilambda: Abstract Wikipedia team.
Feb 15 2024, 3:29 PM · Abstract Wikipedia team, WikiLambda Front-end, WikiLambda, Abstract Wikipedia Fix-It tasks
ecarg created T357681: Refactor Constants in Wikilambda.
Feb 15 2024, 3:29 PM · Abstract Wikipedia team, WikiLambda Front-end, WikiLambda, Abstract Wikipedia Fix-It tasks

Feb 9 2024

ecarg added a comment to T347898: Allow for Error Handling in WASM JS.

kept some notes in this doc

Feb 9 2024, 3:15 AM · function-evaluator, Abstract Wikipedia team

Feb 7 2024

ecarg added a comment to T355815: Try to Use a Blubber Variant When Building Coverage Reports.

Nice!

Feb 7 2024, 1:07 AM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team

Jan 22 2024

ecarg updated the task description for T347103: Find/Implement Stable-Stringify without Node.
Jan 22 2024, 9:41 PM · Patch-For-Review, function-evaluator, Abstract Wikipedia team

Nov 9 2023

ecarg created T350918: Requesting access to WMF LDAP group and deployment and analytics-privatedata-users shell access group for Grace (ecarg).
Nov 9 2023, 9:10 PM · SRE, SRE-Access-Requests

Nov 8 2023

ecarg created T350818: Grant Access to WMF for ecarg.
Nov 8 2023, 6:13 PM · SRE, LDAP-Access-Requests
ecarg created T350753: Unable to add/save SSH keys.
Nov 8 2023, 2:07 AM · Gerrit