Page MenuHomePhabricator

Passed tests on Function details just shows - instead of 3/3
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The column has just - on each line

What should have happened instead?:
If I remember correctly it should show a summary count of how many of the tests passed of how many of the total tests, in this case for example, 3 out of 3 tests passed, i.e. 3/3

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.

Do we know when we began to see this bug? Around the date this was reported, late September 2023?

In the code (WikiLambda/resources/ext.wikilambda.edit/components/function/viewer/FunctionViewerDetails.vue) where this test data would get initialized, I see mention of this task commented, 'TODO (T310003): fetch these from a cached table in mediawiki'. Perhaps this is not a bug, rather a non-trivial task and we are intentionally using '-' for the time being 🤔 ? @Jdforrester-WMF do you recall/have thoughts?

Ok and linked task says it's a dupe of this one which apparently says is resolved 😅 .

T310003 is indeed done via T297707 – we cache the results in the wikilambda_ztester_results table, which we access via the ZObjectStore::findZTesterResult() method in PHP (which the API calls). I think that's unrelated to this bug.

In the zTesterResults.js store module there's a getter called getZTesterPercentage which takes an implementation zid and returns an object such as this:

{
  passing: 3,
  total: 5,
  percentage: 60
}

This getter can be used from the implementationsBody loop to create the "passing/total" for each row.

Change 1008963 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Implementation Table should show test results

https://gerrit.wikimedia.org/r/1008963

Change 1008963 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Implementation Table should show test results

https://gerrit.wikimedia.org/r/1008963

Jdforrester-WMF changed the task status from Open to In Progress.Mar 12 2024, 5:18 PM
Jdforrester-WMF assigned this task to ecarg.
Jdforrester-WMF moved this task from Backlog to To deploy on the Abstract Wikipedia team board.