Maniphest T358596

Frontend cleanup: Remove duplicate isNewZObject and isCreateNewPage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	gengh
	Feb 27 2024, 3:22 PM

Tags

Referenced Files

None

Subscribers

Description

Description

The getters isNewZObject and isCreateNewPage both return true when we are creating a new object. Both of them are used in different places.
We should remove one of them, including the state object and the related setters and getters, and use the other everywhere.

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

	Subject	Repo	Branch	Lines +/-
	Remove duplicate function	mediawiki/extensions/WikiLambda	master	+39 -66
	Remove duplicate isNewZObject and isCreateNewPage	mediawiki/extensions/WikiLambda	master	+57 -84

Customize query in gerrit

Event Timeline

gengh created this task.Feb 27 2024, 3:22 PM

Jdforrester-WMF triaged this task as Lowest priority.Feb 29 2024, 5:48 PM

Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.

ecarg claimed this task.Apr 9 2024, 10:55 PM

Change #1019338 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Remove duplicate isNewZObject and isCreateNewPage

https://gerrit.wikimedia.org/r/1019338

gerritbot added a project: Patch-For-Review.Apr 12 2024, 7:32 PM

ecarg moved this task from Backlog to In Progress on the Abstract Wikipedia team board.Apr 12 2024, 7:33 PM

Change #1021652 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Remove duplicate function

https://gerrit.wikimedia.org/r/1021652

Change #1019338 abandoned by Ecarg:

[mediawiki/extensions/WikiLambda@master] Remove duplicate isNewZObject and isCreateNewPage

Reason:

https://gerrit.wikimedia.org/r/1019338

Jdforrester-WMF moved this task from In Progress to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.Apr 29 2024, 5:51 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to In Progress on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.

Change #1021652 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove duplicate function

https://gerrit.wikimedia.org/r/1021652

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 7 2024, 2:00 PM

Jdforrester-WMF moved this task from In Progress to Needs QA on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.May 7 2024, 2:12 PM

Maintenance_bot removed a project: Patch-For-Review.May 7 2024, 2:31 PM

Jdforrester-WMF moved this task from Needs QA to Ready to deploy on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.May 14 2024, 3:48 PM

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.May 21 2024, 6:48 PM

Jdforrester-WMF closed this task as Resolved.May 21 2024, 7:16 PM