Page MenuHomePhabricator

Unit tests: Add tests to all the ignored base components that are planned to stay
Open, LowPublic

Description

Description

Our components from the "base" folder were sometimes temporary, so we have jest.config.js configured to ignore them for our coverage calculation.
However, many of these components are gonna stay, so we should remove their paths from the ignore, and add unit tests.

Legend:

  • 🆗 Leave untouched
  • ❌ Remove from ignore: no tests needed
  • ✅ Remove from ignore and write test!!

The components currently appearing in the ignore list:

  • 🆗 Chip.vue: ignore, will be removed in the future
  • 🆗 ChipContainer.vue: ignore, will be removed in the future
  • ✅ CodeEditor.vue: remove from ignore and add tests
  • Dialog.vue: remove from ignore, component doesn't exist
  • DialogContainer.vue: remove from ignore, component doesn't exist
  • ✅ ExpandedToggle.vue: remove from ignore and add tests (patch)
  • LeaveEditorDialog.vue: remove from ignore, component doesn't exist
  • ✅ LocalizedLabel.vue: remove from ignore and add tests (patch)
  • ✅ Pagination.vue: remove from ignore and add tests
  • PublishDialog.vue: remove from ignore, component isn't there anymore
  • Select.vue:
  • 🆗 Table.vue: ignore, will be removed in the future
  • Text.vue: remove from ignore and remove component!!
  • 🆗 Tooltip.vue: ignore, will likely be removed in the future

Completion checklist

Event Timeline

Change #1014702 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Remove mentions of deprecated components

https://gerrit.wikimedia.org/r/1014702

ecarg subscribed.

The checklist/task will be tackled in separate patches

Change #1014702 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove mentions of deprecated components

https://gerrit.wikimedia.org/r/1014702

Change #1016913 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Add test for LocalizedLabel component

https://gerrit.wikimedia.org/r/1016913

Change #1017335 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

https://gerrit.wikimedia.org/r/1017335

Change #1017336 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

https://gerrit.wikimedia.org/r/1017336

Change #1017336 abandoned by Ecarg:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

Reason:

dupe

https://gerrit.wikimedia.org/r/1017336

Change #1017336 restored by Ecarg:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

https://gerrit.wikimedia.org/r/1017336

Change #1017335 abandoned by Ecarg:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

Reason:

dupe

https://gerrit.wikimedia.org/r/1017335

Change #1017335 restored by Ecarg:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

https://gerrit.wikimedia.org/r/1017335

Change #1017336 abandoned by Ecarg:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

Reason:

dupe

https://gerrit.wikimedia.org/r/1017336

Change #1016913 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add test for LocalizedLabel component

https://gerrit.wikimedia.org/r/1016913

Change #1019117 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Add test for Pagination component

https://gerrit.wikimedia.org/r/1019117

Change #1017335 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

https://gerrit.wikimedia.org/r/1017335

Change #1019117 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add test for Pagination component

https://gerrit.wikimedia.org/r/1019117

Change #1019693 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fixit: Remove Text.vue component (not used)

https://gerrit.wikimedia.org/r/1019693

Change #1019693 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fixit: Remove Text.vue component (not used)

https://gerrit.wikimedia.org/r/1019693

Change #1028862 had a related patch set uploaded (by Ecarg; author: jenkins-bot):

[mediawiki/extensions/WikiLambda@master] Add test coverage for the CodeEditor component

https://gerrit.wikimedia.org/r/1028862