Page MenuHomePhabricator

Edit button of old revision links to wrong location
Closed, ResolvedPublicBUG REPORT

Event Timeline

Jdforrester-WMF changed the subtype of this task from "Task" to "Bug Report".
Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF edited projects, added WikiLambda Front-end; removed WikiLambda.

Hi @Jdforrester-WMF! I am not able to reproduce this in my local environment atm.

  1. I made some revisions to a created function w/ implementations
  2. Clicked on the revision history to view a single page of an old revision (w/ 'oldid')
  3. Clicked on 'edit' and the function and persistent obj fields have not changed

Is there a step I missed here?

Hi @Jdforrester-WMF! I am not able to reproduce this in my local environment atm.

  1. I made some revisions to a created function w/ implementations
  2. Clicked on the revision history to view a single page of an old revision (w/ 'oldid')
  3. Clicked on 'edit' and the function and persistent obj fields have not changed

Is there a step I missed here?

The bug here is that the construction of the edit link is incorrect; it should be linking to the edit link with the oldid in it, but it does not. Do you not get that behaviour?

(Re-tagged; this is not a front-end/Vue code issue, it's in the PHP.)

Change 1011219 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Correct edit link of an old revision

https://gerrit.wikimedia.org/r/1011219

Change 1011219 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Correct the edit link of an old revision

https://gerrit.wikimedia.org/r/1011219