Page MenuHomePhabricator

Make ZMonolingualString's hard-coded English placeholder label for "Enter text" proper i18n
Closed, ResolvedPublicBUG REPORT

Description

Open Z102 in English. In the "Try this function" panel, look at labels -> text -> Item 1. The "Enter text" placeholder there is untranslatable.

If I look at the same page in Hebrew, I still see "Enter text".

I might be wrong, but I suspect that this is hard-coded in resources/ext.wikilambda.edit/components/default-view-types/ZMonolingualString.vue:

<cdx-info-chip
        ref="chipComponent"
        class="ext-wikilambda-lang-chip"
        :class="{ 'ext-wikilambda-lang-chip__empty': hasEmptyLang }"
>
        {{ langIso.toUpperCase() }}
</cdx-info-chip>
<cdx-text-input
        v-model="text"
        placeholder="Enter text"
>
</cdx-text-input>

Event Timeline

Jdforrester-WMF renamed this task from In Wikifunctions, the "Enter text" placeholder in the "Try this function" function is untranslatable to Make ZMonolingualString's hard-coded English placeholder label for "Enter text" proper i18n.Mar 12 2024, 8:52 PM
Mcastro moved this task from To Triage to Backlog on the Abstract Wikipedia team board.

To clarify, the acceptance criteria is to see "Enter Text" in the respective user language and not in English for every language?

  • Do we expect to have translation for every language or can we have a fallback language with a chip?

To clarify, the acceptance criteria is to see "Enter Text" in the respective user language and not in English for every language?

Yes.

  • Do we expect to have translation for every language or can we have a fallback language with a chip?

Eventually most languages will have it, but from our end we'll just add the en/English (and qqq/documentation) values and let the community translate.

Change #1036732 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Make ZMonolingualString's hard-coded English placeholder a i18n label

https://gerrit.wikimedia.org/r/1036732

ecarg changed the task status from Open to In Progress.May 28 2024, 6:54 PM

Change #1036732 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Make ZMonolingualString's hard-coded English placeholder a i18n label

https://gerrit.wikimedia.org/r/1036732

Change #1038864 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add wikilambda-edit-monolingual-text-placeholder message to extension.json

https://gerrit.wikimedia.org/r/1038864

Change #1038864 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add wikilambda-edit-monolingual-text-placeholder message to extension.json

https://gerrit.wikimedia.org/r/1038864

Change #1038828 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.43.0-wmf.8] Add wikilambda-edit-monolingual-text-placeholder message to extension.json

https://gerrit.wikimedia.org/r/1038828

Change #1038828 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.43.0-wmf.8] Add wikilambda-edit-monolingual-text-placeholder message to extension.json

https://gerrit.wikimedia.org/r/1038828

Mentioned in SAL (#wikimedia-operations) [2024-06-06T14:56:11Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:1038828|Add wikilambda-edit-monolingual-text-placeholder message to extension.json (T359782)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-06T14:58:38Z] <jforrester@deploy1002> jforrester: Backport for [[gerrit:1038828|Add wikilambda-edit-monolingual-text-placeholder message to extension.json (T359782)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-06T15:08:16Z] <jforrester@deploy1002> Finished scap: Backport for [[gerrit:1038828|Add wikilambda-edit-monolingual-text-placeholder message to extension.json (T359782)]] (duration: 12m 05s)