Description
Currently, the idiom with these functions is to do something like
theEnvelope = setMetadataValue( theEnvelope, key, value );
The assignment shouldn't be necessary. In most cases, it currently isn't, but we should remove all of these reassignments from code and ensure that objects are always being mutated in-place. For setZMapValue, this will sometimes not be possible, but it should ALWAYS be possible for setMetadataValue.
Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)
- setMetadataValue no longer needs to return anything
- setZMapValue maybe doesn't need to return anything? But probably does
- callers of functions so modified are updated accordingly
Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task
Completion checklist
- Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist