Page MenuHomePhabricator
Create Task
Maniphest T327412

Re-enable skipped tests in mswOrchestrateTest once type comparison's guarantees are stricter
Closed, ResolvedPublic
Actions

Description

Description

Several tests (marked with this task's ID) have been disabled in mswOrchestrateTest.js. This is because the first phase of the shift from validation to type comparison has loosened our type-checking guarantees. This loosening was planned [1] and will be temporary.

https://docs.google.com/document/d/117-heKYSIPIUB6ZTOdb4euehKvL1u21rkLfQ8Wob2s4/edit?usp=sharing

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • type comparison logic will become stricter about generic types AND/OR
  • all top-level generic types will be resolved to Z4s before type comparison takes place

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2026-03-04-220825 to 2026-03-10-224034operations/deployment-chartsmaster+1 -1
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
tests: Un-skip old skipped Type comparison tests that now passrepos/abstract-wiki/wikifunctions/function-orchestrator!585jforresterunskippadidoodahmain
Customize query in GitLab

Related Objects
Search...

Event Timeline

cmassaro created this task.Jan 19 2023, 3:43 PM
DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Jan 24 2023, 7:38 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready: G2. Correct & efficient on the Abstract Wikipedia team (Phase θ – Throttling) board.Jan 24 2023, 7:40 PM
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.Jan 26 2023, 5:31 PM
Jdforrester-WMF moved this task from Phase θ – Throttling to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jan 26 2023, 5:34 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase θ – Throttling).
Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 12:40 AM
cmassaro added a parent task: T358589: Raise a type error if resulting value is incompatible with argument type.Apr 10 2024, 4:32 PM
Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.Apr 11 2024, 4:55 PM
cmassaro added a comment.May 28 2024, 6:22 PM

These tests are still failing. As far as I can tell, the "bad user-defined type" test in mswOrchestrateTest is redundant with "generic type validation error: bad list" in mockedServicesOrchestrateTest/genericsTest.js

Jdforrester-WMF moved this task from Backlog to Engineering Backlog on the Abstract Wikipedia team board.Nov 20 2024, 5:52 PM
CodeReviewBot added a project: Patch-For-Review.Mar 9 2026, 8:10 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/585

tests: Un-skip old skipped Type comparison tests that now pass

CodeReviewBot added a comment.Mar 10 2026, 4:38 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/585

tests: Un-skip old skipped Type comparison tests that now pass

Jdforrester-WMF closed this task as Resolved.Mar 10 2026, 4:45 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (26Q3 (Jan–Mar)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Needs Sign-off on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.
Jdforrester-WMF added a project: Essential-Work.

They work now. Somehow.

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2026, 5:34 PM
gerritbot added a comment.Mar 11 2026, 1:58 PM

Change #1250595 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-03-04-220825 to 2026-03-10-224034

https://gerrit.wikimedia.org/r/1250595

gerritbot added a project: Patch-For-Review.Mar 11 2026, 1:58 PM
gerritbot added a comment.Mar 11 2026, 2:09 PM

Change #1250595 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-03-04-220825 to 2026-03-10-224034

https://gerrit.wikimedia.org/r/1250595

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2026, 2:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits