| DVrandecic | |
| Mar 6 2024, 1:14 AM |
| F42441584: IMG_0885.png | |
| Mar 7 2024, 11:52 AM |
Steps to replicate the issue (include links if applicable):
What happens?:
Result comes back empty. Test fails with time out.
What should have happened instead?:
Ideally should work (cannot avoid time outs in some cases, sure).
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
Reported by GrounderUK via Telegram
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Update function-schemata sub-module to HEAD (50415ed) | repos/abstract-wiki/wikifunctions/function-orchestrator!189 | apine | sync-function-schemata | main | |
| Update function-schemata sub-module to HEAD (50415ed) | repos/abstract-wiki/wikifunctions/function-evaluator!225 | apine | sync-function-schemata | main | |
| Resolve list types in order to get type converters for list elements. | repos/abstract-wiki/wikifunctions/function-orchestrator!188 | apine | apine-list-type-conversion | main | |
| Support type converters for the elements of typed lists. | repos/abstract-wiki/wikifunctions/function-evaluator!224 | apine | apine-list-of-type-converters | main | |
| Add Avro binary format v0.1.1: support type converters of list types. | repos/abstract-wiki/wikifunctions/function-schemata!122 | apine | apine-community-defined-list | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | BUG REPORT | None | T360247 Natural numbers in an untyped list are not equal to the same natural number not in a list. | ||
| Open | BUG REPORT | None | T366037 lists of months not behaving as expected | ||
| Open | BUG REPORT | None | T365786 serialising lists of months from code | ||
| Open | BUG REPORT | None | T366403 A quoted reference is not handled correctly in the Wikifunctions interface | ||
| Resolved | BUG REPORT | cmassaro | T359233 Support typed list of types with type converters |
See also T359500. Untyped lists are converted to Typed list with Type Natural number.
Currently, this depends on re-entrancy. I wonder if that is a strict dependency: since typed list are handled in the orchestrator bespoke, could we also just call the converters in a bespoke way from the orchestrator for the individual values?
This doesn't necessarily depend on re-entrancy.
When we resolve the arguments and return type of a function call, before delegating to the evaluator, we can retrieve type converters for all participating types (including the types of members of other types).
Our type key logic is probably good enough to handle issues like recursively-defined types (typed lists are the obvious example here).
This does mean that we'll have to replicate the type key creation logic in every supported programming language. That is still probably better than depending on re-entrancy, which would make things prohibitively slow.
Also affects Gregorian calendar month, of course. Please see https://www.wikifunctions.org/view/en/Z16555
apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/122
Add Avro binary format v0.1.1: support type converters of list types.
apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/224
Draft: Support type converters for the elements of typed lists.
apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/188
Draft: Resolve list types in order to get type converters for list elements.
ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/122
Add Avro binary format v0.1.1: support type converters of list types.
Change #1041657 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (50415ed)
jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/224
Support type converters for the elements of typed lists.
Change #1041657 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (50415ed)
apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/188
Resolve list types in order to get type converters for list elements.
Change #1042268 had a related patch set uploaded (by Jforrester; author: Jforrester):
[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-05-31-163732 to 2024-06-11-161031
Change #1042269 had a related patch set uploaded (by Jforrester; author: Jforrester):
[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-06-05-003919 to 2024-06-11-223956
Change #1042268 merged by jenkins-bot:
[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-05-31-163732 to 2024-06-11-161031
Change #1042269 merged by jenkins-bot:
[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-06-05-003919 to 2024-06-11-223956