ModeSelector.vue currently manually combines a CdxButton and a CdxMenu. We should migrate to use a CdxMenuButton https://doc.wikimedia.org/codex/latest/components/demos/menu-button.html. This should help with overflow/screen-side issues, as well as reduce bespoke code at our end.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | DSmit-WMF | T366615 Migrate ModeSelector to use Codex's MenuButton, now it exists | |||
| Resolved | lwatson | T365748 MenuButton: Publish the MenuButton component (take it out of WIP) | |||
| Resolved | lwatson | T366538 MenuButton: make the API consistent internally and with other Codex components |
Event Timeline
Comment Actions
once we pick this ticket we should also test if the codex button solve the current issue with overflowing menus on smaller viewports
Comment Actions
Change #1053701 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):
[mediawiki/extensions/WikiLambda@master] ModeSelector.vue: Migrate ModeSelector to use Codex's MenuButton, now it exists
Comment Actions
once we pick this ticket we should also test if the codex button solve the current issue with overflowing menus on smaller viewports
It does!
Comment Actions
once we pick this ticket we should also test if the codex button solve the current issue with overflowing menus on smaller viewports
It does!
\o/
Comment Actions
Change #1053701 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] ModeSelector.vue: Migrate ModeSelector to use Codex's MenuButton, now it exists