MinervaNeue night-mode should not have white drop-shadows
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdrewniak
	May 7 2024, 7:17 PM

Description

Steps to reproduce

With dark-mode enabled:

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Polar_bear
Open left menu
Open notificitation menu
Click on citation
Open 'more' menu or user menu

Expected results

Drop shadows should remain dark

Actual results

Drop-shadows are white


main menu	citations	notification menu	more menu

Check any additional observations

Observed on the beta cluster wiki
Observed on a production wiki
Observed on MinervaNeue skin
Observed while logged in
Observed while not logged in (anonymous)

QA Results - PROD

AC	Status	Details
1	✅	T364425#9885866
2	❌	T364425#9885866 per T364425#9886126 ✅
3	✅	T364425#9885866
4	✅	T364425#9885866

Details

Subject	Repo	Branch	Lines +/-
Improve Minerva drop-shadows in dark-mode	mediawiki/skins/MinervaNeue	master	+4 -3
fix(minerva): Fix notification & menu shadows in night mode	mediawiki/skins/MinervaNeue	master	+2 -2
feature(codex): Update application.json box-shadow colour tokens	mediawiki/core	master	+1 -0
fix(minerva): Fix notification & menu shadows in night mode	mediawiki/skins/MinervaNeue	master	+7 -2

Customize query in gerrit

Related Objects

Mentioned In: T366331: Verify 1.43.0-wmf.8 deployment
T365428: White shadow background on dark theme page previews
Mentioned Here: T365428: White shadow background on dark theme page previews

Event Timeline

Jdrewniak created this task.May 7 2024, 7:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2024, 7:17 PM

ovasileva triaged this task as High priority.May 9 2024, 10:42 AM

ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 4); removed Web-Team-Backlog.

ovasileva set the point value for this task to 1.May 20 2024, 5:55 PM

ovasileva moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.

Is T365428 in scope for this one?

Jdlrobson mentioned this in T365428: White shadow background on dark theme page previews.May 21 2024, 3:30 PM

Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.May 21 2024, 5:25 PM

• Mabualruz claimed this task.May 22 2024, 1:34 PM

• Mabualruz moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.

Change #1034926 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/MinervaNeue@master] feature(minerva): Remove white drop-shadows in night mode

https://gerrit.wikimedia.org/r/1034926

gerritbot added a project: Patch-For-Review.May 22 2024, 2:24 PM

• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 22 2024, 2:25 PM

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 22 2024, 6:49 PM

Change #1034935 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] feature(codex): Update application.json box-shadow colour tokens

https://gerrit.wikimedia.org/r/1034935

Change #1034936 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/MinervaNeue@master] fix(minerva): Fix notification & menu shadows in night mode

https://gerrit.wikimedia.org/r/1034936

Change #1034936 abandoned by Mabualruz:

[mediawiki/skins/MinervaNeue@master] fix(minerva): Fix notification & menu shadows in night mode

Reason:

https://gerrit.wikimedia.org/r/1034936

• Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 23 2024, 1:18 PM

@JScherer-WMF we need some input on this one. THe box shadow looks incorrect on day mode as well, do you know what design token we should be using for the main menu box shadow?
https://en.m.wikipedia.beta.wmflabs.org/wiki/Polar_bear?minervanightmode=0

Screenshot 2024-05-23 at 9.38.47 AM.png (473×860 px, 91 KB)

In T364425#9826659, @Jdlrobson wrote:

@JScherer-WMF we need some input on this one. THe box shadow looks incorrect on day mode as well, do you know what design token we should be using for the main menu box shadow?
https://en.m.wikipedia.beta.wmflabs.org/wiki/Polar_bear?minervanightmode=0

I requested that DST put a token in Codex that remains dark in both modes. Depending on how long that takes, we might need to hardcode a value and refactor after they create the token.

In T364425#9826659, @Jdlrobson wrote:

@JScherer-WMF we need some input on this one. THe box shadow looks incorrect on day mode as well, do you know what design token we should be using for the main menu box shadow?
https://en.m.wikipedia.beta.wmflabs.org/wiki/Polar_bear?minervanightmode=0

box-shadow-drop-medium as spec'd in codex.

Change #1034935 abandoned by Jdlrobson:

[mediawiki/core@master] feature(codex): Update application.json box-shadow colour tokens

Reason:

Doesn't seem like we need this given Justin's latest comment.

https://gerrit.wikimedia.org/r/1034935

JScherer-WMF moved this task from Design Review to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 24 2024, 8:23 PM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/eba38a9584/w

^ Okay @JScherer-WMF I merged the patch as spec'ed (we were still doing code review so I moved back from sign off).
Could you take a look at the end result and move this to the QA column (or sign off if you don't think it will benefit from additional QA) if it looks good to you?

Jdlrobson moved this task from Ready for Signoff to Design Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 24 2024, 8:37 PM

In T364425#9831364, @Jdlrobson wrote:

^ Okay @JScherer-WMF I merged the patch as spec'ed (we were still doing code review so I moved back from sign off).
Could you take a look at the end result and move this to the QA column (or sign off if you don't think it will benefit from additional QA) if it looks good to you?

Inspected the box shadow on the main menu and it matches the codex spec, so I don't think there's any need for more QA. Moving to sign off.

Change #1034926 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] fix(minerva): Fix notification & menu shadows in night mode

https://gerrit.wikimedia.org/r/1034926

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).May 28 2024, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 28 2024, 2:30 PM

Jdlrobson removed JScherer-WMF as the assignee of this task.May 28 2024, 5:23 PM

Jdlrobson closed this task as Resolved.Fri, May 31, 1:17 AM

Jdlrobson claimed this task.

Edtadros mentioned this in T366331: Verify 1.43.0-wmf.8 deployment.Mon, Jun 10, 9:20 PM

Change #1041775 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/MinervaNeue@master] Improve Minerva drop-shadows in dark-mode

https://gerrit.wikimedia.org/r/1041775

gerritbot added a project: Patch-For-Review.Tue, Jun 11, 8:51 PM

Change #1041775 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Improve Minerva drop-shadows in dark-mode

https://gerrit.wikimedia.org/r/1041775

Maintenance_bot removed a project: Patch-For-Review.Wed, Jun 12, 4:44 PM

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.10; 2024-06-18); removed MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).Wed, Jun 12, 5:07 PM

@Jdlrobson @Edtadros AC2 failed in PROD for citations since the drop shadows are white.

Test Result - PROD

Status: ❌ AC2
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 125
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Redirect Arrow is Visible in Dark Mode

Go to https://en.m.wikipedia.org/wiki/Polar_bear?minervanightmode=1 in Darkmode.
Verify that Main Menu does not have Drop-shadows that are white
✅AC1: Main Menu

2024-06-11_15-06-40.png (768×2 px, 344 KB)

Go to https://en.m.wikipedia.org/wiki/Polar_bear?minervanightmode=1 in Darkmode.
Verify that Citations does not have Drop-shadows that are white
❌AC2: Citations

2024-06-11_15-06-52.png (1×2 px, 578 KB)

Go to https://en.m.wikipedia.beta.wmflabs.org/wiki/Polar_bear in Darkmode.
Verify that Notifications Menu does not have Drop-shadows that are white
✅AC3: Notifications Menu

2024-06-11_15-07-16.png (803×1 px, 111 KB)

Go to https://en.m.wikipedia.beta.wmflabs.org/wiki/Polar_bear in Darkmode.
Verify that More Menu does not have Drop-shadows that are white
✅AC4: More Menu

2024-06-11_15-07-26.png (689×2 px, 249 KB)

GMikesell-WMF updated the task description. (Show Details)Wed, Jun 12, 5:25 PM

❌AC2: Citations

Thanks! This was just fixed as part of a patch merged today (T364425#9885774) so we should repeat QA on this when verifying 1.43.0-wmf.10

GMikesell-WMF updated the task description. (Show Details)Wed, Jun 12, 8:06 PM

GMikesell-WMF added a project: Verified.Wed, Jun 12, 10:45 PM

	F54242973: Screenshot 2024-05-23 at 9.38.47 AM.png
	May 23 2024, 4:39 PM

	F50768109: Screenshot 2024-05-07 at 3.09.29 PM.png
	May 7 2024, 7:17 PM

	F50768037: Screenshot 2024-05-07 at 3.07.48 PM.png
	May 7 2024, 7:17 PM

	F50768000: Screenshot 2024-05-07 at 3.07.35 PM.png
	May 7 2024, 7:17 PM

MinervaNeue night-mode should not have white drop-shadowsClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions

Description

Steps to reproduce

Expected results

Actual results

Check any additional observations

QA Results - PROD

Details

Related Objects

Event Timeline

Test Result - PROD

Test Steps

MinervaNeue night-mode should not have white drop-shadows
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions