Hi @Jdlrobson, in terms of Fundraising banners we're certainly thinking about our design choices for night mode, and will be testing different approaches. We won't need to make final decisions for a while though since we only show to logged out users.

Community banners might be more of a concern due to often showing to logged in users, and the sheer variety of banners. The CentralNotice Community of Practice group is meeting on Monday, so I'll bring it up there. But I think setting a default dark text color on .banner-container might be a good stop gap.

@Pcoombe I think if we set dark color, it would make sense to do this in CentralNotice so you can easily change this in future.

@Pcoombe and I just met, we agreed the immediate solution would be for the Web team to apply the .notheme class and a default text color to the #siteNotice element. We chose to do this instead of modifying CentralNotice because #siteNotice can contain many types of content, i.e. the example in the description from korean wiki has its own custom #siteNoticeLocal element that needs to be handled.

Before we deploy night mode to logged out users, the Fundraising team can update fundraising banners to work with night mode. At that point, we can consider removing the .notheme class from #siteNotice. However, there still might be some edge cases that pop up when we do that.

Okay sounds good. If we did want to run a banner in the night theme I guess the banner itself could remove the class?
We'd need to add the class to both Vector and Minerva skins. Alternatively perhaps Skin::getSiteNotice could contain this logic..?

done! https://phabricator.wikimedia.org/T361966