Page MenuHomePhabricator

Pcoombe (Peter Coombe)
WMF Fundraising Production Manager

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 25 2014, 1:51 PM (243 w, 3 d)
Availability
Available
IRC Nick
pcoombe
LDAP User
Pcoombe
MediaWiki User
Pcoombe (WMF) [ Global Accounts ]

Recent Activity

Mon, Jun 24

Pcoombe added a comment to T169795: Labels for payments form fields.

@DStrine This is probably something we would want to A/B test as well if possible. Trilogy have made a mockup for us, although there are questions over how it should behave on mobile.

Mon, Jun 24, 7:46 PM · Fundraising-Backlog, Accessibility, MediaWiki-extensions-DonationInterface, Wikimedia-Fundraising
Pcoombe added a comment to T224929: Not required to choose card type in new Ingenico iframe?.

This is a major change, I'm pretty sure it should be an A/B test first if possible.

Mon, Jun 24, 7:38 PM · FR-Ingenico, Fundraising-Backlog
Pcoombe added a comment to T226327: wikipedia pages show garbage formatting when viewed by Blackberry QNX OS10 mobile devices.

https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=903239091#Weird_text_overlap_issue has screenshots and looks like it could be related, that's on a very old version of Chrome (38)

Mon, Jun 24, 1:49 PM

Thu, Jun 13

Pcoombe created T225743: Navigating through desktop large form with keyboard can break it.
Thu, Jun 13, 6:21 PM · Wikimedia-Fundraising-Banners

Mon, Jun 10

Pcoombe added a comment to T225387: Closing image in MultimediaViewer does not revert <title> back to article title.

It looks like this is actually a bug in Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=971932

Mon, Jun 10, 1:05 PM · Patch-For-Review, Browser-Support-Google-Chrome, Multimedia, MediaViewer

Wed, Jun 5

Pcoombe added a comment to T152829: Make the log also include the prior page name when moving a page.

The logging table stores the page ID which would be one way to do this. Unfortunately it looks like this is only correct for moves since Sep 2014. https://www.mediawiki.org/wiki/Manual:Logging_table#log_page

Wed, Jun 5, 7:34 PM · MediaWiki-Logging

Fri, May 31

Pcoombe updated subscribers of T224737: [Bug] Animated banner changes layout on update.
Fri, May 31, 3:38 PM · MediaWiki-extensions-CentralNotice, Readers-Web-Backlog
Pcoombe closed T218730: Make 'emailExplain' variant default behavior as Resolved.

Thanks @Ejegg! I tested this and it looks good, so have removed the code adding variant=emailExplain from banners (diff) and donatewiki (diff). Great point that this will free us up to test other variants too, I hadn't thought of that.

Fri, May 31, 3:35 PM · Fundraising Sprint King Kong vs. Mozilla, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Fundraising-Backlog, MediaWiki-extensions-DonationInterface

Thu, May 30

Pcoombe merged T224668: username suggestion window is opened unintentionally into T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load.
Thu, May 30, 2:36 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression
Pcoombe merged task T224668: username suggestion window is opened unintentionally into T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load.
Thu, May 30, 2:36 PM · MediaWiki-Special-pages
Pcoombe added a comment to T219401: Opt-in numbers in IBM not as expected.

Just to clarify, the optIn0 / optIn1 is only added to the utm_source for banners, not for donors coming from donatewiki (i.e. emails)

Thu, May 30, 1:49 PM · Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Hansel and grep -l, Fundraising-Backlog

May 21 2019

Pcoombe added a comment to T201415: Clean up parameters passed from donatewiki forms.

Note that doing this properly means decoupling the parameters sent from the form inputs, as we did for banners.

May 21 2019, 7:06 PM · donate.wikimedia.org
Pcoombe added a comment to T185327: Add "pay the fee" option to donate.wikimedia.org.

I've used a similar approach to the opt-in feature, so add the parameter showPTF=Default to test it. Like our banners it shows up after selecting an amount.

May 21 2019, 6:55 PM · donate.wikimedia.org
Pcoombe closed T216150: New message inclusion syntax strips <span> with more than one class as Resolved.

Looks good, thanks Andy!

May 21 2019, 2:36 PM · Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Greps of Wrath, Fundraising Sprint Fistful of $variables, Fundraising Sprint Ewoks Take Manhattan, Patch-For-Review, Fundraising Sprint Da Vinci Coder, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

May 13 2019

Pcoombe closed T87669: Look at using Lua for donatewiki as Resolved.

I've rewritten a few of the trickier templates to use Lua now. It does make the code much clearer, will probably do some more later.

May 13 2019, 1:07 PM · donate.wikimedia.org, Fundraising-Backlog, Fundraising-Backlog-Old
Pcoombe closed T222091: Create donate wiki form for endowment as Resolved.

Breaking that down:
addStyle=endowment - switches the WMF logo to the endowment one, and hides unsupported payment methods like Amazon
appeal=JimmyQuote - uses the "Imagine a world..." appeal content
utm_medium=endowment - important so that it goes to the endowment payment forms
utm_campaign and utm_source - set these to whatever you like for tracking

May 13 2019, 1:04 PM · donate.wikimedia.org, Fundraising-Backlog

May 10 2019

Pcoombe added a comment to T222977: Please remove "Provincia Pagos" from Argentina cash options.

@DStrine No it can't. It's on the payments page, see the link.

May 10 2019, 10:11 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Fundraising Sprint It Came From Out of Scope, Patch-For-Review, FR-dlocal, Fundraising-Backlog
Pcoombe created T222977: Please remove "Provincia Pagos" from Argentina cash options.
May 10 2019, 6:34 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Fundraising Sprint It Came From Out of Scope, Patch-For-Review, FR-dlocal, Fundraising-Backlog
Pcoombe updated subscribers of T222961: RedPagos (cash) form in Uruguay fails to load with a fatal exception.
May 10 2019, 3:53 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Fundraising Sprint It Came From Out of Scope, Patch-For-Review, FR-dlocal, Fundraising-Backlog
Pcoombe created T222961: RedPagos (cash) form in Uruguay fails to load with a fatal exception.
May 10 2019, 3:52 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Fundraising Sprint It Came From Out of Scope, Patch-For-Review, FR-dlocal, Fundraising-Backlog
Pcoombe added a comment to T185326: Display accepted card types on donate.wikimedia.org.

@CCogdill_WMF Yes, Spain is Visa/Mastercard/Amex/JCB so that's good to go. In fact all our main countries are set up, since I just copied the card types over from the banners (see https://donate.wikimedia.org/wiki/MediaWiki:DonationForm.js and search for addCardTypesClass)

May 10 2019, 3:37 PM · donate.wikimedia.org

May 9 2019

Pcoombe closed T222706: Banner impression data not updating on frdev1001 as Resolved.

Looks fixed now, thanks!

May 9 2019, 10:03 AM · fundraising-tech-ops, Fundraising-Backlog

May 7 2019

Pcoombe closed T213948: Update SciPy on frdev1001 as Resolved.

Looks like the version is 0.18.1 now which is fine. Thanks!

May 7 2019, 2:33 PM · fundraising-tech-ops, Fundraising-Backlog
Pcoombe closed T213948: Update SciPy on frdev1001, a subtask of T220452: upgrade frdev1001 to Debian Stretch, as Resolved.
May 7 2019, 2:33 PM · fundraising-tech-ops
Pcoombe added a comment to T116047: Spike: Create an alert for suspicious dips in banner impressions.

I now have a cron job which emails me if there were no entries in pgehres.bannerimpressions in the last hour (which usually means something is broken). Can add fr-tech to that if it's helpful?

May 7 2019, 10:58 AM · Spike, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
Pcoombe created T222706: Banner impression data not updating on frdev1001.
May 7 2019, 10:56 AM · fundraising-tech-ops, Fundraising-Backlog

May 3 2019

Pcoombe added a comment to T213209: Reduce recurring TY emails.

@Ejegg @TSkaff The problem was that new paragraph hadn't been marked for translation after being changed. I've fixed it now, along with the pt-br link. Want to try again?

May 3 2019, 6:07 PM · Fundraising Sprint Men In Slack, Fundraising Sprint Land before Timeouts, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Greps of Wrath, Fundraising Sprint Fistful of $variables, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Da Vinci Coder, Patch-For-Review, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Recurring-Donations, FR-Email, Fundraising-Backlog
Pcoombe added a subtask for T144254: Update instances of Wikimedia Foundation logo: T222467: Google still shows old logo for Wikimedia Foundation.
May 3 2019, 5:09 PM · WMF-Communications, Wikimedia-Site-requests
Pcoombe added a parent task for T222467: Google still shows old logo for Wikimedia Foundation: T144254: Update instances of Wikimedia Foundation logo.
May 3 2019, 5:09 PM · WMF-Communications, SEO
Pcoombe created T222467: Google still shows old logo for Wikimedia Foundation.
May 3 2019, 5:08 PM · WMF-Communications, SEO
Pcoombe added a comment to T176669: TY page in ingenico iframe.

@Ejegg Never mind, I got it working. Being cross-origin apparently stops the framed content from reading top.location.href, but not from setting it! This alternative code seems to work, and I've added it to the Thank You page:

May 3 2019, 3:59 PM · Fr-backlog-cleanup-Q3_2017-18, FR-Ingenico, Fundraising-Backlog
Pcoombe added a comment to T176669: TY page in ingenico iframe.

I tried adding that, but it gets blocked from working because the origin is different (TY page is on donate.wikimedia.org, parent page is on payments.wikimedia.org)

May 3 2019, 10:56 AM · Fr-backlog-cleanup-Q3_2017-18, FR-Ingenico, Fundraising-Backlog
Pcoombe added a comment to T221385: New mobile iFrame errors.

I was using Chrome on Android though. Haven't been able to test iOS.

May 3 2019, 9:11 AM · Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog

May 1 2019

Pcoombe closed T109427: Country names in Ways to Give credit/debit section should be localised as Resolved.

I finally got round to this one! And fixed the PayPal/currency links to be translated as well.

May 1 2019, 7:05 PM · donate.wikimedia.org
Pcoombe closed T222019: Improve appearance of RTL support pages as Resolved.

After:

May 1 2019, 2:10 PM · RTL, donate.wikimedia.org, I18n
Pcoombe moved T222091: Create donate wiki form for endowment from Backlog to Donation forms on the donate.wikimedia.org board.
May 1 2019, 1:51 PM · donate.wikimedia.org, Fundraising-Backlog
Pcoombe moved T222019: Improve appearance of RTL support pages from Backlog to Support pages on the donate.wikimedia.org board.
May 1 2019, 1:51 PM · RTL, donate.wikimedia.org, I18n
Pcoombe moved T222263: Support page footer should be translated into same languages as pages from Backlog to Support pages on the donate.wikimedia.org board.
May 1 2019, 1:51 PM · donate.wikimedia.org
Pcoombe created T222263: Support page footer should be translated into same languages as pages.
May 1 2019, 1:51 PM · donate.wikimedia.org
Pcoombe added a comment to T222019: Improve appearance of RTL support pages.

Need to

  • reverse language selection bar
  • fix contents spacing, and active section highlight
  • make card and paypal sections aligned right
May 1 2019, 11:03 AM · RTL, donate.wikimedia.org, I18n

Apr 30 2019

Pcoombe added a project to T222091: Create donate wiki form for endowment: donate.wikimedia.org.
Apr 30 2019, 11:21 AM · donate.wikimedia.org, Fundraising-Backlog

Apr 27 2019

Pcoombe added a comment to T221885: donate.wiki: fix visible template for recurring link.

Some of them (including English) were already using a shared link stored at
https://donate.wikimedia.org/wiki/Template:Ways_to_Give/monthlyUrl. I've
updated the rest to use this as well.

Apr 27 2019, 5:00 PM · Fundraising-Backlog
Pcoombe created T222019: Improve appearance of RTL support pages.
Apr 27 2019, 4:51 PM · RTL, donate.wikimedia.org, I18n

Apr 26 2019

Pcoombe added a comment to T221885: donate.wiki: fix visible template for recurring link.

@MBeat33 Oh sorry, I didn't realise you were still using links like that. You can replace the form-countryspecific parameter with monthly=true instead

Apr 26 2019, 11:18 AM · Fundraising-Backlog

Apr 19 2019

Pcoombe closed T219519: Investigate using Web Share API for sharing on Thank You page as Resolved.

Added this as a new button for supported browsers: Chrome on Android, and the latest Safari (12.2) on iOS.

Apr 19 2019, 7:15 PM · donate.wikimedia.org

Apr 17 2019

Pcoombe added a comment to T199733: Add es-419 as a supported 'preferred language' in Civi.

@DStrine As I understand it this is blocking us from sending separate es and es-419 thank you emails? I brought it up because @jrobell asked me about progress on that. It's not urgent, but would be nice to get it done soon if possible.

Apr 17 2019, 7:07 PM · Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Wikimedia-Fundraising
Pcoombe added a comment to T199733: Add es-419 as a supported 'preferred language' in Civi.

Okay, I tested this myself setting language=es-419 for a card payment, and my preferred language in Civi shows up as es_GB.

Apr 17 2019, 1:38 PM · Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Wikimedia-Fundraising
Pcoombe updated subscribers of T199682: Localise most important DonationInterface messages to Latin American Spanish.

@Ejegg I assume this still needs the backport mentioned in the commit message? Specifying language=es-419 still gets me a payments form in English - link

Apr 17 2019, 1:14 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Wikimedia-Fundraising
Pcoombe added a comment to T199733: Add es-419 as a supported 'preferred language' in Civi.

Hi @Ejegg @DStrine, just checking what the status of this is?

Apr 17 2019, 12:58 PM · Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Wikimedia-Fundraising

Apr 16 2019

Pcoombe added a project to T220824: revise recurring SE pay-the-fee amount?: Wikimedia-Fundraising-Banners.
Apr 16 2019, 4:07 PM · Wikimedia-Fundraising-Banners, Fundraising-Backlog

Apr 15 2019

Pcoombe added a comment to T218240: Create variants for fancy new opt in pages on payments wiki.

Thank you page -- where can it point?: @Pcoombe can you advise on where this should go?

Apr 15 2019, 4:55 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Greps of Wrath, Patch-For-Review, Fundraising Sprint Fistful of $variables, Fundraising-Backlog
Pcoombe added a comment to T220428: 1-month update for privacy policy .

@DStrine Here's the copy and all the translations. The entire message will be a link to the policy. https://donate.wikimedia.org/wiki/Template:Privacy_Policy_Update_2019

Apr 15 2019, 3:30 PM · Patch-For-Review, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Hansel and grep -l, Fundraising-Backlog

Apr 9 2019

Pcoombe created T220528: Use semantic elements (<a>, <button>).
Apr 9 2019, 4:36 PM · Wikimedia-Fundraising-Banners
Pcoombe closed T215711: POTY banners are causing client side error during banner display on mobile AND desktop as Resolved.
Apr 9 2019, 4:30 PM · MediaWiki-extensions-CentralNotice, Wikimedia-Fundraising-Banners

Apr 1 2019

Pcoombe closed T219662: Add extra tracking data to utm_key on donatewiki as Resolved.
Apr 1 2019, 3:20 PM · donate.wikimedia.org

Mar 29 2019

Pcoombe created T219662: Add extra tracking data to utm_key on donatewiki.
Mar 29 2019, 6:36 PM · donate.wikimedia.org
Pcoombe added a comment to T185326: Display accepted card types on donate.wikimedia.org.

@CCogdill_WMF Did this ever get tested, or is it something you might be able to test soon?

Mar 29 2019, 4:16 PM · donate.wikimedia.org
Pcoombe added a comment to T205122: en6C-specific survey on TY page.

@spatton Is this (ability to target TY page surveys to a specific country) still something we would find useful?

Mar 29 2019, 4:08 PM · donate.wikimedia.org

Mar 28 2019

Pcoombe closed T205701: Try adding inline errors instead of alerts for missing amount/opt-in as Resolved.

This is done on donate.wikimedia.org now as well. See the donationForm.validate method in https://donate.wikimedia.org/wiki/MediaWiki:DonationForm.js

Mar 28 2019, 8:25 PM · Wikimedia-Fundraising-Banners, donate.wikimedia.org
Pcoombe closed T219516: Merge all donation form scripts to central location as Resolved.

Done! The only remaining inline script is in https://donate.wikimedia.org/wiki/Template:Optin/Default since we may still want to test variations of that.

Mar 28 2019, 6:31 PM · donate.wikimedia.org
Pcoombe moved T219517: Donation <form> shouldn't be named "paypalcontribution" from Backlog to Donation forms on the donate.wikimedia.org board.
Mar 28 2019, 4:06 PM · donate.wikimedia.org
Pcoombe added a project to T219517: Donation <form> shouldn't be named "paypalcontribution": donate.wikimedia.org.
Mar 28 2019, 4:06 PM · donate.wikimedia.org
Pcoombe moved T217854: Can't use comma as decimal separator for Other amount in some banners from Backlog to Donation forms on the donate.wikimedia.org board.
Mar 28 2019, 4:06 PM · donate.wikimedia.org, Wikimedia-Fundraising-Banners
Pcoombe moved T219516: Merge all donation form scripts to central location from Backlog to Donation forms on the donate.wikimedia.org board.
Mar 28 2019, 4:06 PM · donate.wikimedia.org
Pcoombe moved T219519: Investigate using Web Share API for sharing on Thank You page from Backlog to Thank you page on the donate.wikimedia.org board.
Mar 28 2019, 4:06 PM · donate.wikimedia.org
Pcoombe created T219519: Investigate using Web Share API for sharing on Thank You page.
Mar 28 2019, 3:36 PM · donate.wikimedia.org
Pcoombe created T219517: Donation <form> shouldn't be named "paypalcontribution".
Mar 28 2019, 3:31 PM · donate.wikimedia.org
Pcoombe created T219516: Merge all donation form scripts to central location.
Mar 28 2019, 3:29 PM · donate.wikimedia.org

Mar 26 2019

spatton awarded T217854: Can't use comma as decimal separator for Other amount in some banners a 100 token.
Mar 26 2019, 8:11 PM · donate.wikimedia.org, Wikimedia-Fundraising-Banners

Mar 25 2019

Pcoombe added a comment to T217854: Can't use comma as decimal separator for Other amount in some banners.

Okay, I've changed desktop small banners and donatewiki to use type="text" with inputmode="decimal" so that a comma can be used as decimal point in any language or browser.

Mar 25 2019, 8:47 PM · donate.wikimedia.org, Wikimedia-Fundraising-Banners

Mar 11 2019

Pcoombe added a comment to T217854: Can't use comma as decimal separator for Other amount in some banners.

Okay, researching a bit more and my own testing found that handling of decimal points in different browsers is all over the place, and sometimes depends on the OS language as well as the page language. https://www.ctrl.blog/entry/html5-input-number-localization

Mar 11 2019, 2:30 PM · donate.wikimedia.org, Wikimedia-Fundraising-Banners

Mar 7 2019

Pcoombe added a project to T217854: Can't use comma as decimal separator for Other amount in some banners: donate.wikimedia.org.

Thanks @spatton. That's annoying, but also helpful as it rules out it being related to the inline validation we added to banners.

Mar 7 2019, 6:19 PM · donate.wikimedia.org, Wikimedia-Fundraising-Banners
Pcoombe claimed T217854: Can't use comma as decimal separator for Other amount in some banners.
Mar 7 2019, 5:58 PM · donate.wikimedia.org, Wikimedia-Fundraising-Banners
Pcoombe created T217854: Can't use comma as decimal separator for Other amount in some banners.
Mar 7 2019, 5:58 PM · donate.wikimedia.org, Wikimedia-Fundraising-Banners

Mar 6 2019

Pcoombe added a comment to T215939: Edits to text on payments page.

Thanks @Ejegg ! We'd be happy to make this default for anyone who opted out, and shorten our URLs by removing the variant parameter :)

Mar 6 2019, 8:32 PM · Fundraising Sprint Ewoks Take Manhattan, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Fundraising Sprint Da Vinci Coder, Patch-For-Review, Fundraising-Backlog

Feb 27 2019

Pcoombe awarded T200517: Emit lint error or category when a page uses duplicate HTML IDs a Like token.
Feb 27 2019, 10:40 AM · Patch-For-Review, MediaWiki-extensions-Linter, MediaWiki-Parser
Pcoombe updated the task description for T217215: Toggle state in WikiEditor toolbar is not obvious.
Feb 27 2019, 12:46 AM · Design, WikiEditor
Pcoombe created T217215: Toggle state in WikiEditor toolbar is not obvious.
Feb 27 2019, 12:28 AM · Design, WikiEditor

Feb 26 2019

Pcoombe closed T216830: "Other" translation can spill out of button when it's long as Resolved.

Should be fixed. These changes allow the "Other" translation to wrap, and vertically center by applying display: table-cell; vertical-align: middle; to the button (among other things).

Feb 26 2019, 1:27 PM · donate.wikimedia.org
Pcoombe moved T210587: Donation leads to missing Thank you/vi page from Backlog to Thank you page on the donate.wikimedia.org board.
Feb 26 2019, 11:42 AM · donate.wikimedia.org
Pcoombe moved T216830: "Other" translation can spill out of button when it's long from Backlog to Donation forms on the donate.wikimedia.org board.
Feb 26 2019, 11:42 AM · donate.wikimedia.org

Feb 25 2019

Pcoombe added a comment to T215939: Edits to text on payments page.

@Ejegg If we have the opt_in parameter in the URL then I think we do want to suppress the question though, as we already asked it (in the banner, or on donatewiki)

Feb 25 2019, 3:25 PM · Fundraising Sprint Ewoks Take Manhattan, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Fundraising Sprint Da Vinci Coder, Patch-For-Review, Fundraising-Backlog
Pcoombe added a comment to T215939: Edits to text on payments page.

@Ejegg That causes the opt-in question to show again though, even if the choice is included in the URL. Compare:

Feb 25 2019, 3:02 PM · Fundraising Sprint Ewoks Take Manhattan, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Fundraising Sprint Da Vinci Coder, Patch-For-Review, Fundraising-Backlog

Feb 22 2019

Pcoombe created T216830: "Other" translation can spill out of button when it's long.
Feb 22 2019, 3:09 PM · donate.wikimedia.org

Feb 21 2019

Pcoombe closed T202430: Stop using tables for form layout on donate.wikimedia.org as Resolved.

Done, it's using flexbox for the main layout now. I also fixed up https://donate.wikimedia.org/wiki/Template:Quote to be more semantic and not a table.

Feb 21 2019, 10:49 PM · donate.wikimedia.org

Feb 18 2019

Pcoombe added a comment to T191417: IE11: dsk lg PTF opens immediately on banner load w/o amount selection.

This is still an issue for IE11, and now it triggers the inline error messages like "Select an amount" too. Happening at least in German, haven't figured out which other languages (but not English)

Feb 18 2019, 4:00 PM · Browser-Support-Internet-Explorer, Wikimedia-Fundraising-Banners

Feb 14 2019

Pcoombe created T216150: New message inclusion syntax strips <span> with more than one class.
Feb 14 2019, 3:16 PM · Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Greps of Wrath, Fundraising Sprint Fistful of $variables, Fundraising Sprint Ewoks Take Manhattan, Patch-For-Review, Fundraising Sprint Da Vinci Coder, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Feb 11 2019

Pcoombe updated subscribers of T215711: POTY banners are causing client side error during banner display on mobile AND desktop.

The issue with RML.js should be fixed, although I don't understand why these banners were including it in the first place as it is only intended for fundraising banners. I also fixed a call to undefined frb.insertInlineBanner() in POTY 2018 R1 New.

Feb 11 2019, 4:15 PM · MediaWiki-extensions-CentralNotice, Wikimedia-Fundraising-Banners

Jan 23 2019

Pcoombe added a comment to T213209: Reduce recurring TY emails.

fr-creative discussed this today, and agreed on the following language for the banner footer

If you make a recurring donation, you will be debited by the Wikimedia Foundation until you notify us to stop. We'll send you an email receipt for each payment, which will include a link to easy cancellation instructions.

Thea will update our banners with this.

Jan 23 2019, 6:23 PM · Fundraising Sprint Men In Slack, Fundraising Sprint Land before Timeouts, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Greps of Wrath, Fundraising Sprint Fistful of $variables, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Da Vinci Coder, Patch-For-Review, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Recurring-Donations, FR-Email, Fundraising-Backlog

Jan 18 2019

Pcoombe added a comment to T213209: Reduce recurring TY emails.

@MBeat33 We don't include the donate@ email in the banner yet, so that could be added. It may cause you to get more unrelated emails though.

Jan 18 2019, 6:34 PM · Fundraising Sprint Men In Slack, Fundraising Sprint Land before Timeouts, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Greps of Wrath, Fundraising Sprint Fistful of $variables, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Da Vinci Coder, Patch-For-Review, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Recurring-Donations, FR-Email, Fundraising-Backlog

Jan 17 2019

Pcoombe updated subscribers of T213209: Reduce recurring TY emails.

Before this happens we'll need to change this footer text which appears in the banners:

If you make a recurring donation, you will be debited by the Wikimedia Foundation until you notify us to stop. We'll send you an email receipt for each payment, which will include a link to easy cancellation instructions.

Jan 17 2019, 9:10 PM · Fundraising Sprint Men In Slack, Fundraising Sprint Land before Timeouts, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Greps of Wrath, Fundraising Sprint Fistful of $variables, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Da Vinci Coder, Patch-For-Review, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint A series of unfortunate event handlers, Recurring-Donations, FR-Email, Fundraising-Backlog
Pcoombe added a comment to T213948: Update SciPy on frdev1001.

Actually looking into it v0.18.0 does fix the main bug which affects us (in the Mann-Whitney statistical test). So that would be great if an update to Stretch is planned soon anyway?

Jan 17 2019, 9:03 PM · fundraising-tech-ops, Fundraising-Backlog

Jan 16 2019

Pcoombe moved T213949: Update fundraising analysis tools to use Python 3 from Triage to Blocked & not fr-tech on the Fundraising-Backlog board.
Jan 16 2019, 5:41 PM · Fundraising-Backlog
Pcoombe triaged T213949: Update fundraising analysis tools to use Python 3 as Low priority.
Jan 16 2019, 5:41 PM · Fundraising-Backlog
Pcoombe created T213948: Update SciPy on frdev1001.
Jan 16 2019, 5:38 PM · fundraising-tech-ops, Fundraising-Backlog

Jan 7 2019

Pcoombe added a project to T212177: Closing donation banner breaks scrolling: Wikimedia-Fundraising-Banners.

Thanks, banner team will look into this one.

Jan 7 2019, 6:09 PM · Wikimedia-Fundraising-Banners, Fundraising-Backlog

Dec 17 2018

Pcoombe closed T211335: Possible to make a recurring Amazon attempt in mobile large banner as Resolved.

This got fixed with the switch to a 2-step form

Dec 17 2018, 9:56 PM · Wikimedia-Fundraising-Banners

Dec 13 2018

Pcoombe closed T211452: Changing Bitpay Logo as Resolved.

Done.

Dec 13 2018, 10:10 PM · Fundraising-Backlog

Dec 11 2018

Pcoombe closed T211332: Mobile banner nag shows up when editing as Resolved.
Dec 11 2018, 8:48 PM · Wikimedia-Fundraising-Banners

Dec 10 2018

Pcoombe added a comment to T211435: Give jsamra access to /srv/br on frdev1001.

@cwdent Changing to the fundraising group sounds good. Jasmeet is working directly for us now, rather than via CPS.

Dec 10 2018, 8:07 PM · Fundraising-Backlog, fundraising-tech-ops