Page MenuHomePhabricator

Pcoombe (Peter Coombe)
User

Today

  • No visible events.

Tomorrow

  • No visible events.

Wednesday

  • No visible events.

User Details

User Since
Oct 25 2014, 1:51 PM (580 w, 1 d)
Availability
Available
IRC Nick
pcoombe
LDAP User
Pcoombe
MediaWiki User
Pcoombe (WMF) [ Global Accounts ]

Recent Activity

Fri, Dec 5

Pcoombe created T411908: Clarify and/or rethink centralnotice device settings.
Fri, Dec 5, 10:03 PM · MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Pcoombe created T411902: Remove inaccessible inputs from Payments wiki when donor is redirected automatically.
Fri, Dec 5, 8:54 PM · MediaWiki-extensions-DonationInterface, Fundraising-Backlog
Pcoombe added a comment to T411901: Save screen height and width in their own contribution tracking fields.

We also have some user agent info in civicrm_contribution_tracking now: os, os_version, browser, browser_version. Not sure how far back it goes

Fri, Dec 5, 8:52 PM · Fundraising-Backlog

Thu, Dec 4

Pcoombe added a project to T411687: Donation form sticky if back button used: Wikimedia-Fundraising-Banners.
Thu, Dec 4, 12:12 PM · Wikimedia-Fundraising-Banners, Fundraising-Backlog, FR-donorrelations
Pcoombe closed T411687: Donation form sticky if back button used as Resolved.

Okay, this should be fixed in banners now: example, change made. It was an issue even before we switched to the monthly convert dialogs, but maybe that made it a bit more obvious.

Thu, Dec 4, 12:12 PM · Wikimedia-Fundraising-Banners, Fundraising-Backlog, FR-donorrelations
Pcoombe claimed T411687: Donation form sticky if back button used.

I have an idea what this is, will look into it

Thu, Dec 4, 9:24 AM · Wikimedia-Fundraising-Banners, Fundraising-Backlog, FR-donorrelations

Wed, Dec 3

Pcoombe added a comment to T411535: [XS] Send app_install_id from Android for Web payments.

Okay, change on donatewiki is done.

Wed, Dec 3, 6:13 PM · Wikipedia-Android-App-Backlog (Android Release - FY2025-26)

Wed, Nov 26

Pcoombe created T411109: Don't show banners on action=submit.
Wed, Nov 26, 4:11 PM · fr-current-sprint, Fundraising Sprint: Xiaolongbao, MW-1.46-notes (1.46.0-wmf.5; 2025-12-02), MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Tue, Nov 25

Pcoombe merged T403098: Minor donation form quirks when using an iPad? into T348809: Page layout is off on donate.wikipedia.org on iPad tablet display.
Tue, Nov 25, 4:55 PM · donate.wikimedia.org
Pcoombe merged task T403098: Minor donation form quirks when using an iPad? into T348809: Page layout is off on donate.wikipedia.org on iPad tablet display.
Tue, Nov 25, 4:55 PM · Fundraising Tech - Chaos Crew, Fundraising-Backlog, FR-donorrelations
Pcoombe added a comment to T410737: Remove Fundraiseup from donatewiki CSP.

Done, thank you!

Tue, Nov 25, 4:12 PM · Fundraising Sprint WWaally hoo, Fundraising-FRUP, Fundraising-Backlog
Pcoombe closed T410945: Minimum AUD donation amount changing mid-flow as Resolved.

Updated currency rates to match those on payments https://donate.wikimedia.org/w/index.php?title=MediaWiki:DonationForm.js&diff=prev&oldid=42148

Tue, Nov 25, 10:41 AM · FR-donorrelations, Fundraising-Backlog

Fri, Nov 21

Pcoombe created T410787: Focus first field in form (not always first_name field).
Fri, Nov 21, 8:26 PM · MW-1.46-notes (1.46.0-wmf.7; 2025-12-16), Fundraising Tech - Chaos Crew, MediaWiki-extensions-DonationInterface, Fundraising-Backlog
Pcoombe created T410770: Add autocapitalize attributes for address inputs.
Fri, Nov 21, 7:03 PM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), Fundraising Sprint WWaally hoo, MediaWiki-extensions-DonationInterface, Fundraising-Backlog
Pcoombe created T410737: Remove Fundraiseup from donatewiki CSP.
Fri, Nov 21, 1:33 PM · Fundraising Sprint WWaally hoo, Fundraising-FRUP, Fundraising-Backlog
Pcoombe closed T261144: Japanese last name, first name ordering issues as Resolved.

Closing this since both suggestions (swapping order of name fields, and adding explanation to last name caption) were implemented on Japan forms: https://payments.wikimedia.org/index.php?title=Special%3AGravyGateway&appeal=JimmyQuote&country=JP&currency=JPY&payment_method=cc&recurring=0&gateway=gravy&uselang=ja&amount=300

Fri, Nov 21, 1:15 PM · FR-Japan, Fundraising-Backlog
Pcoombe created T410734: Gr4vy card input fields have grey background on mobile.
Fri, Nov 21, 1:00 PM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), Fundraising Tech - Chaos Crew, Fundraising-Backlog

Thu, Nov 20

Pcoombe added a comment to T396271: Implement interim "change payment type" flow.

@Pcoombe how hard is it to make donatewiki pass through a couple more parameters like it already does with contact_id and contact_hash? In this case, we would like it to pass checksum and contribution_recur_id to the payments form.

Thu, Nov 20, 3:07 PM · MW-1.46-notes (1.46.0-wmf.7; 2025-12-16), Fundraising Sprint: Xiaolongbao, fr-current-sprint, Fundraising Sprint: Vixen, Fundraising-Backlog, FR-Donor-portal

Nov 6 2025

Pcoombe added a comment to T257862: Provide a donate skin for donate.wikimedia.org.

Jon's change is merged now. From next Tuesday we will be able to test the new skin using ?useskin=donate on production donatewiki, and I can make any required updates to the templates: I have a pretty good idea already of what needs doing.

Nov 6 2025, 4:06 PM · 25 Dec Q3 Planning, MW-1.46-notes (1.46.0-wmf.2; 2025-11-12), Patch-For-Review, Fundraising-Tech-Roadmap, Fundraising-ComboWiki-Dependency, fr-combowiki, Fundraising-Backlog, donate.wikimedia.org

Oct 30 2025

Pcoombe added a comment to T407241: PaymentsWiki W25 design test.

The different color is deliberate, see the Figma file.

Oct 30 2025, 7:46 PM · MW-1.46-notes (1.46.0-wmf.2; 2025-11-12), Fundraising Sprint: UTM_key lime pie, FR-payments-general, Fundraising-Backlog

Oct 21 2025

Pcoombe updated subscribers of T407898: Donation link with country and currency is setting currency based on country.

Previous discussion on this in T381437 and specifically T381437#10906269. Adding @ppenloglou too for info

Oct 21 2025, 7:36 PM · Fundraising Tech - Chaos Crew, Fundraising-Backlog
Pcoombe added a comment to T407898: Donation link with country and currency is setting currency based on country.

https://donate.wikimedia.org/?country=US&hpc=10000&hpcCurrency=JPY gives the expected result for me: ignore the hpc since the currency doesn't match, and just show default USD amounts

Oct 21 2025, 7:33 PM · Fundraising Tech - Chaos Crew, Fundraising-Backlog
Pcoombe created T407856: Add ISO currency code to in-app donation forms.
Oct 21 2025, 1:57 PM · Wikipedia-iOS-App-Backlog, Android Sprint 2025: Simone Biles, Wikipedia-Android-App-Backlog (Android Release - FY2025-26)

Oct 8 2025

Pcoombe closed T406638: Disable mobilefrontend on donatewiki as Resolved.
Oct 8 2025, 2:05 PM · Fundraising-Backlog, donate.wikimedia.org, Wikimedia-Site-requests

Oct 7 2025

Pcoombe added a comment to T406638: Disable mobilefrontend on donatewiki.

Thanks @greg. I can manage the deploy of this since I have time tomorrow and it seems like a good learning opportunity.

Oct 7 2025, 8:26 PM · Fundraising-Backlog, donate.wikimedia.org, Wikimedia-Site-requests
Pcoombe updated subscribers of T406638: Disable mobilefrontend on donatewiki.
Oct 7 2025, 7:26 PM · Fundraising-Backlog, donate.wikimedia.org, Wikimedia-Site-requests
Pcoombe created T406638: Disable mobilefrontend on donatewiki.
Oct 7 2025, 7:12 PM · Fundraising-Backlog, donate.wikimedia.org, Wikimedia-Site-requests

Sep 27 2025

Pcoombe reopened T33595: CentralNotice banners should exist in their own namespace (stop using the MediaWiki namespace), a subtask of T116140: Banner editor should be more consistent with other editing (tracking), as Open.
Sep 27 2025, 10:59 AM · Tracking-Neverending, Fundraising-Backlog, MediaWiki-extensions-CentralNotice
Pcoombe reopened T33595: CentralNotice banners should exist in their own namespace (stop using the MediaWiki namespace) as "Open".

This has not been resolved. Unpublished translations are now in a "CNBanner" namespace e.g. https://meta.wikimedia.org/wiki/CNBanner:FR2025_translations-iad-thank-you/en. But banner content and published translations remain in MediaWiki namespace e.g. https://meta.wikimedia.org/wiki/MediaWiki:Centralnotice-template-WikiConSeoul2025banner

Sep 27 2025, 10:59 AM · FR-CentralNotice-translations, Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Sep 16 2025

Pcoombe closed T96046: Display a flag and/or country name on the donation form, a subtask of T96047: Donors need an option to pay from another country, as Resolved.
Sep 16 2025, 2:10 PM · Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Fundraising
Pcoombe closed T96046: Display a flag and/or country name on the donation form, a subtask of T86942: Provide a country switching form on payments.wmo, as Resolved.
Sep 16 2025, 2:10 PM · Fundraising-Backlog, MediaWiki-extensions-DonationInterface
Pcoombe closed T96046: Display a flag and/or country name on the donation form as Resolved.

We have the country name on both banners and donatewiki now. So I don't think it's needed on payments as well

Sep 16 2025, 2:10 PM · Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Fundraising
Pcoombe added a comment to T122097: Set expiry time for GeoIP cookies.

For fundraising banners we use the country from mw.centralNotice.data.country (which allows us to override it with a country= url parameter for testing).

Sep 16 2025, 2:06 PM · SRE, Traffic, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Sep 15 2025

Pcoombe added a comment to T402929: [Action required] Bulgarian Lev (BGN) currency changeover to Euro (EUR) .

Donation forms in Bulgaria are now disabled https://donate.wikimedia.org/?country=BG, and I made an Asana task to re-enable with Euros in January

Sep 15 2025, 4:13 PM · 25 Dec Q3 Planning, Fundraising-Tech-Roadmap, Fundraising-Backlog

Sep 11 2025

Pcoombe created T404380: Enable post-payment monthly convert for Apple/Google/ACH on Gr4vy.
Sep 11 2025, 4:45 PM · Fundraising Sprint: rich, the, MW-1.45-notes (1.45.0-wmf.20; 2025-09-23), Fundraising Tech - Chaos Crew, Fundraising-Backlog
Pcoombe created T404377: Payment Submethods by Country sections on Special:PaymentSettings are broken.
Sep 11 2025, 4:34 PM · MW-1.46-notes (1.46.0-wmf.3; 2025-11-19), Fundraising Tech - Chaos Crew, MediaWiki-extensions-DonationInterface, Fundraising-Backlog

Sep 10 2025

Pcoombe added a comment to T402929: [Action required] Bulgarian Lev (BGN) currency changeover to Euro (EUR) .

I've added to discuss in standup next week. Providing everyone agrees, it will be easy to change.

Sep 10 2025, 4:54 PM · 25 Dec Q3 Planning, Fundraising-Tech-Roadmap, Fundraising-Backlog

Sep 9 2025

Pcoombe added a comment to T402929: [Action required] Bulgarian Lev (BGN) currency changeover to Euro (EUR) .

Oh wait @RKumar_WMF, are you suggesting we just disable donations from Bulgaria until January? That would suit me fine, and I can't imagine it's a lot of donations. Do we need a wider discussion before doing that?

Sep 9 2025, 11:37 AM · 25 Dec Q3 Planning, Fundraising-Tech-Roadmap, Fundraising-Backlog
Pcoombe added a comment to T402929: [Action required] Bulgarian Lev (BGN) currency changeover to Euro (EUR) .

It looks like we have payments forms for new EUR donations in Bulgaria already https://payments.wikimedia.org/index.php/Special:GravyGateway?currency=EUR&country=BG&payment_method=cc&uselang=en-gb&amount=10&opt_in=1

Sep 9 2025, 11:34 AM · 25 Dec Q3 Planning, Fundraising-Tech-Roadmap, Fundraising-Backlog
Pcoombe closed T292478: Should be a way to pause animated header on wikimediafoundation.org as Resolved.

No longer an issue with the new homepage

Sep 9 2025, 11:10 AM · Accessibility, wikimediafoundation.org

Jul 22 2025

Pcoombe merged T377504: [Timebox] Some icons not shown when activating Windows 11 Contrast theme into T381642: Codex icons are not visible in Windows' high contrast mode.
Jul 22 2025, 9:16 AM · Readers Essential Work 2025, Design-System-Team, Codex, Accessibility
Pcoombe merged task T377504: [Timebox] Some icons not shown when activating Windows 11 Contrast theme into T381642: Codex icons are not visible in Windows' high contrast mode.
Jul 22 2025, 9:15 AM · Design-System-Team

Jul 2 2025

Pcoombe merged task T398499: Central Notice Logs are not showing diff when modified into Restricted Task.
Jul 2 2025, 8:03 PM · MediaWiki-extensions-CentralNotice

Jun 27 2025

Pcoombe added a comment to T397709: Watchlist expiry not set when saving page edit.

Tried a patch demo (https://patchdemo.wmcloud.org/wikis/2e61fc2ecf/) and it doesn't seem to have fixed it

Jun 27 2025, 7:28 PM · MW-1.45-notes (1.45.0-wmf.9; 2025-07-08), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, Regression, VisualEditor, Expiring-Watchlist-Items, Community-Tech

Jun 26 2025

Pcoombe closed T383189: Suppress opt in when contact hash in the url? as Resolved.
Jun 26 2025, 8:40 PM · donate.wikimedia.org, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM
Pcoombe added a comment to T383189: Suppress opt in when contact hash in the url?.

Legal approved this change, and I've (finally) implemented it. Diff of donatewiki javascript

Jun 26 2025, 8:39 PM · donate.wikimedia.org, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM
Pcoombe added a comment to T396355: Gravy Card Payment AVS check triggering false positives. .

I've redirected both donatewiki and banner cards to adyen

Jun 26 2025, 10:56 AM · Fundraising Tech - Chaos Crew, Fundraising-Backlog

Jun 24 2025

Pcoombe attached a referenced file: F62442507: Screenshot 2025-06-24 at 12.09.31.png.
Jun 24 2025, 11:24 AM · MW-1.45-notes (1.45.0-wmf.9; 2025-07-08), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, Regression, VisualEditor, Expiring-Watchlist-Items, Community-Tech
Pcoombe created T397709: Watchlist expiry not set when saving page edit.
Jun 24 2025, 11:19 AM · MW-1.45-notes (1.45.0-wmf.9; 2025-07-08), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, Regression, VisualEditor, Expiring-Watchlist-Items, Community-Tech

Jun 17 2025

Pcoombe created T397199: donate_interface-redirect-explanation shown on dLocal forms but not on gr4vy equivalent.
Jun 17 2025, 2:08 PM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), Fundraising Tech - Chaos Crew, Fundraising-Backlog

Jun 15 2025

Pcoombe created T396967: Hide "Add languages" button from language selector on Main Pages.
Jun 15 2025, 10:07 PM · UniversalLanguageSelector

Jun 11 2025

Pcoombe added a comment to T394007: Mass Card Declines Following Japan Email 1.

Japan cards and Google Pay traffic are now back to gr4vy on both banners and donatewiki. I updated the payments routing summary sheet

Jun 11 2025, 8:28 PM · FR-donorrelations, Fundraising Tech - Chaos Crew, Fundraising-Backlog
Pcoombe added a comment to T381437: Donors included wrongly in email send due to "country"..

Okay, based on a conversation with @ppenloglou earlier we can include the highest previous contribution currency in the email links to donatewiki. I added a check in the javascript, if the hpcCurrency parameter doesn't match the form currency, then it won't make any changes to the amount options.

Jun 11 2025, 6:35 PM · Fundraising Tech - Chaos Crew, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-donorrelations

Jun 5 2025

Pcoombe closed T396101: Error "Fatal Exception of Type "Type Error" when attempting a donation via PayPal as Resolved.

So this was for countries where we offer Paypal, but in USD instead of the local currency e.g. South Africa http://donate.wikimedia.org/?uselang=en&country=ZA. If a local currency amount is selected on donatewiki, it is passed to payments where it is automatically converted to USD. Currently we simply skip any donatewiki validation if the user selects Paypal USD, so if a user doesn't select an amount, we pass amount=null.

Jun 5 2025, 4:13 PM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), Fundraising Tech - Chaos Crew, Fundraising-Backlog

Jun 3 2025

Pcoombe added a comment to T269897: Add "one-time" to header on One-time Payments Wiki.

Seems like it would be a nice improvement, if it's not too tricky. We do also explicitly call out one-time gifts in the thank you receipt.

Jun 3 2025, 7:36 PM · Fundraising-Backlog

May 29 2025

Pcoombe placed T394399: No longer able to preview centralnotice banners up for grabs.
May 29 2025, 3:39 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), Fundraising Tech - Chaos Crew, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Pcoombe closed T394399: No longer able to preview centralnotice banners as Resolved.
May 29 2025, 3:39 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), Fundraising Tech - Chaos Crew, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

May 23 2025

Pcoombe added a comment to T394932: No support of required debit mandate for SEPA.

Just noting that we'll need a version for annual payments too

May 23 2025, 2:51 PM · MW-1.45-notes (1.45.0-wmf.5; 2025-06-10), Fundraising Tech - Chaos Crew, Fundraising-Backlog

May 15 2025

Pcoombe added a comment to T394399: No longer able to preview centralnotice banners.

Marked this UBN because it blocks online fundraising and centralnotice admin work, but it's not affecting end users (they still see correct banners) so I'm not sure it would warrant a rollback

May 15 2025, 11:36 AM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), Fundraising Tech - Chaos Crew, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Pcoombe triaged T394399: No longer able to preview centralnotice banners as Unbreak Now! priority.
May 15 2025, 11:31 AM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), Fundraising Tech - Chaos Crew, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Pcoombe created T394399: No longer able to preview centralnotice banners.
May 15 2025, 11:30 AM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), Fundraising Tech - Chaos Crew, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

May 12 2025

Pcoombe renamed T393834: CentralNotice campaign page lets people without permissions visually modify stuff from CentralNotice UI lets people without permissions visually modify stuff to CentralNotice campaign page lets people without permissions visually modify stuff.
May 12 2025, 9:55 AM · MediaWiki-extensions-CentralNotice

May 7 2025

Pcoombe created T393601: Sidebar donate link targets are always in English.
May 7 2025, 2:10 PM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), Verified, Essential-Work, MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), Community-Tech, WikimediaMessages, I18n, Regression, Web-Team, Fundraising-Backlog, FY2024-25 WE3.2 Donation Entry Points

May 6 2025

Pcoombe added a comment to T392147: Switch Credit Cards from Adyen to Gravy.

We agreed in standup to switch Adyen credit card, Apple Pay, and Google Pay tomorrow (7 May) at 17 UTC. I'll do this by editing donatewiki (since we need to remove the current A/B test anyway) and banner javascript. fr-tech can consider any form chooser changes later

May 6 2025, 5:57 PM · Fundraising Sprint Impossible shepherds pie, Fundraising Sprint: Hot Pot!, payments-orchestration, Fundraising-Backlog

Apr 27 2025

Pcoombe placed T392000: Transactions stuck in "Authorised" status in Adyen - Urgent up for grabs.
Apr 27 2025, 7:03 PM · Fundraising Tech - Chaos Crew, Fundraising-Backlog

Apr 25 2025

Pcoombe added a comment to T391412: Bad UI from payments form when recurring=1 for non recurring methods.

Hi, I think Option 2 with a simple error like "Recurring donations are not supported with this payment method."

Apr 25 2025, 3:55 PM · 25 Dec Q3 Planning, Fundraising-Tech-Roadmap, MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), Fundraising-Backlog

Apr 22 2025

Pcoombe closed T168537: Ability to select from a variety of standardized banner code templates. as Resolved.

Banner templates have existed for a while now :)

Apr 22 2025, 9:25 PM · Wikimedia-CentralNotice-Administration, MediaWiki-extensions-CentralNotice
Pcoombe merged T153230: Avoid the increasing length of Special:CentralNotice into T328424: Move archived CentralNotice campaigns to a separate page.
Apr 22 2025, 9:20 PM · Fundraising-Backlog, Fundraising Tech - Chaos Crew, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-extensions-CentralNotice
Pcoombe merged task T153230: Avoid the increasing length of Special:CentralNotice into T328424: Move archived CentralNotice campaigns to a separate page.
Apr 22 2025, 9:20 PM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice
Pcoombe closed T150265: Unable to delete a banner with bad HTML code as Resolved.

Whatever the issue was, it was fixed at some point. And I was able to delete the banner

Apr 22 2025, 9:19 PM · MediaWiki-extensions-CentralNotice
Pcoombe closed T151480: CentralNotice banner(s) uses deprecated hideBanner as Resolved.

Did some searching and I can't find any banners using hideBanner alone since 2019.

Apr 22 2025, 9:13 PM · Technical-Debt, JavaScript, MediaWiki-extensions-CentralNotice
Pcoombe closed T123314: CentralNotice banner for Wikimania uses deprecated hideBanner, a subtask of T120084: Fundraising scripts should not use global scope, as Resolved.
Apr 22 2025, 9:09 PM · Fundraising-Backlog, Technical-Debt, MediaWiki-extensions-CentralNotice
Pcoombe closed T123314: CentralNotice banner for Wikimania uses deprecated hideBanner as Resolved.
Apr 22 2025, 9:09 PM · Technical-Debt, JavaScript, MediaWiki-extensions-CentralNotice
Pcoombe merged T97381: CentralNotice audit log should reuse core logging into T32009: CentralNotice on [[Special:Log]].
Apr 22 2025, 8:57 PM · MediaWiki-extensions-CentralNotice
Pcoombe merged task T97381: CentralNotice audit log should reuse core logging into T32009: CentralNotice on [[Special:Log]].
Apr 22 2025, 8:56 PM · Fundraising-Backlog, Fundraising-Backlog-Old, MediaWiki-extensions-CentralNotice
Pcoombe closed T70049: CentralNotice should work correctly out of the box as Resolved.

The setup as described at https://www.mediawiki.org/wiki/Extension:CentralNotice#Quick_developer_setup seems to work fine

Apr 22 2025, 8:52 PM · MediaWiki-extensions-CentralNotice

Apr 17 2025

Pcoombe added a comment to T391025: Re-add &wmf_key=minerva to mobile sidebar donate link.

That's great, thanks @SToyofuku-WMF ! The order doesn't actually matter

Apr 17 2025, 8:52 PM · Verified, WikimediaMessages, MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), Patch-For-Review, Web-Team (Q4 Sprint 1 (April 2 - April 23 2025)), Epic, FY2024-25 WE3.2 Donation Entry Points

Apr 10 2025

Pcoombe added a comment to T308262: Investigate keeping testmeister or re-creating it in civi.

Thanks! I don't do so much with TY emails any more, but remember testmeister fondly. Things it would be neat to be able to test in rough order of priority:

  • different languages, countries
  • different frequencies (one-time, monthly, annual)
  • different emails e.g. default Thank You receipt, monthly/recurring convert
  • the "draft" versions of emails
Apr 10 2025, 5:57 PM · Fundraising-Tech-Roadmap, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog

Apr 3 2025

Pcoombe created T391026: "Wikipedia" in new Minerva donate message on non-Wikipedia sites.
Apr 3 2025, 6:30 PM · Verified, Web-Team (Q4 Sprint 1 (April 2 - April 23 2025)), Unplanned-Sprint-Work, MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), WikimediaMessages, FY2024-25 WE3.2 Donation Entry Points
Pcoombe created T391025: Re-add &wmf_key=minerva to mobile sidebar donate link.
Apr 3 2025, 6:16 PM · Verified, WikimediaMessages, MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), Patch-For-Review, Web-Team (Q4 Sprint 1 (April 2 - April 23 2025)), Epic, FY2024-25 WE3.2 Donation Entry Points
Pcoombe added a comment to T390956: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transactions (DBO_TRX set)).

@Reedy I don't have Centralnotice admin rights on testwiki. Tried on https://meta.wikimedia.beta.wmflabs.org/ and got the following

Apr 3 2025, 2:42 PM · MW-1.44-notes (1.44.0-wmf.23; 2025-04-01), Regression, Wikimedia-production-error, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Pcoombe added a comment to T390956: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transactions (DBO_TRX set)).

Timing appears to line up with the train deployment to meta yesterday, which had a couple of CentralNotice related changes https://www.mediawiki.org/wiki/MediaWiki_1.44/wmf.23#CentralNotice

Apr 3 2025, 12:17 PM · MW-1.44-notes (1.44.0-wmf.23; 2025-04-01), Regression, Wikimedia-production-error, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Pcoombe added a comment to T390956: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transactions (DBO_TRX set)).

Confirmed that editing existing banners still works okay

Apr 3 2025, 12:06 PM · MW-1.44-notes (1.44.0-wmf.23; 2025-04-01), Regression, Wikimedia-production-error, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Pcoombe triaged T390956: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transactions (DBO_TRX set)) as Unbreak Now! priority.
Apr 3 2025, 12:05 PM · MW-1.44-notes (1.44.0-wmf.23; 2025-04-01), Regression, Wikimedia-production-error, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Pcoombe created T390956: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transactions (DBO_TRX set)).
Apr 3 2025, 12:05 PM · MW-1.44-notes (1.44.0-wmf.23; 2025-04-01), Regression, Wikimedia-production-error, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Apr 1 2025

Pcoombe closed T389165: Add a Basic Preview Button to Central Notice Banner Template Editor as Invalid.

An additional live preview is not needed.

Apr 1 2025, 4:20 PM · Patch-For-Review, MediaWiki-extensions-CentralNotice

Mar 26 2025

Pcoombe added a project to T390032: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extension\FundraiserLandingPage\Specials\FundraiserLandingPage::execute]: donate.wikimedia.org.

Thanks, looks good to me as well now and I was able to make a donation.

Mar 26 2025, 10:53 AM · MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), Fundraising Tech - Chaos Crew, donate.wikimedia.org, Content-Transform-Team, Fundraising-Backlog, MediaWiki-extensions-FundraiserLandingPage, Wikimedia-production-error
Pcoombe added a comment to T390032: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extension\FundraiserLandingPage\Specials\FundraiserLandingPage::execute].

https://donate.wikimedia.org/ is broken, which is used for all our non-banner fundraising. Can we get a rollback for this please?

Mar 26 2025, 10:23 AM · MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), Fundraising Tech - Chaos Crew, donate.wikimedia.org, Content-Transform-Team, Fundraising-Backlog, MediaWiki-extensions-FundraiserLandingPage, Wikimedia-production-error

Mar 18 2025

Pcoombe added a comment to T389165: Add a Basic Preview Button to Central Notice Banner Template Editor.

I don't understand the request, this already exists in the "Live preview" section. Users can also click the "Preview on wiki" link to show the current banner content on a wiki page

Mar 18 2025, 4:23 PM · Patch-For-Review, MediaWiki-extensions-CentralNotice

Mar 17 2025

Pcoombe added a comment to T375175: [EPIC] Expose donate button on Minerva.

Hi, not sure if there's somewhere better to raise this but I checked the new donate link on https://en.m.wikipedia.beta.wmflabs.org/ and it doesn't include the wmf_key=minerva which is on the current link. We need that to be able to distinguish Minerva and Vector donations on the fundraising side.

Mar 17 2025, 3:49 PM · Patch-For-Review, Web-Team-Roadmap, Epic, FY2024-25 WE3.2 Donation Entry Points

Mar 14 2025

Pcoombe closed T388796: CSP violation on donatewiki for trustly assets as Resolved.

Thanks for flagging. Trustly suggested we use their hosted image in case they change the bank logos included. However it hasn't changed in the months we've been using it, and we will definitely need to host the image for banners locally anyway. So I uploaded this one to donatewiki as well, and switched our button to use the local copy.

Mar 14 2025, 4:48 PM · Fundraising-Backlog

Mar 12 2025

Pcoombe added a comment to T388263: Persian translation not showing in Central Notice banner.

I don't think a separate banner is needed, the standard IWD2025 banner on ar.wikipedia looks okay to me. The main <html> element will have the correct direction for the site language, and then the centralnotice will inherit from that. Not sure why that advice is in the community template.

Mar 12 2025, 9:30 PM · MediaWiki-extensions-CentralNotice
Pcoombe closed T367189: CentralNotice admin interface issues in dark mode as Resolved.

And this is finally deployed! Thanks! As said the jquery ui elements are still light, but perfectly usable. And they really should be replaced anyway (T185913) so I don't think it matters.

Mar 12 2025, 6:44 PM · MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), Patch-For-Review, MW-1.43-notes (1.43.0-wmf.26; 2024-10-08), dark-mode, MediaWiki-extensions-CentralNotice
Pcoombe closed T74421: Multiselects in Special:CentralNotice sometimes load incorrectly, a subtask of T172024: EPIC: CentralNotice: Tracking: Issues related to old JS widgets in Admin UI, as Resolved.
Mar 12 2025, 6:38 PM · Epic, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Pcoombe closed T74421: Multiselects in Special:CentralNotice sometimes load incorrectly as Resolved.

I haven't seen this in a long time, and can no longer reproduce when throttling the network connection. Closing as resolved, but we should try to move away from these multiselects anyway e.g. T185913: CentralNotice: Replace date picker and multiselect widgets with OOUI widgets in Admin UI

Mar 12 2025, 6:38 PM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Google-Chrome

Mar 11 2025

Pcoombe added a comment to T90863: BUG: CentralNotice banner translations sometimes go missing from Translate interface.
Mar 11 2025, 3:05 PM · Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-Translate, Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Mar 10 2025

Pcoombe added a comment to T388263: Persian translation not showing in Central Notice banner.

I'm confused about how any of the translations work here. Translations are all on the IWD2023 banner, but the IWD2025 banners only use the standard {{{headline}}} etc in the code so I'm not sure how they are pulling in the correct translations?

Mar 10 2025, 10:18 PM · MediaWiki-extensions-CentralNotice
Pcoombe closed T311250: Portal search URLs contain duplicate 'language' parameter as Resolved.
Mar 10 2025, 6:21 PM · Discovery-ARCHIVED, Wikimedia-Portals
Pcoombe closed T369980: Incorrect thousands separator for user preference languages on https://www.wikipedia.org as Resolved.
Mar 10 2025, 6:17 PM · Wikimedia-Portals
Pcoombe closed T386504: Add tracking info to donate link on wikimedia.org as Resolved.
Mar 10 2025, 6:15 PM · Wikimedia-Portals