Tue, Oct 15
Well darn, thanks to T182549 I didn't get notified about this task until David's comment. I've requested access to the copy and will prep a patch for this soon.
Thanks @Nuria !
Fri, Oct 11
@kaythaney Sorry for the delay on this. I've updated donatewiki with the changes requested: https://donate.wikimedia.org/?utm_medium=endowment. Let me know if this looks okay.
Thu, Oct 10
Tue, Oct 8
Don't have time to play around with this now, but maybe it has the same solution as T234953 i.e. add width and height attributes to the <svg>
Japan is done. There were a surprisingly low number of donations, it's not clear why. Results from the test are [here].(https://docs.google.com/spreadsheets/d/1cHQhoMOYTTWnHZNH8V1d64DhHrZ79iBIz9KLEl-Q-Gc/edit#gid=1305301970)
This should be fixed now. Internet Explorer needed the width and height attributes set on the <svg> elements directly, without that they were displaying too wide and pushing the other logos out of view.
Oof, looks like an issue in IE11. I'll look into it ASAP.
We're in peak fundraising season now, and I'm worried this might affect links to https://donate.wikimedia.org.
Wed, Oct 2
Mon, Sep 30
Fri, Sep 20
Thu, Sep 19
Just made a test endowment donation and confirmed I get the new email. Thanks!
@jrobell No, this was just a test from the staging environment. It still needs to be deployed to production which will make it the email donors actually get.
Wed, Sep 18
@kaythaney I just sent you a couple of test emails, one with a named donor and one anonymous. Please can you check these and confirm if they look correct?
An update on this, it's in review but testing is blocked by a bug we found (T232504: 500 error when testing Endowment thank you emails in Civi). I believe Elliott is working on fixing that this sprint.
Tue, Sep 17
After discussing this further today, we decided to go ahead and make the logos the default. I have now done this: diff
I took a more in-depth look at the results from Spain, and see no statistically significant differences from adding the logos in:
- share of card donations
- amounts given
This is now on by default
Sep 16 2019
Sep 13 2019
This looks identical to the text we currently have in banners: https://en.wikipedia.org/wiki/NASA?banner=B1920_0701_enWW_dsk_p1_lg_template&country=IN
Sep 11 2019
Sorry, this one was my fault. I recently added code in CoreJS to block typing letters in the "other monthly amount" field, which was a bug one of the QA specialist candidates spotted. But this throws an error if that field doesn't exist in the banner, i.e. before the introduction of the upsell. The much older banners were still working as they don't include this CoreJS.
Sep 10 2019
Ooh, I notice this label variant fixes T169797: Inconsistent order of payment field errors too!
Sep 9 2019
This is fixed in current best, I realised we could just re-use frb.shouldShowRecurring() from CoreJS. Cleaned them all up to use the same method.
Sep 8 2019
Sep 5 2019
I'll prepare a patch for this, as a chance to test the new direct git method.
Sep 3 2019
Sep 2 2019
Fixed with this change
Agree with closing this, the banners have changed significantly since 2015.
Aug 30 2019
Wonderful, thanks for fixing so quickly!
Aug 29 2019
Thanks for spotting this and reproducing! It's a donatewiki issue, fr-creative will sort it.
Aug 28 2019
We could add the buttons to banners quite easily. However it would need fr-tech work if we want to then remove the choice on the second screen.
Aug 27 2019
@scervantes That will do for testing responsiveness. I have an iPad so will check out the touch-friendliness.
Also don't offer it for certain methods e.g. Credit Card in France (where it's Adyen, which doesn't offer recurring)
Thanks for spotting this and researching it! I created T231325: Check UX of desktop fundraising banners on iPad for the banner team to prepare for this change. Will start an email thread with fr-ops about this too, as some iPad traffic moving from "mobile" to "desktop" might affect our projections.
Aug 22 2019
This happened last year :)
T229932 was resolved, the error message was given an extra parameter for max USD amount. I did the work on banners and donatewiki to move the max amount into a variable and update the error message handling.
That's good to know, thanks @Ejegg!
We decided to do this instead by passing a custom variable containing country to the survey.
Aug 21 2019
I updated all the donatewiki form amounts to match current best banner amounts (where we have them).
Aug 20 2019
Closing this since it stopped happening, and we no longer use catchpoint.
Fixed now, thanks for the report!
Aug 14 2019
Fixed all these. Some of the monthly amount errors in banners were still using DonationInterface messages, I changed them to use the ones from FR2015_translations instead.
Aug 13 2019
Well that was easy enough - diff.
Aug 10 2019
You can select languages with the Tab key, but it would be nice if cursor keys worked too.
Aug 9 2019
Aug 8 2019
Changed all current best banners to use type="text" and inputmode="decimal", since this is supported in Chrome and the current version of Mobile Safari. "Can I use" estimates support at >83% of tracked mobile browsers.
Aug 7 2019
We have this on all banners now.
Aug 6 2019
The formatting in the template is correct, and test emails in pt and pt-br both look good with a link to https://donate.wikimedia.org/wiki/Matching_Gifts.
Aug 5 2019
Doesn't seem to have been fixed in the recent re-write
Did a significant re-write of the desktop large banner scrolling behaviour, and this is now fixed.
Fixed in latest banner versions, by giving other steps visibility: hidden;
Fixed in latest banner versions.
Tested a campaign on aa.wikipedia.org with banner history logger enabled, and this looks good now. Thanks @AndyRussG !
Jul 19 2019
Jul 17 2019
No, I can see mw.centralNotice.bannerHistoryLogger on both beta cluster and production now.
Jul 16 2019
Any dynamic content for the TY page is going to need both an appropriate parameter passed in the URL (fr-tech work) and changes to the TY page itself to take account of that (creative work). Currently the only dynamic content we have is showing/hiding certain messages based on country and payment method.