User Details
- User Since
- Feb 20 2019, 9:17 PM (270 w, 3 d)
- Availability
- Available
- LDAP User
- Tsevener
- MediaWiki User
- TSevener (WMF) [ Global Accounts ]
Fri, Apr 26
@JTannerWMF Can we close this? All the items are checked off.
Going to close this one, as we have bigger fish to fry with technical debt and I don't expect us to pick this up anytime soon. In the meantime, delegates of the button can provide an empty implementation if they don't need to react to the accessibility tap. We should eventually consider a consistent, (ideally) built-in approach to handling all impressions and button taps for logging purposes.
Note: This can be re-tested in TestFlight Wikipedia app 7.5.0 (3509).
@ABorbaWMF This one may be difficult to trigger in Wikipedia 7.5.0 (3509). Please see task description for an alternative way to test this.
Confirmed that the app is sending these calls and receiving a 200 (success) response. That is the most testing we can do here. Moving into Ready for Release.
Build is TestFlight 7.5.0 (3509) for beta testing validation.
I'm going to skip the QA column - Shay can validate the beta data with T362723.
Thu, Apr 25
@ABorbaWMF Looks like this also was fixed in later builds. Please retest in Staging 7.4.11 (78). Thanks! 🙏
@ABorbaWMF Good catch! I can repro on Staging 7.4.11 (75), but not on Staging 7.4.11 (78), so my hope is that we fixed it when wrapping up the remaining work. 🤞 Can you test again on Staging 7.4.11 (78)?
Just some background here:
The "Suggested Edits" toggle at the bottom from your screenshot represents the Add an Image card. See https://phabricator.wikimedia.org/T356811#9592178 for reference. Let me know if it's not working as expected - thanks!
Wed, Apr 24
Can be tested in Staging 7.4.11 (78).
Can be tested in Staging 7.4.11 (78).
Tue, Apr 23
Development work is done - just waiting on dependent PRs to get merged before creating PR for this.
Can be tested in Staging build 7.4.11 (77).
This will be available to test in the main Wikipedia TestFlight build 7.4.11 (3492).
Can be tested in Staging build 7.4.11 (77).
@OTichonova ah good catch, sorry I missed that! Here's some screenshots of the latest:
Can be tested on Staging 7.4.11 (76).
Fri, Apr 19
This is mostly done - progress is in the image-rec/metrics branch. I have a couple of questions for @SNowick_WMF as comments in the deck. Once those are cleared up I can wrap this up next week.
Thu, Apr 18
@OTichonova Please design review in Experimental build #116. Thanks!
Waiting on T354219 getting merged for final design review.