User Details
- User Since
- Feb 20 2019, 9:17 PM (312 w, 1 d)
- Availability
- Available
- LDAP User
- Tsevener
- MediaWiki User
- TSevener (WMF) [ Global Accounts ]
Yesterday
This is merged into a feature branch (temp-accounts). We will move to QA once the feature is complete and the branch is merged into main.
Wed, Feb 12
PR was merged. Nothing to test for this one, as it only affects unit tests.
@SNowick_WMF I'm checking back to the release before system nav bar (7.6.4), and the only action I see logged from Places in ios_search is action=didyoumean source=places. I suspect action=start source=places was never logged, can you confirm? We can add it, just want to make sure this would be a new event first.
I think places search might be some values that may have been dropped in our 7.7.0 release when we switched to system nav bar, I'll do some more digging.
Tue, Feb 11
@HNordeenWMF 7.7.1 (4944) is what will be released to users, sorry about the branch mixup.
@Chandrapg Nice! This is looking good to me so far. Can you put up a PR so we can dig into it further? Thank you!
Mon, Feb 10
Yeah, I think it was like that already in 7.7.0 — I haven’t noticed it until recently – my bad!
I will let @Mazevedo look into #1.
We won't be able to test the launch event, because we won't be able to enable the developer settings "Send analytics to wmflabs" toggle before this launch event is recorded (which is...upon launch, before you can reach the dev settings screen). So moving this into PM Signoff - the best way to confirm this is happening is via external beta testers.
Fri, Feb 7
Sorry there was some mixup here - this work was pretty much done within system nav bar, only hidden. I exposed it with with the work in T383829. Moving to Waiting for Build.
Thu, Feb 6
Just jotting down my theory, though I still can't reproduce so I can't be sure it will fix it.
Note my first PR in T384510 has downstream effects on this one (it takes steps towards moving recently searched into SwiftUI), so I'm moving this to blocked until that is merged.
Part 1 PR: https://phabricator.wikimedia.org/T384510
Wed, Feb 5
@scblr I brought it down to 18 actually for this build, it looked to me like that would match the Figma size more (which looked like a height of 17.5-ish for the logo). Here's screenshots of different options:
Whoops - ignore my previous comment, the screens are listed right there in the task description. 🤦♀️
Tue, Feb 4
@scblr Ok, this is in Experimental build 7.7.1 (220) for design review.
@scblr Ok, this is in Experimental build 7.7.1 (220) for design review.
@scblr FYI, updated the task description to reflect what we last talked about. I will make an official design review build for your final review soon. Thanks!