⚓ T358910 [M] Open image full screen for Image Recs

	Subject	Repo	Branch	Lines +/-
	Revert "styles: Remove transparent PNG fallback for `.vector-icon`"	mediawiki/skins/Vector	wmf/1.44.0-wmf.18	+6 -0
	Revert "styles: Remove transparent PNG fallback for `.vector-icon`"	mediawiki/skins/Vector	master	+6 -0

Status	Assigned	Task
Resolved	None	T344258 [Main Epic] 2023-2024 Enhancements to Editing on the iOS app
Resolved	None	T355270 [Sub Epic] Image Recommendations - Add an Image on iOS
Resolved	None	T355271 [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions
Resolved	HNordeenWMF	T358910 [M] Open image full screen for Image Recs

HNordeenWMF created this task.Mar 1 2024, 9:23 PM

HNordeenWMF mentioned this in T358913: [S] Open Image's Commons page in Webview for Image Recs.Mar 1 2024, 9:32 PM

HNordeenWMF mentioned this in T355271: [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions.Mar 2 2024, 12:02 AM

Seddon moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS Release FY2023-24 (Archive) board.Mar 5 2024, 2:43 PM

Tsevener renamed this task from [S] Open image full screen for Image Recs to Open image full screen for Image Recs.Mar 5 2024, 4:55 PM

JTannerWMF triaged this task as Medium priority.Mar 5 2024, 7:13 PM

JTannerWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

Seddon moved this task from Engineering Backlog to iOS Release FY2023-24 on the Wikipedia-iOS-App-Backlog board.Mar 8 2024, 10:45 AM

Seddon edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2023-24); removed Wikipedia-iOS-App-Backlog.

Seddon moved this task from Tasks from Product Backlog to Needs Engineering Sync on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 8 2024, 11:07 AM

Tsevener renamed this task from Open image full screen for Image Recs to [M] Open image full screen for Image Recs.Mar 19 2024, 5:28 PM

Tsevener moved this task from Needs Engineering Sync to Ready for Development on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener claimed this task.Mar 22 2024, 6:56 PM

Tsevener moved this task from Ready for Development to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4789

@OTichonova New experimental build kicked off for design review of this one - #98.

Tsevener removed Tsevener as the assignee of this task.Mar 22 2024, 9:44 PM

Tsevener moved this task from Doing to Needs Design Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener subscribed.

OTichonova moved this task from Needs Design Review to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 23 2024, 12:11 AM

staykids closed https://github.com/wikimedia/wikipedia-ios/pull/4789

Mazevedo moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 28 2024, 10:20 PM

Tsevener updated the task description. (Show Details)Apr 16 2024, 2:11 PM

Tsevener moved this task from Waiting for Build to Needs QA on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener updated the task description. (Show Details)Apr 26 2024, 3:18 PM

Working for me on 7.5.0 (3512)

The image preview does not remove the "Share" option from the standard image preview as shown in the designs, but core functionality is there for zooming, accessing meta-data, and opening commons listing as required.

A later-on improvement would be adding an entry point to the full-screen view from the "Add image details" screen.

HNordeenWMF mentioned this in T364165: [M] Allow user to open image full-screen from Add Image Details / Media Details.May 3 2024, 5:39 PM

HNordeenWMF closed this task as Unknown Status.May 7 2024, 3:49 PM

HNordeenWMF claimed this task.

HNordeenWMF changed the task status from Unknown Status to Resolved.May 7 2024, 10:20 PM

Change #1123004 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Revert "styles: Remove transparent PNG fallback for `.vector-icon`"

https://gerrit.wikimedia.org/r/1123004

gerritbot added a project: Patch-For-Review.Feb 26 2025, 5:23 PM

Change #1123004 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Revert "styles: Remove transparent PNG fallback for `.vector-icon`"

https://gerrit.wikimedia.org/r/1123004

Change #1123713 had a related patch set uploaded (by Jdlrobson; author: Esanders):

[mediawiki/skins/Vector@wmf/1.44.0-wmf.18] Revert "styles: Remove transparent PNG fallback for `.vector-icon`"

https://gerrit.wikimedia.org/r/1123713

Change #1123713 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.44.0-wmf.18] Revert "styles: Remove transparent PNG fallback for `.vector-icon`"

https://gerrit.wikimedia.org/r/1123713

Mentioned in SAL (#wikimedia-operations) [2025-03-04T21:15:21Z] <jforrester@deploy2002> Started scap sync-world: Backport for [[gerrit:1123713|Revert "styles: Remove transparent PNG fallback for .vector-icon" (T358910 T387351)]]

Stashbot mentioned this in T387351: [regression] ToC icons appears as black squares while assets are loading.Mar 4 2025, 9:15 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-04T21:18:23Z] <jforrester@deploy2002> jforrester, jdlrobson: Backport for [[gerrit:1123713|Revert "styles: Remove transparent PNG fallback for .vector-icon" (T358910 T387351)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-03-04T21:25:34Z] <jforrester@deploy2002> Finished scap sync-world: Backport for [[gerrit:1123713|Revert "styles: Remove transparent PNG fallback for .vector-icon" (T358910 T387351)]] (duration: 10m 13s)

[M] Open image full screen for Image Recs
Closed, ResolvedPublic
Actions

Description

Requirements

Testing

Details

Related Objects
Search...

Event Timeline

	F42305228: image.png
	Mar 1 2024, 9:23 PM

[M] Open image full screen for Image RecsClosed, ResolvedPublicActions