[S] Open Image's Commons page in Webview for Image Recs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	HNordeenWMF
	Mar 1 2024, 9:32 PM

Description

Open image Commons page Figma reference

Requirements

Webview of commons entry for suggested image displays after user taps on external image link
Should be an in-app webview
User can navigate using Back to suggested edit flow

Testing

Please test in TestFlight Wikipedia app 7.5.0 (3509).

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T344258 [Main Epic] 2023-2024 Enhancements to Editing on the iOS app
Resolved	None	T355270 [Sub Epic] Image Recommendations - Add an Image on iOS
Resolved	None	T355271 [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions
Resolved	HNordeenWMF	T358913 [S] Open Image's Commons page in Webview for Image Recs

Event Timeline

HNordeenWMF created this task.Mar 1 2024, 9:32 PM

HNordeenWMF updated the task description. (Show Details)Mar 1 2024, 9:38 PM

HNordeenWMF updated the task description. (Show Details)

HNordeenWMF mentioned this in T355271: [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions.Mar 2 2024, 12:02 AM

Seddon moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS Release FY2023-24 (Archive) board.Mar 5 2024, 2:43 PM

Tsevener renamed this task from [S] Go to the commons page on Webview for Image Recs to Go to the commons page on Webview for Image Recs.Mar 5 2024, 4:55 PM

Mazevedo renamed this task from Go to the commons page on Webview for Image Recs to Open Image's Commons page in Webview for Image Recs.Mar 5 2024, 6:40 PM

Mazevedo updated the task description. (Show Details)

Mazevedo removed subscribers: Jarrod_Baniqued, ldelench_wmf.

JTannerWMF triaged this task as Medium priority.Mar 5 2024, 7:14 PM

JTannerWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

Seddon moved this task from Engineering Backlog to iOS Release FY2023-24 on the Wikipedia-iOS-App-Backlog board.Mar 8 2024, 10:45 AM

Seddon edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2023-24); removed Wikipedia-iOS-App-Backlog.

Seddon moved this task from Tasks from Product Backlog to Needs Engineering Sync on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 8 2024, 11:07 AM

Tsevener renamed this task from Open Image's Commons page in Webview for Image Recs to [M] Open Image's Commons page in Webview for Image Recs.Mar 19 2024, 5:31 PM

Tsevener renamed this task from [M] Open Image's Commons page in Webview for Image Recs to [S] Open Image's Commons page in Webview for Image Recs.

Tsevener moved this task from Needs Engineering Sync to Ready for Development on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener claimed this task.Mar 25 2024, 3:16 PM

Tsevener moved this task from Ready for Development to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4791

@OTichonova Experimental build #99 kicked off for your design review.

Tsevener removed Tsevener as the assignee of this task.Mar 25 2024, 3:39 PM

Tsevener moved this task from Doing to Needs Design Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener subscribed.

Hi @Tsevener, minor thing -> can the copy be 'Back' rather than 'Add image' when tapping back from the commons page?

OTichonova moved this task from Needs Design Review to Ready for Development on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 25 2024, 5:16 PM

@OTichonova Good catch - this is done. Here's a couple of screenshots. I used "Back" when pushing on the Article view as well:

Screenshot 2024-03-25 at 1.37.31 PM (1×559 px, 569 KB)

Screenshot 2024-03-25 at 1.37.38 PM (1×559 px, 283 KB)

@Tsevener great thanks!

staykids closed https://github.com/wikimedia/wikipedia-ios/pull/4791

• Dmantena moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 29 2024, 8:36 PM

Tsevener updated the task description. (Show Details)Apr 16 2024, 2:11 PM

Tsevener moved this task from Waiting for Build to Needs QA on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener updated the task description. (Show Details)Apr 26 2024, 3:18 PM

Looks good on 7.5.0 (3525)

I noticed an issue with the search option not working any more from this view.
From image recs: Commons page > Search icon >

From elsewhere: Commons page > Search icon>

Not a blocker to release as we wouldn't expect many folks to search for something else while in the flow, task: T363942

@HNordeenWMF 👍 Good catch!

HNordeenWMF removed a subtask: T363942: Commons view search field not displaying within Image Recs.May 3 2024, 5:06 PM

HNordeenWMF mentioned this in T364165: [M] Allow user to open image full-screen from Add Image Details / Media Details.May 3 2024, 5:39 PM

HNordeenWMF closed this task as Unknown Status.May 7 2024, 3:49 PM

HNordeenWMF claimed this task.

HNordeenWMF changed the task status from Unknown Status to Resolved.May 7 2024, 10:19 PM

	F43355761: Screenshot 2024-03-25 at 1.37.38 PM
	Mar 25 2024, 6:39 PM

	F43355749: Screenshot 2024-03-25 at 1.37.31 PM
	Mar 25 2024, 6:39 PM

	F49663852: IMG_6148.PNG
	May 1 2024, 5:25 PM

	F49663875: IMG_6149.PNG
	May 1 2024, 5:25 PM

	F42305769: image.png
	Mar 1 2024, 9:39 PM

[S] Open Image's Commons page in Webview for Image RecsClosed, ResolvedPublicActions